From 807c8e735761a950774fe70611778bcd97b655e3 Mon Sep 17 00:00:00 2001 From: "Carsten Haitzler (Rasterman)" Date: Sat, 10 Aug 2019 23:27:24 +0100 Subject: [PATCH] eina file - don't double unlock a lock thanks to coverity - found this double unlock path in case of error. fix CID 1403899 --- src/lib/eina/eina_file.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/lib/eina/eina_file.c b/src/lib/eina/eina_file.c index e334beaf21..f4d0e7221c 100644 --- a/src/lib/eina/eina_file.c +++ b/src/lib/eina/eina_file.c @@ -846,10 +846,7 @@ eina_file_open(const char *path, Eina_Bool shared) { n = malloc(sizeof(Eina_File)); if (!n) - { - eina_lock_release(&_eina_file_lock_cache); - goto on_error; - } + goto on_error; memset(n, 0, sizeof(Eina_File)); n->filename = filename;