vtorri
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

DnD: cancel drag if mouse moves too much 

In the case of an entry inside a draggable gengrid, trying to select
text was always resulting in starting a DnD operation because mouse
coordinates were not checked.

Now we check that the mouse coords don't move more than a finger size.

@fix
This commit is contained in:
Daniel Zaoui 2016-11-10 08:20:10 +02:00
parent 1dfdb9ebd9
commit 819c14c86f
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/lib/elementary/elm_cnp.c
View File

@ -5543,10 +5543,13 @@ static void
_cont_obj_mouse_move(void *data, Evas *e EINA_UNUSED, Evas_Object *obj EINA_UNUSED, void *event_info)
{ /* Cancel any drag waiting to start on timeout */
cnp_debug("In\n");
if (((Evas_Event_Mouse_Move *)event_info)->event_flags & EVAS_EVENT_FLAG_ON_HOLD)
Item_Container_Drag_Info *st = data;
Evas_Event_Mouse_Move *ev = event_info;
int dx = ev->cur.canvas.x - st->x_down, dy = ev->cur.canvas.y - st->y_down;
int finger_size = elm_config_finger_size_get();
if (ev->event_flags & EVAS_EVENT_FLAG_ON_HOLD || (dx * dx + dy * dy > finger_size * finger_size))
{
cnp_debug("event on hold - have to cancel DnD\n");
Item_Container_Drag_Info *st = data;
cnp_debug("event on hold or mouse moved too much - have to cancel DnD\n");
evas_object_event_callback_del_full
(st->obj, EVAS_CALLBACK_MOUSE_MOVE, _cont_obj_mouse_move, st);