From be63db00a71bf1b5b3da59c29e0b3fb569b0ba90 Mon Sep 17 00:00:00 2001 From: Subodh Kumar Date: Fri, 13 Oct 2017 11:46:28 -0700 Subject: [PATCH] eina: comparing unsigned integer with less than zero. Summary: Unsigned integer should not be compared less than zero. Test Plan: NA Reviewers: cedric Subscribers: shilpasingh, jpeg Differential Revision: https://phab.enlightenment.org/D5274 Signed-off-by: Cedric Bail --- src/lib/eina/eina_share_common.c | 2 +- src/lib/eina/eina_strbuf.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/lib/eina/eina_share_common.c b/src/lib/eina/eina_share_common.c index 6ad55b7053..e7ba2a72d2 100644 --- a/src/lib/eina/eina_share_common.c +++ b/src/lib/eina/eina_share_common.c @@ -740,7 +740,7 @@ eina_share_common_add_length(Eina_Share *share, eina_share_common_population_add(share, slen); - if (slen <= 0) + if (slen == 0) return NULL; hash = eina_hash_superfast(str, slen); diff --git a/src/lib/eina/eina_strbuf.c b/src/lib/eina/eina_strbuf.c index f18408d59e..a76e4418ea 100644 --- a/src/lib/eina/eina_strbuf.c +++ b/src/lib/eina/eina_strbuf.c @@ -94,7 +94,7 @@ eina_strbuf_append_printf(Eina_Strbuf *buf, const char *fmt, ...) len = vasprintf(&str, fmt, args); va_end(args); - if (len <= 0 || !str) + if (len == 0 || !str) return EINA_FALSE; ret = eina_strbuf_append_length(buf, str, len); @@ -111,7 +111,7 @@ eina_strbuf_append_vprintf(Eina_Strbuf *buf, const char *fmt, va_list args) len = vasprintf(&str, fmt, args); - if (len <= 0 || !str) + if (len == 0 || !str) return EINA_FALSE; ret = eina_strbuf_append_length(buf, str, len); @@ -131,7 +131,7 @@ eina_strbuf_insert_printf(Eina_Strbuf *buf, const char *fmt, size_t pos, ...) len = vasprintf(&str, fmt, args); va_end(args); - if (len <= 0 || !str) + if (len == 0 || !str) return EINA_FALSE; ret = eina_strbuf_insert(buf, str, pos); @@ -151,7 +151,7 @@ eina_strbuf_insert_vprintf(Eina_Strbuf *buf, len = vasprintf(&str, fmt, args); - if (len <= 0 || !str) + if (len == 0 || !str) return EINA_FALSE; ret = eina_strbuf_insert(buf, str, pos);