Summary: API to get list of ctxpopup items and give the possibility to iterate the ctxpopup items
Reviewers: stanluk, z.kosinski, Hermet, seoz, raster
CC: Hermet, seoz
Differential Revision: https://phab.enlightenment.org/D1055
Summary: The focus of genlist should adjust its position on resizing(shrinking).
Reviewers: seoz
Differential Revision: https://phab.enlightenment.org/D1072
this matches the 8edc879cc2 commit in
efl where edje file changed singals are now gone. this creates nothing
but trouble. please see the efl commit log for details.
This implements scrollable interface in elm_panel so that users can drag open/close panel.
Tap & hold on the edge and panel handler will appear.
Left scrollable panel is implemented in elementary_test > Panel Scrollable.
@feature
elm_widget_tree_unfocusable_set with EINA_TRUE sets focus to the newest
focused object. If prev item is tree_focusable, one of its children can
get focus. This focus movement is unexpected, so should not be happened.
The division by zeor could happen when zoom_cnt is zeor OR when region_cnt
is zero. No need for both cases. In the curent implementation this is
impossible as both are hard coded defines. But code changes so we should
handle this.
CID: 1216619
Summary: Added possibility to set the minimum size of the left and right sides.
Reviewers: raster, cedric, seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D998
Summary:
without given state Orca screen reader deafult script interpret
widget as 'grayed out'.
Test Plan: orca screen reader tests on ubuntu 13.10 with orca 3.10.1
Reviewers: raster, seoz, z.kosinski
Differential Revision: https://phab.enlightenment.org/D983
Summary: should do scrollable_content_set according to focus_region_get
Test Plan: None
Reviewers: woohyun
Differential Revision: https://phab.enlightenment.org/D981
Summary:
During drag, dragwin should be rotated when main window is rotated.
@fix
Reviewers: raster, JackDanielZ, woohyun
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D976
Summary:
If focus is set on item content object, it's treated as a
different object which results the focus deadlock. So, every
time whenever focus sets on item content object, we need to
unset and set the focus on genlist object. Thanks to Seoz for
the idea.
Test Plan: elementary_test -to "list focus"
Reviewers: seoz, SanghyeonLee, eagleeye
CC: seoz
Differential Revision: https://phab.enlightenment.org/D973
Summary:
Upon focus set, if the item content object is not of type widget
(could be of type Evas_Rectnagle) focus set/get is not possible.
ERR<17428>:eo lib/eo/eo.c:603 _eo_call_resolve() in elm_widget.eo.c:112: you called func 'elm_obj_widget_can_focus_get' (239) which is unknown in class 'Evas_Rectangle'.
ERR<17428>:eo lib/eo/eo.c:788 _eo_api_op_id_get() in elm_widget.eo.c:212: unable to resolve regular api func 'elm_obj_widget_child_can_focus_get' 0xb75e6f40 in class 'Evas_Rectangle'
Test Plan: elementary_test -to "list focus" (make focus_on_selection enabled and give a right key event when a content object is focused)
Reviewers: seoz, SanghyeonLee, eagleeye
CC: seoz
Differential Revision: https://phab.enlightenment.org/D972
Summary:
Method is required by AT-SPI clients when interface caching is disabled.
Method is not listed in any at-spi specification - found during fixing
clients behaviour.
Reviewers: raster, seoz, z.kosinski
Reviewed By: z.kosinski
Differential Revision: https://phab.enlightenment.org/D971
Summary:
According to the current elm_win code, client side border should be removed
when window is fullscreen mode. And border couldn't be shown on window
during fullscreen mode. When window is going into normal mode from fullscreen,
then display of border should be determined by its borderless state.
1. client border should be shown when window is going into normal mode from fullscreen with borderless state.
2. client border shouldn't be shown when window is going into normal mode from fullscreen with border state.
3. and also client border shouldn't be shown when window is fullscreen mode.
@fix
Test Plan:
1. run elementary_test in wayland server
2. run window states
3. select borderless
4. select fullscreen
5. unselect fullscreen
6. unselect borderless
Reviewers: raster, devilhorns, seoz
Differential Revision: https://phab.enlightenment.org/D988
Summary:
The focus of genlist was coming out of genlist's viewport area on resizing(shrinking).
This is fixed in this patch.
Test Plan: elementary_test -to genlist5, elementary_test -to fileselector
Reviewers: seoz, singh.amitesh, nirajkr
Differential Revision: https://phab.enlightenment.org/D949
Summary:
If item loop is enabled, the item moves infinitely in
horizontal manner (from right to left and from left to
right).
Need to implement:
-for reorder mode and horizontal mode.
@feature
DEPENDs On D841
Test Plan: elementary_test -to gengrid2
Reviewers: seoz, eagleeye, SanghyeonLee, raster
CC: seoz, raster
Differential Revision: https://phab.enlightenment.org/D842
Conflicts:
src/lib/elm_gengrid.c
Summary:
Added fixes for:
1.Normal mode: ELM_FOCUS_DOWN and ELM_FOCUS_UP
2.Horizontal mode: ELM_FOCUS_DOWN and ELM_FOCUS_UP
(i)
1|2|3
4|5|6
7|8|9
_elm_gengrid_item_edge_check for ELM_FOCUS_DOWN returns EINA_TRUE for item no.6.
It should not. Fixed this.
(ii)
1|2|3
4|5|6
7
_elm_gengrid_item_edge_check returns EINA_FALSE for ELM_FOCUS_DOWN
for item no. 5 and 6 but EINA_TRUE for item no. 7.
It should return EINA_TRUE for item no. 5 and 6 instead.
Fixed this.
(iii)
1|2|3
4|
_elm_gengrid_item_edge_check returned EINA_FALSE for ELM_FOCUS_UP
for item no. 3. Fixed this.
(iv)
1|4|7
2|5|
3|6|
Horizontal Mode: _elm_gengrid_item_edge_check returned EINA_FALSE
for ELM_FOCUS_DOWN for item no. 7. Fixed this.
(v)
1|4|7
2|5|
3|6|
Horizontal Mode: _elm_gengrid_item_edge_check returned EINA_FALSE
for ELM_FOCUS_UP for item no. 1. Fixed this.
Test Plan: elementary_test -to gengrid2
Reviewers: seoz, raster
CC: singh.amitesh, raster
Differential Revision: https://phab.enlightenment.org/D841
Conflicts:
src/lib/elm_gengrid.c
Summary: This example shows the mechanism of elementary widget (button) adding to the 3d scene object.
Reviewers: Hermet, cedric, raster
Differential Revision: https://phab.enlightenment.org/D937
Signed-off-by: Cedric BAIL <c.bail@partner.samsung.com>
Summary: This example shows the mechanism of scene object adding to the widget button.
Reviewers: Hermet, cedric, raster
Differential Revision: https://phab.enlightenment.org/D914
Summary:
Previously there was no focus_direction & focus_next.
These functions are added in filesector winset for currect focus movement inside the winset.
Test Plan: elementary_test->"fileselector"
Reviewers: raster, seoz, nirajkr, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D913
Summary:
By using this API, we can do region show & bring in concurrently.
This needs some tuning more because some main layouting logic in map
needs to be modified to support more smooth animation.
I will spare my time to do that later.
@feature
Reviewers: Hermet, raster, stefan_schmidt
Reviewed By: raster
CC: Jaehyun
Differential Revision: https://phab.enlightenment.org/D887
Summary: This makes inheritance from elementary posible for widget developers
Reviewers: cedric, seoz, raster
CC: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D762
Conflicts:
src/lib/Makefile.am
Summary:
This function allows user to search for item in Genlist.
It takes four search parameters:
1. pointer to function to get text of the item. It could be the same with item's
get_text function. This parameter is added to let user use the specific search key
and to avoid problems with setting item's text, that is not constant.
2. pointer to the item from which search should start.
3. search pattern.
4. fnmatch() flags.
To check it's usage the new test is added to the elementary_test (Genlist Item Search By Text)
Reviewers: cedric, seoz, raster
CC: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D566
Reset the last_focused_item on _item_focus_set_hook.
This fixes the issue which sets the focus to the wrong item when the
focus is set by an API.
Reproduction step:
elementary_test -> genlist focus -> click an item (not the 2nd item) -> click "Focus 2nd
Item after 1.5 seconds" button.
Focus is not moved to the 2nd item.
@fix
Summary:
On focus_on_selection set, the focus set on genlist item of type ELM_GENLIST_ITEM_TREE rather than
on item content objects.
Test Plan: elementary_test -to "genlist focus"
Reviewers: seoz, eagleeye, SanghyeonLee, raster
Reviewed By: raster
CC: seoz
Differential Revision: https://phab.enlightenment.org/D899
Summary:
If focus is set on item content object, it's treated as a
different object which results the focus deadlock. So, every
time whenever focus sets on item content object, we need to
unset and set the focus on genlist object. Thanks to Seoz for
the idea.
Test Plan: elementary_test -to "genlist focus"
Reviewers: seoz, SanghyeonLee, eagleeye
CC: seoz
Differential Revision: https://phab.enlightenment.org/D891
Summary:
Selection handlers' visibility should be updated when entry is hidden or shown
When entry has selection and hidden, the selection handlers should be hidden also.
This fix T1175.
@fix
Reviewers: seoz, woohyun, raster
Reviewed By: raster
Maniphest Tasks: T1175
Differential Revision: https://phab.enlightenment.org/D877
Summary:
Previously in colorclasses.edc border_frame dialog_base along with other base elements were defined to the default font color "White". This means if you change the default font color there are many unrelated side effects.
To fix this issue i have added a new Color define in colorclasses.edc to be used with window related items as opposed to text related items.
Reviewers: raster
CC: seoz, stefan_schmidt
Maniphest Tasks: T1269
Differential Revision: https://phab.enlightenment.org/D879
Summary:
This feature (Clicking on "Enter" key) was previously implemented by using "activate" signal of entry (the one for entering name of the file),
so it was looking like "ok" button was clicked by pushing "Enter" key on the keyboard.
This little feature was added in commit 4d761f3a63270c88fa516764d9288f8bf0ff4a11.
Later the huge feature that adds key binding was implemented (commit 820f3dc907250c0c08ed8431b50567e58d6dab5c for ex).
It allows to bind widgets with keys (certain function calls when certain keys is pressed on keyboard).
This feature also adds same functionality to fileselecter, doing the same as previous (with "activate" signal) one.
Because of that it was looks like "ok" button was clicked twice.
This commit fixes this behavior and removes old and outdated method of "ok" button clicking processing.
@fix
Reviewers: cedric, seoz, raster
CC: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D864
Summary:
Fix to calculator map size not to be smaller than viewport size when zoom mode is either fit or fill.
Previously, map size could be either smaller or larger than viewport.
@fix
Reviewers: Hermet, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D861
Summary:
When gengrid item is reordered or deleted, gengrid didn't update item's position.
This Patch update item's position when item is placed. if middle of item deleted,
every item after the deleted one, will re-postion on _item_place function, so they
will be update there position well.
Test Plan:
modify test_gengrid grid_sel fuction to print there position. so when item selected,
they print there position and it works fine both horizontal and vertical.
Reviewers: bluezery, seoz, raster
Reviewed By: raster
CC: Hermet, chinmaya061
Differential Revision: https://phab.enlightenment.org/D855
Summary: This is an optimization over parent set to hoversel object.
Reviewers: seoz, raster
CC: seoz
Differential Revision: https://phab.enlightenment.org/D853
Summary:
Earlier focus was moving to top item from bottom item on LEFT key and to bottom item on RIGHT Key
in case of vertical hoversel.
@fix
Test Plan: elementary_test -to "Hoversel Focus"
Reviewers: raster, seoz
Reviewed By: seoz
CC: seoz, chinmaya061
Differential Revision: https://phab.enlightenment.org/D858
Summary:
Even if a entry is not editable, user can select text in the entry.
When the entry has selection, we have to support "copy" option.
@fix
Test Plan:
Precondition: Apply D852 patch for fixing a bug in elementary_test
1. elementary_test -to entry7
2. Select some text in the non-editable entry.
3. Press mouse right button.
Note: You can test it in Desktop profile.
Reviewers: tasn, woohyun, seoz
Differential Revision: https://phab.enlightenment.org/D848
Summary:
Fix to skip the item which is disabled and select the next item to the
disabled item
@fix
Reviewers: seoz, raster
CC: seoz, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D700
Since SHADOW adds one pixel padding, the whole object size
was calculated with one extra pixel. Let's add it back
to keep the overall visual balance of buttons.
A few other widgets might visually change after the edje
padding fix:
- Check (looks better)
- Naviframe (smaller height)
- E date widget
- ...
But I did not see anything "weird" that needs fixing.
See EFL 5bf1f0c9187525cf40782b26d7fa49d2676f91bb:
edje_calc: Don't add padding twice to text objects
Text objects declared in Edje will see their padding added twice,
as the Evas_Object_Text itself contains the padding already.
This WILL break some EDC files. It's a bug nonetheless.
Summary:
Show and bring in a region which has the given latitude and longitude after zooming
@fix
Reviewers: Hermet
CC: seoz
Differential Revision: https://phab.enlightenment.org/D851
Summary:
Layout's sub_object_del function calls sizing_eval even if layout's smart_del
function has already been called (Due to widget_smart_del impl).
This patch adds 'destructed_is' flag to Elm_Layout_Smart_Data and prevents unneeded
sizing_eval calls when object is already destructed.
Patch also fixes SIGSEGV in layout derived entry widget caused by calling
sizing_eval after entry_smart_del destructor.
Added entry test to avoid regression for SIGSEGV bug.
Test Plan: run tests/elm_test_entry
Reviewers: raster, seoz, tasn, cedric
Differential Revision: https://phab.enlightenment.org/D823