From 0b69c40d92636c5ded29ed22c8afae3e46965730 Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Thu, 10 Mar 2016 11:21:11 -0500 Subject: [PATCH] resolve harmless coverity reports in wireless module CIDs 1352825, 1352826, 1352827 --- src/modules/wireless/connman.c | 2 +- src/modules/wireless/wireless.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/modules/wireless/connman.c b/src/modules/wireless/connman.c index 662e23a8f..c41a00d1d 100644 --- a/src/modules/wireless/connman.c +++ b/src/modules/wireless/connman.c @@ -1110,7 +1110,7 @@ _connman_dbus_dict_append_array(Eldbus_Message_Iter *array, const char *key, Ein variant = eldbus_message_iter_container_new(dict, 'v', "as"); array2 = eldbus_message_iter_container_new(variant, 'a', "s"); EINA_ARRAY_ITER_NEXT(val, i, str, it) - eldbus_message_iter_basic_append(array2, 's', str ?: ""); + eldbus_message_iter_basic_append(array2, 's', str); eldbus_message_iter_container_close(variant, array2); eldbus_message_iter_container_close(dict, variant); eldbus_message_iter_container_close(array, dict); diff --git a/src/modules/wireless/wireless.c b/src/modules/wireless/wireless.c index 58ca034df..d7f86b369 100644 --- a/src/modules/wireless/wireless.c +++ b/src/modules/wireless/wireless.c @@ -380,6 +380,7 @@ _wireless_array_notequal(Eina_Array *a, Eina_Array *b) unsigned int i; if ((!!a) != (!!b)) return EINA_TRUE; + if ((!a) && (!b)) return EINA_FALSE; if (eina_array_count(a) != eina_array_count(b)) return EINA_TRUE; for (i = 0; i < eina_array_count(a); i++) if (eina_array_data_get(a, i) != eina_array_data_get(b, i)) return EINA_TRUE;