From 3d3e5e67fb70223d8f7bf0be1d7d7aea1a8b586f Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Fri, 10 Feb 2017 17:23:43 -0500 Subject: [PATCH] plug list leak in luncher ==25839== 8,576 (6,432 direct, 2,144 indirect) bytes in 134 blocks are definitely lost in loss reco$ ==25839== at 0xE812A41: _eina_chained_mempool_alloc_in (eina_chained_mempool.c:212) ==25839== by 0xE812CD4: eina_chained_mempool_malloc (eina_chained_mempool.c:324) ==25839== by 0xE7CCFED: eina_mempool_malloc (eina_inline_mempool.x:90) ==25839== by 0xE7CD241: _eina_list_mempool_list_new (eina_list.c:213) ==25839== by 0xE7CE044: eina_list_append (eina_list.c:569) ==25839== by 0x29E2CF07: _bar_check_for_duplicates (bar.c:58) ==25839== by 0x29E30D7F: _bar_cb_exec_client_prop (bar.c:1281) ==25839== by 0xDBD7AF6: _ecore_call_handler_cb (ecore_private.h:317) ==25839== by 0xDBD8A85: _ecore_event_call (ecore_events.c:518) ==25839== by 0xDBE1AEF: _ecore_main_loop_iterate_internal (ecore_main.c:2380) ==25839== by 0xDBDF89D: ecore_main_loop_begin (ecore_main.c:1290) ==25839== by 0x441C04: main (e_main.c:1093) --- src/modules/luncher/bar.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/modules/luncher/bar.c b/src/modules/luncher/bar.c index 43602a3bb..806c0e493 100644 --- a/src/modules/luncher/bar.c +++ b/src/modules/luncher/bar.c @@ -60,7 +60,10 @@ _bar_check_for_duplicates(Icon *ic, E_Client *dupe) EINA_LIST_FREE(clients, ec) { if (ec == dupe) - return EINA_TRUE; + { + eina_list_free(clients); + return EINA_TRUE; + } } return EINA_FALSE; }