Commit Graph

245 Commits

Author SHA1 Message Date
Kim Woelders 3ad01fdda7 focus: IPC help tweaks
- Mention next, prev, and focus mode ?
- Some wording and format changes
2022-04-22 17:00:05 +02:00
Kim Woelders 3c42724f96 Dialog layout adjustments
In general left-align text labels.
2022-04-22 07:41:58 +02:00
Kim Woelders 9c6cd28436 Do focus windows to be manually placed
Broken by ebe82a7bbb, see
https://phab.enlightenment.org/T8973
2021-12-21 06:54:52 +01:00
Kim Woelders 0d6bdb4272 Support _NET_WM_STATE_FOCUSED
GTK apps apparently use this.
2021-08-21 20:57:04 +02:00
Kim Woelders bfe59a8e8f Focus: Debug tweaks 2021-07-15 12:59:58 +02:00
Kim Woelders dd2c51ec75 Focus: Tweak request serial number check logic - correction 2021-04-01 20:43:16 +02:00
Kim Woelders 55872b9db1 Focus: Fixup after "Fix pointer focus on new windows..."
Only do desk switch when focusing new transient.
2021-04-01 20:43:01 +02:00
Kim Woelders 53e15851c9 Focus: Improve debug message understandability 2021-04-01 20:38:40 +02:00
Kim Woelders 358b60baf9 Introduce E_ARRAY_SIZE() and MOD_ITEMS()
Just a bit tidier.
2021-03-19 06:36:46 +01:00
Kim Woelders 136f37f0b9 Focus: Tweak request serial number check logic
Too many Enter events were ignored.
2021-03-16 20:16:05 +01:00
Kim Woelders 01f17e409e Focus: Don't set focus on sliding windows
Focus should be updated when sliding is done.

Probably not much of a problem but seems right.
2021-03-16 20:16:05 +01:00
Kim Woelders ebe82a7bbb Focus: Fix pointer focus on new windows if pointer is in window
In certain situations new windows would not be focused.
2021-03-16 20:16:05 +01:00
Kim Woelders 02f0afd97b Merge variables controlling click-to-raise configuration 2020-06-29 19:47:36 +02:00
Kim Woelders 79711672ab focus.c: Eliminate unnecessary variable 2020-06-27 19:48:16 +02:00
Kim Woelders e6b62914b4 Make "only primary mouse button raises" option take effect immediately 2020-06-23 21:11:13 +02:00
Kim Woelders 0a6b8e177c Add option to allow only the primary mouse button to raise windows
Patch by Simon Kesenci
2020-06-23 21:11:10 +02:00
Kim Woelders c839d0e14a src: Fix clang-analyzer complaints
arrange.c: Highly unlikely, maybe impossible situations

backgrounds.c: False positive (I think)

dialog.c: Fix memleak/segv on realloc failure

focus.c: False positive
	ewin should never be NULL with FOCUS_EWIN_NEW

main.c: False positive
	eoptarg will always be set if argument requires option

menus.c: Fix memleak on malloc failure

session.c: Fix dead assignment

stacking.c: False positive
	Changed code is nicer though

pager.c: False positive
	ewin would never be NULL if hiwin was NULL
	But rearrange for clarity anyway

ecompmgr.c: Avoid bogus issues
2020-01-29 16:43:01 +01:00
Kim Woelders 84788b993c Optionally don't slide in DeskGotoByEwin()
No actual changes yet.
2019-03-05 16:15:28 +01:00
Kim Woelders 982ccfe70e Fix focus-if-group-focused cases
In various cases focus would not be set as intended, at least when
not focus-all-new and
 click-to-focus or
 not click-to-focus and pointer not in new client
2018-03-28 18:46:48 +02:00
Kim Woelders 525e7afc6b focus.c: Cosmetics 2018-03-28 18:43:22 +02:00
Kim Woelders 22de80465d Tweak some (disabled) focus debug stuff. 2017-10-28 09:35:19 +02:00
Kim Woelders 9c31fe29ed Clean up header file inclusion order.
Fixes building with e.g. -std=c99 and c11 by always including config.h
(which defines _GNU_SOURCE) first.
2015-01-17 19:33:42 +01:00
Kim Woelders a9a568ffe3 Debug printout cleanups. 2014-10-17 21:25:12 +02:00
Kim Woelders 23872b2cac Simplify dialog data handling. 2014-04-29 19:42:15 +02:00
Kim Woelders 5fc86cc6ad Refactor dialog apply/exit handling.
Split into separate functions so we don't have to check on val all over
to figure out if it is one or the other.

This also avoids that the apply stuff may be done twice on exit a couple
of places.
2014-04-29 19:42:15 +02:00
Kim Woelders 4d1bde02ae Wrap XID and some other X types.
Mostly to change longs to ints to reduce memory footprint a bit on 64
bit systems.
2014-04-23 19:13:00 +02:00
Kim Woelders ceb0c5aa3f Enable not using a container window.
When not using the container window, client windows are reparented to
the frame window, not to a container window which is a child of the
frame window.

SVN revision: 83374
2013-01-27 21:00:54 +00:00
Kim Woelders 5b3556e386 Wrap XAllowEvents().
SVN revision: 81752
2012-12-27 18:21:48 +00:00
Kim Woelders a01c953c54 Wrap some calls to XGrab/UngrabKeyboard() + cosmetics.
SVN revision: 81698
2012-12-25 18:19:59 +00:00
Kim Woelders c8020ed906 Disable "Previously ignored..." debug message.
SVN revision: 80900
2012-12-13 21:32:12 +00:00
Kim Woelders c76b8f6a2a Focus update tweaks.
Disable grab and stacking updates while focus changes are inhibited.

Disable focus changes during desk/area slides (actually, this is not in
play yet, as we don't run the normal event loop during desk/area slides).

SVN revision: 78405
2012-10-24 17:20:28 +00:00
Kim Woelders 4866fdc829 Don't focus window before client window MapNotify is seen.
SVN revision: 62761
2011-08-24 20:45:14 +00:00
Kim Woelders c02f80c23c Fix pointer focus when a new window appears under the pointer.
SVN revision: 61646
2011-07-24 10:20:54 +00:00
Kim Woelders 78fe9e4b5c Fix focus after ungrab.
E.g. after exiting magwin grabbing mode.

Noted by Daniel Manjarres.

SVN revision: 60282
2011-06-13 16:29:00 +00:00
Kim Woelders 34910b33bc Eliminate EwinIsMapped() and EwinGetDesk().
SVN revision: 59969
2011-06-05 14:53:55 +00:00
Kim Woelders a87641f97e Warning fixes for gcc-4.6.
SVN revision: 56392
2011-01-30 00:07:50 +00:00
Kim Woelders f0c0a4519c Change TimerAdd() and TimerSetInterval() time to ms.
SVN revision: 55891
2011-01-05 18:05:57 +00:00
Kim Woelders c7b7bb107e Another attempt to fix pointer focus breakage.
SVN revision: 51582
2010-08-23 16:55:46 +00:00
Kim Woelders 7d24995988 Attempt to fix sloppy focus breakage on desks other than first.
Focus was being switched back to mouse-over window.
Noted by Ted Baltz.

SVN revision: 51354
2010-08-18 21:16:54 +00:00
Kim Woelders c517a00f0b Indent.
SVN revision: 51100
2010-08-13 21:05:00 +00:00
Lucas De Marchi 4d4401c5d3 Apply badzero.cocci, badnull.cocci and badnull2.cocci
Since badzero.cocci depends on coccinelle knowledge about a variable being a pointer
and about a function returning a pointer, maybe there are false negatives.



SVN revision: 51092
2010-08-13 17:04:13 +00:00
Kim Woelders 4ac03926da Adjustments for indent 2.2.11.
SVN revision: 50909
2010-08-08 19:03:34 +00:00
Kim Woelders 3881d715f8 Enable showing outline for window selected in focuslist.
SVN revision: 50660
2010-07-29 20:39:34 +00:00
Kim Woelders 6f9ab28110 Add force parameter to EwinWarpTo().
SVN revision: 49488
2010-06-06 10:08:17 +00:00
Kim Woelders 48f6bbe94c Trivial cleanups.
SVN revision: 49486
2010-06-06 10:05:53 +00:00
Kim Woelders 0466673fbf Trim whitespace from translatable strings.
SVN revision: 48723
2010-05-09 19:03:19 +00:00
Kim Woelders f2831f0742 Another focus fix after recent changes.
SVN revision: 48679
2010-05-08 13:04:35 +00:00
Kim Woelders e33f6edfbd Add option to focus window if window group is focused.
SVN revision: 48562
2010-05-02 20:26:54 +00:00
Kim Woelders 1c06362630 Better check for focusing transients when group is focused.
SVN revision: 48561
2010-05-02 20:26:51 +00:00
Kim Woelders f947a2b0f5 Simplify.
SVN revision: 48560
2010-05-02 20:26:49 +00:00