enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity

devs/dimmus/meson #8

Closed
dimmus wants to merge 6 commits from (deleted):devs/dimmus/meson into master
pull from: (deleted):devs/dimmus/meson
merge into: enlightenment:master
Conversation 2 Commits 6 Files Changed 22 +43 -43
dimmus commented 2022-06-09 01:34:08 -07:00
Contributor
Copy Link

Changed some deprecations for meson.
Tested with meson 0.61.2 on Ubuntu 22.04.
Build succeeded :)

Changed some deprecations for meson. Tested with meson 0.61.2 on Ubuntu 22.04. Build succeeded :)
dimmus added 5 commits 2022-06-09 01:34:11 -07:00
raster commented 2022-06-10 02:42:34 -07:00
Owner
Copy Link

Thanks for the effort on this.

This is going to be an issue. At least one of my target/test systems only has meson 0.53 available for packages (ubuntu 20.04 LTS). This leads to efl not compiling at all anymore. Meson is relatively mature now so there isn't as much need to follow bleeding edge releases and I think this should hold off for a while. One of the errors as an example:

src/wayland_protocol/meson.build:24:1: ERROR: Function does not take positional arguments.

A full log can be found at /home/carhai01/C/git/efl/build/meson-logs/meson-log.txt
FAILED: build.ninja

I'd need a much newer meson and this is probably then also going to cerate problems for users needing to really update to very-much latest and greatest packages to build efl.

Thanks for the effort on this. This is going to be an issue. At least one of my target/test systems only has meson 0.53 available for packages (ubuntu 20.04 LTS). This leads to efl not compiling at all anymore. Meson is relatively mature now so there isn't as much need to follow bleeding edge releases and I think this should hold off for a while. One of the errors as an example: ``` src/wayland_protocol/meson.build:24:1: ERROR: Function does not take positional arguments. A full log can be found at /home/carhai01/C/git/efl/build/meson-logs/meson-log.txt FAILED: build.ninja ``` I'd need a much newer meson and this is probably then also going to cerate problems for users needing to really update to very-much latest and greatest packages to build efl.
vtorri commented 2022-07-17 02:36:26 -07:00
Owner
Copy Link

what about using tests on meson version ? like:

if meson.project_version() >= 0.55
  blabla
endif

not the best way, but when we bump meson version requirement, the code will be there

what about using tests on meson version ? like: ``` if meson.project_version() >= 0.55 blabla endif ``` not the best way, but when we bump meson version requirement, the code will be there
dimmus added 1 commit 2022-07-22 06:17:54 -07:00
65f312e467 revert e08edfc068 
revert meson: changed deprecated since 0.56 (0.58) method get_pkgconfig_variable() to get_variable()
dimmus closed this pull request 2023-08-07 09:18:17 -07:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: enlightenment/efl#8
No description provided.
Delete Branch "(deleted):devs/dimmus/meson"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?