enlightenment/enlightenment
enlightenment
/
enlightenment
10
9
Fork 12
Code Issues 24 Pull Requests 2 Projects Releases Wiki Activity

Avoid using "mips" as a variable #39

Merged
raster merged 1 commits from rvandegrift/enlightenment:avoid-mips-macro into master 2023-04-09 02:57:12 -07:00
Conversation 1 Commits 1 Files Changed 1 +28 -28
rvandegrift commented 2023-04-08 21:43:42 -07:00
Contributor
Copy Link

Summary:
"mips" is a gcc system-specific predefined macro on mipsel & mips64el. This
fixes compilation on those platforms.

References:

Fixes T8781

Test Plan: built on a debian mipsel porterbox

Reviewers: raster, devilhorns

Subscribers: cedric, zmike

Tags: #enlightenment-git

Maniphest Tasks: T8781

Differential Revision: https://phab.enlightenment.org/D12096

Summary: "mips" is a gcc system-specific predefined macro on mipsel & mips64el. This fixes compilation on those platforms. References: - https://gcc.gnu.org/onlinedocs/cpp/System-specific-Predefined-Macros.html - https://gcc.gnu.org/pipermail/gcc-help/2020-August/139241.html Fixes T8781 Test Plan: built on a debian mipsel porterbox Reviewers: raster, devilhorns Subscribers: cedric, zmike Tags: #enlightenment-git Maniphest Tasks: T8781 Differential Revision: https://phab.enlightenment.org/D12096
rvandegrift added 1 commit 2023-04-08 21:43:45 -07:00
c18c52f36a Avoid using "mips" as a variable 
Summary:
"mips" is a gcc system-specific predefined macro on mipsel & mips64el.  This
fixes compilation on those platforms.

References:
- https://gcc.gnu.org/onlinedocs/cpp/System-specific-Predefined-Macros.html
- https://gcc.gnu.org/pipermail/gcc-help/2020-August/139241.html

Fixes T8781

Test Plan: built on a debian mipsel porterbox

Reviewers: raster, devilhorns

Subscribers: cedric, zmike

Tags: #enlightenment-git

Maniphest Tasks: T8781

Differential Revision: https://phab.enlightenment.org/D12096
raster commented 2023-04-09 02:57:03 -07:00
Owner
Copy Link

wtf? really? mips is a keyword? wow...

wtf? really? mips is a keyword? wow...
raster merged commit c18c52f36a into master 2023-04-09 02:57:12 -07:00
raster deleted branch avoid-mips-macro 2023-04-09 02:57:13 -07:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: enlightenment/enlightenment#39
No description provided.
Delete Branch "rvandegrift/enlightenment:avoid-mips-macro"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?