Summary:
When "New" is pressed, the button should become disabled, because
the file is empty and there is nothing to lose. The "New" button
should only be enabled when there is text to lose by pressing it.
Otherwise, there is no way in the code to disable the button except
at startup, which does not make much sense.
Reviewers: ajwillia.ms, zmike, bu5hm4n
Reviewed By: ajwillia.ms
Tags: #examples
Differential Revision: https://phab.enlightenment.org/D6512
this greatly improves build times by improving parallelizing, though it
does introduce more BUILT_SOURCES usage which causes builds with cxx
bindings to take significantly longer
fix T7157
ref T7154
Differential Revision: https://phab.enlightenment.org/D6633
Summary:
connect factory to edje part name
when create a new layout connect a factory to it
change example to use the factory_model_connect
Reviewers: felipealmeida
Differential Revision: https://phab.enlightenment.org/D6667
Summary:
Fix API changes, plus several logic and syntax errors... again, this had
never been built.
Test Plan:
Didn't build before, builds and runs now, although with some runtime issues
that will be tracked on a separate issue.
Reviewers: felipealmeida, lauromoura, bu5hm4n
Differential Revision: https://phab.enlightenment.org/D6649
Summary:
- Check return vaule of fread()
- Uninitialized var (seriously!)
- Weird struct assignment
Still one warning remains, pending evaluation of T7166.
Fixes T6718
Test Plan:
Those 3 warnings have disappeared and the related example still works
as expected.
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6718
Differential Revision: https://phab.enlightenment.org/D6631
Summary:
animators are implicitly destroyed for this case, and attempting to
manually destroy them just results in an error/failure and invalid reads
since this is a poorly designed api which can internally destroy itself
fix T7000
@fix
Reviewers: Hermet, devilhorns
Subscribers: segfaultxavi, cedric
Tags: #efl
Maniphest Tasks: T7000
Differential Revision: https://phab.enlightenment.org/D6488
so there are 2 problems behind T7113. first is a problem in the efl
selection manager being "sloppy" with selection data. it's doing a
strlen on the data but it's not a normal c string. it's a blob of
binary data + length value. this fixes that "sloppiness" by using the
len field.
there is also another bug in the dnd test code that again has to do
with "sloppy" handling of data buffers and assuming nul byte
termination and not using the len field properly.
this fixes T7113.
Summary:
elua example files were not being distributed correctly as a result of
improper use of build conditionals
Depends on D6582
Reviewers: devilhorns, ManMower
Reviewed By: ManMower
Subscribers: #committers, cedric
Tags: #efl_build
Differential Revision: https://phab.enlightenment.org/D6583
Summary:
when running 'make distcheck' immediately after configure, the build
will fail because some example files were incorrectly being distributed
instead of being compiled normally in the dist build
Reviewers: ManMower
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6582
Summary: These guides needed to be adapted to the new C# API.
Test Plan:
Didn't build before, and now it can be built and run. It has some runtime
errors on exit.
Reviewers: felipealmeida, lauromoura, Hermet
Reviewed By: Hermet
Tags: #examples
Differential Revision: https://phab.enlightenment.org/D6575
Summary:
- Removed the Concrete suffixes
- Changed interfaces to IFoobar
- Event names are now camelcase with 'Evt' suffix
- Methods with the same name as its class are prefixed with 'Do'
due to C# CamelCase methods (Pack.Pack -> Pack.DoPack)
- Updated efl.ui.win.Type to efl.ui.Win_Type after API renaming
Reviewers: segfaultxavi, felipealmeida
Reviewed By: segfaultxavi
Differential Revision: https://phab.enlightenment.org/D6508
Summary: Adapt to API changes plus some other issues (has this ever built for anyone?).
Reviewers: lauromoura, felipealmeida
Differential Revision: https://phab.enlightenment.org/D6505
This reverts commit 2fb5cc3ad09f6aaf82b5d1131ac5ed22ed848bd4.
Most of this change where wrong as they didn't affect the destruction
of the object. efl_add_ref allow for manual handling of the lifecycle
of the object and make sure it is still alive during destructor. efl_add
will not allow you to access an object after invalidate also efl.parent.get
will always return NULL once the object is invalidated.
Differential Revision: https://phab.enlightenment.org/D6062
Unlike Elm_Slider, Efl.Ui.Slider does not support text_set,
format_cb_set, and format_string_set.
To support Efl.Ui.Slider, slider cxx example is modified.
Summary:
Short-lived eina strings do not need to be explicitly deallocated.
The return value of eina_hash_set DOES need to be deallocated, though.
Reviewers: cedric, ajwillia.ms
Differential Revision: https://phab.enlightenment.org/D6006
Summary:
most usage of simple list, items are very limited and loading performance is not serious.
to support those requirement, this efl.ui.list will create scrollable box with efl.pack.
user can create list by packing an pre-loaded item object, Efl.Ui.List.Item class.
Test Plan: tested in efl_ui_list_example_1.c in examples.
Reviewers: cedric, felipealmeida
Subscribers: woohyun, Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D5861
Mike Blumenkrantz
Felipe Magno de Almeida
Xavi Artigas
Carsten Haitzler
Lauro Moura
Alastair Poole
Hermet Park
Larry Lira
Cedric BAIL
Jaehyun Cho
SangHyeon Lee