Commit Graph

65181 Commits

Author SHA1 Message Date
Jaehyun Cho 72da9ec8c6 efl_ui_spotlight: Introduce forward and backward animations
forward_animation and backward_animation are introduced instead of
push_setup, pop_setup, and jump_setup.

forward_animation is started when active element is changed from lower
index to higher index. This includes push() case.
e.g. current active index is 0 and new active index becomes 1.

backward_animation is started when active element is changed from higher
index to lower index. This includes pop() case.
e.g. current active index is 1 and new active index becomes 0.
2020-03-11 13:21:20 +09:00
Marcel Hollerbach 6fd2435c9e efl_ui_spotlight: Introduce animation manager
Summary:
the manager is basically not new, its just the moved fade manager, with
a little bit more utilization. The manager now can be equipt with 3
animaton objects that are played when the correct reason happens.

For now the fade manager is the only thing that uses that.
Depends on D11357

Reviewers: Jaehyun_Cho, zmike, segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11358
2020-03-11 12:10:09 +09:00
Marcel Hollerbach 2267a07a8e efl_ui_spotlight_manager: introduce a reason for switch_to
This is preparation work for a later commit. This brings a flag that
indicates what the reason for a switch to call is, either a jump a push
or a pop.

Differential Revision: https://phab.enlightenment.org/D11357
2020-02-16 13:36:58 +01:00
Marcel Hollerbach ffccc27b1d evas: stop handdefining eo types
that is just technical dept carrying arround.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11356
2020-02-14 19:34:57 +01:00
Marcel Hollerbach 1600b0f9ce efl_ui_spotlight_fade_manager: fix wrong typedef
the typedef used here is not really existing anymore.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11355
2020-02-14 19:34:53 +01:00
Yeongjong Lee 15973fb4df elm_main: remove unreachable condition
Summary: The condition `!*p` is always false because of line 1336.

Reviewers: zmike, Hermet, bu5hm4n

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11349
2020-02-14 08:34:36 -05:00
Mike Blumenkrantz 7768b54043 tests/evas: add simple test for skip_head property
Summary:
when using this property, there should be no mmap loaded after a call
to evas_object_image_file_set, and we want to make sure the image is
eventually loaded

ref T8378

Depends on D11340

Reviewers: raster

Reviewed By: raster

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8378

Differential Revision: https://phab.enlightenment.org/D11341
2020-02-14 08:33:49 -05:00
Mike Blumenkrantz acee4e1db5 evas: restore codepath for loading images from files with skip_head set
Summary:
this was never handled during refactoring because it had already been
removed from the tree by that point

fix T8378
Depends on D11339

Reviewers: raster

Reviewed By: raster

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8378

Differential Revision: https://phab.enlightenment.org/D11340
2020-02-14 08:33:43 -05:00
Mike Blumenkrantz c37e545a03 Revert "evas: Compile out unused functions"
Summary:
This reverts commit 7d36ef88bc.
Depends on D11338

Reviewers: raster

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11339
2020-02-14 08:33:38 -05:00
Mike Blumenkrantz dc14257c96 Revert "evas: remove image_load from the engine."
Summary:
This reverts commit 867d826395.
Depends on D11337

Reviewers: raster

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11338
2020-02-14 08:33:32 -05:00
Mike Blumenkrantz be3915cc90 Revert "evas: remove unused fonction evas_gl_common_image_load."
Summary:
This reverts commit fc7e244e99.
Depends on D11336

Reviewers: raster

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11337
2020-02-14 08:33:26 -05:00
Mike Blumenkrantz 7aec0565cb Revert "evas: remove unused function evas_common_load_image_from_file."
Summary:
This reverts commit 7672d1050e.
Depends on D11335

Reviewers: raster

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11336
2020-02-14 08:33:20 -05:00
Mike Blumenkrantz 08b291e540 Revert "evas: remove unused function evas_cache_engine_image_request."
Summary:
This reverts commit 90e1ca7154.
Depends on D11334

Reviewers: raster

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11335
2020-02-14 08:33:13 -05:00
Mike Blumenkrantz c1dd72fc91 Revert "evas: remove unused function evas_cache_image_request."
Summary: This reverts commit ee3f4e0529.

Reviewers: raster

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11334
2020-02-14 08:33:07 -05:00
Yeongjong Lee fff6ce7f2e eina_rbtree: avoid defererencing null pointer
Summary: Pointer 'it->stack' is dereferenced at `_eina_rbtree_iterator_free`.

Reviewers: Hermet, zmike

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11346
2020-02-14 18:18:20 +09:00
Carsten Haitzler 9768a5ad98 ecore x - fix debug printf format to print time 2020-02-14 09:00:48 +00:00
Marcel Hollerbach 0c313f89b0 efl_canvas_gesture: replace parse with import
we probebly want to use import here, as we want to rebuild this file
when efl_canvas_gesture_events is changed.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11273
2020-02-14 09:44:27 +01:00
Hermet Park 31641e4c75 elementary atspi_bridge: fix memory leak at the corner case 2020-02-14 17:32:59 +09:00
Hermet Park 0a26ea3594 elementary value provider: replace sprintf() with snprintf()
Avoid vulerable function usage in the test code
2020-02-14 17:24:39 +09:00
Mike Blumenkrantz f80189c343 elm_test: add zoom recognizer handling to gesture test
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11330
2020-02-14 09:21:21 +01:00
Mike Blumenkrantz f5c4c4ee15 efl/gesture: remove Efl.Canvas.Gesture_Recognizer_Type
this serves no purpose and isn't used anywhere

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11323
2020-02-14 09:21:19 +01:00
Mike Blumenkrantz 93abc9cbeb efl/gesture: rework custom gesture recognizer methodology
this needs to return the actual gesture class type so that custom gesture
events can implement their own properties if necessary

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11322
2020-02-14 09:21:15 +01:00
Mike Blumenkrantz f917f75c56 efl/gesture: improve docs
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11321
2020-02-14 09:21:12 +01:00
Mike Blumenkrantz f5273decbb efl/gesture: remove bespoke recognizer properties for tap timeout
this should all be managed by efl.config

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11320
2020-02-14 09:21:09 +01:00
Mike Blumenkrantz 61b5131393 efl/gesture: un-@protected efl.canvas.gesture_recognizer::continues
recognizers need to be able to get and set this appropriately

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11319
2020-02-14 09:21:06 +01:00
Mike Blumenkrantz f145b53892 efl/gesture: api renames for Efl.Canvas.Gesture_Touch
ref T8554

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11300
2020-02-14 09:21:03 +01:00
Mike Blumenkrantz 77b6d0efd7 efl/gesture: fix long tap timeout errors
this is the timer pointer, and we need to be able to delete the timer when
the gesture ends

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11299
2020-02-14 09:21:00 +01:00
Mike Blumenkrantz c0453132df tests/gesture: add another tap test to check finger size works
add some move events in to shake up the recognizers and check whether
taps are still working

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11292
2020-02-14 09:20:56 +01:00
Mike Blumenkrantz 9e53d9c017 efl/gesture: fix touch state tracking
correctly set 'pressed' member of touch data only on press events and
don't change it on move events in order to avoid having mismatched states

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11291
2020-02-14 09:20:54 +01:00
Mike Blumenkrantz edcc16238b efl/gesture: remove recognizer::reset method
this wasn't used and doesn't seem necessary

ref T8503

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11279
2020-02-14 09:20:51 +01:00
Mike Blumenkrantz 3d858f3948 efl/gesture: fix tap gesture type naming
we use c_enum_naming_style in our enums, not cSharpEnumNamingStyle

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11275
2020-02-14 09:20:48 +01:00
Mike Blumenkrantz a136ab2e00 efl/gesture: remove gesture_touch::multi_touch
this is redundant now that touch_count exists

ref T8554

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11274
2020-02-14 09:20:45 +01:00
Mike Blumenkrantz 28b7ea6f0c efl/gesture: rework gesture_recognizer::add to be a 'type' property
this simplifies (and optimizes) a bunch of code by letting gesture recognizers
return directly the type of gesture they recognize for use internally

ref T8503

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11267
2020-02-14 09:20:42 +01:00
Mike Blumenkrantz 23f772b434 efl/gesture: use new config value for thumbscroll friction
the old one used here is marked deprecated

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11263
2020-02-14 09:20:39 +01:00
Mike Blumenkrantz a59956680d elm/config: fix thumbscroll config
this was broken a while ago by failing to correctly update all the configs

ref 6409cfa41b

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11294
2020-02-14 09:20:36 +01:00
Mike Blumenkrantz 6a3f10d719 efl/config: add missing gesture config value handlers
these are stored in the config here so they should be manageable here as well

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11250
2020-02-14 09:20:33 +01:00
Mike Blumenkrantz 151ec0748a efl/config: merge all gesture manager config code into efl.config
this is all just duplicated code, so we can deduplicate it with minimal
effort to clean up the api

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11251
2020-02-14 09:20:30 +01:00
Mike Blumenkrantz 23678b3695 efl/win: change a couple config init sets for gesture manager to use legacy config
these values are deprecated, so stop setting them in efl_config

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11249
2020-02-14 09:20:27 +01:00
Mike Blumenkrantz 7da4ab3633 efl/gesture: remove manager config
we can just use efl.config here instead of duplicating it

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11248
2020-02-14 09:20:24 +01:00
Mike Blumenkrantz 94a29d05de efl/config: move C wrappers for this out of elm_config.h to Efl.h
this is beta API and belongs in its proper header

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11247
2020-02-14 09:20:21 +01:00
Mike Blumenkrantz 0f2a61b5f2 efl/gesture: move manager's recognizer cleanup function to eo
this is needed by recognizers which use timers in order to do timeouts
on gestures

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11245
2020-02-14 09:20:18 +01:00
Hermet Park 6307fc056a canvas image: remove unnecessary condition check. 2020-02-14 17:07:05 +09:00
Marcel Hollerbach 0c77cee3ab evas_model_loader: fix 8f3bef248b
The commit fixed a mem leak with freeing one element in the array, which
was never going to work, as only the array is a pointer you can
allocate.

This could have been discovered by simply running ninja test.
2020-02-14 09:01:10 +01:00
Marcel Hollerbach f57b24b86b efl-check: do not print expected errors
that is just a waste of log space.

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11297
2020-02-14 09:01:10 +01:00
Marcel Hollerbach e84c1b6bf8 eina-suite: do not print that many errors
we should expect errors in these conditions, this also safes a lot of
space in logs.

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11296
2020-02-14 09:01:06 +01:00
junsu choi 744b2b5bd1 elm_dbus_menu: Remove unreached code.
Summary:
The property parameter used in this function are passed from _str_to_property.
_str_to_property does not pass anything other than the enum value.
Therefore this log is an unreached line.

Test Plan: N/A

Reviewers: Hermet, YOhoho

Reviewed By: YOhoho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11347
2020-02-14 16:27:27 +09:00
junsu choi 65dae7876d eldbus_service: Prevent memory leak
Summary:
If obj->introspection_data is null, the function returns
without freeing the memory.

Test Plan: N/A

Reviewers: Hermet, YOhoho

Reviewed By: YOhoho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11345
2020-02-14 16:27:12 +09:00
junsu choi 2ba77c0a33 efl_ui_image : Avoid integral division
Summary:
Assigning a result of integral division to a double type variable
is not useful for division calculation.

Test Plan: N/A

Reviewers: Hermet, YOhoho

Reviewed By: YOhoho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11344
2020-02-14 16:26:52 +09:00
SangHyeon Jade Lee 3ce052d9ec elm : fix unintialized data set
Summary:
fw, fh can be referenced in _box_object_aspect_calc
without initialized when ax, ay is greater or equal than 0.

Reviewers: eagleeye

Reviewed By: eagleeye

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11348
2020-02-14 14:29:36 +09:00
Hermet Park 8f3bef248b canvas model_loaders: fix memory leak in ply loader.
eina_str_split() newly allocate memory to return,
caller must take over its resource free..
2020-02-14 13:51:46 +09:00