Commit Graph

23281 Commits

Author SHA1 Message Date
Simon Lees 52713ce0db
22.3 NEWS 2018-03-22 20:36:31 +10:30
Simon Lees cd4c2cee3f
22.3 build file bump 2018-03-22 20:33:14 +10:30
Carsten Haitzler 2a0f90dab3 build - make pam a requirement on non-bsd unless disabled
this shou,ld provide a compile failure for when no pam headers are
found and thus pam not enabled if we need pam for auth (i.e. linux).
so it'll be harder to foot-shoot now.also an add-on fix to T6779
2018-03-22 12:18:03 +09:00
Carsten Haitzler 3bdcb7a0c2 move from data_home/apps/defaults.list to config_home/mimeapps.list
this moves to the newer mimeapps.list file in ~/.config from the older
defaults.list. it also provides a migration (copy file ovr if target
doesnt exist on e startup).

this fixes T6784

@fix
2018-03-22 12:17:03 +09:00
Carsten Haitzler 8b03df8b30 e desklock pam error - go back to previous text
since we had translations of this, go back to the prior text so we
keep these. also dont show if using a personal password. related to
fixing T6779
2018-03-22 12:16:47 +09:00
Carsten Haitzler 71d481b4c4 desklock - make it fail to lock on non-bsd platforms if no pam support
if no pam support detected at build time, dont even lock to begin
with. this should fix T6779

yes - even better is making pam a requirement for building and to be
optionallhy disabled, but then even if disabled we still need this check.

this has been a long long long standing bug in e. i think this is why
we had some reports of "any password unlocks e" - because it was built
without pam support and before auth was always succeeding without pam.
now it is always FAILING instead (which is probably better).

@fix
2018-03-22 12:16:32 +09:00
Carsten Haitzler 0d9a763165 fix autofoo build to match e auth patch backport
the autofoo wasnt updated with the patch and peolpe are using the
autotools build thus this btoke e lockscreen auth but not building the
binary.
2018-03-22 12:11:23 +09:00
Derek Foreman 3c5b541385 Revert no-longer required pulseaudio hack for wayland
The problem this solved is now handled elsewhere.

Reverts what's left of commit 6eefae4822
2018-03-20 12:32:01 -05:00
Simon Lees 256236eba3
22.2 NEWS 2018-03-13 13:51:22 +10:30
Simon Lees ffec2e91e7
22.2 build file bump 2018-03-13 13:38:02 +10:30
Carsten Haitzler 1296061c19 systray - fix sizing of tray so you can see the icons
this should also address the last comment with a fix T5910
2018-03-13 13:28:54 +10:30
Carsten Haitzler eba3bec170 e systray/indicator protocol pixmap data fetch fix
this fixes several issues in the pixmap data fetching

1. it over-read the input buffer assuming ints count instead it has
byte count for length
2. it would leak memory if you have multiple pixmaps and the largest
was not the first found.
3. it always swapped pixel bytes instead of only on little endian.

this should fix T5910
2018-03-13 13:25:25 +10:30
Mike Blumenkrantz 348e57123c remove adding theme extension for "default" theme on startup
elm_theme does this automatically so there should never be a need for it
2018-03-02 11:14:27 -05:00
Carsten Haitzler 3c4e25360e e auth - move all auth to child process only (e_ckpasswd).
this should fix T6211 ensuring no drivers can cause a segfault at exit
time. this also happens to remove the enlightenment_sys -z option for
openbsd and unifies all the passwd checking into the single
enlightenment_ckpasswd binary util (that has ifdefs for openbsd,
freebsd and linux pam in it).

this simplifies code removing a mess of auth being done in multiple
places, removes special fork vs run 1 exe or a different exe in
different cases making it more maintainable. yes - this requires
enlightenment_ckpasswd to be setuid root, but it already was when it
was built.

@fix
2018-03-02 11:14:20 -05:00
Al Poole e8132e8723 sysinfo: fix linux build. 2018-03-02 11:14:08 -05:00
Al Poole da19c3cd6a sysinfo: fix cpuclock for BSD.
This lets us use the cpuclock gadget on FreeBSD machines.

@fix T6259
2018-03-02 11:14:04 -05:00
Mike Blumenkrantz 140f176d8e fix luncher efreet event handling
this does not require a bar resize, a bar refill, or any object creation.
it only requires icon file setting.
2018-03-02 11:13:58 -05:00
Mike Blumenkrantz 553b8063a5 always unset pass_events on desktop editor when it is shown
fixes some cases where the editor could not be interacted with after
it was hidden during gadget placement
2018-03-02 11:13:49 -05:00
Mike Blumenkrantz c43113381c do not add gadget editor pointer site to editor del_list
the pointer site will never exist at the time when the editor is
destroyed
2018-03-02 11:13:42 -05:00
Thanatermesis c35aaefc1f Fix for window borders to accept edje icons
If you have edje icons installed in your system (efreet smartly searches
the candidate icon based in your Icon= entry), they works correctly in
the menus, bar, etc... but doesn't works in the window borders icon,
this is because the code try's to add it without dealing with the .edj
extensions, probably attempting to load multiple image types and
returning some errors/warning, resulting in an empty icon in the window
borders

Fixes T6723
2018-03-02 11:13:34 -05:00
Mike Blumenkrantz 2e0e3a356b process comp object hide/show signals immediately during intercept
for objects without animations, it's important to instantly perform
state transitions in order to preserve intended visibility behaviors of
these objects and avoid race conditions due to asynchronous signal
processing

fix T6722
2018-03-02 11:13:21 -05:00
Mike Blumenkrantz a6d1933823 use per-instance event handler for batman powersave eventing
==19679== Invalid read of size 4
==19679==    at 0x5CC90EF: _ecore_event_message_handler_handler_del (ecore_event_message_handler.c:194)
==19679==    by 0x5CCA332: ecore_event_message_handler_del (ecore_event_message_handler.eo.c:22)
==19679==    by 0x5CBC7E3: ecore_event_handler_del (ecore_events.c:51)
==19679==    by 0x2A23F4F1: _batman_removed_cb (batman.c:579)
==19679==    by 0x6A9A33D: _eo_evas_smart_cb (evas_object_smart.c:78)
==19679==    by 0xC166F4D: _event_callback_call (eo_base_class.c:1560)
==19679==    by 0xC16728E: _efl_object_event_callback_legacy_call (eo_base_class.c:1633)
==19679==    by 0xC167334: efl_event_callback_legacy_call (eo_base_class.c:1636)
==19679==    by 0x6A889CA: _efl_canvas_object_efl_object_event_callback_legacy_call (evas_object_main.c:1157)
==19679==    by 0xC167334: efl_event_callback_legacy_call (eo_base_class.c:1636)
==19679==    by 0x6A9CBA7: evas_object_smart_callback_call (evas_object_smart.c:1037)
==19679==    by 0x500B1D: _gadget_remove (e_gadget.c:426)
==19679==    by 0x5037A9: _gadget_menu_remove (e_gadget.c:1263)
==19679==    by 0x552600: _e_menu_active_call (e_menu.c:2066)
==19679==    by 0x55445E: _e_menu_cb_mouse_up (e_menu.c:2809)
==19679==    by 0x5CC9933: _ecore_event_message_handler_efl_loop_message_handler_message_call (ecore_event_message_handler.c:359)
==19679==    by 0x5CD31D1: efl_loop_message_handler_message_call (efl_loop_message_handler.eo.c:14)
==19679==    by 0x5CCDA73: _efl_loop_message_process (efl_loop.c:681)
==19679==    by 0x5CCDC64: efl_loop_message_process (efl_loop.c:711)
==19679==    by 0x5CC7453: _ecore_main_loop_iterate_internal (ecore_main.c:2444)
==19679==    by 0x5CC457E: _ecore_main_loop_begin (ecore_main.c:1173)
==19679==    by 0x5CCC0CD: _efl_loop_begin (efl_loop.c:97)
==19679==    by 0x5CCED13: efl_loop_begin (efl_loop.eo.c:50)
==19679==    by 0x5CC46F7: ecore_main_loop_begin (ecore_main.c:1246)
==19679==    by 0x5476B6: main (e_main.c:1092)
==19679==  Address 0x212af268 is 40 bytes inside a block of size 48 free'd
==19679==    at 0x4C30D18: free (vg_replace_malloc.c:530)
==19679==    by 0x5CC9BE6: _ecore_event_message_handler_efl_loop_message_handler_message_call (ecore_event_message_handler.c:389)
==19679==    by 0x5CD31D1: efl_loop_message_handler_message_call (efl_loop_message_handler.eo.c:14)
==19679==    by 0x5CCDA73: _efl_loop_message_process (efl_loop.c:681)
==19679==    by 0x5CCDC64: efl_loop_message_process (efl_loop.c:711)
==19679==    by 0x5CC7453: _ecore_main_loop_iterate_internal (ecore_main.c:2444)
==19679==    by 0x5CC457E: _ecore_main_loop_begin (ecore_main.c:1173)
==19679==    by 0x5CCC0CD: _efl_loop_begin (efl_loop.c:97)
==19679==    by 0x5CCED13: efl_loop_begin (efl_loop.eo.c:50)
==19679==    by 0x5CC46F7: ecore_main_loop_begin (ecore_main.c:1246)
==19679==    by 0x5476B6: main (e_main.c:1092)
==19679==  Block was alloc'd at
==19679==    at 0x4C31A1E: calloc (vg_replace_malloc.c:711)
==19679==    by 0x5CC8EE1: _ecore_event_message_handler_handler_add (ecore_event_message_handler.c:148)
==19679==    by 0x5CCA0FB: ecore_event_message_handler_add (ecore_event_message_handler.eo.c:14)
==19679==    by 0x5CBC790: ecore_event_handler_add (ecore_events.c:35)
==19679==    by 0x2A23FB87: _batman_created_cb (batman.c:661)
==19679==    by 0x6A9A33D: _eo_evas_smart_cb (evas_object_smart.c:78)
==19679==    by 0xC166F4D: _event_callback_call (eo_base_class.c:1560)
==19679==    by 0xC16728E: _efl_object_event_callback_legacy_call (eo_base_class.c:1633)
==19679==    by 0xC167334: efl_event_callback_legacy_call (eo_base_class.c:1636)
==19679==    by 0x6A889CA: _efl_canvas_object_efl_object_event_callback_legacy_call (evas_object_main.c:1157)
==19679==    by 0xC167334: efl_event_callback_legacy_call (eo_base_class.c:1636)
==19679==    by 0x6A9CBA7: evas_object_smart_callback_call (evas_object_smart.c:1037)
==19679==    by 0x501172: _gadget_object_create (e_gadget.c:548)
==19679==    by 0x506B90: e_gadget_type_add (e_gadget.c:2056)
==19679==    by 0x2A23CA44: sysinfo_init (mod.c:161)
==19679==    by 0x2A23CCF5: e_modapi_init (mod.c:203)
==19679==    by 0x556814: e_module_enable (e_module.c:524)
==19679==    by 0x555DF9: e_module_all_load (e_module.c:324)
==19679==    by 0x554EFF: _module_done_cb (e_module.c:73)
==19679==    by 0x73531C1: eio_async_end (eio_file.c:510)
==19679==    by 0x5CF8D67: _ecore_thread_kill (ecore_thread.c:229)
==19679==    by 0x5CF8E1C: _ecore_thread_handler (ecore_thread.c:256)
==19679==    by 0x5CB97D0: _ecore_main_call_flush (ecore.c:1090)
==19679==    by 0x5CB9858: _thread_callback (ecore.c:1101)
==19679==    by 0x5CF51F3: _ecore_pipe_handler_call (ecore_pipe.c:602)
==19679==    by 0x5CF5529: _ecore_pipe_read (ecore_pipe.c:725)
==19679==    by 0x5CC3677: _ecore_call_fd_cb (ecore_private.h:476)
==19679==    by 0x5CC6793: _ecore_main_fd_handlers_call (ecore_main.c:2051)
==19679==    by 0x5CC7414: _ecore_main_loop_iterate_internal (ecore_main.c:2439)
==19679==    by 0x5CC457E: _ecore_main_loop_begin (ecore_main.c:1173)
==19679==    by 0x5CCC0CD: _efl_loop_begin (efl_loop.c:97)
==19679==    by 0x5CCED13: efl_loop_begin (efl_loop.eo.c:50)
==19679==    by 0x5CC46F7: ecore_main_loop_begin (ecore_main.c:1246)
==19679==    by 0x5476B6: main (e_main.c:1092)
2018-03-02 11:13:04 -05:00
Mike Blumenkrantz 0c0d002f94 disable bounce for gadget bar scrollers
fix T6721
2018-03-02 11:12:58 -05:00
Mike Blumenkrantz 829f7ee29d use the current pointer client for the xwayland drag client if owner is unmapped
qt seems to like doing this

fix T6644
2018-03-02 11:12:54 -05:00
Stephen Houston abb761b784 Luncher: Add a timeout for mousing out when preview already exists. Update preview on deskswitch.
This fixes https://phab.enlightenment.org/T6328 and https://phab.enlightenment.org/T6202
2018-03-02 11:12:47 -05:00
Mike Blumenkrantz c93e8f93a1 resolve even more null derefs from string parsing in vkbd
CID 1132747
2018-03-02 11:12:21 -05:00
Andy Williams 52319a6feb Remove E_BITFIELD as it is not present on this branch 2018-02-09 11:28:49 +00:00
Marcel Hollerbach 461872e669 build: enter po subdir
the option is handled inside
2018-01-30 10:52:50 -05:00
Mike Blumenkrantz 7b55e20ace print notifications to stderr if a notification handler doesn't exist 2018-01-30 10:52:43 -05:00
Mike Blumenkrantz a95e49fe6b further protect against crashes when xwayland crashes 2018-01-30 10:52:34 -05:00
Mike Blumenkrantz afe31ab8d5 toggle x_fatal variable when xwayland crashes 2018-01-30 10:52:21 -05:00
Mike Blumenkrantz a0985dc6c0 don't do x11 window grab for fps counter when running in wayland mode
this crashes older efl
2018-01-30 10:52:15 -05:00
Mike Blumenkrantz 58e81cdd25 fix notification crashes when a callback isn't specified 2018-01-30 10:52:09 -05:00
Mike Blumenkrantz 9bd0b71f46 add menu item for reporting bugs
fix T6633
2018-01-30 10:52:00 -05:00
Mike Blumenkrantz 22dd7fef86 use normal emotion function to determine playability of e_thumb files
ref 82f1b8a1c1
ref D4779
2018-01-30 10:51:25 -05:00
Mike Blumenkrantz 110835d212 clamp large windows to desk's useful geometry if smart placement fails
in the case where a window does not place with the smart placement algorithm,
clamp position to the top-left available position within the useful geometry
so that the titlebar will always be visible
2018-01-30 10:51:19 -05:00
Mike Blumenkrantz b1eff9a96b block gadget site layouts on moving gadgets which are not on the pointer site
these will be recalculated correctly once the move operation terminates

fix T6623
2018-01-30 10:51:12 -05:00
Mike Blumenkrantz 727b564199 fix some crashes with start gadget deletion
ref T6623
2018-01-30 10:51:05 -05:00
Mike Blumenkrantz cafe1976fb clear visible gadget popups when triggering a gadget action 2018-01-30 10:50:59 -05:00
Mike Blumenkrantz ba11728905 consider gadget ctxpopups as normal popups for callback purposes 2018-01-30 10:50:52 -05:00
Mike Blumenkrantz acf6198252 sort gadgets alphabetically in gadget editor 2018-01-30 10:50:42 -05:00
Carsten Haitzler ef98964bc9 init anim - fix sudden vanish of init splash in some cases
this seems to happen to @manmower in T6619. it may just be timing
changes that changed the start loop time to be at init of ecore maybe ...
but it was doing a forced hide and not a clean "done"
that animates/fades. so fix this along with deferring show until the
first render pre.

this fixes T6619
2018-01-30 10:49:57 -05:00
Mike Blumenkrantz cd74104405 add a lot of null checks to wayland egl init
fix T6617
2018-01-30 10:49:36 -05:00
Mike Blumenkrantz 92d7f40486 unset E_Client->changes.pos when attempting to maximize a new re_manage client
a remaining client from before a restart which is maximized does not need its
position adjusted; this will cause it to go offscreen when unmaximized

ref T6414
2018-01-30 10:49:22 -05:00
Mike Blumenkrantz 083e1a34b4 use e_zone_desk_useful_geometry_get() for all client maximize geometry fetching
fix T6414
2018-01-30 10:49:14 -05:00
Mike Blumenkrantz 9400e02493 make xwl data offer writing async
I foolishly thought this was an impossibly rare deadlock condition

fix T6454
2018-01-30 10:49:07 -05:00
Mike Blumenkrantz 4d0e4b1f8f protect against null deref when setting proxy vars in connman module
CID 1382957, 1382958
2018-01-30 10:48:02 -05:00
Mike Blumenkrantz 8d8c9f69e0 print error when failing to unlink efm/eeze mount point after unmount
CID 1382955
2018-01-30 10:47:56 -05:00
Mike Blumenkrantz 96a67811a1 protect against null deref when emitting efm/eeze error messages
CID 1382954
2018-01-30 10:47:50 -05:00
Mike Blumenkrantz 31e5559658 refactor E_Storage finding for efm/eeze volumes in backend
CID 1382951
2018-01-30 10:47:41 -05:00