Commit Graph

15519 Commits

Author SHA1 Message Date
Mike Blumenkrantz 452a23019c reset scanners/sorters and decrement busy state on efm path set
no more arbitrarily loading file icons from other directories into the current view, mmk?
2014-05-07 17:58:34 -04:00
Mike Blumenkrantz 9e3dedb23f hide fileman popups on window close
fix T1221
2014-05-07 17:46:24 -04:00
Mike Blumenkrantz 22c8d5ca77 fix auto unmounting of volumes if mount occurred due to auto_mount option 2014-05-07 17:43:12 -04:00
Mike Blumenkrantz 810f44d25f do show removable media on first sighting (wtf?)
fix T1227
2014-05-07 17:06:49 -04:00
Mike Blumenkrantz 2cc4ae1fb8 fix more eo edje emit errors 2014-05-07 16:52:44 -04:00
Mike Blumenkrantz 0202c19d49 add efm op to notify of device backend changes 2014-05-07 16:46:56 -04:00
Mike Blumenkrantz 157702c6d1 block shelf autoshow if fullscreen client is present
T1232
2014-05-07 16:04:48 -04:00
Mike Blumenkrantz 3216d8e152 eolian files should be distributed, no need to rerun this on every package build 2014-05-07 16:01:47 -04:00
Mike Blumenkrantz 329322f9a7 fix name of screen blank dialog
fix T1201
2014-05-07 15:33:33 -04:00
Mike Blumenkrantz a963666656 use separate variable for backlight animator value
using e_bl_val here is wrong now since this needs to calculate against the starting and ending backlight values, neither of which are represented accurately by e_bl_val in some cases.

this fixes the gradually decaying backlight which occurs over repeated screen blanks

probably fixes T1152
2014-05-07 15:28:08 -04:00
Mike Blumenkrantz 572760ae0e only update e_bl_val directly in backlight_level_set if not using randr backlight
this is the "real" backlight value, so it needs to always be accurate. since randr backlight sets this value elsewhere, only use those real updates to ensure genuine values
2014-05-07 15:26:42 -04:00
Mike Blumenkrantz 787ca774de return all fm objects matching a path
fix T1191
2014-05-07 14:11:20 -04:00
Mike Blumenkrantz adcf979e5c always unset need_unmaximize after maximize
fix T1203
2014-05-07 12:43:29 -04:00
Mike Blumenkrantz 58d8243457 force geometry setting during maximize
fixes adding maximize states
2014-05-07 12:42:41 -04:00
Mike Blumenkrantz aff4f3516f clamp ibar menu location to ibar zone
fix T1170

fix T1174
2014-05-07 12:06:25 -04:00
Mike Blumenkrantz 0b6b75939e hide ibar menu if no clients exist for lone exe instance 2014-05-07 11:54:34 -04:00
Mike Blumenkrantz f21400e209 don't allow fileman popups to span multiple monitors 2014-05-07 11:33:48 -04:00
Jérémy Zurcher 7ff5a2a744 fix launch mixer from config panel, select card and channel 2014-05-07 14:44:10 +02:00
Jérémy Zurcher 3679550b5c e_fm: add missing EINA_UNUSED 2014-05-07 12:16:10 +02:00
Jérémy Zurcher c12e9740a9 temperature: have_temp is an Eina_Bool, use it as such 2014-05-07 12:05:14 +02:00
Jérémy Zurcher 316b4030e7 music-control: add missing EINA_UNUSED 2014-05-07 11:56:35 +02:00
Jérémy Zurcher b6907e848a ibar: silence uninitialized warning 2014-05-07 11:48:18 +02:00
Jérémy Zurcher 42d2387b70 everything: fix warnings uninitialized and extraneous parentheses 2014-05-07 11:44:32 +02:00
Jérémy Zurcher de779ee133 connman: add missing EINA_UNUSED 2014-05-07 11:37:22 +02:00
Jérémy Zurcher a161537006 bluez4: add missing EINA_UNUSED 2014-05-07 11:23:09 +02:00
Tom Hacohen dfbb42b81d Tiling: Set pass events on the split type popup. 2014-05-06 15:56:38 +01:00
Tom Hacohen 1433be5e3c Tiling: Add informational popup when changing tiling mode. 2014-05-06 15:44:55 +01:00
Tom Hacohen 10d009339a Tiling: Allow changing tiling mode through key-binding from all desktops.
Without this it is impossible to change the tiling mode using the key binding
but you can still change it using the gadget which is stupid.
2014-05-06 14:41:48 +01:00
Tom Hacohen f3d0f73cf6 Tiling: Fix toggle floating mode for untiled window.
This is useful in case they are going to become tiled, e.g maximized
or just from another desktop.
2014-05-06 14:38:44 +01:00
Tom Hacohen 938dee1e3b Tiling: Fix some issues and simplify code.
This fixes the issue with a floating window turned tiled and then closed
leaving a ghost window.
2014-05-06 14:22:04 +01:00
Seunghun Lee 1d9a94c7e9 remove duplicated code
Summary:
this patch removes duplicated code.
the event handler of "focus in/out" already added above it.

Reviewers: raster, zmike

CC: cedric

Differential Revision: https://phab.enlightenment.org/D816
2014-05-02 06:48:28 -04:00
Gwanglim Lee c70e3eb531 remove duplicate xkb_rule_names and xkb_context
Summary: There are already in inner structure xkb in E_Wayland_Compositor.

Test Plan: Build e

Reviewers: raster, devilhorns, zmike

CC: cedric

Differential Revision: https://phab.enlightenment.org/D742
2014-04-26 13:36:53 -04:00
Gwanglim Lee a5bd16603f e_comp_x: fix black area of override redirect win
Summary:
Black area of override redirect window could send damage notify which has unwanted xy position.
(a) Skip x configure notify with 3,55 316x162 of override redirect win
(b) Handle x show notify: create a new client and x damage for override redirect win
(c) Handle x damage notify with 3,55 316x162

To resolve it, E discards unwanted xy position of first damage for override redirect window.
This fixes remained problem of T1180 and T1188.

Test Plan:
1. Run e with sw engine mode
2. Run pcmanfm
3. Select menu in pcmanfm
4. Check whether menu window has black area

Reviewers: raster, zmike, devilhorns

CC: cedric

Differential Revision: https://phab.enlightenment.org/D800
2014-04-26 13:17:13 -04:00
Gwanglim Lee 69e39063dd e_comp_object: update xy position of client in intercept_move to avoid unwanted first damage if given client is not a new_client
Summary:
xterm and pcmanfm windows shows black area if e is running with sw engine mode. (T1180)
In this case, there are two problems:

1. Unwanted geometry info of first damage by wrong window move in intercept_move.
(a) Handle x map request
(b) Initialize client_inset value of comp object according to geometry value of "e.swallow.client" part
(c) Set client_inset value to cw->client.x and y in intercept_move
(d) Call ecore_x_window_move_resize with wrong x and y at idler
(e) Create x damage
(f) Handle unwanted damage notify event which has position values same as client_inset.
(g) Copy image contents from pixmap according to wrong area info of damage notify and render it on screen.

2. Problem of override redirect window
Black area of pcmanfm's menu is related to override redirect window.

This patch only covers 1st problem not 2nd problem.
The override redirect window should be fixed by another way.

Test Plan:
1. Run e with sw engine mode or run x-ui.sh in e git simply
2. Run xterm which is using classic x drawing api
3. Check client window area of xterm

Reviewers: raster, zmike, devilhorns

CC: cedric

Differential Revision: https://phab.enlightenment.org/D795
2014-04-25 12:50:47 -04:00
Gwanglim Lee a008cd66fd change name of include guard E_COMP_H
Summary: e_comp is not an e module anymore.

Test Plan: N/A

Reviewers: raster, devilhorns, zmike

CC: cedric

Differential Revision: https://phab.enlightenment.org/D791
2014-04-25 00:20:18 -04:00
Carsten Haitzler a444f71db7 add -lrt checking to e build 2014-04-25 09:46:21 +09:00
Gwanglim Lee 6f707894a8 fix e cursor invisible after destroying wayland surface
Summary:
E doen't have to remove pointer_image evas object when destroying wayland
surface. The image contents of pointer_image will be replaced default mouse
cursor in pointer_object at idler unless pointer_image is removed in
e_pointer_image_set.

Test Plan: run e with wayland only server -> run elementary test -> close elementary test

Reviewers: raster, devilhorns, zmike

CC: cedric

Differential Revision: https://phab.enlightenment.org/D776
2014-04-24 12:42:03 -04:00
Gwanglim Lee ecb8d21ab6 set blocks to avoid copying cursor contents from evas buffer canvas in idler_before
Summary:
it fixes a bug that cursor is invisible when running a wayland client.
e_pointer_image_set function sets image data of p->pointer_image to
data of E_Pixmap. and then e_pointer_idler_before function changes
raw image data of p->pointer_image to p->pixels. we should enable blocks
to avoid it.

Test Plan: run enlightenment (wayland only) -> run efl app with wayland shm engine

Reviewers: raster, devilhorns, zmike

CC: cedric

Differential Revision: https://phab.enlightenment.org/D769
2014-04-24 12:41:38 -04:00
Stefan Schmidt f47bed7ed7 e_uuid_store: Write uuid as latest to avoid half-working states 2014-04-24 11:03:53 +02:00
Stefan Schmidt cc23186dbd e_uuid_store: Use libuuid for UUID generation and handling
Instead of rolling our own we go with a known working UUID implementation
here. Dependency should be easy enough as more or less every Linux system
is shipping it anyway.
2014-04-24 11:03:52 +02:00
Stefan Schmidt 19436fe61d e_uuid_store: Handle cases where the store is already present as well as not 2014-04-24 11:03:52 +02:00
Stefan Schmidt 9523d7a93c e_uuid_store: Switch uuid entries from list to array
This should help to store it in the shm
2014-04-24 11:03:52 +02:00
Stefan Schmidt 8662551ee3 e_uuid_store: Add version to table if not yet set 2014-04-24 11:03:52 +02:00
Stefan Schmidt c2ce32596a e_uuid_store: Close shm fd on shutdown 2014-04-24 11:03:52 +02:00
Stefan Schmidt 720f3634f8 e_uuid_store: Print out some more store infos on startup 2014-04-24 11:03:52 +02:00
Stefan Schmidt 8ebda14276 e_uuid_store: Add function to dump the table for debugging 2014-04-24 11:03:52 +02:00
Stefan Schmidt 7a940b1062 feature: e_uuid_store: Add infrastructure to store window/surface properties.
e_uuid_store provides an API to store various window/surface properties
in a mmapped shm memory object based on an assigned UUID. Its main purpose
will be to provide storage of these properties during session recovery when
E acts as a wayland compositor.

@feature
2014-04-24 11:03:52 +02:00
Wonguk Jeong ac6a0ced61 pager/pager16: fix text update bug during chaging desktop
Summary:
text part of pager popup is updated every desktop change.
But, the text part name is mismatched with style in elementary.

Honestly, I've fixed in pager16 as well since it's same problem. obviously.
Unfortunately, I couldn't test pager16.. where the hell is it.

Fixes T1189

Test Plan: enlightement -> desktop change by using key input -> check whethere proper desktop name is shown on pager popup or not

Reviewers: raster, zmike

CC: seoz, cedric, maxerba

Maniphest Tasks: T1189

Differential Revision: https://phab.enlightenment.org/D780
2014-04-24 17:56:50 +09:00
Wonguk Jeong cf6d509dfe filepreview: video size bug fix
Summary: after commit 36a4948085, video size was not proper size in preview. the commit was good refactoring. resize only when the video file is opened. but, the smart callback name was wrong. change smart callback name from "length_change" to "open_done"

Test Plan: enlightenment -> efm -> preview on video file -> check whether the video size is shown properly

Reviewers: raster, zmike

CC: seoz, cedric

Differential Revision: https://phab.enlightenment.org/D779
2014-04-22 13:10:00 -04:00
Chidambar Zinnoury be6b912adb Bugfix: e syscon: Cleanup everything when closing the dialog by clicking outside of it.
Inputs were still being held, leading to inability to interact with windows unless restarting Enlightenment.
2014-04-21 23:24:21 +02:00
Chidambar Zinnoury f193f90ce8 Bugfix: e syscon: Use correct coordinates to have the dialog centered on multiple zones. 2014-04-21 23:04:47 +02:00
Chidambar Zinnoury 36a4948085 Bugfix: e filepreview widget: No need to compute dimensions and resize widgets at each and every single frame.
Doing it once on file opening should be enough.
2014-04-21 22:40:45 +02:00
Chidambar Zinnoury b4a58ad874 Bugfix: e fileman: Correct automagic window size computation.
When available width is less than minimum width, the height was computed according to the available width, but the window width was effectively the minimum width: its height was thus more than needed.

 The function now takes the minimum dimensions so that correct height and width are computed.
2014-04-21 21:54:15 +02:00
Chidambar Zinnoury 233347209d Bugfix: e fileman: Correct typo on height computation. 2014-04-21 21:53:05 +02:00
Chidambar Zinnoury 07cd656320 Bugfix: e fileman: Fixe information popup placement.
– Use zone coordinates on desktop icons to have the popup placed where it should be with multiple screens.
– Use correct window content coordinates to account for the client frame.
2014-04-21 19:36:37 +02:00
Chidambar Zinnoury c52d6e201a Bugfix: e filepreview widget: Use correct units for devices sizes.
This will also make them consistent with file sizes.
2014-04-21 16:32:02 +02:00
Chidambar Zinnoury e045d2c287 e xkbswitch: Add check changed. 2014-04-21 15:56:04 +02:00
Chidambar Zinnoury 2b870ed318 e xkbswitch: Align indentation. 2014-04-21 15:56:04 +02:00
Chidambar Zinnoury 51935ac26d Bugfix: e xkbswitch: Disable both up and down buttons when there is only one configuration. 2014-04-21 15:56:04 +02:00
Chidambar Zinnoury 7496cf207d e music-control: Add MPD support. 2014-04-21 15:56:04 +02:00
Chidambar Zinnoury f63e53530a e syscon: Add check changed. 2014-04-21 15:56:03 +02:00
Chidambar Zinnoury 041132bacf e system: Show units. 2014-04-21 15:56:03 +02:00
Chidambar Zinnoury 0414a17fdc e syscon: For user-friendliness, show “System Controls” instead of “Syscon” on labels. 2014-04-21 15:56:03 +02:00
Chidambar Zinnoury 485fb36f02 Bugfix: e fileman: Client coordinates are not accounted against current zone position, so we should use them when computing maximum width and height.
This helps computing optimal dimensions when using multiple screens.
2014-04-21 15:56:03 +02:00
Chidambar Zinnoury 853f8b3c9a e fileman: Use a macro for minimum dimensions instead of hardcoding them at several places. 2014-04-21 15:56:03 +02:00
Chidambar Zinnoury 3e95955a5c Bugfix: e fileman: Typo on maximum height condition. 2014-04-21 15:56:03 +02:00
Chidambar Zinnoury edaf24d3b0 e: It’s now 2014! 2014-04-21 15:56:03 +02:00
Carsten Haitzler 8e49b69796 re-order icon finding for border to use the most reliable source first 2014-04-19 09:08:37 +09:00
Gwanglim Lee ffcc5e72d9 null check ecstack
Summary: fix segmentation fault error

Test Plan:
run enlightenment (wl only server) -> run elementary_test -> run terminlogy
-> move cursor to elementary_test -> click on elementary_test

Reviewers: raster, devilhorns, zmike

CC: cedric

Differential Revision: https://phab.enlightenment.org/D770
2014-04-18 12:51:36 -04:00
Carsten Haitzler 4cce0080b8 fix resent eo changes to e that break updating labels and toggles
this fixes D1172
2014-04-18 09:53:00 +09:00
Carsten Haitzler bdc3d5b5e3 formatting 2014-04-18 09:39:16 +09:00
Wonguk Jeong fb437cd1b0 comp_x_screensaver: screensaver off bug fix
Summary:
Can not turn off screensaver due to condition check bug.

@fixes

Test Plan: enlightenment -> do nothing -> screen saver on -> mouse/key input -> check whether screen saver is turned off or not

Reviewers: raster, cedric, zmike

Reviewed By: raster

CC: seoz, cedric

Differential Revision: https://phab.enlightenment.org/D766
2014-04-18 09:35:45 +09:00
Carsten Haitzler cf90b84a42 fix screensaver/blanking issue where a ss on/off events come in together 2014-04-17 13:55:39 +09:00
Gwanglim Lee fdd4d50146 Fixed a problem with e wl server that sent invalid key value to wl client. (server-side)
Summary:
This problem occurred due to xkb_keysym_t value of libxkbcommon by e wl server.
e wl server should pass keycode from evdev input device on to wl client.
In order that e wl server receives valid keycode Ecore_Event_Key should have
an extended data member. This patch should be applied with client side patch (efl).

Test Plan: run e wl server -> create wl client -> type keys

Reviewers: raster, devilhorns, zmike

Reviewed By: devilhorns

CC: cedric

Differential Revision: https://phab.enlightenment.org/D713
2014-04-14 08:32:51 -04:00
Mike Blumenkrantz 7274ffa742 improve eolian build dependency 2014-04-11 13:40:58 -04:00
Mike Blumenkrantz a2026425d1 mfw I forget git add
..........................__......
.................,-~*`¯lllllll`*~,....
...........,-~*`llllllllllllllllll¯`*-,..
......,-~*lllllllllllllllllllllllllllll*-,.
...,-*llllllllllllllllllllllllllllllllll.\.
.;*`lllllllllllllllllllllllllll,-~*~-,llll\....
..\lllllllllllllllllllllllllll/......\;;;;,-`~-,.
...\lllllllllllllllllllll,-*....`~-~-,...(.(¯`*,`,.
....\llllllllllll,-~*..............)_-\..*`*;..).
.....\,-*`¯,*`)............,-~*`~.............../...
......|/.../.../~,......-~*,-~*`;................/.\..
...../.../.../.../..,-,..*~,.`*~*................*...\..
....|.../.../.../.*`...\...........................)....)¯`~,...
....|./.../..../.......)......,.)`*~-,............/....|..)...`~-,.
..././.../...,*`-,.....`-,...*`....,---......\..../...../..|...¯```*~-,,
...(..........)`*~-,....`*`.,-~*.,-*......|.../..../.../...............\.
....*-,.......`*-,...`~,..``.,,,-*..........|.,*...,*...|..............\.
.......*,.........`-,...)-,..............,-*`...,-*....(`-,............\.
..........f`-,.........`-,/...*-,___,,-~*....,-*......|...`-,..........\.
2014-04-10 19:33:05 -04:00
Mike Blumenkrantz 8f2859a198 fix ibox eo errors 2014-04-10 19:06:04 -04:00
Mike Blumenkrantz b49957bf9b preserve client stacking after compositor effects
fix T1065
2014-04-10 19:01:50 -04:00
Mike Blumenkrantz 47cfb31752 comp_object now uses eo, e_comp_object_signal* -> edje_object_signal*
also cw->clip is gone
2014-04-10 19:01:47 -04:00
Wonguk Jeong c5c7b4733a efm: fix bugs during renaming multiple files and copying file into same directory
Summary:
Since E_FM_OP_OVERWRITE_RESPONSE_NO was sent before file renaming, src had been changed as next file.
->send E_FM_OP_OVERWRITE_RESPONSE_NO after file renaming.

File became empty if I copy a file into same directory
--> first of all, prevent move, rename, symlink into same directory. in case of copy, attach " (copy)" postfix after file name automatically. (need to decide postfix policy)

fixes T739

Reviewers: zmike, raster

CC: seoz, cedric

Maniphest Tasks: T739

Differential Revision: https://phab.enlightenment.org/D707
2014-04-10 11:09:36 +09:00
Mike Blumenkrantz 11f9dcfd72 fix null deref in e_shelf
CID 1039825
2014-04-04 15:26:11 -04:00
Mike Blumenkrantz 9d0f4b7036 use e_util_strcmp() in e_font stuff
CID 1039827, 1039826
2014-04-04 15:24:01 -04:00
Mike Blumenkrantz 19bc0d5a5e reduce strstr use in xkb parser
CID 1039849
2014-04-04 15:14:08 -04:00
Mike Blumenkrantz 05d09f7c51 null check xkb layout list
CID 1039869
2014-04-04 15:04:28 -04:00
Mike Blumenkrantz 6beb98c4e1 remove mixer wizard check
alsa is no longer the only output method, so this was a bogus check anyway

CID 1039872
2014-04-04 15:04:28 -04:00
Mike Blumenkrantz 09aefdeb89 remove winlist dead code
CID 1039873
2014-04-04 15:04:28 -04:00
Mike Blumenkrantz ee3370d226 bugfix: unify temp module temperature_get_bus_files() functions
CID 1039874
2014-04-04 15:04:28 -04:00
Mike Blumenkrantz ed50455cde bugfix: check notification icon size correctly
CID 1039875
2014-04-04 15:04:28 -04:00
Mike Blumenkrantz 861db30df2 remove fileman dead code
CID 1039878
2014-04-04 15:04:28 -04:00
Mike Blumenkrantz 8d32ad61d6 simplify/improve evry files dead code and maybe fix or add a bug
CID 1039879
2014-04-04 15:04:28 -04:00
Mike Blumenkrantz 1950f54caf bugfix: correctly check evry trigger matches
CID 1039880
2014-04-04 15:04:28 -04:00
Mike Blumenkrantz 918682dfb4 remove transition config dead code
CID 1039881
2014-04-04 15:04:28 -04:00
Mike Blumenkrantz 2799be96e9 remove font config dead code
CID 1039882
2014-04-04 15:04:28 -04:00
Mike Blumenkrantz b82ef28332 remove impossible/unnecessary randr rotation checks
CID 1039944
2014-04-04 15:04:28 -04:00
Mike Blumenkrantz 18cc2222f3 remove unnecessary battery check
CID 1039945
2014-04-04 15:04:28 -04:00
Mike Blumenkrantz ba3ffcf029 remove a bunch of unused e_util edje icon functions
CID 1039948, 1039946

removals: e_util_*edje_icon_list*
2014-04-04 15:04:28 -04:00
Mike Blumenkrantz 91aee716cc bugfix: comp config dialog correctly detects effects disabled/fast states
CID 1039957, 1039956
2014-04-04 15:04:28 -04:00
Mike Blumenkrantz e6e764cba9 check more pulse mixer returns
CID 1039959, 1039960
2014-04-04 15:04:28 -04:00
Mike Blumenkrantz 1285ba4196 check import config dialog unlink() return value
CID 1039964
2014-04-04 15:04:28 -04:00
Mike Blumenkrantz 11197cb684 check rename() return value
CID 1039966
2014-04-04 15:04:28 -04:00
Mike Blumenkrantz ed4eb3b6e0 check pulse mixer fd dup return
CID 1040123
2014-04-04 15:04:28 -04:00
Mike Blumenkrantz 789a0acbb1 remove unused ibar variable set
CID 1155291, 1058715
2014-04-04 15:04:28 -04:00
Mike Blumenkrantz 360707e9b1 fix tiling memory corruption
CID 1186206
2014-04-04 15:04:28 -04:00
Mike Blumenkrantz 358ba0f36f e_bindings_key_allowed() handles NULL param
CID 1191998
2014-04-04 15:04:27 -04:00
Mike Blumenkrantz cb3548f0f6 null check xkb parser
CID 1193251
2014-04-04 15:04:27 -04:00
Mike Blumenkrantz c17d33368c check pixmap_size_get() return in e_pointer
CID 1195448
2014-04-04 15:04:27 -04:00
Seunghun Lee 4d8920df06 fix crash when access pager_config which is null.
Summary:
crash was happend when user do logout the enlightenment with pager16.
pager_config was freed in e_modapi_shutdown(),
but after that, there was accessing pager_config again in _gc_shutdown() by called gadman_shutdown().

Reviewers: zmike, raster, cedric, seoz

CC: cedric

Differential Revision: https://phab.enlightenment.org/D694
2014-04-03 19:23:57 +09:00
Mike Blumenkrantz 95a8fed0bf unify comp object stacking
these were nearly identical, and sooner or later there was going to be an unfortunate c/p error
2014-04-02 14:16:34 -04:00
Mike Blumenkrantz cfe26ff838 comp docs part 1: comp objects 2014-04-02 13:06:28 -04:00
Mike Blumenkrantz b9e6a624ef fix frame size calc check to account for themes with 0 height 2014-04-02 12:31:33 -04:00
Mike Blumenkrantz 3f2efbc548 fix client layer marker detection/usage in wayland
this is the correct fix for D687
2014-04-02 11:07:22 -04:00
Seunghun Lee 597aec1710 remove unused comp object variable use and function call in show helper
Reviewers: zmike

Differential Revision: https://phab.enlightenment.org/D686
2014-04-02 09:27:20 -04:00
Gwanglim Lee 26d3075e3d wl pointer configure: fix typo
Summary: ews->geometry.y needs to be set.

Test Plan: N/A

Reviewers: raster, devilhorns, zmike

Reviewed By: devilhorns

CC: cedric

Differential Revision: https://phab.enlightenment.org/D688
2014-04-02 10:39:07 +01:00
Tom Hacohen dc05d96659 Fix client border changing issues
The code was zeroing the flag that tells e to change the border after
the callbacks about frame changes. This means that one couldn't change
the border from within those callbacks. This commit fixes this issue.
2014-03-31 15:24:12 +01:00
Carsten Haitzler 0709b9cfdd disable wp2 module
fixes T954
2014-03-31 19:04:20 +09:00
Mike Blumenkrantz a291211b13 bugfix: efm current .desktop fetching now returns the right .desktop
fix T792
2014-03-28 12:23:18 -04:00
Mike Blumenkrantz 96806eb425 bugfix: swallow efm background objects after applying theme
fix T792
2014-03-28 12:23:18 -04:00
Mike Blumenkrantz 5503e29169 stringshare_replace in fwin: it exists for a reason, stop using macros ffs 2014-03-28 12:23:18 -04:00
Mike Blumenkrantz 32e928b55b bugfix: ibar now scrolls correctly during drags
fix T794
2014-03-28 12:23:18 -04:00
Stefan Schmidt ff874b128a music-control: Do not leak the allocated metadata strings
Fix for ca07e7d505

Thanks are going to Davide Andreoli for spotting it.
2014-03-28 10:51:29 +01:00
Stefan Schmidt 4edf57320e modules/ibar: Fix condition check for edje emits
This fixes a copy and paste error which sneaked into
daa98e867d

CID 1194780
2014-03-28 10:14:37 +01:00
Mike Blumenkrantz 114b411da1 never use new clients for stacking
fix Tcedric
2014-03-27 21:27:51 -04:00
Mike Blumenkrantz da5bd16e12 greatly improve child dialog placement, FIXME--
fix T980
2014-03-27 19:47:31 -04:00
Mike Blumenkrantz ea3439b664 Revert "move comp object tiler creation to helper function to catch retries"
This reverts commit f4e4b2fc4f.

testing commit that wasn't supposed to go upstream
2014-03-27 17:01:22 -04:00
Mike Blumenkrantz d59fa0409c fix access module build
if nobody noticed this was even broken for 3 months, why is it still in the tree?
2014-03-27 16:54:58 -04:00
Mike Blumenkrantz e49b3beff1 ensure minimum X parent window size of 1x1
fix T1098
2014-03-27 16:47:19 -04:00
Mike Blumenkrantz f4e4b2fc4f move comp object tiler creation to helper function to catch retries 2014-03-27 16:47:19 -04:00
Mike Blumenkrantz 6308846480 don't refocus hidden clients on desk flip
probably fix T1083
2014-03-27 16:47:19 -04:00
Mike Blumenkrantz 7ccba3bdc3 null check _evry_items_sort_func() for users with broken systems
fix T1125
2014-03-27 16:47:19 -04:00
Mike Blumenkrantz 6e72796544 check key events for both key and keyname bindings
fix T1119
2014-03-27 16:47:19 -04:00
Mike Blumenkrantz 50a37adb6e ignore mouse movements on client during keyboard actions
fix T1097
2014-03-27 16:47:19 -04:00
Mike Blumenkrantz 3f10e7557f ignore X layer window mouse events
fix T1130
2014-03-27 16:47:19 -04:00
Mike Blumenkrantz 110f62ca61 always unclip/uneffect clients when changing desks
probably fix T1126
2014-03-27 16:47:18 -04:00
Mike Blumenkrantz 53824eb309 redo input rects after comp effect layer changes
fix T1070
2014-03-27 16:47:18 -04:00
Mike Blumenkrantz 18120e1b5a remove invalid shelf autohide window check which would always be wrong 2014-03-27 16:47:18 -04:00
Mike Blumenkrantz 42f43c9311 disable comp object animation hooks if animations are disabled 2014-03-27 16:47:18 -04:00
Mike Blumenkrantz daa98e867d fix lots of edje emits on non-edje objects 2014-03-27 16:47:18 -04:00
Mike Blumenkrantz f2f45428ff +e_icon_edje_get() 2014-03-27 16:47:18 -04:00
Stefan Schmidt 22278399d3 tiling: Free allocated memory on error path.
We don't use new_node in this code path. Free before returning.

CID 1186205
2014-03-27 16:06:06 +01:00
Stefan Schmidt ca07e7d505 bugfix: music_control: Use correct markup for metadata text.
We piped the plain metadata text to edje TEXTBLOCK which might interpret
some of the characters as markup. Better convert it to the correct markup
first. The actual bug case was a & in the metadata cut off the rest of
the text. Now we get the correct &amp before sending it of to edje.

Fixes T1061
2014-03-27 12:51:38 +01:00
Carsten Haitzler 1e50cb1dc6 don't delete client objects when _e_client_hook_call returns false.
_e_client_hook_call() returns false when object refcount hit 0... ie..
it's been deleted. it's simply invalid memory access to then del the
object thats already gone to 0 refcount and been deleted/freed.
2014-03-26 15:32:53 +09:00
Carsten Haitzler b6421e7660 tasks - fix tasks on other screens to properly show all window content
this fixes T1120
2014-03-25 22:44:04 +09:00
Mike Blumenkrantz 24296fa005 use eo to shut up harmless eo menu errors 2014-03-24 12:34:07 -04:00
Mike Blumenkrantz 3d8f5d3b05 add eo headers, aka Captain #define 2014-03-24 12:34:07 -04:00
Sebastian Dransfeld a08c40df7b ilist: Remove unused assignment
CID 1039758
2014-03-24 13:26:20 +01:00
Sebastian Dransfeld 68719520e6 fm: Check return of strrchr
strrchr can return NULL, so we need to check the return value.

CID 1039861
2014-03-24 13:23:39 +01:00
Sebastian Dransfeld 2d9f5764a3 fm: Fix weird test
ic is always true for this function, else dereference would fail. So the
only valid thing to check is whether we already have a drop_icon.

CID 1039829
2014-03-24 13:20:25 +01:00
Sebastian Dransfeld 81c384de9f dialog: allow setting of NULL icon
If NULL is passed as icon, icon should be disabled.

CID 1039951
2014-03-24 13:13:53 +01:00
Sebastian Dransfeld 168dc8ef38 comp: no need to assign pointer before return
As we return after the list free, no need to set the pointer.

CID 1087717
2014-03-24 13:02:56 +01:00
Sebastian Dransfeld ef208ad96b systray: deref pointer after check
CID 1193253
2014-03-24 12:59:14 +01:00
Mike Blumenkrantz 83475dad7e set wayland display socket based on e_ipc_socket name 2014-03-20 14:06:41 -04:00
Mike Blumenkrantz 2bbab7e525 export e_ipc_socket filename as extern variable 2014-03-20 14:06:41 -04:00
Tom Hacohen 07841a6b5e Tiling: start migrating the code to use smart callbacks.
Those are meant to be better than the e hooks.
2014-03-20 17:40:23 +00:00
Mike Blumenkrantz c47bf94cdf hook sticky smart callbacks properly inside comp object 2014-03-20 11:38:58 -04:00
Mike Blumenkrantz b5a04496b7 add stick/unstick client smart callbacks 2014-03-20 11:31:32 -04:00
Stefan Schmidt 04a5a11a8f e_pointer: Fix missing if for else if condition
Fixing devilhorns commit and run commit. If we have a condition we want
to check we need an else if not a simple else. Always compile before push.
Especially the small and simple changes. :)
2014-03-20 15:50:51 +01:00
Chris Michael d0b61e4b88 bugfix: Properly hide/show pointer_image & pointer_object based on if
the pointer is located on an existing canvas

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-20 14:16:42 +00:00
Chris Michael 5ce5d2d90b bugfix: Set pass_events and layer of the pointer image if we are
creating a new one.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-20 14:16:42 +00:00
Cedric BAIL ffe4bf794e e: let's just completely blacklist NVidia driver for Wayland. 2014-03-20 20:46:54 +09:00
Chris Michael db40e4b67e bugfix: Fix crash on eglTerminate with buggy Nvidia blob driver
NB: Thanks for the report cedric ;)

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-20 10:18:44 +00:00
Chris Michael 52532f9a32 Don't leak the allocated client object if we are returning null from
e_client_new

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-20 10:18:44 +00:00
Chris Michael 5b77c566e6 Use ecore_wl functions to return the pointer location if we are
running as wayland-only

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-20 10:18:44 +00:00
Sebastian Dransfeld 30846ee4ea randr: Update lid status when outputs change
If we only have lid, it will be active even though lid is closed. If we
connect a monitor we want the lid to deactivate.
2014-03-19 13:37:34 +01:00
Chris Michael 75d25f8c47 Fix the "Fix more wayland crashes" commit so that we can build for
wayland-only again

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-19 07:47:20 +00:00
Mike Blumenkrantz c81e649992 fix more wayland crashes 2014-03-18 18:15:24 -04:00
Mike Blumenkrantz c04d754ac5 enabling drm output module should NOT require X-less build.
these defines all need to be changed from HAVE_WAYLAND_ONLY to something like WITH_X or we're going to have lots of problems with xwayland later on
2014-03-18 16:14:04 -04:00
Mike Blumenkrantz af3f435d98 systray stop crashing in wayland!!!! 2014-03-18 13:22:11 -04:00
Chris Michael 5c322c40c4 @bugfix: Set ecore_wayland into 'server mode' before we call init so
that it does not stall and we end up sitting forever.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:05 +00:00
Chris Michael 645cb48dd5 @bugfix: Check return of e_comp_wl_init and initialize ecore_wl library
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:05 +00:00
Chris Michael 3d28a91c6b @bugfix: Create window pointer for wayland clients
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:05 +00:00
Chris Michael 9e68b402a4 @bugfix: Initialize the module idler even If we are wayland-only
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:05 +00:00
Chris Michael 4bb1d8f390 @bugfix: Only load external compositing modules if we are wayland-only
@bugfix: Initialize e_comp_wl if we are wayland-only OR supporting
wayland clients.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:05 +00:00
Chris Michael f3da557586 @bugfix: Fix e_win elm window trapping for wayland-only
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:05 +00:00
Chris Michael 160412dcf2 Simplify e_canvas_new code slightly for wayland-only and
wayland-client support.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:04 +00:00
Chris Michael 3d10a3d34e @bugfix: Fix pointer to work in drm and also fix some formatting
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:04 +00:00
Chris Michael 915f8f0613 @bugfix: Fix building for WAYLAND_ONLY by using the proper define
sed -i 's/WAYLAND_ONLY/HAVE_WAYLAND_ONLY/g'

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:04 +00:00
Chris Michael a32d74d1c7 @feature: Add new drm compositing module
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:04 +00:00
Mike Blumenkrantz a2025ddaad ignore size change configurerequests during maximize if not also changing position
correcty fixes gtk window (un)maximize
2014-03-17 12:56:21 -04:00
Mike Blumenkrantz d8375aaf9d Revert "apply client resize limit for all possible size values during maximize calcs"
This reverts commit 08acb0c6aa.

fix T1102
2014-03-17 12:49:44 -04:00
Mike Blumenkrantz 9859daee07 bugfix: get entry width based on viewport size, not entry size
things like icon properties dialog now fit on a 4k monitor
2014-03-17 12:24:03 -04:00
Mike Blumenkrantz 791ed12f7b fix elm win usage 2014-03-14 12:38:01 -04:00
Mike Blumenkrantz 9f310291a7 don't change backlight on zone shutdown 2014-03-14 12:00:23 -04:00
Mike Blumenkrantz ee1cc930c1 ibar mouseover menu no longer breaks when client menu is activated 2014-03-14 11:42:09 -04:00
Carsten Haitzler ad6aa3db71 part of previous commit - also set delete_requested to 0 2014-03-15 00:00:27 +09:00
Mike Blumenkrantz a6148e5e56 fix client resistance visibility check typo
fix T1087
2014-03-14 09:51:57 -04:00
Carsten Haitzler b1373fe63f fix hiding of windows when delete is requested
this is applicable to e19 only (you can't backport this patch as-is -
e19 is too different). this fixes T1063.
2014-03-14 16:25:14 +09:00
Mike Blumenkrantz 19f8126847 prevent fallthrough in determining gcc visibility
CID 1040127
2014-03-13 13:10:55 -04:00
Mike Blumenkrantz b9cdeb17f5 add note about switch statement fallthrough
CID 1040128
2014-03-13 13:09:43 -04:00
Mike Blumenkrantz ce429495bb bugfix: don't deref teamwork pointer after null check
CID 1040134
2014-03-13 13:07:33 -04:00
Mike Blumenkrantz a54fda4530 bugfix: don't deref possibly-null value in mouse bindings
CID 1040138
2014-03-13 13:06:08 -04:00
Mike Blumenkrantz 4b58fa9a4e replace ev->keyname with ev->key
see efl 5ae4cfd1923e502731f4d8fc2bf67b1f536a9216
2014-03-13 13:03:34 -04:00
Mike Blumenkrantz 8422eea8d0 remove unnecessary battery_config null check
CID 1040140
2014-03-13 12:55:24 -04:00
Mike Blumenkrantz d391e5c130 validate params for e_dnd_util_text_uri_list_convert()
CID 1040144
2014-03-13 12:52:36 -04:00
Mike Blumenkrantz 457a385fa7 clamp screen sizes to 1 to avoid impossible division-by-zero for window shots
CID 1040148
2014-03-13 12:50:56 -04:00
Mike Blumenkrantz e0a5cd6e7d bugfix: correctly calculate minimum flowlayout rows
CID 1132740
2014-03-13 12:44:47 -04:00
Mike Blumenkrantz 01abad3f64 bugfix: efm_op no longer tries to close invalid fds during delete ops
CID 1132741
2014-03-13 12:41:53 -04:00
Mike Blumenkrantz 4b3e2797a0 bugfix: don't use external log domain in systray
CID 1132742
2014-03-13 12:40:27 -04:00
Mike Blumenkrantz 6142845ef8 bugfix: don't use external log domain in music player
CID 1132743
2014-03-13 12:38:22 -04:00
Mike Blumenkrantz cea010dce0 bugfix: don't crash when saving screenshots with no file extension
CID 1132744
2014-03-13 12:35:43 -04:00
Mike Blumenkrantz b9eaf4d239 bugfix: don't crash on possibly-null gadman bg string extensions
CID 1132749
2014-03-13 12:35:39 -04:00
Mike Blumenkrantz b373b561e4 check X comp_data existence in pixmap PRESENT usage during refresh
CID 1155279
2014-03-13 12:22:04 -04:00
Mike Blumenkrantz 450d6cf321 add comments to suppress false positives in intentional switch fallthroughs
CIDs 1155283, 1155282, 1155281
2014-03-13 12:20:38 -04:00
Mike Blumenkrantz 9db01b9cbf don't check for non-pointer existence in lokker pin validation
CID 1155284
2014-03-13 12:15:52 -04:00
Mike Blumenkrantz c545deb81c fix gadman resistance checking for fake/desk shelves 2014-03-13 12:15:11 -04:00
Mike Blumenkrantz 26cbbe6723 improve client positioning resistance accuracy for hidden clients and fake shelves 2014-03-13 12:12:28 -04:00
Mike Blumenkrantz fe5f8df001 use E_CLIENT_FOREACH macro for resist calcs
CID 1155285
2014-03-13 12:07:49 -04:00
Mike Blumenkrantz 3f3322cb9c null check auth current user get
CID 1155286
2014-03-13 12:06:04 -04:00
Mike Blumenkrantz 865dc17221 null check client on X stack request
CID 1155287
2014-03-13 12:05:13 -04:00
Mike Blumenkrantz ddcc678d78 ensure va_end is called when creating new pixmaps
CID 1155292
2014-03-13 12:02:11 -04:00
Mike Blumenkrantz de03331469 fix indent for iconic hint setting
seriously?

CID 1156985
2014-03-13 12:00:17 -04:00
Mike Blumenkrantz 537b4054d3 simplify/optimize e_win show trap
CID 1163853
2014-03-13 11:58:16 -04:00
Mike Blumenkrantz 6dd98df0d6 remove all remaining efl version check defines 2014-03-13 11:55:29 -04:00
Mike Blumenkrantz d0589662c5 bugfix: check for unicode string end in client menu
CID 1186203
2014-03-13 11:51:21 -04:00
Mike Blumenkrantz 2b3906d8da bugfix: don't crash when passing NULL desk to e_client_under_pointer_get
CID 1186204
2014-03-13 11:47:44 -04:00
Mike Blumenkrantz dacb821f05 trivial dead code--
CID 1187922
2014-03-13 11:43:53 -04:00
Mike Blumenkrantz 3583d76839 trivial dead code--
CID 1187923
2014-03-13 11:42:49 -04:00
Mike Blumenkrantz b8a3e1ed4f fix probably-impossible divide-by-zero in menu item layout
CID 1187924
2014-03-13 11:41:17 -04:00
Mike Blumenkrantz 400c1f5177 make win->client check more explicit in efm_opinfo
CID 1187925
2014-03-13 11:38:52 -04:00
Mike Blumenkrantz 0a316209aa bugfix: set connman pending.disconnect when disconnecting a service 2014-03-13 11:25:01 -04:00
Mike Blumenkrantz ded3b76723 make connman if statements more clear for freeing data
CID 1039738
2014-03-13 11:24:30 -04:00
Mike Blumenkrantz b25706727b bugfix: don't iterate with or access freed pointer in comp match dialog
CID 1039740
2014-03-13 11:18:14 -04:00
Mike Blumenkrantz 9f3f5e29d1 bugfix: ensure use of non-garbage values for menu item icon placeholders
CID 1039769, 1039768
2014-03-13 11:11:14 -04:00
Mike Blumenkrantz 07135d8b21 bugfix: use more descriptive + accurate buffer size in batget iterator
CID 1039801
2014-03-13 11:01:52 -04:00
Mike Blumenkrantz 16e7c57ba4 bugfix: prevent out of bounds access in systray theme setup
CID 1039843
2014-03-13 10:53:55 -04:00
Mike Blumenkrantz cac879d289 use a more obvious iterator limit for gadman edit end
CIDs 1039846, 1039845, 1039844
2014-03-13 10:51:43 -04:00
Mike Blumenkrantz 5f68ea5c8d bugfix: prevent out of bounds write in e_intl_locale_parts_get()
CIDs 1039848, 1039847
2014-03-13 10:46:28 -04:00
Mike Blumenkrantz cc8eb78352 bugfix: ensure null termination of string in xsettings config
CID 1039967
2014-03-13 10:43:08 -04:00
Mike Blumenkrantz 8b227c33b7 Revert "e_exec - after an instance has its exe deleted - set exe to NULL"
This reverts commit 89fdebb9bf.

CID 1132151
2014-03-13 10:40:11 -04:00
Mike Blumenkrantz 2425ec363c always init container coords when beginning gadcon drag
CIDs 1135457, 1135456
2014-03-13 10:37:01 -04:00
Mike Blumenkrantz 94072211c3 fix mixer config leak on config failure
CID 1135539
2014-03-13 10:31:07 -04:00
Mike Blumenkrantz bf66547c15 fix null termination of client desktop string matching
CID 1155274
2014-03-13 10:28:33 -04:00
Mike Blumenkrantz 1abc612569 ensure valid client layers in client stack iterating functions
CIDs 1155288, 1155280
2014-03-13 10:27:35 -04:00
Seunghun Lee 08acb0c6aa apply client resize limit for all possible size values during maximize calcs
Summary:
there was a problem that the app like gnome-terminal had not been restored to origin size after maximization.
I think that's because E overwrite the data of saved.x/y to maximized size in ConfigureRequest handler.
The reason why ConfigureReuqest happen is that the window tried to resize itself properly, since E resize window without regard of size hints.

Reviewers: zmike, seoz

CC: cedric

Differential Revision: https://phab.enlightenment.org/D633
2014-03-13 10:15:13 -04:00
Seunghun Lee b137b7e741 fix use of same variable in e_desk double-loop
Reviewers: zmike, seoz

CC: cedric

Differential Revision: https://phab.enlightenment.org/D632
2014-03-13 09:38:11 -04:00
Mike Blumenkrantz 3f5ac7d9ab use static array of inlists for client hooks to reduce overhead 2014-03-13 09:35:06 -04:00
Mike Blumenkrantz ce3e7056ae remove unused vars 2014-03-13 09:34:10 -04:00
Seunghun Lee 48c28213c9 fix use of same temporary variable in for loop.
Summary: it caused crash when user edited desk's name after adding desk.

Reviewers: zmike, seoz

CC: cedric

Differential Revision: https://phab.enlightenment.org/D631
2014-03-13 08:46:39 -04:00
Mike Blumenkrantz 1a2f4087db defer netwm maximize hint apply to reduce canvas ops
improves maximize performance on apps like chromium which incrementally apply maximize states
2014-03-10 00:27:16 -04:00
Mike Blumenkrantz 5aa231f53e fix desklock custom bg starting dir display 2014-03-10 00:07:03 -04:00
Mike Blumenkrantz f9f6ddb971 bugfix: dim/undim actions don't require acpi triggers
fix T1067
2014-03-09 23:30:47 -04:00
Sebastian Dransfeld 11a7aa51ec tiling: gitignore
ignore created .edj file
2014-03-07 10:01:46 +01:00
Mike Blumenkrantz ae81d76a3c ignore ignored clients for X mouse events
fix T1058
2014-03-06 09:35:00 -05:00
Sebastian Dransfeld 35fea59e2d conf_randr: redo randr dialog to trust e_randr_cfg
Prevously conf_randr worked directly against ecore_x_randr. Now we
rather modify e_randr_cfg, and use e_randr to apply changes against
ecore_x_randr.
2014-03-06 15:18:15 +01:00
Sebastian Dransfeld c994e235f9 conf_randr: hide refresh rates when none to show 2014-03-06 15:18:15 +01:00
Sebastian Dransfeld d9acc5a5c2 conf_randr: don't store variable when used once 2014-03-06 15:18:15 +01:00
Sebastian Dransfeld 77ea4d2256 conf_randr: remove clone support
Clone isn't well supported in base randr config. Remove until it is.
2014-03-06 15:18:15 +01:00
Sebastian Dransfeld 6e87cec645 conf_randr: use refresh_rate function from e_randr 2014-03-06 15:18:15 +01:00
Sebastian Dransfeld 8c3b7800c9 randr: TODO++ 2014-03-06 15:18:15 +01:00
Sebastian Dransfeld c0d0afad32 randr: function to apply current config 2014-03-06 15:18:14 +01:00
Sebastian Dransfeld f6a0ec2753 randr: only activate outputs we want to connect 2014-03-06 15:18:14 +01:00