declared our 'roots' variable as Ecore_X_Window, but were allocating
as 'Window').
buffer_alloc: "malloc(num * 8UL)" allocates memory.
CID 1039601: Allocation size mismatch (SIZECHECK)
5. incorrect_multiplication: Allocating a multiple of 8 bytes to
pointer of type Ecore_X_Window, which needs 4 bytes.
NB: Fixes Coverity CID1039601
Signed-off-by: Chris Michael <cp.michael@samsung.com>
we are going to allocate space for a variable of a certain type, then
lets make sure we Declare that variable as the proper type).
NB: Fixes Coverity CIDs 1039602, 1039603, 1039604
Signed-off-by: Chris Michael <cp.michael@samsung.com>
wanted here...Or (!(ob->map->cur.map->count == 4)) ... but not much
difference either way ;)
NB: Fixes Coverity CID1039673
Signed-off-by: Chris Michael <cp.michael@samsung.com>
In its current model, cserve2 will reopen, reload and scale an
image whenever a new scaled version is requested by the client.
Instead, we can load the original image when too many scaled
versions are requested, and place the original in the LRU.
above, so fix. On a mkpath failure, print out the message, Then free
dname. Be sure to also free dname if we do not error.
NB: Fixes Coverity CID1039893
Signed-off-by: Chris Michael <cp.michael@samsung.com>
would not have gotten to this error handler if it did (so no point in
checking for it and calling functions using it).
NB: Fixes Coverity CID1039926
Signed-off-by: Chris Michael <cp.michael@samsung.com>
- Add "pixmap" structure to engine_data.
- Free the front and back pixmaps when the ecore_evas gets freed.
- On resize, drop the backing pixmap if size is different.
- Before we render, check pixmap size vs EE size and create new
backing pixmap if needed.
- After we have rendered into the backing pixmap, flip it to the
front so that any calls to "pixmap_get" will return the proper one.
- Add pixmap_new_internal code (the actual guts for all this)
NB: These can be used to create an internally double-buffered
ecore_evas that renders to a pixmap (not a window).
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Fix formatting in ecore_evas_window_get.
NB: This will be used to create an ecore_evas that Renders to a
Pixmap (not a window). As such, Some ecore_evas functions may
not operate as expected when using this type of ecore_evas.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
In some cases we could return extra formats that are outside of the
range. It's actually not completely fixed yet.
Thanks to clang-analyzer for detecting this.
Remove Image_Load_Opts and use Evas_Image_Load_Opts for cs2 master to
slave communication.
2 things to note:
- The struct size is bigger (but at the same time we removed a memcpy)
- The scale_load field is not passed to the slave
When opening an image, OPEN and SETOPTS were always sent
consecutively. Merging these two messages may improve the
performance a bit (not measured), but also simplify the
whole thing.
Note: cserve2 debug tools have not been fixed yet.
Carsten Haitzler
Mike Blumenkrantz
Chris Michael
Jean-Philippe Andre
José Roberto de Souza
maxerba
Ryuan Choi
Cedric Bail
ChunEon Park
Eduardo Lima (Etrunko)
Tom Hacohen