Summary:
elm.swallow.background part will be a default part for
widget's background image.
When entry widget's scrollable status is changed,
the background object will be moved to scr_edje or entry_edje.
Test Plan: N/A
Reviewers: kimcinoo, woohyun, cedric
Differential Revision: https://phab.enlightenment.org/D3677
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
elm.swallow.background part will be a default part for
widget's background image.
Test Plan: N/A
Reviewers: woohyun, kimcinoo, cedric, Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D3676
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Fix vertical drag style and logic.
For vertical spinner graggable should move
in y direction and since drag value is inverse
of spinner increment and decrement so delta should be inversed.
@fix
Test Plan:
1. Elementary test
2. Vertical spinner
Reviewers: cedric
Projects: #elementary
Differential Revision: https://phab.enlightenment.org/D3662
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
elm.swallow.background part will be a default part for
widget's background image.
Test Plan: N/A
Reviewers: woohyun, cedric, kimcinoo
Differential Revision: https://phab.enlightenment.org/D3675
Summary:
- This swallow part is for custom bg image.
- previous bg has to be hid.
Reviewers: kimcinoo
Differential Revision: https://phab.enlightenment.org/D3657
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
@fix T3132
If nobody sees issue with this change, this should be backported.
Signed-off-by: Godly T Alias <godly.talias@samsung.com>
Test Plan: elementary_test Genlist Tree, enable Tree effect
Reviewers: prince.dubey, SanghyeonLee, shilpasingh
Subscribers: govi, rajeshps
Maniphest Tasks: T3132
Differential Revision: https://phab.enlightenment.org/D3656
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Hover dismiss animation takes 0.5 sec to complete. if the genlist item_count
becomes zero, empty swallow is shown in dismiss animation.
@fix T3124
Signed-off-by: divyesh purohit <div.purohit@samsung.com>
Test Plan:
please run combobox example from elementary_test.
Open hover by pressing on left side button of combobox or pressing "enter/space" key in entry
contained in combobox.
Type a char which is not in any genlist item , for example "a' is not presented in any genlist
item.
empty swallow shouldn't seen in dismiss animation.
Reviewers: shilpasingh, cedric, raster
Subscribers: rajeshps, govi
Maniphest Tasks: T3124
Differential Revision: https://phab.enlightenment.org/D3630
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Even MBE item lose focus, item state did not changed before.
So i send a signal to make item state as default when item lose own focus.
Signed-off By: Kumar Navneet <k.navneet@samsung.com>
@fix
Test Plan:
Run MBE sample.
Click any item.
Click out of MBE area.
See the item still got a highlight.
Reviewers: Hermet, cedric
Differential Revision: https://phab.enlightenment.org/D2994
Conflicts:
data/themes/edc/elm/multibuttonentry.edc
Summary:
When focus is moved fast and continuously, newly created animator
conflicts with the animator for previous movement, so focus bounces
among locations.
This patch removes previous animator and move focus to the final
location before creating new animator.
Test Plan:
elementary_test -to focus
elementary_test -to genlist
Reviewers: raster, jpeg, cedric, Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D3611
Summary:
This patch removes unavailable references to nonexistent parts
from default theme.
Reviewers: raster, jpeg, cedric
Differential Revision: https://phab.enlightenment.org/D3609
Summary:
Continouous clicks on hover would need to ensure that variable
on_dismiss of combobox_vertical style in hover.edc should 0 when slot is being shown, otherwise events
would be disabled on hover even though swallow content is shown.
@fix
Signed-off-by: Divyesh Purohit <purohit.div@gmail.com>
Test Plan:
Click continouosly on combobox and events on hover would be
disabled.
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3601
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Apply gray-scale to vertical_separated_bar_glow image and increase the opacity
of the button, so that the text on the entry is visible.
@fix T3075
Signed-off-by: divyesh purohit <div.purohit@samsung.com>
Test Plan: please run combobox example from elementary_test
Reviewers: shilpasingh, cedric, raster
Maniphest Tasks: T3075
Differential Revision: https://phab.enlightenment.org/D3605
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Strangely, toggle couldn't afford it's icon space
at elementary_test -> check toggle.
Following to default style which is normal to avoid this wierd look.
Summary:
Initially combobox used hover's default style, this patch would make combobox use hoversel_vertical style.
@Fix T3075 for 2nd point.
Signed-off-by: divyesh purohit <div.purohit@samsung.com>
Test Plan: please run combobox example from elementary_test
Reviewers: shilpasingh, cedric, raster
Subscribers: rajeshps, govi
Maniphest Tasks: T3075
Differential Revision: https://phab.enlightenment.org/D3596
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
While applying scroller on hoversel, several lines for item size
calculation were added, but they failed to have item get proper size.
Now redundant codes are removed and some are fixed, and hoversel will
be shown more well-ordered.
Test Plan: elementary_test hoversel
Reviewers: jpeg, raster, cedric
Differential Revision: https://phab.enlightenment.org/D3589
Summary:
When continous mouse clicks happen hover emits the hide signals continously
to edje. As the embryo program for hiding requires some time to finish the
animation, if within that time another mouse click comes the program gets
invoked again and thus the hiding will get delayed till the mouse clicks ends.
This patch fix that issue by adding a flag for emitting signals.
@fix T3006
Signed-off-by: godly.talias <godly.talias@samsung.com>
Test Plan: elementary_test
Reviewers: cedric, conr2d, prince.dubey, shilpasingh, Princekrdubey
Reviewed By: shilpasingh, Princekrdubey
Subscribers: Princekrdubey, divyesh, govi, rajeshps
Maniphest Tasks: T3006
Differential Revision: https://phab.enlightenment.org/D3526
Summary:
It was changed for testing shrink mode signals.
But, it was unnecessary change for default theme.
Test Plan: N/A
Reviewers: zmike, jaehwan
Differential Revision: https://phab.enlightenment.org/D3536
Summary:
Combobox is a combinational widget of a drop-down list and single line entry.
Based on the text entered in the entry, the list items are filtered accordingly.
Signed-Off By: Cedric Bail <cedric.bail@free.fr>
Signed-Off By: Divyesh Purohit <div.purohit@samsung.com>
Test Plan: test_combobox.c is added to elementary test
Reviewers: raster, shilpasingh, cedric, jpeg, stefan_schmidt
Reviewed By: raster, shilpasingh, cedric
Subscribers: SanghyeonLee, shashank0990, singh.amitesh, tasn, raster, seoz, poornima.srinivasan, rajeshps, govi
Differential Revision: https://phab.enlightenment.org/D2537
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Hoversel Widget is designed in such a way that it accepts top/bottom/left/right directions , internally it uses hover widget which does not take care if its content goes of it's parent (Elm_Win in most cases) . this patch ensures that the drop-down content remains restricted in visible hover_parent. it would fix T2965
Signed-off-by: divyesh purohit <div.purohit@samsung.com>
Signed-off-by: Jee-Yong Um <conr2d@gmail.com>
Test Plan:
Open entry widget and right click to show a hoversel widget, check if the hoversel or hover content goes out of the window.
this is what hoversel would look like after this patch {F27551}
Screenshots of top-left / top-right/ bottom-left and bottom-right corners in entry after this patch
{F27553}
{F27554}
{F27555}
{F27557}
Reviewers: shilpasingh, conr2d, raster, cedric, Hermet
Subscribers: rajeshps, govi
Projects: #elementary
Maniphest Tasks: T2965
Differential Revision: https://phab.enlightenment.org/D3513
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The following new color classes
for scroller widget are added and changed.
Reviewers: raster, cedric, Hermet, kimcinoo, woohyun
Differential Revision: https://phab.enlightenment.org/D3493
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Apply ctxpopup color class
- ctxpopup_bg
Test Plan:
1. change ctxpopup bg color class in colorclass.edc
2. run elementary test
3. check the color of ctxpopup bg
Reviewers: Hermet, kimcinoo, woohyun, raster
Differential Revision: https://phab.enlightenment.org/D3492
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Apply popup color class
- popup bg
- popup title bg
- popup title text
- popup text
Test Plan:
1. change popup color class in colorclass.edc
2. run elementary test
3. check the color of popup
Reviewers: Hermet, kimcinoo, woohyun, raster
Differential Revision: https://phab.enlightenment.org/D3489
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The following new color classes and text classes
for spinner widget are added.
"spinner_bg", "Spinner Background"
@feature
Reviewers: raster, cedric, Hermet, kimcinoo, woohyun
Subscribers: SanghyeonLee, eagleeye, id213sin
Differential Revision: https://phab.enlightenment.org/D3488
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Add new text classes and color classes for Entry widget according to
consistency with other widget's class.
And it removes legacy classes. If we need to support backward
compatibility, the legacy classes have to be maintained in each widget.
Test Plan: N/A
Reviewers: cedric, woohyun, jaehwan, kimcinoo, raster
Subscribers: CHAN
Differential Revision: https://phab.enlightenment.org/D3486
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The following new color classes and text classes
for calendar widget are added.
"calendar_year_text" - Year Text in Title Area
"calendar_month_text" - Month Text in Title Area
"calendar_weekday_text" - Weekday Text
"calendar_day_text" - Day Text
"calendar_day_text_holiday" - Holiday Text
"calendar_day_text_today" - Today Text
"calendar_day_text_disabled" - Disabled Day Text
"calendar_day_selected" - Selected Day Effect
"calendar_day_highlighted" - Highlighted Day Effect
"calendar_day_checked" - Checked Day Effect
@feature
Test Plan: N/A
Reviewers: woohyun, raster, cedric, kimcinoo, jaehwan
Subscribers: CHAN
Differential Revision: https://phab.enlightenment.org/D3482
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
It is useful for changing item's state according to shrink mode.
@feature
Test Plan:
It includes a use case for the patch in toolbar default theme.
Run "elementary_test -to toolbar2".
Reviewers: jaehwan, woohyun, cedric, raster
Subscribers: eagleeye
Differential Revision: https://phab.enlightenment.org/D3481
Previously, clicking and holding the decrease or increase button would start the drag mode, which made the buttons pretty much unusable on a touchscreen.
Now, it is only set over the text button as expected.
For the record, dragging is unusable for a small count of discrete values as the value will change for each and every pixel movement–have a go at the months spinner test.
Summary:
The spinner buttons in elm_calendar widget can be replaced by elm_buttons.
Then, using elm_button widgets makes it much easier to maintain.
And the buttons has to be focusable with "tab" key just like elm_spinner widget.
The lagacy callbacks for signals from edje is not removed for backward compatibility.
@feature
Test Plan: elementary_test -> calendar, calendar2, calendar3
Reviewers: seoz, Hermet, kimcinoo, cedric, woohyun
Reviewed By: woohyun
Subscribers: CHAN
Differential Revision: https://phab.enlightenment.org/D3198
This change will hide the cursor once there is an actual change, and
there is a difference between the selection cursors. If there is no
difference, then it is better to show the cursor again.
previously, mousing out of an icon during the pulse animation would
instantly stop the animation. this looks strange and is quite noticeable
when mousing through a bar
Mike Blumenkrantz
Jaehwan Kim
Youngbok Shin
Subodh Kumar
Stefan Schmidt
SungTaek Hong
taehyub
Godly T Alias
divyesh purohit
Vitalii Vorobiov
woochan lee
Jee-Yong Um
Divyesh Purohit
Hermet Park
Jean-Philippe Andre
godly.talias
Hosang Kim
Chidambar Zinnoury
Yeshwanth Reddivari
Daniel Hirt