Sorry, I have forgotten adding comments to my patch.
OSM recommends to requesting map images distributively.
Please refere http://wiki.openstreetmap.org/wiki/Slippy_map_tilenames
I used 3 input parameters for selecting one from a, b, c or 1, 2, 3, 4
tile servers.
I attached patch with comments.
Signed-Off-By: TaeHwan Kim(ohpowel@gmail.com)
Signed-Off-By: ChunEon Park(hermet@hermet.pe.kr)
SVN revision: 65892
Subject: Re: [E-devel] [Patch][elm_map] Remove unnecessary flags
There are too may flags in elm_map. Most of them are duplicated and unnecessary.
I have removed "want", "download", "have" variables.
I use gi->job instead of "want" & "download".
I use ecore_file_exists() instead of "have" flags.
SVN revision: 65890
I have using elementary_test for testing elementary map widget.
But it use invalid object for signal callback. I have changed win --> map.
Also I have fixed invalid log message.
Signed-Off-By: TaeHwan Kim(ohpowel@gmail.com)
Signed-Off-By: ChunEon Park(hermet@hermet.pe.kr)
SVN revision: 65886
Subject: [E-devel] [patch] els_pan - bugfix gravity move
Date: Mon, 5 Dec 2011 13:29:48 +0900
Dear developers.
When gravity set on els_pan, user events are processing improperly.
Any touch event move pan to wrong position.
It's due to accumulate px, py.
So I fixed it.
Thanks
SVN revision: 65885
win_resize_object_add(win, subobj);
object_content_set(otherobj, subobj);
object_del(win);
ERR<21326>:elm-externals elm_widget.c:978 elm_widget_sub_object_del() removing sub object 0xdeadbeef (some_stupid_widget) from parent 0xRRRRRRRR (win), but elm-parent is different 0xFUCKTHIS (NOT EVEN A WIDGET)!
SVN revision: 65884
NOTE: As side fix, both genlist and gengrid now share their Widget_Data. Need
a lot more work to be clean and match our quality standard.
NOTE2: Genclear is now faster as it doesn't require to mark all item that need
to be removed, but just increase one int.
SVN revision: 65811
recent elementary api corrections.
I changed item class's 'label_get' to 'text_get'. But 'label_get' is still
supported by union structure. So 'label_get' will just give you
deprecated warnings while compiling but it's recommended to fix your
apps to 'text_get'. Sometimes when you initialize item class using
braces, you will get 'missing braces around initializer' but ignore
this. That warning will be gone after I remove 'label_get' backport. I
will remove this 'label_get' backport after I finish below
jobs.
[TODO]
1. Fix all apps in trunk.
2. Change edc "labels" to "texts" as well. I haven't done this yet.
SVN revision: 65751
deprecate all elm_gen APIs.
We will merge gengrid into genlist later and remove elm_gen.
I updated http://trac.enlightenment.org/e/wiki/ElementaryChanges
I will fix other libraries/programs in trunk soon.
SVN revision: 65700
a. Fix to handle the condition when read returns 0 and the content of buf is uninitialized in function handle_run inside file "src/bin/quicklaunch.c".
b. Indentation correction in function handle_run around the location of fix above.
Signed-Off-By: RAJEEV RANJAN <rajeev.r@samsumg.com>
Signed-Off-By: PRINCE KUMAR DUBEY <prince.dubey@samsung.com>
Signed-Off-By: ChunEon Park <hermet@hermet.pe.kr>
SVN revision: 65699
a. Handled memory allocation failure in function grid_create inside source file src/lib/elm_photocam.c of package elementary.
b. Fixed Memory leak in functiongrid_create due to return without releasing memory allocated for variable g of type Grid *.
Signed-Off-By: RAJEEV RANJAN <rajeev.r@samsung.com>
Signed-Off-By: PRINCE KUMAR DUBEY <prince.dubey@samsung.com>
Signed-Off-By: ChunEon Park <hermet@hermet.pe.kr>
SVN revision: 65698
Hi,
Attachment to the mail is elm_index patch.
Change Log:
a. Memory leak fix in function elm_index_item_append_relative due to memory allocated for item creation reamined allocated when the control returns.
b. Memory leak fix in function elm_index_item_prepend_relative due to memory allocated for item creation reamined allocated when the control returns.
Signed-Off-By: RAJEEV RANJAN <rajeev.r@samsung.com>
Signed-Off-By: PRINCE KUMAR DUBEY <prince.dubey@samsung.com>
Signed-Off-By: ChunEon Park <hermet@hermet.pe.kr>
SVN revision: 65697
Chang <hyoyoung.chang@samsung.com>
2011/10/27 Hyoyoung Chang <hyoyoung.chang@samsung.com>:
> Dear developers
>
> I made a patch to add elm_genlist_item_fields_update function.
> It can be used to updating genlist's item part without
realize/unrealize
> itself.
>
> Prototype is
> elm_genlist_item_fields_update
> (Elm_Genlist_Item *it, const char *part,
Elm_Genlist_Item_Field_Flags itf)
>
> Part supports globbing. Passing "*" to part means updating all parts.
> Item field can be one of icon, content and state.
> I think it's useful to speed up if an app updates frequently.
>
> Thanks
SVN revision: 65688
Fix to unreachable code in function elm_glview_resize_policy_set.
Signed-Off-By: RAJEEV RANJAN <rajeev.r@samsung.com>
Signed-Off-By: PRINCE KUMAR DUBEY <prince.dubey@samsung.com>
Signed-Off-By: ChunEon Park <hermet@hermet.pe.kr>
SVN revision: 65684
elc_naviframe.c: In function ‘_title_content_unset’:
elc_naviframe.c:786:17: warning: ‘content’ may be used uninitialized in this function
Signed-off-by: Mike McCormack <mj.mccormack@samsung.com>
SVN revision: 65682
Hi,
On behalf of Rajeev Ranjan, I am submitting the elm_gesture_layer patch.
Change Log:
a. Variable was used after freeing in function _remove_touched_device, now storing return value of eina_list_remove and then freeing pointer.
b. gesture pointer was dereferenced before checking it against NULL in function _rotate_test. Now dereferencing happens after NULL check.
c. Added NULL check for pointer before using it in function _event_process which is dereferenced in function _add_touched_device.
d. Memory leak fix in function elm_gesture_layer_add. Now using ELM_WIDGET_STANDARD_SETUP which takes care of NULL checks and freeing memory in case of failure.
Please review it.
I'd appreciate any comments on this.
Thank you,
Signed-Off-By: Rajeev Ranjan <rajeev.r@samsung.com>
Signed-Off-By: Prince Kumar Dubey <prince.dubey@samsung.com>
Signed-Off-By: ChunEon Park <hermet@hermet.pe.kr>
SVN revision: 65680
Hi,
On behalf of Rajeev Ranjan, I am submitting the elm_cnp_helper patch.
Change Log:
Removal of DEAD_CODE (Unreachable code statement tmppath = "/tmp").
Please review it.
I'd appreciate any comments on this.
Thank you,
SVN revision: 65666
Hi,
On behalf of Rajeev Ranjan, I am submitting the elm_flip patch.
Change Log:
a. Removed unnecessary comparison and assignment from the function _state_update inside file src/bin/test_flip_page.c. The comparison test will always be failed. Hence the assignment which was unreachable is removed.
b. Removed unnecessary comparison and assignment from the function _state_update inside file src/lib/elm_flip.c. The comparison test will always be failed. Hence the assignment which was unreachable is removed.
Please review it.
I'd appreciate any comments on this.
Thank you,
SVN revision: 65664
Hi,
On behalf of Rajeev Ranjan, I am submitting the elm_genlist patch.
Change Log:
a. Dead code removal in function _sizing_eval
b. Memory leak fix in function elm_genlist_item_insert_before due to return when wd->items is NULL and in this case, memory allocated for item was not getting free.
c. Memory leak fix in function elm_genlist_item_insert_after due to return when wd->items is NULL and in this case, memory allocated for item was not getting free.
Please review it.
I'd appreciate any comments on this.
Thank you,
SVN revision: 65662
it didn't work if orient were ELM_IMAGE_ROTATE_90_CW or CCW.
and it also make seg fault if application calls elm_image_orient_set more than twice.
for 90 or 270 rotation, we need seperate memory.
(It can be algorithm without more memory, but I selected readability than memory efficiency)
Before, els icon use file name for data2.
So it make problem, if file name was removed because of obj's data_set or size_set function.
I modified els icon code using copy data function.
SVN revision: 65634
Hi Mr. Park,
Change description: [ commit message ]
Bug: Hide signal sent twice in case of prev button, next button and icon swallow areas.
Fix: Hide signal sent only once in delete callback.
Thanks & Regards
Shilpa Singh
SVN revision: 65570
CC libelementary_la-elc_multibuttonentry.lo
elc_multibuttonentry.c: In function ‘_set_vis_guidetext’:
elc_multibuttonentry.c:309:20: warning: unused variable ‘en_width’
elc_multibuttonentry.c: In function ‘_resize_button’:
elc_multibuttonentry.c:741:16: warning: unused variable ‘button_text’
elc_multibuttonentry.c: In function ‘_add_button_item’:
elc_multibuttonentry.c:772:40: warning: unused variable ‘h_btn’
elc_multibuttonentry.c: In function ‘_entry_resized_cb’:
elc_multibuttonentry.c:1064:86: warning: unused parameter ‘event_info’
elc_multibuttonentry.c: In function ‘elm_multibuttonentry_item_select’:
elc_multibuttonentry.c:1531:12: warning: suggest explicit braces to avoid ambiguous ‘else’
elc_multibuttonentry.c: In function ‘_resize_button’:
elc_multibuttonentry.c:747:37: warning: ‘padding_inner’ is used uninitialized in this function
^Cmake: *** [libelementary_la-elc_multibuttonentry.lo] Error 1
Signed-off-by: Mike McCormack <mj.mccormack@samsung.com>
SVN revision: 65550
---------------------------------------------------
Dear Developers,
I added a new widget called “Multibuttonentry" which could be used as contact button in App
This widget allows a user to insert a text button.
text button is inserted by pressing the "Enter key"
If there is no space in the current row, the new button is entered in the next row. If the button is clicked, it will become focused.
And focused button can be removed by pressing the "backspace" key.
when items are added over 1 lines, if Multibuttonentry lost focus, it becase shrink mode (made it as 1 line)
Please review it's APIs and functionalities.
Thank you,
Goun
---------------------------------------------------
Widget was originally written by Hyunsil Park <hyunsil.park@samsung.com>.
It has been contributed to by the following people:
* Jihoon Kim <jihoon48.kim@samsung.com>
* WooHyun Jung <wh0705.jung@samsung.com>
* deasung.kim <deasung.kim@samsung.com>
* Myungjae Lee <mjae.lee@samsung.com>
* Goun Lee <gouni.lee@samsung.com>
* Mike McCormack <mj.mccormack@samsung.com>
* Daniel Juyung Seo <juyung.seo@samsung.com>
* Seunggyun Kim <sgyun.kim@samsung.com>
* sanghoon80.cho <sanghoon80.cho@samsung.com>
Signed-off-by: 이고은 <gouni.lee@samsung.com>
Signed-off-by: Mike McCormack <mj.mccormack@samsung.com>
SVN revision: 65548
elm_win.c: In function ‘elm_win_focus_get’:
elm_win.c:2182:4: warning: ‘return’ with no value, in function returning non-void
Signed-off-by: Mike McCormack <mj.mccormack@samsung.com>
SVN revision: 65527
Firstly, for efficiency, we add a Job to calculate the whole canvas. Jobs implicitly coallate work per event loop.
Calcuation of object can be a reasonably intensive set of work.
In the job callback we calculate the whole canvas with evas_smart_objects_calculate() to ensure that all objects have the correct geometry at this point.
Reviewed by Raster.
SVN revision: 65509
Previous part names are just the swallow part names
but in modified version, the part names chaned to simpler meaning names to use.
i.e for button
elm_object_content_part_set(button, "elm.swallow.icon", icon);
-> elm_object_content_part_set(button, "icon", icon);
SVN revision: 65295
This commit introduces two new API: elm_entry_textblock_get and
elm_entry_calc_force. These two APIs can be used to manipulate the
textblock object inside the entry in a safe manner. This exposes an
interface that wasn't available before letting do new and cool things
with entries.
SVN revision: 65169
Hi,
There are bugs that map removes list elements when using
EINA_LIST_FOREACH or EINA_LIST_REVERSE_FOREACH.
We should use EINA_LIST_FOREACH_SAFE or EINA_LIST_REVERSE_FOREACH_SAFE
instead for above case.
Please review belows
SVN revision: 65069
edjeobject, not elm_button. This patch will change all button
edje_objects to real elm_button. And long_press will be supported by
elm_button's autorepeat feature. (This patch was made by Shilpa. Thanks)
SVN revision: 64931
Subject: [E-devel] [elm_map] ecore_file_download_full() should be used
properly
elm_map only checked that returned job is NULL.
But ecore_file_download_full() returns EINA_FALSE when error occurred.
So return value should be checked for proper usage.
Please review this simple bug fix
SVN revision: 64794
Subject: [E-devel] [elm_map] Fix up too many connections at the same
time.
Currently, elm_map requests all visible map image tile to map server
at the
same time.
If the scene is turned off while panning or zooming, it will be
aborted on
HTTP requests.
But it already sent to map server, and it already made useless HTTP
connections.
So if you pan scrolling quickly, elm_map try to download and abort too
many
HTTP
connections repeatedly.
If you have stable and high-throughput data connection, it doesn't
matter
on your side.
However map server will get high load, It is sufficient reason to block
you.
In another case, if you have poor data connection such as 3G
connection, it
has less
throughput and it causes delay of downloading. And finally, the device
is
as full as
HTTP connections even you already aborted. It makes low-performance
issue on
your device.
I wrote a patch for solving this situation.
The idea is simple.
1. I limited number of maximum HTTP request on elm_map side.
2. If maximum HTTP request is exceed, keep requests on Eina_List.
3. If each image downloading is completed, try to download recent
request.
(Because it has strong possibility for your screen)
4. At the same time, invisible request will be removed.
(It doesn't make HTTP connection yet)
I tested many times on my desktop and device.
It works for me. And elm_map's performance is improved
appreciably on 3G
connections.
SVN revision: 64685
When the scroller is dragged repeatedly in a short time, it is accelerated.
If it reaches the edge of the content, the bouncing is started.
Sometimes because of the acceleration, the content cannot be shown in a moment.
In order to avoid that situation, the bounce animation have to be fixed
according the amount of acceleration.
SVN revision: 64642
This reverts commit 64549.
I gotta adimt, your commit looks correct to me, but hey, it breaks
elementary_test's "Window Inline" test... Please investigate it further
and make re-apply your commit afetr your solve these issues.
SVN revision: 64605
Subject: [E-devel] [Patch] elm_map: add image loading error handling
I made a bug fix for elm_map.
When a downloaded image has an error, , elm_map removes a file and goes on
just like download succeeded .
However, it is not success, so it should be marked as FALSE for later retry.
SVN revision: 64598
Avoid leak caused by not updated signal name.
Btw, Mr. Valgrind is sad with elm developers.
Lots of warnings regarding uninitialised values.
SVN revision: 64582
This is actually a pretty important thing to remember.
elm_win_resize_object_add resizes the content to the size of the window,
the size of the window is only applied when the window is shown, at least on
the ecore evas. Is that wanted? or should we take the evas-object geometry
there? The problem I'm worried about is: writing beyond buffer limits.
SVN revision: 64579
currently, only X window system undergo async problem,
but other windowing system meet same problem if it have asyncmode.
so I dont have to handle per-display specifics higher up above ecore-evas.
(use ecore_evas_request_XXX instead of ecore_evas_x11_request_XXX)
not only async windowing system but also situation wm refuse resizing request,
make request size != current size.
so I'll implement ee->req value to other windowing system.
--under this line, and those below, will be ignored--
M elm_win.c
SVN revision: 64549
Subject: [E-devel] [E-Devel][Patch] Evas GL Color Format Enum change
(and ElmGLview changes accordingly)
I'm submitting a patch that changes the color format for Evas GL.
When I first wrote Evas_GL, I just had EVAS_GL_RGB_8 and EVAS_GL_RGBA_8 and etc
but it was misleading for some people. It was more of a filler since I couldn't decide on
a name. I'm finally changing it to make it more clear.
SVN revision: 64491
Until now it was only possible for scrolled entries.
This patch is by Hyoyoung Chang, which I adjusted to conform to my previous
patch.
SVN revision: 64436
elm_entry_autocapital_type_set API is high level API to call ecore_imf_context_autocapital_type_set.
Application programmer can choose the type of autocapitalization such as
WORD, SENTENCE, ALLCHARACTER through this API.
elm_entry_input_panel_enabled_set API is for setting whether input panel
(virtual keyboard) should be appeared when entry has a focus or pressed.
It can be used by dialer or calculator application programmer because those
application prefer to use its keypad NOT virtual keyboard supported by system.
They want to use entry to show the cursor for providing the cursor handling
method but don't want to appear system keyboard.
SVN revision: 64424
Besides we free the object pointed by esd, we NEED the right pointer's
value to unregister the signal with
edje_object_signal_callback_del_full().
SVN revision: 64415
At first, try to execute elementary_test and drag down the list for bounce.
Then as soon as release the mouse, click the list continuously and fast.
The list will not be clicked because it cannot be clicked during the bounce
animation. The bounce animation time is fixed and it is reset again, when
the mouse is down and up. In the result, if we click it continuously, we can
not choose the list item. (During animation, list can not be clicked).
I changed the function "_smart_bounce_x_animator" and "_smart_bounce_
y_animator". I fixed the bounce time will be changed by remaining distance.
SVN revision: 64407
I found a problem in els_scroller. When the scroller is resized, it shows the location of
the coordination which was saved into wanted_coordination. If you don't use the page,
it is no matter. But if you use the page function, the animation of the scroller is operated
by _smart_scrollto_x_animator, not by _smart_momentum_animator.
In _smart_scrollto_x_animator, therer isn't _update_wanted_coordinates. So the value of
wanted_coordination doesn't update. I think _update_wanted_coordinates have to be added in
_smart_scrollto_x_animator and _smart_scrollto_y_animator.
Please check the attached patch file.
SVN revision: 64406
Remove almost all of them. Remaining:
- device on _event_history_clear, elm_gesture_layer
- config has a hand of these cases.
- ctxpopup var inside macro
- segment control edje external (it's unfinished)
SVN revision: 64365
If we need to add functions born deprecated because it will
make other developers life easier, ok. But using these
deprecated functions inside our project isn't nice.
SVN revision: 64363
Do not limit the swallowed objects to icon. This had to be done before
elm 1.0 and now it's time to break. This will break all applications
which are using gengrid/genlist. Please fix it icon_get -> content_get.
TODO
1. fix theme as well.
2. fix documents.
SVN revision: 64344