Type API provides possibility to skip/ignore widgets in accessiblity
tree. It make sense to ignore object if it do not provide any valuable contextual
information for disabled users. Skipped objects are usually container objects
and are ommited in parent-child relationship.
@feature
The test_colorclass function (and prototype) were incorrect in that
they did not have the proper function parameters defined. This lead to
a warning when building elementary tests.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
In Elm_Cnp, a markup data preparer was missing, which resulted
in _x11_notify_handler_targets not requesting
"application/x-elementary-markup" (requested "UTF8_STRING" instead) when
trying to paste markup text from one entry to another (or itself).
Also, there was a missing handling in the selection data callback for
ELM_SEL_FORMAT_MARKUP data format.
This fixes issues like not being able to paste "item" formats to the
entry widget.
@fix
We have to use void in a function declaration if we want no function
parameters. Using just empty parenthesis means the function takes an
unspecified number of parameters.
We had it correct for most declarations and this series fixes it for
the rest.
Thanks for the sparse semantic parser for pointing this out.
We have to use void in a function declaration if we want no function
parameters. Using just empty parenthesis means the function takes an
unspecified number of parameters.
We had it correct for most declarations and this series fixes it for
the rest.
Thanks for the sparse semantic parser for pointing this out.
We have to use void in a function declaration if we want no function
parameters. Using just empty parenthesis means the function takes an
unspecified number of parameters.
We had it correct for most declarations and this series fixes it for
the rest.
Thanks for the sparse semantic parser for pointing this out.
Summary:
The function evas_object_resize(win, 480, 800) was being called after evas_object_show(popup)
so size calculations of popup were going wrong(height was 0).
It should be called before creating popup as win is parent of popup,
This fix needs to be done only here as in other cases window is already present before creating popup
but here both are being created for exmaple purposes.
Signed-off-by: Aditya Raj <aditya1.raj@samsung.com>
Reviewers: singh.amitesh, raster
Subscribers: jpeg, tanwar.umesh07, sachin.dev
Differential Revision: https://phab.enlightenment.org/D3360
previously, mousing out of an icon during the pulse animation would
instantly stop the animation. this looks strange and is quite noticeable
when mousing through a bar
Summary:
If the entry is a single line, rather than return the cursor height,
it is better to return the height of the object.
Reviewers: herdsman, tasn
Differential Revision: https://phab.enlightenment.org/D3169
Summary:
When _elm_theme_set() failed to set given style, it sets style
as "default".
However, setting style to "default" can be unintended behavior,
so developer should have the chance to get to know fallback.
Reviewers: cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3352
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
This is for support dynamically field sequence changing case
for example
User sets datetime format as "%d/%b/%y" first.
Then change the format dynamically in runtime to "%I:%M %p"
Previous format datetime items still there.
It breaks view(object dulicated on same geometry)
@fix
Test Plan:
Run datetime sample.
Add changed callback.
Change format in changed callback function.
Check the bug state.
Reviewers: jaehwan, id213sin, Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3340
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
To prevent pasted markup text in entry.
User want tags removed text when paste text into entry.
@fix
Reviewers: jaehwan, Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3333
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
There is no need ellipsis, space as well before "%d".
The "%d" will show the actual invisible item count.
@fix
Reviewers: jaehwan, Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3332
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
This feature has been added long time ago but it never worked before.
I delayed the parent object hide call when hide signal is present
in theme.
Test:
1. elementary_test -to notify
2. Click Left and wait for timer to expire
3. Click Left and click "close" button on notify. Now hide animation
happens when notify hides.
@fix
Unprotect methods which are ment to be a part of public API.
This methods were initially unprotected, however it looks like
during eo refactoring @protect tags were added by mistake.
@fix
Summary:
If item is unselected in a selected function,
selected function will be called once more from _elm_gengrid_elm_widget_on_focus.
It is happened when elm_gengrid object has no focus and one of item is selected by mouse up event.
To fix this issue, we need to set focus to item and keep the address of selected item before calling selected function.
@fix
Test Plan:
1. Install & Run efbb (Escape From Booty Bay: https://git.enlightenment.org/games/efbb.git/)
2. Select a level in the main menu. (It is using elm_gengrid).
3. See duplicated target images.
Reviewers: cedric, SanghyeonLee
Reviewed By: SanghyeonLee
Differential Revision: https://phab.enlightenment.org/D3323
Summary:
Keep cursor at inserted position after dnd.
For good user experience, after dnd users expect
the cursor should be at the last inserted position.
@feature
Test Plan: NA
Reviewers: thiepha, herdsman, cedric, tasn
Subscribers: shilpasingh
Differential Revision: https://phab.enlightenment.org/D3267
Eina module errors are printed on the screen when the library is not
installed in the system and Clouseau debug is enabled.
The module pointer is not NULL checked, leading to an error message when trying
to load this NULL module.
@fix
Summary:
1. If the sd->items list is empty any time and container_get is used on filter iterator, it will lead to crash. Solution is to not rely on sd->items and maintain a pointer to container when iterator is created.
2. There was a typo while filter feature was added earlier. Fixed it
@fix
Test Plan: NA
Reviewers: SanghyeonLee
Reviewed By: SanghyeonLee
Subscribers: rajeshps, shilpasingh
Differential Revision: https://phab.enlightenment.org/D3319
Summary:
When spinner activated with entry, user can input any characters in entry.
It degrades the usability.
Add filter for only can input numbers and "." for case of decimal point existing.
I will add entry filter for limit size as well after this commit.
This spinner features may help for app developer and users too.
@feature
Test Plan:
Run elementary_test
Test various spinner format for check this.
Reviewers: Hermet, cedric
Subscribers: id213sin, shilpasingh
Differential Revision: https://phab.enlightenment.org/D3299
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
When an Elm_Segment_Control object is created, the constructor calls
the smart_add() behind the scenes. It then calls _update_list() which
calls _position_items(), with the sd->obj unset (because it was set
after calling super constructors). This led to a CRI() (and therefore
to a backtrace) on the creation of each Elm_Segment_Control.
@fix
Test Plan: elementary_test
Reviewers: stefan_schmidt, cedric, raster
Differential Revision: https://phab.enlightenment.org/D3276
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Avoid code duplication
Two dismissal signals at two different places
created some confusion and also code is duplicated.
Also removed some extra space.
Test Plan: NA
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3269
Summary: elm_genlist_first_item_get(), elm_genlist_last_item_get(), elm_genlist_item_prev_get(), elm_genlist_item_next_get() should return the next filtered item if filter is applied on the genlist.
Test Plan: test_genlist.c => Genlist Filter demo updated
Reviewers: shilpasingh, cedric, SanghyeonLee
Subscribers: divyesh, rajeshps
Differential Revision: https://phab.enlightenment.org/D3263
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
An application starts before the indicator has. In this case,
the application should try to connect again with the indicator.
Test Plan:
1. Start an application without the indicator service.
2. Start the indicator service.
Reviewers: raster, Hermet, woohyun, jaehwan, cedric
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D3258
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
1. When subtitle is set using actual part name "elm.text.subtitle",
subtitle,show signal is not sent issue fix.
2. Remove unnecessary checks, maintain code readability.
@fix
Test Plan:
Set text using edc part name elm.text.subtitle
Reviewers: Hermet, cedric
Reviewed By: cedric
Subscribers: shashank0990
Differential Revision: https://phab.enlightenment.org/D2988
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The box_clear, box_fill internal functions called when almost every internal chage happend.
(resize, theme apply, item append, item delete etc...)
Then those APIs delete/create item's edje object for all of the items.
It's very not good action for performance.
So, i changed this just edje object box unpack/pack instead of delete/create.
@fix
Test Plan:
Working test on elementary_test
and Call all of the index APIs for check this change.
Reviewers: Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3268
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Lukasz Stanislawski
Stefan Schmidt
Chris Michael
Daniel Hirt
Mike Blumenkrantz
Amitesh Singh
Aditya Raj
indefini
Jee-Yong Um
woochan lee
Youngbok Shin
Subodh Kumar
Daniel Zaoui
shashank.p
godly.talias
Hosang Kim
Jean Guyomarc'h
Shinwoo Kim
Shilpa Singh