1470572cef
genlist: code refactoring.
...
just clean up code. no logic change.
2015-01-02 16:54:01 +09:00
a41e9d8044
genlist: refactoring code.
...
removed invalid content string free call.
and renamed flip_content_objs -> flip_contents.
2015-01-02 16:48:29 +09:00
60202b7f0a
genlist: code refactoring.
...
remove contents string list that doesn't needed to keep in widget data.
next code refactoring based on this patch will be coming.
2015-01-02 16:17:16 +09:00
67e4baf1df
genlist: exceptional handling.
...
just be hidden if contents are failed to swallow.
2015-01-02 12:14:41 +09:00
2dd05e1580
genlist: free selected items when genlist is cleared.
2014-12-31 19:55:09 +09:00
ff9de8bea8
genlist: send reorder signal to decoration item and views.
...
Previous logic was too much stick to special case for *tizen*
let decide item styles in theme as possible.
This might break reorder group item ui, but it won't be critical.
because tizen ui only depeneded on the scenario and they don't use them anymore.
This will be much better for multiple scenario in the future.
2014-12-31 19:10:40 +09:00
4f1b1bcb9f
genlist: let group item set reorder style as it needs.
...
we don't need to limit the group item it's reorder style.
2014-12-31 18:59:28 +09:00
66d78a4512
genlist: + warning msg for user notice
...
don't unrealize reordering item.
2014-12-30 17:56:24 +09:00
7dc5c3863c
genlist: use convenient macro.
2014-12-30 17:36:14 +09:00
0e5b3f32d5
Revert "genlist: return as possible as soon."
...
This reverts commit ef56ed167206612f146d2c70f5b35a7bcd62c4c6.
This caused logic change. should not be changed.
2014-12-30 15:44:46 +09:00
10ac198400
Revert "genlist: return as possible as soon"
...
This reverts commit 1e6736c3a13d58c4e1a01d7e23983c721051be08.
This caused logic. should not be changed.
2014-12-30 15:43:20 +09:00
65de16477c
genlist: return as possible as soon
2014-12-30 15:32:41 +09:00
f86dbe4854
genlist: removed unnecessary check
2014-12-30 11:17:46 +09:00
f14fa87c84
genlist: Fix internal comments.
2014-12-30 01:31:43 +09:00
f9cc9863a3
genlist: return as possible as soon.
2014-12-29 22:58:38 +09:00
f2b7e575f0
genlist: clean up code.
...
repositioned function and remove unnecessary prototype declaration.
2014-12-29 22:51:39 +09:00
fb8af1004c
genlist: remove duplicated signal registration.
2014-12-29 22:34:45 +09:00
1f73409844
genlist: send an additional signal
...
send flip disabled signal when it's state is switched.
2014-12-29 22:27:28 +09:00
cce9511130
genlist: send a signal internally.
...
send a signal so that item set it's style according to it's depth
2014-12-29 22:16:34 +09:00
5b2493b7af
genlist: send a disabled signal when the decorated item is unrealized.
2014-12-29 21:44:50 +09:00
b4fe364f1b
genlist: code refactoring
...
declare/use const strings for internal signals
2014-12-29 19:50:39 +09:00
Davide Andreoli
9988b752c7
Genlist: do not fire clicked,right while dragging in progress
2014-12-29 11:19:21 +01:00
eb229ae0e2
genlist: add "scroll" smart call
...
@feature
2014-12-29 19:02:08 +09:00
Davide Andreoli
69b6310954
Improve -clicked- detection code by accept only if the mouse do not move too much
...
Too much in this case is a fixed 4px. As fingers do not have a right button I think
that taking into account finger size is not needed here.
Also someone argued about the signal name is not really correct...
should I change it to somethig like: clicked,secondary ?
2014-12-26 18:46:28 +01:00
Davide Andreoli
536c5de134
Genlist: added the clicked,right event on items
...
@feature
2014-12-26 17:29:51 +01:00
fc1579020c
list/genlist/gengrid: Fix memory leak.
...
Summary: @Fix
Reviewers: kimcinoo, SanghyeonLee, raster, seoz
Reviewed By: seoz
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1825
2014-12-26 20:22:57 +09:00
d47a4adae4
gengrid, genlist, list, toolbar: Fix memory leak and enhance performance.
...
1. Fix memory leak by freeing eina_list.
2. Enhance performance by getting the item list when it is really
needed.
@fix
2014-12-26 18:41:48 +09:00
9b038471bf
genlist: Return the correct pointer for object item.
...
No backport needed.
2014-12-26 14:36:36 +09:00
8148de6e17
elm_genlist: add missing callback call
...
Summary:
Added missing "moved" callback call when reordering items with keyboard
"up" and "down" arrows
@fix
Reviewers: cedric, raster, seoz
Reviewed By: seoz
Subscribers: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D1818
2014-12-26 14:23:42 +09:00
c201ec6c87
genlist should ignore no-select items when moving with the keyboard
...
@fix
2014-12-25 20:39:17 -05:00
4a61d3955e
genlist: Fix dereference before null check.
...
This fixes coverity CID 1258636.
No backport needed.
2014-12-16 23:54:13 +09:00
Carsten Haitzler
17f411f6be
elm - fix warnings added in f99be3a1d6bdc63153598b592b5437c33da44bf0
2014-12-16 19:36:35 +09:00
17419ec81c
genlist: added reorder feature on key events
...
Summary: This feature allows user to reorder items using up/down keys.
Test Plan: elementary_test -to "Genlist Reorder Mode"
Reviewers: singh.amitesh, raster, seoz, SanghyeonLee
Differential Revision: https://phab.enlightenment.org/D1262
Conflicts:
src/bin/test_genlist.c
src/lib/elm_genlist_legacy.h
2014-12-16 18:20:32 +09:00
14e79451c2
genlist: Fix genlist crash issue when clearing genlist on item focus callback.
...
This fixes "genlist focus" test sample's crash issue.
@fix
2014-12-14 04:19:42 +09:00
e31df3372c
gengrid, genlist: Optimize eo item usage.
...
Remove unnecessary pointer reference.
2014-11-25 21:55:14 +09:00
dfc3f7ac30
Genlist: Fix previous commit.
...
The items of an item is a list of Elm_Object_Item and not of Elm_Gen_Item.
Sorry @zmike ;-)
Fixes T1859
Another fix has been added in this commit, related to relative items.
2014-11-23 09:18:42 +02:00
0f28743080
Genlist: Fix API return value.
...
elm_genlist_item_subitems_get has to return a list of Elm_Object_Item.
Because of the porting of the genlist item to Eo, this function returns
a list of Elm_Gen_Item.
Thanks to zmike and seoz for catching this.
Fixes T1859
2014-11-22 09:40:37 +02:00
7fc83c54b5
genlist: Fix build warning for uninitialized variable.
...
elm_genlist.c:1916:15: warning: 'eo_it' may be used uninitialized in
this function [-Wuninitialized]
2014-11-19 19:53:40 +09:00
05225b162e
Object Items: remove data variable from widget item.
...
Now, data is stored in Eo layer via eo_key_data_set/get.
Two macros have been added to facilitate access.
2014-11-12 12:03:58 +02:00
ef03bc098e
Object Items: remove legacy APIs.
...
They are now generated by Eolian.
2014-11-12 12:03:58 +02:00
b01d01528a
Object Items: remove casts that are no more needed.
...
It includes casts to Eo, Elm_Object_Item and to specific items data.
This belongs to the cleaning phase of the object items porting to Eo.
2014-11-12 12:03:57 +02:00
ca286ea1cb
Elm Genlist Item: Migrate to Eo
2014-11-12 12:03:56 +02:00
a9b13f7633
Elm Widget Item: Migrate to Eo
...
Since we want to support legacy inheritance mechanism, code is not
finished and will have to be cleaned when all the items are ported.
2014-11-12 11:52:10 +02:00
f9ec18f586
genlist: Remove unnecessary callbacks when item loop is disabled.
...
@fix
2014-11-07 02:20:21 +09:00
2ca1f8a75a
atspi: properly include at-spi headers.
...
Summary:
Change requested by TAsn. Previuosly AT-SPI headers were kept private
and included directly into elementary source code. From now on,
AT-SPI headers can be included from Elementary.h public header, however
will be marked as beta APIs.
Commit includes following changes:
* include all atspi headers into new elm_interfaces.h header.
* marking all at-spi interfaces methods/properties as @protected.
* wrap all common headers with EFL_BETA_API_SUPPORT.
* make some common APIs visible in lib, by adding EAPI attribute
(if someone decides to use beta APIs).
Test Plan: out-off tree build with gcc, g++
Reviewers: tasn
Reviewed By: tasn
Subscribers: seoz, q66, kuuko
Maniphest Tasks: T1721
Differential Revision: https://phab.enlightenment.org/D1528
2014-10-17 16:57:26 +01:00
2bcbe743d1
genlist item block recalc checks now more readable
2014-10-07 14:07:13 -04:00
dbc3b87b18
genlist item block recalc checks make more sense
2014-10-07 14:07:13 -04:00
236bab8d53
Change according to recent Eo changes, and fix related wrong unrefs.
...
eo_add()'s counterpart is eo_del, not eo_unref. Regardless of that, some
objects were being double-deleted which spew out some eo errors. These
things should now be fixed.
bc6b6aa457
2014-09-30 14:54:52 +01:00
7629c147eb
Eo related: Change according to recent changes in eo_add().
...
For more info check out a7560dbc61
2014-09-25 17:39:34 +01:00
b9744e58f5
genlist: Removed unnecessary casting of genlist item.
...
Reviewers: seoz
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1471
2014-09-25 01:36:03 +09:00
ChunEon Park
Daniel Juyung Seo
Davide Andreoli
Amitesh Singh
Andrii Kroitor
Mike Blumenkrantz
Carsten Haitzler
Jyotiprakash Sahoo
Daniel Zaoui
Lukasz Stanislawski
zmike
Tom Hacohen