stacking become a lot more complex when re-order mode was added, group
headers and more, so simple raise/lower wasn't enough, so this adds 2
stacking markers (rectangles) and objects are stacked above or below
these 2 markers. that basically provides 4 possible stacking slots
that are easy to address, and if you also still raise/lower you get 6
slots. use these markers for stacking so items go into a fixed
stacking layer when they stack around.
I splited ELM_SAFE_FREE refactoring patches. One commit per each file as recommended.
For the detail, please refer 3072dab12f12fe83fb5a628d15efd5cded11787f.
There are pros and cons but this
1. reduces human mistakes.
2. enhances readability.
3. enhances code quality.
4. removes future bug.
5. was adopted from enlightenment.
This is not all. I will work on enhancing elementary more and more.
Summary:
This patch applies automatic focus feature to elm_genlist and elm_list
containers.
Currently (prior to this patch), focusable widgets inside list items of both
containers receive focus by an explicit mouse click over them, and lose focus
when focus goes to someone else in the window.
This change also adds the ability to:
- focus by default on the first-from-right focusable widget upon items selection
- lose the focus when another item is selected (focused or not)
- move focus between focusable widgets inside the same item by left and right
arrow keys accordingly (up and down keys when elm_list is in horizontal mode)
Focus is supported for horizontal and vertical lists.
Tests have been added for genlists and lists to check focus feature.
This patch broke at least two stuffs:
1. item movement with key arrow
now up/down arrow scrolls genlist now move to upper/lower item.
2. item del routine.
item del callbacks are called twice LOL.
this also broke apps that use elm_fileselector_button which uses elm_genlist internally.
Once these are fixed and tested more, I will re-commit this.
This reverts commit cea8e755dbf9b062bb1e6d7a89fbf4c590b8f6b3.
flags.
This flags was used for deferring deletion of genlist items.
After deferred, items can be cleanup when _item_select() is called.
This flags was used for preventing crash when subitems are deleted right
after one item is deleted.
But this made genlist code too complicated and could hide internal
issues. One of the issues is incorrect use of EINA_INSTLIST_FOREACH (or
forloop). Because sub items can be deleted when one item is deleted, I
used whlie loop and EINA_INLIST_CONTAINER_GET(sd->items->last, xx) and
not defer the deletion. This has no problem evenif inlist sd->items is
changed inside the while-loop.
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
Elm devs should fix it beforehand.
So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
is used for changing items' look when elm_genlist_reorder_mode_set() is
called. Also, when decorate mode is enabled/disabled, these signal
should be sent properly.
When the scroller is resized, the signals("elm,action,scroll", "elm,edge,top" so on) shouldn't be sent,
because it's not a scroll-action. So in this case, the content_pos_set should be called without the signals.
the user would be visually impaired person or blind, so the type infomation
of genlist or list is not proper. there would be more proper type infomation.
SVN revision: 83005
show_region_hook, but rather get it from the actual Object.
Fixes a crash that happens if someone overrides the show_region_hook
(via elm_widget call) and passes an Int or String or something else as
the data parameter.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 82571
+ elm_access_object_register();
+ elm_access_object_unregister();
+ elm_access_text_set();
+ elm_access_text_get();
+ elm_access_cb_set();
These APIs are to use edje part, evas object as an accessible object.
and do not create access object, because access object would be created at run time.
This is different with internal API _elm_access_object_register();
SVN revision: 81659
*note: this commit - callback behavior - would be disputable, becuase genlist has
"clicked,double", "selected" and "activated" signal and smart callback also.
but the access acitvate callback works as the item is selected.
SVN revision: 79369
genlist could have LOTS of items. so it would be better to use only displayed items for the focus chain.
please check the attachment and give feedback. thanks.
cordially,
shinwoo kim.
SVN revision: 78378
Subject: [E-devel] [E-Devel][Patch][Elementary]Genlist - Edje Item
Cache Refactoring
This is patch for reconstructing genlist's item cache.
Each item cache functions do harsh jobs so just push,pop by
Elm_Gen_Item * now.
Before, cache is disabled by comments. But I enabled item cache again
(even for the case which tree_effect_enabled is on).
I changed some functions:
_item_cache_find() --> _item_cache_pop()
_item_cache_add() --> _item_cache_push()
_item_cache_zero() -->_item_cache_all_free()
And I removed _item_cache_clean() function because I made
_item_cache_push() to don't exceed the item_cache_max. So clean-up of
cache is not needed anymore.
Breaks "genlist 2" test and clouseau. Just open genlist 2, press the "X"
button, and then the "+" button.
This reverts commit 77944.
SVN revision: 78336
Subject: [E-devel] [PATCH][ELEMENTARY][BUG Fix] Current Reordering
item is not resizing on genlist resize (e.g On roation)
Please review the attached patch created to fix the current reordering
item
resizing issue.
[ISSUE] Current genlist reordering item is not resizing on genlist
resize
(e.g. On rotation).
Change Description:
In _calc_job call back, the width of reordering item is corrected.
SVN revision: 77992
Subject: [E-devel] [E-Devel][Patch][Elementary]Genlist - Edje Item
Cache Refactoring
This is patch for reconstructing genlist's item cache.
Each item cache functions do harsh jobs so just push,pop by
Elm_Gen_Item * now.
Before, cache is disabled by comments. But I enabled item cache again
(even for the case which tree_effect_enabled is on).
I changed some functions:
_item_cache_find() --> _item_cache_pop()
_item_cache_add() --> _item_cache_push()
_item_cache_zero() -->_item_cache_all_free()
And I removed _item_cache_clean() function because I made
_item_cache_push() to don't exceed the item_cache_max. So clean-up of
cache is not needed anymore.
SVN revision: 77944
Subject: [E-devel] [patch][elementary] multibuttonentry - access feature
i have attached a patch which has access feature for the multibuttonentry.
it was hard time to implement access feature on the multibuttonentry than
others.
SVN revision: 77738
On Fri, Sep 28, 2012 at 10:04 PM, Bluezery <ohpowel@gmail.com> wrote:
> Dear EFL developers,
>
> In current genlist reorder mode, reordering is not moved when
> reordering item is on top or in bottom of within genlist objec because
> of scroller's hold mode.
> After mouse point is moved out of genlist object, then reordering item
> can be moved.
> But in mobile, mouse point can not be moved out of window (if genlist
> item is expanded in window).
> So I add some tweaks to reordering item can be moved when reordering
> item is moved on top item or bottom item.
>
> Please review this patch.
>
> BRs
> Kim.
SVN revision: 77255
On Fri, Aug 31, 2012 at 8:50 PM, Bluezery <ohpowel@gmail.com> wrote:
> Hello,
>
> Sometimes reorder animation ended incorrectly
> You can test & see the problem when background color is black and
> genlist item color is white.
> I made the added value for animation as difference between old item
> position and new item position if difference is below predefined dy.
> (y = diff, if diff < dy) So item position can be finally new item
> position at last.
> Please review this patch.
>
> Thanks
SVN revision: 75950
Subject: [E-devel] [patch][elementary] * access *
Series of of pathes from kim shinwoo. looked good to me - so in they
go, finishing off some more access mode to be more complete.
SVN revision: 75415
set it all the time themselves for read-only use outside. :) if uw ant
this u have to accomplish this another way. eg table with genlist PLUS
invisible rect obj at the same cell spot (0, 0, 1x1). and make the
invisible rect have a min size hint. table takes care of using the
"constraints" of both rect and gnelist then for sizing. :)
SVN revision: 75044
Widgets having internal panning objects won't have so fancy inheriting
schemas for those very objects, but they should be fine with
re-defining their own, if they want/need and overwriting it in their
smart_add()s.
SVN revision: 74682
initializing text parts first. Patch by Bluezery <ohpowel@gmail.com>
On Thu, Jul 26, 2012 at 2:29 PM, Bluezery <ohpowel@gmail.com> wrote:
> Hello,
>
> This patch make genlist free their text parts when each item is
unrealized.
> Before this patch, the item is just cached when an item is unrealized
> and the text part is freed and set by other text when the cached item
> is realized.
> This improves scrolling performance with very long text because this
> can reduce needless edje size recalculation time.
> Please review this patch.
>
SVN revision: 74413
This fixes "elm - genlist decorate all mode on and scroll - garbage
items left around."
Note: Do not manipulate swallowed items. Unswallow it first then
manipulate it.
SVN revision: 74412
The ERRs thrown on the terminal while exiting some tests were already
there -- check that those decorate and stuff modes add lots of NULL
children on lists.
Genlist work exactly as before. All the bugs and feature were kept :)
SVN revision: 73941
elementary configuration environment. Patch by Bluezery
<ohpowel@gmail.com>
On Thu, Jul 12, 2012 at 1:00 AM, Bluezery <ohpowel@gmail.com> wrote:
> Hello,
>
> Vertical bounce enable value can be changed by elementary
> configuration environment.
> But currently It was always EINA_FALSE. I fix that this value can be
> got from elm_config value.
>
> Please review this patch.
> Thanks
SVN revision: 73596
Documentation was wrong too and code had a slight bug stopping
genlist from contracting to min size.
Optimize the case of COMPRESS + homogeneous mode to avoid
queue entirely and use existing known item sizes.
SVN revision: 71140
<hyoyoung@gmail.com>
On Fri, Apr 20, 2012 at 4:10 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all,
>
> After introduced flipped mode to genlist, some clearing process is
> added to _elm_genlist_item_unrealize.
> In item _elm_genlist_item_unrealize, item is casting to gengrid item
> or genlist item.
> segfault is occurred in _elm_genlist_item_unrealize at using gengrid.
> this patch moves flipped mode clearing process to _item_realize_cb.
>
> Thanks.
>
SVN revision: 70355
Hyoyoung Chang <hyoyoung@gmail.com>
On Fri, Apr 20, 2012 at 5:19 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> After discuss with seoz, i changed to not clean selections also i
> removed the new added internal func.
>
> Thanks
>
> On Fri, Apr 20, 2012 at 4:00 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
>> Dear all,
>>
>> I made a small patch to fix remained selection bug.
>> In decorate all mode, some item selection is not cleared after unset
>> decorate all mode.
>> I added to fix it.
>> And make unselecting common routine to a internal function.
>>
>> Thanks.
SVN revision: 70354
Subject: [E-devel] [patch] elm_genlist - bugfix at item flipped
I made a small patch about item flipped.
It resolves two bugs
1. flip_set and unset is called quickly, sometimes genlist can't free
flipped data.
it fixed to remove checking flipped status in item unrealize
2. add item unhighlight at flip_job
SVN revision: 70306
Subject: [E-devel] [Patch][Genlist] fix the bug in _elm_genlist_item_del_notserious
I made a patch to fix the bug in _elm_genlist_item_del_notserious.
If relcount is not 0 or walking is not 0, return.
SVN revision: 70291
Hyoyoung Chang <hyoyoung@gmail.com>
On Thu, Apr 5, 2012 at 3:12 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all,
>
> I made a patch for elm_genlist_fields_update to selective content
update.
> a genlist item can update any content regardless of its mode.
>
> Thanks.
>
> PS: It assumed my previous patch is applied ([patch] elm_genlist -
> split flip content from item's content)
SVN revision: 69944
Dear ALL,
If the block that must be removed/freed, it has already removed/freed in
_item_block_del.
So I removed the code in _clear_cb.
Thanks
Joey
Submitted-By-Off ChankWook Jung<jchanwook@gmail.com>
SVN revision: 69929
Chang <hyoyoung@gmail.com>
On Fri, Mar 30, 2012 at 5:17 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> I talked with seoz. and agreed with previous naming changing is
insufficient.
>
> so changed like this
> "mode_" -> "deco_it_"
> "edit_" -> "deco_all_"
>
> Thanks
>
> On Fri, Mar 30, 2012 at 3:33 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
>> Dear all,
>>
>> After edit mode naming is changed, some legacy naming is remained.
>> I changed naming to follow API naming changes.
>>
>> "edit_" -> "deco_"
>> and also some explicit edc part names are changed.
>>
>> Some naming are remained as is, I'll fix at next patches.
>>
>> Thanks.
>
SVN revision: 69836
for this change.
Revert "After edit mode naming is changed, some legacy naming is remained."
This reverts commit 5e1aa3c8b0382a0ca471150f4c219cd32dbdbe22.
SVN revision: 69835
I changed naming to follow API naming changes.
"edit_" -> "deco_" and also some explicit edc part names are changed.
Some naming are remained as is, I'll fix at next patches.
SVN revision: 69793
1. delete old content object
2. check whether new content object is same as old content object
3. rename internal content set hook function
4. elm_widget_sub_object_del will be followed by evas_object_del
5. added some doxygen description.
SVN revision: 69738
<hyoyoung@gmail.com>
On Thu, Mar 29, 2012 at 4:56 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all
>
> I made a patch about flip_realize.
> Currently flip feature uses content_objs, so it should keep its
content_objs.
> However it's lost at _item_flips_realize().
> So i fixed to initialize with its content_objs.
>
> Thanks
SVN revision: 69725
<jchanwook@gmail.com>
On Wed, Mar 28, 2012 at 3:06 PM, chanwook jung <jchanwook@gmail.com>
wrote:
> Dear all,
>
> I added one line to fix the bug at tree effect. If the item is equal
to
> expanded_next_item, expanded_next_item set to NULL in _item_del
>
> Thanks,
> Joey
SVN revision: 69691
Subject: [E-devel] [patch] elm_genlist - add merging edc strings list
I add like a routine in previous patch.
It add merging routines to realize functions.
also i removed "elm_widget_stringlist_free(cons)"
because all of it is freed at item_unrealize.
SVN revision: 69598
Subject: [E-devel] [Patch][Genlist] Tree effect bug fix
I found some bugs in tree effect. flickering, emit signal to unrealize
item... so I fix it.
SVN revision: 69582
Subject: [E-devel] [patch] elm_genlist - bugfix at item_state_update
I fixed minor error in _elm_genlist_item_state_update.
If item is selected, it sends signal to item and edit_obj.
But edit_obj is not checked by if statement.
I added a parenthesis for it.
SVN revision: 69538
Subject: [E-devel] [Patch][Genlist] Add the moved.after/before signal
instead of moved
Some applications want to know moved.after or before and relative item
because of updating their own list. So I separated moved into
moved,after and move,before.
SVN revision: 69537
Subject: [E-devel] [patch] elm_genlist - bugfix at flip_realize
I found a bug in _item_flip_realize.
It replaces previous string list without free.
this patch fixed for it.
SVN revision: 69536
<hyoyoung@gmail.com>
On Mon, Mar 19, 2012 at 11:48 AM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all,
>
> I found a bug in decorate mode that selection callback is called
twice.
> Because two _mouse_down callbacks are added to a genlist item.
> I'm fixing this bug and some refactoring.
>
> Thanks.
SVN revision: 69520
Chanwook Jung <jchanwook@gmail.com>
On Thu, Mar 15, 2012 at 7:25 PM, chanwook jung <jchanwook@gmail.com>
wrote:
> Dear all,
>
> This patch is evas_object_unref position change properly in
_item_select.
>
> Thanks
> Joey
SVN revision: 69373
Jung <jchanwook@gmail.com> But this will never be correct without
performance issue.
On Thu, Mar 15, 2012 at 4:43 PM, chanwook jung <jchanwook@gmail.com>
wrote:
> Dear all,
>
> I made the patch to fix index bug.
>
> Thanks,
> Joey
SVN revision: 69366
<jchanwook@gmail.com>
On Thu, Mar 15, 2012 at 2:47 PM, chanwook jung <jchanwook@gmail.com>
wrote:
> Dear all,
>
> I made a simple patch. If ELM_LIST_COMPRESS mode, did not recalc
minw/minh
> in _sizing_eval.
>
> Thanks,
> Joey.
SVN revision: 69365
hyoyoung@gmail.com>. I committed his patch except for _calc_job diff.
On Wed, Mar 14, 2012 at 3:09 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all.
>
> This patch include two changes
>
> 1. at _scroll_item, added to check show_item is null or not.
> 2. at _calc_job, added to check genlist type
> because calc_job is added anytime, but some genlist clearing is can
> be done before doing calc_job.
>
> Thanks.
SVN revision: 69349
<hyoyoung@gmail.com>
On Tue, Mar 13, 2012 at 6:52 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all,
>
> In _item_select, some if conditional is not working as user intention.
> always_select mode checking is reversed and no-select mode is not
checked.
> I add and fix it.
> Thanks
SVN revision: 69292
On Fri, Mar 9, 2012 at 5:49 PM, Hyoyoung Chang <hyoyoung@gmail.com> wrote:
> Dear all.
>
> This is a patch about genlist to add item signal emit hook.
> due to elm_genlist_item_object_get is deprecated,
> item sinal emit hook should be supported.
> So it's added.
>
> + elm_widget_item_signal_emit_hook_set(it, _item_signal_emit_hook);
>
> Thanks
SVN revision: 69111
elm_genlist_height_for_width_mode_set/get. Use
elm_genlist_mode_set(obj, ELM_LIST_COMPRESS) instead. This may
introduce bugs or performance issue but I will fix this soon.
Signed-off-by: Daniel Juyung Seo <juyung.seo@samsung.com>
SVN revision: 68985
Subject: [E-devel] [patch] elm_gen{list, grid} - add
no_highlight_mode_set/get
actually change it to hilight_mode/set/get with the inverse.
SVN revision: 68947
Subject: [E-devel] [patch] elm_gen{list, grid} - add elm_genlist_select_mode_set
As discussed in irc, I made a patch about unifying
always_select_mode_set and no_select_mode_set.
I'm introducing two apis in genlist (also in gengrid)
+EAPI void
+elm_genlist_select_mode_set(Evas_Object *obj,
Elm_Object_Select_Mode_Type mode)
+EAPI Elm_Object_Select_Mode_Type
+elm_genlist_select_mode_get(const Evas_Object *obj);
And added a enum in elm_general.h
+typedef enum
+{
+ ELM_OBJECT_NORMAL_SELECT = 0, /**< default select mode */
+ ELM_OBJECT_ALWAYS_SELECT, /**< always select mode */
+ ELM_OBJECT_NO_SELECT, /**< no select mode */
+
+ ELM_OBJECT_SELECT_MODE_MAX
+} Elm_Object_Select_Mode_Type;
After this is commited, i'll send a patch about examples and
edje_external.
SVN revision: 68937
Subject: [E-devel] [Patch] elm_genlist : Add tree effect APIs
I made a patch for Tree Effect in elm_genlist.
This feature shows the flip effect when expand/contract the expandable
list.
External APIs :
+EAPI void elm_genlist_tree_effect_enabled_set(Evas_Object
*obj, Eina_Bool enabled);
- Set Genlist tree effect
+EAPI Eina_Bool elm_genlist_tree_effect_enabled_get(const
Evas_Object *obj);
- Get Genlist tree effect status
You can test it. "Genlist Tree Effect".
SVN revision: 68934
Hyoyoung Chang <hyoyoung@gmail.com>
On Wed, Feb 29, 2012 at 9:17 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all.
>
> I made a patch to introduce new genlist item mode.
> Two public apis are added.
> +EAPI void elm_genlist_item_flip_set(Elm_Object_Item *it, Eina_Bool
flip);
> +EAPI Eina_Bool elm_genlist_item_flip_get(Elm_Object_Item *it);
>
> It provides on-the-flying item change. It works like that a new item
> added on existed item.
> In elementary test, you can test it.
> It's useful at adding widgets or show buttons in genlist item.
>
> Thanks.
On Mon, Mar 5, 2012 at 5:56 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Hello, I modifed fliP_set api to use ecore_job.
> It resolved version of mouse_{move, up} bugs.
>
SVN revision: 68727
this does NOT handle multiselect, since imo calling select callbacks on $TEXAS items would be pretty costly; probably need to job/timer it out or something
SVN revision: 68443
Subject: [E-devel] [patch] elm_genlist - add edit_mode feature (3/3)
As we discussed in 2011 May (
http://www.mail-archive.com/enlightenment-devel@lists.sourceforge.net/msg32498.html
).
I post edit_mode patch.
It almost made by Seunggyun Kim. I fixed some bugs and complaint to
current genlist.
Two public apis are introduced.
+EAPI void elm_genlist_edit_mode_set(Evas_Object *obj,
Eina_Bool edit_mode);
+EAPI Eina_Bool elm_genlist_edit_mode_get(const Evas_Object
*obj);
And one attribute is added in genlist item class
+ const char *edit_item_style;
It can used for editing and deleting in genlist.
SVN revision: 68309
removed elm_genlist_mode_item_style_get/set APIs. Patch by Hyoyoung
Chang <hyoyoung@gmail.com>
On Wed, Feb 22, 2012 at 8:55 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all.
>
> genlist item class had mode_item_style.
> it used for mode styling (such as sweep mode).
> one genlist can have multiple mode style.
> And mode_item_style's an item's attribute.
>
> So it's better to move to item class from widget_data.
>
> Thank you.
SVN revision: 68294
Subject: [E-devel] [patch] elm_genlist - add item_class management
functions
I make controversial apis for item class management.
As raster and other guys suggest, I simplify APIs and its behaviors.
First, Two public apis and two internal apis are introduced
+EAPI Elm_Genlist_Item_Class *
+elm_genlist_item_class_new(void)
+EAPI void
+elm_genlist_item_class_free(Elm_Genlist_Item_Class *itc)
+void
+_elm_genlist_item_class_ref(Elm_Genlist_Item_Class *itc)
+void
+_elm_genlist_item_class_unref(Elm_Genlist_Item_Class *itc)
genlist item class is maintained by genlist in automatic manner.
And three fields are introduced in genlist item class.
+ int version;
+ unsigned int refcount;
+ Eina_Bool delete_me;
Normally a user add a elm_genlist_item_class by
elm_genlist_item_class_new().
Then its reference counter is automatic maintained.
If the user wanna to remove the elm_genlist_item_class, then call
elm_genlist_item_class_free()
After refcount reaches to 0, it will be removed.
SVN revision: 68147
Subject: [E-devel] [patch] elm_genlist - add a getting item flag
function
Sometimes it is needed to get genlist item's type.
It will help to get item's type.
SVN revision: 67890
Subject: [E-devel] [patch] elm_genlist - bugfix at genlist rotation.
It's about genlist items which are backed from rotation.
After rotating and items width is extending, genlist doesn't shrink its items.
So adding some routines to check if item min width is bigger than genlist's width.
If then recalc items width.
SVN revision: 67876
Daniel Juyung Seo
Carsten Haitzler
Daniel Juyung Seo
Ivan Briano
Yossi Kantor
Tae-Hwan Kim
Shinwoo Kim
Cedric Bail
Daniel Zaoui
Tom Hacohen
Flavio Ceolin
Gustavo Lima Chaves
Jaehwan Kim
ChunEon Park
Shinwoo Kim
Jaehwan Kim
Christopher Michael
Mike Blumenkrantz
Yakov Goldberg
Michael BOUCHAUD
Bluezery
DUBEYPRINCE KUMAR
Stefan Schmidt
Hyoyoung Chang
chanwook jung
Jihoon Kim
WooHyun Jung
Leif Middelschulte
Daniel Juyung Seo
Jiyoun Park
Sanjeev BA