Summary:
this is both invalid and useless, so return immediately before spending cpu
time and generating error messages
fix T7035
Depends on D6324
Reviewers: bu5hm4n, Hermet, woohyun, devilhorns
Reviewed By: bu5hm4n
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7035
Differential Revision: https://phab.enlightenment.org/D6325
Summary:
a number of calls during construction resulted in null object errors here
fix T7036
Depends on D6323
Reviewers: bu5hm4n, Hermet, woohyun, devilhorns
Reviewed By: bu5hm4n
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7036
Differential Revision: https://phab.enlightenment.org/D6324
Summary:
this check already existed in the function but was not applied to the
entire function
ref T7030
Depends on D6322
Reviewers: bu5hm4n, Hermet, woohyun, devilhorns
Reviewed By: bu5hm4n
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7030
Differential Revision: https://phab.enlightenment.org/D6323
Summary:
API parts require namespacing, these parts have been namespaced with
compatibility code added to handle legacy naming
Depends on D6210
Reviewers: cedric
Reviewed By: cedric
Subscribers: #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6211
Summary:
this was released with improperly namespaced parts which must be maintained
for future releases, but the namespacing can be corrected for future
releases while adding aliasing to preserve compatibility
Depends on D6208
Reviewers: cedric
Reviewed By: cedric
Subscribers: #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6210
This reverts commit 1b245787fe.
This is a workaround patch, even occurs a regression bug that
breaks widget signal emission logic. (Happened in Enventor toolbar)
I reviewed this code seriously and found out
ui_layout sub object unset logic has been changed.
Obviously that breaks the elm compatibility.
When sub-object of layout is removed, it tries to remove sub-object from
the layout internal list. Problem is, some widgets sends internal signals
when sub-object is removed(i.e "icon,hidden") , but layout returns the
valid object even though sub-object unset is called prior to signal,
means, "icon,visible" not "icon,hidden" emitted.
This logic obvisouly changed from the previous efl version.
And we need to fix that logic first.
See _efl_ui_button_legacy_efl_ui_widget_widget_sub_object_del()
to check this issue.
1. button: sub_object_del()
2. layout: sub_object_del() => sub object must be removed.
3. button: signal emit() => for updating states
4. layout: content_get() => returns valid object?????! (Issue)
Summary:
08a11d, Signal name is changed to efl ui signal name
legacy widget should use elm
This commit resolves T6928
#efl, #regression
Test Plan: elementary_test -to datetime
Reviewers: JackDanielZ, Jaehyun_Cho, Hermet, YOhoho, devilhorns, zmike
Reviewed By: zmike
Subscribers: YOhoho, cedric, Hermet, Jaehyun_Cho, #committers, JackDanielZ, zmike
Tags: #efl
Maniphest Tasks: T6928
Differential Revision: https://phab.enlightenment.org/D6289
in the provider we accidently flattend out the widget history by
returning the wrong parent. However, this flattening code was required
for the element focus code of the two generic widgets, so the item is
found for every widget, in every subtree.
Summary:
When _icon_signal_emit is called, "icon" part always exist. so, it only make
"visible" signal.
this fixes that issue
Test Plan:
elm_object_content_unset(button);
elm_object_content_unset(radio);
elm_object_content_unset(check);
elm_object_content_unset(progressbar);
Reviewers: Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6241
Summary:
see 421217b150
If parent is NULL, is_legacy in _elm_theme_set is always true. and it will use
"efl/xxx" for mmap_set. this patch avoid this case.
fixes T6921
Test Plan:
1. elementary_test -to tooltip
2. check that "Hello", "Big Icon Tooltip", "Insanel Big Icon Tooltip" is working
Reviewers: zmike
Subscribers: cedric, ManMower, #committers
Tags: #efl
Maniphest Tasks: T6921
Differential Revision: https://phab.enlightenment.org/D6232
Summary:
It should use legacy class in elm_win_add.
this patch fixes T6898, T6899
Test Plan: make check
Reviewers: zmike, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6899, T6898
Differential Revision: https://phab.enlightenment.org/D6233
Summary:
1. remove prior/next action
prior/next key action doesn't look suitable for image.zooamble.
It is not able to support bi-directional interaction.
2. remove logic that refers to step_size the logic has been removed
by applying this commit because api related with step_size has been removed
since the new scrollable interface introduced.
another patch may follow after discussing on community
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6221
Toggling this option is unlikely happened by user because with autofit=false,
it doesn't gurantee readable visual text.
We don't need this stupid api yet. So remove it.
Summary:
Evas map was not updated when text was updated.
@fix
Test Plan:
1. Run the following test case.
elementary_test -to "efl.ui.textpath"
2. Toggle short text.
3. See a long line from the end of text which is wrong.
If you change angle, Evas map will be updated properly.
But, it should be updated when text is updated.
Reviewers: raster, cedric, thiepha, Hermet
Reviewed By: Hermet
Subscribers: Hermet, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6216
Summary:
The round value was not being applied when input the value as an internal entry.
@fix
Test Plan: elementary_test -> spinner sample.
Reviewers: cedric, woohyun, Jaehyun_Cho
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5843
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
This reverts commit f37b96a1de.
as pointed out in D5957, this would break use of theme_set during the
efl_add constructor once this is implemented in the future
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6146
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
4976f1fc5276835940610b72ca4fa48776fc9410 erroneously flipped the
bool flag on this call, accidentally creating another object during
deletion which is illegal now as the notify object is now unparented
at this point which will result in a CRI error
this call was never required in the first place as the corresponding
layout object would have been deleted automatically due to widget parenting
@fix
Reviewers: cedric
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6147
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The efl_gfx_color interface was not applied properly.
The implementation code of evas_object_smart_color_set was moved
to efl_gfx_color_set implementation code. But, these two functions are not same.
In efl_gfx_color_set impl, it has to call super's color set to apply
the given color values to widget object itself.
This bug caused color_set/get test failure and the following bug.
1. elm_image_add
2. evas_object_color_set
3. elm_image_file_set
4. show. See the given color is not applied. It was applied in the past.
Test Plan: color_set/get to elm_image object is included in test suite.
Reviewers: raster, cedric, herdsman, woohyun
Reviewed By: cedric
Subscribers: #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6163
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
1. Scroller in scroller case, callback process should continue.
If child scroller does not scroll, parent scroller should be checked whether scroll or not.
So returning EINA_TRUE is necessary.
2. down.dragged flag is always EINA_FALSE, so scroll is never unlocked.
@fix
Test Plan:
precondition
elementary_config -> scrolling -> Set Scroll Smooth Amount to 0
elementary_test -> pagescroller
Reviewers: woohyun, zmike, singh.amitesh, cedric
Reviewed By: cedric
Subscribers: #committers, cedric, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6187
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
There was wrong logic for calculating # of slices, dt, dist of each segment.
It caused bad rendering quality by putting too much slices on small text.
In addition, textpath didn't care about smoothness of curve's slope changing.
The patch fixes to check differences of previous points and next points for Evas Map.
So, textpath can show more smoothly curved text.
Also, it fixes "autofit" bug when text is much huge than given circle's size.
@tix
Test Plan:
- I'll attach screenshots for comparing rendering quality.
- To see "autofit" bug.
1. Run the following command.
ELM_ACCEL=gl ELM_SCALE=2.0 elementary_test -to "efl.ui.textpath"
2. Toggle "autofit" check box.
3. See the bug case. Textpath can't show all text properly.
Reviewers: raster, cedric, thiepha
Subscribers: #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6195
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Elm.List.Item lifecycle where an exception in Efl. They were trying to prevent the death of
there parent, to avoid dealing with safely walking on items list. This has been on the todo
list for years and is now fixed by this patch.
Mike Blumenkrantz
Hermet Park
Jihoon Kim
Daniel Zaoui
junsu choi
Chris Michael
Marcel Hollerbach
Larry Lira
YeongJong Lee
Wonki Kim
Youngbok Shin
Carsten Haitzler
Woochan Lee
Mike Blumenkrantz
Hosang Kim
Cedric BAIL
WooHyun Jung
Cedric Bail