NOTE: This improve calendar performance quite a lot, but a better improvement
would be to populate the object when we really need it. I don't know how to
do that in current Elementary source code. Reason for another expected massive
improvement is that every time you set a property on an Elm_Calendar trigger
a populate and that one is costly (Around 6 populates call per Elm_Calendar in
our code example, meaning doing it could give us a 6 times boost...).
SVN revision: 74553
Subject: [E-devel] [patch][elementary] popup - focus chain,
accessibility
you would be in rush because of freezing.. but there is still hot. -_-;
i'd like to raise an issue about focus chain on the popup. The focus would
go around only in the popup. (IMHO)
but current popup gives a chance to get the focus to other widget which is
not in the popup.
please check the attachment which has accessibility feature also and give
your opinion. thanks.
SVN revision: 74467
if there is a button, consider the same amount on the other side, even
if there is no button in there, limited to the maximum button size
(100px). It's not optimal, but looks less ugly.
SVN revision: 74451
as Tasn reported elementary_config was broken as the naviframe title
was covering the toolbar. This was due its usage of
elm_naviframe_item_simple_push() that uses
elm_naviframe_item_title_visible_set(FALSE) and a missing clipper on
my part.
SVN revision: 74449
initializing text parts first. Patch by Bluezery <ohpowel@gmail.com>
On Thu, Jul 26, 2012 at 2:29 PM, Bluezery <ohpowel@gmail.com> wrote:
> Hello,
>
> This patch make genlist free their text parts when each item is
unrealized.
> Before this patch, the item is just cached when an item is unrealized
> and the text part is freed and set by other text when the cached item
> is realized.
> This improves scrolling performance with very long text because this
> can reduce needless edje size recalculation time.
> Please review this patch.
>
SVN revision: 74413
This fixes "elm - genlist decorate all mode on and scroll - garbage
items left around."
Note: Do not manipulate swallowed items. Unswallow it first then
manipulate it.
SVN revision: 74412
Subject: [E-devel] [patch][elementary] popup - getting proper geometry value]
current popup does not give proper geometry value,
evas_object_geometry_get(popup, &x, &y, &w, &h) gives 0, 0, 0, 0.
the patch resolves it, but it would be not a good way to get geometry
value. which is the best way to set obj->cur.geometry.x(y,w,h)?
please enlighten me. thanks.
SVN revision: 74409
- fixed theme to look less like an arse:
- overlap theme is translucent
- naviframe title visibility toggle is now animated
- item pop/push animation now applies to title area as well
- icon without title label is now centered (see Naviframe 2 test)
- title label and subtitle are now centered among the free space, should not overlap buttons anymore.
- title will use a font-size range, trying to not overlap buttons anymore.
- title will use ellipsis, trying to not overlap buttons anymore.
- prev/next buttons do not have a fixed min/max size anymore
- emit signals elm,state,title_label,show and elm,state,title_label,hide
- by default the previous button label is the title of the previous page
however by using a regular elm_button with an icon and long label
exposes a bug with button theme. And there is a conceptual issue: if
the previous button label is too big, it will look horrible. We should
have a maximum size that, if reached, should have ellipsis. This
should be a different elm_button style, with
elm/button/base/naviframe/back_btn/default being an alias to it.
SVN revision: 74403
back button now uses standard icon "arrow_left", and provides a "Back"
text that should be translated with the application.
Then we can define the elm/button/base/naviframe/back_btn/default as
an alias to the default button. If a theme wants it could still
provide an alternative button. IOW no breaks.
SVN revision: 74399
In real world it's very likely you're flipping to something, back or
front, not randomly flipping around based on one button.
I'd say we should deprecate the elm_flip_go().
SVN revision: 74360
whenever we "go" flip while flipping, we'll enter an inconsitent
state. We should detect where to flip and flip back if required.
Test: go to "Flip" test, click "1" button twice, before the first
animation ends.
SVN revision: 74359
Please review this patch I don't know the intention why did someone add this flags on mouse up in scroller.
Anyhow I tested and works fine.
SVN revision: 74334
Subject: [E-devel] [PATCH] elm_icon is disappeared when theme hook is
called.
[Current Issue]
- The elm_icon can be disappeared when theme hook is called.
You can see the problem in the below situation.
a) elementary_test -> Layout select
b) elementary_config -> Fonts(toolbar) -> select some font
class, font,
style, size
c) Select "Apply" button
then two icons in title layout are disappeared.
[Main cause]
- when theme hook is called, internally
_elm_image_smart_sizing_eval
function is called.
The function calculates icon's min, max size.
But min, max size is calculated only in case no_scale is true or
resize_down or resize_up is false.
If application isn't set no_scale or resize_down/up, minw and
minh value
is just -1.
So when theme hooks is called then sizing_eval is called, icon's
min size
is -1 and that is disappeared.
[Change Description]
- I just added evas_object_size_hint_min_get(obj, &minw, minh) in
_elm_image_smart_sizing_eval.
Patch is working well, but I don't think this is right solution
because
that would break image(icon) min,max concept
SVN revision: 74163
Allows setting a trap in elm_win that intercepts calls to
ecore_evas. If there is a trap and the trap returns EINA_FALSE, then
the corresponding call is NOT issued. If it does not exist or returns
EINA_TRUE, then the call is executed.
Enlightenment window manager will set these traps and will call
e_border directly, allowing E17 to use Elementary! A major feature
given e_widgets painful usage.
This should also help integrating into Wayland or even debug.
SVN revision: 74156
widgets.
Some of them have initting code using the parent ptr for some logic.
Now there's a new idiom on instantiating widgets which adresses
that. It'll be used for all widgets from now on.
SVN revision: 74147
When smart obj was set as the contents the _configure would be called recursively.
In this process the lastest size could be reverted as the previous one.
SVN revision: 74064
Subject: [E-devel] [PATCH] Add frame size when calculating minimized
elm_win size
Hi,
I found frame size including width and height isn't counted in
_elm_win_resize_objects_eval() when calculating minimized elm_window
size.
It is OK for X engine because elementary only draw client area and X
provides widow frame. So both the width and height from
evas_output_framespace_get are 0.
But it cause bug for wayland engine because elementary need draw
window
frame by itself. So real client area size is smaller than window size.
If frame size isn't counted into minimized window size, there isn't
enough client area to layout widgets.
So it is bug for any engine in which elementary draws window frame by
itself. It is the reason of
http://trac.enlightenment.org/e/ticket/1064.
Could you please my attached patch for this issue?
Thanks.
SVN revision: 74049
an app. they printf as OUTPUT. alkso u broke build:
/home/raster/C/elm/src/bin/test_genlist.c:2862: undefined reference to
_elm_log_dom'
of course there is no symbol exposed that is an INTERNAL LOG DOMAIN to
elm! it's for elm not for outside.
SVN revision: 73957
The ERRs thrown on the terminal while exiting some tests were already
there -- check that those decorate and stuff modes add lots of NULL
children on lists.
Genlist work exactly as before. All the bugs and feature were kept :)
SVN revision: 73941
knew him well. disable because it seems nothing i try requests it
except thunderbird, and thunderbird seems to sumarrily ignore the text
we provide. why - don't know. would have to now dig into thunderbir
src, but suffice to say plaintext is working a charmer, so let's stick
to that.
SVN revision: 73913
elementary configuration environment. Patch by Bluezery
<ohpowel@gmail.com>
On Thu, Jul 12, 2012 at 1:00 AM, Bluezery <ohpowel@gmail.com> wrote:
> Hello,
>
> Vertical bounce enable value can be changed by elementary
> configuration environment.
> But currently It was always EINA_FALSE. I fix that this value can be
> got from elm_config value.
>
> Please review this patch.
> Thanks
SVN revision: 73596
ecore_evas_window_get with a replacement function that checks the
currently used engine first. This fixes a segfault when running elm
with the wayland engines.
SVN revision: 73568
trying to use an invalid X window when running under the Wayland
backend. Replaces the non-safe call to ecore_evas_window_get, with an
_elm_ee_xwin_get function that checks the used engine first. Replace
call to ecore_evas_window_get inside elm_cnp.
SVN revision: 73567
Everytime a icon not on edje file is used (an standard icon),
an error was printed because it was trying to set it from
edje first.
Now it checks if the group exists on edje first.
SVN revision: 73543
We had an inconsistency of two missing getters, that would "leak" API
deprecation on specialized scrollers (scrollables). Putting them in
for good now.
SVN revision: 73540
i know - freeze is on. last thing going into elm. only because i
rejected the patch at the last minute and it was small enough to do
now.
SVN revision: 73450
Subject: [E-devel] [patch][elementary] diskselector, duplicate icon
for rounded item
minor fix to diskselector to repeat icons right.
The diskselector has round mode which can be set by
elm_diskselector_round_enabled_set().
In case of round mode is enabled, the icon does not display properly
because diskselector replace the icon for the additional items - not copy
and paste. To enable round mode, diskselector adds over/under itmes(additional
itmes) by using normal mode items. So there is a icon to set two places in
diskselector. But diskselector does not duplicate the icon.. this makes item
without icon but there should be.. I'm not sure the best way to duplicate icon.
SVN revision: 73397
Subject: Re: [E-devel] [Patch][layout] select layout in access mode
I revised the patch which has the way to get the state of
accessibility now. elm_layout_edje_object_can_access_set/get().
SVN revision: 73393
Its API will be the the common one on ALL scrollable widgets, too.
Any scrollable widget having a function behaviour clashing with one of
the elm_scroller_* will be marked as DEPRECATED from now on.
SVN revision: 73309
This is meant to be used for all widgets implementing scrolling views.
An Elementary interface adds a given behaviour to whichever widget,
from any class.
SVN revision: 73307
last to be evaluated.
Porting of the basic scrolling infra to an interface will happenfirst, as well as the scrolling widgets porting.
Patch by: Gustavo Lima Chaves <glima@profusion.mobi>
SVN revision: 73306
Subject: [E-devel] [Patch][elm_widget] access hook
Real time setting would be necessary in case of running applications
which
have elm_layout or elm_widget_item.
If the access mode does not care of this, running applications should
restart. The attached for this. Please review the patch and give any
feedbacks. Thanks.
SVN revision: 73229
Subject: [E-devel] [E-deve] [Patch] Add new apis for editable set/get
in multibuttonentry
Typically multibuttonentry is used as a composer.
But sometimes, Multibuttonentry can be used as a viewer.
Currently there is no way to use multibuttonentry as non-editable
viewer.
So I added new APIs which are elm_multibuttonentry_editable_set/get().
If editable is true, entry in multibuttonentry is activated and user can
compose item by pressing the return key.
If not, entry is hidden and muttibuttonentry works as a non-editable
viewer.
SVN revision: 73223
Subject: [E-devel] [Patch] Added new style for hoversel (hoversel_horizontal)
Problem:
Ticket #838 (new Bug). Items appear without background on a
horiz-hoversel.
Just add: elm_hoversel_horizontal_set(bt, EINA_TRUE); to the first
hoversel
added in test_hoversel.c then try to open it.
Items appear without black background.
SVN revision: 73078
Subject: [E-devel] [Patch] Patch for test case for panel widget
(genlist expand automatically)
Problem:
In test case for panel widget genlist not expand automatically
Commit log:
Added patch for test case for panel widget (genlist expand
automatically).
SVN revision: 73077
Subject: [E-devel] [Patch] Patch for normal scaling in elm_panel.c
widget
Problem:
Ticket #656 (new Bug) . The whole test window size will just grow
larger and
larger on each _theme_hook called.
Easy to reproduce: 1. Open elementary_test's panel test 2. Do
something that
issues a theme_hook (change scale etc)
SVN revision: 73076
Subject: [E-devel] [Patch][elementary] elm_access, use widget_item in
focus chain
It has been possible to use widget_item in access mode. The mouse-in
event
makes the widget_item speak.
But focus chain is not useful in access mode, because the widget_item
cannot get the focus as the edje object.
The accessibility highlight will move by keeping the attached patch
and you
can hear the sound of widget item information.
Please review the patch and give some feedbacks. There would be further
works such as dynamic setting focus next hook,
the previous _elm_access_list_register();, but please keep this first if
there is no big trouble. I'll do those also. Thanks.
SVN revision: 73074
Subject: [E-devel] Fwd: [Patch] elm_toolbar add signals patch.
For new style of toolbar (align icon and text to center of item) are
necessary some signals ("elm,state,text,visible",
"elm,state,text,hidden", "elm,state,icon,visible",
"elm,state,icon,hidden")
New style for toolbar, where icon and text are align to center of item.
SVN revision: 73028
It seems that the elementary examples still use some deprecated functions,
most notably elm_icon_* that has been replaced by elm_image_*.
This patch fixes that.
Patch by: Daniel Willmann <d.willmann@samsung.com>
SVN revision: 72958
One should either listen to mouse events and filter the corrosponding multi
events, or listen only to multi events. We chose the former, so we should
handle it correctly.
SVN revision: 72905
The datetime module has unnecessary lines.
The datetime resets ctxpopup parent in ctxpopup parent resize callback.
But ctxpopup has its own callback for the parent resize.
In this callback, ctxpopup hides itself. then, ctxpopup recalculates its
parent size when ctxpopup shows itself.
So the parent resize callback in the datetime is not necessary.
Then, please review the patch and give some feedbacks. Thanks.
Patch by Shinwoo Kim.
SVN revision: 72518
revert ->
Log:
From: Daniel Willmann <d.willmann@samsung.com>
Subject: Re: [E-devel] [PATCH] elementary: Add
elm_progressbar_maxunit_{set, get} functions
Some more discussion in IRC led to the conclusion that this should be a
handled in a signal callback I've attached the new patch where I also
updated the progress bar example.
Author: raster
Date: 2012-06-19 02:26:29 -0700 (Tue, 19 Jun 2012)
New Revision: 72459
SVN revision: 72506
Implements the module unloading to all modules on elm_module_shutdown.
This change also fixes a memory leak within elm_module picked by valgrind.
Here follows the valgrind log:
96 bytes in 1 blocks are definitely lost in loss record 105 of 168
at 0x4C29DB4: calloc (
in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x52065B6: _elm_module_add (elm_module.c:223)
by 0x520669E: _elm_module_parse (elm_module.c:77)
by 0x51F1249: elm_quicklaunch_sub_init (elm_main.c:437)
by 0x51F12BE: elm_init (elm_main.c:180)
Patch by Leandro Dorileo <dorileo@profusion.mobi>
SVN revision: 72499
Removes the event callback list within _smart_del. The current
implementation does not care about the node data resulting on
memory leaks.
Here follows the valgrind log:
16 bytes in 1 blocks are definitely lost in loss record 11 of 168
at 0x4C29DB4: calloc (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x522EC34: elm_widget_event_callback_add (elm_widget.c:1996)
by 0x5A7AA2B: _edje_emit_handle (edje_program.c:1322)
by 0x5A766B6: _edje_message_queue_process (edje_message_queue.c:764)
by 0x5A76856: _edje_job (edje_message_queue.c:160)
by 0x628C02A: _ecore_job_event_handler (ecore_job.c:115)
by 0x6288C1F: _ecore_event_call (ecore_private.h:319)
by 0x628D09B: _ecore_main_loop_iterate_internal (ecore_main.c:1814)
by 0x628D566: ecore_main_loop_begin (ecore_main.c:931)
by 0x4023B0: elm_main (test.c:198)
Patch by Leandro Dorileo <dorileo@profusion.mobi>
SVN revision: 72498
Subject: Re: [E-devel] [PATCH] elementary: Add
elm_progressbar_maxunit_{set, get} functions
Some more discussion in IRC led to the conclusion that this should be a
handled in a signal callback I've attached the new patch where I also
updated the progress bar example.
SVN revision: 72459
Gustavo Lima Chaves
Christopher Michael
Cedric BAIL
Jihoon Kim
Kim Shinwoo
Gustavo Sverzut Barbieri
Carsten Haitzler
Daniel Juyung Seo
WooHyun Jung
ChunEon Park
Jaehwan Kim
Seunggyun Kim
yan.wang
Mike Blumenkrantz
Michael BOUCHAUD
Bruno Dilly
Tom Hacohen
Jiyoun Park
Daniel Willmann
Minseok Kim
Artem Popov
Vincent Torri
Hyoyoung Chang