Adrien Nader
3778036926
efreet: reverse if's condition and swap then/else blocks for readability
...
The reversal makes it possible to merge two #if and unspaghetti the code
a bit.
Since the diff is not very readable, here is the before/after to show
the spirit:
before:
#if cond
if (...)
#endif
do_foo();
#if cond
else
do_bar();
#endif
after:
#if cond
if ( ! ...)
do_bar();
else
#endif
do_foo();
2014-08-14 20:55:58 +09:00
Adrien Nader
0fb9f5d516
efreet: remove #ifdef GETUID inside #ifdef _WIN32 (it's always false).
2014-08-14 20:55:58 +09:00
Sebastian Dransfeld
e7198621c5
efreet: use eina_file_mkstemp to create filename
2014-08-14 13:30:48 +02:00
Sebastian Dransfeld
b9c2a08105
benchmarks: close mkstemp file
...
eina_file_mkstemp returns an open filedescriptor, so we need to close
it.
2014-08-14 13:30:48 +02:00
Carsten Haitzler
5a722ca6fe
fix structurally dead code warning
...
CID 1039494
2014-08-14 20:21:19 +09:00
Carsten Haitzler
111fd9339c
evas gl - fix structurally dead code
...
unused var protection in ifdef - use unused macro instead. fixes
CID 1039495
2014-08-14 20:18:56 +09:00
Carsten Haitzler
029c6847d7
evas render i386 - comment out structurally dead code
...
this code has bugs, so comment it out rather than just have a return
get rid of it - CID 1039499
2014-08-14 20:17:16 +09:00
Carsten Haitzler
d399921724
fix structurally dead code
...
this cleans up fixing of unused param warnings - fix
CID 1039524 1039504 1039523 1039503 1039522 1039502 1039521 1039501
1039540 1039520 1039539 1039519 1039538 1039537 1039517 1039536
1039516 1039535 1039515 1039534 1039514 1039533 1039513 1039532
1039512 1039531 1039511 1039530 1039510 1039529 1039509 1039528
1039508 1039527 1039507 1039526 1039506 1039525 1039505
2014-08-14 20:17:16 +09:00
Carsten Haitzler
2bd42962e3
eet init - fix structurally dead code
...
CID 1039542
2014-08-14 20:17:16 +09:00
Carsten Haitzler
9d40475b22
edje - edje load - remove structurally dead code
...
CID 1039543
2014-08-14 20:17:16 +09:00
Carsten Haitzler
eeab470cf1
evas xpm loader - fix xpm loader overrun check
...
coverity CID 1039596 - the code actually was wrong. do not multiple by
sizeof(DATA32) for ptr compare here.
2014-08-14 20:17:16 +09:00
Sebastian Dransfeld
95a02295c1
efreet: remove creation of XDG_RUNTIME_DIR
...
XDG_RUNTIME_DIR should be created and set by the system, not a library.
2014-08-14 13:01:29 +02:00
Carsten Haitzler
03f7ff5f27
evas sw-x11 - fix pointless code in dri swapper
...
this fixes CID 1039620 - it pointed out a pointless null check.
2014-08-14 19:49:34 +09:00
Carsten Haitzler
1294a91201
evas gl generic - remove dead code
...
coverity CID 1039633 pointed out dead code and some invalid null
checks. fixed!
2014-08-14 19:44:16 +09:00
Carsten Haitzler
257e853407
eio - fix possible stringhare del bug in dir chmod
...
coverity picked this up - CID 1039645. it does indeed look like a real
bug. if order->dirs is empty. for example.
2014-08-14 19:40:54 +09:00
Carsten Haitzler
8da87146b4
formatting fix
2014-08-14 19:39:46 +09:00
Carsten Haitzler
4771d25e9f
edje swallow resize handling
...
this fixes some deadcode in CID 1039646 that suggests we should do a
check for rp->typedata.swallow first before we go using it.
2014-08-14 19:36:40 +09:00
Carsten Haitzler
bc6eb8fcec
edje entry - fix format appending with just empty strings
...
this fixes CID 1039647 - it caught a real bug. we were not skipping
out on an empty + or - push/pop format fomamnt if it had nothing
there. not actually something people do - but possible. fix!
2014-08-14 19:32:45 +09:00
Carsten Haitzler
53ddf83842
edje_pick - remove unused var that we just free and nothing else
...
this should fix CID 1039669
2014-08-14 19:25:32 +09:00
Carsten Haitzler
90bbc73c6e
eina unicode - remove pointless operands
...
fixes CID 1039676
2014-08-14 19:18:46 +09:00
Carsten Haitzler
bcbe9f621e
embryo_cc - check return value
...
this matches the check for fgetpos()
2014-08-14 19:11:06 +09:00
Carsten Haitzler
4e85b6b57b
embryo_cc - fix return value checking
...
fixes CID 1039712
2014-08-14 19:09:30 +09:00
Carsten Haitzler
f9cef6f079
epp - fix unchecked return
...
fix CID 1039717
2014-08-14 19:04:38 +09:00
Carsten Haitzler
00d3bd1747
epp - fix unchecked return
...
this fixes CID 1039718
2014-08-14 19:02:39 +09:00
Carsten Haitzler
27ef84e372
edje_decc - fix unchecked return value
...
fix CID 1039719
2014-08-14 19:00:37 +09:00
Carsten Haitzler
2ee14e5997
embryo_cc - make assert clearer
...
this fixes coverity warning CID 1039730
2014-08-14 18:55:02 +09:00
Carsten Haitzler
e263af08c9
eldbus - fix varargs missing end in iter get and next
...
there was an error return handler that would return without doing
va_end(). coverity picked this up. this fixes CID 1039883
2014-08-14 18:53:40 +09:00
Carsten Haitzler
ff12b4b955
evas cache - fix logically dead code
...
fix CID 1039928
2014-08-14 18:53:40 +09:00
Carsten Haitzler
bd3c2c245d
evas cache - fix logically dead code
...
fixes CID 1039929
2014-08-14 18:53:39 +09:00
Carsten Haitzler
cb9a2410af
evas cache - fix logically dead code
...
fixes CID 1039930
2014-08-14 18:53:39 +09:00
Carsten Haitzler
18e2302184
evas cache - fix logically dead code
...
fixes CID 1039931
2014-08-14 18:53:39 +09:00
Carsten Haitzler
d24af520dc
evas cache - fix logically dead code
...
this fixes CID 1039932
2014-08-14 18:53:39 +09:00
Carsten Haitzler
cf704cc5a0
evas cache - remove logically dead code
...
fix CID 1039934
2014-08-14 18:53:39 +09:00
Carsten Haitzler
6b312e9818
evas cache - fix logically dead code
...
this fixes CID 1039935
2014-08-14 18:53:39 +09:00
Carsten Haitzler
13917c8769
eina_inlist_sorted_state_insert - fix logically dead code
...
this fixes CID 1039938
2014-08-14 18:53:39 +09:00
Carsten Haitzler
9767fa2b9c
eina list insert sorted - fix logically dead code
...
this fixes CID 1039941
2014-08-14 18:53:39 +09:00
Stefan Schmidt
d37b312141
README: Update statement about C++ usage.
...
Its no longer interfacing to bullet only but also our C++ bindings that
need the C++ compiler.
2014-08-14 11:36:11 +02:00
Carsten Haitzler
874e87e8df
fix noop self-assignment
...
this fixes CID 1040028
2014-08-14 18:25:42 +09:00
Carsten Haitzler
4b431d3638
evas font - fix null access of font format possibility
...
this fixes NULL access in CID 1099705, 1099703, 1099704
2014-08-14 18:14:08 +09:00
Carsten Haitzler
24a1c444b0
evas scalecache - fix thread deadlock posssibility
...
there is a re-ordering of how locks are taken and this should cover
that deadlock possibility. fixes CID 1106338
2014-08-14 18:10:11 +09:00
Carsten Haitzler
eec2daf31b
evas preload + locking - fix deadlock
...
there is a possible deadlock condition where locks are not taken in
the same order (img lock then cancel lock). re-order so this doesn't
happen. this fixes CID 1106339
2014-08-14 18:03:07 +09:00
Carsten Haitzler
31045df0d2
evas gl - fix possible null tls resource access in bindframebuffer
...
this fixes CID 1181887
2014-08-14 17:41:55 +09:00
Carsten Haitzler
e82b61b420
epp - fix bit underflow in bitshift for multibyte
...
this fixes CID 1193200
2014-08-14 17:39:11 +09:00
Carsten Haitzler
49694c9a64
xpm - colors cant be 96 bytes long.
...
since colors are hex, 96 bytes of hex would be 32bytes per r, g and b,
and that would be 128 bits per r g and b and that just is never seen
or used. also coverity is right in CID 1193201 that we just can't
shift that many, so go down to max 16 bits per rgb which is sensible
and able to be done. (thats 12 bytes max for hex of color).
2014-08-14 17:34:39 +09:00
Carsten Haitzler
caf2b018a2
fix possible focket fd of -1 in cserve
...
this fixes CID 1193207 where a server fd may be -1, connect fail and
still be -1 due to failed connect.
2014-08-14 17:18:57 +09:00
Carsten Haitzler
c87748a7c1
evas cserve - handle possilbe null ref and fentry pointers
...
this fixes CID 1193209 with possible NULL refs.
2014-08-14 17:16:02 +09:00
Carsten Haitzler
3ad7feafe3
evas ico loader - ensure count is within sane ranges
...
this hopefully addresses CID 1205000
2014-08-14 17:04:55 +09:00
Carsten Haitzler
b25c416b14
evas 3d - remove logically dead code
...
coverity is right. this code is misleading - fixes CID 1210806
2014-08-14 16:35:57 +09:00
Carsten Haitzler
1cf526286a
fix edje file fetch
...
this fixes CID 1210811
2014-08-14 16:31:45 +09:00
Carsten Haitzler
9cb92e3727
fix null check of edje file data
...
this fixes CID 1210812
2014-08-14 16:29:03 +09:00