Commit Graph

4140 Commits

Author SHA1 Message Date
Yeongjong Lee d36beba2bb elm_photocam: fix correct return value in elm_photocam_file_set
Test Plan: `elm_photocam_file_set(NULL, "file_name");`

Reviewers: Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8473
2019-03-26 15:04:52 +09:00
Bowon Ryu a026405a6a efl_ui_tab_pager: fixed issue where tab_pager does not work
Summary:
I fixed the tab_pager behavior problem caused by changing efl interface.
and I have also fixed some sample code errors.
 - using efl_file_load for efl_file_set
 - using efl_del for unpacked tab_page
 - disable unimplemented features

Test Plan: elementary_test -to efl.ui.tab_pager

Reviewers: Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8471
2019-03-26 14:20:27 +09:00
Yeongjong Lee 43b199aca3 elm_photocam: fix file_get,set operations
Summary: This patch fixes bug that elm_photocam_file_get always return NULL.

Test Plan: make check

Reviewers: Hermet, zmike, bu5hm4n

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8472
2019-03-26 13:16:32 +09:00
WooHyun Jung d761658985 elm_entry: fix a bug in moving the magnifier
Summary:
When moving the magnifier in elm_entry, _magnifier_move
function occured infinite loop problem by calling
evas_object_move twice with different positions.
So, I changed it to call evas_object_move once.

ref T7202

Test Plan:
1. Set profile to "mobile"
2. elementary_test
3. entry
4. long press mouse button on elm_entry
5. when the magnifier is shown, try to move it

Reviewers: zmike, bu5hm4n, bowonryu, id213sin

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7202

Differential Revision: https://phab.enlightenment.org/D8462
2019-03-25 08:52:10 -04:00
Hermet Park 620eb070f4 efl_ui_image: remove job in sizing calc.
Originally, this job task was introduced for trick optimization to avoid
unnecessary duplicated compuation.

But this introduced a regression bug as well, image geometry updation was
delayed by this.

So, we remove the job here.

@fix T7360
2019-03-25 19:49:54 +09:00
Yeongjong Lee 476010b018 elm_win: fix correct rot variable in elm_win_rotation_get
Remove duplicated rotation variable

Also, it fixes wrong layout class comparing.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8464
2019-03-25 11:36:14 +01:00
Yeongjong Lee aa54d57a07 efl_ui_container_layout: use correct property
The `if` condition check whether horizontal, vertical aspect are greater than 0.
`aspect` is correct here.

this patch fixes T7756

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8461
2019-03-25 10:58:43 +01:00
Marcel Hollerbach 04122ec311 elm_gengrid: speed up update order calls
update order can be quite expensive, so this here tries to skip it as
often as possible.

ref T7384

Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D8367
2019-03-25 10:54:13 +01:00
Marcel Hollerbach f1678d06c2 elm_gengrid: rework focus registration
before just everything has been registered, now only the realized items
are registered.

ref T7384

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8366
2019-03-25 10:54:12 +01:00
Shilpa Singh ed51150853 efl_access: if 0 is set as reading_info_type, remove existing reading_info
Summary:
if 0 is set as reading_info_type, remove existing reading_info and
allow default reading info types (name, role, state and description)
to be read.
Do not set reading info again in reading_info_type_set API if new
value matches the old value.

Test Plan:
If application does not set reading_info_type or set 0 reading_info_type,
All four reading info types of an accessible object should be read on highlight.

Signed-off-by: Shilpa Singh <shilpa.singh@samsung.com>

Reviewers: kimcinoo, jsuya, bu5hm4n, lukasz.stanislawski

Subscribers: prasoonsingh16, rajeev.jnnce, #reviewers, cedric, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8435
2019-03-25 10:11:39 +09:00
Xavi Artigas 205193f1ab docs: Add @since 1.22 to all stable classes' EO docs
Summary: Previous @since tags have already been removed from eo files.

Test Plan: Everything builds, but stable classes now have Since tags in the docs.

Reviewers: zmike, bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8446
2019-03-22 16:57:36 +01:00
Jaehyun Cho 44d0cb9260 elm_atspi_bridge: remove all legacy usage from eo files
this takes the current generated output from eolian for legacy code in
efl and adds it to the tree, then removes legacy references from the
corresponding eo files. in the case where the entire eo file was for
a legacy object, that eo file has been removed from the tree

ref T7724
2019-03-22 16:04:32 +09:00
Jaehyun Cho 0225db71c0 elm_atspi_app_object: remove all legacy usage from eo files
this takes the current generated output from eolian for legacy code in
efl and adds it to the tree, then removes legacy references from the
corresponding eo files. in the case where the entire eo file was for
a legacy object, that eo file has been removed from the tree

ref T7724
2019-03-22 16:04:29 +09:00
Taehyub Kim bb81ccdac1 efl_ui_layout: Eina_Error type has been modified to work correctly.
Summary:
fix Eina_Error type calculation in _efl_ui_layout_base_efl_ui_widget_theme_apply() to behave as before.

@fix

Test Plan: run elementary_test for all widgets

Reviewers: #reviewers, Jaehyun_Cho, Hermet

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8443
2019-03-22 12:38:44 +09:00
SangHyeon Jade Lee b747af5181 elm : fix wrong layout class comparing in orientation mode disable
automatic theme lotation is layout base class property which can be applied
layout based widget classes.
currently it only comparing EFL_UI_LAYOUT_CLASS so layout base inherited class
can not be applied this feature properly.

depends D8434

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8436
2019-03-21 10:33:58 +01:00
SangHyeon Jade Lee 7bb702b0df elm : fallback orientation_mode_disable_set legacy behavior to get true disabled state as what we set.
current code set the disable EINA_TRUE when disabled,
but once it was set diabled, it never changed EINA_FALSE even we set the orientation_mode_disable as FALSE.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8434
2019-03-21 10:33:57 +01:00
Prasoon Singh e0511c995f elm_gesture_layer: Use flag returned by gesture callbacks
Summary:
Instead of flag returned by gesture callbacks, always EVAS_EVENT_FLAG_NONE
flag was being used.

Test Plan:
As event flag was not being appropriately updated, in some cases expected
behaviour was not seen.

Reviewers: shilpasingh, cedric, Hermet, segfaultxavi

Reviewed By: shilpasingh, segfaultxavi

Subscribers: segfaultxavi, #reviewers, rajeev.jnnce, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8421
2019-03-21 10:08:07 +01:00
Mike Blumenkrantz 5930c5f86e efl_ui_win: avoid triggering legacy forbidden path during window finalize
this (unintentionally) revealed some bugs where apps/examples were mixing
eo and legacy code for elm_win which breaks things pretty badly. I'm only
here so I don't get fined.

ref T7713

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8401
2019-03-20 12:36:59 -07:00
Mike Blumenkrantz fcf2eb2205 efl_ui_win: mark legacy forbidden during bg part load always
calling this function indicates legacy is forbidden, not successfully
loading a file. this is functionally meaningless, as the only way to
trigger the previous codepath would be to have previously set legacy
as forbidden, but perhaps it will be slightly easier to read now

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8400
2019-03-20 12:36:57 -07:00
Mike Blumenkrantz b8ff87fc1d efl_ui_win: fix hw accel detection
the ordering of priority here is supposed to be:

1. env vars
2. global override config
3. window config
4. global config

in the case where 1 and 3 were not set, however, this would end up
mangling the global config values and not using the gl options

@fix

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8389
2019-03-20 12:36:50 -07:00
Xavi Artigas bbd4b6e514 docs: Remove obsolete @since tags from EO files
Summary:
All legacy @since tags have already moved to the *.legacy.h files.
EO files are now devoid of @since tags (except some eldbus still
needed for legacy).
Upcoming patches will add @since 1.22 to those APIs which come out
of beta in this release.
APIs marked @beta do not need @since tags.

Test Plan: Everything builds, EO docs (like DocFX) have no Since tags.

Reviewers: zmike, bu5hm4n, lauromoura, cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8430
2019-03-20 20:16:05 +01:00
Marcel Hollerbach c081825bc8 efl_ui_tab_bar: the type of this event is annotated as object
however, efl_ui_tab_bar does pass in there a int. For now i decided that
we just pass NULL here, if this is not accaptable then we can still add
another event to the object itself.

fix T7758

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8418
2019-03-20 18:50:48 +01:00
Marcel Hollerbach decfca4f23 efl_ui_selection: give this event a better name
this event does not get emitted when selection per se changes, it gets
emitted when the selection in the window manager changes. we should
prefix this even with that.

ref T7476

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8424
2019-03-20 16:59:39 +01:00
Marcel Hollerbach 7069b0efc0 efl_ui_list_view: remove not used event
this event is not used here, and if it ever is used, then it should
probebly be using efl.ui.selectable.

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8423
2019-03-20 16:59:38 +01:00
Yeongjong Lee 77f2782d29 ui.box_stack: refactor layout_update
Summary:
This patch remove evas_box function from Efl.Ui.Box_Stack and add unit test.

Depends on D8214

Test Plan:
1. make check
2. elementary_test -to 'efl.ui.box_stack'

Reviewers: zmike, Jaehyun_Cho, cedric

Reviewed By: zmike, Jaehyun_Cho, cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8094
2019-03-20 10:37:42 -04:00
Shilpa Singh e80169a844 efl_access: Add attribute_del API, Add test cases for all access_object_attribute* APIs
Add attribute_del API, currently there is no provision to delete a particular attribute(key-value pair)
from the attribute list of a widget.
Add test cases for efl_access_attribute_append, efl_access_attributes_get, efl_access_attribute_del and efl_access_attributes_clear API

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: Shinwoo Kim <cinoo.kim@samsung.com>
Differential Revision: https://phab.enlightenment.org/D8386
2019-03-20 15:29:04 +01:00
Lauro Moura efb05a3ac8 efl: Add missing docs to parameters.
Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8422
2019-03-20 14:13:22 +01:00
Yeongjong Lee 37c703437a efl.pack_table: inherit efl.pack instead of efl.pack_linear
Summary:
>>! In T5301#110572, @jpeg wrote:
> Quick recap before I leave.
> ...
> ...
>  - Pack interfaces - T5328
>
> Table does not need to inherit from "linear" (1d) layout: this brings unnecessary complexity, for a dubious use case.

We don't have linear layout policy of table(2d) layout. furthermore, i don't
think it will be clearly defined. it is enough for Efl.Pack_Table to support
`efl_pack` which work the same as `efl_pack_end`.

ref T5719, T5328

Test Plan:
- make
- elementary_test -to 'efl.ui.table'
- elementary_test -to 'efl.ui.table(linear api)'

Reviewers: zmike, woohyun, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, jpeg, #committers

Tags: #efl

Maniphest Tasks: T5719, T5328

Differential Revision: https://phab.enlightenment.org/D8420
2019-03-20 12:54:25 +01:00
Marcel Hollerbach 6dec272d31 efl_ui_focus_object: apply new event calling convention
Summary:
ref T7758
Depends on D8408

Reviewers: cedric, zmike, segfaultxavi

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7758

Differential Revision: https://phab.enlightenment.org/D8409
2019-03-19 16:31:55 -04:00
Marcel Hollerbach 60384a4d40 evas: apply new event calling convention
Summary:
ref T7758

Depends on D8407

Reviewers: cedric, zmike, segfaultxavi

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7758

Differential Revision: https://phab.enlightenment.org/D8408
2019-03-19 16:31:50 -04:00
Marcel Hollerbach 158336d19e efl_ui_tags: apply new event calling convention
Summary:
it appears that this event calling is a bit fishy, the value of the
second callback call was never set, i think the shrink flag here is what
we want to return here.

T7758
Depends on D8406

Reviewers: cedric, zmike, segfaultxavi

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8407
2019-03-19 16:31:45 -04:00
Marcel Hollerbach f5fb68e1cd efl_ui_win: apply new event calling convention
Summary:
ref T7758
Depends on D8405

Reviewers: cedric, zmike, segfaultxavi

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7758

Differential Revision: https://phab.enlightenment.org/D8406
2019-03-19 16:31:39 -04:00
Marcel Hollerbach e4e14f50db efl_ui_focus_manager_sub: apply new event calling convention
Summary: ref T7758

Reviewers: cedric, zmike, segfaultxavi

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7758

Differential Revision: https://phab.enlightenment.org/D8405
2019-03-19 16:31:34 -04:00
Marcel Hollerbach 11003bcae3 efl_ui: rename select and unselected of efl_ui_selectable
Summary:
this was conflicting with a model event. Prefixing it with "item,"
resolves this, and describes better what it does.
Depends on D8413

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8414
2019-03-19 16:30:19 -04:00
Marcel Hollerbach 9a3d4310be elm: do not use eo events here
Summary:
we want to rename it, and this would break legacy behaviour, so better
this way.
Depends on D8412

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8413
2019-03-19 16:29:45 -04:00
Marcel Hollerbach c9cdb916cd Revert "efl_ui_selectable: namespace events to avoid conflicts"
Summary:
This reverts commit f629f11bed.

This breaks legacy events. As the selected event is used in legacy
widgets. Also this commits mixed up two different concepts, selection in
a entry etc. and selection of a item.
Depends on D8411

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8412
2019-03-19 16:29:39 -04:00
Marcel Hollerbach bb0290edbe efl_ui_widget: resolve warning about multiple defines
Summary:
the difference here is, that the macro before did not print ERR's the
one now does. Hence this commit remove two error messages.

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8415
2019-03-19 16:28:10 -04:00
Yeongjong Lee a278e4ea9d efl_ui_text_alert_popup: use correct theme klass name
text_alert_popup is not scroll_alert_popup.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8364
2019-03-19 19:20:02 +01:00
Xavi Artigas 8c39c0e251 Revert "efl_ui_widget: resolve warning about multiple defines"
This reverts commit 9012742f9a.

I landed this too hastily.
2019-03-19 16:50:13 +01:00
Marcel Hollerbach 9012742f9a efl_ui_widget: resolve warning about multiple defines
Summary:
the difference here is, that the macro before did not print ERR's the
one now does. Hence this commit remove two error messages.

Depends on D8394

Reviewers: zmike, segfaultxavi, cedric, devilhorns

Reviewed By: segfaultxavi

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8395
2019-03-19 16:41:45 +01:00
Marcel Hollerbach d44a818d8c efl_ui_zoomable: fix widget
Summary:
before the efl_file_set operations have been safed, and then applied on
the internal evas_image. With the refactor
6326e18b3f, this was broken, and the
file_set was applied to the super object which is a layout here.

fix T7748

Reviewers: zmike, segfaultxavi, cedric, devilhorns

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7748

Differential Revision: https://phab.enlightenment.org/D8394
2019-03-19 09:37:57 -04:00
Christopher Michael 04ea005218 efl_ui_widget: Remove duplicate definition of ELM_WIDGET_DATA_GET
Patch 28400e3260 added a define for ELM_WIDGET_DATA_GET
which is available for all widgets so we do not need to redefine it
here.
2019-03-19 08:33:01 -04:00
Christopher Michael 7ceba76957 elm_entry: Add missing EINA_UNUSED
'sd' is an unused parameter here so add missing EINA_UNUSED
2019-03-19 08:31:03 -04:00
Christopher Michael 05c9aff90a elementary: Use efl_data_scope_safe_get when trying to get widget data
As per bu5hm4n, these macros should be using efl_data_scope_safe_get
when trying to get widget data
2019-03-18 15:19:21 -04:00
Christopher Michael 28400e3260 elementary: Add ELM_WIDGET_DATA_GET macro
There are cases, such as 2abe5ad9bc where we do not
always want to return if we fail to get the elm widget data (as we may
have to cleanup leaks, etc). As such, add a macro we can call which
will just try to fetch the elm_widget data.
2019-03-18 15:14:54 -04:00
Ali Alzyod d8c770be1c Fix _entry_has_new_line on detecting new lines when it finds <br> <ps> in passed string
Summary:
Fix issue where **_entry_has_new_line** will not detect '<br>' or '<ps>' inside markup text as new lines indicators.

this  functionlity effect following public function:
**elm_entry_single_line_set()**

Reviewers: woohyun, bowonryu, ManMower, cedric, raster, segfaultxavi

Reviewed By: bowonryu, segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8323
2019-03-18 19:47:57 +01:00
Christopher Michael 2abe5ad9bc elm_focus_legacy: Fix resource leaks
Summary:
Coverity reports 2 resource leaks here because old_chain & new_chain
are never freed if we fail to return widget data. Use just
ELM_WIDGET_DATA_GET, manually check for valid 'ppd' and if false we
can just break out of the for loop here.

Fixes Coverity CID1399096, CID1399095

@fix

Depends on D8352

Reviewers: raster, cedric, zmike, bu5hm4n, stefan_schmidt

Reviewed By: cedric, bu5hm4n

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8353
2019-03-18 14:47:58 -04:00
Yeongjong Lee cced5487c8 efl_ui_layout: call efl_del instead of efl_unref when text part does not exist
Summary:
Because `efl_isa` doesn't call _efl_object_call_end, the part object is not
removed. it occurs a bunch of efl_unref error message.

Test Plan:
1. elementary_test -to 'efl.ui.box'
2. exit window.
3. check there is no efl_unref error message.

Reviewers: zmike, cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8385
2019-03-18 08:50:19 -04:00
Daniel Kolesa 58b8a3d163 efl: remove EFL_EO_API_SUPPORT macro
Summary:
Since we're now going to be shipping some eo classes as stable,
there is no point in keeping the eo api behind a macro, and it
should be enabled by default. Another case is beta classes, but
those are behind the EFL_BETA_API_SUPPORT guard.

This also changes includes around the place where things are
clearly broken (such as an included header needing something
from another header but that other header being guarded, notably
efl_ui_widget.h needing focus manager but focus manager being
behind beta in Elementary.h)

Reviewers: zmike, cedric, bu5hm4n, stefan_schmidt, segfaultxavi

Reviewed By: cedric, segfaultxavi

Subscribers: segfaultxavi, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8322
2019-03-18 12:13:59 +01:00
Marcel Hollerbach 3fa8bb7bad elm_focus: document that focus_region_show_mode more
it appears that this API is only implemented in Elm_Gengrid, this patch
adds documentation for this.

ref D8286

Reviewed-by: YeongJong Lee <yj34.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D8383
2019-03-18 11:14:45 +01:00
Christopher Michael 5e7bc44d34 efl_ui_focus_manager_calc: Fix resource leaks
Summary:
Coverity reports that we leak old_chain & chain variables here if we return.
Add an eina_array_free for both to clean this up.

Fixes Coverity CID1396984,CID1396965

@fix

Depends on D8353

Reviewers: raster, cedric, zmike, bu5hm4n, stefan_schmidt

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8355
2019-03-15 12:57:18 -04:00
Christopher Michael 12f0dc4fdd efl_ui_text: Fix resource leak
Summary:
Coverity reports a resource leak here. When we return due to invalid
selection, we should free the 'ldata' that we previously allocated

Fixes Coverity CID1396998

@fix

Reviewers: raster, cedric, q66, zmike, bu5hm4n, stefan, stefan_schmidt

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8320
2019-03-15 12:14:05 -04:00
Wonki Kim 597b82444a elm_entry: fix to keep api backward compatability
Summary:
if passing NULL as filename to elm_entry_file_set,
elm_entry_entry_get NULL as return value before.
and it doesn't now.

Test Plan:
1. passing a existing file to efl_entry_file_set
2. passing NULL as file to efl_entry_file_set
3. check return value of elm_entry_entry_get

Reviewers: zmike, bu5hm4n

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8363
2019-03-15 11:23:09 -04:00
Wonki Kim dae881c9dc elm_entry: fix to return a error code if a argument is not valid
Summary:
if format is not specified, it should return some error code.
this is a kind of a patch to keep backward compatability of the api.

Reviewers: zmike, bu5hm4n

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8337
2019-03-15 11:23:09 -04:00
Christopher Michael eeb6d626ea efl_ui_win: Fix dereference null return value
Summary:
Coverity reports efl_data_scope_safe_get returns NULL here (checked
273 out of 285 times). Add an EINA_SAFETY check here before trying to
use 'sd'.

Fixes Coverity CID1399425

@fix

Depends on D8348

Reviewers: raster, cedric, zmike, bu5hm4n, stefan_schmidt

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8349
2019-03-15 08:58:04 -04:00
Christopher Michael 94405eca3b efl_ui_win: Fix dereference null return
Summary:
Coverity reports that efl_data_scope_safe_get returns NULL here
(checked 273 out of 285 times). Add an EINA_SAFETY check before trying
to use 'sd'.

Fixes Coverity CID1399426

@fix

Depends on D8347

Reviewers: raster, cedric, zmike, bu5hm4n, stefan_schmidt

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8348
2019-03-15 08:57:54 -04:00
Christopher Michael 0f1f5dabf3 efl_ui_win: Fix dereference null return
Summary:
Coverity reports that efl_data_scope_safe_get returns NULL here
(checked 273 out of 285 times). Add an EINA_SAFETY check here before
trying to use 'sd'.

Fixes Coverity CID1399427

@fix

Depends on D8346

Reviewers: raster, cedric, zmike, bu5hm4n, stefan_schmidt

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8347
2019-03-15 08:57:44 -04:00
Christopher Michael 384d960852 efl_ui_win: Fix dereference null return value
Summary:
Coverity reports efl_data_scope_safe_get returns NULL here (checked
273 out of 285 times). Add an EINA_SAFETY check here for a null return.

Fixes Coverity CID1399428

@fix

Depends on D8345

Reviewers: raster, cedric, zmike, bu5hm4n, stefan_schmidt

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8346
2019-03-15 08:57:34 -04:00
Christopher Michael 1688b5d511 elm_atspi_bridge: Fix resource leak
Summary:
Coverity reports a resource leak here because the dbus 'reply' message
is never unref'd. Fix that.

Fixes Coverity CID1399429

@fix

Depends on D8344

Reviewers: raster, cedric, zmike, bu5hm4n, stefan_schmidt

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8345
2019-03-15 08:57:24 -04:00
Christopher Michael c802103789 elm_atspi_bridge: Minor formatting fixes
Summary:
NB: No functional changes

Depends on D8320

Reviewers: raster, cedric, zmike, bu5hm4n, stefan_schmidt

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8344
2019-03-15 08:57:09 -04:00
Cedric BAIL c5560bf2ef eo: efl_object_legacy_only_event_description_get is an internal only function, make it so.
Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8361
2019-03-15 11:54:24 +01:00
Marcel Hollerbach 72b866b8b2 efl_ui: fix headers
Summary:
the function parameters is a only beta, so this function should be beta.
Depends on D8341

Reviewers: zmike, segfaultxavi

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8342
2019-03-14 14:26:30 -04:00
Marcel Hollerbach 30bb8395c3 build: add a option to disable eo file installation
Summary:
this is done because .eo files are not stable, and in order to stop
people depending on it, its better for now to disable the installation
of them for now.

ref T7676

Reviewers: stefan_schmidt, cedric, zmike, devilhorns

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7676

Differential Revision: https://phab.enlightenment.org/D7897
2019-03-14 12:44:00 -04:00
Yeongjong Lee ba1c94d051 efl_ui_layout: fix elm_layout_text_set behavior
Summary:
Since commit 649433560b, elm_layout_text_set didn't work on some widgets.
This patch fixes invisible text issues.

Test Plan:
1. make check
2. elementary_test -to 'popup'

Reviewers: zmike, segfaultxavi, bu5hm4n

Reviewed By: zmike

Subscribers: cedric, #reviewers, herb, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8326
2019-03-14 11:11:32 -04:00
Christopher Michael 27095e859a efl_ui_grid: Fix dereferencing null pointer
Summary:
Coverity reports EFL_UI_GRID_ITEM_DATA_GET can return NULL (checked
273 out of 281 times). As such, we should verify that 'id' is not NULL
here before trying to dereference it.

Fixes Coverity CID1397000

@fix

Depends on D8318

Reviewers: raster, cedric, q66, zmike, bu5hm4n, stefan

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8319
2019-03-14 07:22:44 -04:00
Christopher Michael 881b72f40d efl_ui_datepicker: Fix uninitialized scalar value
Summary:
Coverity reports field t.tm_sec is unitialized when calling
efl_datetime_manager_value_set, so this patch uninitializes it to 0.

Fixes Coverity CID1397006

@fix

Reviewers: raster, cedric, q66, zmike, bu5hm4n, stefan

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8318
2019-03-14 07:22:26 -04:00
Yeongjong Lee c3f823418d ui.widget: fix theme_apply working in sub_object_add
It seems that theme_apply in sub_object_add haven't worked since commit
f6fa1ef612.

scale, theme property will be set properly when the parent is changed.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8283
2019-03-13 17:02:30 +01:00
Christopher Michael 8ef176ca53 efl_ui_stack: Fix dereference null return value
Coverity reports that efl_data_scope_safe_get returns NULL here (273
out of 281 times). _end_anim dereferences pd directly, so we should
check for a valid 'pd' before calling _end_anim function.

Fixes Coverity CID1399082

@fix

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8315
2019-03-13 16:55:10 +01:00
Christopher Michael 62d7d8a418 efl_ui_selection_manager: Fix unchecked return value
This patch fixes an issue where the return value from ecore_x_init is
not checked. If we fail to initialize ecore_x, then we should print
out an error and get out.

Fixes Coverity CID1399092

@fix

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8312
2019-03-13 16:55:08 +01:00
Yeongjong Lee c6e0a8cbc6 elm_conform: remove duplicated constructor call
It is duplicated in commit ccbc27f24d.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8303
2019-03-13 16:55:05 +01:00
Christopher Michael f60fef6f0f efl_ui_widget_common: Fix potential resource leak
Coverity reports that we potentially leak the storage of
'tree_iterator' here because we allocate the space for it, but
potentially juse return due to use of ELM_WIDGET_DATA_GET_OR_RETURN.
To fix this, just move the allocation to after the above macro is
called.

Fixes Coverity CID1399088

@fix

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8314
2019-03-13 11:51:59 +01:00
Christopher Michael 86cf4e5d7b elm_config: Fix unchecked return value
Small patch to check the return value of ecore_file_cp. Coverity
reports this as an unchecked return value, so let's just add a simple
check here.

Fixes Coverity CID1399101

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8309
2019-03-13 11:51:58 +01:00
Jaehyun Cho 98ca79e8ce Revert "efl_ui_layout: check part existence in text_set"
This reverts commit 649433560b.

This patch is reverted because this patch breaks the backward
compatibility.
Please check Popup in elementary_test.
2019-03-13 19:27:03 +09:00
Jaehyun Cho 6c00b54305 efl_ui_navigation_layout: fix bar value to be Efl.Ui.Layout_Base
Since Efl.Ui.Layout is renamed to Efl.Ui.Layout_Base, the bar value is
fixed to be Efl.Ui.Layout_Base.
2019-03-12 14:43:46 +09:00
Jaehyun Cho dbe5cd3ac8 Efl_Ui.h: move stack and navigation headers to Efl_Ui.h
The following efl ui headers move from Elementary.h to Efl_Ui.h.
efl_ui_navigation_bar.eo.h
efl_ui_navigation_bar_part.eo.h
efl_ui_navigation_bar_part_back_button.eo.h
efl_ui_navigation_layout.eo.h
efl_ui_stack.eo.h
2019-03-12 14:40:56 +09:00
Cedric BAIL 8d5fc26837 elementary: none of this call should have propagated any legacy call.
Summary:
Triggering legacy event call for non legacy event on a an object that is
also non legacy made little sense.

Reviewers: zmike, stefan_schmidt, segfaultxavi, bu5hm4n

Reviewed By: zmike, bu5hm4n

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7729

Differential Revision: https://phab.enlightenment.org/D8249
2019-03-11 17:52:39 -04:00
Marcel Hollerbach 991c2333ed efl_ui_focus_object: fixup properties that are used for event infos.
Summary:
those are the completly wrong properties, please be carefull with this.
There is a major difference between focus_geometry and geometry on the
entity. In a viewport for example its the viewport itself - the bars at
the side. Additionally, not every focus object is a efl.gfx.entity.

this fixes a giant amount of errors when you try to test terminology,
emixer, toolbar tests or something like this.

fixup 1d9fef8da6

Reviewers: cedric, segfaultxavi, zmike

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8300
2019-03-11 17:47:05 -04:00
Marcel Hollerbach aabe29abc1 Revert "ui.widget: fix theme_apply working in sub_object_add"
This only works with a new libcheck, but not with a old one, revisiting
it.

This reverts commit da0ff53471.
2019-03-11 21:57:45 +01:00
Mike Blumenkrantz ceb4c04d3b efl.ui.widget: disable parts{} block for now
the part is not stable, as the type is not stable. However, we lack the
support of declaring parts beta, so we just comment them out.
This can be reverted after the release.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8298
2019-03-11 21:35:06 +01:00
Mike Blumenkrantz 23d922a4ac efl_ui_focus_composition: get geometry from canvas object not adapter
the adapter has no geometry, so we must use the object from the adapter data

ref D8287

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8295
2019-03-11 21:35:03 +01:00
Mike Blumenkrantz ca8e0d6eb7 efl.ui.win: merge fullscreen+maximize events to use *,changed naming
ref T7511

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8294
2019-03-11 21:35:02 +01:00
Mike Blumenkrantz f7670ff5fd efl.ui.win: add event info to 'rotation,changed' event and rename
be consistent with property name and '*,changed' event info convention

ref T7511

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8293
2019-03-11 21:35:01 +01:00
Yeongjong Lee da0ff53471 ui.widget: fix theme_apply working in sub_object_add
It seems that theme_apply in sub_object_add haven't worked since commit
f6fa1ef612.

scale, theme property will be set properly when the parent is changed.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8283
2019-03-11 21:34:57 +01:00
Yeongjong Lee 0838c1af63 ui.widget: add exception handling code and unit test of sub_object_add/del function
Add missing exception check code with unit test.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8282
2019-03-11 21:23:51 +01:00
Marcel Hollerbach e2b63eae75 efl_ui_widget: mark some oversawn event as beta
this was overseen and should be refactored.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D8297
2019-03-11 21:23:50 +01:00
Mike Blumenkrantz 1d9fef8da6 efl.ui.focus.object: add geometry to focus_geometry,changed event
Summary: ref T7571

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl_api

Maniphest Tasks: T7571

Differential Revision: https://phab.enlightenment.org/D8287
2019-03-11 16:09:04 +01:00
Daniel Kolesa d3c5384cd0 eolian: enable checking of beta/stable contexts in all classes
Summary:
This enables all the checks unconditionally, without ignoring
classes that don't have an Efl namespace. This required a lot
of beta marking to make it build. It most likely doesn't
mark types correctly, as that is not fully enabled yet.

Reviewers: zmike, cedric, segfaultxavi, bu5hm4n

Reviewed By: segfaultxavi

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8266
2019-03-11 13:42:29 +01:00
Yeongjong Lee c043b11f46 ui.widget: enhance documentation of sub_object_add
Reviewers: segfaultxavi, bu5hm4n

Reviewed By: segfaultxavi, bu5hm4n

Subscribers: bu5hm4n, kimcinoo, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8281
2019-03-11 12:17:36 +01:00
Carsten Haitzler afe26b831d Revert "elementary,evas: remove obsolete legacy includes"
This reverts commit c876ac52d9.

This is not safe to remove - this breaks enlightenment. perhaps test
with the reason efl exists in the first place before delcaring it
safe? specifically this removed some function symbols in
efl_canvas_event_grabber_eo.legacy.c ...
2019-03-09 15:59:10 +00:00
Marcel Hollerbach 1c62ed5349 efl: ensure legacy is only relying on stable types
Summary:
This commit changes the beta ness of a few types, those types are
looking quite stable. Edje types will likely not change. The
Efl.Gfx.Join types are actaully already stable since the last release,
since evas_vg was stable back then and those enums have been in there.

The elementary stuff looks a bit unthought, and we have the chance to
change the API in the backend, so maybe we want to not declare it
stable, but rather reintroduce the legacy types.

With this we can enable eolian generation of beta tags for types.

ref T7726

Depends on D8276

Reviewers: cedric, segfaultxavi, zmike, stefan_schmidt, q66

Reviewed By: segfaultxavi, q66

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7726

Differential Revision: https://phab.enlightenment.org/D8277
2019-03-09 16:39:06 +01:00
Marcel Hollerbach f234a2b6c7 efl: mark types beta that have been missed before
Summary:
With this we can drop the getenv in eolian, and enable beta checking per
default.

ref T7584
Depends on D8274

Reviewers: segfaultxavi, cedric, q66, zmike

Reviewed By: segfaultxavi

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7584

Differential Revision: https://phab.enlightenment.org/D8275
2019-03-09 14:27:56 +01:00
Marcel Hollerbach 954cdb3656 efl: apply the stabilzed column of the efl api board
Summary:
The project https://phab.enlightenment.org/tag/efl_api/ has been used in
the last few weeks to figure out which classes can be stablized and
which cannot. This commit moves those dedicated classes outside beta.
And makes them stable.

ref T7601
ref T7600
ref T7599
ref T7598
ref T7597
ref T7596
ref T7594
ref T7593
ref T7591
ref T7590
ref T7589
ref T7588
ref T7583
ref T7582
ref T7581
ref T7576
ref T7570
ref T7567
ref T7564
ref T7563
ref T7560
ref T7559
ref T7672
ref T7584
ref T7577
ref T7571
ref T7558
ref T7555
ref T7554
ref T7553
ref T7512
ref T7511

Depends on D8272

Reviewers: cedric, stefan_schmidt, zmike, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7672, T7601, T7600, T7599, T7598, T7597, T7596, T7594, T7593, T7591, T7590, T7589, T7588, T7584, T7583, T7582, T7581, T7577, T7576, T7571, T7570, T7567, T7564, T7563, T7560, T7559, T7558, T7555, T7554, T7553, T7512, T7511

Differential Revision: https://phab.enlightenment.org/D8273
2019-03-09 13:49:36 +01:00
Marcel Hollerbach b94c62f5d4 efl_ui_focus_manager: move API into beta which is for debugging
Summary:
there is no sense to have this outside beta, noone should really use
this. It is only meant for debugging purposes.

ref T7726

Depends on D8271

Reviewers: segfaultxavi, cedric, zmike

Reviewed By: segfaultxavi

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7726

Differential Revision: https://phab.enlightenment.org/D8272
2019-03-09 13:40:56 +01:00
Marcel Hollerbach 02971039c4 efl_ui: repair a few docs
Summary:
ref T7726

Depends on D8270

Reviewers: segfaultxavi, cedric, zmike

Reviewed By: segfaultxavi

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7726

Differential Revision: https://phab.enlightenment.org/D8271
2019-03-09 13:39:31 +01:00
Marcel Hollerbach 2f85e78998 efl_ui_types: rename move_prolicy field
Summary:
in was not very descriptiv, move_in was concluded to be more descriptive

ref T7726

Reviewers: segfaultxavi, cedric, zmike

Reviewed By: segfaultxavi

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7726

Differential Revision: https://phab.enlightenment.org/D8270
2019-03-09 13:34:48 +01:00
Marcel Hollerbach a1addad60e efl_ui_widget: refactor sub_object handling
efl_ui_widget has a property called widget_parent. The setter for this
function is called is exactly once, and this is within the constructor,
to a value which is not even set to the actaul field parent_obj. Which
shows, that in the sitation right now, the setter of the property is a
bit disconnected and lags some real aspects.
As we are heading towards eo-api stabilization we should beat some sense
into this setter, as people using our classes might overwrite the setter
and except calls to it, whenever the widget_parent is changed, and
implementation as in elm_menu show that this might makes sense sometime.

In order to achive this, the sub_object registering code of elm is
adjusted a bit.
sub_object_add/del is now used to differenciate between evas objects and
efl.ui.widget objects as subobject. In case of a widget, the
widget_parent of this object is set, most of the widget specific code is
then executed in the actaul setter. In case of an evas object, the
parent reference is added. In the end both end up in the subobject
children list. The later is also a requirement for widget_parent_set to
be successfull.

ref T7553

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D8031
2019-03-09 11:12:26 +01:00
Marcel Hollerbach ccbc27f24d efl_ui_widget: remove widget_parent overwritting
before the widget_parent have been only set once. The call to the set
was in the constructor and carried the efl_parent. In the next commit
widget_parent is getting a refactor, which gives it more meaning, where
it is actaully called, which means, the behaviour will change. In order
to not break every existing usage of the here changed widgets, we move
the code to the constructor, and feed it with the efl_parent, just like
before.

Differential Revision: https://phab.enlightenment.org/D8041
2019-03-09 11:12:25 +01:00
Cedric BAIL bc12d9feb5 eo: make reflection getter const function.
Getter are usually not modifying there object. This is going to put a strong
limit on what a getter property for MVVM is, as it will prevent any side
effect on getting a property from a View.

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D7969
2019-03-08 14:31:08 -08:00
Cedric BAIL 6bb197caa9 efl: for consistency and effiency move Efl.Model event to send stringshare like Property_Bind event.
Reviewed-by: Vitor Sousa da Silva <vitorsousa@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D7946
2019-03-08 14:31:06 -08:00
Cedric BAIL 98e5a71974 efl: add an event for the View to know if someone did bound a property.
Reviewed-by: Vitor Sousa da Silva <vitorsousa@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D7945
2019-03-08 14:31:04 -08:00