Commit Graph

186 Commits

Author SHA1 Message Date
André Ribes 38c5254494 From: André Ribes <andre.ribes@gmail.com>
Hi all, this is a patch to use pkg-config for edje_cc path on ethumb. Is it ok
for you ?
Best regards,
André



SVN revision: 53846
2010-10-25 04:10:19 +00:00
Gustavo Sverzut Barbieri fe40b278d8 yeah, we know it is unstable ;-)
SVN revision: 52604
2010-09-22 21:30:15 +00:00
Chidambar Zinnoury 52b0c711a1 ethumb: missing initialization.
Thank you Lucas de Marchi :)


SVN revision: 52487
2010-09-20 12:10:30 +00:00
Chidambar Zinnoury 0f4ce94ecf ethumb: automagically orient thumbnails based on:
- metadata contained in files (EXIF only currently) - default active;
 - orientation given by the caller against pixel data orientation.
 Code is based on els_icon.

 Next is to add that through dbus.

 Open question: if orientation is specified, do we need to save the thumbnail in a different folder?


SVN revision: 52465
2010-09-19 17:07:35 +00:00
Rafael Antognolli 94540f3b5b Changing Ethumb license from LGPL3 to LGPL2.
Making this change to be in agreement with some other EFL libraries
under LGPL.



SVN revision: 52275
2010-09-14 23:02:45 +00:00
Eduardo de Barros Lima b5dc226bc1 Ethumb: make distcheck fixes
SVN revision: 51844
2010-09-02 20:12:08 +00:00
Lucas De Marchi 5a8a8c9014 Convert (hopefully) all comparisons to NULL
Apply badzero.cocci, badnull.coci and badnull2.cocci

This should convert all cases where there's a comparison to NULL to simpler
forms. This patch applies the following transformations:

code before patch               ||code after patch
===============================================================

return a == NULL;                 return !a;

return a != NULL;                 return !!a;

func(a == NULL);                  func(!a);

func(a != NULL);                  func(!!a);

b = a == NULL;                    b = !a;

b = a != NULL;                    b = !!a;

b = a == NULL ? c : d;            b = !a ? c : d;

b = a != NULL ? c : d;            b = a ? c : d;


other cases:

a == NULL                         !a
a != NULL                         a




SVN revision: 51487
2010-08-21 13:52:25 +00:00
Carsten Haitzler 13f65a2119 sync to 1.0.0 alpha
SVN revision: 51197
2010-08-16 10:29:57 +00:00
Eduardo de Barros Lima 168b0a7ed4 ethumb: set micro version
SVN revision: 51054
2010-08-12 18:07:23 +00:00
Gustavo Sverzut Barbieri 5882201502 ethumb: Invalid access upon ethumb_free
The sub-ecore_evas is automatically deleted by ecore_evas_object_image
object when it is deleted, so we were double-freeing it.

By: Brian Wang <brian.wang.0721@gmail.com>


SVN revision: 50265
2010-07-15 12:45:52 +00:00
Gustavo Sverzut Barbieri 675b20a859 ethumb: cleanup headers
This bug of including Ecore, Evas and Ecore_Evas from Ethumb.h was
actually expoed from recent evas-0/Evas.h change, as these were not
required in the public file, I'm removing them and just letting eina
as it is used to typedef Eina_Bool and function attributes.




SVN revision: 50160
2010-07-09 15:24:17 +00:00
Christopher Michael 6d4c38f97b Move Ethumb headers to own directory.
Fix trying to free an evas_object by using ecore_evas_free...spankies !!



SVN revision: 50152
2010-07-09 08:14:24 +00:00
Gustavo Sverzut Barbieri a2a0ab8d4c Fix memory alignment and remove dead/useless code.
* those write to stderr were legacy from development, some of them
   were even wrongly accessing out-of-buffer memory;

 * some platforms cannot access non-aligned memory, like integers that
   are not aligned to sizeof(int) and do on. Change the generated
   message using memcpy to aligned memory before using them. Add
   comment to explain that;



SVN revision: 50135
2010-07-08 22:37:04 +00:00
Lucas De Marchi 7c12cc36aa Fixes for Ecore Api changes
Patch automatically generated by Coccinelle to fix the
callbacks used by the following functions:

 * ecore_event_handler_add()
 * ecore_event_filter_add()
 * ecore_idler_add()
 * ecore_idle_enterer_add()
 * ecore_idle_enterer_before_add()
 * ecore_idle_exiter_add()
 * ecore_main_fd_handler_add()
 * ecore_main_win32_handler_add()
 * ecore_timer_add()
 * ecore_timer_loop_add()
 * ecore_animator_add()
 * ecore_poller_add()


SVN revision: 50113
2010-07-08 01:00:48 +00:00
Mike Blumenkrantz b3a4801b79 fix leak in free
SVN revision: 50009
2010-07-03 05:29:31 +00:00
Iván Briano b9d2cf0983 Fix nasty cenourette.
Also from Raphael Kubo, you can ask him what the commit message means (rakuco around the irc plane of existence)


SVN revision: 49976
2010-07-01 19:54:47 +00:00
Iván Briano 8e50bcb41b More from Raphael Kubo, register log domains
SVN revision: 49975
2010-07-01 19:48:54 +00:00
Iván Briano 01b6434842 From Raphael Kubo da Costa, fix callbacks to match Ecore changes
SVN revision: 49974
2010-07-01 19:42:12 +00:00
Carsten Haitzler 726b1ffb7f faster single frame gen
SVN revision: 49853
2010-06-25 08:21:22 +00:00
Iván Briano d57f9b09d6 Use edje_edit_object_add() or the edje_edit API won't work.
SVN revision: 48347
2010-04-26 19:46:15 +00:00
Iván Briano e01b2c7a5c Fix to changes in Edje_Edit
SVN revision: 47813
2010-04-07 17:06:07 +00:00
Gustavo Sverzut Barbieri 144e732a24 remove spurious \n for eina_log messages.
SVN revision: 46756
2010-03-02 00:39:37 +00:00
Gustavo Sverzut Barbieri 6a6ad0f603 silent rules, and disable c++/fortran/java checkers.
SVN revision: 46754
2010-03-02 00:36:41 +00:00
Gustavo Sverzut Barbieri 9345b211b0 fix llvm/clang and gcc errors.
NOTE: mixing write() and fprintf() to the same descriptor (stderr,
      done by ERR()), will likely cause problems :-/



SVN revision: 46753
2010-03-02 00:34:40 +00:00
Gustavo Sverzut Barbieri 23f96d5d33 All packages should have README...
SVN revision: 46138
2010-02-13 13:28:32 +00:00
Luis Felipe Strano Moraes c33a7982ed fix build of ethumbd client.
SVN revision: 46093
2010-02-11 21:05:31 +00:00
Luis Felipe Strano Moraes b9ef31f902 Add missing CFLAGS for ethumb.
SVN revision: 45991
2010-02-08 20:26:45 +00:00
Daniel Kolesa e7e2fb4bc5 Using autoreconf in autogen in ethumb is bad. With it, libtool m4 stuff is included inside dist tarball and we dont want that.
SVN revision: 45360
2010-01-20 19:13:22 +00:00
Daniel Kolesa f1ce8c20c5 Revert xcomp's commit. It is already there. Bad xcomputerman! :D
SVN revision: 45333
2010-01-19 17:27:39 +00:00
xcomputerman 38d5b876b0 Forgets to install ethumb_client.pc
SVN revision: 45316
2010-01-19 02:58:25 +00:00
Sebastian Dransfeld a82e7511aa make clang happy
SVN revision: 45197
2010-01-15 20:51:01 +00:00
Jorge Luis Zapata Muga f3fb3dea17 + [Eina] API change. eina_module_list_flush() -> eina_module_list_free()
as we are on the modules context not the array.
  All the referenced projects are changed too. Remember that the list_free()
  already calls the unload() on each module so no need to call list_unload()



SVN revision: 44978
2010-01-08 12:22:23 +00:00
Cedric BAIL 8bc6ac86fb * ethumb: Cleanup dependency.
SVN revision: 44626
2009-12-21 13:27:09 +00:00
Rafael Antognolli 6cbcfd262f ethumb: now using ecore_exe to start the slave.
SVN revision: 44092
2009-12-01 13:34:09 +00:00
Jonathan Atton 3cadaace4f Ethumb: test if unique_name is not null, If I kill the daemon right after it is started, I have a segv. This patch fix it.
SVN revision: 43971
2009-11-25 12:43:27 +00:00
Rafael Antognolli 2897458356 Add some more video extensions to ethumb emotion plugin.
Patch by: João Paulo Rechi Vita.



SVN revision: 43621
2009-11-11 19:06:52 +00:00
Rafael Antognolli 44f0e80046 Add logging to ethumb emotion plugin.
Some debug logging info to ethumb emotion plugin.



SVN revision: 43620
2009-11-11 19:03:25 +00:00
Carsten Haitzler 5e5ee2eca2 note about distcheck b0rken
SVN revision: 43570
2009-11-09 10:22:08 +00:00
Carsten Haitzler fd34cb43ab fix build after vtorri broke it! :)
SVN revision: 43569
2009-11-09 10:21:38 +00:00
Vincent Torri d4d1a53181 * fix order of libraries during link (fix windows compilation)
* paths based on $prefix are not set at configure time. The correct
   way is to use them in Makefile.am.
 * $themesdir and $sysconfdir does not seem to be used


SVN revision: 43567
2009-11-09 05:41:41 +00:00
Vincent Torri 2198c8a70a don't free stack variable
SVN revision: 43566
2009-11-09 05:27:35 +00:00
Vincent Torri 3df447d570 orget to commit configure.ac
SVN revision: 43507
2009-11-07 05:23:47 +00:00
Rafael Antognolli 755a5f7da6 Make ethumb match case-insensitive.
Ethumb wasn't matching files to plugins if the extension were not
composed of all lowercase chars. This patch makes the ethumb match
case-insensitive.

Patch by: João Paulo Rechi Vita



SVN revision: 43502
2009-11-06 22:17:55 +00:00
Vincent Torri 880ad8484d fix comment
SVN revision: 43496
2009-11-06 18:31:53 +00:00
Vincent Torri 4d7149ffb1 fix DLL creation on Windows
SVN revision: 43495
2009-11-06 18:27:56 +00:00
Vincent Torri f65022c077 useless includes
SVN revision: 43493
2009-11-06 18:12:37 +00:00
Vincent Torri 98e97e39bd fix comment
SVN revision: 43492
2009-11-06 18:11:55 +00:00
Vincent Torri a0dc963b1a fix library compilation on Windows (it should be cleaned, though)
There is still a problem with the binary, because of ecore_getopt


SVN revision: 43402
2009-11-01 21:55:15 +00:00
Rafael Antognolli 0db1dc430b Fix ethumb_calculate_fill_from_ratio().
Default values should be assigned to the return variables even if the
aspect ratio is 0.



SVN revision: 43352
2009-10-30 14:30:15 +00:00
João Paulo Rechi Vita d0155d87ee The "generated" D-Bus signal is published with an int64 as it first
parameter but an int32 is sent instead.

Patch by: João Paulo Rechi Vita <jprvita@profusion.mobi>

--This lina, and those below, will be ignored--

M    ethumb/src/bin/ethumbd.c


SVN revision: 43160
2009-10-19 14:05:54 +00:00
João Paulo Rechi Vita 2b93b55313 Sending an empty byte array to Ethumbd through the D-Bus API was
leading to a segfault.

Patch by: João Paulo Rechi Vita <jprvita@profusion.mobi>



SVN revision: 43159
2009-10-19 14:04:43 +00:00
Carsten Haitzler 1ad41f8bca install is auto-generated by autofoo.
SVN revision: 42811
2009-09-30 02:34:42 +00:00
Gustavo Sverzut Barbieri 131be821c8 oops! strncpy is tricky and uri was a pointer not an array.
people were not noticing it as they were using 64 bits machines... but
with 32 bits just 4 bytes were copied and 3 were missing :-P



SVN revision: 42549
2009-09-17 18:37:22 +00:00
Gustavo Sverzut Barbieri acc688873b logging: remove trailing \n
SVN revision: 42546
2009-09-17 14:31:29 +00:00
Gustavo Sverzut Barbieri bea73e88bd Ethumb improvements and more docs.
make some types unsigned int to better represent what they will
contain, fix dbus api to match so.



SVN revision: 42545
2009-09-17 14:05:04 +00:00
Gustavo Sverzut Barbieri bf4e52869b configure summary, maximum log level and other improvements.
Have all source to include config.h conditionally (HAVE_CONFIG_H),
define EINA_LOG_LEVEL_MAXIMUM, minor changes to configure.ac to make
it conform with the rest of efl.



SVN revision: 42544
2009-09-17 12:04:35 +00:00
Gustavo Sverzut Barbieri 1573ce03ca todo...
SVN revision: 42542
2009-09-17 06:19:01 +00:00
Gustavo Sverzut Barbieri 4be6ac7921 enable "make doc", improve doxygen support for client library.
Some methods are missing and the in-process thumbnail needs to be
done, the documentation is almost the same as the client, so I really
appreciate someone else do it :-)



SVN revision: 42541
2009-09-17 06:08:10 +00:00
Gustavo Sverzut Barbieri 5dc1e3900f more docs
SVN revision: 42538
2009-09-17 05:17:12 +00:00
Gustavo Sverzut Barbieri 56d5c74815 done items
SVN revision: 42449
2009-09-12 18:29:46 +00:00
Gustavo Sverzut Barbieri 97645fe7bc API BREAK: Fix Ethumb API to be more EFL-like
* Callbacks were named to help Vala bindings.
 * All callbacks get 'void *data' as first argument, always.
 * All async methods get free_data parameters and call them also on disconnect()
 * queue_remove() renamed to generate_cancel() to be more clear.
 * queue_clear() renamed tp generate_cancel_call() to be more clear.



SVN revision: 42445
2009-09-12 18:23:05 +00:00
Gustavo Sverzut Barbieri 992936af22 Update to match new EINA init/shutdown.
SVN revision: 42301
2009-09-06 22:23:04 +00:00
Gustavo Sverzut Barbieri e229b25826 loggify ethumb.
remove debug_level options as it is better handled by EINA_LOG_LEVELS
and EINA_LOG_LEVEL variables, for example:

  EINA_LOG_LEVEL=3 EINA_LOG_LEVELS=ethumb:4,ethumb_client=1

will show debug for ethumb (lib), just errors (no warnings) for
ethumb_client library and everything else shows "info".



SVN revision: 42261
2009-09-04 19:27:12 +00:00
xcomputerman 1f24df9c39 Update EINA_ERROR_LEVEL* to EINA_LOG_LEVEL* to allow building again
SVN revision: 42255
2009-09-04 18:04:00 +00:00
Daniel Kolesa 26bd9e8d46 Fixed generation of dist tarball in ethumb.
SVN revision: 41576
2009-08-04 07:34:52 +00:00
Daniel Kolesa 1ef8e96d05 Add data/images/border-0.jpg in ethumb to EXTRA_DIST so it will be included when creating tarballs.
SVN revision: 41462
2009-07-21 06:01:57 +00:00
Daniel Kolesa b58ac165cf Fix build of ethumb on some machines..
SVN revision: 41457
2009-07-20 15:20:25 +00:00
Gustavo Sverzut Barbieri 37d5bd6ead add item to fix callback type names and remove done items.
SVN revision: 41402
2009-07-17 15:33:49 +00:00
Gustavo Sverzut Barbieri 980d778e39 ethumbd_client.
do the same as ethumb, but uses ethumbd for doing it. Yet another
sample on ethumb usage.



SVN revision: 41401
2009-07-17 15:29:44 +00:00
Gustavo Sverzut Barbieri 7acfd6d648 fix theme/frame parsing to not leak and be simpler.
we don't need to allocate memory, copy, modify and free (free was
missing!), we can just give stringshare the length to use.



SVN revision: 41398
2009-07-17 14:48:03 +00:00
Gustavo Sverzut Barbieri 6aa85b1cf9 indent.
SVN revision: 41397
2009-07-17 14:44:11 +00:00
Gustavo Sverzut Barbieri df0ea7a123 public header files should include global headers, not local.
SVN revision: 41395
2009-07-17 14:27:17 +00:00
Gustavo Sverzut Barbieri 386972f2f0 match API rename, it's module flush now.
SVN revision: 41394
2009-07-17 14:24:08 +00:00
Rafael Antognolli ffe70c5e07 Fix some memory handling issues:
* Ethumb_Client now calls free_data on clear() and queue_remove().
* disconnect() doesn't call clear() anymore.
* disconnect() free pending calls correctly.



SVN revision: 41377
2009-07-17 04:28:41 +00:00
Gustavo Sverzut Barbieri 658d39dac8 emotion supports mov, make template edje more efficient.
* add .mov as supported extension.
 * disable mouse events and smooth scale, hint scale as dynamic.



SVN revision: 41375
2009-07-16 23:13:16 +00:00
Gustavo Sverzut Barbieri ebcc27e426 improve tool usage.
-Q, -V, -D: change debug levels, always forget about EINA_ERROR_LEVEL :-P

 print message with status, if it failed, was generated or already exists.



SVN revision: 41374
2009-07-16 22:55:05 +00:00
Gustavo Sverzut Barbieri 2d2dfb7485 improve debug support on module loading.
SVN revision: 41373
2009-07-16 22:53:38 +00:00
Gustavo Sverzut Barbieri 51e81f52ef fix symbol visibility in plugins.
ethumb_plugin_get() must be visible, _module_init/shutdown do not.

also add some __UNUSED__ attribute to shut up -Wextra



SVN revision: 41372
2009-07-16 22:13:36 +00:00
Gustavo Sverzut Barbieri b803f43e91 Export EAPI otherwise plugins will not get symbols.
SVN revision: 41371
2009-07-16 22:06:40 +00:00
Gustavo Sverzut Barbieri 473f5ea563 remove -Wextra warnings.
SVN revision: 41370
2009-07-16 21:49:14 +00:00
Gustavo Sverzut Barbieri 2051b9b76c svn:ignore + TODO
SVN revision: 41348
2009-07-15 05:02:37 +00:00
Gustavo Sverzut Barbieri c6b4e69225 zero pointers before failing.
SVN revision: 41347
2009-07-15 04:44:15 +00:00
Rafael Antognolli 0e694f4e18 Fix ethumb file URI generation.
It's now escaping invalid chars to its hex representation.



SVN revision: 41345
2009-07-15 04:18:05 +00:00
Rafael Antognolli 26a3abe8ef Making ethumb_client_connect always call the connected_cb.
Now the callback is called even when it fails to create a get_name_owner
request.



SVN revision: 41323
2009-07-13 22:08:00 +00:00
Rafael Antognolli 31fc2b0dfa Added support to creating animated thumbnails from videos.
These thumbnails are generated using an edje template. Each thumbnail is
an edje file, that has a group called "movie/thumb"
The thumbnail can be animated by receiving a signal "animate" or "animate_loop"
(the last one being a loop animation that calls itself when finished), and
the animate_loop program can be stopped by receiving a signal "animate_stop".
The transition time is set based on the time of the animation (that is set
by the call ethumb_video_time_set()).



SVN revision: 41322
2009-07-13 19:38:17 +00:00
Rafael Antognolli 2dd7e38b96 Changing boolean flags to Eina_Bool.
SVN revision: 41321
2009-07-13 19:24:20 +00:00
Rafael Antognolli 8106bf6d44 Added ETHUMB_THUMB_EET as a format flag.
SVN revision: 41289
2009-07-09 19:47:51 +00:00
Rafael Antognolli 6a060751f8 Providing more API to plugins.
- Now it's possible to access the ecore_evas used to generate the
thumbnails (and use functions like ecore_evas_buffer_pixels_get() ont it);
- Functions to calculate aspect and fill area using the aspect ratio as
argument are also provided.



SVN revision: 41288
2009-07-09 19:42:18 +00:00
Rafael Antognolli 116c7d3266 Fixed wrong usage of dbus.
This was also the problem causing ethumb generated callback on the client
library always return with success=1 (see ticket #337).



SVN revision: 41287
2009-07-09 19:26:16 +00:00
Rafael Antognolli f9b765ec1c Added support to set quality and compress level.
SVN revision: 41286
2009-07-09 19:16:02 +00:00
Rafael Antognolli 5dc0fa41ef Added support to free_data callbacks.
Some functions that require callbacks and data passed to them now can
receive a free_data callback as argument too.



SVN revision: 41285
2009-07-09 19:14:29 +00:00
Rafael Antognolli 8f9dc79021 Fixed wrong usage of eina_list_remove_list on Ethumb_Client.
SVN revision: 41284
2009-07-09 19:11:57 +00:00
Viktor Kojouharov fca7b4aa43 return -1 on error instead
SVN revision: 40971
2009-06-08 15:44:43 +00:00
Viktor Kojouharov 06437b0e33 make the generated callback receive the thumb path and key
SVN revision: 40969
2009-06-08 15:29:52 +00:00
Gustavo Sverzut Barbieri b7d1bed838 start service by name requires one more parameter (flags).
The dbus api has a "flags" parameter that is now unused but may be in
future, it was missing and dbus was giving method mismatch.

I forgot to commit this but changed Ethumb_Client, then Viktor "fixed"
it by reverting such change. Now going back to my code and adding "0"
as flag.



SVN revision: 40968
2009-06-08 14:32:17 +00:00
Viktor Kojouharov e5ca756ffe fix the use of e_dbus_start_service_by_name
prevent id_count from being 0


SVN revision: 40963
2009-06-08 08:47:56 +00:00
Gustavo Sverzut Barbieri 19ebe43a04 start dbus service by its name if it's not up.
we still guess it was up and try to get its name, if not possible then
try to start it and then get is name.

another way to do it would be to always request start and just then
get its name and just then start to listen to NameOwnerChanged. But
the current way is good enough and should save some roundtrips for
good cases (server is up).



SVN revision: 40955
2009-06-07 21:20:37 +00:00
Gustavo Sverzut Barbieri 76d4b16942 move bit flags to end, use bitfield.
SVN revision: 40954
2009-06-07 20:47:28 +00:00
Rafael Antognolli aac69a080f Added ethumbd (ethumb).
ethumbd is a server waiting for requests of thumbnails via dbus. A client
library is also provided, avoiding dbus burocracy (and with an API similar
to ethumb).



SVN revision: 40899
2009-06-04 21:21:43 +00:00
Rafael Antognolli 4229b4654b Fixed segfault when no file is passed as argument to ethumb.
Other minor fixes:
 - fixed use fo eina safety checks;
 - _ethumb_build_absolute_path is used inside dir_set.



SVN revision: 40840
2009-05-26 20:33:58 +00:00