Without any locking or thread-safe mechanism, the previous implementation
would have failed as soon as too many file_set() happened on the same
object. Indeed, file_set() can happen while the async open thread is
running. I shouldn't have blindly listened to Cedric :P
Summary:
Issue: Mirroring of elm_panel not working correctly.
Solution: Handle mirroring appropriately for animations.
@fix
Test Plan:
Case: 1
1. Open elementary_test
2. Mirror on
3. Open scrollable panel, click on toggle button.
Case: 2
1. Keep the scroller panel opened
2. Turn off Mirror
Case: 3
1. Turn on mirror
2. Check direction button in non-scrollable panel.
Reviewers: shilpasingh, raster, Hermet, Princekrdubey
Reviewed By: shilpasingh
Subscribers: poornima.srinivasan, subodh6129
Differential Revision: https://phab.enlightenment.org/D2237
Summary:
Some APIs need to return specific values for their usage.
For Examples, elm_xx_select_mode_get function need to return
ELM_OBJECT_SELECT_MODE_MAX when invalid input comes.
**Fixed API list :**
elm_list_mode_get
elm_list_multi_select_mode_get
elm_genlist_mode_get
elm_genlist_select_mode_get
elm_genlist_multi_select_mode_get
elm_genlist_item_type_get
elm_genlist_ttem_index_get
elm_genlist_item_select_mode_get
elm_gengrid_select_mode_get
elm_gengrid_multi_select_mode_get
elm_gengrid_item_index_get
Test Plan: Call API with NULL parameter and check return value.
Reviewers: Hermet, seoz, jaehwan, raster, eunue
Subscribers: id213sin
Differential Revision: https://phab.enlightenment.org/D2306
Since the latest elm colorclass changes we need eldbus-codegen to generate
some files. Not all setups have this in their normal $PATH so let allow these
setups to set the correct path during configure. This allows our Jenkins setup
as well as others to work again.
why have elm image repeat events always (and unable to stop it)? this
is neither useful nor convenient. it's just painful. it makes images
not behave like prety much every object. they already are set up to
capture events - then do it normally.
@fix
This will allow apps to set the proper viewport, even if the
actual surface geometry didn't change.
This fixes a rare situation where the mode is changed from indirect
to direct (eg. in elm_test glview).
This commit enables generic broadcasting of changes in widget hierarcies.
Previously this kind of broadcasting had to be implemented inside widget.
This solution is using elm_widget sub_obj_add/sub_obj_del functions.
elm_interface_atspi_widget object was previously used to implement
atspi features on top of elm_widget object. However such inheritance
obfuscates a design, so atspi features implementation was moved directly
into elm_widget code.
Summary:
When object in elm_win lose their focus, elm_win save it on focus_highlight.prev structure,
and add **EVAS_CALLBACK_DEL** event callback. But after changed focus object also lose their focus from other,
**EVAS_CALLBACK_DEL** on prev object is not deleted if their in_theme is not **EINA_TRUE**.
This could be cause **'Memory Leak' **until previous focused objects are deleting.
checking in_theme of prev focus_highlight is for send signal on prev focused view(edje),
so 'if' sentence for checking previous existance and in_theme need to be separated.
@fix
Test Plan:
You can easily check this on elementary_test. launch radio sample and make focus by keyboard and
change focus repeatly, callback is added as per focus movement, but callback del is not called.
Reviewers: seoz, woohyun, raster, Hermet
Reviewed By: Hermet
Subscribers: jaehwan
Differential Revision: https://phab.enlightenment.org/D2276
Summary: I missed this during btn object type change to layout from edje object .
Reviewers: Hermet, seoz, woohyun
Differential Revision: https://phab.enlightenment.org/D2289
NO! this breaks compiling anything against elementary UNLESS you
enable eo beta api support. NO NO NO NO.
This reverts commit cad6de2a8ef93d994f9dedb8e980efe5fbf6d77e.
Summary:
Added to Entry new signal "validate", this signal called from entry every
time when the text inputed to entry.
The regex validation add as elm_helper.
The styles of Entries scrollers are changed to allow highlightion that
is needed by regex processing.
For use regex with entry need register the regex helper as callback
to event: ELM_ENTRY_EVENT_VALIDATE
@feature
Test Plan:
See elementary_test "Entry Regex" test.
Note: when the string matches to regex the highlighting (green) is reset on unfocusing.
Reviewers: herdsman, raster, cedric, tasn
Reviewed By: cedric, tasn
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D2043
Summary: Adding a get API because of having only elm_object_access_info_get().
Reviewers: jaehwan, kimcinoo
Differential Revision: https://phab.enlightenment.org/D2271
This commit is related to 260cdd6150d567fcee8d1afaf690e4b90cd16a2b.
When unrealized item is focused, edje object is not exist,
so genlist cannot read the focus highlight information from edje object.
Therefore, when the item is realized, check the item is focused or not and
need to update focus highlight.
Summary:
A pointer to the internal Elm_Naviframe_Item_Data was mistakenly being passed as
event_info.
This patch changes the callback_call to pass the correct Elm_Object_Item (Eo) pointer.
Reviewers: #elementary, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2222
Summary: Add long pressed callback for application. test code changed to following this change as well.
@feature
Reviewers: seoz, woohyun, Jaehyun, Hermet
Differential Revision: https://phab.enlightenment.org/D2103
Conflicts:
src/lib/elc_multibuttonentry.c
Summary:
If elm_object_text_set() function is called twice,
elm_obj_containter_content_set(CONTENT_PART, sd->text_content_obj)
function makes sd->text_content_obj null since sd->text_content_obj already exists.
Test Plan:
1. run elementary_test(popup) and excute "popup-center-text + 1button (check hide, show)"
2. print sd->text_content_obj value in content_text_set()
3. push hide button and excute the example again
4. check sd->text_content_obj value if null or not
Reviewers: woohyun, Hermet, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D2225
Summary:
In case of the toolbar item size is fixed, the size of toolbar item became finger size.
so, after signal emission in _inform_item_number(),
edje_object_size_min_restricted_calc() and evas_object_size_hint_min_set() function are added.
Test Plan: change edc for supporting fixed toolbar item and run examples of toolbar in elementary_test
Reviewers: woohyun, seoz, Hermet, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D2184
Summary:
namespacing is wrong for tooltip label. Although we still support old theme
but it should be removed in EFL 2.0.
Test Plan: elementary_test -to tooltip
Reviewers: seoz, Hermet, raster
Reviewed By: raster
Subscribers: kimcinoo, sachin.dev, seoz
Differential Revision: https://phab.enlightenment.org/D2120
Summary:
Some app like calendar, they heavily depend on the value of datetime,so to ensure accuracy
second field is considered while comparing datetime values.
@fix
Test Plan: NA
Reviewers: shilpasingh, raster
Reviewed By: shilpasingh, raster
Subscribers: poornima.srinivasan, govi, rajeshps
Differential Revision: https://phab.enlightenment.org/D2204
Summary:
In POSIX, some format include extra character like dash, hash, etc, which gives unexpected behaviour.
Fix to filter out those character.
Signed Off By: Seongjun Yim <se201.yim@samsung.com>
Signed Off By: Subodh Kumar <s7158.kumar@samsung.com>
@fix
Test Plan:
1. Set datetime as POSIX locale.
2. Check the datetime behaviour in elementary_test.
Reviewers: raster, shilpasingh
Reviewed By: shilpasingh
Subscribers: poornima.srinivasan, govi, rajeshps
Differential Revision: https://phab.enlightenment.org/D2203
Summary:
Datetime value should be compared earlier to avoid unnecessary code execution.
Also added logic for single field comparion which will avoid to compare all fields when field limit is set.
Signed Off By: Seongjun Yim <se201.yim@samsung.com>
Signed Off By: Hyunseok Yang <hs0219.yang@samsung.com>
Signed Off By: Subodh Kumar <s7158.kumar@samsung.com>
Test Plan: NA
Reviewers: shilpasingh, raster
Reviewed By: shilpasingh, raster
Subscribers: poornima.srinivasan, govi, rajeshps
Differential Revision: https://phab.enlightenment.org/D2202
This feature works the infinite loop horizontally or vertically.
If the content is set, it will be shown repeatedly.
@feature
Change-Id: I1f20b794ae44bc8e5d120901222c7cccadca96b7
Conflicts:
src/lib/elm_scroller.c
src/lib/elm_scroller_legacy.h
"file" property in Efl.File interface is virtual pure,
so according to OO principles must be implemented in derived classes.
This patch adds implementation of "file.get" in Elm_Layout.
Further, Elm_Video class has it's own implementation of "file.set",
thus also requires implementation of "file.get"
Summary:
There is a bug that popup can't get proper size when list is set as its content.
Because of unneccesary calling evas_object_show() in popup's overriding elm_obj_container_content_set(),
sizing eval doens't work correctly.
This patch fixes this bug.
Test Plan:
Execute 14th popup sample in "elementary_test popup".
(popup-center-title + list content + 1 button)
After applying this patch, popup shows correctly.
Reviewers: seoz, Hermet
Reviewed By: Hermet
Subscribers: Hermet, seoz
Differential Revision: https://phab.enlightenment.org/D2158
Summary:
Call evas_font_reinit() API before applying font overlays when config is fully reloaded.
Application could modify or add font config "*.conf" files.
And It should affects all of other running EFL application.
So, put evas_font_reinit() API to be called when x win property is changed.
@feature
Reviewers: cedric, raster, tasn, woohyun
Differential Revision: https://phab.enlightenment.org/D2113
Summary:
Setting focus to entry object when text is being selected
@fix
Test Plan:
1. open "elementary_test entry3"
2. click on the big entry
3. mouse down on singleline entry to start selection
4. move mouse out of window
5. mouse up. text in that entry seems to be selected
6. press del or type any text
expected result: selected text in singleline entry is deleted/replaced
result without this patch: singleline entry is not focused and all edit actions are affecting the big one
Reviewers: cedric, Hermet, seoz
Subscribers: poornima.srinivasan, subodh6129, raster, reutskiy.v.v, herdsman
Differential Revision: https://phab.enlightenment.org/D1476
This reverts commit 841fcdfb18a414a7381910bcbb0b0ef4807bc5c2.
It's been too much passed.
we have more dependencies to the change (ie, key bindings)
so conclude to have the abi break in this case.
Summary:
The strcmp(line 738) has been failed since the eo applied.
the widget type get API returned "Elm_Genlist" now.
For fix it, using eo_isa() to check object types instead of string comparison.
@fix
Reviewers: seoz, woohyun, JackDanielZ, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2148
Summary: If _elm_image_object_size_get fails, w and h have garbage value.
Test Plan: no
Reviewers: seoz, Hermet, cedric, raster
Differential Revision: https://phab.enlightenment.org/D2163
The problem occurs when no drop target below the mouse can receive the
data type provided and the mouse button is released. The mouse pointer
stays grabbed and this leads to issues for the next drags.
To solve this, on a bad drop, the destination window has to request
from the source window the end of the dnd.
Jean-Philippe Andre
kumar navneet
SangHyeon Lee
woochan lee
Carsten Haitzler
Jaeun Choi
Stefan Schmidt
Mike Blumenkrantz
Lukasz Stanislawski
Lukasz Stanislawski
ChunEon Park
Boris Faure
Cedric BAIL
Tom Hacohen
Vyacheslav Reutskiy
JinsolPark
Jaehwan Kim
Kai Huuhko
michelle legrand
taehyub
Amitesh Singh
Subodh Kumar
Yakov Goldberg
WooHyun Jung
Jee-Yong Um
Youngbok Shin
Andrii Kroitor
Daniel Juyung Seo
Hosang Kim
Daniel Zaoui