Commit Graph

8489 Commits

Author SHA1 Message Date
woochan lee 0cfbc39b67 multibuttonentry: btn item theme set API change.
Summary: I missed this during btn object type change to layout from edje object .

Reviewers: Hermet, seoz, woohyun

Differential Revision: https://phab.enlightenment.org/D2289
2015-04-06 10:21:48 +09:00
Mike Blumenkrantz e0f7e8f7c4 gitignore update 2015-04-05 16:26:22 -04:00
Mike Blumenkrantz 2b03eb5a09 colorclass: add util function for listing color classes out of an open edje file 2015-04-05 16:26:22 -04:00
Mike Blumenkrantz 84b68085c3 colorclass: add subsystem for remotely editing colorclasses over dbus
the winid should match the e_pixmap id

also various theme improvements
2015-04-05 16:26:18 -04:00
Mike Blumenkrantz a583013bab add colorclass editor
the colorclass editor can be used to live edit the color classes in
any running application.

@feature
2015-04-05 16:02:00 -04:00
Mike Blumenkrantz 38ef781083 config: use eina_streq to optimize comparisons in _elm_config_color_overlay functions 2015-04-05 16:01:57 -04:00
Mike Blumenkrantz 6d33a125c4 colorselector: support "changed,user" smart callback
this allows users to avoid getting callbacks from api calls
2015-04-05 16:01:50 -04:00
Boris Faure c50ab5755c elc_popup: make sure code is C89 strict 2015-04-04 18:21:12 +02:00
Cedric BAIL df4c3bbb7d evas: let's not use eo_do for potential Efl interface call. 2015-04-03 16:04:58 +02:00
Tom Hacohen 6d2699317e Elm helper: fix compilation against elementary.
There was an issue when compiling against elementary when EO_BETA_API
wasn't set. This commit fixes that.

Thanks to Kuuko for reporting.
2015-04-02 10:54:06 +01:00
Tom Hacohen 82a43998cb Revert "Revert "Elm helper: add the posix regex validator.""
Reapply the patch. Next commit will fix the break.

This reverts commit 6f8be78ca04125f220c339145d700fc2e1a1f9c1.
2015-04-02 10:37:37 +01:00
Carsten Haitzler 71dc4b5392 Revert "Elm helper: add the posix regex validator."
NO! this breaks compiling anything against elementary UNLESS you
enable eo beta api support. NO NO NO NO.

This reverts commit cad6de2a8ef93d994f9dedb8e980efe5fbf6d77e.
2015-04-02 09:48:29 +09:00
Vyacheslav Reutskiy 4c041aee9a Elm helper: add the posix regex validator.
Summary:
Added to Entry new signal "validate", this signal called from entry every
time when the text inputed to entry.
The regex validation add as elm_helper.
The styles of Entries scrollers are changed to allow highlightion that
is needed by regex processing.

For use regex with entry need register the regex helper as callback
to event: ELM_ENTRY_EVENT_VALIDATE

@feature

Test Plan:
See elementary_test "Entry Regex" test.
Note: when the string matches to regex the highlighting (green) is reset on unfocusing.

Reviewers: herdsman, raster, cedric, tasn

Reviewed By: cedric, tasn

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D2043
2015-04-01 16:11:18 +01:00
JinsolPark 2573e7a9ea elm_object_access_info_get() API add
Summary: Adding a get API because of having only elm_object_access_info_get().

Reviewers: jaehwan, kimcinoo

Differential Revision: https://phab.enlightenment.org/D2271
2015-04-01 17:05:17 +09:00
Jaehwan Kim 29385e75ff Gengrid: Modified to handle the focus highlight on unrealized items
This commit is related to 260cdd6150d567fcee8d1afaf690e4b90cd16a2b.

When unrealized item is focused, edje object is not exist,
so genlist cannot read the focus highlight information from edje object.
Therefore, when the item is realized, check the item is focused or not and
need to update focus highlight.
2015-03-30 16:00:01 +09:00
ChunEon Park 856bf8c0df conform: decide indicator visibility in the swallow part. 2015-03-28 20:06:19 +09:00
ChunEon Park c17ea7197e conform: decide indicator visibility in the swallow part. 2015-03-28 19:18:24 +09:00
Kai Huuhko ff3ac49cf3 Fix elm_naviframe transition,finished smart events event_info
Summary:
A pointer to the internal Elm_Naviframe_Item_Data was mistakenly being passed as
event_info.

This patch changes the callback_call to pass the correct Elm_Object_Item (Eo) pointer.

Reviewers: #elementary, Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D2222
2015-03-28 15:12:37 +09:00
woochan lee 93a4b8b4e3 multibuttonentry: Add item long pressed callback.
Summary: Add long pressed callback for application. test code changed to following this change as well.

@feature

Reviewers: seoz, woohyun, Jaehyun, Hermet

Differential Revision: https://phab.enlightenment.org/D2103

Conflicts:

	src/lib/elc_multibuttonentry.c
2015-03-28 15:09:27 +09:00
michelle legrand 65bb320c00 elm_diskselector: check if sd variable is null.
Summary:
This causes a segmentation fault when closing the DiskSelector window
on Windows.

@fix

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-03-26 18:13:27 +01:00
michelle legrand ce9498311a elm_prefs: compatibility for Windows.
Summary:
Add test for relative path on Windows

@fix

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-03-26 18:08:54 +01:00
michelle legrand 8d4a6bfc81 elm_datetime: compatibility for Windows.
Summary:
For Windows, we have a nl_langinfo() equivalent in Evil.

@fix

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-03-26 18:08:15 +01:00
michelle legrand 6f86fb5fb0 elc_fileselector: fix looking for right Windows home path.
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-03-26 18:04:38 +01:00
taehyub d48b15b2fd elc_popup: add null pointer check before creating content text object
Summary:
If elm_object_text_set() function is called twice,
elm_obj_containter_content_set(CONTENT_PART, sd->text_content_obj)
function makes sd->text_content_obj null since sd->text_content_obj already exists.

Test Plan:
1. run elementary_test(popup) and excute "popup-center-text + 1button (check hide, show)"
2. print sd->text_content_obj value in content_text_set()
3. push hide button and excute the example again
4. check sd->text_content_obj value if null or not

Reviewers: woohyun, Hermet, raster

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D2225
2015-03-26 03:02:15 +09:00
taehyub c361c9e839 elm_toolbar: add toolbar item size calculation and setting min values for fixed items
Summary:
In case of the toolbar item size is fixed, the size of toolbar item became finger size.
so, after signal emission in _inform_item_number(),
edje_object_size_min_restricted_calc() and evas_object_size_hint_min_set() function are added.

Test Plan: change edc for supporting fixed toolbar item and run examples of toolbar in elementary_test

Reviewers: woohyun, seoz, Hermet, raster

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D2184
2015-03-25 07:47:33 +09:00
Amitesh Singh 8e47bbb70a tooltip: Corrected namespacing for tooltip label style.
Summary:
namespacing is wrong for tooltip label. Although we still support old theme
but it should be removed in EFL 2.0.

Test Plan: elementary_test -to tooltip

Reviewers: seoz, Hermet, raster

Reviewed By: raster

Subscribers: kimcinoo, sachin.dev, seoz

Differential Revision: https://phab.enlightenment.org/D2120
2015-03-25 07:23:07 +09:00
Carsten Haitzler ac771e51af elm - fix warnings after patches to datetime 2015-03-25 07:14:08 +09:00
Subodh Kumar 7bf866f8bf [elm_datetime] Fix to consider second field while comparing datetime values.
Summary:
Some app like calendar, they heavily depend on the value of datetime,so to ensure accuracy
second field is considered while comparing datetime values.

@fix

Test Plan: NA

Reviewers: shilpasingh, raster

Reviewed By: shilpasingh, raster

Subscribers: poornima.srinivasan, govi, rajeshps

Differential Revision: https://phab.enlightenment.org/D2204
2015-03-25 07:09:23 +09:00
Subodh Kumar 79e7d5bcad [elm_datetime] Fix to parse the POSIX locale format properly.
Summary:
In POSIX, some format include extra character like dash, hash, etc, which gives unexpected behaviour.
Fix to filter out those character.

Signed Off By: Seongjun Yim <se201.yim@samsung.com>
Signed Off By: Subodh Kumar <s7158.kumar@samsung.com>

@fix

Test Plan:
1. Set datetime as POSIX locale.
2. Check the datetime behaviour in elementary_test.

Reviewers: raster, shilpasingh

Reviewed By: shilpasingh

Subscribers: poornima.srinivasan, govi, rajeshps

Differential Revision: https://phab.enlightenment.org/D2203
2015-03-25 07:06:03 +09:00
Subodh Kumar 12f6f56f85 [elm_datetime] Corrected the logic for datetime values comparison.
Summary:
Datetime value should be compared earlier to avoid unnecessary code execution.
Also added logic for single field comparion which will avoid to compare all fields when field limit is set.

Signed Off By: Seongjun Yim <se201.yim@samsung.com>
Signed Off By: Hyunseok Yang <hs0219.yang@samsung.com>
Signed Off By: Subodh Kumar <s7158.kumar@samsung.com>

Test Plan: NA

Reviewers: shilpasingh, raster

Reviewed By: shilpasingh, raster

Subscribers: poornima.srinivasan, govi, rajeshps

Differential Revision: https://phab.enlightenment.org/D2202
2015-03-25 07:00:44 +09:00
Jaehwan Kim 1925ec3b8e scroller: add loop feature.
This feature works the infinite loop horizontally or vertically.
If the content is set, it will be shown repeatedly.
@feature

Change-Id: I1f20b794ae44bc8e5d120901222c7cccadca96b7

Conflicts:
	src/lib/elm_scroller.c
	src/lib/elm_scroller_legacy.h
2015-03-23 20:35:04 +09:00
Yakov Goldberg 9a2f068740 Implement efl_file_get() for Elm_Layout and Elm_Video
"file" property in Efl.File interface is virtual pure,
so according to OO principles must be implemented in derived classes.

This patch adds implementation of "file.get" in Elm_Layout.

Further, Elm_Video class has it's own implementation of "file.set",
thus also requires implementation of "file.get"
2015-03-22 14:37:52 +02:00
WooHyun Jung 56b6792584 toolbar: remove useless codes 2015-03-21 09:45:59 +09:00
Jee-Yong Um 89d4986aee elc_popup: Fix to make popup get proper size
Summary:
There is a bug that popup can't get proper size when list is set as its content.
Because of unneccesary calling evas_object_show() in popup's overriding elm_obj_container_content_set(),
sizing eval doens't work correctly.
This patch fixes this bug.

Test Plan:
Execute 14th popup sample in "elementary_test popup".
(popup-center-title + list content + 1 button)
After applying this patch, popup shows correctly.

Reviewers: seoz, Hermet

Reviewed By: Hermet

Subscribers: Hermet, seoz

Differential Revision: https://phab.enlightenment.org/D2158
2015-03-20 14:14:02 +09:00
Subodh Kumar c7b28cb1ac Elm_toolbar: Sizing evaluation improvement.
Summary:
Issue: Flickering when toolbar was set/unset
Solution: Unnecessary resizes and show caused the flicker, removed unnecessary resizes.

Reviewers: seoz, raster, shilpasingh

Reviewed By: shilpasingh

Subscribers: poornima.srinivasan, rajeshps, govi

Differential Revision: https://phab.enlightenment.org/D2070
2015-03-19 18:46:59 +09:00
Youngbok Shin fa68fc7603 config: Reinitialize font config using evas_font_reinit() API.
Summary:
Call evas_font_reinit() API before applying font overlays when config is fully reloaded.
Application could modify or add font config "*.conf" files.
And It should affects all of other running EFL application.
So, put evas_font_reinit() API to be called when x win property is changed.
@feature

Reviewers: cedric, raster, tasn, woohyun

Differential Revision: https://phab.enlightenment.org/D2113
2015-03-19 18:04:59 +09:00
Andrii Kroitor 3857bf83ea elm_entry: fix focus on text selection
Summary:
Setting focus to entry object when text is being selected

@fix

Test Plan:
1. open "elementary_test entry3"
2. click on the big entry
3. mouse down on singleline entry to start selection
4. move mouse out of window
5. mouse up. text in that entry seems to be selected
6. press del or type any text

expected result: selected text in singleline entry is deleted/replaced
result without this patch: singleline entry is not focused and all edit actions are affecting the big one

Reviewers: cedric, Hermet, seoz

Subscribers: poornima.srinivasan, subodh6129, raster, reutskiy.v.v, herdsman

Differential Revision: https://phab.enlightenment.org/D1476
2015-03-19 17:43:04 +09:00
Jaehwan Kim 9c26cdf25a elm_widget: fix wrong parmeter.
The parameter what the application gets should Elm_Object_Item.

@fix
2015-03-19 16:47:24 +09:00
Mike Blumenkrantz 97912ed487 elm_win fullscreen setting on FAKE wins should just toggle the flag
@fix
2015-03-18 10:53:56 -04:00
Mike Blumenkrantz 39a3a9a827 elm_win fullscreen getter does not need a third case for an inclusive if/else 2015-03-18 10:51:29 -04:00
ChunEon Park dc01331903 Revert "widget: fix the abi break."
This reverts commit 841fcdfb18a414a7381910bcbb0b0ef4807bc5c2.

It's been too much passed.
we have more dependencies to the change (ie, key bindings)
so conclude to have the abi break in this case.
2015-03-17 15:46:19 +09:00
ChunEon Park 82ee39739d conform: remove redundant declares. 2015-03-17 15:44:27 +09:00
woochan lee fb2144d9e0 conform: Use eo_isa() to check object types.
Summary:
The strcmp(line 738) has been failed since the eo applied.
the widget type get API returned "Elm_Genlist" now.

For fix it, using eo_isa() to check object types instead of string comparison.
@fix

Reviewers: seoz, woohyun, JackDanielZ, Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D2148
2015-03-17 15:42:36 +09:00
Daniel Juyung Seo 53fafc464e image: Initialize parameters in case of it just returns without assigning any value.
In this way, callers does not need to consider initializing the
parameters for their local variables.
2015-03-16 23:19:20 +09:00
Hosang Kim 74b6b65426 elm_image: Fix to initialize variable.
Summary: If _elm_image_object_size_get fails, w and h have garbage value.

Test Plan: no

Reviewers: seoz, Hermet, cedric, raster

Differential Revision: https://phab.enlightenment.org/D2163
2015-03-16 21:18:28 +09:00
Daniel Zaoui 87aa8cdb54 DnD/Wl: extend types support to all the atoms.
uri-list type was always sent as source data type.
2015-03-16 09:42:03 +02:00
Daniel Zaoui c0bd72eaa4 DnD/Wl: fix drop sequence when drop is done on a bad target.
The problem occurs when no drop target below the mouse can receive the
data type provided and the mouse button is released. The mouse pointer
stays grabbed and this leads to issues for the next drags.
To solve this, on a bad drop, the destination window has to request
from the source window the end of the dnd.
2015-03-16 09:42:02 +02:00
Daniel Zaoui 29ddeff501 DnD/Wl: add a better support to data types.
The types management mechanisms for X11 and Wayland use the same
infrastructures.
2015-03-16 09:42:02 +02:00
Daniel Zaoui cc0368334d DnD: Arrange code for better usability
Specific types need to be declared before other, as well as functions
prototypes.
2015-03-16 09:42:02 +02:00
Daniel Zaoui 1f86e80f0a DnD/X11: generalize function
This is needed for the types management in Wayland.
2015-03-16 09:42:02 +02:00
Daniel Zaoui 1191f41238 DnD/X11: generalize atoms descriptions
This step is needed to simplify types management for Wayland by using
the same data structures.
2015-03-16 09:42:02 +02:00
Jean-Philippe Andre 89d8f954de GLView: Return false if the surface could not be created
Apps had no easy mean to check that their chosen configuration
was actually working.

@fix
2015-03-16 16:40:08 +09:00
Jean-Philippe Andre b408b31537 elm_config: Add doc for the new depth/stencil/msaa preference 2015-03-16 15:10:57 +09:00
Wonsik Jung c27ab30fae elm_config: Add feature to set depth/stencil/msaa bit to window surface
Summary:
When evas gl/elm glview runs with direct rendering, it can not set these bits to window surface.
Because of no interface and method.This patch can do that.

This patch just uses current interface as a elm_config_accel_preference_set instead of new API.
Also, it is related D2144 patch.

Test Plan: ElmGL View test menu in elementary_test app JP's test app.

Reviewers: spacegrapher, cedric, raster, jpeg

Reviewed By: jpeg

Subscribers: mer.kim

Differential Revision: https://phab.enlightenment.org/D2145

Signed-off-by: Jean-Philippe Andre <jp.andre@samsung.com>
2015-03-16 14:26:41 +09:00
ChunEon Park 622fe4c5da widget: fix the abi break.
Widget type string should be all lower-cases!

This acutally was caused in 7b10fdb8f39c3b36f575dd22d26a1efe6ecd28ec

@fix
2015-03-13 17:46:00 +09:00
Jaehyun Cho 80baf57494 elm_panel: Fix incorrect scroller content region calculation of panel.
Summary:
Fix incorrect scroller content region calculation of panel.
It is fixed that the parent of panel content becomes scr_ly if panel is scrollable.

Test Plan:
Test Panel Scrollable in elementary_test.
1. Change panel orient as ELM_PANEL_ORIENT_RIGHT in test_panel.c.
2. Run elementary_test and test Panel Scrollable.
3. You can see the right panel drawer is hidden right after it is shown.
   (After applying this patch, this problem will be resolved.)

Reviewers: seoz, woohyun, eunue, Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D2125
2015-03-13 17:28:17 +09:00
ChunEon Park 2ffc39659b elm_object: update doc.
remove redundant note.
2015-03-13 17:24:07 +09:00
Amitesh Singh a56457ac76 entry: use ea_isa() for object types comparison
Reviewers: seoz, raster, Hermet

Reviewed By: Hermet

Subscribers: kimcinoo, seoz, sachin.dev

Differential Revision: https://phab.enlightenment.org/D2132
2015-03-12 15:44:09 +09:00
woochan lee 1f8ad27e40 genlist: Send param item type instead of eo item type.
Summary:
The _item_unselect() fucntion called at _elm_genlist_select_mode_set() with parameter.
It makes crash when access it->item. it is eo item type actually so it doesn't have member as item or something.
@fix

Test Plan:
1. Run elementary_test
2. Execute genlist
3. Select an item on list and click Next API fucntion button 2times.
4. Check the crash.

Reviewers: seoz, woohyun, Hermet

Reviewed By: Hermet

Subscribers: SanghyeonLee

Differential Revision: https://phab.enlightenment.org/D2136
2015-03-12 15:42:30 +09:00
SangHyeon Lee 411c30b408 Genlist/Gengrid : Modified to handle the focus highlight on unrealized items
Summary:
When unrealized item is focused, edje object is not exist,
         so genlist cannot read the focus highlight information from edje object.
         Therefore, when the item is realized, check the item is focused or not and
         need to update focus highlight.

@fix

Test Plan: change edc for supporting focus highlight in edc, and set focus on unrealized items.

Reviewers: raster, seoz, jaehwan

Differential Revision: https://phab.enlightenment.org/D2128
2015-03-11 20:35:53 +09:00
Carsten Haitzler 8cfa96fee7 elm - fix zmikes smart-arse stupid documentation remark 2015-03-11 20:16:36 +09:00
Daniel Juyung Seo f5d144e421 elm: Use eo_isa() to check object types instead of manual string comparison. 2015-03-10 22:52:29 +09:00
Daniel Juyung Seo c49d674d81 atspi: Remove unnecessary null check.
win could not be null due to EINA_LIST_FOREACH design.
2015-03-10 22:51:22 +09:00
Daniel Juyung Seo c9e3ab3363 elm: Clean up elm_win_resize_object_add caller.
- Do not need to call align_set for window resize object.
- Call weight_set before adding an object to a window's resize object.
2015-03-10 22:41:44 +09:00
ChunEon Park 86783c4c9a main: use eo_isa() to check obj type. 2015-03-10 22:31:13 +09:00
woochan lee d66a2555a8 multibuttonentry: registered object change for callback add.
Summary:
API changed from "edje_object_signal_callback_add()" to "elm_layout_signal_callback_add"
to following code refactoring.

Reviewers: seoz, woohyun, Jaehyun, Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D2102
2015-03-10 17:19:47 +09:00
ChunEon Park 6761b04c47 popup: fix mistake
this is introduced in d4eaee4eb97210ed153c161fc8b7d21967f61131.

the position should be rearragned after geometry_get().
2015-03-10 17:03:36 +09:00
ChunEon Park 304d582953 layout: here default content alias can be acceptable.
elm_object_content_set() for layout will be working.

@fix.
2015-03-10 16:56:22 +09:00
ChunEon Park 51b05f466f popup: correct popup position.
actually popup position should be updated when it's parent is moved.

@fix
2015-03-10 16:51:44 +09:00
woochan lee aa51e5ac24 layout: Add text alias description as default.
Summary:
The _text_aliases value exists. but never use here on layout for text part aliases.
in addition, i think that "elm,text" should be the default part for text set.

Reviewers: seoz, woohyun, JackDanielZ, Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D2116
2015-03-10 16:40:53 +09:00
ChunEon Park fddc22e30a Revert "Fix for T2042 ctxpopup don’t know its size"
This reverts commit aeeef70cfbc6d589262024105b52ae2c07336ecd.

Ahhh this patch wasn't intended. revert.
2015-03-10 16:36:24 +09:00
Jee-Yong Um 80f2f61c14 elc_popup: Adjust popup size when its parent is resized
Summary:
When parent is resized, popup keeps its original size.
This patch makes popup have proper size in proportion to parent's size.

T2082

Test Plan: You can check the effect of this patch in "elementary_test popup".

Reviewers: seoz, Hermet

Subscribers: stefan_schmidt, J5lx, seoz

Differential Revision: https://phab.enlightenment.org/D2121
2015-03-10 16:21:16 +09:00
woochan lee 325513c396 popup: Delete useless restack cb.
Summary:
This restack callback added for support previous tree [parent - notify - popup].
The popup has been redesigned to have correct tree [parent -popup - notify].
So the restack callback does not need anymore.

Test Plan:
1. Run elementary_test
2. Execute popup sample.
3. Activate popup which has restack feature.
4. Check the result.

Reviewers: seoz, woohyun, Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D2127
2015-03-10 16:17:49 +09:00
ChunEon Park ed6e7043a7 Fix for T2042 ctxpopup don’t know its size
Summary:
Since this patch ctxpopup is able to report its size which is equal to 1 element of list.
This can be treated as another bug (list visibility implementation must be so list will be counting its size dynamic on every item add)
Might be also ignored.

Test Plan:
1. Use application provided in T2042 (should have coordinates greater then 0).
2. Using atspi check is accessible element is visible. (with patch ctxpopup will be visible, without ctxpopup and its children will have status visible and showing set to FALSE)

Reviewers: raster, seoz, Hermet

Subscribers: m.jagiello

Projects: #elementary

Maniphest Tasks: T2042

Differential Revision: https://phab.enlightenment.org/D2045
2015-03-09 09:57:42 +09:00
Mike Blumenkrantz 00e8d1737c cursor theme setting should use cur->owner instead of cur->eventarea for parent
owner is required to be an elm widget, eventarea is not
2015-03-05 11:35:41 -05:00
Mike Blumenkrantz 46e9bdd735 cursor object changes are now rejected if creating the new cursor fails
previous behavior resulted in a deleted cursor
2015-03-05 11:33:57 -05:00
Mike Blumenkrantz 8384b0a0f7 cnp should only attempt to get wl win for wl engine canvases
fixes abort() on missing wl ee interface
2015-03-05 11:31:30 -05:00
Carsten Haitzler d3d3cbf915 elm spinner - add backwards compat for older spinner themes
this makes spinenr work with previous themes after
adfe7fbcd3f4146d84219de7dbb5a273d89f396e commit
2015-03-05 15:14:34 +09:00
Mike Blumenkrantz 297ac7c17d elm_win now accurately reapplies framespace in all cases for fullscreen wins
also related opaque region fix
2015-03-04 15:20:54 -05:00
Daniel Juyung Seo cce206ff53 colorselector: Check return value of elm_layout_theme_set as other widgets do.
This fixes coverity CID 1273969.
2015-03-04 20:59:36 +09:00
woochan lee 03af867581 multibuttonentry: Item width size set policy change.
Summary:
Item width max size set as 130 in edc before, i thinks that value doen't have any meaning,
so i changed the item max width size to follow container width size.

For modification, item size calc, box resize logic changed.

Test Plan:
1. Run elementary_test
2. Execute multibuttonentry sample.
3. Input some text for make item.

Reviewers: Hermet, seoz, woohyun, Jaehyun

Differential Revision: https://phab.enlightenment.org/D1970
2015-03-04 20:38:04 +09:00
Sung-Taek Hong 22adafce60 elm_slider: Added elm_slider_indicator_visible_mode_set/get.
Summary: elm_slider: Added elm_slider_indicator_visible_mode_set/get.
elm_slider_indicator_visible_mode_set/get allows individual sliders to have
its own indicator visible_mode.

@feature

Reviewers: Hermet, woohyun, seoz

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D1945
2015-03-04 18:45:51 +09:00
Vitalii Vorobiov 46cdb168e8 Genlist: make reordered item selected
Restacking not selected item should be selected after it is done.

@fix

Test Plan:
1. run in console
> elementary_test "Genlist Reorder Mode"
2. Switch to reorder mode
3. Select Item #6
4. Try to restack Item #4
(not selecting it, but holding mouse on it and moving down)
5. See that Item #4 and Item #6 is not selected

Reviewers: cedric, Hermet, raster, seoz

Subscribers: reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1931
2015-03-04 18:40:42 +09:00
Carsten Haitzler 17ffbd6448 elm - focus feature - add config option to automatically show/hide focus
this adds logic in elm widget and elm win to figure out how to
automatically show a focus hilight when switching focus, or to hide
it. this really should be the default mode, thus in all default
profiles (default, standard, mobile) it's turned on. this means if you
tab or shif+tab or use arrow keys to switch focus, the focus hilight
will magicallly appear. click with a mouse to change focus and it'll
disappear assuming you want to use the mouse to do things. If focus is
explicitly turned on in config or in the window by api, then this has
no effect and focus will remain on all the time. this adds apis to
change these config values and options in the default elm config tool
to swizzle them as well as config upgrade handling for existing configs.

@feature
2015-03-04 17:47:54 +09:00
Subodh Kumar b0f969dd2a Elm_spinner focus UI, accessibility fix
Summary:
Issue: Focus was not getting transferred individually on arrow buttons and text area.
Solution: Remove the usage of image parts and text parts and replace them with buttons
so as to handle the focus transfer normally than forcibly via smart event.
hence Focus next hook and focus direction hook is implemented.

Signed-off by: Subodh Kumar<s7158.kumar@samsung.com>
Signed-off by: Shilpa Singh<shilpa.singh@samsung.com>

Test Plan:
Use keyboard keys on spinner and test focus transfer, enable accessibility and test
accessibility.

Reviewers: woohyun, Hermet, shilpasingh, raster, seoz

Reviewed By: shilpasingh, raster

Subscribers: stefan_schmidt, raster, rajeshps, govi

Differential Revision: https://phab.enlightenment.org/D1911
2015-03-04 16:03:30 +09:00
Shobhit b2b4f805bb hoversel: Enabled default mirroring in hoversel.
Removed default disable automatic mirroring of hoversel.

Summary:
Removed below API call for hoversel, hover, box and button object
elm_widget_mirrored_automatic_set(obj, EINA_FALSE);

Modified theme of "elm/button/base/hoversel_vertical_entry/default" to remove console errors due to theme, and modified text.align to -1 as 'x' value to set auto align for Arabic text.
Modified example hoversel_example_01.c to illustrate mirroring functionality

@fix

Reviewers: Hermet, seoz, tasn

Subscribers: sachin.dev

Differential Revision: https://phab.enlightenment.org/D1910
2015-03-04 15:54:41 +09:00
Mike Blumenkrantz 3df05663bd elm_win framespace toggling on fullscreen change: activate!
@fix
2015-03-03 15:00:04 -05:00
Mike Blumenkrantz c5f5425e5e elm_win trivial function move 2015-03-03 15:00:04 -05:00
Andrii Kroitor 67068df957 elm_colorselector update
Summary:
elm_colorselector: replaced entries with spinners
elm_colorselector: extended styling support
elm_colorselector: changed colors alignment in palette

Reviewers: Hermet, reutskiy.v.v, tasn, cedric, seoz, raster

Reviewed By: reutskiy.v.v

Subscribers: reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1513
2015-03-03 20:07:50 +09:00
VBS 93f0745430 genlist: Implemented genlist expand mode and content_min_limit function
Summary:
1. Implemented genlist mode ELM_LIST_EXPAND
2. Implemented content_min_limit function which override scroll interface.
  This function will be used by call API elm_scroller_content_min_limit.
  This function will set the object minimum size as its scroll content size,
  if parameter value is EINA_TRUE.

@feature

Test Plan: Add new test case in test_popup.c

Reviewers: raster, seoz

Subscribers: stefan_schmidt, bluezery

Differential Revision: https://phab.enlightenment.org/D1279
2015-03-03 19:58:41 +09:00
Jaeun Choi 8b85672bdd gengrid/genlist/list: focus first item if first_item_focus_on_first_focus_in is on
whether focus highlight is enabled or not

@fix
2015-02-27 18:17:37 +09:00
Jaeun Choi 7f77edf55d layout: apply widget's states when elm_layout_file_set is called
when a layout's theme is changed by elm_layout_theme_set, the edje is updated
according to the widget's states such as 'disabled' or 'highlight_in_theme'.
but the update is dropped for elm_layout_file_set.
this patch tied up the codes into _visuals_refresh function
so that the same update happens for elm_layout_file_set.

@fix
2015-02-27 14:46:40 +09:00
Chris Michael 244f32b797 elementary: Fix issue of cursor getting unset on DRM engine
Summary: When running the E startup wizard using DRM, the cursor ends
up getting unset (and never reset) due to the DRM engine not having a
wayland window. To fix this, we will test the the engine being DRM and
if so then set the cursor->use_engine to false so that it defaults to
ecore_evas_object_cursor calls (which work on DRM).

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-02-26 10:44:59 -05:00
Chris Michael a87b0341f3 elementary: Restart default cursor for wayland windows
Summary: If we are unsetting the cursor for an object, then if it's an
object on a wayland window, we should be callbacking
ecore_wl_window_cursor_default_restore

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-02-26 10:22:04 -05:00
Daniel Zaoui cd97249a33 DnD/X11: improve callbacks invocations.
There is no reason why drop targets callbacks registered for a specific
type would be invoked when a not supported data is dragged.
This patch fixes it by comparing the data type and the callback type of
the drop target. Only the callbacks supporting the data type are
invoked.
2015-02-25 10:36:38 +02:00
Daniel Zaoui 3b7710f107 DnD/X11: improve types checking during position event.
During a DnD position event, we need to find the first dropable target
located under the mouse pointer; one of its callbacks has to support
at least one of the types of the dragged data.
This search process was done by strcmp-ing types for every drop target
and for each of their types until a good target is found.
This patch improves the process by comparing types formats, i.e and-ing bits
vectors.
2015-02-25 10:36:34 +02:00
Daniel Zaoui deb599fa47 DnD/Wl: clean app callbacks management 2015-02-25 10:36:26 +02:00
Daniel Zaoui 43274d3d3c DnD/Wl: support multi-layer Drag and Drop
Now, we use the same way as in X11 to determine which dropable target
should receive the drop data.

@feature
2015-02-25 10:36:18 +02:00
Daniel Zaoui a04166da20 DnD: Add line number to debug messages 2015-02-25 10:36:13 +02:00
Daniel Zaoui ed8505ea01 DnD: generalize internal functions.
They were specific to X11 and should be used for Wayland too.
2015-02-25 10:36:09 +02:00
Daniel Zaoui 703f86dfb4 DnD/Wl: add cancel support
This feature permits cancellation of a DnD operation in the middle.

@feature
2015-02-25 10:35:43 +02:00
Tom Hacohen e2dcfa64ae Fix code to conform to recent Eo changes. 2015-02-23 17:16:21 +00:00
Daniel Juyung Seo 5e4093babe multibuttonentry: Check return value of elm_layout_theme_set.
This fixes coverity CID 1086781.
2015-02-23 22:45:33 +09:00
Jee-Yong Um c0e8ebc971 elm_box: Fix miscalculated items' size issue in homogeneous box
Summary:
When box has expanded items (evas_object_size_hint_weight_set() with EVAS_HINT_EXPAND)
and homogeneous is set (elm_box_homogeneous_set() with EINA_TRUE),
there is a bug that it miscalculates its items size omitting padding size (space among items),
so the last item looks cropped or having smaller size than others.
This patch makes box calculate its items' size correctly.

T2033

Reviewers: Hermet, seoz

Subscribers: seoz, Hermet

Maniphest Tasks: T2033

Differential Revision: https://phab.enlightenment.org/D2016
2015-02-23 17:59:52 +09:00
woochan lee ebe640cc2d datetime: Fix elm_datetime_field_limit_set.
Summary:
If user sets the limit value using elm_datetime_field_limit_set() API, the filed value will be recalculated.
Even though the value changed in case, value changed signal didn't send to user before.
@fix

Reviewers: seoz, woohyun, Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D1980
2015-02-23 17:58:19 +09:00
SangHyeon Lee 594fe0c8a1 genlist/gengrid : Add upadating 'focus' state in item realized function.
Summary:
When an item is realized, select/disable/expand signal emission to the view object of an item was handled correctly,but there are no updating code for focus state.

@fix

Test Plan: tested by editing genlist/genlist item edc to react on elm,state,focused and move scroll signals to unrealized/realized item again.

Reviewers: raster, seoz

Reviewed By: seoz

Subscribers: eunue

Differential Revision: https://phab.enlightenment.org/D2024
2015-02-23 17:57:01 +09:00
woochan lee fb104a22ee elm_box.eo: Added @ingroup tag.
Summary: The API "elm_box_horizontal_get" missed @ingroup tag. so i added the tag for grouping when  doxygen making API documentation.

Reviewers: Hermet, JackDanielZ, Jaehyun, seoz

Reviewed By: seoz

Differential Revision: https://phab.enlightenment.org/D1966
2015-02-23 12:48:36 +09:00
Daniel Juyung Seo 263801f018 elm: Remove redundant finger size adjustment.
This is a successor of a54da8aab.
2015-02-23 08:43:47 +09:00
kabeer khan 7cc6360aee elm_photocam: add API's to change photocam image orientation
Summary:
Added API's to rotate(90, 180, 270), flip(horizontal, vertical), transpose and transverse Photocam Image.

Signed-off-by: kabeer khan <kabeer.khan@samsung.com>

Reviewers: seoz, stephenmhouston, raster, cedric

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1541

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-02-20 14:33:17 +01:00
kabeer khan 97cefca273 elm_image: changed orient_set code to use evas_object_image_orient_set API
Summary:
evas_image_orient_set is a newly added API to set orientation of evas image.
Using this API to set orientation of image widget.
Also removed Elm_Image_Orient enums and replaced it with Evas_Image_Orient enums.

Signed-off-by: kabeer khan <kabeer.khan@samsung.com>

Reviewers: raster, seoz, cedric

Differential Revision: https://phab.enlightenment.org/D1987

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-02-20 14:31:12 +01:00
Andy Williams 3e78cbb1a6 entry: Don't unlink empty files when saving @fix T2122.
Simmple fix where we now only unlink if the object we are saving is NULL.
A null terminated string being null is not an error case.
2015-02-18 08:46:05 +00:00
Daniel Juyung Seo 58c131d25d transit: Clean up internal variables and function names. 2015-02-17 09:09:33 +09:00
Jee-Yong Um f4bf91f7c7 elm_transit: Add elm_transit_go_in() API
Summary:
elm_transit_go() is executed immediately after it is called.
elm_transit_go_in() starts transit in given seconds.

@feature

Reviewers: Hermet, seoz

Reviewed By: seoz

Subscribers: seoz, Hermet

Differential Revision: https://phab.enlightenment.org/D1954
2015-02-17 08:34:46 +09:00
woochan lee 684013d25e multibuttonentry: Item selected callback called twice redundantly.
Summary:
_current_item_change() called at _item_select() internally.
it means _current_item_changed() called two times in vain.
so that's why item select callback called two times.
@fix

Test Plan:
1. Run elementary_test
2. Excute multibuttonentry sample.
3. Added some items and click the item area.
4. Select signal called two times.

Reviewers: Hermet, woohyun, JackDanielZ, seoz

Reviewed By: seoz

Differential Revision: https://phab.enlightenment.org/D1955
2015-02-14 22:56:05 +09:00
Hermet aa647b6a2c panes: improve doc. 2015-02-14 13:29:20 +09:00
Chris Michael aca4b39e9a elementary: Remove unused variable
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-02-13 09:44:05 -05:00
Daniel Kolesa d88843bccc els_tooltip: compiler portability (use full ternary operator) 2015-02-13 14:22:28 +00:00
Jaeun Choi dc4f231b71 popup: removed button style setting code in theme_apply
popup buttons are created by users
it's inappropriate to set button style in widget code

@fix
2015-02-13 21:28:05 +09:00
kabeer khan caca7d7204 elm_photo: sanitise file path
Summary:
Resolved FIXME deal with relative path by sanitising file path

Signed-off-by: kabeer khan <kabeer.khan@samsung.com>

Reviewers: stephenmhouston, cedric, seoz, devilhorns

Reviewed By: cedric, seoz, devilhorns

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1874
2015-02-13 16:26:05 +09:00
Carsten Haitzler 44556de7f9 elm scroller - add adnimated and accelerated wheel scroll
now when a whele event comes in, 1. the amount we scroll accelerates
based on time between wheel events (the faster wheel events come out,
the more accel), and 2. we animate to the new position providing a
smooth transition to the new spot rather than a jump. very visually
nice.

@feature
2015-02-13 13:14:07 +09:00
Daniel Juyung Seo a3200cc02c genlist: Fix elm_genlist_item_index_get.
The first item's index is 1 not 0.

@fix
2015-02-12 22:05:27 +09:00
Jaeun Choi 2fdfbd5aac gengrid: select the focused item on enter key input
there was no way to select an item with key input on ELM_ITEM_SELECT_ON_FOCUS_DISABLE mode.
this patch enables select and multi select with enter/space key input.

@fix
2015-02-12 19:15:57 +09:00
Jaeun Choi abf1693705 genlist: select the focused item on enter key input
there was no way to select an item with key input on ELM_ITEM_SELECT_ON_FOCUS_DISABLE mode.
this patch enables select and multi select with enter/space key input.

@fix
2015-02-12 17:53:55 +09:00
Jee-Yong Um aead3d5135 elm_toolbar: remove code duplication
Summary:
elm_coords_finger_size_adjust() is called twice.
It might not be intended.

Reviewers: Hermet, Jaehyun, seoz

Reviewed By: seoz

Subscribers: raster, seoz, Hermet

Differential Revision: https://phab.enlightenment.org/D1924
2015-02-11 16:49:25 +09:00
Jaeun Choi bc7eb19133 Revert "gengrid: call "selected" callback on entey key input"
This reverts commit 0debdcf1ca166da1c083765bdb1542183fe96427.
2015-02-10 20:58:39 +09:00
Jaeun Choi 355768be53 gengrid: call "selected" callback on entey key input 2015-02-10 20:29:47 +09:00
Carsten Haitzler 4aab4fd356 elm engine - restore explicit use of ELM_ENGNE env var
this fixes a deprecation of elm engine done just before 1.13 release
that ends up breaking "make doc" and also will make ELM_ENGINE env var
stop working (the latter was intentional). but since this is relied on
for things like make doc - keep the env var and haveit set preferred
engine and let people migrate away from using the engine var EXCEPT
for things like the shot engine

@fix
2015-02-10 19:50:14 +09:00
Jaeun Choi f5f71a14e8 popup: passing right parameter to elm_layout_sizing_eval
pass popup object instead of main_layout to elm_layout_sizing_eval()
so that _elm_popup_elm_layout_sizing_eval is called

@fix
2015-02-10 16:01:23 +09:00
woochan lee cf07ba6b5d multibuttonentry: refactoring(makes button object Elm_Item_Object instead of edje object)
Summary:
There was no consistency with another widget which has item object, basically widgets has Elm_Object_Item object for own's item object.
but multibuttonentry used edje object for item object before.

Test Plan:
1. Run elementary test.
2. Execute multibuttonentry.
3. Doing variety action on multibuttonentry widget.(add, delete, key event, focus etc...)

Reviewers: seoz, woohyun, Jaehyun, Hermet, JackDanielZ

Subscribers: herdsman, cedric

Differential Revision: https://phab.enlightenment.org/D1864
2015-02-10 14:22:43 +09:00
Youngbok Shin a6f4ef80e4 panel: Remove error message from elm_panel_add API and _theme_apply func.
Summary:
elm_layout_content_set API calls _elm_panel_elm_container_content_set func.
The panel widget checks the given "parts" string is whether "elm.swallow.event" or not.
To avoid error message and set the given object to the "elm.swallow.event" internally,
the panel widget need to call *_content_set for "elm.swallow.event" part using eo_do_super.
@fix

Test Plan: elementary_test -> panel

Reviewers: seoz, woohyun, Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D1949
2015-02-10 13:41:13 +09:00
Carsten Haitzler 5b69285f8a elm - list - fix invalid item data scope get
@fix
2015-02-09 20:25:44 +09:00
Carsten Haitzler d9e54a4c96 elm list - fix access of deleted items in list when recursing
@fix
2015-02-09 18:20:45 +09:00
Youngbok Shin b48ab5e101 widgets: Apply default return value according to description in .eo or add description too.
Summary:
1) According to description in .eo file,
some APIs return not 0 when the given object is NULL or not proper object.
But, several APIs are not implemented as those description.
Now, they will return a value as description.
2) If there is no description about the return value when the API fail,
put description according to pair API or old version of elementary.
@fix

Reviewers: woohyun, Hermet, seoz

Differential Revision: https://phab.enlightenment.org/D1933
2015-02-09 13:09:05 +09:00
kabeer khan 2d7cb99e9b elm_widget: added evas smart callback descriptions
Summary:
Resolved FIXME filled all smart callbacks and also set it in the constructor

Signed-off-by: kabeer khan <kabeer.khan@samsung.com>

Reviewers: seoz

Differential Revision: https://phab.enlightenment.org/D1876
2015-02-09 10:40:29 +09:00
Carsten Haitzler 03dbbf034c elm - fix engine config mismatch with new perferred accel vs old engine
the elm config tool only lets you set accel preference. if you set
none, then the old engine config takes charge, but there is no way to
change/set this, so deprecate the old engine set and don't use it.
this accel preference has been around for a while, so use it now
instead.
2015-02-07 13:00:21 +09:00
Sung-Taek Hong 94e9434206 elm_slider: modified each slider have its indicator visible mode.
Summary: Added indicator_visible_mode to each slider in order not to make elm_config controlls every sliders.

Reviewers: Hermet, woohyun, seoz

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D1887
2015-02-06 21:58:32 +09:00
Daniel Juyung Seo a2b97d4abb doc: Fix typos in documentations. 2015-02-06 15:15:44 +09:00
Youngbok Shin 2bd02ea54d win: fix an issue that profile is erased and set to NULL.
Summary:
When ecore_evas_window_profile_supported_get API return EINA_FALSE,
elm_win widget should not get profile from ecore_evas_window_profile_get API.
@fix

Reviewers: woohyun, Hermet, seoz

Reviewed By: seoz

Differential Revision: https://phab.enlightenment.org/D1943
2015-02-06 15:06:49 +09:00
Carsten Haitzler 40fd99e2d9 fix win center trap for elm to pass in h and v params
while this is technically an abi break, it should actually have no
real impact. it will have warnings - sure, but running existing code
will simply not see the extra parammeters on the stack and not use
them so it'll continue to work. if we removed paramms, we'd be in
pain. (same applies to params passed in registers).

this fixes T2031
2015-02-06 11:32:55 +09:00
Carsten Haitzler 299c604661 elm - win - dont use deprecated func - use new one.
cleanup to match efl 1.13 changes
2015-02-05 20:44:49 +09:00
Jee-Yong Um 190c2f93ef elm_label: Fixed label disappearing after theme changed
Summary:
There is a bug that text disappears when theme is changed after label shown.
This patch fixed it.

@fix

Reviewers: woohyun, Hermet, Jaehyun, seoz

Subscribers: Jaehyun, seoz

Differential Revision: https://phab.enlightenment.org/D1923
2015-02-05 20:41:16 +09:00
Shinwoo Kim 02693dbc02 [tooltip] use proper object to set tooltip layer
Summary:
tooltip could be hide by the other object which have lower layer than target object of tooltip.
the layer of content could be changed, when is set to the tooltip as a content.

@fix

Test Plan: check added test lines

Reviewers: cedric, jpeg, seoz, raster

Reviewed By: raster

Subscribers: singh.amitesh, stefan_schmidt, seoz

Differential Revision: https://phab.enlightenment.org/D1889
2015-02-05 20:02:45 +09:00
Jee-Yong Um 3e2e181bc3 elm_label: Fixed to prevent slide's autostart before calling elm_label_slide_go()
Summary:
Label should not start sliding before elm_label_slide_go() is called.
However, label starts sliding automatically,
because resize callback emits slide start signal.
This patch prevents label from sliding before calling elm_label_slide_go().

@fix

Reviewers: woohyun, Hermet, seoz

Subscribers: CHAN, woohyun

Differential Revision: https://phab.enlightenment.org/D1906
2015-02-04 19:26:06 +09:00
Jaehwan Kim 4629240ad2 datetime module: include elm_widget_datetime.h instead of elm_priv.h
The external module can't include elm_priv.h.
So Elm_Datetime_Module_Data moves in elm_widget_datetime.h
2015-02-04 18:56:18 +09:00
VBS 8570190563 Gengrid : Fix memory leak in elm_gengrid_realized_items_update
Summary:
Eina_List from elm_gengrid_realized_items_get must be freed by caller,
         but elm_gengrid_realized_items_update doesn't free Eina_List.
         So memory leak is happens.
@fix

Test Plan: Call elm_gengrid_realized_items_update repeatly and check memory share increase.

Reviewers: raster, seoz

Differential Revision: https://phab.enlightenment.org/D1903
2015-02-04 08:30:07 +09:00
Youngbok Shin 10fae20d33 elm_image: fix elm_image_memfile_set API fail when elm_image widget is not visible.
Summary:
It could success only when the widget was visible.
The API must return EINA_TRUE if buffer and size has no problem, not visiblity of widget.
@fix

Reviewers: Hermet, woohyun, jpeg

Differential Revision: https://phab.enlightenment.org/D1917

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-02-03 10:17:50 +01:00
Amitesh Singh ab50a85937 list/genlist/gengrid/toolbar: set focus/unfocus on item when focus is actually set on widget.
Summary: @Fix

Reviewers: raster, Hermet, seoz

Reviewed By: seoz

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D1918
2015-02-03 15:48:36 +09:00
woochan lee 6e8f8629aa multibuttonentry: Delete duplicate running code.
Summary:
When layout clicked, "elm_widget_on_focus()" called with "entry_focus_in()" callback.
The "view update" and "focus set to entry" already call in those callbacks, so i deleted duplicate code and it also make focus issue when user click the entry to add item.
@fix

Test Plan:
Run elementary_test.

1. excute multibuttonentry.
2. click the entry area.
3. see the elm_widget_on_focus called twice.
   (layout callback function called view update -> elm_box_unpack called in view update ->
    entry lose focus -> on_focus_callback call again)

Reviewers: Hermet, seoz, Jaehyun_Cho, JackDanielZ

Differential Revision: https://phab.enlightenment.org/D1902
2015-02-03 11:38:21 +09:00
Youngbok Shin 82f1aebd01 win: Add default return value at elm_win_type_get API according to API description.
Summary: The API must return ELM_WIN_UNKNOWN (-1) when the given object is improper.

Test Plan: None.

Reviewers: woohyun, JackDanielZ, seoz

Differential Revision: https://phab.enlightenment.org/D1907
2015-01-30 11:04:24 +09:00
kabeer khan d87b5c0e41 Elm_Entry: Removed empty line and added error message
Summary:
Resolved FIXME in utf8_markup_save by adding error messages
for fopen and fputs command

Signed-off-by: kabeer khan <kabeer.khan@samsung.com>

Reviewers: devilhorns, seoz

Reviewed By: seoz

Differential Revision: https://phab.enlightenment.org/D1888
2015-01-30 08:02:21 +09:00