Summary:
Fix item selection using selection handler
In case of selection using handler, there is a problem in case the entry
has the item, mouse down over handler consider the current down
coordinate to start selection and it becomes very difficult to select in the
situation shown in the test plan. So I consider the next/previous line
geometry to fix it.
@fix
Test Plan:
1.Enable selection handler
2. Have a look at the setup in the attached image
{F27396}
3. Start selecting from last item and extent to cover the last text.
4.Observe that its impossible to select the last text until you move mouse out of the window
So, in mobile device its almost impossible to select using handlers in this situation.
Please use the attached application to test it.
{F27402}
Reviewers: thiepha, herdsman, tasn
Reviewed By: tasn
Subscribers: shilpasingh
Differential Revision: https://phab.enlightenment.org/D3479
Summary: Use edje api and simplify empty check logic
Test Plan: NA
Reviewers: herdsman, tasn
Reviewed By: tasn
Subscribers: shilpasingh, cedric
Differential Revision: https://phab.enlightenment.org/D3505
This cleans up orphan icons being left in the UI if you call icon_set
after the toolbar has been displayed.
This was most noticable if the toolbar or buttons move first
@fix
Summary:
Continouous clicks on hover would need to ensure that variable
on_dismiss of combobox_vertical style in hover.edc should 0 when slot is being shown, otherwise events
would be disabled on hover even though swallow content is shown.
@fix
Signed-off-by: Divyesh Purohit <purohit.div@gmail.com>
Test Plan:
Click continouosly on combobox and events on hover would be
disabled.
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3601
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
This patch @fix this usage example:
0. image obj create
1. file_set(an animated gif)
2. animated_set(TRUE) + animated_play_set(TRUE) to make the gif play
3. file_set(a normal image)
... at this point elm_image is confused because it still think that the image is animated
4. file_set(an animated gif)
5. animated_set(TRUE) + animated_play_set(TRUE) to make the gif play
...this now do not work because elm think that the image is already animated
_elm_combobox_elm_genlist_filter_set function does not use the Eo *obj
parameter so mark it as EINA_UNUSED to remove compiler warning
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
In the case of a genlist set as ELM_OBJECT_SELECT_MODE_ALWAYS the "selected" cb was called 2 times. This @fix that by skipping the selection code in case the click is not the first one (EVAS_BUTTON_NONE).
Also merge the conditions of two consecutive "if" in a single statement.
Summary:
Initially combobox used hover's default style, this patch would make combobox use hoversel_vertical style.
@Fix T3075 for 2nd point.
Signed-off-by: divyesh purohit <div.purohit@samsung.com>
Test Plan: please run combobox example from elementary_test
Reviewers: shilpasingh, cedric, raster
Subscribers: rajeshps, govi
Maniphest Tasks: T3075
Differential Revision: https://phab.enlightenment.org/D3596
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Before this patch, the filter was set inside the combobox. This is confusing for the
user of the object as it can't define a custom filter except on strings. It is also
impossible to bind as binding require to know what was put in and they can't differentiate
between a genlist filter being set from the binding to one being set internally by
the combobox.
@fix
genlist item is flaoting upon the expanded item when homoegeneous mode
is enabled.
when item block is recalculated by tree expanding, new item didn't
update their properties and values becuase of size hash, but edc
actaully need to be recaculated after swallowing tree size padding.
solve the issue by adding expand depth check in size hash.
you can check the previous issue in T2708
elementary_test->genlist tree->homoegeneous check
@fix
This @fix three (yes 3!) errors from commit cafda5928f9bf8116564219dc03d12c3a6e131b3
1. the initial value in the standard config is wrong, causing ctx menu to be disabled for everyone!
2. the argument of the api should be named "disabled" (like all the other disable API in this context)
3. (minor) fixed doc for elm_config_context_menu_disabled_set
NOTE: there are no configuration gui for this option, if you cleared your elm config recently you probably now have the ctx menu disabled everywhere, only solution is to wipe your config (to let elm create a new correct one)
Big SPANK to the author, the commiter and all the reviewers of D2463!!!
Summary:
While applying scroller on hoversel, several lines for item size
calculation were added, but they failed to have item get proper size.
Now redundant codes are removed and some are fixed, and hoversel will
be shown more well-ordered.
Test Plan: elementary_test hoversel
Reviewers: jpeg, raster, cedric
Differential Revision: https://phab.enlightenment.org/D3589
Summary:
This patch will reduce duplicate codes and code depth for readability
Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
Reviewers: seoz, Hermet, cedric
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D3574
When using this function with wayland windows, we should be returning
the matching Ecore_Wl2_Window id, not the surface_id
ref T3058
@fix
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
There is no need to recalc row and col position of the item, they are already stored in the item struct.
The old implementation was calculating wrong values and also was storing this wrong values in it->x and it->y, resulting in wrong results for the elm_gengrid_item_pos_get() function.
so, at the end, this is a @fix for the pos_get() function.
Also changed a bit the test to let the gengrid fill the window and thus testing behaviour on col/row changes.
I didn't find any regression in all the gengrid tests after this, let me know if it broke something for you.
Issue:
1. elementary_test -> slider
2. move mousewheel on slider and popup gets shown.
3. close the slider window very fast or increase the wheel_timeout to 4 seconds
4. observe crash
deleting subobjects here was occurring and triggering sizing eval
prior to removing the objects from the evas box, resulting in a failure
to accurately calculate and set size hints
also set delete_me to block sizing evals during subobj deletion loop
in order to avoid object thrashing during the time when nothing is happening
@fix
Summary:
1) Recalc error occurs if combobox_hover_begin() was called by the app, it can be reproduced by keeping elm_combobox_hover_begin() in the test_combobox.c
2) Content_set in hover always considered "bottom" as it's best_location as it done during the constructor.
@fix
Signed-off-by: divyesh purohit <div.purohit@samsung.com>
Test Plan:
It can be reproduced by keeping elm_combobox_hover_begin() in the test_combobox.c.
Also the changing the position of combobox in the window would give top/bottom as it's best location.
Reviewers: cedric, shilpasingh
Reviewed By: shilpasingh
Subscribers: rajeshps, govi
Differential Revision: https://phab.enlightenment.org/D3544
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
it's wierd to expand hoversel without items.
the behavior made me suprised before i analyzed it.
it looked almost a bug.
if you have any other objections, please ping me.
conceptually, ctxpopup won't give any geometry information of the container.
this event is a way for returning the information of the container for user scenarios.
@feature.
fix @T2042
Coverity CID1347398 reports that this could potentially be a
non-portable assumption resulting in a sizeof mismatch. Fix this by
using the actual structure type in the call to calloc.
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
This patch just fixes a compiler warning about using fw/fh
uninitialized if the conditional is false
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
previously-applied max size hints should not be unset; these are only
able to be set externally from a parent object, so don't overwrite them
internally
@fix
Summary:
When elm_sys_notify was not needed, its singleton instance
is NULL. Eo complained about passing a NULL pointer.
Thanks to bu5hm4n (Marcel Hollerbach) for the report.
@fix
Reviewers: stefan_schmidt, cedric
Subscribers: bu5hm4n
Differential Revision: https://phab.enlightenment.org/D3535
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
With the push of 1056b6ed01475817da2439012057d11865d2c5d8, elementary
compile broke due to undeclared variables. This patch fixes elm to
compile again by declaring the missing vars.
@fix
@raster, Please double check this change as I am unsure if it is what
you Really intended here.
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
this fixes the config monitoring to not use flush.cfg but to use the
correct profie.cfg or base.cfg in the profile we are using. this is
necessary to do "special" profiles per screen so apps that switched to
another profile because asked by e, monitor THAT profile for changes
specifically and dont also switch profiles since they have been told
what to use now.
@fix
this adds the ability to have one profile automatically be derived
from another with modifications applied. right now it only can do a
very limited modification - multiple scale. over time this will
expand. this is only inteded otbe sued by a DE like enlightenment, so
it's not going to be documented fully at this point.
@feature
support the ability to have hidden profiles that begin with a dot (.)
char like all hidden files/dirs. to do this we need to also be able to
create profiles with a given name (a hidden name) without switching to
them, so add the ability to save out to a specific profile name
without switching to it. of course this means to list profiles we need
to list them or list ALL includiing hidden profiles.
@feature
Summary:
Combobox is a combinational widget of a drop-down list and single line entry.
Based on the text entered in the entry, the list items are filtered accordingly.
Signed-Off By: Cedric Bail <cedric.bail@free.fr>
Signed-Off By: Divyesh Purohit <div.purohit@samsung.com>
Test Plan: test_combobox.c is added to elementary test
Reviewers: raster, shilpasingh, cedric, jpeg, stefan_schmidt
Reviewed By: raster, shilpasingh, cedric
Subscribers: SanghyeonLee, shashank0990, singh.amitesh, tasn, raster, seoz, poornima.srinivasan, rajeshps, govi
Differential Revision: https://phab.enlightenment.org/D2537
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
when using elm_object_part_content_set(hover, "smart", content); it would cause segfault, this patch would fix T3004
Signed-off-by: divyesh purohit <div.purohit@samsung.com>
Test Plan:
please open the hover3 example in elementary for testing it, the hover
content shouldn't leave the window as "smart" direction is used.
Reviewers: shilpasingh, raster, cedric, Hermet
Subscribers: rajeshps, govi
Maniphest Tasks: T3004
Differential Revision: https://phab.enlightenment.org/D3524
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
If auto_update feature changes hoversel width,
dismiss animation seems awful because hoversel contents move to
changed position in an instant.
This patch makes hoversel update its content with clicked item
after dismiss animation finished.
Test Plan: elementary_test hoversel
Reviewers: raster, cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D3519
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Hoversel Widget is designed in such a way that it accepts top/bottom/left/right directions , internally it uses hover widget which does not take care if its content goes of it's parent (Elm_Win in most cases) . this patch ensures that the drop-down content remains restricted in visible hover_parent. it would fix T2965
Signed-off-by: divyesh purohit <div.purohit@samsung.com>
Signed-off-by: Jee-Yong Um <conr2d@gmail.com>
Test Plan:
Open entry widget and right click to show a hoversel widget, check if the hoversel or hover content goes out of the window.
this is what hoversel would look like after this patch {F27551}
Screenshots of top-left / top-right/ bottom-left and bottom-right corners in entry after this patch
{F27553}
{F27554}
{F27555}
{F27557}
Reviewers: shilpasingh, conr2d, raster, cedric, Hermet
Subscribers: rajeshps, govi
Projects: #elementary
Maniphest Tasks: T2965
Differential Revision: https://phab.enlightenment.org/D3513
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The following new color classes and text classes
for spinner widget are added.
"spinner_bg", "Spinner Background"
@feature
Reviewers: raster, cedric, Hermet, kimcinoo, woohyun
Subscribers: SanghyeonLee, eagleeye, id213sin
Differential Revision: https://phab.enlightenment.org/D3488
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Add new text classes and color classes for Entry widget according to
consistency with other widget's class.
And it removes legacy classes. If we need to support backward
compatibility, the legacy classes have to be maintained in each widget.
Test Plan: N/A
Reviewers: cedric, woohyun, jaehwan, kimcinoo, raster
Subscribers: CHAN
Differential Revision: https://phab.enlightenment.org/D3486
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The following new color classes and text classes
for calendar widget are added.
"calendar_year_text" - Year Text in Title Area
"calendar_month_text" - Month Text in Title Area
"calendar_weekday_text" - Weekday Text
"calendar_day_text" - Day Text
"calendar_day_text_holiday" - Holiday Text
"calendar_day_text_today" - Today Text
"calendar_day_text_disabled" - Disabled Day Text
"calendar_day_selected" - Selected Day Effect
"calendar_day_highlighted" - Highlighted Day Effect
"calendar_day_checked" - Checked Day Effect
@feature
Test Plan: N/A
Reviewers: woohyun, raster, cedric, kimcinoo, jaehwan
Subscribers: CHAN
Differential Revision: https://phab.enlightenment.org/D3482
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
minw and minh are overwritten in the next line at once.
This patch removes a meaningless line.
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3450
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Add new scrollto type allowing to align gengrid item to bottom of viewport.
Feature compleates and closes list of all alignment types for gengrid items.
Reviewers: seoz, cedric, SanghyeonLee
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D3452
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Add new scrollto type allowing to align genlist item to bottom of viewport.
Feature compleates and closes list of all alignment types for genlist items.
@feature
Test Plan: elementary_test => Genlist Show/Bring
Reviewers: cedric, seoz, SanghyeonLee
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D3447
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
An Eo class Elm.Sys_Notify acts as a manager of notification
servers. A manager registers and unregisters notification servers.
Notification servers implement the Elm.Sys_Notify_Interface
which allows to send and close notifications.
Currently, only the DBus server is implemented (legacy code).
Even though there are many changes in the code, there should
be no API nor ABI breaks.
Reviewers: naguirre, seoz, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3172
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
If the content object of genlist item is 'elm_layout' class,
minimum size cannot get directly becuase layout do the delay calculating.
So to make proper genlist size calc, before the swallowing,
forcely do the size calc about layout class contents in genlist.
@fix
Test Plan: N/A
Reviewers: raster, cedric, singh.amitesh, Hermet
Reviewed By: Hermet
Subscribers: seoz, conr2d, eagleeye
Differential Revision: https://phab.enlightenment.org/D3478
Summary:
It is useful for changing item's state according to shrink mode.
@feature
Test Plan:
It includes a use case for the patch in toolbar default theme.
Run "elementary_test -to toolbar2".
Reviewers: jaehwan, woohyun, cedric, raster
Subscribers: eagleeye
Differential Revision: https://phab.enlightenment.org/D3481
0 is a "valid" max size, so using it as the default value
results in a box being 0x0 if there are no explicit max size
hints set on any child objects
ref aef9d23550bbcd74829a5d75d5226ba394a9da87
tl;dr: if you haven't used aspect hints on objects packed into boxes,
this commit has no effect on anything you've done
in some cases, using weight+align hints are not sufficient in order to
do a simple box packing of objects.
one example of this is when a box's size is not explicitly determined,
such as if it is packed with EXPAND into another container and contains
only objects with no min size hint, such as images. in this case, the box
will determine that its min size is extremely small, resulting in nearly-hidden
contents inside the box.
using aspect hints, this outcome is noticeably different. the expanded/filled
potential size of a box item is used to calculate the aspected size, and this
size, if it fits within min/max constraints, is then used to calculate the min
size of the box.
as a more concrete example:
* create box with maximum size 100x50
* pack 2x image into box
- set VERTICAL aspect, EXPAND, FILL
have 2x 50x50 images
also I added some docs
@feature
valgrind pointed out an issue in elm cursor handling. this fixes that.
the handle was lost, yet it was still around due to it being
overwritten without deletion.
@fix
Seems these 2 functions are currently unused inside elm_calendar. For
now, let's just #if 0 them out
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
Summary:
This code is wrong and enforces developers to manipulate
resize_obj filed directly, instead of using elm_widget_resize_object_set.
Test Plan:
check if objects inheriting from elm_widget do not set field
directly.
Reviewers: cedric, raster, seoz
Subscribers: seoz
Projects: #elementary
Differential Revision: https://phab.enlightenment.org/D3362
Summary:
The default value of size_hint_min is 0, but in sizing_eval of
some elm widgets, default min value is set to -1.
Reviewers: cedric, Hermet
Reviewed By: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D3451
Summary:
Even doing almost same thihgs in inc_XXX fucntions, dec_XXX fucntion.
It was separated up.
So i merged those functions for code size reduce.
Test Plan:
Run elementary_test
Execute spinner sample.
Reviewers: cedric, Hermet
Differential Revision: https://phab.enlightenment.org/D3455
To configure elementary sources with bindings to use in nodejs add
––with-js=nodejs in configure flags in EFL compilation to generate
node files, then compile elementary normally:
path/to/efl$ configure --with-js=nodejs
path/to/efl$ make
path/to/efl$ make install
path/to/elm$ configure
path/to/efl$ make
path/to/efl$ make install
To use, you have to require elm:
elm = require('elm')
The bindings is divided in two parts: generated and manually
written. The generation uses the Eolian library for parsing Eo files
and generate C++ code that is compiled against V8 interpreter library
to create a elm.node file that can be required in a node.js instance.
@feature
Summary:
Fix to hide magnifier when menu is disabled
@fix
Test Plan:
1. Enable magnifier
2. Disable menu
3. Long press and mouse up
4. observe magnifier is not hidden.
Reviewers: tasn, herdsman, thiepha
Subscribers: shilpasingh
Differential Revision: https://phab.enlightenment.org/D3490
Summary:
The spinner buttons in elm_calendar widget can be replaced by elm_buttons.
Then, using elm_button widgets makes it much easier to maintain.
And the buttons has to be focusable with "tab" key just like elm_spinner widget.
The lagacy callbacks for signals from edje is not removed for backward compatibility.
@feature
Test Plan: elementary_test -> calendar, calendar2, calendar3
Reviewers: seoz, Hermet, kimcinoo, cedric, woohyun
Reviewed By: woohyun
Subscribers: CHAN
Differential Revision: https://phab.enlightenment.org/D3198
Summary:
Add newline filter
Using the present filter infra
a newline or paragraph separator filter
is being added for single line entry.
@fix
Test Plan:
Copy multiline text from
and paste it to single line entry.
it will fix T2660
Reviewers: herdsman, tasn
Subscribers: thiepha, DaveMDS
Maniphest Tasks: T2660
Differential Revision: https://phab.enlightenment.org/D3109
Summary:
The use of elm_widget_type_get here is pretty harmfull, for the usecase
of inheriting a widget elm_widget_type_get is something else than
before. But the key binding should still work.
@fix T2891
Reviewers: tasn
Reviewed By: tasn
Maniphest Tasks: T2891
Differential Revision: https://phab.enlightenment.org/D3470
this is handled correctly in evas. checking load errors from
the engine/loaders is sufficient, but the printed ERR messages
for these cases have been improved
partially reverts 865383aa0da5d1eb6d29f4ed5447a73f63800a33
reverts ee7d5425628942a45e23a2cb6be253db8ec0b3fd
ref 840dcc618ead292414b0de64a7a3ae38d778311f
ref a915229dc87606472480a8b2eacce9514055ac27
fix Titalia
Clean up elm_popup actions. Move actions should not be used
from accessibility API. Only dismiss seems to be resonable
action which could be triggered.
The selection is cleared by losscb when we set it.
As result, selection is not done.
To avoid it, we should check if the new selection owner
is current selection owner or not and only call losscb
if the new selection owner is not the current one.
Test Plan:
In wayland, select text in entry (e.g double click, ctrl-a).
Summary :
When genlist compressed, size width must updated after sizing eval,
but still hash is not changed after sizing eval, so wrong width are
applied.
so when sizing eval called, free all buckets to get updated width.
@fix
Summary:
previously, homogeneous was only supported for one type of items or group items,
so if user want to use various item styles with different height,
they should set homogeneous false.
This patch is increase usability of homogeneous to make possible homogeneous for
each item class, with the assumption that every item in same class have same height.
Now the item class not only define it's style and class funcitons, also define the
shape properties of item including height and width also.
@feature
Test Plan: Already exist test case in genlist group
Reviewers: raster, cedric
Differential Revision: https://phab.enlightenment.org/D3396
Summary:
Added a config variable Context_Menu_Disabled to make the appearance
of the context menu configurable.
@feature
Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>
Reviewers: Hermet, SanghyeonLee, raster, singh.amitesh
Subscribers: stefan_schmidt, alok25, cedric, thiepha, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2463
using a job results in the resize occurring after render in the same loop,
meaning that anything which depends on resizes to happen in a certain
time will not have synchronized display vs toolkit geometries
fixes all issues related to wayland window geometries
regions have not yet been calculated during RENDER_PRE, and commit
happens during the outbuf flush, so this callback should be the latest
possible time at which window geometry can be sent
Expected behavior: when Cancel or X is pressed in Filesector
don't change entry.
Wrong behavior: entry is cleaned.
If no file was selected 'file' variable is NULL,
and elm_entry_utf8_to_markup(NULL) returns empty string.
Thus this empty string was set to entry.
@fix
Item anchors can have null items likes <item size=10x10>. That is,
there is no "href". The problem is that Elm Entry segfaults as it
expects a non-null item. I prefer this fix over passing "" from Edje
Entry, and leave the decision to be made by Elm Entry. It will now just
show the error emoticon if there is no "href".
@fix
high should be the last item of the array, not the length of the array.
As part of this change, I also changed the code to use the better way of
getting the array size.
CID1339827
This whole code reeks. This generating and parsing strings as a value
store is hacky and could use an overhaul.
This just fixes the more obvious possible errors (that are maybe not
even possible, just look possible).
CID1339828
CID1339829
Emit accessibility events if slider value was chagned through API.
Moreover emit accessibility event more rarely if value is being
changed by the user.
Summary:
In _item_single_select_left/right functions if logic is corrected from && to ||.
The previous thing is like: if "there is a generation mismatch" and "item is
disable" then only get the next gengrid item. This seems logically incorrect.
The suggested logic is if "there is generation mismatch" OR "item disabled" then
go for the new item. Whether we get a generation mismatch or item disable, we
should look for next item. So there should be || logic instead of && logic.
@fix
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Reviewers: Hermet, raster, singh.amitesh, SanghyeonLee, cedric
Subscribers: cedric, sachin.dev
Differential Revision: https://phab.enlightenment.org/D3354
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The alignment of popup can be different in each profiles.
So I added the align configuration of popup.
@feature
Reviewers: cedric, woohyun
Differential Revision: https://phab.enlightenment.org/D3357
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Even if spinner's min max values range from -ve to +ve, it wasn't possible to enter
-ve values in spinner.
@fix T2915
Test Plan:
1. Launch Elementary Test
2. Launch spinner demo
3. Tap on the editable area of first spinner
4. Enter negative value
'-' is not allowed to enter even though the min max value of spinner ranges from -5000 to +5000.
Reviewers: CHAN, cedric
Reviewed By: cedric
Maniphest Tasks: T2915
Differential Revision: https://phab.enlightenment.org/D3403
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
As Elementary handles the window border theme, we can more accurately
set ecore_wl2 window geometry from here. The window geometry is
defined as the "visible bounds" from the user's perspective, so the
values we set here should come from the theme.
@fix
ref T2919
Signed-off-by: Chris Michael <cp.michael@samsung.com>
During _elm_config_sub_shutdown we were explicitly calling
ecore_wl2_shutdown. We should only be doing this if we are actually in
a wayland environment.
@fix
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
Summary:
Spinner on scroller case.
Scroll should be freeze when spinner button in long press state.
If not, the scolling will be started after delete longpress timer.
Like a other widgets, scroll not allowing is correct action for this.
@fix
Reviewers: jaehwan, Hermet, eagleeye, cedric
Differential Revision: https://phab.enlightenment.org/D3334
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Application set language using elm_language_set and when elm_language_set is called
language should be set to edje as well
@fix
Test Plan:
Call elm_language_set and check language should be set to
edje as well.
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3365
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Patch fixes issue when widgets could be orphaned in accessibility tree
due to overloaded accessible_children_get methods in widgets returning
Elm_Object_Items. Widgets like genlist, gengrid, list and toolbar returned
only items as its accessibility children so if some widget was attached
directly to those widgets (like ctxpopup/popup) it become orphaned
in accessibility tree.
Type API provides possibility to skip/ignore widgets in accessiblity
tree. It make sense to ignore object if it do not provide any valuable contextual
information for disabled users. Skipped objects are usually container objects
and are ommited in parent-child relationship.
@feature
In Elm_Cnp, a markup data preparer was missing, which resulted
in _x11_notify_handler_targets not requesting
"application/x-elementary-markup" (requested "UTF8_STRING" instead) when
trying to paste markup text from one entry to another (or itself).
Also, there was a missing handling in the selection data callback for
ELM_SEL_FORMAT_MARKUP data format.
This fixes issues like not being able to paste "item" formats to the
entry widget.
@fix
We have to use void in a function declaration if we want no function
parameters. Using just empty parenthesis means the function takes an
unspecified number of parameters.
We had it correct for most declarations and this series fixes it for
the rest.
Thanks for the sparse semantic parser for pointing this out.
Summary:
If the entry is a single line, rather than return the cursor height,
it is better to return the height of the object.
Reviewers: herdsman, tasn
Differential Revision: https://phab.enlightenment.org/D3169
Summary:
When _elm_theme_set() failed to set given style, it sets style
as "default".
However, setting style to "default" can be unintended behavior,
so developer should have the chance to get to know fallback.
Reviewers: cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3352
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
This is for support dynamically field sequence changing case
for example
User sets datetime format as "%d/%b/%y" first.
Then change the format dynamically in runtime to "%I:%M %p"
Previous format datetime items still there.
It breaks view(object dulicated on same geometry)
@fix
Test Plan:
Run datetime sample.
Add changed callback.
Change format in changed callback function.
Check the bug state.
Reviewers: jaehwan, id213sin, Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3340
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
To prevent pasted markup text in entry.
User want tags removed text when paste text into entry.
@fix
Reviewers: jaehwan, Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3333
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
There is no need ellipsis, space as well before "%d".
The "%d" will show the actual invisible item count.
@fix
Reviewers: jaehwan, Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3332
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
This feature has been added long time ago but it never worked before.
I delayed the parent object hide call when hide signal is present
in theme.
Test:
1. elementary_test -to notify
2. Click Left and wait for timer to expire
3. Click Left and click "close" button on notify. Now hide animation
happens when notify hides.
@fix
Unprotect methods which are ment to be a part of public API.
This methods were initially unprotected, however it looks like
during eo refactoring @protect tags were added by mistake.
@fix
Summary:
If item is unselected in a selected function,
selected function will be called once more from _elm_gengrid_elm_widget_on_focus.
It is happened when elm_gengrid object has no focus and one of item is selected by mouse up event.
To fix this issue, we need to set focus to item and keep the address of selected item before calling selected function.
@fix
Test Plan:
1. Install & Run efbb (Escape From Booty Bay: https://git.enlightenment.org/games/efbb.git/)
2. Select a level in the main menu. (It is using elm_gengrid).
3. See duplicated target images.
Reviewers: cedric, SanghyeonLee
Reviewed By: SanghyeonLee
Differential Revision: https://phab.enlightenment.org/D3323
Summary:
Keep cursor at inserted position after dnd.
For good user experience, after dnd users expect
the cursor should be at the last inserted position.
@feature
Test Plan: NA
Reviewers: thiepha, herdsman, cedric, tasn
Subscribers: shilpasingh
Differential Revision: https://phab.enlightenment.org/D3267
Eina module errors are printed on the screen when the library is not
installed in the system and Clouseau debug is enabled.
The module pointer is not NULL checked, leading to an error message when trying
to load this NULL module.
@fix
Summary:
1. If the sd->items list is empty any time and container_get is used on filter iterator, it will lead to crash. Solution is to not rely on sd->items and maintain a pointer to container when iterator is created.
2. There was a typo while filter feature was added earlier. Fixed it
@fix
Test Plan: NA
Reviewers: SanghyeonLee
Reviewed By: SanghyeonLee
Subscribers: rajeshps, shilpasingh
Differential Revision: https://phab.enlightenment.org/D3319
Summary:
When spinner activated with entry, user can input any characters in entry.
It degrades the usability.
Add filter for only can input numbers and "." for case of decimal point existing.
I will add entry filter for limit size as well after this commit.
This spinner features may help for app developer and users too.
@feature
Test Plan:
Run elementary_test
Test various spinner format for check this.
Reviewers: Hermet, cedric
Subscribers: id213sin, shilpasingh
Differential Revision: https://phab.enlightenment.org/D3299
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
When an Elm_Segment_Control object is created, the constructor calls
the smart_add() behind the scenes. It then calls _update_list() which
calls _position_items(), with the sd->obj unset (because it was set
after calling super constructors). This led to a CRI() (and therefore
to a backtrace) on the creation of each Elm_Segment_Control.
@fix
Test Plan: elementary_test
Reviewers: stefan_schmidt, cedric, raster
Differential Revision: https://phab.enlightenment.org/D3276
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Avoid code duplication
Two dismissal signals at two different places
created some confusion and also code is duplicated.
Also removed some extra space.
Test Plan: NA
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3269
Summary: elm_genlist_first_item_get(), elm_genlist_last_item_get(), elm_genlist_item_prev_get(), elm_genlist_item_next_get() should return the next filtered item if filter is applied on the genlist.
Test Plan: test_genlist.c => Genlist Filter demo updated
Reviewers: shilpasingh, cedric, SanghyeonLee
Subscribers: divyesh, rajeshps
Differential Revision: https://phab.enlightenment.org/D3263
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
An application starts before the indicator has. In this case,
the application should try to connect again with the indicator.
Test Plan:
1. Start an application without the indicator service.
2. Start the indicator service.
Reviewers: raster, Hermet, woohyun, jaehwan, cedric
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D3258
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
1. When subtitle is set using actual part name "elm.text.subtitle",
subtitle,show signal is not sent issue fix.
2. Remove unnecessary checks, maintain code readability.
@fix
Test Plan:
Set text using edc part name elm.text.subtitle
Reviewers: Hermet, cedric
Reviewed By: cedric
Subscribers: shashank0990
Differential Revision: https://phab.enlightenment.org/D2988
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The box_clear, box_fill internal functions called when almost every internal chage happend.
(resize, theme apply, item append, item delete etc...)
Then those APIs delete/create item's edje object for all of the items.
It's very not good action for performance.
So, i changed this just edje object box unpack/pack instead of delete/create.
@fix
Test Plan:
Working test on elementary_test
and Call all of the index APIs for check this change.
Reviewers: Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3268
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
It is an legacy of old code. When the view object of item was edje,
I think there was no meaningless parent-child relationship changes.
But, now, the view object is elm_layout and if we add object in proper order,
we don't need to make an useless parent-child realationship in any moments.
Test Plan: None
Reviewers: woohyun, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3254
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The icon is already sub object of VIEW(item) by content_set.
We don't need to make icon as a sub object of obj again.
It was used when VIEW(item) is Edje object.
Test Plan: None
Reviewers: Hermet, eagleeye, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3249
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Issue: When accessibility is set, individual color item's RGBA values are read
instead of actual color names.
Solution: Read color names by matching the color RGBA from the array.
Test Plan:
enable accessibility
run elementary test
select colorselector demo
click on individual color palette items
Reviewers: cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3240
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Subodh Kumar
Jean-Philippe Andre
Andy Williams
Divyesh Purohit
Davide Andreoli
Chris Michael
Jaehyun Cho
divyesh purohit
Cedric BAIL
SangHyeon Lee
Jee-Yong Um
Minkyu Kang
Hermet Park
Amitesh Singh
Stefan Schmidt
Mike Blumenkrantz
Tom Hacohen
Carsten Haitzler
Stephen okra Houston
Jean Guyomarc'h
woochan lee
Youngbok Shin
Lukasz Stanislawski
taehyub
Vincent Torri
Felipe Magno de Almeida
Shinwoo Kim
Marcel Hollerbach
Thiep Ha
Sung-Taek Hong
Vaibhav Gupta
Yakov Goldberg
Daniel Hirt
Umesh Tanwar
Shilpa Singh
Chris Michael
Jean Guyomarc'h
Nicolas Aguirre
indefini
Daniel Zaoui
shashank.p
godly.talias
Hosang Kim