Summary:
In _item_single_select_left/right functions if logic is corrected from && to ||.
The previous thing is like: if "there is a generation mismatch" and "item is
disable" then only get the next gengrid item. This seems logically incorrect.
The suggested logic is if "there is generation mismatch" OR "item disabled" then
go for the new item. Whether we get a generation mismatch or item disable, we
should look for next item. So there should be || logic instead of && logic.
@fix
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Reviewers: Hermet, raster, singh.amitesh, SanghyeonLee, cedric
Subscribers: cedric, sachin.dev
Differential Revision: https://phab.enlightenment.org/D3354
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The alignment of popup can be different in each profiles.
So I added the align configuration of popup.
@feature
Reviewers: cedric, woohyun
Differential Revision: https://phab.enlightenment.org/D3357
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Even if spinner's min max values range from -ve to +ve, it wasn't possible to enter
-ve values in spinner.
@fix T2915
Test Plan:
1. Launch Elementary Test
2. Launch spinner demo
3. Tap on the editable area of first spinner
4. Enter negative value
'-' is not allowed to enter even though the min max value of spinner ranges from -5000 to +5000.
Reviewers: CHAN, cedric
Reviewed By: cedric
Maniphest Tasks: T2915
Differential Revision: https://phab.enlightenment.org/D3403
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
As Elementary handles the window border theme, we can more accurately
set ecore_wl2 window geometry from here. The window geometry is
defined as the "visible bounds" from the user's perspective, so the
values we set here should come from the theme.
@fix
ref T2919
Signed-off-by: Chris Michael <cp.michael@samsung.com>
During _elm_config_sub_shutdown we were explicitly calling
ecore_wl2_shutdown. We should only be doing this if we are actually in
a wayland environment.
@fix
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
This is a merge of branch 'devs/devilhorns/ecore_wl2' that ports
Elementary to use the new Ecore_Wl2 library. This port allows for
improved time to first frame, reduced input latency, and proper
support for xdg window geometry.
@feature
This change will hide the cursor once there is an actual change, and
there is a difference between the selection cursors. If there is no
difference, then it is better to show the cursor again.
Summary:
Spinner on scroller case.
Scroll should be freeze when spinner button in long press state.
If not, the scolling will be started after delete longpress timer.
Like a other widgets, scroll not allowing is correct action for this.
@fix
Reviewers: jaehwan, Hermet, eagleeye, cedric
Differential Revision: https://phab.enlightenment.org/D3334
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Application set language using elm_language_set and when elm_language_set is called
language should be set to edje as well
@fix
Test Plan:
Call elm_language_set and check language should be set to
edje as well.
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3365
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Patch fixes issue when widgets could be orphaned in accessibility tree
due to overloaded accessible_children_get methods in widgets returning
Elm_Object_Items. Widgets like genlist, gengrid, list and toolbar returned
only items as its accessibility children so if some widget was attached
directly to those widgets (like ctxpopup/popup) it become orphaned
in accessibility tree.
Type API provides possibility to skip/ignore widgets in accessiblity
tree. It make sense to ignore object if it do not provide any valuable contextual
information for disabled users. Skipped objects are usually container objects
and are ommited in parent-child relationship.
@feature
The test_colorclass function (and prototype) were incorrect in that
they did not have the proper function parameters defined. This lead to
a warning when building elementary tests.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
In Elm_Cnp, a markup data preparer was missing, which resulted
in _x11_notify_handler_targets not requesting
"application/x-elementary-markup" (requested "UTF8_STRING" instead) when
trying to paste markup text from one entry to another (or itself).
Also, there was a missing handling in the selection data callback for
ELM_SEL_FORMAT_MARKUP data format.
This fixes issues like not being able to paste "item" formats to the
entry widget.
@fix
We have to use void in a function declaration if we want no function
parameters. Using just empty parenthesis means the function takes an
unspecified number of parameters.
We had it correct for most declarations and this series fixes it for
the rest.
Thanks for the sparse semantic parser for pointing this out.
We have to use void in a function declaration if we want no function
parameters. Using just empty parenthesis means the function takes an
unspecified number of parameters.
We had it correct for most declarations and this series fixes it for
the rest.
Thanks for the sparse semantic parser for pointing this out.
We have to use void in a function declaration if we want no function
parameters. Using just empty parenthesis means the function takes an
unspecified number of parameters.
We had it correct for most declarations and this series fixes it for
the rest.
Thanks for the sparse semantic parser for pointing this out.
Summary:
The function evas_object_resize(win, 480, 800) was being called after evas_object_show(popup)
so size calculations of popup were going wrong(height was 0).
It should be called before creating popup as win is parent of popup,
This fix needs to be done only here as in other cases window is already present before creating popup
but here both are being created for exmaple purposes.
Signed-off-by: Aditya Raj <aditya1.raj@samsung.com>
Reviewers: singh.amitesh, raster
Subscribers: jpeg, tanwar.umesh07, sachin.dev
Differential Revision: https://phab.enlightenment.org/D3360