Jupp, its a dirty hack but it helps to work around the problem for now and
get the release out. I will revert it in master after the release and we
keep the bug open until this is fixed and hopefully backported.
ref T2367
This should be a proper fix for T1717. Idea is that we build a list of operation
that needs to be deferred in order (including pop and push) so that we are sure
we can pop and push in any order without the need to wait for any event.
Changed all the callback_call to pass the correct Elm_Object_Item
(Eo) pointer, was passing Elm_Slideshow_Item_Data instead.
@fix
Also updated the test
Summary:
If current item is disabled, next item should be
taken.
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
@fix
Reviewers: raster, Hermet
Subscribers: singh.amitesh, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2458
Summary:
fix the _item_multi_select_down() function for
ELM_OBJECT_SELECT_MODE_DISPLAY_ONLY select_mode.
_item_multi_select_up is right, but _item_multi_select_down is wrong.
So fixed this.
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
@fix
Reviewers: Hermet, raster
Reviewed By: raster
Subscribers: sachin.dev, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D2452
Summary:
After discussion with DaveMDS, D2402 is a wrong fix and must be reverted.
This reverts commit a7978f931a4b67820b6b65758ce6f362c1ebec70.
Reviewers: cedric, DaveMDS
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D2437
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
When content is resized, scrollbar's position is not updated.
Add bar position update after bar size is changed.
Test Plan: elementary_test -> scroller3
Reviewers: seoz, jaehwan, woohyun, cedric, raster, kimcinoo, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2419
Summary:
incorrect evas_object_box_children_get usage: returned list must be freed
@fix
Reviewers: cedric, seoz, raster, reutskiy.v.v, Hermet
Differential Revision: https://phab.enlightenment.org/D2412
Summary:
1.) Fixing defective label position.
Whenever user create multibuttonentry and set some text into label,
label will be shown at zero point (0,0) of MultiButtonEntry parent.
But then, after clicking on any button of MBE object, label position forced to
be recalculated and changes it's position.
2.) Fixing wrong size when label is not used.
When label is not being used, buttons shift by few pixels,
and it looks like if label is actually there, which is wrong.
@fix
Reviewers: cedric, seoz, raster, reutskiy.v.v, Hermet
Reviewed By: Hermet
Subscribers: NikaWhite
Differential Revision: https://phab.enlightenment.org/D2416
Summary:
The entry inactive signal emitted when finish spinner value set.
but the active signal emitted after that. so it makes weird view state.
The function 'key_action_toggle()' called twice. (for entry, spinner)
event propagate called this func twice and its make this issue.
This patch makes to ignore toggle event when entry is not visible.
T2262
Test Plan:
Run elementary_test, execute spinner widget sample.
Click the first spinner.
Input something on entry.
Press enter key.
Check the issue.
Reviewers: raster, Hermet
Subscribers: kuuko
Differential Revision: https://phab.enlightenment.org/D2411
Summary:
There is a invisible prev button. but it can get a focus and delete the current naviframe item.
Its not intend to added here i think, so i add a function that not add prev button automatically.
Test Plan:
Run elementary_test -> Naviframe Complex
Move focus use arrow key button and input enter key on prev button.
Click the View list, check the ERR msgs.
Reviewers: Jaehyun, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2420
Summary:
While setting theme currently changes style and theme to all button and
whole multibuttonentry object, it doesn't change few other parts of this object.
Part are, for examples, "guidetext", "label" and "closedbutton".
Fixing this sad mistake leads to be able to create different styles for such
wonderful widget.
@fix
Reviewers: cedric, seoz, raster, reutskiy.v.v, Hermet
Reviewed By: Hermet
Subscribers: NikaWhite
Differential Revision: https://phab.enlightenment.org/D2407
Summary:
Reloading image in zoom in/out only if its previous orientation was changed
@fix
Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: jpeg, raster, cedric
Differential Revision: https://phab.enlightenment.org/D2402
Summary:
Even if the given Evas_Object is NULL, API returns ELM_INPUT_PANEL_LAYOUT_NORMAL.
But, ELM_INPUT_PANEL_LAYOUT_INVALID seems proper in that case.
Test Plan:
Call the following API with NULL.
elm_entry_input_panel_layout_get(NULL);
Reviewers: woohyun, Hermet, eunue
Reviewed By: eunue
Differential Revision: https://phab.enlightenment.org/D2404
Summary:
Currently zoom in/out rotated or flipped image was causing lost of orientation
and aspect of image is also changed. Fixed that by reloading image on pan_obj on zoom
@fix
Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: DaveMDS, jpeg, cedric, raster
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D2381
Summary:
In case of mirror enabled, wanted x should come from _elm_scroll_x_mirrored_get().
This defect is visible in case of some fancy effects on scroller (map).
@Fix
Reviewers: raster, Hermet
Subscribers: herdsman, sachin.dev, kimcinoo, eagleeye, seoz
Differential Revision: https://phab.enlightenment.org/D2363
when insert a new item before/after an item, the relative item should not be NULL.
this patch fixes naviframe, gengrid, genlist, list, and toolbar.
@fix
Tom Hacohen
Chris Michael
Stefan Schmidt
Cedric BAIL
Lukasz Stanislawski
Davide Andreoli
Sung-Taek Hong
Umesh Tanwar
Amitesh Singh
kabeer khan
Hosang Kim
Andrii Kroitor
Vitalii Vorobiov
Woochan Lee
Vaibhav Gupta
Jee-Yong Um
Youngbok Shin
Mike Blumenkrantz
Jaeun Choi
ChunEon Park