Commit Graph

56455 Commits

Author SHA1 Message Date
Marcel Hollerbach 67188ba22b efl_ui_focus_manager: emit callbacks after stack change
fix T6389
2017-11-20 09:13:08 +01:00
Marcel Hollerbach 87900a97d0 efl_ui_focus_manager_sub: remove event callback array when destructing
i forgot about that and this leads to a segfault in enlightenment, the
object then segfaults when the parent manager emits a event and then the
code tries to access the private data of a dead object.
2017-11-20 09:13:08 +01:00
Jean-Philippe Andre 50fde448fb eldbus: "fix" make check
As Cedric told me, eldbus_suite now fails on this line, where somehow
the properties array contains 2 elements, instead of 0 as expected. It
seems that the change is not related to EFL, but a new package on our
systems.

With d-feet (a dbus inspection tool), I can see two properties under:
 org.freedesktop.DBus
   /org/freedesktop/DBus or /
     org.freedesktop.DBus
       Properties
         Features
         Interfaces

Has anyone a better clue what's happening?
2017-11-20 12:31:13 +09:00
Pawel Aksiutowicz 63f8071c7d evas: fix typos in canvas/evas_object_textblock
Reviewers: lukasz.stanislawski, stanluk, jpeg

Reviewed By: lukasz.stanislawski

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5456
2017-11-20 12:03:52 +09:00
Lukasz Stanislawski 2f294aeb88 elm: add "activate" action to ctxpopup items
Summary: Change-Id: I0974c3bec02a05d3d46d7cc0fd86572e32248a3b

Subscribers: jenkins, cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5493
2017-11-20 12:03:29 +09:00
Lukasz Stanislawski 26e49ca562 elm: overload access children getter
Subscribers: jenkins, cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5482
2017-11-20 12:03:04 +09:00
Bryce Harrington cc14a1288c eina: Indicate in and out parameters for eina_matrix
Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5496
2017-11-20 12:02:24 +09:00
Pawel Aksiutowicz cb2ba05675 elementary: fix typos
Reviewers: stanluk, lukasz.stanislawski

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5494
2017-11-20 11:54:52 +09:00
Marcel Hollerbach b27944da08 elm_list: use internal focus set instead of public focus set
elm_object_item_focus_set ensures that the list also gets focus, thus calling
that in _elm_list_elm_widget_on_focus_update would result in a infinite
call recursion, if setting the focus fails (for example when the object
is not visible yet, [see enlightenment for that]).

This fixes a freeze if you open lunchers config.
2017-11-19 11:08:36 +01:00
Derek Foreman 796de8cb86 wayland_shm: Don't use a fixed number of buffers
We no longer allocate 3 buffers at startup, we now allocate only as needed.

Trimming the queue will come later, as there are some situations where we
might need 3 buffers and later drop down to 2 (when on a hardware plane)

Most clients will only ever need 2 buffers, so this is a reasonable RAM
savings.
2017-11-17 14:33:36 -06:00
Derek Foreman 04ce069cba ecore_wl2: Properly handle buffer test failure during buffer_init
The buffer manager is already cleaned up at this point, don't try to
do it again.
2017-11-17 14:32:50 -06:00
Cedric Bail 7821367b1a eina: properly initialize EINA_ERROR_VALUE_FAILED. 2017-11-17 11:12:06 -08:00
Cedric Bail 7cfb9e00ed eina: properly initialize EINA_ERROR_NOT_MAIN_LOOP. 2017-11-17 11:11:48 -08:00
Cedric Bail 574d4526cb eina: properly initialize EINA_ERROR_MAGIC_FAILED. 2017-11-17 11:11:28 -08:00
Cedric Bail 8fbd8bfe2a eina: fail with an Eina_Error on copy failure. 2017-11-17 10:44:26 -08:00
Marcel Hollerbach 56522f19ff efl_ui_focus_manager_sub: do not specify a interface as first argument
this leads in eo to the meaning that the manager.sub is giving
implementations to that interface, but leaving the ->func with NULL,
which leads on some maschines to the assumation that this is
pure_virtual, which means not composition objects will be queried, on
other maschines this will work, since there other inherits will
overwrite this entry and set ->src to NULL.

While i still dont understand why this works on some maschines and does
not on others, this is is now fixed.
2017-11-17 16:08:14 +01:00
Marcel Hollerbach b93e744e1f elm_widget: simplify code
there is now a utility function
2017-11-17 16:08:14 +01:00
Marcel Hollerbach 2ba64efe62 Eo: be a bit more detailed in the docs
this is completly not obvious. But now its documented.
2017-11-17 16:08:14 +01:00
Marcel Hollerbach 19cb57d914 efl_ui_focus_manager_calc: efl_wref_del deletes the wref
A happy thank you goes to the doc for leaving this trivial peace of
information undiscovered!

Followup commit will fix this
2017-11-17 16:08:14 +01:00
Marcel Hollerbach ffca5284ae efl_ui_focus_manager:do not followup if we have not changed candidate
_followup_previous_direction should only be called if there was a real
change to the redirect. In was happening that we have not changed the
focus but called _followup_previous_direction, which lead to weird focus
changes.
2017-11-17 16:08:14 +01:00
Marcel Hollerbach f8badf1c06 elm_widget: remove focus set
calling this function was not working at all, so its gone now
2017-11-17 16:08:14 +01:00
Marcel Hollerbach 84a6a329fe elementary: stop using elm_widget_focus_set 2017-11-17 16:08:14 +01:00
Marcel Hollerbach 6daff0e6f4 elm_main: checking the redirect chain is not neccessery
the manager is in or has no focused element
2017-11-17 16:08:14 +01:00
Marcel Hollerbach 1e5c894a1b elm_main: replace _elm_object_focus_set with efl_ui_focus_util_focus 2017-11-17 16:08:14 +01:00
Marcel Hollerbach 4086f18ebf efl_ui_focus_manager_calc: error if a element is not registered yet 2017-11-17 16:08:14 +01:00
Marcel Hollerbach 2e6a08737d efl_ui_focus_object: emit changed event after the flag gets set
otherwise new efl_ui_focus_object_focus_get calls could be confused.
2017-11-17 16:08:14 +01:00
Marcel Hollerbach 738cb8a2bb efl_ui_focus_util: add a util class
the util class is for common code that is just added again and again.
2017-11-17 16:08:14 +01:00
Andrii Kroitor c37226ef5e elm_genlist: fix rare segfault
Conditions:
- style is "double_label"
- the is some content for items (i.e elm_label)
- elm_genlist_filter set was once called after genlist creation with
  NULL data
- label_get callback uses elm_genlist_item_prev_get on its current item
- at least one item is added as a sub-item
- ~2 blocks of items are added afterwards
- items are added quickly while holding 'enter' on an elm_button

@fix
2017-11-17 10:16:41 +02:00
Amitesh Singh 35f3019a6d Efl.Ui.Slider: add default indicator format to %0.2f
This was broken in legacy code as well.
Thanks to @taxi2se for reporting.

elm_test -> slider -> check vertical slider

@fix
2017-11-17 14:55:51 +09:00
Amitesh Singh 19e70a8e1f Efl.Ui.Slider: replace default with on_drag in visible_mode enum.
Ref T6376
2017-11-17 14:38:32 +09:00
Amitesh Singh 651d9e94a0 Efl.Ui.Slider: add visible_mode() as an indicator part API
Ref T6376
2017-11-17 14:38:32 +09:00
Amitesh Singh 67996afbf6 Efl.Ui.Slider: make indicator_visible_mode() legacy APIs
Ref T6376
2017-11-17 14:38:32 +09:00
Amitesh Singh 77164413cd Efl.Ui.Slider: make indicator_show_on_focus/indicator_show() legacy APIs
Ref T6376
2017-11-17 14:38:32 +09:00
Jean-Philippe Andre 28d74624ec tests/eldbus: Use different bus for cxx and C tests
I had eldbus_suite and eldbus_cxx_suite fail quite often for some
strange reason: name already in use... yeah but by who??? Turns out both
test cases used the same name, and when ran in parallel (make -j10
check) this would often fail.
2017-11-17 11:57:15 +09:00
Jean-Philippe Andre bae51a0612 tests: Add better debugging for eldbus failure
It keeps on failing for me, but quite inconsistently (i.e. sometimes,
not always). Annoying.
2017-11-17 11:57:15 +09:00
Shilpa Singh e58e00b08a elm_index: Index item role modify
Summary:
Modified index item role to EFL_ACCESS_ROLE_RADIO_MENU_ITEM from EFL_ACCESS_ROLE_PUSH_BUTTON
as index item should maintain its current state.

Test Plan:
Query the role of index item from atspi client, ATSPI_ROLE_RADIO_MENU_ITEM role should
be returned.

Reviewers: kimcinoo

Reviewed By: kimcinoo

Subscribers: cedric, govi, rajeshps, jpeg

Differential Revision: https://phab.enlightenment.org/D5486
2017-11-17 10:18:18 +09:00
Derek Foreman 1bd513305e ecore_wl2: fix user pointer for dmabuf param listener
Proving once again that those that defeat type safety usually get what
they deserve.
2017-11-16 13:18:48 -06:00
Derek Foreman 925be86f9e ecore_wl2: Fix dmabuf test failure
We need to destroy the buffer manager on fail, since it will exist but
only be able to create buffers we can't actually use.
2017-11-16 13:18:48 -06:00
Derek Foreman c08920820b ecore_wl2: Don't try to close drm_fd if we never opened it
derp.
2017-11-16 13:13:38 -06:00
Andy Williams 63c6724f08 eina: fix docs for manage_read_only_new 2017-11-16 12:49:56 +00:00
Jean-Philippe Andre 313eb563b5 win: Rename specific APIs to avoid clashes
This renames 3 basic APIs specific to Win:
 - name
 - type
 - role

Ref T5322
2017-11-16 19:11:51 +09:00
Lukasz Stanislawski 57e0d19c45 elm: return Efl.Access.Actions only if action_area is not set
Summary:
The accessibility clients should not have a possibility
to dismiss popup in case when action area is set.

Reviewers: jpeg

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5481
2017-11-16 18:17:49 +09:00
Shilpa Singh 54657b0a95 elm_index: Send selected signal to atspi client
Summary: When Index item is selected, notify atspi clients.

Test Plan:
when atspi mode is enabled, item selection notification
should be received by atspi client

Reviewers: kimcinoo

Subscribers: cedric, govi, rajeshps, jpeg

Differential Revision: https://phab.enlightenment.org/D5485
2017-11-16 18:17:49 +09:00
Lukasz Stanislawski 989f6c27d2 elm: enhance access name for spinner
Summary: Try to take access name from internal entry object or text button first.

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5480
2017-11-16 12:12:04 +09:00
Lukasz Stanislawski 20c9dd1e84 elm: add Efl.Access.Value interface to progressbar
Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5479
2017-11-16 12:05:21 +09:00
Jean-Philippe Andre e9ebe5c676 elm: Define and rename internal atspi struct in EO
This thing is used by only 2 EO APIs that are marked as @beta. I wonder
if the @beta tag or the ptr() expression made it work for eolian,
because it simply wasn't defined in EO.

I'm renaming it just so that it's more consistent with the new names
used by atspi (and EO API in general).
2017-11-16 12:00:18 +09:00
Lukasz Stanislawski c838e30a24 elm: Rename elm_interface_atspi_widget_action mixin
Reviewers: jpeg

Subscribers: jenkins, cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5400
2017-11-16 12:00:18 +09:00
Cedric Bail 30adccd6a2 elementary: make sure that ecore shutdown match ecore init. 2017-11-15 16:29:14 -08:00
Cedric Bail babcb0f1e4 elementary: do not send a PAUSE event if not iconified. 2017-11-15 16:29:14 -08:00
Cedric Bail 1112ce2a8a ecore: should be the one triggering EFL_LOOP_EVENT_TERMINATE. 2017-11-15 16:29:14 -08:00