Commit Graph

115 Commits

Author SHA1 Message Date
Michal Jagiello 3491137bdb From: Michal Jagiello <>
Subject: [E-devel] [PATCH][ETHUMB] Null checks and checks if divisor
is not equal to zero in ethumb.c file

In functions ethumb_calculate_aspect_from_ratio,
ethumb_calculate_fill_from_ratio, ethumb_plugin_image_resize and
ethumb_image_save Ethumb object is not checked if is NULL, what can cause
segmentation fault.
In functions ethumb_calculate_aspect and ethumb_calculate_fill divisor is
not checked if is equal to zero before division.

SVN revision: 77736
2012-10-10 09:31:25 +00:00
Daniel Juyung Seo e430627e7e ethumb ethumb.c: Fixed indentation.
SVN revision: 77233
2012-10-01 04:43:39 +00:00
Daniel Juyung Seo 1e38f04bfc ethumb ethumb.c: Fixed wrong return value. Return EINA_FALSE when there is no theme_file on ethumb_frame_set. Spotted by Patryk Kaczmarek <>
SVN revision: 77232
2012-10-01 04:43:35 +00:00
Carsten Haitzler 0e77364887 update header #defined versions to 1.8 to make sure new apis are used
in e17 only with ifdefs.

SVN revision: 75994
2012-09-03 09:55:34 +00:00
Carsten Haitzler 19af039b30 add missing EAPI's for ethmub.c for symbols exposed to ethumb plugins.
SVN revision: 75843
2012-08-30 07:42:35 +00:00
Carsten Haitzler aef32ed6d3 more updates for 1.7.0 alpha.
SVN revision: 75095
2012-08-10 10:51:17 +00:00
Mike Blumenkrantz a7d136e964 formatting
SVN revision: 72176
2012-06-15 08:51:07 +00:00
Carsten Haitzler 318bd30043 This is a small change, so I won't changelog it (or backport), but
make _shutdown() funcs across efl complain and be unhappy if you
shutdown to < 0 shutdowns and not pull init count below 0.

SVN revision: 71548
2012-05-30 10:08:41 +00:00
Vincent Torri 6ce3dfc3e3 Ethumb: Patch that fixes:
warning: Tag `DETAILS_AT_TOP' at line 163 of file Doxyfile has become obsolete.
To avoid this warning please update your configuration file using "doxygen -u"
/tmp/ethumb/src/lib/client/ethumb_client.c:1597: warning: argument 'f' of command @param is not found in the argument list of ethumb_client_orientation_set(Ethumb_Client *client, Ethumb_Thumb_Orientation o)
/tmp/ethumb/src/lib/client/ethumb_client.c:1597: warning: The following parameters of ethumb_client_orientation_set(Ethumb_Client *client, Ethumb_Thumb_Orientation o) are not documented:
 parameter 'o'
/tmp/ethumb/src/lib/client/ethumb_client.c:1752: warning: return type of member ethumb_client_frame_set is not documented

Patch by Jérôme Pinot

SVN revision: 69826
2012-04-01 05:33:25 +00:00
Carsten Haitzler 63ed6ac02f gear up svn for release. one of many steps/things to do.
SVN revision: 69481
2012-03-17 04:17:29 +00:00
Thanatermesis 4776bcfbd7 Fix linking complaints brought out by:
From: Thanatermesis <>
Subject: [E-devel] LDFLAGS with -Wl,-z,defs

Aparently if you add the option "-Wl,-z,defs" to your LDFLAGS, there's some
libs that doesn't compile, like evas and e_dbus, there's some logs:

SVN revision: 68464
2012-02-27 05:20:17 +00:00
Cedric BAIL 122b8d9f98 ethumb: reorder parameter to match other EFL callback API.
SVN revision: 66608
2011-12-28 16:27:08 +00:00
Cedric BAIL 521c66c9e5 ethumb: make plugin API fully assynchronous and use it in emotion backend.
NOTE: epdf isn't asynchronous at the moment, so no need to fix its ethumb plugin.

SVN revision: 66607
2011-12-28 16:10:10 +00:00
Vincent Torri 23043ed40e Ethumb: source files should have their names with lower case letters
SVN revision: 65948
2011-12-06 06:50:10 +00:00
Vincent Torri 4d5063985b Ethumb: formatting, fix future compilation on Windows
SVN revision: 65946
2011-12-06 06:31:45 +00:00
Vincent Torri cb1efe97d8 Ethumb: remove and move header file
SVN revision: 65942
2011-12-06 05:32:35 +00:00
Vincent Torri 44c9a67c69 Ethumb: remove unused macro
SVN revision: 65941
2011-12-06 05:27:13 +00:00
Vincent Torri 621382a899 Ethumb: fix future compilation on Windows
SVN revision: 65940
2011-12-06 05:21:30 +00:00
Cedric BAIL 70af557501 ethumb: provide facility using Ecore_Idler.
SVN revision: 65781
2011-12-01 15:37:21 +00:00
Sanjeev BA d33324ebc1 Fix compile error due to missing assert.h.
Signed-off-by: Sanjeev BA <>

SVN revision: 65665
2011-11-29 00:40:11 +00:00
Cedric BAIL 12285a5f4f ethumb: cleanup API.
SVN revision: 65660
2011-11-28 23:24:32 +00:00
Michael BOUCHAUD fc413bec7a ethumb: set explicitly alpha on, which allows us to fix the thumbnails with transparent backgrounds
SVN revision: 64735
2011-11-04 14:50:47 +00:00
Vincent Torri f392fc315c ethumb: add some linker and preprocessor flags, patch by Philippe Reynes, a bit modified by myself
SVN revision: 64529
2011-10-30 18:02:41 +00:00
Cedric BAIL 8385a7dec0 ethumb: fix wrong dirty detection.
Patch by SANS Mikael <>.

SVN revision: 63021
2011-08-31 09:28:54 +00:00
Cedric BAIL 77851c1891 ethumb: fix race condition and memory leak.
NOTE: that's a first obvious patch thanks to Gustavo reviews.
More work needed, but some decision should be discussed first.

SVN revision: 62265
2011-08-09 20:36:28 +00:00
Christopher Michael d39b302cee Ethumb: Add a bunch of UNUSED where needed.
SVN revision: 61622
2011-07-23 23:12:55 +00:00
Cedric BAIL 0408408e2a ethumb: fix various source of misusage.
SVN revision: 60760
2011-06-28 14:35:21 +00:00
Cedric BAIL 563fbf97f2 eina: update Eina_Refcount API to please Tasn.
SVN revision: 60592
2011-06-22 14:04:09 +00:00
Cedric BAIL f8e35bf8de ethumb: request file information early to avoid loosing them.
SVN revision: 59865
2011-06-01 13:04:41 +00:00
Cedric BAIL 191c79c9e1 ethumb: break API to fix race condition during cancel.
SVN revision: 59846
2011-05-31 16:14:26 +00:00
Cedric BAIL c958177e51 ethumb: use Eina_Refcount.
SVN revision: 59039
2011-04-29 16:09:45 +00:00
Cedric BAIL 88745904b4 ethumb: cache exists result.
SVN revision: 59017
2011-04-28 17:00:13 +00:00
Cedric BAIL c5b107f144 ethumb: use xattr as cache when available.
SVN revision: 59004
2011-04-28 13:25:14 +00:00
Cedric BAIL bcef93caba ethumb: make exists client API async.
Ethumb_Client now use Ecore_Thread with this patch.

	* cache exists requests (client side).
	* cache generate requests (server side).

SVN revision: 58977
2011-04-27 18:06:42 +00:00
Cedric BAIL e697938fc2 * eio, ethumb and elementary: snapshot increase.
SVN revision: 54508
2010-11-12 16:03:34 +00:00
Chidambar Zinnoury 52b0c711a1 ethumb: missing initialization.
Thank you Lucas de Marchi :)

SVN revision: 52487
2010-09-20 12:10:30 +00:00
Chidambar Zinnoury 0f4ce94ecf ethumb: automagically orient thumbnails based on:
- metadata contained in files (EXIF only currently) - default active;
 - orientation given by the caller against pixel data orientation.
 Code is based on els_icon.

 Next is to add that through dbus.

 Open question: if orientation is specified, do we need to save the thumbnail in a different folder?

SVN revision: 52465
2010-09-19 17:07:35 +00:00
Rafael Antognolli 94540f3b5b Changing Ethumb license from LGPL3 to LGPL2.
Making this change to be in agreement with some other EFL libraries
under LGPL.

SVN revision: 52275
2010-09-14 23:02:45 +00:00
Gustavo Sverzut Barbieri 5882201502 ethumb: Invalid access upon ethumb_free
The sub-ecore_evas is automatically deleted by ecore_evas_object_image
object when it is deleted, so we were double-freeing it.

By: Brian Wang <>

SVN revision: 50265
2010-07-15 12:45:52 +00:00
Gustavo Sverzut Barbieri 675b20a859 ethumb: cleanup headers
This bug of including Ecore, Evas and Ecore_Evas from Ethumb.h was
actually expoed from recent evas-0/Evas.h change, as these were not
required in the public file, I'm removing them and just letting eina
as it is used to typedef Eina_Bool and function attributes.

SVN revision: 50160
2010-07-09 15:24:17 +00:00
Christopher Michael 6d4c38f97b Move Ethumb headers to own directory.
Fix trying to free an evas_object by using ecore_evas_free...spankies !!

SVN revision: 50152
2010-07-09 08:14:24 +00:00
Lucas De Marchi 7c12cc36aa Fixes for Ecore Api changes
Patch automatically generated by Coccinelle to fix the
callbacks used by the following functions:

 * ecore_event_handler_add()
 * ecore_event_filter_add()
 * ecore_idler_add()
 * ecore_idle_enterer_add()
 * ecore_idle_enterer_before_add()
 * ecore_idle_exiter_add()
 * ecore_main_fd_handler_add()
 * ecore_main_win32_handler_add()
 * ecore_timer_add()
 * ecore_timer_loop_add()
 * ecore_animator_add()
 * ecore_poller_add()

SVN revision: 50113
2010-07-08 01:00:48 +00:00
Mike Blumenkrantz b3a4801b79 fix leak in free
SVN revision: 50009
2010-07-03 05:29:31 +00:00
Gustavo Sverzut Barbieri 9345b211b0 fix llvm/clang and gcc errors.
NOTE: mixing write() and fprintf() to the same descriptor (stderr,
      done by ERR()), will likely cause problems :-/

SVN revision: 46753
2010-03-02 00:34:40 +00:00
Luis Felipe Strano Moraes b9ef31f902 Add missing CFLAGS for ethumb.
SVN revision: 45991
2010-02-08 20:26:45 +00:00
Sebastian Dransfeld a82e7511aa make clang happy
SVN revision: 45197
2010-01-15 20:51:01 +00:00
Jorge Luis Zapata Muga f3fb3dea17 + [Eina] API change. eina_module_list_flush() -> eina_module_list_free()
as we are on the modules context not the array.
  All the referenced projects are changed too. Remember that the list_free()
  already calls the unload() on each module so no need to call list_unload()

SVN revision: 44978
2010-01-08 12:22:23 +00:00
Jonathan Atton 3cadaace4f Ethumb: test if unique_name is not null, If I kill the daemon right after it is started, I have a segv. This patch fix it.
SVN revision: 43971
2009-11-25 12:43:27 +00:00
Vincent Torri d4d1a53181 * fix order of libraries during link (fix windows compilation)
* paths based on $prefix are not set at configure time. The correct
   way is to use them in
 * $themesdir and $sysconfdir does not seem to be used

SVN revision: 43567
2009-11-09 05:41:41 +00:00
Vincent Torri 2198c8a70a don't free stack variable
SVN revision: 43566
2009-11-09 05:27:35 +00:00