Summary:
Added this example which demonstrate the exact behavior or "changed" in radio button.
After changing the documentation of "changed" as in https://phab.enlightenment.org/D1445, thought the example might be useful, so added this.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: devilhorns, stefan_schmidt, seoz
Differential Revision: https://phab.enlightenment.org/D1490
This is a fix upon 6e7686c030fab162edb3128de005ec00ea8c0ffc.
This correctly deletes the list even if the windows are still referenced
and even if they are deleted from under out feets.
Summary:
Setting layer of a smart member is not required as it would remain
on same layer of slider.
Reviewers: raster, seoz
Reviewed By: seoz
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1447
This reverts commits 123ca6a8744729525889bbc09ee1aff4b2b97b75, 0d527b03f4f630e81ab4480d7160bbf6352b0bac
this is still unusable even after being fixed so the fix was unnecessary to begin with
Summary:
Right now we cannot have a designated build directory and we should build in the source directory. So the proposed solution lets you to build from any directory.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: raster, cedric
Differential Revision: https://phab.enlightenment.org/D1395
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
ecore_x, ecore_wl, ecore_drm etc. were being linked to clients as they
were added to the pc file - they should not have been. elm hides
these. it's meant to hide them. remove them from the pc file.
Summary:
Changed the text for Radio "changed" event to:
This is called when the radio object is selected.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: stefan_schmidt, seoz
Reviewed By: stefan_schmidt, seoz
Subscribers: stefan_schmidt
Maniphest Tasks: T1657
Differential Revision: https://phab.enlightenment.org/D1445
The scale is used for the application to be scaled.
If the application isn't made on the basis of scale 1.0,
the application layout will be scaled inappositely. So if the
application set the base scale, it is applied when the application is scaled.
this should have been done with the module rename, and this release is the last chance to get it fixed before it has to be permanently maintained with wrong names
This was leading to never enter the cnp functions dedicated to Wayland,
as the given object was not a window. The Copy And Paste test was not
working for this reason.
Summary:
If item select callback is elm_genlist_clear and genlist object have many item, elm_genlist_clear was broken.
This reason is due to incorrect code. In Old code, check the item focus after an item was deleted. So, I changed the order of the code.
Before item was deleted, Check the item focus.
@fix
Test Plan: I revised the elementary_test code and tested with that.
Reviewers: raster, SanghyeonLee, seoz
Reviewed By: seoz
Subscribers: bluezery, SanghyeonLee
Differential Revision: https://phab.enlightenment.org/D1418
I'll reintroduce this in a moment, was just easier this way in order to
merge Vincent's changes.
This reverts commit d46fa601ef45d579d1448b19887d02ff2dfbb576.
Summary:
Label size is incorrectly calculated (text does not wrap) if
elm_label_line_wrap_set() is called before elm_label_wrap_width_set().
@fix
Test Plan:
The label3 test case is added to show the bug case.
In label3 test case, if we switch the calling sequence of
elm_label_line_wrap_set() and elm_label_wrap_width_set(),
the result is different.
Reviewers: raster, seoz, woohyun, Hermet
Differential Revision: https://phab.enlightenment.org/D1369
Summary: Removed all global variables for item class
Reviewers: zmike, raster, seoz
Maniphest Tasks: T1482
Differential Revision: https://phab.enlightenment.org/D1318
Summary:
If gengrid select mode is not ELM_OBJECT_SELECT_MODE_ALWAYS, ELM_OBJECT_SELECT_MODE_ALWAYS mode for
elm_genlist_item_select_mode was broken. In the item select routine, item mode(it->mode) was not checked.
So, I added the check routine there.
@fix
Test Plan: I revised the elementary_test code and tested with that.
Reviewers: raster, seoz
Reviewed By: seoz
Subscribers: SanghyeonLee, bluezery
Differential Revision: https://phab.enlightenment.org/D1372
This completely breaks automatic UI mirroring. The code there was
correct. Please, before removing code, contact the original author and
make sure you don't break things down. Especially if your reason for
removing is "this doesn't make sense to me" instead of "this breaks X
Y."
This reverts commit 24983fed239a3b37c05cc3c65ed9c56953a7176b.
thre are still all the old engines supported inside, but docs dont say
so so effectively deprecated. also handle a NULL engine. this is part
of our engine/display system cleanup.
Summary:
elm_widget calls _item_del_pre_hook of each widget and widget can
decide item deletion by return type. But gengrid and popup widget implemented
those _item_del_pre_hook function as a void type.
So this commit fixs the return types to Eina_Bool and changes gengrid widget to return EINA_FALSE when
the item wants to be deleted later.
And when the item wants to be deleted directly, it returns EINA_TRUE.
@fix
Test Plan: test in demo.
Reviewers: seoz, raster, bluezery
Subscribers: Hermet, jaehwan
Differential Revision: https://phab.enlightenment.org/D872
now that we have ELM_DISPLAY and ELM_ACCEL we have little need for a
lot of the elm engine stuff and frankly a lot was broken if you used
multiple engines etc. so this fixes a lot of it nd removes a lot of
cruft. i think i got it all right, but i may have oppsied. this also
remo9ves engine support for engines long gone from evas.
Summary:
ELM_OBJECT_SELECT_MODE_ALWAYS mode for elm_genlist_item_select_mode
was broken. In the item select routine, item mode(it->mode) was not
checked. So, I added the check routine there.
@fix
Test Plan: I revised the elementary_test code and tested with that.
Reviewers: raster, seoz
Reviewed By: seoz
Subscribers: SanghyeonLee, bluezery
Differential Revision: https://phab.enlightenment.org/D1347
This reverts commit 2e2d003efeded27955cc9301279cd3a0d362f548.
Revert this patch to leave the credit to Andrii Kroitor.
I will fix this correctly in the next commit.
Sorry Andrii for the wrong review comments that can break compatibility.
But actually it was not documented at all so there was no problem.
Just to please hermet, let's not do more.
This reverts commit a2afbe91e851f3d943736d2a1aae9e2721d1a0d5.
definitely this will break compatibility.
and as i mentioned, we should prevent as possible that
until there are other methods.
Summary:
added support of bottom_left, bottom_right, top_left, top_right styles
of notify that are present in default theme
@fix
Reviewers: cedric, seoz, Hermet
Subscribers: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D1329
this makes the black rect etc. appear instantly even if no effects are
selected for comp - this should cover up lockscreen and other stuff on
suspend/shutdown/resume etc. like fading does. this should fix T1498
if entry has selection, it would be cleared if selection region set is requested again.
because entry cancel the selection area after it reset the selection area.
unfortunately, the selection area is new selection so selection area is gone.
this patch prevent clearing selection and keep the new selection.
@fix
Now both hoversel and button are usable.
This is easiest way to fix the bug. But why it didn't work well even
hoversel inherit button default style?
Revert "button: revert this patch because this patch just broke hoversel."
This reverts commit 3238c8787511aaf69b755760b24f1aa518477d75.
hoversel is now usable. let's fix the button warning message with more
considerations.
Revert "button: add fixed 1 1 in case that text is not used."
This reverts commit efd33ddb5ba51dccaee2734e8a7add18801d9285.
Draggable area could be zero size if user set the panes content size
with elm_panes_xxx_size_set().
In this case, it prints fixed messages.
now, it's gone and i tested with various cases for any side effects.
the engine checks are also broken - but that's a much bigger change,
so this fixes elm config and main code to not do their x11 work if no
DISPLAY env var is set. this is right for a wayland world where you
don't want DISPLAY but WAYLAND_DISPLAY set and used. this fixes
several ERRs that should never have hapapned in this setup.
lots of code unsing ENGINE_COMPARE where it should get the engine from
the ecore_evas directly - it happened to work as we happened to have
apps that have windows only for x11, or wayland etc, but not both in
an app. this was wrong, so remove the engine compare macro and do it
properly. no laziness.
this was yet another thing broken by the mostly-unreviewed and untested widget item focus feature. it's still not completely fixed, since the reorder modes are broken, but at least it works for the general case again
@fix
@fix
moved the user callbacks call at the end of the function, so the user
is able to modify the list without making the code below the call to
fail miserably.
Also improved the Genlist Del test to also include this case.
@fix
To calc the position in a table you need to make the modulo of the col/row size, not the modulo on the x/y value
This unbreak the elm_gengrid_item_pos_get() function that was reporting wrong values
Especially the -fvisibility=hidden would be needed here for our EAPI handling.
I never realised we miss this here but Lukasz Stanislawski pointed me to it
when we wondered why it linked ofr him with missing EAPI but not for me.
I'v compiling and releasing elm like this for a long time now so I don't
expect any trouble but if something strange comes up we can still revert it
before 1.11 final.
Issue reported by Stefan Schmidt. Above atspi function had EAPI attribute
defined in implementation file, however this symbol should not be public in
elementary 1.11.
These headers are installed in the system but not officially supported
as they are considered as internal headers.
The reason why they still need to be installed is that
- they were exposed even in the previous releases.
- they are needed for widget customization (unofficially)
- or it will break ewe.
Special thanks to Stefan for the reporting.
Summary:
Elementary application crashes on startup when it is running with
wayland engine. This crash problem happens while ecore_x_screensaver API
is being called from _win_noblank_eval funcion. Thus we should not call
ecore_x_screensaver APIs if elm win doesn't have X11 window.
Test Plan:
1. build efl and elementary to support x11 and also wayland
1. run weston without xwayland
2. run elementary_test on the weston
Reviewers: raster, seoz, stefan_schmidt, devilhorns
Differential Revision: https://phab.enlightenment.org/D1293
misspelled.
In case someone exports the ELM_ENGINE to be wayland-shm or
wayland-egl, let's handle That case also. Typically it is set to
wayland_shm or wayland_egl but since we check variants of spelling for
other engines also, then let's check it for the wayland engines too.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
As a small fallout from e7dbe063c9c044f072bacafd31ab872f6210788b we now
need to set ELM_DISPLAY with our system has something like $DISPLAY or
$WAYLAND_DISPLAY set. Elm uses that now to find out which window system
to use.
In the case of daing make doc we want it forced to shot even if we run
under X. With ELM_DISPLAY we do that. Thanks goes to raster for the
explanantion and git bisect for pinning it down.
Srivardhan Hebbar
Carsten Haitzler
Tom Hacohen
Jaehwan Kim
Amitesh Singh
Mike Blumenkrantz
Boris Faure
Daniel Juyung Seo
Wonguk Jeong
Stefan Schmidt
Savio Sena
Ryuan Choi
Kai Huuhko
Igor Murzov
maxerba
Daniel Kolesa
Daniel Zaoui
Kai Huuhko
Jae Yong Hwang
Vincent Torri
Cedric BAIL
kabeer khan
Tae-Hwan Kim
Vincent Torri
Jaeun Choi
Thiep Ha
Jihoon Kim
yinsc
SangHyeon Lee
Jérémy Zurcher
ChunEon Park
Andrii Kroitor
zmike
Davide Andreoli
Lukasz Stanislawski
q66
Gwanglim Lee
Chris Michael