NOTE: if you want to implement even/odd in your theme you know
need to listen to both signal :
- elm,state,odd from elm
- elm,state,even from elm
If you set data of "stacking_even" to "above" of you item group
it will raise the even object above the odd one (that's the default
behaviour).
You could also explicitly active/deactivate the stacking by setting
data of "stacking" to "no". Default is "yes".
SVN revision: 58822
I introduce a new concept to genlist.
I named it "genlist mode" after I discussed it with raster.
Using this feature, one can activate/deactivate any mode(effect) to an item.
The mode is defined in genlist item edc.
You can watch a sample video on youtube.
http://www.youtube.com/watch?v=ZPbwpzwwiS8
I created two sample mode: Slide and Rotate.
[Feature Description]
- One can activate a specific mode to an item.
- One item is activated at one time while others are deactivated.
- Genlist handles deactivating other items when one item is activated.
- There are two different view: before activated, after activated.
- Genlist creates the second view when the first view is activated. Usually the first view is animated.
- Genlist destroys the second view when the item finishes deactivating.
- Creating/Destroying the second view on the fly gives performance enhancement because there is no reason to hold all objects in two views all the time.
- Mode is defined in genlist edc so one can easily add it more.
- Mode edc style is separated from normal genlist styles. One can combine any genlist style with mode edc style.
[API]
- EAPI void elm_genlist_item_mode_set(Elm_Genlist_Item *it, const char *mode_type, Eina_Bool mode_set) EINA_ARG_NONNULL(1, 2);
Activate/Deactivate a mode to an item.
- EAPI const char *elm_genlist_mode_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
Get activated mode name.
- EAPI const Elm_Genlist_Item *elm_genlist_mode_item_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
Get activated item.
[Structure]
- Elm_Genlist_Item
Added const char *mode_item_style;
[Usage]
- Set mode style name to genlist item class.
itc.mode_item_style = "mode";
- Activated mode to an item whenever you want.
elm_genlist_item_mode_set(it, "slide", EINA_TRUE);
SVN revision: 58791
I added some APIs for name to elm_map.c and added some test code to test_map.c
I used nominatim OSM service. (http://http://nominatim.openstreetmap.org/)
as i felt, it's response time was very good to use.
SVN revision: 58703
Mail from Sangho Park.
I added some APIs for route to elm_map.c
There are some route services provided by Open Street Map (yours, open
route service, monav...)
I just added 'yours' url callback and will add ors, monav.
And added some test code to test_map.c
SVN revision: 58474
Segment Control Widget is a horizontal control made of multiple segment items
together, each segment item is set to equal size, functioning similar to
discrete two state button. Only one segment item can be at selected state.
SVN revision: 58461
Subject: Re: [E-devel] [Patch] Display more than 3 items
This is Shinwoo Kim, learned that I could contribute to EFL! :)
I'm pleased to inform you that the patch for the "elm_diskselector".
Until now, the "elm_diskselector" only display 3 items at once,
if you accept this patch, the "elm_diskselector" can display more than 3
items.
For this feature, "elm_diskselector_display_item_num_set(Evas_Object *obj,
int num)" is added.
I would like to know more about your opinion about this feature. Thanks.
SVN revision: 58405
Subject: [E-devel] [Patch] elm_genlist :
elm_genlist_realized_items_update api added
I added elm_genlist_realized_items_update api.
elm_genlist_item_update api already exists.
But If the application want to change all realized items using this api,
application always have to check genlist all realized items and call
elm_genlist_item_update api.
This routine is being used at many functions of application.
So I made elm_genlist_realized_items_update api.
This helps application to update easily all realized items at a time.
SVN revision: 58403
It's just useless and makes zero sense. No matter what we'll
get a useless output and it just slows everything down.
Should probably be added when it makes sense, but it will probably
need something like elm_label_wrap_width_set.
SVN revision: 58393
In some cases, for example resizing the GenGrid test or just using
ephoto, the scroller would jump to the right before going to it's
proper direction. We should check if the position is below minimum
after we reduce the position, and not instead.
SVN revision: 58383
Unified double-click smart callback signal name to "clicked,double".
Wrong signal name "clicked" is still there.
But this will be removed soon after fixing all codes in trunk.
SVN revision: 58293
Patch from 장효영 (Hyoyoung Chang). Basically checking extensions is silly,
and some real life use shows it just breaks things. Especially since we
aren't liberal enough with the extensions we check.
I also cleaned up some whitespace and weird indentation at the edges.
SVN revision: 58229
Subject: [E-devel] [Patch] elm_genlist - group index homogeneous mode
support
Current, genlist using group index can't use homogeneous mode.
So this is patch for support homogeneous mode when the genlist uses
group index.
SVN revision: 58173
Subject: [E-devel] [Patch] for Gettext /I18N
Mr. Govi in SISO made a patch for following description.
Detail Description:
1. If EFL/Elementary Application has i18n String with its own PO file,
then Elementary will end up looking for internal Strings at application
PO files. Passing PACKAGE name in the Elementary String Look up macro
eliminates this issue and looks for internal String from Elm.po files.
2. Macro E_(str) is used, to differentiate the elementary Strings from
commonly used #define _(str) in the applications. ( Just E ed :) )
SVN revision: 58085
Subject: [E-devel] [PATCH]: keyboard navigation in menus
I was using elementary on a target that only has a keyboard, and I add
to do several modification on the elm_menu to handle keyboard
navigation.
- patch 1: discard a menu from C source code
- patch 2: add accessors for menu items and add the ability to handle
selected item from C source code
SVN revision: 58084
Subject: [E-devel] Patch for photocam elm_photocam_file_set
hello, i made a patch for photocam, because i found a bug that
sometimes grid_clearall is done after image preload process, but it
should be done before image preload process, otherwise, only low
quality image is loaded.
Please have a check, thanks~
SVN revision: 58083
Subject: [E-devel] elm_genlist - bug fix about _update_job
I found one bug in _update_job.
Now, when the elm_genlist_item_update is called, all realized items have
been updated.
In _update_job logic, item block is recalculated if it->minw and
itminw is
not same.
But before comparing that, itminw value is saved it->w.
And it->minw value is saved in _item_realzie function.
Then there are different between it->minw and itminw value.
So the item block is recalculated and _item_block_position is called.
After applying below patch, elm_genlist_item_update api updates only one
item.
SVN revision: 58082
Subject: [E-devel] [PATCH] Patch to give focus to the content in
elm_notify
lm_notify has not handled the focus movement.
Even though a button widget is contained in an notify widget and notify
widget is shown, button widget could not be focused.
Therefore, button couldn't process any key event such as space and enter key.
This patch will solve this problem.
SVN revision: 58081
If the scroller is stopped and set the freeze push while bounce
animation is running, it will stop bouncing in a moment. Even if the scroller
is set the freeze pop again, the scroller don't finish the bouncing. I think
that it should finish the bouncing when it is set the freeze pop.
SVN revision: 58063
Elementary was missing window types for dropdown_menu, popup_menu,
tooltip, notification, combo, and dnd. This patch adds the missing
types into the enum and elm_win code.
SVN revision: 57992
Subject: [E-devel] [Patch] Small patch for elm_slider (scrolling pop +
push)
I made small patch for elm_slider.
I think scrolling should be freezed (not held) when dragging is
started.
This is because scrolling can go on with elm_widget_scroll_hold_push.
SVN revision: 57959
>>> Hello,
>>>
>>> I was using elementary on a target that only has a keyboard, and I add
>>> to do several modification on the elm_menu to handle keyboard
>>> navigation.
>>> - patch 2: add accessors for menu items and add the ability to handle
>>> selected item from C source code
SVN revision: 57957
Subject: [E-devel] [Patch] Focus issue in elm_widget.c
I've checked there were some focus problems when an object is hidden.
So I made patch for that ~
SVN revision: 57898
Subject: [E-devel] [PATCH] elm_entry : use EINA_FALSE instead of 0 when calling edje_object_part_text_select_allow_set
Date: Fri, 18 Mar 2011 13:04:44 +0900
Hi,
This is simple patch to use EINA_FALSE instead of 0 when calling
edje_object_part_text_select_allow_set in elm_entry.c
Would you please apply in svn?
SVN revision: 57836
It cause a error since the pan object does not have any child yet.
And why it should be visible even if it should call evas_object_show after setting child?
Anyway, the line does nothing.
SVN revision: 57683
After a widget is created(obj = elm_widget_add), the object does not have any parent object.
However if user call elm_widget_sub_object_add(parent, obj), then CRI will be happened.
So the exception should be there.
SVN revision: 57667
Subject: [E-devel] [Patch] elm_smart_scroller_child_region_show_internal
In the els_scroller of the elementary, the function
"elm_smart_scroller_child_region_show_internal"
have a problem. If the parameters "x,y,w,h" have the wrong value like
"elm_scroller_region_show(scroller,
-300, -300, 900, 900);", the scroller move the position temporarily.
The scroller seem to jump.
So if the value of the parameter is not valid, it should be changed to
valid value.
The work is applied already in the function
"elm_smart_scroller_region_bring_in".
It should be applied in the function
"elm_smart_scroller_child_region_show_internal" too.
I changed the code like bring_in function.
SVN revision: 57666
Subject: [E-devel] [Patch] elm_map_marker_region_get
This is a patch for elm_map_marker.
I added one api to get the coordinates of the marker.
because marker->longitude and marker->latitude are private data,
app can't access the coordinates of the marker.
SVN revision: 57665
Subject: [E-devel] [Patch] anchorview's "clicked" signal is always
sent when mouse up.
I've checked "anchor,clicked" signal is always sent with mouse_up.
That is, mouse_down on the anchor -> mouse_move out from the anchor ->
mouse_up can emit "anchor,clicked" signal.
So I made one patch for right clicked signal emitting.
SVN revision: 57664
Subject: [E-devel] [PATCH] elm_gengrid selection key patch
Unlike other widget, gengrid processes only the "Return" key for
selecting item.
This patch makes gengrid be able to process KP_Enter and space key for
selecting item.
SVN revision: 57662
Since these APIs are committed not much days ago, Im modified the API names to make better.
But Im not sure. how many people are using this APIs at this time.
I guess nobody.
SVN revision: 57651
These APIs provide options to user to set the properties of the transit objects will be rest or not when the transition ends.
The properties include geometry, color, evas_map data..
SVN revision: 57498
Hello.
I attached the modified patch about calc_job problem.
When I tested gengrid, sometimes gengrid renderd two times in different
shape in a moment.
So I checked gengrid code, I found cause in calc_job function.
calc_job added to ecore job after elm_gengrid_item_size_set and
elm_gengrid_item_append(,prepend,insert_before,insert_after) and etc.
Sometimes pan_smart's cvw and cvh is 0 at this time.
I think, No need to calc_job when pan_smart's cvw and cvh is 0.
Please check about this patch.
Thanks.
SVN revision: 57491
It will provide new apis - elm_transit_object_prop_hold_set/get to give a option for keeping the object property when effect is over.
SVN revision: 57396
Subject: [E-devel] elm_genlist - bug fix about del callback
I found one bug in elm_genlist_clear.
In case append lots of items in genlist, some items are still in genlist
item queue before it is processed in _item_queue.
At that time, if application calls elm_genlist_item_del api that has item in
genlist queue and elm_genlist_clear is called at once, "func.del" callback
is called twice.
If application frees some memory in "func.del" callback, It occurs
double free memory problem.
For example, some application has many items. and all items are deleted. but
all items are not proceed in queue. then application is terminated.
In that case, double free problem is occured in application.
So, I fixed elm_genlist_clear code and made a patch.
SVN revision: 57371
Subject: Re: [E-devel] [Patch] elm_map_user_agent_set and get
This is a patch for elm_map for setting user-agent.
- Add elm_map_user_agent_set
- Add elm_map_user_agent_get
- modify doxygen
elm_map uses OSM(OpenStreetMap), but we can add custom map provider.
If custom map provider server filters robot out (currently default
user-agent is 'curl'),
we need some APIs to set/get user-agent.
SVN revision: 57353
The commit caused bugs when there was no icon, exactly what it claimed
to have fixed. I took a look at the commit and it looked a bit messy,
too messy for me to try to fix. A rewrite makes more sense.
Previous commit message:
From: Sohyun Kim <anna1014.kim@samsung.com>
Subject: [E-devel] [Patch] elm_bubble theme patch
I'm Sohyun Kim. Nice to meet you.
This is a patch for bubble theme.
The bubble has a region for icon, label and info text.
However, it has the region, if icon, label and info text are not set.
I modified theme and added edje signals.
1. add edje signal for label and info text state
2. remove text size for label and info text default state
-> set it on "visible" state
3. add base image state for info text only
SVN revision: 57244
[patch] els_scroller - simple bug fix about bar-dragging. by Jae Hwan Kim.
More info:
You can test it in "Scroller" menu of the "elementary_test".
We cannot move the scroller by dragging the bar.
The reason is why the bar-dragging-event and mouse-move-event confict.
When bar is draged, the movement by mouse-move should be freezed.
SVN revision: 57184
Subject: [E-devel] [patch] elm_label - bugfix at string manipulation
ear Elementary developers.
It's a elm_label bugfix.
It has two small improvements.
1. Current code can be reference null ptr.
- replocater = curlocater + key_len + 1;
- while ((*replocater != '=') && (replocater))
^^^
-
replocater++;
It should be *replocater, not replocater
2. there are two while loop to find a separate character in
string.
I changed it from loop to strchr.
SVN revision: 57161
Subject: [E-devel] [Patch] elm_map_marker_remove test code
Dear all,
This is a patch for elm_map_marker_remove test code.
I added one button for marker_remove to test_map.c
SVN revision: 57044
objects hierarchical region show. Scroller pan geometry is included, as scrolelr
is smart object, not in genlist hierarchy.
Patch By Govindaraju SM <govi.sm@samsung.com>
SVN revision: 56981
1. the range of marker to remove.
2. after free(marker->groups[i]), reuse the value.
Patch by Sangho Park <gouache95@gmail.com>
Reviewed by Atton Jonathan.
SVN revision: 56849
* Added elm_mirrored_get/set to set the system mirrored mode
* Added elm_widget_mirrored/get/set to set each widget's mirrored mode.
* Added code to set the system mirrored mode from translations to elementary and added translations for all the rtl languages. (a trick to load according to locale).
* Future commits will include specific widgets mirrored mode handling.
Work by Aharon Hillel and Tom Hacohen.
SVN revision: 56673
Mr. Wonguk Jeong made a patch for elm_module.
This patch is for changing the timing of module loading.
For now, module loading is done in elm_init
Thus, modules are always loaded, even if the application does not use
them.
So this patch deferred the timing of module loading to
"_elm_module_find_as".
SVN revision: 56586
Subject: [E-devel] [Patch] genlist item cache exception handling patch
I added "no cached item" handling.
In some case, items should not be cached and should not use caches.
For example,
if there was a state change in item style, it should not be cached
because it remembers the state changes.
And if we use elm_genlist_item_item_class_update() API,
item should not be cached as well.
It needs to be a fresh item style without remembering the state changes.
SVN revision: 56585
Subject: [E-devel] [Patch] elm_genlist patch regarding inlist
I made a patch for elm_genlist.
For getting genlist item from inlist, ELM_GENLIST_ITEM_FROM_INLIST macro
should be used.
SVN revision: 56582
Subject: [E-devel] [Patch] Removed dead code in elm_genlist.c
I removed dead macro LONGPRESS_TIMEOUT.
Genlist's longpress_time value is read from
_elm_config->longpress_timeout.
SVN revision: 56581
Subject: [E-devel] [Patch] els_scroller - Cannot click even if it
reach to end
I have another issue in scroller when the bounce is off.
Scroller cannot be clicked even if it reach to edge and animation is
end.
The reason is why the momentum animation is running even if it reach
end and bounce animation is off.
So I change the code that if it reach the edge in case of bounce-off,
the momentum animation is stoped.
The following is the patch code.
SVN revision: 56580
Subject: [E-devel] [Patch] els_scroller -
elm_smart_scroller_child_region_show
I have some issue in scroller.
Sometimes the scroller move to wrong region when the child get first
focus.
It use "scroller -> layout -> button".
So I checked the code and found a suspected thing in
elm_smart_scroller_child_region_show.
Please refer following pictures.
In the pictures, the rect which be written "x, y, w, h" is the area
which be made with the parameters of
"elm_smart_scroller_child_region_show".
The rect which be written "Pan" is the pan area of the scroller.
If the situation is 1) or 2) and the function is called, the result
have to be 7).
In case of 3) or 4), it have to be 8).
In case of 5) or 6), it have to remain as it is.
Is it right??
But if the situation is 6) and the function is called, the result will
be 7) in current code.
I think it is wrong.
I attached patch code. please find it below the pictures.
1)
---------------
| |
| x, y, w, h |
| |
---------------
---------------------
| |
| |
| |
| Pan |
| |
| |
| |
---------------------
2)
---------------
| |
| x, y, w, h |
---------------------
| | | |
| --------------- |
| |
| Pan |
| |
| |
| |
---------------------
3)
---------------------
| |
| |
| |
| Pan |
| |
| --------------- |
| | | |
---------------------
| x, y, w, h |
| |
---------------
4)
---------------------
| |
| |
| |
| Pan |
| |
| |
| |
---------------------
---------------
| |
| x, y, w, h |
| |
---------------
5)
---------------------
| |
| --------------- |
| | | |
| | x, y, w, h | |
| | | |
| --------------- |
| Pan |
---------------------
6)
---------------
| |
--------------------- <---Pan
| | | |
| | x, y, w, h | |
| | | |
---------------------
| |
---------------
7)
---------------------
| | | |
| | x, y, w, h | |
| | | |
| --------------- |
| |
| Pan |
| |
---------------------
8)
---------------------
| |
| Pan |
| |
| --------------- |
| | | |
| | x, y, w, h | |
| | | |
---------------------
SVN revision: 56579
Subject: [E-devel] [Patch] small patch for elm_main.c
I made small patch for elm_main.c
In elm_all_flush function, I was suspicious about,
if _elm_win_list is NULL then following codes should not be called or
not.
ejde_file_cache_flush();
edje_collection_cache_flush();
eet_clearcache();
I thinks above functions should be called without any consideration
about
the state of _elm_win_list.
SVN revision: 56574
Subject: [E-devel] [Patch] elm_genlist patch for group index handling
and bug fix
I attached a small patch for elm_genlist.c
1. _item_block_position() fix
This patch realizes group index even there is no sub-items.
There was a request about this.
And it shows that there is no sub-items explicitly.
2. Bug Fix
Null check routine was wrong-placed.
I fixed it.
SVN revision: 56573
Subject: [E-devel] [Patch] environment parameter - ELM_EFFECT_ENABLE
I want to add the environment parameter "ELM_EFFECT_ENABLE".
It will play a role as the enablement for the effect of all widget.
SVN revision: 56572
Subject: [E-devel] [PATCH] elm_transit
Here is a minor patch for elm_transit
(indentation & removed unuseful calls - evas_map_smooth_set)
SVN revision: 56571
In this change I also introduced elm_smart_scroller_child_region_set thats used to change the position of the scroller, without actually saving it as a wanted position.
SVN revision: 56284
Revert "Elementary scroller: Fixed an issue in scroller. When a resize happens (or any change for that matter), we should go to the last "asked for" location. This for example fixes an issue with elm_scrolled_entry (and many other widgets) showing "empty regions" on some resizes."
This reverts commit f322bd28101518849c53e6d56b93c206e4129162.
SVN revision: 56282
Revert "Elemenatry: Fixed an issue with elm_scrolled_entry_cursor_end_set not showing the correct region."
This reverts commit 90e80c4045d0c7031b0b01b67b06f62ea8efb14f.
SVN revision: 56281
(for that matter externals has a problem in design - it loads every
module for externals and thus links in every lib even if never used by
the app/edje obj).
SVN revision: 56218
can't. its a matter of simply some element re-rendering that is hidden
- rendering into a mapped buffer. i disable the animation in the
layout (layout2) and no cpu usage. that's my bet.
SVN revision: 56204
Subject: [E-devel] [Patch] small patch for elm_pager.c
I felt strange with the following codes in elm_pager.c
Why it->content should be hidden after deleted ?
Is it a bug ?
I made a small patch for this
SVN revision: 56127
By default it's text only for single line entries (you can toggle it back on
if you want to). Otherwise images are enabled for multiline entries.
SVN revision: 56078
So basically you can request markup without images. If you want both request
MARKUP | IMAGES. Then when an image comes in you'll get an image as markup.
SVN revision: 56076
Subject: [E-devel] [Patch] elm_map downloading progress info & bug fix
I added one new signal, one new API and fixed seg fault bug.
- signal : "download" (this signal is called when map_tile is
downloaded)
- API : elm_map_utils_downloading_status_get(const Evas_Object *obj, int
*try_num, int *finish_num)
- seg fault : if user select custom map provider, seg fault occurs,
because
there is no url_cb in the custom map provider
you can check download progress using these signal & API.
the example is in "test_map.c".
SVN revision: 56039
Subject: [PATCH] elc_ctxpopup
Here code is for the ctxpopup.
Since the functionalities of ctxpopup are somewhat different,
I'm trying to overwrite the ctxpopup code entirely first.
The main reason is,
Original ctxpopup could determine it's size and position by itself.
Of course, upstreamed version supports this. But it can not be reduced
it's
size
And it supposes the arrow position to center of box edje.
Basically,
This version calculates it's box size first then find available space
from
the it's position.
The origin position of the box is not expected, it finds the available
positions.
But if there is not enough space to be shown, then it finds a best
direction
to be shown again.
In this case, it reduces it's size also as to be shown entirely.
Since the ctxpopup supports scroller, the reduced box could show the all
items also.
(The point is ctxpopup should know the size of total items...)
I'm not sure the upstreamed version could cover the above scenario,
If then, I need to modify it first.
(fixed some minor formatting issue too)
SVN revision: 56021
Subject: [E-devel] [Patch] elm_genlist doxygen fix and addition.
I fixed some typos of Genlist doxygen and added more explanations.
Please review this and apply this to upstream.
SVN revision: 56017
Subject: [E-devel] [PATCH] Change the second parameter type of
elm_slidershow_timeout_set
Most of APIs related to timeout_set / get uses double type as parameter,
but elm_slidershow uses integer type.
For uniformity, the second parameter type of elm_slideshow_timeout_set
is changed into double type.
SVN revision: 56015
Patch original from Hyoyoung Chang.
Modified by me a lot, with some extra debug.
Also I removed the sizeof(char). That was defined to be one before most of us
where born.
SVN revision: 55986
Even it looks somewhat alien elm,
I hope EFL supports basic effect by using c and edc.
In some cases, it is useful for app developers.
They want to use effects easily and quickly as Other F/W does
providing.
Here is patch again.
Added two lines for elm_transit_duration_set exception handling.
I guess there are possibilities still to add/modify some functions to
the
transit.
So, currently the exception cases does not defined yet.
But I will try patches soon as perfect things.
Please consider about transit.
And.. if this transit is acceptable,
How about deprecate elm_animator as soon as possible?
SVN revision: 55966
Subject: RE: [E-devel] [Patch] Group index support
I added a small patch for Genlist group item clear.
And I changed git->minh to git->h in item_block_position function.
Thanks Govi
SVN revision: 55965
raster: may I rename elementary_config.h to config.h ? If I
add macros for all the init stuff, it would be nice to have
consistent name for that file
SVN revision: 55952
Subject: RE: [E-devel] [Patch] Group index support
I added a small patch for Genlist Group.
I missed one. Thanks Govi!
Can you review this and apply it to upstream?
SVN revision: 55929
Subject: [E-devel] [Patch] Group index support
I added group index feature.
This feature support to show item indicates group index.
I attached capture images showing group index.
As you can see attached png images, Group index item includes same group
items.
The group index is shown until every items that have same group index
are scrolled. so group index realize/unrealize is not excuteded in
_item_block_position function.
instead of the function, group index is controlled in _pan_calculate
function.
"Genlist Group" and "Genlist Group Tree" menu is added in
elementary_test. you can test group index operations in elementary_test.
This patch is not support elm_genlist_item_insert_before/after
operation of group index. We are now considering the operations in group index.,
This patch assumes that the previous 2 patches are already applied to upstream.
'[E-devel] [Patch] Tree support for elm_genlist_item_prepend() API.'
'[E-devel] [Patch] Tree support for
elm_genlist_item_insert_before/after() APIs',
So this patch does not include the changes of the previous patch.
I separated this patch.
- 004.elm_genlist.c.patch.txt
Patch for src/lib/elm_genlist.c
- 005.test_genlist.c.patch.txt
Patch for src/bin/test_genlist.c
- 006.genlist.patch.txt
Patch for data/theme/default.edc
And you have to add attached group_index.png file into 'data/themes'
'group_index.png' file is group index background image.
Daniel Juyung Seo help make test code and refactoring group index code.
SVN revision: 55925
Subject: Re: [E-devel] [Patch] elm_map pinch zoom
This is a patch for elm_map pinch zoom.
you can zoom in/out using two fingers.
- add event handler for multi touch.
(also fixed the TOUCH_HOLD_RANGE to use finger size as it should be)
SVN revision: 55920
I fixed a bug for elm_genlist_item_insert_before/after() declarations.
(Thanks glima.)
I should have modified EINA_ARG_NONNULL() when I added a new parameter.
1st and 5th parameter should not be NULL.
Anybody can review and apply this to upstream?
Thanks.
Daniel Juyung Seo (SeoZ)
SVN revision: 55880
Subject: [E-devel] [Patch] elm_genlist multi-touch smart callbacks
added
I added 6 multi-touch smart callbacks in elm_genlist, please refer to
below.
"multi,sweep,left" - Genlist has been multi-touch swept left.
"multi,sweep,right" - Genlist has been multi-touch swept right.
"multi,sweep,top" - Genlist has been multi-touch swept top.
"multi,sweep,bottom" - Genlist has been multi-touch swept bottom.
"multi,pinch,out" - Genlist has been multi-touch pinched out.
"multi,pinch,in" - Genlist has been multi-touch pinched in.
I think these smart callbacks are very useful for elm_genlist
multi-touch
effect.
If this patch have any issue, please let me know.
SVN revision: 55878
Subject: [E-devel] [Patch] elm_actionslider feature patch for
elementary.
This patch is for elementary elm_actionslider.
Mr. Sumanth created this patch. I reviewed it and fixed some.
This patch includes below features.
- Indicator label Set/Get APIs.
- _del_hook fix for wd->drag_button_base.
- Added magnet disable feature. _drag_button_up_cb fix for no magnet
handling. If magnet position is set to ELM_ACTIONSLIDER_NONE, it disables
magnetic. Added a test case to elementary_test.
SVN revision: 55872
Subject: [E-devel] elm_label patch(bugfix)
It's a bugfix patch of elm_label.
In strbuf_key_value_replace, null pointer reference can be occured
SVN revision: 55870
Subject: [E-devel] [Patch] Tree support for
elm_genlist_item_insert_before/after() APIs
I added tree feature support to
elm_genlist_item_insert_before/after() APIs.
This patch assumes that the previous patch, '[E-devel] [Patch] Tree
support
for elm_genlist_item_prepend() API.', is already applied to upstream.
So this patch does not include the changes of the previous patch.
This patch includes API break. I added parent parameter.
To support genlist group index feature, it should have a parent
parameter
like elm_genlist_item_append/prepend() do.
Raster already agreed to this API break.
I or my co-worker will introduce genlist group index feature today.
But for the reviewer's convenience, I separated this patch.
- 001.elm_genlist.patch.txt
Patch for src/lib/elm_genlist.c
- 002.elm_genlist.patch.txt
Patch for src/lib/Elementary.h.in, src/bin/test_genlist.c
- 003.elm_genlist.patch.txt
Due to API break, I changes other EFL libraries and applications on SVN.
SVN revision: 55869
Subject: [E-devel] [Patch] Tree support for elm_genlist_item_prepend()
API.
I added tree feature support to elm_genlist_item_prepend() API.
(elm_genlist_item_append() already supports tree.)
This patch is tested with elementary_test -> Genlist Tree.
Please review this and apply it to upstream.
SVN revision: 55868
elm_photocam widget does not support keyboard input.
This patch makes elm_photocam be able to process keyboard input such
as Left,
Right, Up, Down, PgDn, and PgUp key.
In addition, image will be zoomed in or out when '+' or '-' key in
keypad is pressed.
Please review it and let me know if there is any problem in this patch.
SVN revision: 55842
I found one small bug in elm_gengrid.c
"item" is used after "free(item)" in elm_gengrid_item_del() function.
Can anybody check about this ?
SVN revision: 55841
Subject: [E-devel] elm_map patch for supporting keyboard input
Most of elementary widgets can process keyboard input, but elm_map widget
has not. This patch makes elm_map be able to process keyboard input such as
Left, Right, Up, Down, PgDn, and PgUp key. In addition, map image will be
zoomed in or out when '+' or '-' key in keypad.
Please review it and let me know if there is any problem in this patch.
Merry Christmas!
SVN revision: 55840
Subject: [E-devel] [Patch] elm_bubble theme patch
I'm Sohyun Kim. Nice to meet you.
This is a patch for bubble theme.
The bubble has a region for icon, label and info text.
However, it has the region, if icon, label and info text are not set.
I modified theme and added edje signals.
1. add edje signal for label and info text state
2. remove text size for label and info text default state
-> set it on "visible" state
3. add base image state for info text only
SVN revision: 55839
Subject: [E-devel] [Patch] els_scroller momentum_animator and bounce
animator disabled set/get added
This is a patch for momentum_animator and bounce animator
enabling/disabling
in els_scroller.
I added below api for disabling when the scroller's momentum or bounce
animator need to be disabled in some case.
Eina_Bool elm_smart_scroller_momentum_animator_disabled_get
(Evas_Object
*obj);
void elm_smart_scroller_momentum_animator_disabled_set
(Evas_Object *obj, Eina_Bool disabled);
void elm_smart_scroller_bounce_animator_disabled_set
(Evas_Object *obj, Eina_Bool disabled);
Eina_Bool elm_smart_scroller_bounce_animator_disabled_get
(Evas_Object
*obj);
SVN revision: 55690
Reasons for this patch are as follows.
1. Clicked signal is emitted from button when mouse release region
coincides
with button region and there has not been any drag outside the region
during
pressed state. (theme change)
2. Unpressed signal is emitted from button every time we press on
button and
unpress it irrespective of whether we unpress in button's region or
outside.
(theme change)
3. The unsetting of maximum size hint has been removed from _sizing_eval
function as there is a possibility that some application may set this
hint
and if we unset it then this information set by application will be
lost.
4. Modification in test code for button to show the difference between
clicked and unpressed signal emission from this widget. Added a
scroller in
the heirarchy to show the effect of hold on clicked signal emission.
SVN revision: 55687
Subject: [E-devel] [Patch] elm_map module patch
This is a patch for elm_map module.
when app developers or companies want to use specific license map (i.e
google map), module is needed.
- add new map provider for module "ELM_MAP_SOURCE_MODULE".
- add test_map module.
- add test code for module provider.
- add my name to AUTHORS.
SVN revision: 55684
here is a patch for elm_genlist.
Fixing Eina_Bool in elm_genlist.
0 -> EINA_FALSE
1 -> EINA_TRUE
And fixed return value of _item_block_recalc from int to Eina_Bool.
Anybody can review this and apply it to upstream?
Thanks.
Daniel Juyung Seo (SeoZ)
SVN revision: 55673
Subject: [E-devel] elm_cnp_helper patch(check string length)
Dear Brett Nash, and Elementary developers.
It's a elm_cnp_helper patch.
main changes are
1. check string length when retrieving filename
2. adding bmp filetype and ignoring filetype case
(also a type error fix for utf8).
SVN revision: 55656
Subject: Re: [E-devel] elm_label patch(ellipsis, sliding)
It's a elm_label patch.
My previous patch is too big to submit.
So I did split into patch files.
(Thanks for Gastavo and Rasterman)
2. adding label text sliding feature
SVN revision: 55654
Subject: Re: [E-devel] elm_label patch(ellipsis, sliding)
Dear Elementary developers.
It's a elm_label patch.
My previous patch is too big to submit.
So I did split into patch files.
(Thanks for Gastavo and Rasterman)
main changes are
1. refine ellipsis algorithm
- improve to cut string to fit
SVN revision: 55653
Subject: [E-devel] [PATCH] Patch for elm_slider.c (if you click the
bar of the slider, the button will be at there.)
I made one patch for elm_slider.c file.
If you click the bar of the slider, the button will be located at there.
(If you keep your "mouse_down" after moving of the button, you can
continuously move the button.)
SVN revision: 55610
Subject: [E-devel] [PATCH] elm scroller, scrolled entry: events
propagation, min size
It's not possible to connect event handler such as
EVAS_CALLBACK_KEY_UP to
elm_scrolled_entry because the scroller inside the scrolled entry does
not
propagate events. So this is the patch for adding events propagation set
function to scroller and setting it to EINA_TRUE in elm scrolled entry.
And one more thing in scrolled entry, while evaluating its size,
scrolled
entry does not consider its min size.
(It just refers to the min size of its scroller object instead of
scrolled
entry object.)
So here in the attached patch, scrolled entry compares its min size to
the
min size of the scroller object and set the bigger one to its min size
to
keep the min size set by intent.
looks good - some mistakes you made. you forgot the patch that adds
elm_scroller_propagate_events_set() to Elementary.h.in .... i added it
for
you. but remember to include it in your patch next time. Also the
documentation could be a LOT better! i fixed that for you too. also -
you
could have added a elm_scroller_propagate_events_get(). i added that
too for
you. oh.. and you didn't use ELM_CHECK_WIDTYPE().
SVN revision: 55609
Subject: Re: [E-devel] [PATCH] elm widget: make show_region_set
function call all region show functions set by parents
I'm trying to send several patches that I've changed.
This is just the beginning of my patch rushes..
'elm_widget_show_region_set' function works fine in the simple case (any
widget inside one scroller) however, in the complex parent-child case
(such
as entry in the box in the horizontal scroller in the layout in the
vertical
scroller) it doesn't work correctly because all show region functions
set by
scrollers are not called.
So I changed it to call all show region functions set by its parents
widgets
if exist.
Please review the attached patch file and feel free to give me any
kind of
feedback.
SVN revision: 55592
If you try to create a new widget, you must be sure that the parent
is really an evas object.
With the previous implementation it was possible to call an _add
function for an elementary widget with any non-null pointer as parent
eventually causing crashes (like with the elm_box).
SVN revision: 55521
elm_widget_disabled_set was calling focus_jump and it broke the focus tree.
Now, using focus_cycle to pass focus to next object.
Added test to disable focused button in test_focus.
SVN revision: 55408
Subject: Re: [E-devel] [PATCH] els_scroller
els_scroller has some problems.
First, when the function "elm_scroller_page_size_set" is used and the
scroller is bounced,
the signal "scroll,anim,stop" is not called.
Second, the signal "scroll,anim,stop" is called at the time
"ELM_THUMBSCROLL_FRICTION",
even if the animation of scroller end before the time.
So I changed the code "els_scroller.c".
Patch code is the following.
SVN revision: 55341
Subject: [E-devel] [PATCH] elm_slider patch for disable state
elm_slider does not support disable state, so I make this patch.
Please review it and upload in svn if it is ok.
(nb - also fixed vertical slider sizing in defaul theme and changed
jihoons changes to slider test to make the vertical sliders in a
horizontal box so they dont get silly long windows)
SVN revision: 55340
Subject: [E-devel] [PATCH] Some modifications for adapting
elm_longpress_timeout_get().
I made a patch for adapting elm_longpress_timeout_get() function to all
winsets, using long press event.
And I checked one warning in elm_entry.c , so I modified it.
SVN revision: 55339
When we have time, we'll research a way of signalling
mouse events from bottom up, too (or at least emulate that).
Might be useful for "trapping" mouse wheel events, what
Elementary can't do as is.
SVN revision: 55325
The Api is very large, probably there is some EINA_ARG_NONNULL that are
missing in some parameters and others that I put that should not be
there, I tried my best to not have these mistakes, if you find
any, please, fix it :).
SVN revision: 55189
As we talked last week, I made a version of adding external image in
elm_entry. It seeks a local file if prefix is 'file://' then it loads image and adds it. If image file can't be loaded, adding
wft emoticon.
patch in with minor fix for path and an added actual test case in elm
entry test.
SVN revision: 55134
The reason for modifying about elm_colorselector can be "readability".
Each bar in the colorselector has its own color type (like hue, saturation,
...)
So I thought it will be better, if I added enum for each color type.
And, for about elm_entry.c , I thought that "SIG_CLICKED" was wrongly
emitted (by "MOUSE_UP" event).
I deleted mouse_up callback function (as you advised),
because this function didn't do anything by my modification.
By: WooHyun Jung <wh0705.jung@samsung.com>
SVN revision: 55097