Commit Graph

9263 Commits

Author SHA1 Message Date
Ryuan Choi a3c5ee407f elm_cnp: Fix that calls _x11_elm_widget_xwin_get two times at elm_cnp_selection_{set|get}
small refactoring.
2014-01-23 22:22:33 +09:00
ChunEon Park f8d00ae0f2 elementary - override widget translation but work also the base widget's behavior.
Some widgets override the widget translation but it didn't inherit the base widget's function.
Becuase of it,The language changed won't be properly called in the widget tree.

Now it fixed it.
2014-01-23 20:20:43 +09:00
ChunEon Park 39ad0e358e elementary - support language changed callback from a few widgets.
support a language,changed callback if a widget has the text part in default.
2014-01-23 20:07:20 +09:00
ChunEon Park dbacb2fef9 elementary - send signal "language,changed" with one way in the widget.
Call the smart callback in the widget infra so that each widget don't need to hook the smart_translate only for the smart call.

This makes reducing duplicated code and supporting language,chagned from all widgets.
2014-01-23 19:30:34 +09:00
ChunEon Park aebdcff513 elementary - use the focused/unfocused string in widget defined.
Now, it will share the strings so that reduce the binary size also user uses it in one way.
2014-01-23 17:27:17 +09:00
WooHyun Jung 9b0b34e801 test_focus3: Correct wrong data for smart callback. 2014-01-23 15:07:33 +09:00
Amitesh Singh aed0272e8c focus: Fixed focus issue that the highlight was not visible on first

Focus highlight was not visible on first click on a widget with focus_highlight enabled on the window.
This happens because on first click, the "elm,action,focus,show" signal was emitted before setting focus highlight edje object as theme object of elm window.
In this patch, moved the  _elm_win_focus_highlight_visible_set() call after focus highlight edje object set as theme object of window.
This fixes T774.

Test Plan:
elementary_test->focus then click any widget. Focus won't appear for the first time.

Reviewers: seoz, raster, woohyun

Maniphest Tasks: T774

Differential Revision:
2014-01-23 14:12:53 +09:00
Carsten Haitzler 91c61d0837 naviframe - don't access item after del 2014-01-23 11:59:07 +09:00
Daniel Juyung Seo f79a003b6b test_hoversel: Change the hoversel button text when an hoversel item is

This reveals hoversel bug on mobile profile that changes the size of
text parts on continuous item change.
2014-01-23 01:51:04 +09:00
Daniel Juyung Seo 3eb9e6b4cf spinner: Uncomment ctype.h inclusion because isspace is used.
It looks like ctype.h is included in some other headers by luck but it
is recommended to explicitly include the necessary header.
Confirmed by glima as he commented this out.
2014-01-23 01:31:53 +09:00
Daniel Juyung Seo ac00267206 spinner: Internal code clean up for spinner.
- Used macro for constant.
- Changed timer name to be more descriptive.
- Added descriptions about timers.
2014-01-23 01:31:53 +09:00
Carsten Haitzler 69144caceb theme - win shadow - stack under all so pulsing icon is not BELOW the shadow. 2014-01-23 00:28:13 +09:00
Daniel Juyung Seo e7528a2e78 naviframe: Use elm_widget_item_del() when you want to delete the item

It will call del_pre_func and free the item data.
Special thanks to glima for the report.
2014-01-22 23:33:47 +09:00
Jaehyun Cho 404093c701 [naviframe] Fix to enable item deletion in pop_cb
Summary: Fix to enable item deletion in the registered pop_cb function

Reviewers: Hermet

Reviewed By: Hermet

CC: seoz

Differential Revision:
2014-01-22 22:13:51 +09:00
Jaehyun Cho 1ca6d33e08 [naviframe] do not size evaluate during deletion
Summary: Author: Shinwoo Kim <>  2012-12-11 20:13:39

Reviewers: Hermet

CC: seoz

Differential Revision:
2014-01-22 22:09:16 +09:00
Jaehyun Cho ef93bf6616 [naviframe] Fix to hide the previous view by emitting signal
Previously, previous view was hidden by evas_object_hide.
         However, this method is no longer correct because size calculation of naviframe causes evas_object_show.
         Now, previous view is hidden by emitting signal to naviframe theme and clipper hides the previous view.

Reviewers: Hermet

Reviewed By: Hermet

CC: seoz

Differential Revision:
2014-01-22 22:07:31 +09:00
Daniel Juyung Seo 8298782bdc fileselector: Make fileselector focusable. Ok on Enter key and Cancel on Escape key.
Now fileselector accepts the key event on Enter and Escape.
2014-01-22 18:43:18 +09:00
Daniel Juyung Seo 0ddb97b377 fileselector_button: Added missing description about focus signals. 2014-01-22 18:43:18 +09:00
WooHyun Jung 811c38145d popup: Replace focus_direction_go with focus_cycle. 2014-01-22 18:36:13 +09:00
Carsten Haitzler 1d59d62703 theme update to handle rename on/off in efm
shoudl fix T799
2014-01-22 18:32:24 +09:00
WooHyun Jung cbb946ee99 elm_widget: Fixed some codes about focus custom chain.
- When appending an object to the focus custom chain,
  event callback about deletion should be added.
- When a widget is deleted, its focus custom chain should be
  managed correctly.
2014-01-22 16:24:25 +09:00
Daniel Juyung Seo 87b3d7d5b5 ctxpopup: Fixed typo and flourished comment. 2014-01-22 15:20:24 +09:00
Carsten Haitzler 59bc4cff0e elm filesel - scale button in filesel button. 2014-01-22 15:19:17 +09:00
Carsten Haitzler 3ee1a576e3 elm filesel - fix theme layout for button+entry 2014-01-22 15:17:47 +09:00
Carsten Haitzler 5c04d8866e inwin - the "greying out" fade looks just wrong - make it black. 2014-01-22 15:14:15 +09:00
Jihoon Kim 54ec084e76 fix some typos in comment and description 2014-01-22 13:20:15 +09:00
Daniel Juyung Seo 47073aaf58 test_conform_indicator: Refactor internal code of conform_indicator test

- removed unnecessary casting.
- removed unnecessary internal variables.
- removed wrong window resize object addition.
- changed parent parameter correctly.
- fixed wrong grammar in command line message.
- fixed resource leak.
- enhanced comments.
- removed unnecessary size hint align set.
- removed unnecessary parameter passing.
2014-01-22 12:32:32 +09:00
Daniel Juyung Seo 3c07d8d9a6 config: Added more description about elm_config_indicator_service_get(). 2014-01-22 12:07:55 +09:00
Youngbok Shin 89c3d430a3 entry: Fixed to emit "*enabled" signal to scr_edje when it is not disabled.
Summary: This fixes coverity issue CID 1162751.

Reviewers: seoz, woohyun, tasn

Reviewed By: seoz

Differential Revision:
2014-01-22 11:32:08 +09:00
Daniel Juyung Seo ae9cb7e40f elm: Removed unnecessary null checks.
As all efl public free apis  and free function get null as valid parameter,
we do not need to check null. I also used ELM_SAFE_FREE if necessary.
After this job code got cleaner.

This is a continue of a commit e3372339.
2014-01-22 11:14:33 +09:00
Daniel Juyung Seo 3e45b920ee elm: Removed unnecessary null check for eina_hash_free and
2014-01-22 11:13:30 +09:00
Daniel Juyung Seo 5353aa863c elm: Removed unnecessary null check for free. 2014-01-22 11:13:11 +09:00
Daniel Juyung Seo 0d1ac0fa05 elm: Removed unnecessary null check for eina_list_free. 2014-01-22 10:55:01 +09:00
Daniel Juyung Seo 0c3c2572b9 elm: Removed unnecessary null check for ecore_event_handler_del. 2014-01-22 10:54:58 +09:00
Daniel Juyung Seo db5fe2581d elm: Removed unnecessary null check for evas_object_del. 2014-01-22 10:54:52 +09:00
Daniel Juyung Seo 43533a2fb9 elm: Removed unnecessary null check for eina_stringshare_del. 2014-01-22 10:54:45 +09:00
Daniel Juyung Seo c066009c49 elm: Removed unnecessary null check for ecore_idler_del, ecore_idle_enterer_del. 2014-01-22 10:54:28 +09:00
Daniel Juyung Seo b6b90d7c83 test, examples fileselector_entry: Changed the usage of deprecated APIs
to recommended APIs.
2014-01-21 23:53:48 +09:00
Daniel Juyung Seo c0d6b27a16 fileselector_entry: Moved declarations of deprecated APIs to
elm_deprecated.h and marked them as EINA_DEPRECATED in c code.
2014-01-21 23:50:31 +09:00
Daniel Juyung Seo b3dff64665 test, examples fileselector_button: Changed the usage of deprecated APIs to recommended
2014-01-21 23:44:29 +09:00
Daniel Juyung Seo 471db42fe4 fileselector_button: Moved declarations of deprecated APIs to
elm_deprecated.h and marked them as EINA_DEPRECATED in c code.
2014-01-21 23:43:41 +09:00
Daniel Juyung Seo 68eca6d62e url: Added underscore(_) to elm internal functions, elm_url_xxx.
- _elm_url_download, _elm_url_cancel, _elm_url_get
- other internal functions in elm_priv.h also have same prefix.
2014-01-21 23:23:37 +09:00
Daniel Juyung Seo a4f3074f9c elm: Removed unnecessary null check for ecore_timer_del,
ecore_animator_del, and ecore_job_del.

As all efl public free apis get null as valid parameter, we do not need
to check null. I also removed some null check for other free apis which
were right next to timer/animator/job del. After this job code got
2014-01-21 23:18:16 +09:00
Ryuan Choi 26dd1db99c Introduce fileselector interface and applied to elm_fileselector.
fileselector_button and fileselector_entry should have almost same interfaces with fileselector.
Previously , we exposed them individually such as elm_fileselector_is_save_set().

Instead of adding the same APIs three times, we can reuse one fileselector's API using Eo interface.

This patch introduced fileselector interface and applied it to elm_fileselector.

Reviewers: seoz, raster

Reviewed By: raster

Differential Revision:
2014-01-21 22:50:35 +09:00
Daniel Juyung Seo 5d45fc195f spinner: Create an internal entry when it is really needed.
Do not create the internal entry on smart add. Create that when it is
needed with editable mode.
2014-01-21 22:12:53 +09:00
Daniel Juyung Seo 8253767035 spinner: Toggle entry on Enter and space key. 2014-01-21 21:59:41 +09:00
WooHyun Jung 6eb6f805ba entry: NULL should be set to the correct position of tmpbuf.
If edje_object_part_text_get gives different text from original one,
length of text can be changed. So the last position of tmpbuf should
be calculated again refering to the current text to be returned.
2014-01-21 21:00:29 +09:00
Daniel Juyung Seo 068c9a095f toolbar: Do not check ev->string for Return key and react on space key.
space key works as same as Return key.
2014-01-21 19:58:10 +09:00
Daniel Juyung Seo fec8441c71 elm: Fixed formatting about EINA_LOG stuff. 2014-01-21 19:58:09 +09:00
Daniel Juyung Seo ec59ba6363 test_focus: Call window object show after its content creation.
This is a successor commit of 64fd5a825b24591aedb9cac695d03f5b4d867442.
Window show call triggers all smart objects' smart calculation and in case of
X11, XMapWindow() is called directly.
Also moved resize of window accordingly.
2014-01-21 19:58:09 +09:00