Summary:
When gengrid item is reordered or deleted, gengrid didn't update item's position.
This Patch update item's position when item is placed. if middle of item deleted,
every item after the deleted one, will re-postion on _item_place function, so they
will be update there position well.
Test Plan:
modify test_gengrid grid_sel fuction to print there position. so when item selected,
they print there position and it works fine both horizontal and vertical.
Reviewers: bluezery, seoz, raster
Reviewed By: raster
CC: Hermet, chinmaya061
Differential Revision: https://phab.enlightenment.org/D855
Summary: This is an optimization over parent set to hoversel object.
Reviewers: seoz, raster
CC: seoz
Differential Revision: https://phab.enlightenment.org/D853
Summary:
Earlier focus was moving to top item from bottom item on LEFT key and to bottom item on RIGHT Key
in case of vertical hoversel.
@fix
Test Plan: elementary_test -to "Hoversel Focus"
Reviewers: raster, seoz
Reviewed By: seoz
CC: seoz, chinmaya061
Differential Revision: https://phab.enlightenment.org/D858
Summary:
Even if a entry is not editable, user can select text in the entry.
When the entry has selection, we have to support "copy" option.
@fix
Test Plan:
Precondition: Apply D852 patch for fixing a bug in elementary_test
1. elementary_test -to entry7
2. Select some text in the non-editable entry.
3. Press mouse right button.
Note: You can test it in Desktop profile.
Reviewers: tasn, woohyun, seoz
Differential Revision: https://phab.enlightenment.org/D848
Summary:
Fix to skip the item which is disabled and select the next item to the
disabled item
@fix
Reviewers: seoz, raster
CC: seoz, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D700
Since SHADOW adds one pixel padding, the whole object size
was calculated with one extra pixel. Let's add it back
to keep the overall visual balance of buttons.
A few other widgets might visually change after the edje
padding fix:
- Check (looks better)
- Naviframe (smaller height)
- E date widget
- ...
But I did not see anything "weird" that needs fixing.
See EFL 5bf1f0c9187525cf40782b26d7fa49d2676f91bb:
edje_calc: Don't add padding twice to text objects
Text objects declared in Edje will see their padding added twice,
as the Evas_Object_Text itself contains the padding already.
This WILL break some EDC files. It's a bug nonetheless.
Summary:
Show and bring in a region which has the given latitude and longitude after zooming
@fix
Reviewers: Hermet
CC: seoz
Differential Revision: https://phab.enlightenment.org/D851
Summary:
Layout's sub_object_del function calls sizing_eval even if layout's smart_del
function has already been called (Due to widget_smart_del impl).
This patch adds 'destructed_is' flag to Elm_Layout_Smart_Data and prevents unneeded
sizing_eval calls when object is already destructed.
Patch also fixes SIGSEGV in layout derived entry widget caused by calling
sizing_eval after entry_smart_del destructor.
Added entry test to avoid regression for SIGSEGV bug.
Test Plan: run tests/elm_test_entry
Reviewers: raster, seoz, tasn, cedric
Differential Revision: https://phab.enlightenment.org/D823
Summary:
elm_entry_context_menu_disabled_set API is called to wrong entry.
It should be called to "en2" that added for testing the API.
@fix
Test Plan: 1. elementary -to entry7
Reviewers: woohyun, seoz, tasn
Reviewed By: seoz
CC: herdsman
Differential Revision: https://phab.enlightenment.org/D852
Summary:
Calculating the coordinate of the object to retain the focus with in view port.
Earlier focus was moving out of view port.
Test Plan:
elementary_test-> "Focus 3". Enable the Focus Auto scroll bring in and use
keys to move focused item.
Reviewers: raster, seoz, singh.amitesh, nirajkr
Differential Revision: https://phab.enlightenment.org/D822
Summary: Load a map theme with a style to support customized style
@fix
Reviewers: Hermet
Reviewed By: Hermet
CC: seoz
Differential Revision: https://phab.enlightenment.org/D845
As widget and widget item can have different in_theme value (since
30cada369), we need to update in_theme value whenever the widget or
widget item get the focus.
Applied this logic to genlist, gengrid, toolbar first.
List focus is not working well at the moment.
This fixes small focus highlight on the left top corner of genlist
when the genlist scroller is clicked before the genlist is focused.
Special thanks to zmike for the report.
elm_config_focus_auto_scroll_bring_in_enabled_get/set()
->
elm_config_focus_autoscroll_mode_get/set()
The main reason is that bring_in_enabled_get/set() APIs are too restricted
and thus not flexible. I got more requirements for the focus autoscrolling
such as none, wholely visible not just bring_in and show. So it is correct
to add mode_set/get() APIs for the focus auto scrolling.
Thanks god, we've found this before the release :)
@feature
This reverts commit 377179bdaf84aa1a86621cdfa64ed43613ab9d45.
The main claim of https://phab.enlightenment.org/T1205 was fixed in
the previous commit 30cada369. This code will be modifed again in the
next commit due to the api change during development life cycle.
Note: do not blindly revert this commit if you have any problem with
widget item focus. This commit is not related to any fundamental cause
of the issues. If you have a problem, please contact me first.
seojuyung2@gmail.com or SeoZ on IRC.
Thanks.
This was introduced during 1.10 development phase but this changed the
default focus behavior and got a lot of complaints. (especially from
discomfitor)
So I would like to comment this out now and make it optional on 1.11
by keeping the default behavior.
Fixing this issue is not trivial and will bring another issues like crashing.
So it is better to fix this in a development phase by refactoring list.
To fix this issue, the following are needed:
1. it->walking concept should be adopted instead of using just sd->walking.
sd->walking was introduced in beb418d6
2. elm_widget_item_del() should be called instead of the combination of
_elm_list_item_free() + elm_widget_item_free()
This was introduced in f343011d
This fixes variable initialize problems related to focus. This can be
reproduced when you enable focus highlight/animation and reuse
elm_list by clearing it.
This problem occurred because list item del pre is never been called.
This bug will be addressed in a next commit.
Unified the local variable name to ret if the ret is a return value of
another content_unset calls.
- Evas_Object *int_ret --> Evas_Object *ret
- Evas_Object *int_content --> Evas_Object *ret
- Evas_Object *content --> Evas_Object *ret
Daniel Juyung Seo
Carsten Haitzler
SangHyeon Lee
Amitesh Singh
zmike
Youngbok Shin
nirajkr
Jean-Philippe Andre
Jaehyun Cho
Lukasz Stanislawski
Mike Blumenkrantz
Anand
Stefan Schmidt
Davide Andreoli
Cedric Bail