Commit Graph

23749 Commits

Author SHA1 Message Date
Mike Blumenkrantz ea3803e6fb tests: add test to verify genlist item deletion
Reviewers: stefan_schmidt

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5963
2018-04-20 14:31:11 +02:00
Bowon Ryu f176aece65 evas_engine: remove logically dead code
Summary:
"plane" exception value is already filtered at line 1791.
execution cannot reach this statement.

Reviewers: cedric, Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Differential Revision: https://phab.enlightenment.org/D5973
2018-04-20 19:07:39 +09:00
Bowon Ryu f5479c19ff ecore_con: remove unused code
Test Plan: N/A

Reviewers: cedric, Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Differential Revision: https://phab.enlightenment.org/D5975
2018-04-20 18:28:23 +09:00
Bowon Ryu 90135320d1 efl_ui_progressbar: add null check
Summary: a segmentation fault occurs once the argument is not valid.

Test Plan: N/A

Reviewers: cedric, Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5974
2018-04-20 17:49:44 +09:00
Jaehyun Cho 57cfa21836 efl_net_control_access_point-connman: Fix build warning 2018-04-20 17:34:00 +09:00
Carsten Haitzler dd1e6fbf9a elm - fix build break (against efl - missing header)
cant build against efl after 939690a8a9.
this fixes that.
2018-04-20 17:30:54 +09:00
JongMin Lee 47caa0115a elm: resolve possible memory leak.
@fix
2018-04-20 16:45:50 +09:00
JongMin Lee c21ffd8735 elm: resolve possible memory leak.
@fix
2018-04-20 15:59:49 +09:00
Hermet Park 7048cc6259 ector cairo: fix a memory leak.
Here don't need to use heap memory.

@fix
2018-04-20 15:47:40 +09:00
JongMin Lee a07d729b2f elm: resolve possible memory leak.
@fix
2018-04-20 15:41:32 +09:00
JongMin Lee a42451d688 elm: resolve possible memory leak.
@fix
2018-04-20 15:36:32 +09:00
JongMin Lee b1caf014ef ecore_wl_dnd: correct wrong variable assignment
@fix
2018-04-20 15:29:44 +09:00
Jaehyun Cho fcffd58223 efl_net_control_access_point-connman: Remove unused code
if the method is EFL_NET_CONTROL_ACCESS_POINT_PROXY_METHOD_UNSET, then
the function is returned before.
2018-04-20 14:28:41 +09:00
Jaehyun Cho 0bebd097b5 elc_multibuttonentry: Fix to make multibuttonentry to be legacy only
To make multibuttonentry to be legacy only, inappropriate efl ui
interface usages are removed in multibuttonentry.
2018-04-20 14:07:35 +09:00
Hermet Park fd85423ae3 ecore: fix a potential memory leak.
if the func argument is null, allocated memory won't be freed properly.
return it as soon as possible.

@fix
2018-04-20 13:29:46 +09:00
Hermet Park 215b854b54 edje edje_cc: fix memory leak.
This token has temporary alloc'd memory.
We should free it before loosing its ptr address.

@fix
2018-04-20 13:12:22 +09:00
Hermet Park 5ea2f94ffb edje: Don't access a garbage pointer.
set null to avoid multiple access.
At 221 line, it tries to free tmp again.
2018-04-20 11:44:43 +09:00
Lauro Moura 1179058017 efl_mono: Fix after prop get const change 2018-04-19 14:06:02 -03:00
Stephen 'Okra' Houston cf359629a5 Focus: If tree focus is set to not allow focus on the object - don't give it focus.
Patch from Marcel 'bu5hm4n' Hollerbach
2018-04-19 11:19:51 -05:00
Lauro Moura 90f7144e81 elementary: Fix multibuttonentry legacy build.
Summary:
The legacy header was still referencing the eo class removed in
939690a8a9.

Reviewers: cedric, Jaehyun_Cho, vitor.sousa

Reviewed By: vitor.sousa

Differential Revision: https://phab.enlightenment.org/D5970
2018-04-19 12:38:19 -03:00
Jaehyun Cho d767c31a57 test_ui_stack: Add test using Efl.Ui.Stack class
Add test using Efl.Ui.Stack, Efl.Ui.Navigation_Layout, and
Efl.Ui.Navigation_Bar classes.

Navigation_Bar widget is set into Navigation_Layout widget and
Navigation_Layout widget is pushed into Stack widget.
2018-04-19 23:40:10 +09:00
Jaehyun Cho 6c65b6368a efl_ui_navigation_bar: Add Efl.Ui.Navigation_Bar class
Efl.Ui.Navigation_Bar is a widget which provides a bar form useful for
navigation.
2018-04-19 23:40:06 +09:00
Jaehyun Cho 7e8722be00 efl_ui_navigation_layout: Add Efl.Ui.Navigation_Layout class
Efl.Ui.Navigation_Layout is a widget which provides a layout form useful
for navigation.
2018-04-19 23:40:01 +09:00
Jaehyun Cho ab4fa83f62 efl_ui_stack: Add Efl.Ui.Stack class
Efl.Ui.Stack is a container arranges objects in stack structure by
pushing and popping them.
2018-04-19 23:39:57 +09:00
Jaehyun Cho e3315baaa3 efl_canvas_object: Add events for state changes of object's animation
Add events to notice the state changes of canvas object's animation.
anim_started, anim_running, and anim_ended events are added.
2018-04-19 23:39:32 +09:00
Woochan Lee 939690a8a9 Revert Efl.Ui.Multibuttonentry to create new one.
Summary:
Revert e02b2f04c2945ad60fab5612af1e02b0838b7ff5.

I couldnt make a revert commit for many commit has been related with above commit.

I will create a new MBE eo class ASAP. (https://phab.enlightenment.org/T5358)

Reviewers: cedric, woohyun, Jaehyun_Cho, SanghyeonLee, herb

Reviewed By: Jaehyun_Cho

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5954
2018-04-19 22:22:01 +09:00
Daniel Kolesa a2ccdb7b21 eolian: re-enable non-dependencied parsing
The issue was that standalone-parsed files (outside of dependencies
of some other unit) were not being included in that dependency tree
(obviously) which resulted in their own dependency tree being
excluded from merging, causing the database hashes to lack the
necessary elements.

To fix this, I trigger merging of the "standalone" dependency trees
separately, by calling _merge_units from defer parsing cb.
2018-04-19 13:44:14 +02:00
Daniel Kolesa 974fa323a1 eolian: disable non-dependencied parsing for the time being
As 543902f2ba breaks build,
disable parsing with state as a parent for now, until the issue
is figured out.
2018-04-18 21:17:31 +02:00
Lauro Moura 15fcaaec69 elm: Move legacy genlist types to elm_general.
Summary: Fixes T6771

Reviewers: bu5hm4n, felipealmeida

Subscribers: q66, cedric

Maniphest Tasks: T6771

Differential Revision: https://phab.enlightenment.org/D5938
2018-04-18 19:03:19 +02:00
Daniel Kolesa 543902f2ba eolian: make doc ref resolution global
Doc refs no longer introduce new dependencies into files. Instead,
they're parsed globally, and any doc ref lookup is also made
globally. This allows unit based dependencies to correspond more
to what files actually really need at compile time/runtime, with
docs being irrelevant to that; it also simplifies the API.

The doc resolution API now takes Eolian_State instead of
Eolian_Unit, too.
2018-04-18 16:38:14 +02:00
Daniel Kolesa d13cfe1b83 eolian: doc ref validation cleanup 2018-04-18 16:38:14 +02:00
Daniel Kolesa 28b1dd25c7 eolian: add internal api for dep deferring + parsing without dep
This is cleaner than adding into a hash manually. Additionally, it
is now possible to request that the file be parsed not as a dep,
but rather standalone, which will be useful later.
2018-04-18 16:38:14 +02:00
Daniel Kolesa 311fada0d2 eolian: simpler and more efficient defer parsing 2018-04-18 16:38:14 +02:00
Derek Foreman 50a9b49acc elm_win: Don't do auto norender on non X11 engines
This only really makes sense on X11 and can lead to some seriously
confusing cases on other engines (*cough* wayland) when elm's idea
of iconified state doesn't match the compositor's.

While currently only X11 is whitelisted, other backends can be
added, though I suspect most are more like wayland where it makes
no sense at all.

ref T6834
2018-04-18 09:15:39 -05:00
Mike Blumenkrantz ab430e3ee5 tests: preload elm csd theme in elm_suite startup
Summary:
ref T6864
Depends on D5958

Reviewers: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6864

Differential Revision: https://phab.enlightenment.org/D5959
2018-04-18 13:58:15 +02:00
Mike Blumenkrantz 9bfa85fdf0 tests: skip second ecore_shutdown call in elm_suite when forking
Summary:
init is only called here to verify the refcount, shutdown is only necessary
when not forking in order to preserve the environment

ref T6864

Reviewers: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6864

Differential Revision: https://phab.enlightenment.org/D5958
2018-04-18 13:57:49 +02:00
Stefan Schmidt 72f4ab875d examples: cxx: fix some missing const attributes in colourable*
Fixing some fallout from fcae7cab27

Given that the examples do not build for weeks with CXX enabled this is
just the tip of the iceberg.
2018-04-18 10:15:26 +02:00
YeongJong Lee 2c8c7807f1 config: fix Efl.Ui.Slider key binding
Summary: this fixes T6796

Test Plan: elemetary_test -to slider

Reviewers: woohyun, Hermet, Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric

Maniphest Tasks: T6796

Differential Revision: https://phab.enlightenment.org/D5962
2018-04-18 15:34:35 +09:00
Derek Foreman 73beab6a08 ecore_con: Fix build
commit fcae7cab27 broke connman stuff,
I've blindly fixed it up here.  I don't actually use or test ant of this
but apparently I build it.

If it's broken, please mail the pieces to Daniel Kolesa.

Ref T6859 I guess
2018-04-17 14:49:20 -05:00
Daniel Kolesa fcae7cab27 eolian gen: enable constness generation on property getter impls
This changes a lot of things all across the EFL. Previously,
methods tagged @const had both their external prototype and
internal impl generated with const on object, while property
getters only had const on the external API. This is now changed
and it all has const everywhere.

Ref T6859.
2018-04-17 20:31:55 +02:00
Derek Foreman e50b43d02f ecore_wl2: handle configure_complete after handling configure
since configure_complete may result in a draw op, configure should be
handled first so the size is correct.
2018-04-17 11:12:27 -05:00
Mike Blumenkrantz 67705589ac tests: preload elm_init and default theme groups in elm_suite
Summary:
opening the default theme file can take up to 0.2s in worst case during
a test

ref T6864
Depends on D5914

Reviewers: stefan_schmidt

Reviewed By: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6864

Differential Revision: https://phab.enlightenment.org/D5915
2018-04-17 15:43:52 +02:00
Mike Blumenkrantz 22cb35c9a4 tests: use loop test to split jpeg tests from evas_object_image_all_loader_data
Summary:
jpeg loader tests take 4+ seconds due to manual value comparisons, so ensure
that they run separately

ref T6856

Reviewers: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6856

Differential Revision: https://phab.enlightenment.org/D5911
2018-04-17 15:14:52 +02:00
YeongJong Lee c943c4a2ff elm_dbus_menu: add missing const for Eina_List
Summary:
This fixes following warning

../src/lib/eina/eina_list.h:1421:10: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]

Test Plan: make

Reviewers: SanghyeonLee

Reviewed By: SanghyeonLee

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5952
2018-04-17 11:08:25 +09:00
Davide Andreoli 01a95d1f40 Revert "Genlist: restore old behaviour of item next/prev in group items"
This reverts commit f0a0da9f44.

As per T5938 seems we really want to restore a totally wrong
behaviour, without taking care of newer apps being broken.

I revert this for now, but I'm still convinced that we must
find a way to let user use a sane ordering for newer app.

I'm thinking about adding an api in genlist to let the widget
use the new sane ordering, something like
elm_genlist_fixed_ordering_set(bool) so that new apps can use
this to ensure correct behaviour. zmike what do you think about
this solution?
2018-04-17 00:11:11 +02:00
junsu choi ad6ef48053 eo : Add null check
Summary:
This commit add null check on __efl_auto_unref_set.
In EO_OBJ_POINTER, if obj_id is null, obj can also be null.

Test Plan: N/A

Reviewers: woohyun, kimcinoo, cedric

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5869

Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-04-16 11:24:29 -07:00
SubodhKumar b650325b88 edje: Dont append font source if fonts are not embedded in edje
Summary:
If font source is not embedded in edje, it should not
be appended in font source to skip the lookup in edj file
while loading font.

@fix

Test Plan: NA

Reviewers: cedric

Reviewed By: cedric

Subscribers: shilpasingh

Differential Revision: https://phab.enlightenment.org/D5909

Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-04-16 11:23:23 -07:00
Bryce Harrington 4ea4a20455 eina: Improve documentation formatting
Summary:
Revise wording of a few parameters, improve consistency of punctuation
and documentation body placement.

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5918

Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-04-16 11:21:50 -07:00
Wonki Kim d1ed913f85 elementary: Remove unreachable code lines
Summary: This patch removes unreacahble code lines

Reviewers: cedric, woohyun, eagleeye

Differential Revision: https://phab.enlightenment.org/D5923

Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-04-16 11:21:21 -07:00
Bryce Harrington 025b54ce52 eina: Cleanup documentation for Sparse Matrix.
Summary:
Revises some descriptions, polishes wording, makes punctuation and
formatting more consistent, and straightens out some convoluted grammar
here and there.

There are a few places where the parameter documentation was incorrectly
cut-and-pasted from other routines, so this is fixed.  Also, in
eina_matrixsparse_iterator_new() the docs say the elements are not
returned sequentially, but from the context and code I think it meant to
say they're not _consecutive_.

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5924

Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-04-16 11:20:24 -07:00
Wonki Kim 34216aa9eb Fix a shutdown logic to be reachable in some case
Summary:
move evas_async_events_shutdown: to out of EVAS_CSERVE2 ifdef block
to make it reachable.

Reviewers: cedric, woohyun

Differential Revision: https://phab.enlightenment.org/D5926

Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-04-16 11:18:29 -07:00
SangHyeon Lee 9c8ebc9dfc elm_menu, toolbar, ctxpopup : remove unnecesary interface efl_ui_item and efl_ui_menu
Summary:
Legacy menu toolbar and ctxpopup are not new efl interface widget,
but it have efl interfaces, efl_ui_item and efl_ui_menu.
if we plan to implement this two, it should be a class not a interface,
so I remove it on legacy widget.

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5939

Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-04-16 11:03:02 -07:00
Mike Blumenkrantz 9dcf6f71d0 ecore: further reduce pipe wait time during shutdown.
Summary:
it turns out that 0.01s is actually a lot, accounting for something like
20s across a run of 'make check' while providing no additional value

ref e0c8ab4c79
ref T6825
ref T6864

Reviewers: cedric

Maniphest Tasks: T6864, T6825

Differential Revision: https://phab.enlightenment.org/D5941

Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-04-16 10:57:32 -07:00
Mike Blumenkrantz 7708154069 tests: remove explicit checks for eina mempool tests
Summary:
this was only a temporary measure
Depends on D5916

Reviewers: stefan_schmidt

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5937
2018-04-16 12:24:35 +02:00
Mike Blumenkrantz 576570ce27 tests: flush stdout after printing test suite timing info
Summary:
avoid repeating lines

Depends on D5937

Reviewers: stefan_schmidt

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5917
2018-04-16 12:24:35 +02:00
Mike Blumenkrantz 1885374ce5 tests: do not attempt to parallelize test suites with only 1 test case
Summary: Depends on D5911

Reviewers: stefan_schmidt

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5916
2018-04-16 12:24:35 +02:00
YeongJong Lee ffbbf7b7d6 elm_list: check there is focused item when list get focus at first
Summary:
list have got focus. but there isn't logic to check whether focused_item exist.
we need that logic for list focus
this fixes T6807, T6799

Test Plan: elementary_test -to 'list focus'

Reviewers: bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric

Maniphest Tasks: T6807, T6799

Differential Revision: https://phab.enlightenment.org/D5935
2018-04-15 11:52:34 +02:00
Davide Andreoli f0a0da9f44 Genlist: restore old behaviour of item next/prev in group items
Commit fd82c2521 has changed the behaviour of item_next/prev_get()
in case of genlist with group items (not tree).

The lagacy behaviour was to tread normal items and group items
in a flat way, like if group items was on the same level of
the children normal items.

As the commit already implement bug compatibility, seems to me
the case to restore also this case. Note that this changes only
apply to legacy genlist (I think).

Let me know if this broke something for you...as touching genlist
code is always an "I hope this is right" operation.
2018-04-13 20:37:36 +02:00
Carsten Haitzler 703277b242 efl selection manager - fix x11 cnp from entry to plain text conversion
use sel data not input data/size... copy & paste fix problem...
fixes 28d06f9a5f
@fix
2018-04-13 23:28:21 +09:00
Daniel Kolesa b8f28e2a99 elua: get rid of lightuserdata for state retrieval
In order to get around the lightuserdata 48-bit problem, split
the state pointer into two and reconstruct it later as necessary.
2018-04-13 15:40:05 +02:00
Mike Blumenkrantz 224ff7c86a tests: fix iterator leak in evas mesh tests
Summary: Depends on D5911

Reviewers: stefan_schmidt

Reviewed By: stefan_schmidt

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5912
2018-04-13 13:53:39 +02:00
Mike Blumenkrantz 5490db74a0 tests: remove sleep() calls from eo tests
Summary: fix T6854

Reviewers: stefan_schmidt

Reviewed By: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6854

Differential Revision: https://phab.enlightenment.org/D5910
2018-04-13 13:53:39 +02:00
Mike Blumenkrantz 00f8541d6d tests: split elm_test_init into separate test suite (inside elm_suite)
Summary:
check whether init+shutdown work explicitly before proceeding to other
tests
Depends on D5913

Reviewers: stefan_schmidt

Reviewed By: stefan_schmidt

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5914
2018-04-13 13:53:39 +02:00
Derek Foreman e066e574cb Revert "elm entry - fix wayland bug by not updating selection until after mse up"
Summary:
This reverts commit b0a7c4b086.

This is adding another EFL bug to work around an EFL bug.

Reviewers: raster

Subscribers: devilhorns, stefan_schmidt, bu5hm4n, thiepha, cedric

Differential Revision: https://phab.enlightenment.org/D5933
2018-04-13 20:50:24 +09:00
Carsten Haitzler eab91edcb2 efl selection manager - fix dnd end handling to only handle on dnd
dnd end handling was being done even if no dnd started, like an
ungrab. this caused side effects like stoping selections in their
tracks.

@fix
2018-04-13 20:50:24 +09:00
Marcel Hollerbach 803fddea5d efl_ui_focus_manager_calc: do not redirect requested calls
this is not documented and does not make sense.
2018-04-13 11:07:34 +02:00
Marcel Hollerbach 9d5a9cf2e1 efl_ui_focus_util: add helper for getting the highest manager objekt 2018-04-13 11:07:34 +02:00
Marcel Hollerbach e5001b2cf3 elm_suite: add test for request_move 2018-04-13 11:07:34 +02:00
YeongJong Lee 35e7b36411 efl_ui_focus_manager_calc: a node from focus_stack is always normal node.
Summary:
focus_stack can't store logical node. we don't need to check a node from
focus_stack is not normal.
see line 1613

Reviewers: bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5927
2018-04-13 11:07:34 +02:00
YeongJong Lee 4841165530 efl_ui_focus_manager_calc: remove needless check for normal node
Summary:
a node in focus stack is always normal node. we don't need to check whether
node is normal.

see also, 97ec48434f

Reviewers: bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5930
2018-04-13 11:07:34 +02:00
YeongJong Lee 1d182a44f3 efl_ui_win: add "focused" and "unfocused" signals emission
Summary:
Win is root of focus manager. it means Win is logical node and "focused" and
"unfocused" signals in Win aren't handled by focus manager.
Win needs to emit the signals itself.

Reported by eagleeye, jsuya

Test Plan:
1. elementary_test -to 'window states'
2. Check that "WIN FOCUS: focused" and "WIN FOCUS: unfocused" printed.

Reviewers: bu5hm4n

Reviewed By: bu5hm4n

Subscribers: jsuya, cedric, eagleeye

Differential Revision: https://phab.enlightenment.org/D5931
2018-04-13 11:07:34 +02:00
Marcel Hollerbach 01272c71d0 efl_ui_focus_manager: make request_move more powerfull
it turns out that it is useful and needed (for future patches) to
request moves for nodes that are not focused currently. It is also
needed to request a move that might end up in a logical node.
2018-04-13 11:07:33 +02:00
Marcel Hollerbach 32e17ecdc2 efl_ui_focus_manager_calc: only call next when the node is unexpected
ref T6793
2018-04-13 11:07:33 +02:00
Lauro Moura 4214311a76 examples: Improve efl_mono and eolian_cxx build
The examples were either not build or using repeated rules due to
_EOLIAN_DEP_GEN not being set correctly was Makefile_Eolian_Helper.am
assumes it being inclueded from src/, while each example folder has its
own .am inside its folder.
2018-04-12 21:23:42 -03:00
Lauro Moura 87c58a460a efl_mono: Add namespace on helpers.
Make it easier on finding where those functions are coming from.
2018-04-12 21:23:42 -03:00
Lauro Moura 65f868786a efl_mono: Proper support for @class methods.
Previously, class methods were implemented as regular instance methods.
This commits generates C# static methods for @class methods on the
*Concrete classes (and their childs).
2018-04-12 21:23:42 -03:00
Derek Foreman a252c3445d ee_wayland: Stop using manual_render_set
Now we use draw_block instead, so we don't accidentally stomp on other
code's usage of manual_render_set

fix T6834
2018-04-12 15:59:39 -05:00
Derek Foreman 2dbaef9b7c ecore_evas: Make draw_block block drawing
This was only used in the X custom render function, now it's meaningful
everywhere.  (Nothing that uses this code path currently sets it)

ref T6834
2018-04-12 15:59:39 -05:00
Derek Foreman 380a58a9d9 ee_x: Rename draw_ok to draw_block and invert logic
I want to use this in other engines, but no other engine initializes this
properly, so draw_ok would be EINA_FALSE everywhere.  This way draw_block
is EINA_FALSE after calloc in all engines that don't know about it.

ref T6834
2018-04-12 15:59:39 -05:00
Derek Foreman 2ad9b80517 efl_ui_win: Always show the wayland pointer
It's hidden by the compositor as required, so this just makes life much
more complicated in other code.

ref T6834
2018-04-12 15:59:39 -05:00
Derek Foreman b8e58eb4b2 ee_wayland: Remove use of draw_ok
This appears vestigial, as the evas render path we use has no custom
draw_ok handling, so nothing ever reads this variable.

ref T6834
2018-04-12 15:59:39 -05:00
Derek Foreman 4343a95e27 ee_cocoa: Remove draw_ok sets
draw_ok isn't currently used by anything but the X custom render function,
so it's doing absolutely nothing here.

ref T6834
2018-04-12 15:59:39 -05:00
Carsten Haitzler b0a7c4b086 elm entry - fix wayland bug by not updating selection until after mse up
or update with a small delay after any change and check mouse button
mask to avoid some bizarre mouse up event that is stopping the
selection form continuing with a mouse up event... so this works
around that and still works.
2018-04-13 04:19:16 +09:00
Carsten Haitzler 28d06f9a5f efl selection - fix another binary buffer treates as string bug
as per subject.

@fix
2018-04-13 04:19:16 +09:00
Carsten Haitzler 13734e51c1 efl selection - fix entry <-> plain text compy and paste in wl
efl didnt convert markup to plain text when pasting markup -> text.
this fixes that and enables middle mouse paste etc. etc.

@fix
2018-04-13 04:19:16 +09:00
Carsten Haitzler 9d6ac24a9c efl selection manager - fix anoyther binary buffer treated as string bug
yet another "binary buffer" (pointer + size) streated as a string with
strdup + strlen which is oh so wrong. this fixes up some cnp in
wayland with garbage at the end of strings

@fix
2018-04-13 04:19:16 +09:00
Carsten Haitzler 59f3dbdd34 efl selection manager - fix crashes when doing selections on non-x11
elm was calling x calls when on wayland here... because it didnt check
the RUNTIME display system type for the window, relying on ifdefs
instead.

@fix
2018-04-13 04:19:16 +09:00
Daniel Kolesa 2defb32214 eolian: correct line/column number during doc reference validation
Eolian doc objects now bundle debug information necessary to
provide correct line/column numbers. It is not possible to get
this information cirectly from the text, as it's reformatted and
contains no extra whitespace or newlines beyond paragraph
separators.

Fixes T6701.
2018-04-12 15:24:15 +02:00
YeongJong Lee 4793398759 efl_ui_frame: remove dulicated _content_aliases
Summary:
Frame inherits from layout. it can use same _content_aliases of Layout

ref 3114ee264b

Reviewers: Jaehyun_Cho, woohyun, cedric

Reviewed By: Jaehyun_Cho

Differential Revision: https://phab.enlightenment.org/D5929
2018-04-12 22:11:39 +09:00
Carsten Haitzler 3d6fa02540 evas - loading extension query - fix to not skip small extensions
since this can take an extension as well as a file path (extension
being .gif or .jpeg etc.) it would skip if passed a small extension
only (5 chars or less). fix and this fixes e's thumbnailing too for
some files.

@fix
2018-04-12 20:56:48 +09:00
Youngbok Shin 4c36461233 evas: apply fribidi bracket types to show paired bracket properly
Summary:
The fribidi couldn't reorganize paired brackets (Ex. '(', ')')
when there is RTL + LTR text. According to TR9(http://www.unicode.org/reports/tr9/),
it has to be shown properly without LRM or RLM.

Also, from the fribidi 1.0.0, fribidi_get_par_embedding_levels() was deprecated.
It is replaced with fribidi_get_par_embedding_levels_ex() which is including
paired brankets rules from TR9.

@feature

Test Plan:
1. Create a elm_entry.
2. Set a text by calling text_set.
   elm_entry_entry_set(entry, "مرحبا Hello (40)");
3. Run and see the results.
   - Without this patch or fribidi 1.X.X, it will show text like this...
     "(Hello (40 مرحبا"

   - With this patch and fribidi >= 1.0.0
     "Hello (40) مرحبا"

Reviewers: raster, cedric, herdsman, woohyun

Reviewed By: herdsman

Differential Revision: https://phab.enlightenment.org/D5921
2018-04-12 12:55:26 +03:00
Jaehyun Cho e4fbab8b47 efl_canvas_object: Change parameter name of property event_animation
Change the parameter name of property event_animation from "event_type"
to "desc" to synchronize with other APIs.
(The parameter type is Efl.Event.Description)
2018-04-12 12:55:49 +09:00
Derek Foreman 48e0c6ea90 ecore_wl2: Fix ecore_wl2_window_output_find
Window geometry x, y are the offset from the top left corner of the
buffer, and not screen co-ordinates, so has nothing to do with output
geometry and can't be used to determine which window we're on.

Now that we track surface enter/leave events we can just give the first
output in the list of outputs we know we're on.
2018-04-11 16:29:07 -05:00
Derek Foreman f560c76b52 ecore_wl2: Properly handle minimize request before shell surface exists
If we're asked to iconify a window before it's visible we need to track
this and apply the state as soon as we create the shell surface.

fix T6834
2018-04-11 11:48:27 -05:00
Derek Foreman 5a2c5479bf ecore_wl2: Stop pretending to fully control minimized state
Under wayland we can set minimized but not unset it, nor can we tell
if it's been unset.  This means we can't cache the value, we need to
make the protocol request any time ecore_wl2_window_iconified_set is
called.

ref T6834
2018-04-11 11:48:27 -05:00
Derek Foreman d697e7936b ecore_wl2: Remove (beta) API ecore_wl2_window_iconified_get
We actually can't ever query this, it's clearly defined that way in the
protocol.  There is absolutely no way to ever know if we're iconified.

ref T6834
2018-04-11 11:48:27 -05:00
Lauro Moura 15afb832e6 tests: Fix compilation when timing is disabled.
Reviewers: zmike, cedric

Reviewed By: zmike

Differential Revision: https://phab.enlightenment.org/D5919
2018-04-11 13:43:38 -03:00
Marcel Hollerbach 253430ab76 efl_ui_focus_manager_calc: call next after requesting a subchild
requesting subchild for subchild is not a good idea, as it really only
fetches for a subchild, and never calls next and escapes the children of
the passed node.

fix T6793
2018-04-11 17:16:34 +02:00
Chris Michael b5c9742cb7 efl_ui_focus: Add missing EINA_UNUSED for unused function parameters 2018-04-11 10:11:20 -04:00
Chris Michael c18fac91ff ecore-evas: Remove unused variable 2018-04-11 10:05:33 -04:00
Daniel Kolesa e9811c6596 eolian: simplify class validation logic 2018-04-11 14:58:41 +02:00
Daniel Kolesa 710748c551 eolian: better/more robust class inheritance list replacement 2018-04-11 14:31:03 +02:00
Marcel Hollerbach eef0c5164a elc_popup: no need to make them focusable
if they have content the content will be focusable, if there is no
content the rect of root_focus will be focused instead.
2018-04-11 10:36:24 +02:00
Marcel Hollerbach f4b70fc6cd efl_ui_focus_manager_root_focus: maintain focus state over state eval
the rect is unregistered and registered again, if it was focused, still
focus it.
2018-04-11 10:33:19 +02:00
Marcel Hollerbach ba7e4d2168 elm_suite: a new testcase for checking focus chains with redirects 2018-04-11 10:31:53 +02:00
Carsten Haitzler 86c855bdd3 ecore ipc - fix send to skip data payload if null/0
conversion to efl.nmet didnt deal with null/0 zised payloads properly
and tried to send them, resulting in lots of ERR complaints which were
not errors. fix that to not try and send such empty payloads

@fix
2018-04-11 14:34:40 +09:00
Cedric Bail 23800a06a0 ecore_evas: remove dead code. 2018-04-10 15:01:43 -07:00
Cedric Bail 664c1c8eb4 evas: we directly use the main loop, we do not need external integration anymore. 2018-04-10 14:42:54 -07:00
Cedric Bail f1f1a8c996 evas: protection during canvas shutdown. 2018-04-10 14:42:54 -07:00
Jaehyun Cho 5351070a4d efl_canvas_animation_player: Reset map after animation is finished
Previously, beginning state of animation is applied after animation is
finished if final_state_keep_get() is false.

Now, map is reset (no animation is applied) after animation is finished
if final_state_keep_get() is false.
2018-04-10 22:38:40 +09:00
Jaehyun Cho 503bb0c8f9 efl_canvas_animation_player: Change Running_Event_Info to Event_Running
To synchronize other types of event info,
Efl_Canvas_Animation_Player_Running_Event_Info is changed to
Efl_Canvas_Animation_Player_Event_Running.

Remove unused struct.
2018-04-10 22:38:32 +09:00
Marcel Hollerbach c705139623 ecore_file: switch from buf to tmpstr
before 	c65782b15c the acutal path has
been filled into buf, with eina_file_mkstemp the string is filled into
tmpstr, so that path should be chmoded instead of the template buf.

Thx to MatP for the report!
2018-04-10 14:27:44 +02:00
Marcel Hollerbach ef3cce5730 elm_suite: fixup test suite
the testcase was only added, but not executed, my bad!
2018-04-10 14:27:44 +02:00
Shinwoo Kim b27949dafb ecore_evas_wayland: handle 0x0 content problem
Someone could NOT use elementary and use ecore_evas only. In this case, content
size which is defined by elementary is 0x0. If content size is 0x0, then frame
size is equal to window size. But the frame size is defined by elementary as
well. So if there is not a content, then the frame size should be 0.
2018-04-10 20:38:47 +09:00
Mike Blumenkrantz 5bbe49ab99 tests: split ecore thread queue tests into 2 test cases
Summary:
enable running these tests in parallel

ref T6851
Depends on D5905

Reviewers: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6851

Differential Revision: https://phab.enlightenment.org/D5906
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz 99f3f89f24 tests: split efl_app promise tests into separate test cases
Summary:
each test case can run in parallel, so this provides a ~300% speedup

ref T6850
Depends on D5904

Reviewers: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6850

Differential Revision: https://phab.enlightenment.org/D5905
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz 43c420d3d0 tests: ensure eina/efl_object are initialized for all efl_app tests
Summary:
these aren't tested so don't init/shutdown for every test

ref T6850
Depends on D5903

Reviewers: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6850

Differential Revision: https://phab.enlightenment.org/D5904
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz 5e806ee41f tests: move ecore promise tests into efl_app_suite
Summary:
ref T6815
Depends on D5902

Reviewers: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6815

Differential Revision: https://phab.enlightenment.org/D5903
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz b4da776b3b tests: add more timing info for per-file timing
Summary:
ref T6825
Depends on D5901

Reviewers: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6825

Differential Revision: https://phab.enlightenment.org/D5902
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz 1bd52cc116 tests: split ecore poller tests into separate file
Summary:
ref T6850
Depends on D5900

Reviewers: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6850

Differential Revision: https://phab.enlightenment.org/D5901
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz 88a6a3c769 tests: split ecore idler tests into separate file
Summary:
ref T6850
Depends on D5899

Reviewers: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6850

Differential Revision: https://phab.enlightenment.org/D5900
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz 3b22dbc5af tests: move efl_loop_fd tests into efl_app_suite
Summary:
ref T6815
Depends on D5898

Reviewers: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6815

Differential Revision: https://phab.enlightenment.org/D5899
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz f83dfb2173 tests: break out simple timer failure test into separate test
Summary: Depends on D5897

Reviewers: stefan_schmidt

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5898
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz 3547297f80 tests: add fixtures for efl_app tests
Summary:
ref T6811
Depends on D5896

Reviewers: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6811

Differential Revision: https://phab.enlightenment.org/D5897
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz fab4c313f4 tests: move disabled efl loop timer test into efl_app_suite
Summary:
ref T6815
Depends on D5895

Reviewers: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6815

Differential Revision: https://phab.enlightenment.org/D5896
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz e02598cd4e tests: split efl_loop tests out of efl_app_suite.c
Summary: Depends on D5894

Reviewers: stefan_schmidt

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5895
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz ab8237d36d tests: reduce duration of ecore_test_timers
Summary:
fix T6852
Depends on D5893

Reviewers: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6852

Differential Revision: https://phab.enlightenment.org/D5894
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz 96da1551c5 tests: move ecore_test_ecore_main_loop_timer into timers test file
Summary: Depends on D5892

Reviewers: stefan_schmidt

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5893
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz 3858186376 tests: reduce duration of ecore_test_animators
Summary:
fix T6852
Depends on D5891

Reviewers: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6852

Differential Revision: https://phab.enlightenment.org/D5892
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz 94d0aae906 tests: reduce duration of ecore_test_ecore_main_loop_timer test
Summary:
fix T6852
Depends on D5890

Reviewers: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6852

Differential Revision: https://phab.enlightenment.org/D5891
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz f810e0a3ba tests: improve ecore thread queue reliability
Summary:
* check inside thread callbacks whether thread has been canceled
* clean up (global) objects
* wait for threads to die before exiting each test

ref T6851
Depends on D5889

Reviewers: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6851

Differential Revision: https://phab.enlightenment.org/D5890
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz 0ea6624e10 tests: remove "info" messages from ecore-drm/input tests
Summary: Depends on D5888

Reviewers: stefan_schmidt

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5889
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz e5fc5f0263 tests: quiet useless printf spam from thread queue tests
Summary: Depends on D5886

Reviewers: stefan_schmidt

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5887
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz 59520a57cb tests: remove extra download in ecore_test_ecore_file_download
Summary:
this function is just a wrapper, avoid downloading the same file
multiple times

ref T6853
Depends on D5885

Reviewers: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6853

Differential Revision: https://phab.enlightenment.org/D5886
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz a04e7be83a tests: use different website for ecore_test_ecore_file_download
Summary:
while it may be the case that we do not control example.com, it is also
the case that loading anything from enlightenment.org takes 10+ seconds
longer (at minimum) than loading example.com

ref T6853
Depends on D5884

Reviewers: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6853

Differential Revision: https://phab.enlightenment.org/D5885
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz ed4c53b628 tests: use 0.05s as poller interval in ecore_test_ecore_main_loop_poller
Summary:
fix T6852
Depends on D5883

Reviewers: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6852

Differential Revision: https://phab.enlightenment.org/D5884
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz a995a0c0fe tests: split ecore_test_ecore_main_loop_poller_add_del into separate tests
Summary:
unit tests should verify only small pieces of functionality to ensure
that they are testing what they claim to be testing

fix T6852
Depends on D5882

Reviewers: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6852

Differential Revision: https://phab.enlightenment.org/D5883
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz 853e2c43ca tests: remove random usleeps from ecore thread queue tests
Summary:
fix T6851
Depends on D5881

Reviewers: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6851

Differential Revision: https://phab.enlightenment.org/D5882
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz c45f134680 tests: enable some commented out eldbus tests
Summary:
these are able to run now that a dbus session is always launched
Depends on D5880

Reviewers: stefan_schmidt

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5881
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz 0998f1586f tests: remove timing info for eina mempool initializer
Summary:
this is buggy somehow and prints its info a few dozen times, likely
taking longer to print the info than to run the actual test
Depends on D5879

Reviewers: stefan_schmidt

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5880
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz 1eeb3cbdf7 tests: use dbus-run-session when running tests
Summary: Depends on D5878

Reviewers: stefan_schmidt

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5879
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz 946c9757bb tests: add all xml files to gitignore
Summary: Depends on D5877

Reviewers: stefan_schmidt

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5878
2018-04-10 11:28:01 +02:00
Mike Blumenkrantz 6879270b59 tests: parallelize most test suites
Summary:
check does not internally do any parallelizing and is impossible to use
with threads, so using fork appears to be the only viable option for
using more cpu without radically redesigning all existing tests

ref T6825
ref T6848

Reviewers: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6848, T6825

Differential Revision: https://phab.enlightenment.org/D5877
2018-04-10 11:28:01 +02:00
Shinwoo Kim 579eeb4a8c efl_io_queue: add null check for slice->mem
A negative test case leads to segmentation fault.
If ecore_evas_msg_parent_send is called with NULL data, then slice->mem would
be NULL, and _efl_io_queue_efl_io_writer_write calls memcpy with NULL src.
2018-04-10 16:25:11 +09:00
Hermet Park ab7988b532 elementary: apply anti-aliasing at the gesture layer example. 2018-04-10 11:25:25 +09:00
Hermet Park d62ee3bea1 evas: improve evas map anti-alising rendering quality.
Old version algorithm was imperfection a bit, quality was poor at some specific
degrees, specifically, when pixel increment pattern on the diagonal lines is
unstable.

This revised version was better than old one even source code is much cleaner
and simpler.

See belows.

*NonAA vs AA:
https://ibb.co/bCNfMc

*Compare the worst case aa in the old version:
https://ibb.co/bEJsZx

*Test video:
https://youtu.be/Wn20Tym5lfg
2018-04-10 11:19:19 +09:00
Woochan Lee 0088189eee elementary: add new config value to handle tap finger size.
Summary:
The tap_finger_size value of the concept is different from the finger_size value used in the past.

We need a minimum value for recognize the gesture as a tap or not.

Since the actual screen has different screen sizes, there is a problem that the recognition rate of tap is lowered when using the existing value(finger_size)

Test Plan: elementary_test -> gesture sample.

Reviewers: cedric, woohyun, Jaehyun_Cho, herb, id213sin

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5842

Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2018-04-09 10:36:43 -07:00
Woochan Lee f9fa8bfcb0 ecore_evas: check return value.
Summary: After migration this code in Tizen. The coverity said it needs to check return value(CID 39562).

Reviewers: raster, myoungwoon, woohyun, cedric

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5907

Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-04-09 10:36:43 -07:00
junsu choi 982ad90f57 evas: add null check
Summary:
this commit add null check.
In EVAS_OBJECT_DATA_SAFE_GET, if eo_obj is null, obj can also be null.
and In _efl_canvas_output_async_block() can return null.

Test Plan: N/A

Reviewers: woohyun, kimcinoo, cedric

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5870

Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-04-09 10:36:43 -07:00
junsu choi 0f06f222ba ecore_fb: fix divided by zero
Summary:
w and h must not be zero.
because of the divide_by_zero exception occurs on line 649 and 653.

Test Plan: N/A

Reviewers: woohyun, kimcinoo, cedric

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5873

Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-04-09 10:36:43 -07:00
Marcel Hollerbach 78f4babbb5 efl_ui_focus_object:
make the prepare call safe to recursive calls. There is no need to
prepare a item again if it is already in prepare.
2018-04-09 18:27:45 +02:00
Marcel Hollerbach e70bf4e231 efl_ui_focus_manager_root_focus: refactor _state_eval
Summary:
we have to check whether all of descendant are none_logical.

this fixes T6800

Test Plan:
1. elementary_test -to ctxpopup
2. Click 'Ctxpopup with user content'
3. Try focus ctxpopup content(button) using arrow key.
4. Check that the content is focused (you can move scroll bar)

Reviewers: bu5hm4n

Subscribers: raster, cedric

Maniphest Tasks: T6800

Differential Revision: https://phab.enlightenment.org/D5856
2018-04-09 18:27:09 +02:00
Marcel Hollerbach 84ad5d9fe3 introduce efl_ui_focus_manager_window_root
Which is a interface that indicates that this is the root of all focus
managers.
2018-04-09 18:05:27 +02:00
Marcel Hollerbach 33921385f9 efl_ui_focus_util: support later managers not beeing registered
this should fix some corner cases when setting focus by hand
2018-04-09 18:05:27 +02:00
Marcel Hollerbach 59828721d8 efl_ui_focus_layer: return the registered focus manager when active
this fixes in chain setting for hovers and ctxpopups
2018-04-09 18:05:27 +02:00
Marcel Hollerbach 39af0ebde0 elm_hoversel: make the keyevent handlers work again
i am not sure when this stopped working, elm hover sends focus to the
children it has, thus the propergation line for the key down events is
going from the hover up accross the over parent, however, the
hoverparent can be different to the hoversel, which would lead to
missing navigation in the hoversel.

this fixes T6802
2018-04-09 18:05:27 +02:00
Stefan Schmidt 6f6384f0bb tests: eolian: remove reference to no longer existing files
These have been renamed in commit f19a905261
No need to keep the reference in the makefile. distcheck was also
getting confused about them.
2018-04-09 12:24:53 +02:00
Hermet Park 3a4baabaaa ecore: fix a potential memory leak.
if the func argument is null, allocated memory won't be freed properly.
return it as soon as possible.

@fix
2018-04-09 11:46:13 +09:00
Hermet Park ecc8b479bd edje: fix potential memory leak.
next_token() requires free() for it's returned value and a string attribute.
Here token usage didn't take care of the memory freeing.

@fix
2018-04-09 11:29:41 +09:00
Hermet Park d5c913c60b edje: fix potential memory leak.
next_token() requires free() for it's returned value and a string attribute
Here logic didn't take care of the memory usage.

@fix
2018-04-09 11:14:07 +09:00
Felipe Magno de Almeida 9470252450 gendoc-mono: Add documentation generation for C# language 2018-04-08 11:25:25 -03:00
Felipe Magno de Almeida c2b067453a efl-js: Fix dependency generation in JavaScript binding compilation
Use C++ as dependency in automake so concurrent builds will not fail to compile
2018-04-08 11:24:08 -03:00
Davide Andreoli 1234130686 A really small fix for test focus 5
Just place one of the buttons in the perfect position.
2018-04-07 20:02:51 +02:00
Carsten Haitzler e29102e134 Revert "efl_ui_focus_manager_root_focus: refactor _state_eval"
This reverts commit c6ce04e48f.

OK. I bisected and found that this is ythe root cause for 2 pretty
chunky bugs. Reverting this fixes T6870 and fixes T6871.

so that's 2 segvs in existing uses and even olne (elm config) ships
with efl. Having a look at the diff doesn't jump out what is wrong
here, but the best course IMHO is to take this patch and put it back
into review again... :)
2018-04-07 16:42:51 +09:00
Cedric Bail 6e0c86eb67 evas: when passed an Evas_Object, we should try to access it directly so that during destructor Evas is still accessible. 2018-04-06 11:32:21 -07:00
junsu choi d21d51a4a9 evas: fix typo written twice
Summary: disp is written twice with the same value.

Test Plan: N/A

Reviewers: woohyun, kimcinoo, cedric

Reviewed By: cedric

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5874

Reviewed-by: Cedric Bail <cedric@osg.samsung.com>
2018-04-06 11:32:07 -07:00
Cedric Bail 14b9a674ac elementary: in case of an object being destroyed, there is no point to warn. 2018-04-06 11:32:00 -07:00
Bowon Ryu 72c263d5f2 ecore_wayland: remove logically dead code.
Summary:
remove logically dead code.
execution cannot reach this statement.

Reviewers: cedric

Differential Revision: https://phab.enlightenment.org/D5876

Reviewed-by: Cedric Bail <cedric@osg.samsung.com>
2018-04-06 10:10:44 -07:00
YeongJong Lee 3114ee264b efl_part: remove duplicated text_aliases code
Summary: this widgets inherit from Layout. they can use same text_aliases of Layout.

Reviewers: Jaehyun_Cho, woohyun

Subscribers: herb, cedric

Differential Revision: https://phab.enlightenment.org/D5859

Reviewed-by: Cedric Bail <cedric@osg.samsung.com>
2018-04-06 10:10:08 -07:00
Mike Blumenkrantz e0c8ab4c79 ecore: reduce pipe wait time during shutdown
Summary:
this is only meant to listen to data which is currently available,
not wait for new data

@fix

Depends on D5866

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5867

Reviewed-by: Cedric Bail <cedric@osg.samsung.com>
2018-04-06 10:09:00 -07:00
Mike Blumenkrantz 0fddfe199f ecore: poll the thread pipe twice during shutdown
Summary:
this resolves a race condition when a thread join was pending during
shutdown but a pipe write was needed in order for the join to be
successfully executed before shutdown had occurred

@fix

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5866

Reviewed-by: Cedric Bail <cedric@osg.samsung.com>
2018-04-06 10:08:57 -07:00
YeongJong Lee 0e035b2e22 elm_inwin: use macro for content set/get/unset
Summary: also, content_aliases is not necessary. it can use Layout's content_aliases.

Test Plan:
elementary_test -to inwin
elementary_test -to inwin2
elementary_test -to inwin3

Reviewers: Jaehyun_Cho, woohyun

Subscribers: herb, cedric

Differential Revision: https://phab.enlightenment.org/D5860

Reviewed-by: Cedric Bail <cedric@osg.samsung.com>
2018-04-06 10:08:52 -07:00
Alastair Poole 10fb87bbcd efl_selection_manager: fix build on MacOS and WL2. 2018-04-06 16:11:41 +01:00
YeongJong Lee 67be5b427a efl_wl: Add NULL check
Reviewers: zmike, ManMower, Jaehyun_Cho, woohyun

Reviewed By: ManMower

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5862
2018-04-06 09:38:23 -05:00
Carsten Haitzler b63d64bda2 ecore audio - add comment that this is an intended leak... 2018-04-06 22:40:33 +09:00
Stefan Schmidt 63a390ecbc tests: eldbus: mark unused parameter as such 2018-04-06 12:01:39 +02:00
Stefan Schmidt ea60b359a7 tests: ecore: remove no longer needed jenkins check function
After changes to the ecore_timer tests this function is no longer used
or needed. It can safely go.
2018-04-06 11:19:40 +02:00
Stefan Schmidt 7b4d9f5905 tests: elementary: remove unused variable
Looks like a copy and paste left over from another test.

../../../src/tests/elementary/elm_test_genlist.c:58:16: warning: unused variable ‘type’ [-Wunused-variable]
2018-04-06 10:35:44 +02:00
Carsten Haitzler 35a6e7a6d2 ecore audio - dont unload modules etc. in case audio obj around on exit
if audio objects are around after ecore_audio has been shut down then
they may access the sndfile or pulse lib ptrs/funcs and thus dont
unload these. should fix crashes on shutdown.
2018-04-06 17:08:44 +09:00
Cedric Bail 0ba3ffda8d ecore: and rename the test for Eina_Future to be the only promise test. 2018-04-05 13:18:24 -07:00
Cedric Bail 8563e3780e ecore: remove tests of old Efl_Future based on Eo. 2018-04-05 13:17:32 -07:00
Cedric Bail 5ebe5bb62c evas: by moving lifecycle management to be handle by the death of the parent, there should be no call to efl_del. 2018-04-05 11:52:47 -07:00
Cedric Bail 53378d6a6b evas: the life cycle of an object inside an hash can not rely on the parent destroying, use ref/unref properly. 2018-04-05 11:52:12 -07:00
Cedric Bail def3bb6eec ecore: rely on object being destroyed on parent invalidate. 2018-04-05 11:52:12 -07:00
Cedric Bail a9fbaf16d3 ecore: pipe fd can become invalid while being processed. 2018-04-05 11:52:12 -07:00
Cedric BAIL 0578079927 evas: we should always sync the canvas before destroying the object. 2018-04-05 11:50:52 -07:00
Mike Blumenkrantz 81d97eb45a tests: ck_assert_ptr_null -> ck_assert_ptr_eq 2018-04-05 14:04:21 -04:00
Mike Blumenkrantz 681cfc9177 tests: ck_assert_ptr_null -> ck_assert_ptr_ne 2018-04-05 13:43:54 -04:00
Cedric BAIL 621f34d322 eina: mark thread by default as not cancellable as per Eina documentation.
By default all Pthread are cancellable. This leads to strange behavior that
happen during shutdown and hasn't been figured out. Most likely fix for T6622.
2018-04-05 10:39:30 -07:00
Mike Blumenkrantz 978901903d tests: move bindings tests to using checked fixtures too.
T6862
T6811

Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-04-05 10:19:57 -07:00
Xavi Artigas 2a512b72f0 elementary: fix efl_ui_view_list examples
Reviewers: SanghyeonLee

Reviewed By: SanghyeonLee

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5863

Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-04-05 10:00:02 -07:00
Mike Blumenkrantz 71f76c65cf tests: add test for check < 0.11 to enable timing info 2018-04-05 12:25:16 -04:00
Stefan Schmidt 568fc2ab30 tests: elementary: fix build break after rename of efl_ui_view examples
Commit ae8df9ba07 renamed the files but
did not rename the references in the Makefile.
2018-04-05 14:37:47 +02:00
Carsten Haitzler fcd7c3097c elm - selection manager - fix string buffer handling and format types
this has 2 bugs really. 1 - the format masks for plain text included
markup which ... is wrong - right? that should have a mime type of its
own... either way it leads to plain text pasts being handled wrong in
wayland... so this fixes that

also the string buffers in wayland just were nothandled right. buffers
were raw binary buffers plus size,not strings, but they were strdup'd
etc. assuming nul termination. oh so wrong to do that. this also fixes
that as i fpound it while fixing the above format bug.

this fixes T6284

@fix
2018-04-05 21:17:22 +09:00
Daniel Kolesa 284e352811 eolian: _ is allowed in doc references 2018-04-05 13:54:20 +02:00
Shinwoo Kim 3cd2243028 Fix static analysis result
[Dereference after null check]

(1) src/lib/ecore/ecore_main.c
 - _efl_loop_handler_efl_object_finalize checks if pd->loop_data is NULL.
   After that, _handler_reset > _handler_clear > _ecore_main_fd_handler_del >
   _ecore_main_fdh_pool_del is directly dereferencing pd->pool_data.
 - _efl_loop_handler_efl_object_parent_set checks if pd->loop_data as well.
   Then it calls _handler_reset as well.

(2) src/lib/ecore_wayland/ecore_wl_dnd.c
  - ecore_wl_dnd_selection_set checks if t - result of wl_array_add - is NULL.
    And it is dereferecing t directly for wl_data_source_offer.

(3) src/lib/elementary/efl_ui_dnd.c
 - Third parameter const char *data could be NULL.
   In this case strlen dereferences NULL. The data should be non NULL value.
   I have checked this with Mr. Thiep Ha.

(4) src/lib/evas/canvas/evas_object_inform.c
 - _efl_canvas_object_efl_gfx_stack_stack_below checks if obj->layer is NULL.
   So it could call evas_object_inform_call_call_restack which is dereferencing
   obj->layer directly.
2018-04-05 19:40:57 +09:00
Carsten Haitzler 2105bc4fb1 efl selection manager - build again if no wl or no x is enabled
so make check and my builds passed because i have wl and x enabled. if
one of these isnt then this build will fail. my fix fails. this fixes
that.
2018-04-05 19:16:16 +09:00
Carsten Haitzler 37ff19c80e elm - fix selection debug print to not print unterminated buffers
so it's printfing a non-0 byte terminated string ... it's a
buffer/slice which has explicit lenmgth and no nul, so fwrite it
approplriately.
2018-04-05 18:52:57 +09:00
Carsten Haitzler 3a12a6c4a5 evas - plug in dirty + pixels get hold in "is inside" for images
this should fix T6791

@fix
2018-04-05 18:52:57 +09:00
Carsten Haitzler d009a231e9 efl selection manager - handle multi window selections properly
tell other windows they lost their selections correctly if you have
multiple windows within the same process. this fixes multi-window mode
in terminology.

@fix
2018-04-05 18:52:57 +09:00
Carsten Haitzler 468d55e284 efl selection - fix paste with multiple windows and filter by window
so changes in elm cnp (efl selection) broke cnp with terminology
multi-window mode. this fixes it.

@fix
2018-04-05 18:52:57 +09:00
Carsten Haitzler b90cd2f683 efl threadio - make call and call sync func proto same as efl events
well call sync returns a void * too.... instead of just void return
(nothing) but this makes it easier to write and maintain code due to
consistency of function callback signatures.
2018-04-05 18:52:57 +09:00
Carsten Haitzler 78d7fded5d efl exe - map some "well known" exit codes to specific errnos 2018-04-05 18:52:57 +09:00
Carsten Haitzler 6fbf6d6c67 efl task - support flag to ignore exit code errors for future resolve 2018-04-05 18:52:57 +09:00
Carsten Haitzler 6e308e6039 ecore - thread - document thread max limits more sensibly
leave the exact numbers less defined because core count can change on
the fly and could be virtually limited by policy in future etc. so
keep things less exactly defined so people dont go depending on exact
results which was never really intended.
2018-04-05 18:52:57 +09:00
Carsten Haitzler 2577def20e elm config tool - get web backend when entry is deleted not on terminate
terminate may be called after widgets/windows are deleted already...
so donyt get this stuff in terminate.
2018-04-05 18:52:57 +09:00
Carsten Haitzler cffb31f4a7 elm config - dont leak config if re-loading it again later on
delete config object and so on before the relaod
2018-04-05 18:52:57 +09:00
Carsten Haitzler 08dc189053 elm win - change parent to only use win parents in efl win struct as parent 2018-04-05 18:52:57 +09:00
Mike Blumenkrantz ab37ca4d7b tests: increase step sizes for eina_fp_div and eina_fp_mul tests
fix T6841

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:32 +02:00
Mike Blumenkrantz 594b5f4967 tests: reduce looping in slstr_thread thread callbacks
this works out to the same number of total tests as slstr_many but
now split across all the threads

fix T6846

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:32 +02:00
Mike Blumenkrantz 88436ca89c tests: reduce looping in eina_test_spinlock
no changes to coverage

fix T6845

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:32 +02:00
Mike Blumenkrantz 7819d56da6 tests: add eina_test_hash_int64_fuzze
ref T6844

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:32 +02:00
Mike Blumenkrantz 4ac90511b9 tests: reduce looping in eina_ustringshare_putstuff
fix T6843

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:32 +02:00
Mike Blumenkrantz e8878e19b7 tests: reduce looping in eina_binshare_putstuff test
also slightly increase eina_hash coverage

fix T6843

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:31 +02:00
Mike Blumenkrantz d5583d74ea tests: improve eina_binshare_collision test
remove rand() usage and loop less

fix T6843

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:31 +02:00
Mike Blumenkrantz 7f54a431a3 tests: change eina cmdline test names to match api namespaces
Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:31 +02:00
Mike Blumenkrantz 910db08a6b tests: remove 9900 loop iterations from eina_test_file_thread
no changes in coverage

fix T6842

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:31 +02:00
Mike Blumenkrantz e6c8bf7fbf tests: rework eina hash fuzzing tests
these are supposed to be for testing the finding of values not in the
hash, not basic hash operations

fix T6839

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:31 +02:00
Mike Blumenkrantz 631f506a6f tests: fix mem leak in eina_test_hash_add_del_by_hash
Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:31 +02:00
Mike Blumenkrantz f2dc01a8dc tests: reduce malloc usage in eina_test_hash_extended
ref T6839

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:30 +02:00
Mike Blumenkrantz 947c954141 tests: reformat eina_test_hash.c
no functional changes

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:30 +02:00
Mike Blumenkrantz eabd003b00 tests: use namespacing for eina hash tests
no functional changes

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:30 +02:00
Mike Blumenkrantz 80569fd7a6 tests: use namespacing for safepointer test names
Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:30 +02:00
Mike Blumenkrantz 908ba030bf tests: reduce array size in safepointer tests
this reduces test runtime by ~1.0s while having no effect on coverage

fix T6836

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:30 +02:00
Mike Blumenkrantz 3162240921 tests: simplify eina safepointer tests to be more readable
no functional changes

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:29 +02:00
Mike Blumenkrantz 2bbc300b80 tests: use EINA_C_ARRAY_LENGTH macro in safepointer tests
no functional changes

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:29 +02:00
Mike Blumenkrantz 1f7f7297e3 tests: rework strbuf append/prepend tests
there's no point in iterating this many times; the base step size is 32
and so each loop will only increase the buffer...not at all since it takes
3 loops for the buffer to increase by the step size

verify that the buffer increases and then stop instead of spinning uselessly

fix T6835

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:29 +02:00
Mike Blumenkrantz 0f3f651f81 tests: reformat eina_test_strbuf.c
Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:29 +02:00
Mike Blumenkrantz 26103722be tests: use namespacing for eina strbuf tests
Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:29 +02:00
Mike Blumenkrantz 11d695cfcd tests: improve eina_test_list_shuffle
reduce iteratons by a hundredfold, remove verifying of rand() seed,
check whether shuffle actually shuffles

fix T6833

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:29 +02:00
Mike Blumenkrantz 8ca6102f62 tests: rename eina_list tests to use list namespace for readability
Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:28 +02:00
Mike Blumenkrantz 05edb41388 tests: remove sleep calls from eina_barrier_test_simple
the timing does not matter for these tests, so there's no point in
randomly waiting longer and delaying build completion

fix T6832

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:28 +02:00
Mike Blumenkrantz 5427cd31d1 tests: improve coverage in eina_rbtree_fuzzy test
Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:28 +02:00
Mike Blumenkrantz 0683552037 tests: simplify eina_rbtree_fuzzy test and speedup by infinity%
this test is to try and match values in a tree which have not been
inserted, so remove irrelevant insert/remove operations as well as
insane looping

fix T6830

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:28 +02:00
Mike Blumenkrantz f176c86b09 tests: greatly reduce iterations for eina_rbtree_remove test
this has no bearing on coverage, so there is not much point in uselessly
iterating here

ref T6830

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:28 +02:00
Mike Blumenkrantz 391ebf9cff tests: reduce malloc calls in eina rbtree tests
ref T6830

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:28 +02:00
Mike Blumenkrantz 5f55a07f8a tests: rework eina inlist tests to be infinity% faster
coverage currently at ~95%

fix T6829

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:27 +02:00
Mike Blumenkrantz 7bf389f3a7 elm: remove hacky calls to emotion_init/shutdown
these are irrelevant since emotion manages init/shutdown internally

fixes elm test pass state

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:27 +02:00
Mike Blumenkrantz 73106cc201 emotion: call shutdown when smart objects are destroyed
the constructor calls init for every object, so ensure a matching
shutdown call exists to balance the init count

ref 517471190f
ref T6816

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:27 +02:00
Mike Blumenkrantz 492814bf2f tests: unbreak PACKAGE_BUILD_DIR usage in makefiles
for some reason, a few projects changed this from the expected value of
abs_top_builddir for their test suites, breaking the usage of this define
within those tests

fix T6812

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:27 +02:00
Mike Blumenkrantz ddd00273a4 tests: disable xim in ecore_imf test when DISPLAY is not set
tests should be able to run in console without failing

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:27 +02:00
Mike Blumenkrantz 55441e82e2 elput: include Eina.h in public header
Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:27 +02:00
Mike Blumenkrantz 97b76bd35a tests: redo eina in-tree module loading
this performs an eina init/shutdown check and loads available modules
before running remaining tests

note that this still does not work and may never have worked because
PACKAGE_BUILD_DIR is broken

ref T6812

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:26 +02:00
Mike Blumenkrantz 624925fe6e tests: move to using checked fixtures for all test suites
individual tests should not need to explicitly call init/shutdown functions
in most cases, and many did not properly do this anyway

see followup commit which resolves some issues with eina tests

ref T6813
ref T6811

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:26 +02:00
Mike Blumenkrantz 730020c7d4 tests: remove duplicated eina mempool test
Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:26 +02:00
Mike Blumenkrantz e9eb96e097 eldbus: call ecore_init in eldbus_init
eldbus requires ecore and cannot run without it

@fix

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:26 +02:00
Mike Blumenkrantz ff67706783 tests: make test time output configurable with TIME_DIFF_THRESHOLD
setting this value too low will likely lead to unmanageable results

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:25 +02:00
Mike Blumenkrantz adc601aca2 tests: add instrumentation to existing tests to find slow tests
efl_check.h must be included and the EFL_START/END_TEST macros must be
used in place of normal START/END_TEST macros

timing is enabled when TIMING_ENABLED is set
https://phab.enlightenment.org/w/improve_tests/

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:25 +02:00
Mike Blumenkrantz b340b5e49c tests: match test names using strcasecmp when parsing cmdline
Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
2018-04-05 11:10:25 +02:00
Hermet Park 8329dace50 ecore_con: resolve the possible read of uninitalized data.
Submitted-By-Off: JongMin Lee<jm105.lee@samsung.com>
2018-04-05 15:29:57 +09:00