Commit Graph

11553 Commits

Author SHA1 Message Date
Jaehyun Cho c04635c9b7 layout: Add NULL check for ELM_NEW memory allocation. 2015-06-15 14:56:42 +09:00
Youngbok Shin ed343cbab0 clock: Add safety check for NULL pointer from localtime() func.
Summary:
localtime() can return NULL when there is an error.
@fix

Reviewers: raster, woohyun, Hermet, JackDanielZ

Subscribers: JackDanielZ

Differential Revision: https://phab.enlightenment.org/D2666
2015-06-15 08:17:32 +03:00
Youngbok Shin 6f33f4f1d1 cnp: Add safety check for NULL pointer from malloc().
Summary:
It could make crash when malloc is failed.
@fix

Reviewers: raster, woohyun, Hermet, JackDanielZ, thiepha

Subscribers: JackDanielZ

Differential Revision: https://phab.enlightenment.org/D2671
2015-06-15 08:08:34 +03:00
Youngbok Shin d04e6c7d6a cnp: Fix memory leak issue.
Summary: Call efreet_uri_free() API to free Efreet_Uri structure.

Test Plan: None.

Reviewers: raster, cedric, woohyun, Hermet, thiepha, JackDanielZ

Subscribers: JackDanielZ

Differential Revision: https://phab.enlightenment.org/D2655
2015-06-15 08:05:02 +03:00
ChunEon Park d103e00145 calendar: + null check. 2015-06-15 13:58:02 +09:00
ChunEon Park 150f3b421c clendar: + null check
gmtime can return NULL vaule.
if so strftime will cause crash.

this patch just prevent that potential situation.
2015-06-15 13:39:14 +09:00
Hosang Kim 81ead01597 elm_interface_scrollable : Fix logic about setting EVAS_EVENT_FLAG_ON_HOLD
Summary: Even if scroller is not scrolled, EVAS_EVENT_FLAG_ON_HOLD is set. So clicked event is canceled in Edje.

Test Plan:
On the button in the vertical scroller, click button and move mouse horizontal.
Mouse up on the button, so now button is not clicked

Reviewers: Hermet, CHAN, seoz, jaehwan, woohyun, SanghyeonLee

Differential Revision: https://phab.enlightenment.org/D2550
2015-06-15 09:56:02 +09:00
Daniel Zaoui fcbb42d19b DnD: fix memory leak 2015-06-14 11:23:52 +03:00
Daniel Zaoui 9781aef4bb DnD/X11: Fix invalid access to memory
It seems X doesn't send the data with the termination.
2015-06-14 11:23:52 +03:00
Daniel Zaoui f66224b5f3 DnD/X11: rename notifiers
As the notify functions don't notify anymore, they have to be renamed to
reflect their real job, i.e data preparers before calling user
functions.
2015-06-14 11:23:47 +03:00
Daniel Zaoui b779ae6780 DnD/X11: refactor the notifiers
Each data notifier was preparing data and then invoking the user callbacks
for DnD or selection protocols.
Most of the notifiers code was handling the user callbacks invocation
and was the same for all of them.

This patch simplifies the notifiers by moving the user callbacks
invocation into a common place for all the types, i.e into the notify
dispatcher.
The notifiers prototype has been changed to suit the code modifications.
2015-06-14 11:21:33 +03:00
Daniel Zaoui 271a37f6eb DnD/X11: remove unused function 2015-06-13 12:29:35 +03:00
WooHyun Jung 1ca127d826 fileselector: add NULL check for memory allocation 2015-06-13 15:45:36 +09:00
Thiep Ha 8fe80fc6a3 entry: add dnd image handling
When image is dropped into entry, we should insert image to it.
This patch adds image inserting in dropping.

@fix
2015-06-12 11:53:57 +03:00
Thiep Ha 551074c5f2 Cnp/X11: correct object parameter in datacb
The object parameter in datacb must be the selection request object,
not the selection owner object.
This patch corrects that.

Test case: open two windows with entry, copy text from one entry in
first window, paste to entry in other window.

@fix
2015-06-12 11:53:55 +03:00
Thiep Ha 99ab88c1c7 Cnp/X11: move entry-only code in elm_cnp to entry
There is code in elm_cnp.c which is used to paste data to entry widget only.
This can cause error if widget is not entry.
This patch removes that code in elm_cnp.c and adds datacb to entry
to insert content to entry.

@fix
2015-06-12 11:53:34 +03:00
Thiep Ha 1ee5b72ceb Dnd/X11: add dnd support for image, uri types
There is no dnd callbacks for image, uri types.
This patch adds dnd callbacks for those types.

@fix
2015-06-12 11:45:00 +03:00
Youngbok Shin 61fe7e5f39 cnp: Add safety check for NULL pointer from strdup().
Summary:
It could make crash when strdup() is failed.
CID - 329115
@fix

Reviewers: raster, thiepha, woohyun, Hermet

Differential Revision: https://phab.enlightenment.org/D2673
2015-06-12 11:02:05 +03:00
Youngbok Shin 9fba74ea72 cnp: Add safety check for NULL pointer from calloc() for anim_icon.
Summary:
It could be failed to allocate memory for Anim_Icon.
CID - 337351
@fix

Reviewers: raster, thiepha, woohyun, Hermet

Differential Revision: https://phab.enlightenment.org/D2672
2015-06-12 11:01:55 +03:00
Youngbok Shin e227bad7fe cnp: Add safety check for NULL pointer from _elm_util_text_to_mkup().
Summary:
_elm_util_text_to_mkup() func could return NULL when malloc is failed internally.
CID - 398441
@fix

Reviewers: raster, thiepha, woohyun, Hermet

Differential Revision: https://phab.enlightenment.org/D2668
2015-06-12 10:56:22 +03:00
Ji-Youn Park bda0ccfb60 elm_win: fix keygrab bug to use wrong keygrab mode
The code set worng ecore_x_keygrab mode according keygrab mode.
and changed some codes for readablity.
2015-06-12 11:16:25 +09:00
Daniel Kolesa 2fbe7d5103 eo: migrate all event docs to new syntax 2015-06-11 17:14:02 +01:00
Mike Blumenkrantz b82ded243f comp effects: add vertical visibility effect 2015-06-11 11:50:52 -04:00
Daniel Kolesa 80f101d420 eo: migrate enum docs to new format 2015-06-11 16:39:33 +01:00
Thiep Ha 8677ef1add widget: Add null check
Summary: Adding NULL checking when allocate memory.

Reviewers: Hermet, seoz, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D2663

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-11 15:15:35 +02:00
Thiep Ha d9712847be transit: add NULL check for memory allocation.
Summary: Adding Null checking when allocate memory.

Reviewers: Hermet, seoz

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D2662

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-11 15:15:35 +02:00
maxerba df0cc6f930 Updating italian translation 2015-06-11 14:20:47 +02:00
Lukasz Stanislawski b2ec75db6d list: add atspi SELECTABLE state to elm_list items. 2015-06-11 11:00:27 +02:00
Shinwoo Kim 3a80bbcb41 [layout] support mirrored set for layout which is using elm_layout_file_set()
Summary: mirroed mode does not work, if layout uses elm_layout_file_set().

Test Plan:
the following is test code.
[test.edc]
collections {

   group {
      name: "layout/test";

      parts {

         part {
            name: "bg";
            type: RECT;
               description {
               state: "default" 0.0;
               color: 255 255 0 100;
            }
         }

         part {
            name: "test.rect";
            type: RECT;
               description {
               state: "default" 0.0;
               color: 255 0 0 255;
               rel1.to: bg;
               rel1.relative: 0.2 0.1;
               rel2.to: bg;
               rel2.relative: 0.5 0.2;
            }
         }

      } /* parts */
   } /* group */
} /* collections */

[test.c]
//Compile with:
//gcc -g test.c -o test `pkg-config --cflags --libs elementary`

#include <Elementary.h>
#include <Ecore_X.h>

static void
_bt_click(void *data, Evas_Object *obj, void *event_info)
{
   Eina_Bool mirrored;
   Evas_Object *layout;

   layout = data;

   mirrored = elm_config_mirrored_get();
   mirrored = !mirrored;
   printf("mirred: %d\n", mirrored);
   elm_config_mirrored_set(mirrored);
}

EAPI_MAIN int
elm_main(int argc, char **argv)
{
   Evas_Object *win, *box, *layout, *bt, *check;
   char buf[PATH_MAX];

   elm_app_info_set(elm_main, "elementary", "./test.edj");
   elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED);

   win = elm_win_add(NULL, "Layout", ELM_WIN_BASIC);
   elm_win_autodel_set(win, EINA_TRUE);

   box = elm_box_add(win);
   evas_object_size_hint_weight_set(box, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
   elm_win_resize_object_add(win, box);
   evas_object_show(box);

   // Adding layout and filling it with widgets
   layout = elm_layout_add(win);
   evas_object_size_hint_weight_set(layout, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
   evas_object_size_hint_align_set(layout, EVAS_HINT_FILL, EVAS_HINT_FILL);
   snprintf(buf, sizeof(buf), "./test.edj");
   elm_layout_file_set(layout, buf, "layout/test");
   elm_box_pack_end(box, layout);
   evas_object_show(layout);

   bt = elm_button_add(win);
   elm_object_text_set(bt, "mirrored");
   evas_object_size_hint_weight_set(bt, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
   evas_object_size_hint_align_set(bt, EVAS_HINT_FILL, EVAS_HINT_FILL);
   evas_object_smart_callback_add(bt, "clicked", _bt_click, layout);
   elm_box_pack_end(box, bt);
   evas_object_show(bt);

   check = elm_check_add(win);
   elm_object_text_set(check, "test");
   evas_object_size_hint_weight_set(check, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
   evas_object_size_hint_align_set(check, EVAS_HINT_FILL, EVAS_HINT_FILL);
   elm_box_pack_end(box, check);
   evas_object_show(check);

   evas_object_resize(win, 500, 500);
   evas_object_show(win);

   elm_run();
   elm_shutdown();

   return 0;
}
ELM_MAIN()

Reviewers: seoz, raster, tasn, Hermet

Subscribers: seoz, cedric

Differential Revision: https://phab.enlightenment.org/D2142
2015-06-09 14:05:58 +01:00
Carsten Haitzler e99831eb2f fix list item mode change on elm list
@fix
2015-06-09 16:43:38 +09:00
Carsten Haitzler 5e79a4e211 elm list - theme - make compress moder work again
someone.. somewhere along the way.. likely a long time ago.. broke
compress mode. likely the addition of the ellipsis value as an
ellipsis position or something related to that broke compatibility,
as this used to work. be that as it may... finding out just where is
virtually impossible, so fix it the simpler way - add elipsis values
2015-06-09 16:25:24 +09:00
Mike Blumenkrantz 51cc52f685 pager16: add signals for toggling content visibility 2015-06-08 14:54:47 -04:00
Mike Blumenkrantz 9d6ac3696c shelf: use spacer for content sizing, toggle content visibility 2015-06-08 14:54:47 -04:00
Mike Blumenkrantz f73944df11 shelf: use constant rects for eventing 2015-06-08 14:54:47 -04:00
Stefan Schmidt c7201386e3 test_win_keygrab: Better use strncpy when copying into fixed size buffer.
We should never copy more than PATH_MAX.

CID: 1298016
2015-06-08 17:21:45 +02:00
Carsten Haitzler 1e8dfb051c elm theme - toolbar - adjust padding for the toolbar to not look so bad
therw was always a small 2 pixel padding inside the toolbar. it just
looks bad for toolbar so expand out to boundary of toolbar
2015-06-07 11:22:31 +09:00
Lukasz Stanislawski 166d8c2db8 atspi: fix popup role and signal emission 2015-06-05 16:00:30 +02:00
Amitesh Singh 6b8de59969 tooltip: fix tooltip multi line text issue
Summary:
This is fixed by removing wrap=word from tooltip style.

Resolves: T2034

@fix

Test Plan:
1. elementary_test -> tooltip
2. click "unlock tooltip visibility"
3. check tooltip text. full text is not visible.

Reviewers: seoz, raster, Hermet, cedric, tasn

Reviewed By: tasn

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D2606
2015-06-04 10:25:44 +01:00
Lukasz Stanislawski dd19750273 entry: improve at-spi2 accessibility support
* return guide text instead of content
* mask passwords
* set proper at-spi roles when entry enables password mode.
2015-06-03 17:38:34 +02:00
Lukasz Stanislawski 27090197cf atspi: fix signal name 2015-06-03 17:38:34 +02:00
taehyub 8bdcdf8cc6 interface scrollerable: modify the loop_v condition in _elm_scroll_momentum_animator() function
Summary:
change the 'sid->loop_v' condition to '!sid->loop_v' to delete momentum animator
when the vertical scroller reached the end of the content

@fix

Reviewers: raster, Hermet, woohyun

Subscribers: CHAN

Differential Revision: https://phab.enlightenment.org/D2609
2015-06-03 21:30:50 +09:00
Vaibhav Gupta bb6ea34e68 Gengrid: Fix typo in API Documentation.
Summary: Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>

Reviewers: raster, Hermet

Reviewed By: Hermet

Subscribers: sachin.dev, singh.amitesh

Differential Revision: https://phab.enlightenment.org/D2619
2015-06-03 21:19:32 +09:00
Vaibhav Gupta 3118690837 Genlist: Fix typo in API Documentation
Summary: Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>

Reviewers: raster, Hermet

Reviewed By: Hermet

Subscribers: sachin.dev, singh.amitesh

Differential Revision: https://phab.enlightenment.org/D2620
2015-06-03 21:17:49 +09:00
shilpa.singh cfaf18f967 Elm: Add context,open signal in elm_entry.
Summary:
When context,open signal is sent from elm_entry before showing context
menu, dynamic addition of context menu items to entry becomes easier.

@feature

Test Plan:
Run elementary_test
Launch Entry Scrolled test
Right Click on Multiline Markup entry

Reviewers: tasn

Reviewed By: tasn

Subscribers: subodh6129, poornima.srinivasan

Differential Revision: https://phab.enlightenment.org/D2580
2015-06-03 10:41:13 +01:00
Jaehyun Cho e9eeadd93c examples: Replace setenv() with elm_config_accel_preference_set().
Replace environment value set with elm_config_accel_preference_set.
2015-06-02 19:25:39 +09:00
Jaehyun Cho 64e799d1a7 examples: Replace preferred engine "opengl_x11" with accel preference "3d".
Replace preferred engine "opengl_x11" with accel preference "3d".
2015-06-02 19:22:39 +09:00
Daniel Zaoui 9ab2ab73fe Focus: add and fix comments 2015-06-02 08:46:55 +03:00
WooHyun Jung 52b95670e3 missed from prvious commit 2015-06-02 13:48:09 +09:00
WooHyun Jung 98060bd8da elm_focus: added new focus move policy and elm_object_focus_move_policy_set/get
New focus move policy, ELM_FOCUS_MOVE_POLICY_KEY_ONLY, is added.
If you set this policy as base focus move policy, objects cannot steal
focus by using mouse click or mouse in. Only keyboard input (such as Left,
Right, Up, Down, ...) can make focus be moved.
Additaionally, an object can have its own focus move policy by using
elm_object_focus_move_policy_set API.

@feature
2015-06-02 13:42:00 +09:00
Tom Hacohen d495b6874e Elm widget: Fix some Eolian warnings. 2015-06-01 15:02:05 +01:00