enlightenment/efl
enlightenment
/
efl
8
7
Fork 15
Code Issues 12 Pull Requests 2 Projects Releases Wiki Activity
54,762 Commits 489 Branches 2 Tags 427 MiB
Commit Graph

20066 Commits

Author SHA1 Message Date
Carsten Haitzler 26e93caec7 evas textblock - remove redundant check 
found by PVS studio
 2017-07-31 11:34:41 +09:00
Carsten Haitzler 1dc443a1a6 epp - cpp - fix buffer end/null checks given static buffer paths 
this is an ncient bug that's never been triggered... but it's there.
fix and compare to null buffer.

found by PVS studio

@fix
 2017-07-31 11:31:04 +09:00
Carsten Haitzler 71b1f4d5a5 epp - remove redundent check for char 
makes static analyisers happy... not a bug

found by PVS studio
 2017-07-31 10:58:27 +09:00
Carsten Haitzler 6ac4ea2080 evas cache2 - remove excess file and key checks - only check file 
no need for key as no key is handled and no file is handled too. cleaner
code.

found by PVS studio
 2017-07-31 10:58:04 +09:00
Carsten Haitzler 2d4d836018 elm gesture layer - use fabs not abs when actually comparing floats 
2 abs uses should have been fabs as they compe a src float with
anot her float.

found by PVS studio

@fix
 2017-07-31 10:41:39 +09:00
Carsten Haitzler 573d0cf586 eina debug - set length after freeing/iterating over the keys 
found by PVS studio
 2017-07-31 10:03:59 +09:00
Carsten Haitzler ae79052376 elm calendar - fix gmtime call to use an actual value 
e85c92662b added this bug. before it was
always set to 259200 (first sunday after epoch).

found by PVS studio
 2017-07-31 10:00:00 +09:00
Carsten Haitzler 2c1e2db876 ecore_drm2 - fix startup if edid blob is null.. assume all 0's 
this causes a crash when no edid is available. survive and dont crash.
this causes e wayland to not work at all on my baytrail laptop.

@fix
 2017-07-30 23:27:56 +09:00
Carsten Haitzler 3de08599bf eldbus lower error print levesl from ER to WRN in get all props 
this is generally unnecessary noise as the majority of the time i see
this it's because the message was canceled by the caller... thats not
an error though then... it's intended. less debug noise to sift through.
 2017-07-30 23:04:35 +09:00
Derek Foreman 1a175cd537 ecore_evas_drm: Only check for gpu time offset if env var set 
Since most systems shouldn't need this, and it's possible
that it's causing trouble for some systems, make it off by
default.

Fix T5806
 2017-07-29 08:52:16 -05:00
Carsten Haitzler e1605e6405 tests - make ecore con test suite reliable and work 
basically ecore_con's test suite was broken. ipv6 checks were broken.
you now need to set an env var to get ipv6 tested. using eocre_con to
detetc it didnt init eina or ecore_con and if you do init these then
the other tests that check return values from these fail... so make it
an env var if you want to test ipv6. now it's reliable and works!
 2017-07-29 14:56:57 +09:00
Carsten Haitzler 2b91a48d72 ector software - fix min/max int range for fixedpoint math 
min value bitshifts are negative and thus not portable. just tax max
(as its 1 more than min it if we do -max) as the limit as its within
range. this should fix it

@fix

found by PVS studio
 2017-07-29 13:49:33 +09:00
Carsten Haitzler 29eebb44fc evas render - remove obj null check in proxy clip as obj not null 
obj is never null. so this check is pointless. not a bug though.

found by PVS studio
 2017-07-29 12:26:49 +09:00
Carsten Haitzler 3c27869c93 evas object textblock - fix append if cur node is null 
then it will appeand totally as it should be. small buglet found. fixed

found by PVS studio

@fix
 2017-07-29 12:20:12 +09:00
Carsten Haitzler a0ed0483fc evas gl gnenric engine - dont check w and h ptrs - will never be null 
analyser unhappiness.

found by PVS studio
 2017-07-29 12:06:20 +09:00
Carsten Haitzler 66f71d2ebc embryo_cc - remove pointless test for null byte and space 
space wins. the nul byte test is pointless. not a bug but pointless code

found by PVS studio
 2017-07-29 11:36:33 +09:00
Carsten Haitzler 7620d5d957 ecore-x - remove useless extra assignments of value to itself 
usless code that does nothing - not a bug though

found by PVS studio
 2017-07-29 11:22:54 +09:00
Carsten Haitzler 075e150a03 edje_cc - remove pointless free of null ptr 
not a bug but not useful code either freeing what is already null

found by PVS studio
 2017-07-29 11:13:26 +09:00
Carsten Haitzler 7abf4715f2 efl ui text - remove useless else + free 
string is null so no need to free. not a bug but cleaner and analysers
dont like it.

found by PVS studio
 2017-07-29 11:11:21 +09:00
Carsten Haitzler fe781b284c edje entry - remove extra else and free as sdtring is null there 
string is null so no need to free. not a bug but cleaner and analysers
dont like it.

found by PVS studio
 2017-07-29 11:08:46 +09:00
Carsten Haitzler cfe4f19f54 eina simple xml parser - remove pointless memcmp of 0 bytes 
no point - all we are doing is having a final fallback of any tag that
starts with ! that isnt a special one like !DOCTYPE, !-- comment and
![CDATA stuff... analysers dont like these pointless calls.

found by PVS studio
 2017-07-29 11:03:01 +09:00
Carsten Haitzler 8b6e72bfad els box - remove rudundant double check 
not a bug but checking something twice in a row isn't too useful

found by PVS studio
 2017-07-29 10:56:53 +09:00
Carsten Haitzler 20333c7905 elm code - remove unneded extra check from copy and pasta it seems 
extra check already done in if above - no need. looks like copy &
paste of the checks from above thus why it's there, but not needed.
not a bug, byt analysers dont like it so remove

found by PVS studio
 2017-07-29 10:56:53 +09:00
Carsten Haitzler 2eb46302a2 emotion gst1 module - remove extra unneded if's 
not a bug, but don't need these

found by PVS studio
 2017-07-29 10:56:53 +09:00
Carsten Haitzler 08a69d2284 eeze_disk - remove redundant if check already done 
removes redundant fi check. not a bug but analysers dont like it and
it is redundant

found by PVS studio
 2017-07-29 10:56:53 +09:00
Carsten Haitzler ff26991220 efl net - fix ipv6 getsockname to use the proper struct to do it 
struct sockaddr_storage *addr;

AS the actual storage ( a ptr to store the whole data). kind of...
wrong. it should be:

      struct sockaddr_storage addr;

see examples of this kind of usage of getsockname:

http://www.masterraghu.com/subjects/np/introduction/unix_network_programming_v1.3/ch04lev1sec10.html

found by PVS studio

@fix
 2017-07-29 10:56:47 +09:00
Carsten Haitzler d532f28284 eeze disk - remove uneeded extra check for test var 
test for non null already done above, so test must obviously be null
here so no need to check. analysers dont like this but it's not a bug.
make them happy thought

found by PVS studio
 2017-07-29 10:37:51 +09:00
Carsten Haitzler 157caee2c0 evas psd loader - remove unneeded extra check in if 
one if condition is always true by virtual of previous if statements
and drop-through so can remove. not actually any bug but analysers
don't like it

found by PVS studio
 2017-07-29 10:37:51 +09:00
Carsten Haitzler d6785cfeb6 eina debug - if calloc for session struct failed - return NULL 
makes analysers happy but really doesnt change anything - moves the
abort/crash/exit somewhere else.

found by PVS studio
 2017-07-29 10:37:44 +09:00
Carsten Haitzler 53629e2fd2 edje_cc - make list free simpler to make analysers happy 
analysers like PVS studio dont know the eina_list_free returning NULL
design pattern for consistency and so dislike the var being set twice
in a row. this will make them happy without any skin off our backs.
not a bug at all.

found by PVS studio
 2017-07-29 09:44:54 +09:00
Carsten Haitzler c0764e153e evas git loader - move findo reset inside else as only that changes it 
only the else changes finfo so reset inside there. not really any bug
at all byt style-wise a bit better and analysers don't like it

found by PVS studio
 2017-07-29 09:42:44 +09:00
Carsten Haitzler 9c507faf2a elm list - remove harmless extra null set to keep analysers happy 
this was totally harmless and not an actual bug but it keeps analysers
happy.

found by PVS studio
 2017-07-29 09:42:43 +09:00
Carsten Haitzler e85694f33b elm dayselector - remove double set of content var 
this looks like a leftover from legacy to eo porting. it was harmless
but analysis hates it

found by PVS studio
 2017-07-29 09:08:40 +09:00
Carsten Haitzler 5a1f8fdf41 elm code - remove double set of textlen 
analysis doesnt like it, but not a bug

found by PVS studio
 2017-07-29 09:08:40 +09:00
Carsten Haitzler 1670ee2766 edje edit - remove pointless setting attr_mount to 0 
static analysers dont like it bug not a bug at all

found by PVS studio
 2017-07-29 09:08:40 +09:00
Carsten Haitzler 2930bc0b06 evas pmap loader - remove pointless extra assign of end of string to 0 
not an actual bug - just analysis impacting

found by PVS studio
 2017-07-29 09:08:40 +09:00
Carsten Haitzler aab56c4123 eldbus parser - remove duplicate tag handler thats already handled 
confusing and dead code as it's already handled. not an actual bug but
analysis impacting

found by PVS studio
 2017-07-29 09:08:40 +09:00
Carsten Haitzler 302731e1af evas events - remove set of list to null then back to value - confusing 
eina_list_free always returns NULL. it's meant as a design pattern to
follow like the append/prepend that ensures a freed list is NULL, but
it can be confusing to analysers so remove the assing. not a bug
actually.

found by PVS studio
 2017-07-29 09:08:40 +09:00
Carsten Haitzler b944fc7c9b eina evlog debugging - when freeing debug buf with mmap 0 size after 
munmap would not munmap the memory with  a size of 0... so zero the
size after the munmap.

found by PVS studio

@fix
 2017-07-29 09:08:40 +09:00
Carsten Haitzler e9ab26ae53 evas obj smart - remove pointless if 
s is already checked for null... so no need to check again

found by PVS studio

@fix
 2017-07-29 09:08:40 +09:00
Carsten Haitzler e9123a5a58 edje edit - when adding size class set max width and height to -1 
since we're not using size class yet.. we hvent had to debug this...
but it is a bug.

fond by PVS studio

@fix
 2017-07-29 09:08:40 +09:00
Carsten Haitzler 16abe895c6 efl net ssl constructor - remove double set of same var 
all struct vars are set... one 2x. not a bug but pointless code in the
src

found by PVS studio
 2017-07-29 09:08:40 +09:00
Carsten Haitzler 64dc6ab056 evas bmp loader - fix warnings about same type handled twice 
so a type we handle earlir inan if we re-handle as invalid later. this
wouldnt lead to a crash or bugs as the if's would ned to be evaluated
in order normally, but it's good to get it right.

found by PVS studio
 2017-07-29 09:08:40 +09:00
Carsten Haitzler 02a07caca4 etc to rgba conversion - dont read stack garbage into the est imgs 
surprising this wasn't caught when testing fallbacks. etc2 is used
hyper-rarely but still... basically it'd skip pixels and read stack
junk (which really would not crash but we'd have junk in image data).
or should.

found by PVS studio

@fix
 2017-07-29 09:08:40 +09:00
Carsten Haitzler 51cc2e0ec6 ephysics - fix stacking comparsion correctly if 1 smaller than 1 
this fixes a pretty trivial comparison issue..

found by PVS studio

@fix
 2017-07-29 09:08:40 +09:00
Carsten Haitzler fec726e7e5 evas legacy event mask - cast to unit64_t before bitshift 
this fixes a bit wraparound in the shift as the 1 is an int (32bit)
type that then gets shifted .. then after that cast to 64bit.

found by PVS studio

@fix
 2017-07-29 09:08:31 +09:00
Carsten Haitzler 091146fa34 eina inarray accessor - use right type in parameter 
this actually wasn't a bug that would cause a crash. cloning an array
access would fail as the magic check would find its an accessor not an
array. indeed a bug... but we never used this anywhere i can find.

this was cast to the correct func ptr callabck in the accessor struct
as the clone method though.. thus everyhting was happy with it
seemingly.

found by PVS studio

@fix
 2017-07-29 08:55:27 +09:00
Derek Foreman 33439865de elput: Fix synthetic relative motion events based on abs events 
libinput won't actually give us this info, and logs an error instead.
We can't synthesize based on pointer position due to pointer
warping.

So we must track abs reports and use previous abs reports to
synthesize rel events.
 2017-07-28 16:48:38 -05:00
Derek Foreman 2b16fc4278 ecore_evas_drm: Calculate gpu blank time offset once at startup 
So vmware's graphics driver reports the MONOTONIC drm cap, yet uses
CLOCK_REALTIME instead.  This leaves us with a gigantic offset between the
gpu timestamp and the times ecore_time_get() gets from CLOCK_MONOTONIC.

Since ticking screws directly with loop time this results in some long
distance clock jumping.

This commit fixes drm/gl_drm operation under vmware.
 2017-07-28 15:35:03 -05:00
Derek Foreman 0584fc81a2 ecore_drm2: Add a fallback method for vblank waiting 
We can't depend on vblank waits being implemented by the driver, but we
can count on page flips functioning, so add a fallback that does a page
flip and waits for it.
 2017-07-28 15:35:03 -05:00
Mike Blumenkrantz 6bb56b3f56 ecore-wl2: implement support for aux hints 
this is a direct copy of a feature from tizen git with no modifications other
than what was required for compilation and functionality

https://review.tizen.org/git/?p=platform/upstream/efl.git;a=commitdiff_plain;h=01e72b7e3484ece4b589f95315990ba2c366c231
https://review.tizen.org/git/?p=platform/upstream/efl.git;a=commitdiff;h=670d84b579f248ae0e3df48e9953fe8128da9468

fix T5780

@feature
 2017-07-28 15:43:48 -04:00
Mike Blumenkrantz 6dc937d26c Revert "evas: Fix use of invalid EO object" 
This reverts commit 9b1e785f8e.

this breaks devices with vt switching under drm
 2017-07-28 15:40:47 -04:00
Mike Blumenkrantz d529d6def6 elput: fix seat cleanup 
ensure seat deletion does not conflict with elput shutdown

@fix
 2017-07-28 15:40:47 -04:00
Mike Blumenkrantz ea4ae11023 elput: unref devices in post event cb 
@fix
 2017-07-28 15:40:47 -04:00
Mike Blumenkrantz b43a2d55e1 elm_table: do not propagate max size 
evas table does not set max size, propagating this triggers unnecessary
callbacks

@fix
 2017-07-28 15:40:47 -04:00
Mike Blumenkrantz 049d0c1f4c elm_box: use correct aspect ratio for HORIZONTAL layout 
ratio should be flipped in this case

@fix
 2017-07-28 15:40:47 -04:00
Mike Blumenkrantz 531422a2bb elm_box: use homogeneous layout if only one child exists 
this should be a small speedup for a corner case of box use
 2017-07-28 15:40:47 -04:00
Mike Blumenkrantz 812be4a43b elm_win: do not implement aspect_get() 
this breaks aspect hints.

@fix
 2017-07-28 15:40:47 -04:00
Mike Blumenkrantz 4f2b4d870a efl-wl: escape command args from test 2017-07-28 15:40:47 -04:00
Mike Blumenkrantz 84ae9d82d0 efl-wl: hide popup surface before unsetting attrs during destructor 
ensure focus remains with the popup parent
 2017-07-28 15:40:47 -04:00
Mike Blumenkrantz e24bc7517b efl-wl: simplify refocus on popup hide 2017-07-28 15:40:47 -04:00
Mike Blumenkrantz b32ae04306 efl-wl: use correct window when requesting x11 clipboard selection 2017-07-28 15:40:47 -04:00
Guilherme Iscaro ef03ecd89c Ecore_Con: Fix wrong comparison. 
Otherwise it will always evaluate to false.
 2017-07-28 15:22:51 -03:00
Guilherme Iscaro 493f75587d Ecore_Conn: Set EOS only if the connection is not closed.#algo. 
This check prevents that EOS is set on a closed connection.

Fixes T5180
 2017-07-28 15:22:51 -03:00
Guilherme Iscaro 0a51ac2997 Ecore_Con: Fix CLOEXEC documentation. 
The socket attributes are inherited by the child.
 2017-07-28 15:22:51 -03:00
Derek Foreman 8e500c6835 ecore_drm2: Allow picking a sequence number for blanktime_get 
This lets us do a blocking wait for a vsync.  Something we should try to
do as infrequently as possible, but in some cases we need it one time at
startup to catch graphics driver bugs.
 2017-07-28 10:41:11 -05:00
Daniel Hirt 2efa25511f Elm entry: fix call to set text via entry_set 
Accidentally called the super here, so did not get routed to
'_elm_entry_text_set'.

Fixes T5803.
 2017-07-28 12:36:07 +03:00
Amitesh Singh fd65e0f56a elm test: img.zoomable: allow top rect to pass events 2017-07-28 16:07:21 +09:00
Felipe Magno de Almeida 634f7d0dbb eo-cxx: Add overload for Eina_Bool inout handling interoperability 
Add convert_inout_impl overload to handle bool/Eina_Bool conversion in inout direction.
 2017-07-27 13:20:20 -03:00
Guilherme Iscaro 45a767632d Ecore_Conn: Enable CLOEXEC by default. 
This flag should be enabled by default in order to avoid socket leaks.
 2017-07-27 16:54:34 +02:00
Guilherme Iscaro 97f6803be1 Ecore_IPC: Preserve Ecore_Con legacy behaviour. 
This patch sets some Ecore_Con flags that were missing after
the EO migration. These flags must be set in order
maintain the Ecore_IPC behaviour before Ecore_Con EO was implemented.

Fixes T5722
 2017-07-27 16:54:16 +02:00
Amitesh Singh 0787b739cd efl.ui.image.zoomable: Add missing edje.group_size_min/max_get 
This supresses the warnings when photocam is used as
an external edje object.
 2017-07-27 19:06:27 +09:00
Jean-Philippe Andre 936ea58cb9 evas: Always call show/hide intercept 
Ref T5370
 2017-07-27 15:53:43 +09:00
Marcel Hollerbach f2b6a67115 elm_widget: change to @inout 
according to q66 this is correcter than ptr(..).

Anyhow this still leads to a bug in cxx that crashes compilation in cxx
examples, people are notified!
 2017-07-26 18:56:59 +02:00
Marcel Hollerbach 01af4dd13b elm_widget: fix warning 2017-07-26 15:52:54 +02:00
WooHyun Jung 9ef214ec08 ecore_events: inarray should be flushed before return 
@fix
 2017-07-26 18:57:37 +09:00
Jiyoun Park 6d4ebf9bc6 ecore_evas_wayland: fix bug ecore_evas cannot update the evas when rotation 
usecase:
    show -> rotation -> hide -> show
    ecore_evas_wayland didn't check the rotation.
    when ee is landscapemode, it cannot update the right area of evas.
 2017-07-26 15:28:02 +09:00
Andy Williams 77db870b61 elm_code: Fix missing middle button selection paste 
Resolves task T5520
@fix
 2017-07-25 23:54:21 +01:00
Derek Foreman 69c6cbfdf1 elput: Close fds when asked to 
Our close callback tells logind we're done with a device, but it should
also actually close the fd it's passed, or we end up leaking piles of
fds on VC switch.

see weston commit 8f5acc2f3a29c3831af4ddd6bed57f703c98dc77
and subsequent regression in commit 72dea06d7952e3ce8dd8057f7106186da4fa2678
and pending fix in https://patchwork.freedesktop.org/patch/168992/
 2017-07-25 16:59:11 -05:00
Sungtaek Hong a5fc50c186 edje_cc: fix wrong comment about lazEDC norequired. 
Summary: - norequired; stands for required: 0

Reviewers: conr2d, jpeg

Reviewed By: jpeg

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5036
 2017-07-25 14:44:40 +09:00
Jean-Philippe Andre d4b2eb1e7f elm: Move calls to efl_destructor(efl_super()) to the end 
When destroying any object, its parent class destructor should
be called after the subclass destructor has been called. Only
some extremely limited work may be done after the super call.

This commit makes sure that all efl_destructor() overrides in
elementary are doing operations in the right order.

Also, remove a return void.
 2017-07-25 14:43:12 +09:00
Marcel Hollerbach dd883a7064 elm_widget: only emit events when there is really a changed manager 
A manager change to NULL is to be used as "this object is not registered
anymore" call, which will happen quite regular during shutdown.
 2017-07-24 23:40:38 +02:00
Marcel Hollerbach 6f0b79fe4b elm_widget: call the events after eval outself with new manager/parent 
otherwise we might end up with a node_get error, since the widget where
the event is called on is still registered in the wrong manager
 2017-07-24 23:40:38 +02:00
Marcel Hollerbach b49df7128a elm_widget: only set focus.manager if we are really registering 
otherwise we might set focus.manager even if we are not registered
 2017-07-24 23:40:38 +02:00
Marcel Hollerbach 47ce995637 elm_widget: give feedback if registration was successfull or not 
with this we can whipe out the focus.manager field in elm.widget so for
the case that something goes wrong we only get the error message where
actually something went wrong, and not the whole bunch of follow ups
where the code assumes its registered but it isnt.
 2017-07-24 23:40:38 +02:00
Derek Foreman 27f88b534a elput: Fix multiple open/close of drm devices 
When I added the code to probe drm devices to ensure they're
modeset capable (ref 414d406b3b)
I didn't realize elput didn't allow us to open and close more than
one drm device at startup without blowing up libinput.

This is a somewhat dirty hack to rough that in.

The problem is that open/close the device during startup will
result in an async "gone" callback from logind, which then kicks
off an input shutdown.  We need to try harder to only do that
shutdown when it makes sense.
 2017-07-24 16:06:52 -05:00
Mike Blumenkrantz aae4d21b63 ecore-wl2: handle null offer drags more effectively 
this is valid and refers to an offer with no types; a leave event
with no enter is a protocol error, however

fix T5770

@fix
 2017-07-24 08:30:05 -04:00
Mike Blumenkrantz 451a93d9d2 Revert "ecore wl2 - dnd - handle NULL drags... shouldnt happen but does" 
This reverts commit 85e5858466.

please do not randomly add null checks for the purpose of quickly closing tickets.
 2017-07-24 08:29:45 -04:00
Carsten Haitzler 85e5858466 ecore wl2 - dnd - handle NULL drags... shouldnt happen but does 
this should fix T5770

@fix
 2017-07-24 18:53:33 +09:00
Carsten Haitzler fd9e6b305d efl net server udp - report erro on alloc failure 
unwind nicely and complain
 2017-07-24 17:44:22 +09:00
Carsten Haitzler 143709faba ecore con proxy helper - complain when realloc fails 
so you know why things might be failing... complain about out of
memory errors.
 2017-07-24 17:35:13 +09:00
Carsten Haitzler fe6dc2000d ecore exe - pisix - handle malloc fails 
handle malloc fails better
@fix
 2017-07-24 16:59:53 +09:00
Carsten Haitzler 829d0bc3f9 ecore win32 exe handling - check realloc and malloc returns 
handle out of memory errors better
@fix
 2017-07-24 16:57:22 +09:00
Carsten Haitzler b47cbdcb65 ecore_exe - handle realloc failures by complaining and rolling back 
@fix
 2017-07-24 14:10:17 +09:00
Carsten Haitzler 132c047c4d embryo_cc - be sensible about realloc returns so analysers are happy 
assingto tmp var then assign to real one after a check to analysers
dont complain.
 2017-07-24 13:46:30 +09:00
Carsten Haitzler 8786449704 efreetd cache create - fix reallocs to bail on out of memory cleanly 2017-07-24 13:37:57 +09:00
Carsten Haitzler 8e311db414 edje_cc - make svg loader (still beta) handle out of memory nicely 
print ERR and abort.
 2017-07-24 13:26:28 +09:00
Carsten Haitzler 92fb46fb50 edje convert - make realloc fatal and complain about it 
cleaner error handling
 2017-07-24 13:09:26 +09:00
Amitesh Singh 4b4564c857 edje_cc out: fix div by 0 correctly 2017-07-24 09:50:05 +09:00
Andy Williams 292e9e9ecf elm_code: Fix crash with long lines 
Also fixes issue where widget would sometimes blank when scrolling
@fix
 2017-07-23 21:30:35 +01:00
Carsten Haitzler 83a249baa1 edje_cc out - fix theoretical div by 0 
fixes CID 1371125
 2017-07-23 19:48:16 +09:00
Carsten Haitzler d62f7d72e6 edje_cc out ... fix theoretical div by zero... 
if files size was 0... which would basically make a lot fail before...
it could be a divide by zero. fix and just assume minimum size of 1.

fix CID 1371127
 2017-07-23 19:46:17 +09:00
Carsten Haitzler 17d33c7138 efl ui grid - handle invalid 0x0 fully if the grid size fails to do it 
if efl_pack_grid_size_set is overridden and somehow allows 0x0 to
still happen then handle this caase and skip the layout.

fix CID 1374317
 2017-07-23 19:42:06 +09:00
Carsten Haitzler a91d0b2ea4 edje_cc out ... check more iui list element ptrs to help coverity 
fix CID 1374482 ... and others i hope.
 2017-07-23 19:36:41 +09:00
Carsten Haitzler 4df92f88d0 edje_cc out - double check list element ptr to make coverity happy 
fix CID 1374483
 2017-07-23 19:33:58 +09:00
Carsten Haitzler 3826f21a29 evas seat focus add - handle other case where layer may be null 
fix CID 1377522
 2017-07-23 19:30:31 +09:00
Carsten Haitzler bb7e8456c4 eina debug timer - handle fail wakeup write with error complaint 
fix CID 1377528
 2017-07-23 19:26:56 +09:00
Carsten Haitzler 144f5f73e0 add comment about poll high/medium/low implementation of events 
not brilliant as it stands. :(
 2017-07-23 19:18:55 +09:00
Carsten Haitzler 8a80005f25 ecore main - fix division to remain a double/float as expected 
1/60 != 1.0/60.0 ... the first is an integer which is 0... the second
is 0.016666666 .... a float/double. fix CID 1377532
 2017-07-23 19:12:32 +09:00
Carsten Haitzler 758e7d3562 eina debug - don't try and collect stats on more than a million threads 
sanity check... just in case.
 2017-07-23 19:09:11 +09:00
Carsten Haitzler b2809026bb elm cnp - check if selbuf is null or not and skip copying if null 
this should fix CID 1377536
 2017-07-23 18:56:43 +09:00
Carsten Haitzler b3b0411a05 evas callbacks - check if obj->events is valid because it's cow alloced 
it COULD be null and we do have other checks for it being not-null and
we dont check if the alloc fails...  so check. this SHOULD fix
CID 1377547
 2017-07-23 18:53:46 +09:00
Carsten Haitzler 6a65cb2f3c eina debug - add comments to cpu debug using locks to pause sysmon 
this is intended so leave comments saying so. coverity doesn't like it
with CID 1377549
 2017-07-23 18:43:58 +09:00
Carsten Haitzler c69f9d2837 eina debug - check return value of syscall for errors 
this should fix CID 1377550
 2017-07-23 18:40:04 +09:00
Carsten Haitzler 4095165385 efl canvas image - dbug ingo get - dont get if no root dbg info supplied 
if root dbg info is null we'll leak and not have anything useful
stored somewhere for fetching anyway.

this should fix CID 1365656
 2017-07-23 18:36:44 +09:00
Carsten Haitzler 60d2bd233b evas module load add comments pointing out this is intentional ptr loss 2017-07-23 18:29:57 +09:00
Carsten Haitzler fceb86c865 efreetd cache - fix leak of strbuf when error conditions abort save 
fix CID 1374951
 2017-07-23 18:11:26 +09:00
Carsten Haitzler 91878f72f1 efreetd cache - handle queue case leaking strbuf 
fix CID 1374954
 2017-07-23 18:09:39 +09:00
Carsten Haitzler 8f67f2f2d3 ecore_audio headers conflict with app have ifdefs 
Ecore_Audio.h had #ifdef HAVE_PULSE ... and that is just so wrong as
this is something an ap[p may or may not set in its config.h ... but
this certainly hase no place in our public headers. the api's there
should always be there... symbols always... just imtplementation may
be empty ... though ecore_audio doesnt build at all without pulse...
so it's moot.

so fix this build issue i found when fixing e build issues with meson
changes etc.

@fix
 2017-07-22 17:59:11 +09:00
Derek Foreman 414d406b3b ecore_drm2: Ensure device we find can mode set 
Some systems have dri devices that can't mode set, and if they're first in
the directory they'll get picked by our code and things fall apart later.

So, open the potential device and ensure it has basic functionality before
selecting it.

This is a little inefficient as it gets the device via elput twice before
it can be used - this will be addressed later as the changes are a little
more invasive to optimize.
 2017-07-21 16:46:00 -05:00
Derek Foreman 57e826db69 ecore_drm2: Open elput manager before drm device 
We're going to need to access the device as part of the find process,
so we need a manager.
 2017-07-21 16:46:00 -05:00
Jean-Philippe Andre dcf751bd3d hover: Return valid slot for main_menu_submenu 
Fixes T5760
 2017-07-21 16:18:36 -04:00
Mike Blumenkrantz 337f3796d6 ecore-evas-wayland: destroy frame callback on hide 
ensure cursor surfaces can render again after being hidden

 #TheDisappointer

@fix
 2017-07-21 16:17:54 -04:00
Mike Blumenkrantz 89e0d387dd eldbus: print full filename when codegen write fails 2017-07-21 16:17:54 -04:00
Mike Blumenkrantz 93bac8ce4a wayland: stop creating 1x1 surfaces on init 
fix T5226

 #IGot99TicketsBut1x1AintOne
 2017-07-21 16:17:54 -04:00
Mike Blumenkrantz 5070ecc99a elm_win: instantiate csd frame after creating pointer surface 
csd attempts to create sw cursors if the pointer surface doesn't exist,
so create the pointer surface before the csd to avoid duplicate cursors

 #TheDisappointer
 2017-07-21 16:17:53 -04:00
Mike Blumenkrantz 5acd75c0c9 elm_win: do not set invalid geometries on the window object 
clamping to 1x1 is not valid, neither is trying to always position at 0,0

 #IGot99TicketsBut1x1AintOne
 2017-07-21 16:17:53 -04:00
Mike Blumenkrantz 10516fa3fd elm_win: hide pointer surface on mouse out 
this should be unmapped so edje stops trying to render to it, though
at some point it could be optimized to not hide and just reuse the buffer
when showing again

 #IGot99TicketsBut1x1AintOne
 2017-07-21 16:17:53 -04:00
Mike Blumenkrantz d67bdc92b7 elm_win: show pointer canvas after setting cursor 
setting cursor calls resize, which is what sets the surface size

 #IGot99TicketsBut1x1AintOne
 2017-07-21 16:17:53 -04:00
Mike Blumenkrantz 9a56b267cd evas sw x11: formatting 2017-07-21 16:17:53 -04:00
Derek Foreman 736c63be34 gl_drm: half fix eglGetPlatformDisplayEXT usage 
Just because the #define is present doesn't mean the extension is, so we're
BAILing on egl completely on some systems for no good reason at all. (saw
this on an SGX stack)

This is still wrong.  I don't want to try too hard until after the upcoming
release, though.

We should actually be testing for the presence of client extensions before
attempting to do any of this.  It's entirely possible that a gl stack will
return bogus functions for these from eglGetProcAddress
 2017-07-21 14:34:50 -05:00
Carsten Haitzler b8a760ed58 efreet - dont complain if INTERNAL x extension hash of desktop is NULL 
asking for an x- field from a desktop shouldnt result in null safety
checks IF the x hash is null - it's fine if it's null - that field
just doesn't eixst. if other fields were in the x hash but the desired
one wasn't it'd not complain, so why complain if there is just no x
hash?
 2017-07-21 17:02:43 +09:00
Carsten Haitzler 97c3eedbab evas xpm loader - don't error print for files that cant be mmaped 
no point complaining because we can't mmap... it'd be an unloadable
file.
 2017-07-21 16:35:21 +09:00
Carsten Haitzler 0f73f10a42 efreet - remove noisy debug printfs 2017-07-21 06:06:59 +09:00
Daniel Hirt 01a693412f Evas textblock: add definition to 'cursor_equal' 
This is a follow-up to c4ea25cbdb to fix
legacy API.
The definition was missing, so adding it.
 2017-07-20 19:20:36 +03:00
Stefan Schmidt cc924aacde eldbus: codegen: free allocated strbuf in error path 
fname would have been leaked if we failed to get a file_handler.
Also make sure we always create a new fname strbuf even without
a output_dir present to fix a potential unbalance between creating
and freeing.

CID: 1378112
 2017-07-20 16:15:32 +02:00
Marcel Hollerbach 344a049ddb elm_widget: do not check for the visibility 
it seems like the visibility is evalulated from different parent
relations, Just because the box (that is a container of a element) is
not visible, does not mean that the element in it is also not visible,
this somehow comes back to the box beeing deleted, the children beeing
reparented in evas, but not in elm. This is for now just a quickfix,
since those calls are just for optimization.

This fixes a load of errors once the elm_test window is closed

@fix
 2017-07-20 12:00:13 +02:00
Jean-Philippe Andre 5db3e557c5 eina_list: Ensure single init 
This fixes a crash in make check when --profile=dev is explicitely
enabled. eina_list_init() is called by the standard eina_init() loop
and by eina_debug_init() as well.

Honestly I'm not sure why it doesn't crash for other people as
well...

The crash was in eolian_suite during the second eina_init (called
from eolian_init).
 2017-07-20 17:47:51 +09:00
Jean-Philippe Andre 7bb14727af evas: Fix a crash in emotion with GL 
Ooops! When mapping for writing we can't use the same code
path as when tofree is true. This restores the path for image
writing. This basically fixes rage with GL engine.

See also 45c8e5e983
 2017-07-20 16:43:52 +09:00
Hosang Kim 05e3e450e5 slider: fix jumping handler bug. 
Summary:
Actual slider value is not changed.
So when user release mouse or touch, slider value is returned
to the value by user set.

This is a partial revert of f41e276160

Fixes T5745

Test Plan: elementary_test -> slider

Reviewers: jpeg

Subscribers: cedric

Maniphest Tasks: T5745

Differential Revision: https://phab.enlightenment.org/D5031
 2017-07-20 15:28:32 +09:00
Jean-Philippe Andre 7243b71a19 evas: Restore flag pre_render_done in render_mapped 
Some objects don't go through render_pre (unchanged, child
of mapped parents), even though they will go through
evas_render_mapped. Those were marked as pre_render_done
inside evas_render_mapped since it seemed to fix some issues
a long time ago.

Unfortunately, if those objects are changed their flag may
not be reset to false, which means they never go through
render_pre, leading to render issues.

I believe simply restoring the value of the pre_render_done
flag should be good enough. I don't know why it is set to
true inside evas_render_mapped but I also don't want to find
out :)

See 9ac13e4aec (old)
See 87e5e70a9d (older)

Patch made with @jiin.moon
 2017-07-20 15:17:36 +09:00
Jean-Philippe Andre cb19c77558 evas: Avoid infinite loop on evas shutdown 
If an object fails to call efl_destructor() on all the parent
classes, then it may never be removed from the layer object
inlist and never would its data be deleted either (eo keeps
it safely alive).

Here's how to test: add a "return;" statement inside an object's
destructor (eg. the window class).

Fixes T5680
 2017-07-20 14:59:25 +09:00
Jean-Philippe Andre bbfdf8909b evas focus: Fix crash when shutting down with errors 
Example test: add many evas_object_ref() to a window and click
on its X to close it.
 2017-07-20 14:46:49 +09:00
Jean-Philippe Andre dccdd20335 elm: Fix a safety error message 
Happens when shutting down E
 2017-07-20 14:46:49 +09:00
Jean-Philippe Andre d6c95d1e4b evas gl: Rename secsym_ to eglsym_ 
eglDestroyImage has nothing to do with SEC...
This is a cosmetic change.
 2017-07-20 13:31:34 +09:00
Jean-Philippe Andre 0c78783045 evas gl: Check EGL version before using dlsym 
A recent commit broke texture_from_pixmap for NVIDIA EGL
(again), because eglCreateImage is a symbol in libEGL.so
but isn't in fact implemented by the driver.

That's because eglCreateImage() is exposed by libglvnd but
the underlying EGL implementation is NVIDIA and its version
is only 1.4, not 1.5 (where the API was introduced as core).

Instead of reverting the patch, it's better to cover our
bases properly and use dlsym() only if the version is right.

Note that GetProcAddress() may return garbage function
pointers for ALL functions as dynamic virtual functions may
be created on the fly by libglvnd. So it is absolutely
necessary to check the extension string as well.

See 0255f14dc2
 2017-07-20 13:31:15 +09:00
Derek Foreman ef9bd41831 gl_common: extsn is no longer unused 
Also, we should throw an error when it's NULL, since it's important
for finding symbols for extended egl/gl.
 2017-07-19 13:05:53 -05:00
Derek Foreman 0255f14dc2 gl_common: Prefer unextended eglCreateImage 
eglCreateImage is objectively better than eglCreateImageKHR - it allows
attributes large enough to hold pointer values.  We should use it when
available and only use the older extension version as fallback.

Also, eglCreateImage is core EGL functionality so don't depend on extensions
to be present to use it.  Theoretically we should be testing for
EGL version >= 1.5 but it's probably safe not to.
 2017-07-19 12:24:19 -05:00
Derek Foreman d31f5038e2 gl_common: Remove fallback hack for wayland 
This was only necessary due to bugs in the wayland_egl and gl_drm engine
that have been corrected.

Wayland has no bizarre requirements making this necessary.
 2017-07-19 12:09:33 -05:00
Derek Foreman eda81c6dff gl_drm: Defer gl symbol lookups until they're possible 
See previous commit for details.
 2017-07-19 12:02:03 -05:00
Derek Foreman c7fe083a57 wayland_egl: Defer gl symbol lookups until they're possible 
Commit 2e6587a14b adds a gl extension string to glsym_evas_gl_symbols()
to prevent using functions that are provided by extensions that aren't
available in the current gl context.

However, we can't query the extension strings until after we create an egl
context.

Split the regular symbol lookup stuff from the gl symbol lookup stuff so
we can query at the appropriate time.
 2017-07-19 12:00:07 -05:00
Derek Foreman 86377caa0e wayland_egl: de-wtf the eglGetProcAddress prototype 2017-07-19 11:44:00 -05:00
Derek Foreman 7fd66e84d9 gl_drm: de-wtf the eglGetProcAddress prototype 
This doesn't seem to serve any purpose other than rigorous proof that
typecasts can make literally anything compile.
 2017-07-19 11:43:25 -05:00
Derek Foreman 855f59da8d gl_common: Stop looking for eglCreate/DestroyImageOES 
These aren't a thing.  the GL_OES_EGL_image_base extension doesn't exist
and the GL_OES_EGL_image extension doesn't extend egl, because it's a gl
extension.

So let's stop being the only google match for these nonsense strings.
 2017-07-19 10:33:06 -05:00
Jean-Philippe Andre 7231a3295b eo: Fix deadlock due to the shared mutex 
Explicit lock / unlock of the shared mutex mixed with implicit
lock / unlock when accessing the internal Eo_Object data lead
to uncaught issues such as these.

This was found by trying to run E with gfx filters under eo_debug.
 2017-07-19 15:44:49 +09:00
Jean-Philippe Andre b98bc51968 evas: Fix cmopilation warning 
Oops I forgot to add that to the previous commit!
 2017-07-19 14:01:07 +09:00
Jean-Philippe Andre 45c8e5e983 evas: Fix support for image_data_get on snapshot 
evas_object_image_data_get() is a legacy API that I made work
with snapshot objects (evas_object_image_snapshot_set()). Some
changes in the engine broke the behaviour and this patch fixes
it.

When getting the pixels from an FBO, in read-only mode, we need
to create a temporary image (pixels surface) that contains the
copy of the pixels we get from glReadPixels. This image needs
to be deleted afterwards. It is thus stored by the image object
and freed upon _image_data_set() (good) or object deletion (bad).

FBO + read-write is not supported by this API (it is supported
through buffer_map as the filters had to use that).

Fixes T5754
 2017-07-19 13:59:42 +09:00
Jean-Philippe Andre 897d81acb1 evas engine gl: Add missing image unlock 
This is a rare error path. Unlikely and not very important as
the lock/unlock doesn't actually perform any meaningful operation.
 2017-07-19 13:59:42 +09:00
Woochan Lee 6d31f5c7fd multibuttonentry: Fix item resource clean up logic. 
Summary:
There are four cases where items are deleted.

1. Select item and push back button.
2. Delete "X" part of item.
3. Calling elm_object_item_del().
4. MBE deleted.

Previous logic is can't support for all cases.

below problems were there.

eina_list_remove() called twice.
list data free twice.

@fix

Test Plan: elementary_test -> multibuttonentry test.

Reviewers: jpeg, cedric

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5030
 2017-07-19 13:59:42 +09:00
Carsten Haitzler 1a16a4f10b emtoion gst1 - workaround gst break between 1.10 and 1.12 
so emotion was using a much older (pre 1.0) buffer map mechanism for
getting video data. a new frame map api was added to gst in 1.0 but we
didnt use it. gst broke the old buffer direct mapping for some codecs
paths between 1.10 and 1.12. since we were using a very old method/api
this broke us. this also happens to fix some vaapi issues (except
where the buffer is simply never mappable ever). so this is kind of a
fix (updating us to as more modern api) and a workaround.

@fix
 2017-07-19 11:07:47 +09:00
Marcel Hollerbach 68eba4817a eo: clarify what extensions are. 2017-07-18 17:51:38 +02:00
Marcel Hollerbach 1c9762d8ca elm_widget: do not register disabled logical nodes 
this reduces the load of useless logical trees that

ref T5753
 2017-07-18 17:51:38 +02:00
Marcel Hollerbach 92bad54778 elm_widget: eval all children if the disable property has changed 
since all children could have a new register state in the manager

fix T5753
 2017-07-18 17:51:38 +02:00
Marcel Hollerbach 8e2f5e8642 elm_widget: disable is a property across the tree 
if a widget is disabled its children are also meant to be disabled.

ref T5753
 2017-07-18 17:51:38 +02:00
Mike Blumenkrantz c5155d2fcc eldbus: support output dir in codegen 
@feature
 2017-07-18 11:34:18 -04:00
Jean-Philippe Andre f1bcd804ec elm_test: Set label as word wrap 
This exposes an elm_win sizing bug. To test (under X):
  ELM_DISABLE_EXTERNAL_MENU=1 elementary_test -to "Main Menu"

The layout is not completely wrong 100% of the time, but it is
exactly correct 0% of the time. Window sizing is our flying
spaghetti monster.
 2017-07-18 18:42:16 +09:00
Jean-Philippe Andre 521f41f536 win: Fix main menu when not in framespace 
On OSX the framespace and CSD (Client-Side Decorations) are not
supported at all... I am not able to test this case. This patch
restores the main menu functionality based on pre 1.19 themes,
where it was located inside win.edc (app content) and not in
border.edc (framespace).

Note that the initial size of a window may be wrong, eg as in
  elementary_test -to "Main Menu"

Fixes T5734 (hopefully!)
 2017-07-18 18:42:16 +09:00
Cedric BAIL 2330d4fec1 ecore_evas: make sure fn_post_render callback is called last. 
Should fix T5595.
 2017-07-17 11:51:15 -07:00
Daniel Hirt 4923945f81 Text: move Annotation type to Efl.Text.Annotate namespace 2017-07-17 17:38:28 +03:00
Daniel Hirt d5f781da2b Efl text: replace all usages of cursor handle to same type 
Changes cursor handle name from 'Efl.Text.Cursor.Cursor_Data' to
'Efl.Text.Cursor.Cursor'.
Also, replace all usages of Efl_Canvas_Text_Cursor
with Efl_Text_Cursor_Cursor as the handle for the cursor.
 2017-07-17 16:51:45 +03:00
Daniel Hirt c4ea25cbdb Evas textblock: fix legacy header 
Fix ABI changes with const qualifiers, as well as some missing docs.
 2017-07-17 16:50:31 +03:00
Daniel Hirt 22c39d4ee5 Ui internal text interactive: handle signed cursor position 
CID 1377551.
 2017-07-17 16:50:31 +03:00
Daniel Hirt e7f7636ac1 Ui text: don't send focus action to cursor on init 
It made the cursor animation start on init, even if widget wasn't
focused.
 2017-07-17 16:50:31 +03:00
Daniel Hirt 2bb0a1123e Ui text: add more examples to test 2017-07-17 16:50:31 +03:00
Daniel Hirt 02a607f360 Ui text: set default color (white) 2017-07-17 16:50:31 +03:00
Daniel Hirt bb2678d403 Canvas text: re-add support for tabs 
Somehow this was left out. Fixes tabs, so you can now use "\t" and
press the "tab" key.
 2017-07-17 16:50:31 +03:00
Daniel Hirt ba9a1b97c5 Ui text: use new api instead of 'style' property in the test 2017-07-17 16:50:31 +03:00
Andy Williams bf8a0eead2 OSX: fix version detection in build 2017-07-17 13:04:30 +01:00
Daniel Kolesa d5bca5b0cb eolian: always generate a class initializer 
Because there might be hidden C implements defined, we need to
always generate the appropriate class initializer. This does not
hurt anything as the contents would have been called automatically
by Eo anyway.

@fix T5736
 2017-07-17 11:04:29 +02:00
Jean-Philippe Andre 9dddc075d4 win: Amend previous commit about modifiers 
The code was invalid, so making it valid now. Explicitely marking
the modifiers as unused, as mentionned in the documentation as
well.

See 9baa8752a9
 2017-07-17 16:38:38 +09:00
Carsten Haitzler 9d1a8bb082 eina debug bt sig handle - fix build on osx for clockid_t 
fix #ifdefs so it should in theory build on osx 10.11.x

@fix
 2017-07-17 16:04:01 +09:00
Sungtaek Hong d545929845 edje_signal: reduce member count when deleted edje_signal_callback is found 
Summary:
 - when deleted callback is found _edje_signal_callback_move_last() is called
   in order to pack match array.
 - during _edje_signal_callback_move_last() index skips when another deleted
   callback is found, but does not reduce members_count.
 - this duplicates a remaining callback and calls the callback twice.

Test Plan:
1. add multiple edje_signal_callback by edje_object_signal_callback_add()
              which have the same source, signal, func but different data.
           2. delete first and last callback by
              edje_object_signal_callback_del/edje_object_signal_callback_del_full.
           3. emit edje_signal.
           4. observe one callback is called twice.

Reviewers: SanghyeonLee, conr2d, jpeg

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D4985
 2017-07-17 15:05:20 +09:00
Jean-Philippe Andre 9baa8752a9 win: Fix ABI compatibility for grab modifiers 
This fixes an ABI change when moving from unsigned long long
modifier mask to a simple enum. This is a fix for the release
of EFL 1.20.
 2017-07-17 14:24:30 +09:00
Jean-Philippe Andre 9c18f0d00a ecore joystick: Use const char * in API, not slstr 
The API eina_slstr_ is meant to look just like const
strings, wihch means here there could instead be an internal
struct holding the name, and the API would behave the same.

Note: This API is new in 1.20
 2017-07-17 13:53:42 +09:00
WooHyun Jung 245940c093 Revert "elm_widget: separate elm_widget_item codes from elm_widget.c" 
This reverts commit 4f8d20c826.
I'll apply this after finishing of release.
Thanks JP to give notification.
 2017-07-17 13:45:08 +09:00
WooHyun Jung 4f8d20c826 elm_widget: separate elm_widget_item codes from elm_widget.c 
This will help to focus on creating efl_ui_widget class work.
And, we need to change all the Elm_Widget_Item related logics to
factory or something else.
 2017-07-17 11:22:46 +09:00
Jean Guyomarc'h 2f9cbb3a35 evas-gl_cocoa: fix compilation 
Booo for commit 2e6587a14b.
 2017-07-16 17:26:41 +02:00
Carsten Haitzler 2e6587a14b evas gl - fix compositing/native surface with egl/gles after glvnd 
this fixes an issue that has cropped up in the past few months - only
nvidia drivers with egl/gles in x11... and compositing won't work
(native surface) and the introduction of libglvnd

it's a combination of libglvnd lying that it has symbols it can't
later find, new features to get core functions via procaddress that we
hadn't migrated to use AND use preferring core functions that libglvnd
will expose, so switching to KHR extensions by preference. we also
need to symmetrically use destroy image khr too...

oddly enough using procaddress purely for create/destroy image makes
wayland fail ... sofor now i'm taking advantage of the fact that
wayland has no extensions string passed in at the moment and still
doing dlsym... this is odd though.

@fix
 2017-07-16 15:56:02 +09:00
Carsten Haitzler 53d6486ffa efreet icon cache create bin - check realloc results and handle 
@fix
 2017-07-16 15:56:02 +09:00
Carsten Haitzler fef4c2c292 efreet cache create binary - check realloc results and handle failure 
@fix
 2017-07-16 15:56:02 +09:00
Carsten Haitzler ead5d9cefd eo lexer - handle malloc failure with longjmp 
handles possible error case nicely
 2017-07-16 15:56:02 +09:00
Carsten Haitzler ff67dd25e3 evas mesh save - use alloca for tmp strings instead of heap 
this reduces code and means we dont have to handle NULL exceptions as
alloca always "works".

@fix
 2017-07-16 15:56:02 +09:00
Andy Williams 665679bc42 elm_code: add missing selection signals 2017-07-15 21:29:48 +01:00
Mike Blumenkrantz 3d4bb3851c ecore-evas: make the window_get apis return null without errors on failure 
the normal usage of these is something like

if (!strcmp(engine, my_engine))
  win = window_get(ee);

which is a waste of effort since the window_get() functions all check
the engine interface internally
 2017-07-14 18:43:00 -04:00
Mike Blumenkrantz bc3dc78a52 eina: make tiler test compare tilers which are not equal 2017-07-14 18:43:00 -04:00
Mike Blumenkrantz 83ff889f6d eina: fix eina_tiler_equal to not always return true 
ref e3f4f4457d
broken by D996

@fix
 2017-07-14 18:43:00 -04:00
Mike Blumenkrantz 47ddbede05 eina: make tiler function params const where appropriate 
stop throwing warnings when passing const params to functions which don't
modify the params
 2017-07-14 18:43:00 -04:00
Stefan Schmidt 02bbcabd3f examples: elm_icon: remove no-op deprecated function call for icon lookup 
The function is deprecated and actually a no-op already. Better make
sure we do not promote deprecated functions in our won examples.
 2017-07-14 14:06:34 +02:00
Stefan Schmidt e2fa3acb40 tests: elm_popup: mark unused parameter as such to avoid warning 2017-07-14 12:46:33 +02:00
Amitesh Singh ffa2cd5c75 efl.ui.image.zoomable: mark setter of img_region property as eo api 
thanks to stefan for reporting.
 2017-07-14 19:38:52 +09:00