_sizing_eval is very costly on toolbar as it recalc all edje part and sends
signal to all of them. _item_theme_hook was already calling _sizing_eval
doubling the cost of adding new item.
various fixes have occurred over the years to improve proxy rendering.
as a result, this theme, which is apparently the only other user of proxy
edje parts besides deskmirror, was broken.
@fix
Summary: clang reports SIG_BLOCK_CLICKED and SIG_TIMEOUT as being
unused variables, so remove
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: clang reports passing EINA_FALSE here is being treated as an
Eo object, so pass NULL instead
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: clang reports passing EINA_FALSE here is being treated as an
Eo object, so pass NULL instead
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: clang reports ELM_APP_SERVER_VIEW_PROPS_ENTRY as being an
unused variable, so remove.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Scenario:
const char * accel = accel_get();
accel_set("gl:depth");
Now accel may not be valid anymore since the original
Eina_Stringshare might have been destroyed. So there was
no point in saving the const char * pointer. It was not valid
after the call to set(). This is a bit confusing here. Returning
char* would be clear: the caller would own the data.
too many rels and complexity to track this to a more coherent
message
probably broken since 1.0 since there are zero "noicon" toolbar
tests
@fix
fix T2782
Elm_Image rely on Evas_Image ability to rotate content. There is no
pixels manipulation involved that require an update_add here. In fact
this cause a bug where the content would disapear due to evas trying
to get some pixels data that are not where it think they are.
Summary:
In hover.edc, hoversel dismiss animations are defined,
but it doesn't work at all. (Hover is removed before animation)
This patch makes hoversel remove its hover after dismiss animation.
@fix
Test Plan: elementary_test hoversel
Reviewers: Hermet, cedric
Reviewed By: cedric
Subscribers: woohyun
Differential Revision: https://phab.enlightenment.org/D3070
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary: As ecore_evas_wayland_move ends up updating the location of
the ecore_wl_window, we should be calling move with the proper
geometry as this ends up updating the internal ecore_wl_window
geometry (which in turn sends to xdg_surface_set_window_geometry).
This is part of a fix where xdg_surface_set_window_geometry was
getting sent inproper values.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
This reverts commit 1094fb77a0ee23cbe1e8b15783e406a8d93b7fd4.
Feature is freezed for new released version.
This patch must updated after release finished.
Toolbar creates a more_item when shrink mode is
ELM_TOOLBAR_SHRINK_EXPAND.
If select mode is ELM_OBJECT_SELECT_MODE_ALWAYS and there is no item
appended, then toolbar sets a selection on a newly created item.
In this case, sd->more_item is referenced before the new more_item is
assigned to sd->more_item.
@fix
Summary:
Add elm_gengrid_item_all_contents_unset API for reusing contents in application side.
User can unset all contents or re-use their contents for increase scrolling performance.
genlist already support this API.
@feature
Test Plan: Need to add test in elementary_test.
Reviewers: raster, singh.amitesh, cedric
Subscribers: woohyun, Hermet, seoz
Differential Revision: https://phab.enlightenment.org/D3066
previous config ignored elm theme if ithas cursors. this was just
wrong, so switch default back to using theme and update configs
accordingly etc. this is houw it should have worked.
Summary: Unsure whether these are left-over, or are going to be
implemented in the near future...but for now, #if 0 out these 2
functions as they are currently unused.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Allow to add some extra contextul information about accessibility objects
which can be used by Assistive Technology to provide better user experience.
API is still marked as beta.
@feature
org.a11y.atspi.Collection interface allows to perform fast search
queries on accessibility objects tree.
Due to lack of specification of collection interface this implementation
base on gnome project implementation from https://git.gnome.org/browse/at-spi2-atk/.
@feature
This actually doesn't work for coverity, I guess we just need to mark it
as false-positive, as it will never be null.
This reverts commit 178e7e6ac9419742d1bbe583fd252fc6536e5649.
These screenshots are used in the documentation but we never made sure that we
have them actually. This resulted in our docs missing image links.
Thanks to Jean Rene Dawin for reporting it at the Enlightenment Developer Day.
Moved the data fetching to be after the tests. This doesn't really
matter and is mostly there to silence coverity. Coverity was complaining
about "it" being dereferenced before the null check (implicit in
EO_OBJ), so reordering it will fix it.
CID 1040000
Summary:
elm_hover_dismiss() doesn't hide hover directly, but sends signal only.
It can be translated that "dismiss" do not hide hover only, but handles
some works. (EDC program, callbacks etc.)
However, "dismiss" sends signals after hide hover itself, so following
edje signals are ignored. (Hover cannot be seen already!)
This patch makes hover dismiss delayed while handling edje signal.
@fix
Test Plan: elementary_test hover2
Reviewers: Hermet, cedric
Reviewed By: cedric
Subscribers: woohyun
Differential Revision: https://phab.enlightenment.org/D3068
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Issue: If text set is NULL to naviframe, crash happens in strcmp
Soln: Check for text if NULL, before passing to strcmp
@fix
Test Plan:
//Pass the text as NULL
elm_object_part_text_set(nf, "title", NULL);
Reviewers: Hermet, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3052
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Hoversel can be used like dropdown or pulldown menu.
In that case, changing hoversel label into selected item lable can be
considered as common usage of hoversel.
This API automatizes changing label.
Reviewers: SanghyeonLee, Hermet, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2963
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Some modifications for hoversel scrollability are applied.
For example,
The logic for generating scroller is changed. (newly added during activation)
If hoversel's contents are larger than hover,they will be resized to fit hover.
If hoversel is moved (by window rotation etc.), scroller will be resized.
Reduandant code are removed from popup for scrollability.
Test Plan:
You can see the sample for scrollable hoversel in second one
of "elementary_test hoversel".
Reviewers: Hermet, SanghyeonLee, cedric
Reviewed By: cedric
Subscribers: godlytalias, Hermet
Differential Revision: https://phab.enlightenment.org/D2926
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>