enlightenment/enlightenment
enlightenment
/
enlightenment
10
9
Fork 12
Code Issues 24 Pull Requests 2 Projects Releases Wiki Activity

Remove const on variable which will be modified. 

Remove double looping.


SVN revision: 25003
This commit is contained in:
sebastid 2006-08-21 16:00:43 +00:00 committed by sebastid
parent 7b26db9067
commit 3a7b3efa8f
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/bin/e_desklock.c
View File

@ -67,7 +67,7 @@ static int _e_desklock_check_auth();
#ifdef HAVE_PAM #ifdef HAVE_PAM
static int _e_desklock_cb_exit(void *data, int type, void *event); static int _e_desklock_cb_exit(void *data, int type, void *event);
static int _desklock_auth(const char *passwd); static int _desklock_auth(char *passwd);
static int _desklock_pam_init(E_Desklock_Auth *da); static int _desklock_pam_init(E_Desklock_Auth *da);
static int _desklock_auth_pam_conv(int num_msg, const struct pam_message **msg, struct pam_response **resp, void *appdata_ptr); static int _desklock_auth_pam_conv(int num_msg, const struct pam_message **msg, struct pam_response **resp, void *appdata_ptr);
static char *_desklock_auth_get_current_user(void); static char *_desklock_auth_get_current_user(void);
@ -569,7 +569,7 @@ _e_desklock_cb_exit(void *data, int type, void *event)
} }
static int static int
_desklock_auth(const char *passwd) _desklock_auth(char *passwd)
{ {
if ((_e_desklock_child_pid = fork())) if ((_e_desklock_child_pid = fork()))
{ {
@ -599,12 +599,7 @@ _desklock_auth(const char *passwd)
strncpy(da.user, current_user, PATH_MAX); strncpy(da.user, current_user, PATH_MAX);
strncpy(da.passwd, passwd, PATH_MAX); strncpy(da.passwd, passwd, PATH_MAX);
/* security - null out passwd string once we are done with it */ /* security - null out passwd string once we are done with it */
for (p = (char *)passwd; *p; p++); for (p = passwd; *p; p++) *p = 0;
while (p >= passwd)
{
*p = 0;
p--;
}
da.pam.handle = NULL; da.pam.handle = NULL;
da.pam.conv.conv = NULL; da.pam.conv.conv = NULL;
da.pam.conv.appdata_ptr = NULL; da.pam.conv.appdata_ptr = NULL;