Carsten Haitzler
320ec625b0
wtf? thats like double-free land.. why strdupa at all? nuts! remove
...
strdupa's and make code consistent with neighbouring code.
SVN revision: 81006
2012-12-15 01:56:35 +00:00
Mike Blumenkrantz
679cae4fad
patch from maxime villard fixing strdupa definition and moving a variable to local scope
...
SVN revision: 80990
2012-12-14 21:09:21 +00:00
Mike Blumenkrantz
9d68775725
fix pointer warping on desk change + revert focus
...
ticket #1994
SVN revision: 80942
2012-12-14 13:47:53 +00:00
Mike Blumenkrantz
381425f538
improper E_FREE usage
...
SVN revision: 80939
2012-12-14 13:04:32 +00:00
Mike Blumenkrantz
acdc863299
fix magic fail when deleting desklock popup: popup already hidden, so don't need to delay delete
...
SVN revision: 80938
2012-12-14 13:04:16 +00:00
Mike Blumenkrantz
8b698680df
reorder efm dnd finished cb to prevent crash when accessing possibly deleted icon
...
SVN revision: 80933
2012-12-14 11:29:50 +00:00
Mike Blumenkrantz
1d7d7def2a
update widget min size when changing label text
...
SVN revision: 80932
2012-12-14 11:29:19 +00:00
Mike Blumenkrantz
8347b33d9c
more leaks gone in trash code that isn't used
...
SVN revision: 80924
2012-12-14 09:19:50 +00:00
Mike Blumenkrantz
799e6b5a5e
it seems that this variable in e_exec does not actually need to be strdup()ed, and thus does not need to leak...
...
SVN revision: 80923
2012-12-14 09:13:07 +00:00
Mike Blumenkrantz
31b66a272e
improper E_FREE usage
...
SVN revision: 80922
2012-12-14 09:07:57 +00:00
Mike Blumenkrantz
53c7cc643f
small leak in config registry item add
...
SVN revision: 80920
2012-12-14 09:04:23 +00:00
Mike Blumenkrantz
f4440456f7
actually we can just strdupa here instead
...
SVN revision: 80899
2012-12-13 21:28:54 +00:00
Mike Blumenkrantz
925645792e
grr meant strncpy!
...
SVN revision: 80898
2012-12-13 21:25:29 +00:00
Mike Blumenkrantz
0d579688ae
add object_repack function for frametable
...
SVN revision: 80890
2012-12-13 20:12:32 +00:00
Mike Blumenkrantz
6ae01a1b09
unbreak e_intl.h #ifdefs
...
SVN revision: 80889
2012-12-13 19:12:37 +00:00
Mike Blumenkrantz
006a014982
gadcon positioning leak
...
SVN revision: 80850
2012-12-13 13:41:35 +00:00
Mike Blumenkrantz
44442a8e45
reorder some stuff in static_grab to be more successful
...
SVN revision: 80842
2012-12-13 13:11:21 +00:00
Mike Blumenkrantz
3d9ac54d21
even more leaks in randr11 refresh rates fail
...
SVN revision: 80841
2012-12-13 13:01:57 +00:00
Mike Blumenkrantz
4e23dd680e
fix leak in randr11 refresh rate failure
...
SVN revision: 80840
2012-12-13 12:59:43 +00:00
Mike Blumenkrantz
7fb5b16ee4
void functions don't return values
...
SVN revision: 80839
2012-12-13 12:55:59 +00:00
Mike Blumenkrantz
3111aa6120
another pedantic free for the analyzers
...
SVN revision: 80838
2012-12-13 12:53:28 +00:00
Mike Blumenkrantz
251ee5a5d6
another pedantic and probably unneeded null check
...
SVN revision: 80837
2012-12-13 12:52:13 +00:00
Mike Blumenkrantz
3a82001c8b
fix leak in client menu generation
...
SVN revision: 80836
2012-12-13 12:50:58 +00:00
Mike Blumenkrantz
6388913775
another pedantic and probably unneeded null check
...
SVN revision: 80835
2012-12-13 12:47:34 +00:00
Mike Blumenkrantz
6d0a11236f
fix possible buffer overflow in module config dialog
...
SVN revision: 80832
2012-12-13 12:03:41 +00:00
Mike Blumenkrantz
8f1f764359
don't leak on iterate in intl path searching
...
SVN revision: 80831
2012-12-13 11:58:06 +00:00
Mike Blumenkrantz
1358b91d2b
pedantic free() here to shut up analyzers
...
SVN revision: 80829
2012-12-13 11:56:22 +00:00
Mike Blumenkrantz
b51d7c6eda
fix leak in import dialog
...
SVN revision: 80828
2012-12-13 11:55:10 +00:00
Mike Blumenkrantz
da5caff466
inlist_count is not O(1)
...
SVN revision: 80827
2012-12-13 11:52:38 +00:00
Mike Blumenkrantz
9b4ec19471
fix guaranteed crash in efm_op...rustyBSD check this if you happen to read
...
SVN revision: 80826
2012-12-13 11:49:07 +00:00
Mike Blumenkrantz
4a2837830b
another efm_op leak, also wrong E_FREE usage
...
SVN revision: 80824
2012-12-13 11:34:09 +00:00
Mike Blumenkrantz
e0926014a1
fix possible NULL deref in efm_op
...
SVN revision: 80823
2012-12-13 11:30:40 +00:00
Mike Blumenkrantz
c637b2874f
fix small leak in efm_op
...
SVN revision: 80822
2012-12-13 11:27:47 +00:00
Mike Blumenkrantz
b48d65af00
fix lots of stupidity in efm daemon trash code that isn't even enabled
...
SVN revision: 80821
2012-12-13 11:18:26 +00:00
Mike Blumenkrantz
0743fd1ea2
fix efm daemon leak in every command made
...
SVN revision: 80820
2012-12-13 11:13:17 +00:00
Mike Blumenkrantz
b2b336ed7d
fix leak in efm daemon when reordering files
...
SVN revision: 80819
2012-12-13 11:10:01 +00:00
Mike Blumenkrantz
67b24415d6
fix efm leak when symlinking out of an ASK DND action
...
SVN revision: 80818
2012-12-13 11:07:06 +00:00
Mike Blumenkrantz
52ca7afc9a
fix leak in e_exec when DISPLAY is too long
...
SVN revision: 80817
2012-12-13 11:03:13 +00:00
Mike Blumenkrantz
59aa402a46
fix wrong E_FREE usage
...
SVN revision: 80816
2012-12-13 11:02:36 +00:00
Mike Blumenkrantz
c0910ad0d4
only create config registry item once its category has been found to prevent dangling registry items
...
SVN revision: 80815
2012-12-13 10:56:59 +00:00
Mike Blumenkrantz
f81c0f3d93
fix uninitialized border geom in SMART/EXPAND maximizes
...
SVN revision: 80814
2012-12-13 10:48:39 +00:00
Mike Blumenkrantz
7877c41869
handle NULL more gracefully in e_bindings_signal_handle
...
SVN revision: 80813
2012-12-13 10:38:24 +00:00
Mike Blumenkrantz
e3c0e6bbcc
shut up e_exehist
...
SVN revision: 80812
2012-12-13 10:37:14 +00:00
Mike Blumenkrantz
9cc54e74c7
formatting
...
SVN revision: 80804
2012-12-13 09:46:11 +00:00
Carsten Haitzler
dae7d45236
add small detail to error printf on e_sys.
...
SVN revision: 80799
2012-12-13 08:32:37 +00:00
Mike Blumenkrantz
6999eb8ad1
add new event for when managers regrab keys
...
SVN revision: 80774
2012-12-12 19:21:31 +00:00
Mike Blumenkrantz
55ae26fcd3
prevent config dialogs from crashing if create/free data functions are not defined
...
SVN revision: 80772
2012-12-12 16:54:48 +00:00
Mike Blumenkrantz
8077e1aafb
always unpopulate shelf before changing orientation so systray doesn't ibtch
...
SVN revision: 80768
2012-12-12 14:56:17 +00:00
Mike Blumenkrantz
86aa333211
disable currently-set orientation for shelf on orientation change menu
...
SVN revision: 80766
2012-12-12 14:44:10 +00:00
Mike Blumenkrantz
dbce2eaed3
show files again when an overwrite dialog pops up
...
ticket #1974
SVN revision: 80762
2012-12-12 13:50:43 +00:00
Mike Blumenkrantz
a8143270cd
always re-set xmodmap after changing kbd layout group
...
SVN revision: 80761
2012-12-12 13:31:18 +00:00
Mike Blumenkrantz
15df42143e
add some null checks before monitor deletion to account for people still affected by the frenchman's laziness
...
SVN revision: 80757
2012-12-12 12:34:49 +00:00
Carsten Haitzler
ddbf106d6e
ensur emensu dont go futzing about whileu use them... allocate
...
POTENTIAL space for submenus later. :)
SVN revision: 80751
2012-12-12 11:06:40 +00:00
Mike Blumenkrantz
d0eff6a730
fix initial name string for New Directory action
...
SVN revision: 80748
2012-12-12 10:12:29 +00:00
Mike Blumenkrantz
a93a4d56f0
New Directory action in efm now renames inline like New File action
...
SVN revision: 80747
2012-12-12 10:08:04 +00:00
Carsten Haitzler
353b588347
10k files.... ok! :)
...
oh and fix a segv people will get when queue process timeout is hit...
and reduce timeout to 0.01 sec :)
SVN revision: 80746
2012-12-12 09:59:53 +00:00
Carsten Haitzler
da9336c9dd
fix menu box packing for submenu itms so when set up in specific
...
orners with a pre callback... its packed WITH fill
SVN revision: 80661
2012-12-11 14:37:17 +00:00
Mike Blumenkrantz
90ce8a3f24
fix buffer length for deskenv_init
...
SVN revision: 80660
2012-12-11 14:31:12 +00:00
Mike Blumenkrantz
b341cd4689
unbreak mouse move events when autohiding shelves are present
...
ticket #1961
ticket #zmikeisdumb
SVN revision: 80659
2012-12-11 14:20:53 +00:00
Mike Blumenkrantz
ab1a9e5e80
efm no longer eats pager dnd events
...
SVN revision: 80646
2012-12-11 11:14:25 +00:00
Carsten Haitzler
54faad046f
dont focus noedit entries! :)
...
SVN revision: 80645
2012-12-11 10:54:31 +00:00
Carsten Haitzler
36523293d2
fix read-only status of file name in desktop editor
...
SVN revision: 80644
2012-12-11 10:50:54 +00:00
Mike Blumenkrantz
00cac2c0a4
add function for determining whether modules are still loading
...
SVN revision: 80640
2012-12-11 10:30:06 +00:00
Mike Blumenkrantz
f287acc53c
warn--
...
SVN revision: 80639
2012-12-11 10:29:48 +00:00
Mike Blumenkrantz
c4115615f0
s/creat/open/
...
SVN revision: 80630
2012-12-11 08:44:05 +00:00
Mike Blumenkrantz
370ba1b3fe
okay, after considering the words of a certain frenchman we no longer write anything to new files
...
SVN revision: 80629
2012-12-11 07:50:06 +00:00
Mike Blumenkrantz
e61159e49e
write \n to new files instead of ""
...
ticket #1947
SVN revision: 80608
2012-12-10 14:16:16 +00:00
Mike Blumenkrantz
c30e42e9ec
fix fsel path changing and entry setting
...
SVN revision: 80606
2012-12-10 13:06:04 +00:00
Mike Blumenkrantz
fd9abc1da8
e now properly sets "hicolor" as the icon theme when no theme is set (FDO standard: http://icon-theme.freedesktop.org/wiki/HicolorTheme )
...
SVN revision: 80601
2012-12-10 11:48:20 +00:00
Mike Blumenkrantz
f9c87ab214
fix efm crash when using XDS drags, also fix XDS drags to work again
...
SVN revision: 80599
2012-12-10 11:41:40 +00:00
Daniel Juyung Seo
206acb6eb6
e e_icon.c: also return false on null icon.
...
SVN revision: 80598
2012-12-10 11:33:45 +00:00
Mike Blumenkrantz
06897e960b
fix dnd source visibility when dragging into a link drop target
...
ticket #1953
SVN revision: 80586
2012-12-10 08:59:36 +00:00
Mike Blumenkrantz
74b145c3d0
hide scrollbars by default in scrollframe
...
ticket #1954
SVN revision: 80584
2012-12-10 08:29:53 +00:00
Mike Blumenkrantz
9605a4fb85
resizable dialogs are now compatible with the maximize action and maximize options in border menu
...
ticket #1950
SVN revision: 80581
2012-12-10 08:20:52 +00:00
José Roberto de Souza
463617699c
From: José Roberto de Souza <zehortigoza@profusion.mobi>
...
Subject: [E-devel] [PATCH] e: Return EINA_FALSE if icon path was not
found
SVN revision: 80567
2012-12-10 06:58:58 +00:00
Massimo Maiurana
96fac26f2f
Mark some strings for translation. (patch from Igor Murzov)
...
SVN revision: 80551
2012-12-09 14:39:30 +00:00
Carsten Haitzler
f0c9f5121c
lots of buglet-fixing. this does:
...
1. make idle fade timer work at all (dodnt work before)
2. fixes backlight status on e restart
3. fixes setting bl level on start
4. improves the compositor fade in/out effect by ALSO fading backlight
in and out... oh so much smoother now
5. fixes label in ui to be seconds, not minutes.
6. in order to make this all work - it adds a special screensaver
event inside of e that the screensaver subsystem generates based on
the real x one.
SVN revision: 80538
2012-12-09 06:27:42 +00:00
Carsten Haitzler
1b4cfff4bf
avoid mouse down cb feeding another mouse down cb.. to itself.. until
...
the stack blows.. in slider.
SVN revision: 80510
2012-12-08 05:16:33 +00:00
Sebastian Dransfeld
7903db5d3d
e: efreet event can be null
...
And add code to normal startup with a TODO
SVN revision: 80500
2012-12-07 20:27:27 +00:00
Massimo Maiurana
8b38245df1
two more duplicate message with different case and also two with slash and hyphen
...
SVN revision: 80481
2012-12-07 18:15:14 +00:00
Mike Blumenkrantz
82b4efa5e4
in the event that an ecore_exe is not passed with the exit cb, check the pid list
...
SVN revision: 80450
2012-12-07 13:28:17 +00:00
Mike Blumenkrantz
41fbbfe2da
when fullscreening a window from a maximized state, prevent overwriting of previously saved window geometry
...
ticket #1940
SVN revision: 80416
2012-12-07 08:05:17 +00:00
Mike Blumenkrantz
b3ae9ae78a
always run deskenv init on startup, even during restart; gnome-settings-daemon is smart enough not to run if already running
...
ticket #1939
SVN revision: 80415
2012-12-07 07:54:35 +00:00
Cedric BAIL
a97fb13810
e: forgotten move to PT_GETSIGINGO.
...
SVN revision: 80408
2012-12-07 02:49:40 +00:00
Carsten Haitzler
d1581b714f
group ptrs together.
...
SVN revision: 80407
2012-12-07 02:48:30 +00:00
Boris Faure
5bf8a6cab3
e: fix windows being uniconified on desk show
...
SVN revision: 80392
2012-12-06 21:22:34 +00:00
Massimo Maiurana
b2d8ca25e5
this is to avoid duplicate messages different only for case of initial letters, so translation files has less messages
...
SVN revision: 80374
2012-12-06 17:44:36 +00:00
Mike Blumenkrantz
3c78f7dba2
fix ratio resizing when increasing window size
...
ticket #1935
SVN revision: 80359
2012-12-06 13:24:27 +00:00
Mike Blumenkrantz
3a87b43a19
formatting
...
SVN revision: 80356
2012-12-06 12:48:14 +00:00
Mike Blumenkrantz
f233e0d59d
fix shelf autohiding when the mouse goes directly from a shelf into the window of a shitty toolkit which blocks X mouse movement events
...
ticket #1884
SVN revision: 80343
2012-12-06 11:03:32 +00:00
Mike Blumenkrantz
955c24344a
fix shelf autohide calculations for non-zero zones
...
ticket #1884
SVN revision: 80334
2012-12-06 10:27:15 +00:00
Mike Blumenkrantz
ce1add259c
probably fix crash in ticket #1931
...
SVN revision: 80333
2012-12-06 09:59:14 +00:00
Mike Blumenkrantz
2b64147c16
double clicking efm icons with single click activation enabled no longer opens directories twice
...
ticket #1933
SVN revision: 80331
2012-12-06 09:52:06 +00:00
Mike Blumenkrantz
7972371393
efm menu replace/start functions now properly pass icon info
...
SVN revision: 80327
2012-12-06 09:36:35 +00:00
Mike Blumenkrantz
4aa85b3c2c
add timer to show icons after a drag to fix XDirectSave dnd
...
ticket #1917
SVN revision: 80324
2012-12-06 09:16:15 +00:00
Mike Blumenkrantz
654b7ee554
use event handler list macro
...
SVN revision: 80323
2012-12-06 09:04:18 +00:00
Mike Blumenkrantz
11b244883d
fix weird dnd crash
...
SVN revision: 80321
2012-12-06 09:01:32 +00:00
Mike Blumenkrantz
d6521d8cad
fix pointer slide focus setting
...
SVN revision: 80307
2012-12-06 08:01:42 +00:00
Mike Blumenkrantz
503d7305db
Dear all,
...
As I've said before, I'm attached a patch for minor bugs in the e17 again.
Please take a look at attached patch.
01. missing E_FREE(wev) if zone is null
File: src/bin/e_actions.c: 1467
Function: ACT_FN_GO_EDGE macro function
null check of zone and wev, it would be better to separate them.
02. dead code
File: src/bin/e_configure.c: 338
Function: _e_configure_efreet_desktop_update
03. array buf might be overwritten by "buf[i] = '\0'"
File: src/bin/e_eap_editor.c: 412
Function: _e_desktop_edit_user_local_desktop_filename_generate
04. missing null check
File: src/bin/e_fm.c
Function: e_fm2_icon_get: 2196
It would be better to check ic->info.file in e_fm2_icon_get
before passing to _e_fm2_file_is_edje because it doesn't check
null pointer.
05. array 'path' might be overwritten by "path[i + 1] = XXX"
File: src/bin/e_fm.c: 4299
Function: _e_fm2_uri_parse
06. missing null check
File: src/bin/e_fm_device.c: 468
Function: e_fm2_device_mount_find
If the null pointer is passed to e_fm2_device_mount_find,
then it attempt to compare string using strncmp without null
check.
e.g., e_fm2_path_set
-> real_path = _e_fm2_dev_path_map: this function could return null.
-> sd->realpath = real_path;
-> e_fm2_device_mount_find(sd->realpath)
07. missing free(fstrip)
File: src/bin/e_import_config_dialog.c: 34
Function: _import_edj_gen
08. missing _module_free(cfm)
File: src/bin/e_int_config_modules.c: 530
Function: _load_modules
09. missing free(class) in for loop
File: src/bin/e_int_menus.c: 1187
Function: _e_int_menus_clients_add_by_class
10. missing free(roots)
File: src/bin/e_main.c: 1646
Function: _e_main_screens_init
Actually only e_win_init function could return 0.
But I've added free to other codes for the consistency.
11. missing null check of 'es->cfg'
File: src/bin/e_shelf.c: 2583
Function: _e_shelf_bindings_add
'es->cfg' might be null. please look at e_shelf_position_calc.
12. no ect->category check before comparing string values
File: src/bin/e_theme.c: 387
Function: e_theme_config_remove
I'm not sure, but inner if block checks ect->category before
deleting a string.
13. missing E_FREE(wcb) in while loop
File: src/bin/e_widget_ilist.c: 146
Function: _queue_timer
14. dereferencing freed pointer 'entry'
File: src/modules/quickaccess/e_mod_quickaccess.c: 583
Function: _e_qa_event_border_remove_cb
15. missing E_FREE(trov)
File: src/modules/tiling/e_mod_tiling.c: 3106
Function: _do_transition_overlay
Thanks & Regards,
Gwanglim
SVN revision: 80231
2012-12-05 11:13:09 +00:00
Carsten Haitzler
84b97ad9cc
warn--... and actually build. :)
...
SVN revision: 80229
2012-12-05 10:56:18 +00:00
Mike Blumenkrantz
f66c6c6f2c
unbreak compile with 1.7 branch
...
SVN revision: 80226
2012-12-05 09:59:02 +00:00
Gwanglim Lee
499b88748b
From: Gwanglim Lee <gl77.lee@samsung.com>
...
Subject: Re: Re: Re: [E-devel] [RFC] Virtual desktop window profile
I've attached 4th patch. May the 4th be with you.
ecore patch has been merged with efl and all files are based on r80123.
Thanks & Regards,
Gwanglim
------- Original Message -------
Sender : Daniel Juyung Seo<seojuyung2@gmail.com>
Date : 2012-12-04 01:55 (GMT+09:00)
Title : Re: Re: [E-devel] [RFC] Virtual desktop window profile
It looks ok to me.
Sorry but can you re-generate the patch according to the recent ecore
merge to efl single tree?
Daniel Juyung Seo (SeoZ)
On Thu, Nov 29, 2012 at 12:29 AM, Gwanglim Lee <gl77.lee@samsung.com>
wrote:
Dear Raster and Daniel Juyung Seo,
I've attached 3rd patches and test_config according to your reviews.
These are based on r79782.
[elementary & ecore]
1. "profile,set" -> "profile,changed" - done
2. spaces after EINA_LIST_FOREACH - done
3. variable type - keep
4. author - done
5. removing deprecated marking in patch - done
6. add elm_win_available_profiles_get to test_config for the debugging
purpose - done
7. check whether a given profile is present in an available profiles.
otherwise window profile will be one of the item
in available profiles. - newly added thing to the elm_win
8. merge with EO - done. :(
Any comments would be appreciated.
SVN revision: 80216
2012-12-05 06:51:16 +00:00
Carsten Haitzler
b000cf12d6
only srand once.
...
SVN revision: 80209
2012-12-05 06:21:41 +00:00
Cedric BAIL
d8b8ba3be4
e: fix build on Solaris 11.
...
Patch by Robert David <robert.david.public@gmail.com>.
SVN revision: 80204
2012-12-05 02:23:00 +00:00
Mike Blumenkrantz
17c9b707d5
fix focus_revert_on_hide_or_close option to work correctly with mouse focus, also fix annoying pointer warp focus bug which erroneously focused windows while moving the pointer for pointer_slide warps on new windows
...
SVN revision: 80174
2012-12-04 15:11:53 +00:00
Mike Blumenkrantz
3bd8f4dd81
also fix lost window pointer warping
...
SVN revision: 80173
2012-12-04 14:58:48 +00:00
Mike Blumenkrantz
86a42a2e73
add functions for locking border focus
...
SVN revision: 80172
2012-12-04 14:57:35 +00:00
Mike Blumenkrantz
17ef5ee535
fix e_exec crash
...
SVN revision: 80171
2012-12-04 14:50:16 +00:00
Mike Blumenkrantz
5980697b20
delete from hash by key
...
SVN revision: 80170
2012-12-04 14:49:49 +00:00
Mike Blumenkrantz
dd3f97f742
scrollframe scrollbars are NOT visible by default
...
ticket #1846
SVN revision: 80143
2012-12-04 11:20:35 +00:00
Mike Blumenkrantz
5a60f9dad8
further clamp menus to zone size
...
ticket #1895
SVN revision: 80138
2012-12-04 09:08:19 +00:00
Mike Blumenkrantz
0ceb3289f0
fix e_entry cnp to work better with non-container grab windows
...
SVN revision: 80094
2012-12-03 19:04:27 +00:00
Mike Blumenkrantz
23d0765d1a
add function to return current key grab xwin
...
SVN revision: 80093
2012-12-03 19:03:49 +00:00
Mike Blumenkrantz
d48545db45
add function to disable entry menu
...
SVN revision: 80091
2012-12-03 18:31:14 +00:00
Mike Blumenkrantz
d444728457
all dialogs EXCEPT module config dialog are not resizable. this is just too frustrating
...
SVN revision: 80075
2012-12-03 14:59:39 +00:00
Carsten Haitzler
d268bb2cc3
fix infintie delfn loop waiting to happen.
...
SVN revision: 80048
2012-12-03 11:40:23 +00:00
Cedric BAIL
d6b04df109
e: when valgrind is on, no need to ptrace anything.
...
SVN revision: 80042
2012-12-03 10:43:14 +00:00
Mike Blumenkrantz
68e6b07cd7
all dialogs are no longer resizable
...
SVN revision: 80032
2012-12-03 09:24:12 +00:00
Mike Blumenkrantz
dc5775e628
set no_resizable state by default on dialogs
...
SVN revision: 80029
2012-12-03 09:15:47 +00:00
Mike Blumenkrantz
f8efeed3e8
fix in-place directory opening in efm: statinfo resolves link targets now, so only call "selected" if link target is not a directory
...
ticket #1863
SVN revision: 80026
2012-12-03 08:57:15 +00:00
Mike Blumenkrantz
362531b082
Dear all,
...
I'm attaching a patch for some minor bugs in the e17.
Please take a look at attached patch.
01. missing E_FREE(inst)
File: src/bin/e_exec.c: 347
Function: _e_exec_cb_exec
02. missing null check
File: src/bin/e_fm.c: 10173
Function: _e_fm_error_dialog
I'm not sure, but all other codes always check the return
value of e_fm2_op_registry_entry_get except here.
03. missing free(slave)
File: src/bin/e_fm_ipc.c: 804
Function: _e_fm_ipc_slave_run
04. eina_list_remove after free
File: src/bin/e_fm/e_fm_ipc.c :1325
Function: _e_fm_ipc_cb_fop_trash_idler
05. invalid check for _udisks_del, it might be _udisks_chg.
File: src/bin/e_fm/e_fm_main_udisks.c : 162
Function: _e_fm_main_udisks_test
06. uninitialized gx and gy values
File: src/bin/e_gadcon_popup.c: 172
Function: _e_gadcon_popup_position
These could be changed in e_gadcon_client_geometry_get
if gcc->o_base is null.
07. unnecessary code 'evas = e_win_evas_get(dia->win)'
File: src/bin/e_import_config_dialog.c: 456
Function: e_import_config_dialog_show
08. missing free(sizes)
src/bin/e_randr_11_serialization.c: 136
Function: _11_try_restore_configuration()
09. unnecessary variable output_info
File: src/bin/e_randr_12.c: 560
Function: _output_property_change_event_cb
10. eina_list_remove after free
File: src/bin/e_randr_12_serialization.c : 357
Function: _12_serialized_setup_update
11. no check of the return value of symlink.
File: src/bin/e_widget_fsel.c: 84
Function: _e_wid_fsel_favorites_add
12. no evr->var check before comparing string values
File: src/modules/conf_applications/e_int_config_defapps.c: 432
Function: _basic_apply
13. missing error message or check return value of edje_file_group_exists
File: src/modules/conf_theme/e_int_config_theme.c: 333
Function: _open_test_cb
Anyway, I've added e_util_dialog_show if failed. Is it okay?
14. missing index range check
File: src/modules/gadman/e_mod_config.c: 153
Function: _cb_config
It could read negative array index, because return value of
e_widget_ilist_selected_get might be negative.
BR,
Gwanglim
SVN revision: 80020
2012-12-03 07:54:07 +00:00
Carsten Haitzler
63286be95d
lets make e_alert noto also be bag with valgrind eh?
...
SVN revision: 79998
2012-12-03 00:46:34 +00:00
Carsten Haitzler
8fa7ba94bb
doing configure checks for arpa/inet.h and so on is all fine and
...
great.. but if the src file htis was intended for doesn't include e.h
so it include config.h... then its kind of pointless isn't it? :)
SVN revision: 79997
2012-12-03 00:27:52 +00:00
Mike Blumenkrantz
97a7e3affb
cast to void in delete macro
...
SVN revision: 79986
2012-12-02 19:27:25 +00:00
Vincent Torri
688aa066a1
E17: define htonl correctly
...
SVN revision: 79960
2012-12-01 07:19:18 +00:00
Mike Blumenkrantz
011dfdccf5
only block fsel updating if path is already set
...
SVN revision: 79951
2012-11-30 21:26:24 +00:00
Sebastian Dransfeld
5d64abb461
e: omit path in .desktop file if in xdg dir
...
SVN revision: 79950
2012-11-30 21:25:30 +00:00
Mike Blumenkrantz
21c5355c18
remove menu fixme
...
SVN revision: 79946
2012-11-30 20:04:11 +00:00
Mike Blumenkrantz
1eda0a3417
some text fixes from thomasg
...
SVN revision: 79910
2012-11-30 15:39:17 +00:00
Mike Blumenkrantz
c6a9c34e7f
giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes
...
SVN revision: 79908
2012-11-30 14:38:34 +00:00
Mike Blumenkrantz
49f4670d7b
cached menus now listen to efreet cache update events
...
ticket #1888
SVN revision: 79883
2012-11-30 11:50:21 +00:00
Mike Blumenkrantz
fbc12f2e3f
only save gcc during edit end if the gcc has a config
...
SVN revision: 79875
2012-11-30 08:50:12 +00:00
Christopher Michael
9b465c8a95
Add ECORE_X_CURSOR_EXCHANGE to e_pointer for a 'rotate' cursor.
...
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 79867
2012-11-30 07:26:19 +00:00
Mike Blumenkrantz
fd95d45c9b
okay, only try the gadcon config gcc unref if it's a custom gadcon that's editing
...
SVN revision: 79840
2012-11-29 16:02:33 +00:00
Mike Blumenkrantz
2a6d8d9f74
unref drag gcc when deleting gcc from gc config dialog to ensure it is deleted properly
...
SVN revision: 79837
2012-11-29 15:22:12 +00:00
Mike Blumenkrantz
6600e453ec
delete gcc drag object if it exists when gcc is deleted
...
SVN revision: 79836
2012-11-29 15:19:24 +00:00
Mike Blumenkrantz
f371980da8
entry leak--
...
SVN revision: 79835
2012-11-29 15:06:32 +00:00
Mike Blumenkrantz
3f8c09d6a0
fix continual leak in efm file names
...
SVN revision: 79834
2012-11-29 15:02:00 +00:00
Mike Blumenkrantz
c21b0240ba
don't show gcc drag object when dragging desktop icons on same zone
...
SVN revision: 79833
2012-11-29 13:42:42 +00:00
Mike Blumenkrantz
d7a5385b2b
only run a gadcon populate event after module init end
...
SVN revision: 79829
2012-11-29 12:15:50 +00:00
Mike Blumenkrantz
6d4150fcad
increase shelf show timeout after module init end
...
SVN revision: 79828
2012-11-29 12:15:11 +00:00
Mike Blumenkrantz
25853a0c2a
fix possible null deref crash when deleting gadcon client config
...
SVN revision: 79827
2012-11-29 11:48:34 +00:00
Mike Blumenkrantz
ab52c7a2ee
unselecting all ilist items will no longer fail to unselect all ilist items
...
SVN revision: 79826
2012-11-29 11:25:02 +00:00
Mike Blumenkrantz
af38ddf0a6
delete any invalid gadcon clients for custom gadcons since we don't validate as much here
...
SVN revision: 79823
2012-11-29 10:09:28 +00:00
Mike Blumenkrantz
8db2b8bb69
disable "internal_fileman" border setting since there's no theme which supports it and all it does is break border config
...
ticket #1830
SVN revision: 79820
2012-11-29 08:57:20 +00:00
Mike Blumenkrantz
eb2ae4dfb2
improve and homogenize system action dialog texts
...
SVN revision: 79817
2012-11-29 07:20:17 +00:00
Mike Blumenkrantz
1af4e65b56
fix shelf crash when attempting to animate an autohide during screen rotation
...
SVN revision: 79804
2012-11-29 05:23:52 +00:00
Mike Blumenkrantz
fff13bc94a
fix gadget popup positioning bug for top/left shelves
...
SVN revision: 79801
2012-11-29 04:31:23 +00:00
Mike Blumenkrantz
bd19ea1330
fix max menu size clamping
...
ticket #1691
SVN revision: 79800
2012-11-29 03:02:16 +00:00
Carsten Haitzler
ef76974ffc
lets not break dnd onto dirs.. within the same efm view.
...
SVN revision: 79763
2012-11-28 04:11:33 +00:00
Carsten Haitzler
022e768010
fix segv in efm! dnd 2 files into another dir - yay!
...
SVN revision: 79762
2012-11-28 03:51:24 +00:00
Tom Hacohen
81efa66d66
E entry: Use stringshare instead of strdup.
...
The string is usually shared already and this saves us the allocation.
SVN revision: 79753
2012-11-27 18:14:03 +00:00
Tom Hacohen
cf7f76c329
E entry: Fix password mode toggle.
...
It's just a straightforward fix. Some cleanup is needed there to make
everything nicer, but that's not important for the time being as it'll be
replaced with elm_entry "soon" anyway.
SVN revision: 79750
2012-11-27 15:50:53 +00:00
Carsten Haitzler
b1b5f7c09d
less offensive import dialog layout. :)
...
SVN revision: 79742
2012-11-27 10:45:09 +00:00
Cedric BAIL
85b27ab7e3
e: detect when sysactions.conf doesn't let us run gdb.
...
SVN revision: 79731
2012-11-27 03:48:05 +00:00
Mike Blumenkrantz
2ac82d5a0c
gadcon popups will no longer pop over the gadget if popping for a shelf in autohide mode
...
SVN revision: 79719
2012-11-26 14:10:00 +00:00
Mike Blumenkrantz
c244e1f9b7
module config dialog now listens for module status update events and adjusts module status accordingly
...
ticket #1816
SVN revision: 79693
2012-11-26 10:58:58 +00:00
Mike Blumenkrantz
0f46bd2d98
module update event module name is now stringshared
...
SVN revision: 79691
2012-11-26 10:30:00 +00:00
Mike Blumenkrantz
d8edcec5f1
add function for cloning an e_order
...
SVN revision: 79683
2012-11-26 09:36:11 +00:00
Mike Blumenkrantz
4d92a1de3c
patch from Deon Thomas fixing some lost window behavior bugs
...
ticket #1821
SVN revision: 79681
2012-11-26 09:09:16 +00:00
Sebastian Dransfeld
4de7b95f4a
e: honor XDG_DESKTOP_DIR
...
SVN revision: 79678
2012-11-26 08:45:03 +00:00
Sebastian Dransfeld
f5c645b793
e: keep code in same scope
...
SVN revision: 79677
2012-11-26 08:44:47 +00:00
Mike Blumenkrantz
011b6c7b02
NULL check gadcon dnd enter events so we don't crash on efm drag operations
...
ticket #1820
SVN revision: 79676
2012-11-26 08:29:22 +00:00
Mike Blumenkrantz
8d30916e09
set flag in fsel for when preview is a directory so we can grab the right path
...
ticket #1815
SVN revision: 79675
2012-11-26 08:16:25 +00:00
Carsten Haitzler
92d53b87a5
and remvoe debugging.
...
SVN revision: 79670
2012-11-26 06:40:35 +00:00
Carsten Haitzler
7277ce21b1
fix segv where menus are not actually popped down on deletion of gcc.
...
SVN revision: 79669
2012-11-26 06:38:43 +00:00
Carsten Haitzler
108b985e87
valgrind complain-- :
...
SVN revision: 79665
2012-11-26 03:49:55 +00:00
Carsten Haitzler
f119b1969b
use readonly not disabled for entires in icccm/netwm dialog
...
SVN revision: 79661
2012-11-25 23:56:52 +00:00
Carsten Haitzler
2697a5f84d
delay fdo re-loads/hunts by 0.1 sec after any resize event for
...
smoother anim.
SVN revision: 79654
2012-11-25 12:30:09 +00:00
Carsten Haitzler
4ff82885e8
delay e_win and e_popup deletes to avoid bad mem accesses from
...
objects/callbacks that free evases deep inside a callback tree. :)
SVN revision: 79622
2012-11-24 04:22:21 +00:00
Carsten Haitzler
6460d80767
ensire filepreview video doesnt overflow when in fsel ANd maintains
...
aspect based on video content.
SVN revision: 79621
2012-11-24 02:32:59 +00:00
Carsten Haitzler
758168f6f0
and keep updating number too when set form code.
...
SVN revision: 79620
2012-11-24 02:05:54 +00:00
Carsten Haitzler
7243e0c665
and keep t in too. oops. last second edit.
...
SVN revision: 79618
2012-11-24 01:41:52 +00:00
Carsten Haitzler
a537c5c741
stop video preview stuttering!
...
SVN revision: 79617
2012-11-24 01:40:35 +00:00
Carsten Haitzler
cff3bfb61b
oooh fix some infinite loops in entry .. and oh so much make color
...
specture.selector/sliders WORK again... properly.
SVN revision: 79557
2012-11-23 11:24:39 +00:00
Carsten Haitzler
4d880b56ec
remove some infintie loops in entry where is resizes to the same size
...
and sets the same3 text again and again.
SVN revision: 79556
2012-11-23 04:41:47 +00:00
Carsten Haitzler
5d7474c5e5
split about text -> the translatable bit and the license bit (always
...
english).
SVN revision: 79539
2012-11-22 11:57:22 +00:00
Carsten Haitzler
6c466cd6f3
stderr for the run cmd so we can debug and stuff...
...
SVN revision: 79529
2012-11-22 01:27:03 +00:00
Carsten Haitzler
e9a383f40c
printf--
...
SVN revision: 79489
2012-11-21 04:08:58 +00:00
Carsten Haitzler
2efe87a0e9
fix up single click and click to rename + event sticking with mouse
...
events.
SVN revision: 79488
2012-11-21 04:06:23 +00:00
Sebastian Dransfeld
5986618d0a
e: remove cruft
...
SVN revision: 79480
2012-11-20 21:18:30 +00:00
Carsten Haitzler
fe99dc3e26
about legal stuff + contact info.
...
SVN revision: 79476
2012-11-20 15:37:50 +00:00
Carsten Haitzler
e87dc77227
ensure the about dialog has a copy of the license to make sure legally
...
we've given the info needed in an accessible place to the user.
SVN revision: 79475
2012-11-20 15:32:27 +00:00
Carsten Haitzler
7e8768ad5d
add new about theme signals/text capabilities as per email - change 1
...
string - "Theme" -> "About Theme"
SVN revision: 79461
2012-11-20 01:41:33 +00:00
Vincent Torri
ba53c29261
E17: update alloca detection
...
SVN revision: 79427
2012-11-18 13:42:48 +00:00
Sebastian Dransfeld
e54ec613c4
e: gravity on lock win
...
SVN revision: 79412
2012-11-17 20:58:36 +00:00
Sebastian Dransfeld
5865d2d675
e: lock parent, not window
...
SVN revision: 79411
2012-11-17 20:39:29 +00:00
Mike Blumenkrantz
36af3ea6bb
only post-adjust menu position for non-submenus
...
ticket #1802
SVN revision: 79403
2012-11-16 22:09:48 +00:00
Daniel Juyung Seo
f185eabf92
e e_entry.c: 1. Used EINA_TRUE/FALSE for Eina_Bool. 2. Removed unused variable 'have_preedit'
...
SVN revision: 79379
2012-11-16 11:46:03 +00:00
Sebastian Dransfeld
30350d0f76
e: edit == !noedit && !edit == noedit
...
SVN revision: 79373
2012-11-16 10:20:31 +00:00
Carsten Haitzler
1da5608d7b
entry - read only mode (noedit) should be supported and use it from
...
file preview too...
SVN revision: 79368
2012-11-16 09:08:14 +00:00
Sebastian Dransfeld
6004ba2eaa
e: prevent events on modal parent
...
This fixes trapping of events on modal parents. We can't change event
mask, as that changes the event _we_ receive, not the client. We must
add and input window above the parent which traps the events.
SVN revision: 79367
2012-11-16 09:02:24 +00:00
Tom Hacohen
5d840bab5b
E entry: force disable thumbscroll.
...
We need that disabled, as currently mouse grabbing breaks if that's not
set. That's what you get when you have scrolling and selection in the same
place. We can just use selection for scrolling or fix the issue.
The fix would probably require using the ON_SCROLL flag instead of
the ON_HOLD and actually handle it correctly.
SVN revision: 79359
2012-11-16 06:55:40 +00:00
Mike Blumenkrantz
26b38be179
fix crash in menus
...
SVN revision: 79347
2012-11-15 15:01:19 +00:00
Mike Blumenkrantz
c984977c20
prevent thread crash on startup; efreet does some non-threadsafe stuff, so we need to not be generating multiple menus simultaneously on init
...
SVN revision: 79344
2012-11-15 13:20:34 +00:00
Carsten Haitzler
9cceb74058
fix text mouse pointer stickiness in entry.
...
SVN revision: 79342
2012-11-15 12:40:27 +00:00
Mike McCormack
b0f8f6c8bf
e: Fix warning unused return code warning
...
e_widget_filepreview.c:817:9: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result [-Wunused-result]
Signed-off-by: Mike McCormack <mikem@atratus.org>
SVN revision: 79337
2012-11-15 11:14:31 +00:00
Mike Blumenkrantz
3b8856aa3c
unbreak tab completion in efm typebufs
...
SVN revision: 79331
2012-11-15 09:59:51 +00:00
Mike Blumenkrantz
9e4184cee1
thread-create favorite apps menu on startup since this will probably be a commonly used menu
...
SVN revision: 79328
2012-11-15 09:36:21 +00:00
Mike Blumenkrantz
6d3694d4a9
improve menu positioning for menus which have not yet generated items at the time that they are made visible
...
SVN revision: 79326
2012-11-15 09:20:28 +00:00