Commit Graph

576 Commits

Author SHA1 Message Date
Carsten Haitzler 97977f9f41 efm - call e fwin key cb's after e_fm cb's and delay fwin del
this mens fwin's key handling should always be called after efm's own
internal handling and dispatching. also the final deletion will also
now be deferred in a job to "after all of this".

fix segv on ctrl+w
2020-11-27 09:28:57 +00:00
Carsten Haitzler 7062c0fa4c efm - make some comment notes for exec verify 2020-05-30 21:56:29 +01:00
Riccardo Calixte 01fd3da2a3 tree-wide: get rid of trailing whitespace
Remove trailing whitespaces

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11841
2020-05-19 12:09:13 +02:00
Elyes HAOUAS bead80ca23 tree-wide: get rid of trailing whitespace (part 9)
Remove trailing whitespaces

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11829
2020-05-14 14:17:13 +02:00
Elyes HAOUAS 153f479d3f tree-wide: fix typos all over the place
Fix some typos

Differential Revision: https://phab.enlightenment.org/D11778
2020-05-14 12:04:51 +02:00
Carsten Haitzler 785219f3c6 efm nav menu - fix to not count filtered out and dotfiles in count 2020-04-24 11:48:29 +01:00
Carsten Haitzler 91bc151878 fileman - handle another error case to not pass null
fix CID 1425226
2020-04-19 02:41:59 +01:00
Carsten Haitzler 948d064561 fileman - handle rare path where dev may not be found
fix CID 1425230 1425226
2020-04-19 00:32:38 +01:00
Carsten Haitzler bc28793796 efm - fix eio usage to notuse efl apis in a thread
the heavy func is in a theread and thus needs to only stick to things
that will be thread safe...
2020-04-17 20:36:22 +01:00
Simon Tischer 6c1a623e01 settings -> window: settings window align optimizations
settings ->  file manager window align optimizations

Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11681
2020-04-11 10:45:12 -04:00
Carsten Haitzler ac4323b453 fileman module - fix warning about constness of ptrs
noisy warning so we can see real bugs. no real bug fixed here.
2020-01-15 11:33:55 +00:00
Carsten Haitzler dda50e8d87 shot + efm - add efm action to show dir so if same dir is open it shows
and if there is not the same dir upa  new win is created and shown.
... shot uses this to avoid shot dir duplication.
2020-01-09 00:26:45 +00:00
Carsten Haitzler b4cfada8e8 module and config - remove pointless config vars that have no use
we dont need to delay module loading anymore so remove allof this -
priority too shouldn't be necessary as well and was just a workaround.
this remvoes all of that removing some e module api's and module
struct members as well as some global config fields. it also ensures
all config files are up to date as well.
2019-09-10 17:58:30 +01:00
Carsten Haitzler b7d8916701 efm: ensure progress popup is visible with min calc and hint set
we never calc'd min size and set min size hint - fix that and set it...
@fix
2019-08-15 09:55:12 +01:00
maxerba afc1f44ac7 Updating french translation 2019-07-08 21:15:00 +02:00
Carsten Haitzler e912e0a087 efm - fix always new window mode to put dir inline from favorites select
when u select something from the favorites on the left it should
always affect the content of the current window, not open a new one -
this would happen if u switch mode to open new windows from the default.

this fixes that.
2019-05-08 15:09:27 +01:00
Carsten Haitzler d8e92184b8 fix casts to use void ptr to avoid warning that isnt important
the callback uses a subset of the arguments (taking advantage that our
first arg is void * data) so it can re-use across callback types. void
* makes this case not complain as oposed to casint to a specific fn
sig type from another.
2019-01-12 01:51:43 +00:00
Carsten Haitzler 01575d590e e mime cfg - skip work when string is empty - fixes warning 2019-01-12 01:51:43 +00:00
Carsten Haitzler 21dd3b1aba efm - reorder destroy to toolbar can access fm obj still on free
less ERRs
2019-01-09 18:39:16 +00:00
Carsten Haitzler e493891151 fileman - don't add cbs to a fwin window that doesnt exist
less ERR noise.
2019-01-09 18:23:19 +00:00
Alastair Poole 8ee7cf979f fileman: remove temporary fix.
Efreet should now properly unmap the correct address.
The unmap was causing a SIGBUS. Removing this bogosity.
Won't affect e22.
2018-06-01 14:37:44 +01:00
Carsten Haitzler a1994536a4 move from data_home/apps/defaults.list to config_home/mimeapps.list
this moves to the newer mimeapps.list file in ~/.config from the older
defaults.list. it also provides a migration (copy file ovr if target
doesnt exist on e startup).

this fixes T6784

@fix
2018-03-20 20:36:56 +09:00
Al Poole bff91e0885 fileman: fix use after free and workaround issues on FreeBSD.
Reading from tmp is causing SIGBUS issues on FreeBSD, the easiest
and cleanest way round this atm is to avoid parsing /tmp. In the
process found another bug which occurred on Linux also which was
use after free.
2018-03-01 17:52:56 +00:00
Ross Vandegrift 629f7d41c8 clean up .desktop files and misc typos
Summary:
Drop deprecated Encoding key from desktop files

The Encoding key is no longer required, all desktop files are assumed to
be UTF-8 encoded.  See details at:
https://standards.freedesktop.org/desktop-entry-spec/1.1/apc.html

Fix various typos and misspellings

lintian, Debian's package checker, uses strings to check for common typos
in compiled binaries.  This change fixes the ones it identified in 0.22.1.

Reviewers: zmike!

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5585
2018-01-04 09:57:52 -05:00
Mike Blumenkrantz 99db9e2557 more E_BITFIELD conversions 2017-11-08 09:22:24 -05:00
Mike Blumenkrantz 0bd73b5a54 use client geometry for fileman popup positioning instead of win object geometry
window objects don't return accurate geometry under wayland

fix T3842
2017-08-25 14:47:10 -04:00
Marcel Hollerbach 29901d67b2 meson: use file instead of doing the relative path by hand
a reason for doing that is that you can just pack together targets into
a array and pass them to our helper, and the helper will just handle
them, so even module with eldbus codegen etc is now supported.

This also means that we are just passing the src object directly into
the shared_module call, which means the user of our helper can just pack
everything he needs into the src var and the helper does not need to
know about it.
2017-08-08 18:38:37 +02:00
Mike Blumenkrantz 7a3876ffc9 add and use new event for zone useful geometry changing
many times it's useful to have an event for actual zone geometry change
vs useful geomtry change, so split this out and use the right handler where appropriate
2017-08-04 16:05:15 -04:00
Carsten Haitzler 650d7aa82c mod filemane - remove ancient instance theme path code not used...
this also removes warnings. too many anyway
2017-08-04 14:56:45 +09:00
Carsten Haitzler 69290dd7f4 e module build - make build files far more generic and far smaller
now mdoule build files that fllow one pattern (the most common by far)
all JUSt list their souce files and nothing else. this really cuts
down on build size/complexity.

there are other patterns too (no icons at all) that i'll do next, then
we're down into "weird" land where i'll have to think of some more
interesting ways to deal with this.
2017-07-29 08:55:36 +09:00
Mike Blumenkrantz e8dc71cd48 meson. 2017-07-20 17:18:33 -04:00
Mike Blumenkrantz b7e8e886e9 do not generate module.desktop files
the purpose of this is to allow variable substitutions, but no desktop
files do this so it's a waste of build time for no reason
2017-07-14 18:40:50 -04:00
Carsten Haitzler 39752e55ec e fileman config - fix definite alignment bug with cast char to int ptr
we're casting ptrs to char fields to int * which is actually wrong as
we break alignment guarantees. fix.
2017-02-12 16:25:35 +09:00
Derek Foreman 4cf555f36e Replace all timer_reset with timer_loop_reset
Another sed bomb - didn't occur to me first time around to
check for this.  Cleans up more clock_gettime calls.
2017-02-06 15:59:25 -06:00
Derek Foreman 73aecd73ab Replace all timer_add with timer_loop_add
So yeah, I've literally used sed to replace every occurrence of
ecore_time_add() with ecore_timer_loop_add() because I'm reasonably
confident that no part of E has a legitimate need for timer based on the
exact current time.

It would be really nice if I'm not wrong. :)

The reason for this is the incredible spew of clock_gettime() calls I'm
seeing on an ARM system (that should have a vdso for gettime, but...)
This can amount to thousands of system calls per second.

 #YOLO
2017-02-03 15:52:28 -06:00
Carsten Haitzler 3903d44666 e - BLOODY BUILD AGAIN - DAMN FLOAT WARNINGS...
i swear ... all of this shit over a warning that CAUSED more bugs than
it eveer fixed? sersiously...

ARGH!
2017-01-07 14:05:17 +09:00
Mike Blumenkrantz aeb8851c9d resolve efm float-equal warnings
Reviewed-by: Derek Foreman <derekf@osg.samsung.com>
2017-01-06 12:57:33 -05:00
Al Poole bfe02d2303 efm - fix popup if file is a fifo
this fixes T4815

@fix
2016-11-02 11:00:40 +09:00
Carsten Haitzler fd8d41a2a6 e fm - fix popup to not crash by referring to possibly deleted data
fm icon info is transient because fm icons are transient. files may
get deleted, added or removed on the fly. keeping icon info around for
things like the popup is asking for tyrouble and does create  trouble.

so look it up each time based on filename string. safe!

this fixes T4716 and fixes T4798 (they are the same bug basically).
2016-10-31 18:23:08 +09:00
Al Poole 382fe30688 fwin: prevent segv when the vaarg abi messup with unused parameter.
Quite a hack overall, but if you don't need those parameter, just put
nothing and it will work.

@fix T4112

Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
2016-07-15 09:17:44 -07:00
Mike Blumenkrantz 768252740b don't revert focus to desktop fileman during compositor grab
grabs indicate an action is already occurring and focus shouldn't be altered
2016-05-03 20:27:03 -04:00
Mike Blumenkrantz eb58e2ca70 remove eldbus init/shutdown calls from the codebase
this is handled by e_msgbus
2016-03-11 17:19:32 -05:00
Mike Blumenkrantz c5ff37e56e use strbufs instead of strcat in fwin navbars
CIDs 1039794, 1039795, 1039796
2016-02-29 07:55:37 -05:00
Mike Blumenkrantz 6d45baa510 do not shortcut access of Efreet_Desktop->x hash in fileman
this subverts thread safety and also (now) avoids return data validation

fix T3096
2016-01-25 11:29:55 -05:00
Carsten Haitzler 255d227ac8 e - efm - rate limit dbus requests to open dirs or files to avoid dos
in a wayland wold we dont want to trust clients on the other side of a
dbus connection - so rate limit what you can do with efm dbus requests

@fix
2015-11-24 22:07:53 +09:00
Mike Blumenkrantz d659b86478 remove fwin popup size hint change callback on win deletion
this callback also crashes if called during delete
2015-11-20 09:16:21 -05:00
Mike Blumenkrantz b2706afe06 ensure fwin efm delete callback does not trigger crash
if this is called during fwin delete, dereferencing the passed data
will result in a crash
2015-11-20 09:09:38 -05:00
Mike Blumenkrantz 6aa2342b7e decode .desktop link and directory uris in fileman menus
fix T1922
2015-09-21 16:16:00 -04:00
Mike Blumenkrantz 1b2cceafbb redo fileman menus to only scan the first 100 items found
this was meant to be a quick way to navigate directories, not a fully
operational filemanager in a menu

fix T2462
2015-08-19 15:03:47 -04:00
Mike Blumenkrantz d2a9596753 use evas object callbacks for fwin mouse in/out, don't use ecore-x handlers in wayland
improve compatibility with wayland compositors
2015-07-06 14:23:54 -04:00