Commit Graph

43 Commits

Author SHA1 Message Date
Elyes HAOUAS 28080ccc04 tree-wide: get rid of trailing whitespace (last part)
Remove trailing whitespaces

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11832
2020-05-14 14:17:19 +02:00
Elyes HAOUAS 4d51984286 tree-wide: get rid of trailing whitespace (part 11)
Remove trailing whitespaces

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11831
2020-05-14 14:17:17 +02:00
Carsten Haitzler 745fbf0909 wireless - fully init all fields in struct to fix warn 2020-01-15 19:06:24 +01:00
Carsten Haitzler 58af9a7d8c wireless - explicit cast as types have same vals by design 2020-01-15 19:06:24 +01:00
Carsten Haitzler 2b0735da58 connman - set var to defined value - less warnings 2019-08-06 21:01:26 +01:00
Carsten Haitzler b03c0739db wireless mod - fix out of bound type array accesses
coverity pointed this out. certainly 1403948 is definitely possible if
no geometry matches succeed.

fix CID 1403948
fix CID 1403944
fix CID 1403928
2019-08-06 17:00:38 +01:00
maxerba e131745fb7 Updating french and italian translations 2019-06-21 19:32:32 +02:00
Stephen 'Okra' Houston 18f9c8eb23 Wireless: Fix wireless gadget settings to work with updated gadget/menu callback methodology. 2019-01-23 20:57:15 -06:00
Carsten Haitzler e4339f4819 bryce - improve usability from code and user by having std right menu
now right click on any gagdte in bryce and they ALL have a menu that
allows removal of the gagdte bar or the gadget as well as access to
gadget settings AND the ability for gadgets to extendthis menu like
lunhcer does per icon. now it's standard behavior everywhere which is
much easier to use and discover. it also removes code from every
gadget to do their own "button 3" handling as its handled centrally
making the code in gadgets simpler.

this is part of my effort to improve usability (mostly discoverability
and accessibility of settings/features).

also  long press left mouse gets u gadget right click menu

this has to move many modules/gadgets actions to mouse up instead of
mouse down so the bryce has a chance to trap the events first and set
hold flags. but now long press for 0.5 sec and bryce menu come sup
(with left mouse .. so touch friendly).

in addition move context menu hanbdling to e_gadget instead of in
bryce and in e_gadget. a context callback is called so different
systems can still do different things. this should probably change to
always pop up a mnenu and simple call populate callbacks for site
owner specific content.

all in all it makes the new gagdtes more consistent, easier to use
(without a right mouse button), doesn't need special action bindings
etc. etc.
2018-10-11 16:25:10 +01:00
Ross Vandegrift 629f7d41c8 clean up .desktop files and misc typos
Summary:
Drop deprecated Encoding key from desktop files

The Encoding key is no longer required, all desktop files are assumed to
be UTF-8 encoded.  See details at:
https://standards.freedesktop.org/desktop-entry-spec/1.1/apc.html

Fix various typos and misspellings

lintian, Debian's package checker, uses strings to check for common typos
in compiled binaries.  This change fixes the ones it identified in 0.22.1.

Reviewers: zmike!

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5585
2018-01-04 09:57:52 -05:00
Mike Blumenkrantz 99db9e2557 more E_BITFIELD conversions 2017-11-08 09:22:24 -05:00
Mike Blumenkrantz 59fa0e418d use E_BITFIELD define for bitfield struct members
on release builds this will be a bitfield, on devel builds it will make
bools a normal unsigned char for easier debugging
2017-11-07 10:39:56 -05:00
Mike Blumenkrantz 50fc7d1276 always hide wireless non-wired icons in gadget if wired connection exists
the most common use case when using a wired connection is to not also be
using a wireless connection
2017-09-12 13:21:04 -04:00
Mike Blumenkrantz 3506f550c7 only show options for hiding non-active wireless services in gadgets 2017-09-08 15:52:49 -04:00
Mike Blumenkrantz ca10560705 refresh wireless gadgets upon toggling hide for services types 2017-09-08 15:52:49 -04:00
Mike Blumenkrantz 2b7bfe657c add options for hiding service types in wireless gadget
fix T5975
2017-09-08 14:53:52 -04:00
Mike Blumenkrantz ef3ee4b258 further improve wireless gadget popup sizing
ref 55f4a37492
2017-09-06 14:31:00 -04:00
Mike Blumenkrantz 55f4a37492 redo wireless gadget network list popup to use a table
sizehints.jpg
2017-09-01 13:40:11 -04:00
Mike Blumenkrantz c31cb51499 replace <br> with <ps/> for all text 2017-08-21 10:16:35 -04:00
Marcel Hollerbach 29901d67b2 meson: use file instead of doing the relative path by hand
a reason for doing that is that you can just pack together targets into
a array and pass them to our helper, and the helper will just handle
them, so even module with eldbus codegen etc is now supported.

This also means that we are just passing the src object directly into
the shared_module call, which means the user of our helper can just pack
everything he needs into the src var and the helper does not need to
know about it.
2017-08-08 18:38:37 +02:00
Carsten Haitzler a70b683ffd wireless module - dont segv e if connman daemon restarts
so i get a new service of type WIRELESS_SERVICE_TYPE_NONE that's going
to suck when accessing arrays by type like wireless does like
array[cs->type] ... so check type value and if its invalid kill off
the cs as we can't do much useful with it. this fixes an actual segv e
gets if you restart the connamn daemon while e runs.
2017-07-29 08:55:36 +09:00
Carsten Haitzler 69290dd7f4 e module build - make build files far more generic and far smaller
now mdoule build files that fllow one pattern (the most common by far)
all JUSt list their souce files and nothing else. this really cuts
down on build size/complexity.

there are other patterns too (no icons at all) that i'll do next, then
we're down into "weird" land where i'll have to think of some more
interesting ways to deal with this.
2017-07-29 08:55:36 +09:00
Carsten Haitzler 84bf48b3ed module build - clean up and fix meson install of pretty much all modules
so we';re missing installing desktop files. edj icon files, wizard
data files in the wrong place, and much more. this also cleans up the
module meson build of pretty much all modules and make their build
files cimple and consistent so it's far easier to re-use things from
one module to the next. we should aim for simplicity, consistency
between as much as possible so we can refactor and turn into maybe
functions later. imho that starts with consistency though. until i can
see all the common patterns clearly, i don't want to write functions
yet. it's easier to see if all the files are consistently using the
same vars and formatting etc. etc. etc.

but either way the installation needs fixing so it installs all files
in the right places with the right permissions etc. etc. etc.

this doesn't fix all module build files bt all the ones i found that
were broken installs and they use what i think is a cleaner/simpler
template, BUT there is far too much copy & pastage here... far too
much.i need to find a cleaner way to automate this.
2017-07-27 14:29:30 +09:00
Mike Blumenkrantz e8dc71cd48 meson. 2017-07-20 17:18:33 -04:00
Mike Blumenkrantz b7e8e886e9 do not generate module.desktop files
the purpose of this is to allow variable substitutions, but no desktop
files do this so it's a waste of build time for no reason
2017-07-14 18:40:50 -04:00
Stephen Houston 28da1ff339 Nothing to see here. debug-- 2017-07-06 21:12:53 -05:00
Stephen 'Okra' Houston bac93b1bb5 Wireless Gadget: Make the network list popup and right click popup work correctly.
This fixes an issue where layering was off for the popup network list and when the right click settings window would not open.
2017-07-06 16:29:19 -05:00
Mike Blumenkrantz cfc538ca55 remove all unnecessary efl version checks
the version of efl required by configure is already higher than these checks
2017-02-24 14:15:38 -05:00
Stephen 'Okra' Houston 9344c828c6 Wireless: Don't autoclose left click popup in order to be on the same page with other gadgets. 2017-02-06 13:38:50 -06:00
Stephen 'Okra' Houston 483a978e83 Enlightenment: Wireless gadget - place the ctxpopup after the size hints are set, not before 2017-01-09 13:46:43 -06:00
Cedric Bail 689441781a connman: avoid random memory walk in case dbus data aren't provided by connman. 2016-11-21 12:46:59 -08:00
Mike Blumenkrantz 989675f310 force min size on wireless popup during show
box+list inside a ctxpopup may result in an unreliable min size at the time
of show, so force the size wanted at this time in order to avoid positioning
errors
2016-10-25 11:30:23 -04:00
Mike Blumenkrantz 9d63a1db3e do not show wireless gadget popups if desklock is active
this gadget may be allowed on lockscreen, but configuration should be disabled
2016-09-28 10:43:00 -04:00
Mike Blumenkrantz 90fcc55f1e add e_util_open(), unify all callers of enlightenment_open
ref adbba1042b
2016-09-27 11:19:00 -04:00
Mike Blumenkrantz 287e9637a8 delete previous wireless popup when activating editor from connection list
fixes case where newly-created popup would be deleted upon show, breaking
interactions
2016-08-19 12:15:31 -04:00
Mike Blumenkrantz 9a9e892825 clean up some string leaks in wireless gadget popups 2016-08-19 12:15:31 -04:00
maxerba a1407ca224 Updating italian translation 2016-08-18 12:12:03 +02:00
Mike Blumenkrantz a93aadfe01 replace wireless connection error #warning with notification
this needs a more robust infrastructure than I'm prepared to write at
the moment, but errors do need to be seen
2016-06-20 12:37:28 -04:00
Carsten Haitzler 90a4ad88b7 e - wireless module - remove horrible memcpy with offsetof magic
while it technically wuld work, this memcpy here is fragile and the
moment some struct members changed it'd fall apart and have fields all
misaligned etc. in fact using offsetof means it might over-copy a bit
extra due to alignment of the connect_cb vs method in Connman_Service.
so manually aissgne the fields in the func instead to be far safer.

if anything this should become a sub-struct with a type that can then
be properly copied even if things change.

@fix
2016-04-13 20:28:27 +09:00
Mike Blumenkrantz 48fbfa2908 reduce efl version req to 1.17.0, make new gadget stuff 1.7.99+ at runtime 2016-04-11 15:15:51 -04:00
Mike Blumenkrantz 0b69c40d92 resolve harmless coverity reports in wireless module
CIDs 1352825, 1352826, 1352827
2016-03-10 11:21:11 -05:00
Mike Blumenkrantz c95f3347ae flatten return of strcmp to bool value
CIDs 1352821, 1352822
2016-03-10 11:08:48 -05:00
Mike Blumenkrantz 24fe43d735 add new wireless module/gadget
this is the successor to the connman module/gadget. it does not use
or depend on econnman.
2016-03-04 14:23:44 -05:00