Commit Graph

7651 Commits

Author SHA1 Message Date
Lucas De Marchi 2aca12cc2e e/notification: do not use null_strings_replace()
It would be very weird and error-prone on clients to have code like
this:

E_Notification_Notify n;
memset(n, 0, sizeof(*n));
n.app_name = "bla";
e_notification_client_send(...);
eina_stringshare_del(n.icon.icon);
eina_stringshare_del(...);
...

Instead of doing this, replace NULL by "" in the only place it's not
allowed: while sending the D-Bus message.



SVN revision: 82120
2013-01-03 22:08:15 +00:00
José Roberto de Souza 84550effc5 e: Add client api to notifications
Patch by: José Roberto de Souza  <zehortigoza@profusion.mobi>



SVN revision: 82119
2013-01-03 22:08:10 +00:00
Lucas De Marchi 8ec8c40bb7 e/notification: improve consistency of the API
Rename some functions and fields to have a better API. Also sanitize the
method and signal tables.



SVN revision: 82117
2013-01-03 22:08:00 +00:00
José Roberto de Souza ab185d46c3 e: Add notification API
Patch by: José Roberto de Souza  <zehortigoza@profusion.mobi>



SVN revision: 82116
2013-01-03 22:07:56 +00:00
Lucas De Marchi 3c6d7db5a3 e: Make a few renames on new dbusmenu API
typos:
 toogle -> toggle
 itens -> items

API consistency:
 MENU_ITEM_TOGGLE -> E_DBUSMENU_ITEM_TOGGLE
 E_DBus_Menu_Item_Event -> E_DBusMenu_Item_Event
 	(I don't want to bikeshed on this, but we need to choose one of the
	 possible names, and keep consistent with the rest of the API)

A few var renames: It's E_DBusMenu_Ctx, so let's name the var ctx
instead of menu_data. internal_ctx is no more meaninful than ctx, so
rename it as well.



SVN revision: 82092
2013-01-03 18:16:16 +00:00
José Roberto de Souza 805d32b831 e: Add dbusmenu API
Patch by: José Roberto de Souza  <zehortigoza@profusion.mobi>



SVN revision: 82091
2013-01-03 18:16:09 +00:00
José Roberto de Souza d46ef364fd e: Replace printf by eina log
Patch by: José Roberto de Souza  <zehortigoza@profusion.mobi>



SVN revision: 82088
2013-01-03 18:15:53 +00:00
Mike Blumenkrantz 9e207e6f92 conf2
SVN revision: 82078
2013-01-03 14:47:21 +00:00
Carsten Haitzler 625cafc28c fix xsettings to notneed x headers directly... much better! :)
SVN revision: 82058
2013-01-03 11:21:24 +00:00
Cedric BAIL 92ab0600ee e: fix restart of E17 after manually monitoring it.
SVN revision: 82023
2013-01-03 00:32:48 +00:00
José Roberto de Souza 53f67fa86b e/music-control: Add gadget GUI
Patch by: José Roberto de Souza  <zehortigoza@profusion.mobi>



SVN revision: 81989
2013-01-02 13:19:49 +00:00
Lucas De Marchi 9e1b995c56 e: small fixes to port of e_fm udisk to edbus
- no need for calling edbus_message_error_get() if we are not getting
   the error message
 - rename confusing vars:
 	* A dict is this complete type: "a{sv}", i.e. an array with
	  key-values pairs (though the value could very well be 's', or
	  'u' or another basic type)
	* An entry (or dict_entry, or de) is *the* key-value pair.
 - Use eina_stringshare_replace when possible



SVN revision: 81986
2013-01-02 13:16:24 +00:00
José Roberto de Souza 5e4352e9b3 e: e_fm udisk ported to edbus
Patch by: José Roberto de Souza  <zehortigoza@profusion.mobi>



SVN revision: 81985
2013-01-02 13:16:19 +00:00
José Roberto de Souza 5655cbf8af e: Remove Hal backend from e_fm
Since Hal is deprecated since 2008 it's a bad idea wasting time porting
it to edbus.

Patch by: José Roberto de Souza  <zehortigoza@profusion.mobi>



SVN revision: 81984
2013-01-02 13:16:14 +00:00
Lucas De Marchi b8dbc2fa0e e: small fixes to e_msgbus conversion to edbus
SVN revision: 81981
2013-01-02 13:15:58 +00:00
José Roberto de Souza a84987cd60 e: Port e_msgbus to edbus
Patch by: José Roberto de Souza  <zehortigoza@profusion.mobi>



SVN revision: 81980
2013-01-02 13:15:53 +00:00
José Roberto de Souza 5b714e3146 e: Port fileman to edbus
Patch by: José Roberto de Souza  <zehortigoza@profusion.mobi>



SVN revision: 81977
2013-01-02 13:14:54 +00:00
José Roberto de Souza 71fa105fd8 e: Port battery module to upower and edbus
Patch by: José Roberto de Souza  <zehortigoza@profusion.mobi>



SVN revision: 81975
2013-01-02 13:14:29 +00:00
Daniel Juyung Seo ba8be587ab e dialog: Handle Escape keys on dialogs. This is very useful. Now e about, theme about, sys dialogs handles Escape key and closes the window.
SVN revision: 81966
2013-01-01 23:44:11 +00:00
Mike Blumenkrantz 9bd47bb46b add enum for deskflip animation mode
SVN revision: 81931
2012-12-31 14:00:47 +00:00
Mike Blumenkrantz 0d8a0f40df convert #defines in e_int_menus.h to enums
SVN revision: 81930
2012-12-31 13:51:43 +00:00
Mike Blumenkrantz b471739c98 e_win now traps elm_win_activate to avoid conflict with active hint ignore settings
SVN revision: 81926
2012-12-31 08:20:22 +00:00
Mike Blumenkrantz 1bbcf1abb0 added function to hide all active menus, always hide menus when desklocking
SVN revision: 81925
2012-12-31 07:47:51 +00:00
Carsten Haitzler 2bcb066ccb oh this was always broken - mh simply was never set and being used...
until the 2nd loop. by then it ws too lae as ms was screwed.



SVN revision: 81895
2012-12-30 10:53:29 +00:00
Mike Blumenkrantz f3e9d402b8 fix wrong config value clamping for window autoraise delay
SVN revision: 81886
2012-12-29 19:01:03 +00:00
Mike Blumenkrantz 34abfeb42e more elm tooltip window fixes
SVN revision: 81885
2012-12-29 17:03:13 +00:00
Mike Blumenkrantz 27c5e97d3b fix elm tooltip borderless display
SVN revision: 81879
2012-12-29 16:04:42 +00:00
Mike Blumenkrantz a5a068a358 fix xkb variant construction, patch from Tomas Cech
ticket #2119


SVN revision: 81849
2012-12-28 22:35:10 +00:00
Carsten Haitzler 7483f4bee9 allow for primary toplevel menus > screen height (or width) and
autoscroll them correctly. also raise the limits for menu sizes up to
30k or 2x zone height for menu item cutoff...



SVN revision: 81778
2012-12-28 03:28:25 +00:00
Cedric BAIL 5af50c40da e: remove some warning when compiling on FreeBSD.
Patch by Maxime Villard <rustyBSD@gmx.fr>.


SVN revision: 81772
2012-12-28 00:27:41 +00:00
Christopher Michael e69f1ae991 Fix uninitialized variable warning(s).
Fix formatting for 80 columns.

Signed-off-by: Christopher Michael <cpmichael1@comcast.net>

SVN revision: 81743
2012-12-27 13:18:59 +00:00
Mike Blumenkrantz 6112e1285c flag config option as GUI
SVN revision: 81737
2012-12-27 09:06:11 +00:00
Mike Blumenkrantz 204a7b1065 hmm that didn't work like I expected, leave elm include here I guess even though this is awkward...
SVN revision: 81733
2012-12-27 07:32:53 +00:00
Mike Blumenkrantz be140d1a3b if using elm, include globally for e
SVN revision: 81732
2012-12-27 07:27:12 +00:00
Igor Murzov b96d338097 Fix inverted arguments for lseek()
Patch from Maxime Villard <rustyBSD@gmx.fr>
"Hum, I've made a mistake in e_fm_op.c with lseek(), I inverted
the two last arguments. However it's not harmful, as SEEK_SET=0.:


SVN revision: 81697
2012-12-25 18:12:31 +00:00
Chidambar Zinnoury 8d542d40a8 e gadcon settings: add icons.
SVN revision: 81694
2012-12-25 17:04:15 +00:00
Mike Blumenkrantz 66aaa87c49 warn--
SVN revision: 81634
2012-12-22 10:33:45 +00:00
Mike Blumenkrantz 56ef3c37d2 add echievements to module whitelist: I (and others) maintain the hell out of this, so I consider it a real bug if there's a crash
SVN revision: 81633
2012-12-22 10:32:30 +00:00
Mike Blumenkrantz 0f01a6b279 in a move which will make me tremendously unpopular, config versioning has been changed from hex to dec across the whole tree, including helper functions and modules
PS. HAHAHAHAHAHAHAHA


SVN revision: 81624
2012-12-21 23:57:05 +00:00
Mike Blumenkrantz 8cd8b27f96 hokay, last commit made bg_file_get leak, so now let's simplify and clean it up
SVN revision: 81621
2012-12-21 23:06:11 +00:00
Mike Blumenkrantz 32c5b6e9fd possibly the last bug fix before release, yet another stringshare bug
ticket #2072


SVN revision: 81620
2012-12-21 22:58:17 +00:00
Mike Blumenkrantz 21bdf63d57 don't generate menu on startup, just cache it after the first one
SVN revision: 81561
2012-12-21 16:34:50 +00:00
Hannes Janetzek 303abf60de e17/shelf: fix wrong autohide with systray on second zone
SVN revision: 81557
2012-12-21 15:54:45 +00:00
Mike Blumenkrantz de5a59c469 correctly update gtk icons/themes when changed, also don't double update on icon events
ticket #2063


SVN revision: 81541
2012-12-21 12:03:11 +00:00
Mike Blumenkrantz 3bc56a9e5f fix a tremendous number of stringshare leaks
SVN revision: 81532
2012-12-21 10:20:05 +00:00
Mike Blumenkrantz b13ca641f7 ensure we get a properly stringshared return value here to match state of e_path_find
SVN revision: 81527
2012-12-21 10:02:27 +00:00
Mike Blumenkrantz e9ea6454d9 some stringshare improvements for e_path_find
SVN revision: 81526
2012-12-21 10:01:01 +00:00
Mike Blumenkrantz 4ee20a2c2f use edje_file_group_exists instead of manually iterating the groups
SVN revision: 81524
2012-12-21 09:08:33 +00:00
Mike Blumenkrantz e049fbf4ee use stringshare return type
SVN revision: 81523
2012-12-21 09:03:30 +00:00
Mike Blumenkrantz 99a5b074dd show icons again when activating DND drop menu
ticket #2061


SVN revision: 81514
2012-12-21 08:08:56 +00:00
Mike Blumenkrantz d7bc5ae149 e internal dialogs now correctly remember their maximization state and are now less prone to moving around crazily if e is restarted while they are maximized
SVN revision: 81472
2012-12-20 17:51:42 +00:00
Mike Blumenkrantz 59c4945890 another focus bug: pointer no longer warps when closing a window if pointer was not over a window when window was closed
SVN revision: 81470
2012-12-20 16:50:44 +00:00
Mike Blumenkrantz 72a901f954 finally fix insanely long-lived bug where pointer warp would end abruptly if the timer was called again before the X cursor move had occurred
SVN revision: 81469
2012-12-20 16:38:12 +00:00
Mike Blumenkrantz 6267cbd223 found a weird bug where sometimes window remembers get saved wrong...add some checks to rescue lost windows like these on startup and unb0rk the related remember
SVN revision: 81467
2012-12-20 15:37:01 +00:00
Mike Blumenkrantz 829a5b0d28 in fact, if we're being serious, linear_flip_to doesn't need flip eval either since it calls a function which does a flip eval
SVN revision: 81465
2012-12-20 14:57:55 +00:00
Mike Blumenkrantz fe991936c0 linear_flip_to already does a flip eval, don't need it here
SVN revision: 81464
2012-12-20 14:52:50 +00:00
Mike Blumenkrantz 6888d7b697 argh more of that desktop profile insanity that didn't get #ifdefs
SVN revision: 81458
2012-12-20 14:07:33 +00:00
Mike Blumenkrantz 7d1cc24f5c only do pointer warp for sloppy focus if the mouse is currently over another window, otherwise just do the other focus-in manually
ticket #morlenxus


SVN revision: 81455
2012-12-20 13:52:49 +00:00
Mike Blumenkrantz a9e313bb1c always set last focused focus on desk change
SVN revision: 81454
2012-12-20 13:51:08 +00:00
Carsten Haitzler 1f745881d9 series of dialogs that were not resizable but should be, are now.
SVN revision: 81434
2012-12-20 10:07:30 +00:00
Mike Blumenkrantz 68e80049c7 improve xkb init: don't call setxkbmap more than once, wait a short while on a timer before setting the layout group to (hopefully) ensure that setxkbmap has completed before trying to set the group number
SVN revision: 81430
2012-12-20 09:27:35 +00:00
Boris Faure c9dfe38ac2 e:slider: delete timer early to avoid losing it. Fix #2050
SVN revision: 81408
2012-12-19 22:34:37 +00:00
Massimo Maiurana c4058ca063 Make some error dialogs translatable (patch from Igor Murzov)
SVN revision: 81394
2012-12-19 17:45:04 +00:00
Mike Blumenkrantz 271f92f912 ahh never too late for an API/ABI break. e_icon_file_get now returns edje group, which fixes fileman border icons
ticket #rasternaggedme


SVN revision: 81387
2012-12-19 17:00:10 +00:00
Christopher Michael 39b6588855 Revert exposing the try_restore_config function.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 81375
2012-12-19 15:39:31 +00:00
Christopher Michael 1012d6be1d Change e_randr_12_try_enable_output to be exported via EAPI.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 81366
2012-12-19 14:21:44 +00:00
Christopher Michael 4d4fd44b39 Expose the e_randr_12_try_enable_output function via EAPI.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 81365
2012-12-19 14:21:39 +00:00
Mike Blumenkrantz ae7ca9105f Hi,
here is a patch.

 1. free() already null-checks the passed argument, so it is not
    necessary to do 'if(x) free(x)'.

 2. Moved some '{free(x); x = NULL}' to E_FREE.

 3. In e_start_main.c, 'buf' is allocated with the size of the
    two arguments + '=', so we don't need to check for lenght;
    we should use sprintf().

 thanks
Maxime Villard


SVN revision: 81364
2012-12-19 14:20:34 +00:00
Mike Blumenkrantz b393de2eaa fix shelf autohide on click
ticket #2051


SVN revision: 81362
2012-12-19 13:59:36 +00:00
Mike Blumenkrantz 4ff6488dfa apparently scrollframe has its own key grabs??? wtf???
ticket #2043


SVN revision: 81355
2012-12-19 12:29:47 +00:00
Mike Blumenkrantz ddd898bdac "set as background" ctx action now sets default bg instead of current desk bg
ticket #2042


SVN revision: 81352
2012-12-19 11:13:23 +00:00
Mike Blumenkrantz d6b83ff15e don't return blank locale parts
SVN revision: 81340
2012-12-19 09:52:14 +00:00
Mike Blumenkrantz 43dca4ccd8 don't leak efreet menus!
SVN revision: 81338
2012-12-19 09:44:55 +00:00
Mike Blumenkrantz 91aad68829 e_util_strcmp now checks if ptrs are equal before running strcmp
SVN revision: 81336
2012-12-19 09:39:35 +00:00
Mike Blumenkrantz 24ce5a79a3 initialize var for static analyzer
SVN revision: 81333
2012-12-19 09:27:51 +00:00
Mike Blumenkrantz 602c4dd07a change shelf style during config while gadcon is unpopulated for a small speedup, also fixes crash when changing size and style
ticket #2048


SVN revision: 81332
2012-12-19 09:18:11 +00:00
Mike Blumenkrantz aa35b742c5 don't stop filling a gadcon if one (systray) fails to create
SVN revision: 81331
2012-12-19 09:17:05 +00:00
Mike Blumenkrantz 44c599480b changing shelf style no longer repopulates the gadcon
SVN revision: 81329
2012-12-19 09:16:09 +00:00
Mike Blumenkrantz 504c88e033 fix shelf autohiding for when people slowly, over the course of an hour or longer, move their mouses a single pixel distance out of the shelf onto a gtk app
ticket #1884


SVN revision: 81327
2012-12-19 08:55:51 +00:00
Carsten Haitzler 47c5345f55 lets not make the buffer so small (256 chars). with utf8 this could be
as little as 42 letters... in theory.... :) 1024 is better.



SVN revision: 81318
2012-12-19 01:33:20 +00:00
Mike Blumenkrantz cfd42b1c6b efm no longer allows renaming files over other files or into directories
ticket #2024


SVN revision: 81253
2012-12-18 14:08:39 +00:00
Mike Blumenkrantz 45a263b793 trivial formatting
SVN revision: 81249
2012-12-18 13:40:10 +00:00
Mike Blumenkrantz 9bfd23edab whoops forgot to set r
SVN revision: 81244
2012-12-18 13:07:57 +00:00
Mike Blumenkrantz ab1455310a fix opening a .desktop file which is a link to a file
SVN revision: 81243
2012-12-18 12:28:37 +00:00
Mike Blumenkrantz 317ca83733 delete smart callbacks when deleting efm toolbar
ticket #2026


SVN revision: 81242
2012-12-18 12:16:47 +00:00
Mike Blumenkrantz 3577ddfff2 fix e_intl_locale_parts_combine() usage to handle locales without regions
SVN revision: 81241
2012-12-18 12:10:33 +00:00
Mike Blumenkrantz 747a446838 apparently efreet_menu_get() uses timers and such for some reason, sigh. back to threadless we go for this
SVN revision: 81239
2012-12-18 12:01:59 +00:00
Christopher Michael edf54d9d1b Make sure we have a valid monitor edid_hash Before trying to append it
to the serialized config.

Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 81238
2012-12-18 11:15:25 +00:00
Christopher Michael 290423c477 Fix incorrect types used in _e_config_randr_mode_info_edd:
randr structure for this uses unsigned int, not int, so store them
    in unsigned.

Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 81237
2012-12-18 11:14:31 +00:00
Mike Blumenkrantz 37a539bf80 simplify string lowercasing in intl post-init
SVN revision: 81235
2012-12-18 11:10:00 +00:00
Mike Blumenkrantz 77d578451c fix retrieving locale parts if region is not present
SVN revision: 81233
2012-12-18 11:04:00 +00:00
Mike Blumenkrantz 1199fc9807 okay, exposing icon object not such a great idea considering it gets deleted and recreated constantly
SVN revision: 81230
2012-12-18 10:12:47 +00:00
Mike Blumenkrantz d54e0dd00b add efm icon object to icon info so people can hook callbacks to it
SVN revision: 81228
2012-12-18 09:39:10 +00:00
Mike Blumenkrantz a658db2782 use e_util_strcmp, set current gadcon style menu item to disabled, only use default style as menu item if current style not set
ticket #2023


SVN revision: 81226
2012-12-18 09:30:35 +00:00
Mike Blumenkrantz 558894792f fix gadcon stringshare usage
SVN revision: 81225
2012-12-18 09:25:48 +00:00
Mike Blumenkrantz adae1d9000 prevent shelf artifacts when re-creating shelf after config
ticket #2005


SVN revision: 81224
2012-12-18 09:20:32 +00:00
Mike Blumenkrantz 6c71c50732 whoops, ensure we unmount the deleted mount object after the mount ops are run
SVN revision: 81204
2012-12-18 06:11:03 +00:00
Mike Blumenkrantz f0965845b5 handle better a startup where a config cannot be loaded
ticket #2003


SVN revision: 81163
2012-12-17 16:12:32 +00:00
Mike Blumenkrantz 46f630f103 efm finally does something other than flail around helplessly when you drag stuff onto the icon of another device
ticket #2000, fuck DND


SVN revision: 81162
2012-12-17 15:59:43 +00:00
Christopher Michael a6d983b1a8 Include private header before public one (without this change, build
breaks).

Export e_randr_try_restore_configuration function so it can be used
from the RandR module.

Combine serialized_setup_new code into one function (No reason for
additional function call).

Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 81159
2012-12-17 15:46:50 +00:00
Christopher Michael 407fd760f6 Remove generic EINTERNAL _try_restore_configuration. Combine the code
into one e_randr_try_restore_configuration function.

Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 81158
2012-12-17 15:46:47 +00:00
Christopher Michael 296a985992 Export the try_restore_configuration function.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 81157
2012-12-17 15:46:43 +00:00
Christopher Michael 0744667e74 Use proper function when config gets loaded to try and restore
configuration.

Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 81156
2012-12-17 15:46:41 +00:00
Christopher Michael 85de44850b Include private header After public header.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 81155
2012-12-17 15:46:37 +00:00
Christopher Michael 94535beb52 Group EAPI functions together.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 81154
2012-12-17 15:46:32 +00:00
Christopher Michael 00d5045d27 Move EAPI functions above EINTERN ones.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 81148
2012-12-17 14:28:04 +00:00
Christopher Michael 1f13d6d76d Move EINTERN functions below EAPI exposed functions.
Fix formatting.

Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 81147
2012-12-17 14:21:42 +00:00
Christopher Michael 06a76bcb27 Add e_randr_store_configuration function to exposed headers
(NB: It was exposed in the serialization file, but never provided by
the e_randr header).

Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 81146
2012-12-17 14:21:39 +00:00
Christopher Michael d4810be25f No need for 2 functions which do the same thing (return a new
Serialized Setup).

Signed-off-by: Christopher Michael <cp.michael@samsung.com>

SVN revision: 81145
2012-12-17 14:21:35 +00:00
Mike Blumenkrantz 606701ff6c make e_fm2_device_mount_free() EAPI
SVN revision: 81123
2012-12-17 11:34:19 +00:00
Mike Blumenkrantz b22ac9e803 also automatically show files again if an op fails entirely
SVN revision: 81120
2012-12-17 10:59:10 +00:00
Mike Blumenkrantz e41c2b9343 fix weird efm crash
SVN revision: 81070
2012-12-17 08:30:46 +00:00
Massimo Maiurana 6b330d0932 Translate the "Shelf <orientation>" message (patch from Igor Murzov)
SVN revision: 81052
2012-12-16 17:10:08 +00:00
Massimo Maiurana 9f1d6e067e Store and handle action names correctly. (patch from Igor Murzov)
SVN revision: 81049
2012-12-16 16:58:17 +00:00
Chidambar Zinnoury ee1209aceb e button widget: same bad logic when removing text. See r81045.
Sorry, didn’t check before committing!


SVN revision: 81046
2012-12-16 16:36:55 +00:00
Chidambar Zinnoury 9bb7ab62de e button widget: bad logic when removing icon.
SVN revision: 81045
2012-12-16 16:33:57 +00:00
Carsten Haitzler 7badcc8fe9 radios - if none is selected... the one u select gets selected. :)
SVN revision: 81043
2012-12-16 14:06:10 +00:00
Carsten Haitzler 0251a602f9 ok - give some size in printf.
SVN revision: 81037
2012-12-16 01:29:48 +00:00
Carsten Haitzler 5ab8396f24 ok - strdupa make sure its defined after other includes in case,.. and
add to e_fm_ipc.c...



SVN revision: 81036
2012-12-16 01:17:45 +00:00
Chidambar Zinnoury 23299743a2 e: Unicode makes you look better, gives you luck, brings back lost love,
SVN revision: 81031
2012-12-15 20:19:33 +00:00
Chidambar Zinnoury d2f9a1cc7d e main menu: remove parentheses and disable item when there are no elements.
SVN revision: 81030
2012-12-15 20:07:02 +00:00
Maxime Villard 5ebf793f1b From: Maxime Villard <rustyBSD@gmx.fr>
Subject: [E-devel] [e] Patch acpi

A little patch to fix a possible warning - and overflow.

'buf' is PATH_MAX, but PATH_MAX is not necessary 1024. If
PATH_MAX < 1024 -> overflow.

Also, fgets() fills the buffer and nullterminate it, so we
don't need to buff[0] = '\0'.



SVN revision: 81024
2012-12-15 14:42:19 +00:00
Carsten Haitzler 8c3c6c57a0 provide debug printfs for cedric.. my init splash comes up fine...
debug loosk good.



SVN revision: 81014
2012-12-15 07:51:16 +00:00
Carsten Haitzler 18b1eb7111 revert that.. its not a double free... its a bizarre-arse macro!
SVN revision: 81012
2012-12-15 07:44:11 +00:00
Carsten Haitzler 320ec625b0 wtf? thats like double-free land.. why strdupa at all? nuts! remove
strdupa's and make code consistent with neighbouring code.



SVN revision: 81006
2012-12-15 01:56:35 +00:00
Mike Blumenkrantz 679cae4fad patch from maxime villard fixing strdupa definition and moving a variable to local scope
SVN revision: 80990
2012-12-14 21:09:21 +00:00
Mike Blumenkrantz 9d68775725 fix pointer warping on desk change + revert focus
ticket #1994


SVN revision: 80942
2012-12-14 13:47:53 +00:00
Mike Blumenkrantz 381425f538 improper E_FREE usage
SVN revision: 80939
2012-12-14 13:04:32 +00:00
Mike Blumenkrantz acdc863299 fix magic fail when deleting desklock popup: popup already hidden, so don't need to delay delete
SVN revision: 80938
2012-12-14 13:04:16 +00:00
Mike Blumenkrantz 8b698680df reorder efm dnd finished cb to prevent crash when accessing possibly deleted icon
SVN revision: 80933
2012-12-14 11:29:50 +00:00
Mike Blumenkrantz 1d7d7def2a update widget min size when changing label text
SVN revision: 80932
2012-12-14 11:29:19 +00:00
Mike Blumenkrantz 8347b33d9c more leaks gone in trash code that isn't used
SVN revision: 80924
2012-12-14 09:19:50 +00:00
Mike Blumenkrantz 799e6b5a5e it seems that this variable in e_exec does not actually need to be strdup()ed, and thus does not need to leak...
SVN revision: 80923
2012-12-14 09:13:07 +00:00
Mike Blumenkrantz 31b66a272e improper E_FREE usage
SVN revision: 80922
2012-12-14 09:07:57 +00:00
Mike Blumenkrantz 53c7cc643f small leak in config registry item add
SVN revision: 80920
2012-12-14 09:04:23 +00:00
Mike Blumenkrantz f4440456f7 actually we can just strdupa here instead
SVN revision: 80899
2012-12-13 21:28:54 +00:00
Mike Blumenkrantz 925645792e grr meant strncpy!
SVN revision: 80898
2012-12-13 21:25:29 +00:00
Mike Blumenkrantz 0d579688ae add object_repack function for frametable
SVN revision: 80890
2012-12-13 20:12:32 +00:00
Mike Blumenkrantz 6ae01a1b09 unbreak e_intl.h #ifdefs
SVN revision: 80889
2012-12-13 19:12:37 +00:00
Mike Blumenkrantz 006a014982 gadcon positioning leak
SVN revision: 80850
2012-12-13 13:41:35 +00:00
Mike Blumenkrantz 44442a8e45 reorder some stuff in static_grab to be more successful
SVN revision: 80842
2012-12-13 13:11:21 +00:00
Mike Blumenkrantz 3d9ac54d21 even more leaks in randr11 refresh rates fail
SVN revision: 80841
2012-12-13 13:01:57 +00:00
Mike Blumenkrantz 4e23dd680e fix leak in randr11 refresh rate failure
SVN revision: 80840
2012-12-13 12:59:43 +00:00
Mike Blumenkrantz 7fb5b16ee4 void functions don't return values
SVN revision: 80839
2012-12-13 12:55:59 +00:00
Mike Blumenkrantz 3111aa6120 another pedantic free for the analyzers
SVN revision: 80838
2012-12-13 12:53:28 +00:00
Mike Blumenkrantz 251ee5a5d6 another pedantic and probably unneeded null check
SVN revision: 80837
2012-12-13 12:52:13 +00:00
Mike Blumenkrantz 3a82001c8b fix leak in client menu generation
SVN revision: 80836
2012-12-13 12:50:58 +00:00
Mike Blumenkrantz 6388913775 another pedantic and probably unneeded null check
SVN revision: 80835
2012-12-13 12:47:34 +00:00
Mike Blumenkrantz 6d0a11236f fix possible buffer overflow in module config dialog
SVN revision: 80832
2012-12-13 12:03:41 +00:00
Mike Blumenkrantz 8f1f764359 don't leak on iterate in intl path searching
SVN revision: 80831
2012-12-13 11:58:06 +00:00
Mike Blumenkrantz 1358b91d2b pedantic free() here to shut up analyzers
SVN revision: 80829
2012-12-13 11:56:22 +00:00
Mike Blumenkrantz b51d7c6eda fix leak in import dialog
SVN revision: 80828
2012-12-13 11:55:10 +00:00
Mike Blumenkrantz da5caff466 inlist_count is not O(1)
SVN revision: 80827
2012-12-13 11:52:38 +00:00
Mike Blumenkrantz 9b4ec19471 fix guaranteed crash in efm_op...rustyBSD check this if you happen to read
SVN revision: 80826
2012-12-13 11:49:07 +00:00
Mike Blumenkrantz 4a2837830b another efm_op leak, also wrong E_FREE usage
SVN revision: 80824
2012-12-13 11:34:09 +00:00
Mike Blumenkrantz e0926014a1 fix possible NULL deref in efm_op
SVN revision: 80823
2012-12-13 11:30:40 +00:00
Mike Blumenkrantz c637b2874f fix small leak in efm_op
SVN revision: 80822
2012-12-13 11:27:47 +00:00
Mike Blumenkrantz b48d65af00 fix lots of stupidity in efm daemon trash code that isn't even enabled
SVN revision: 80821
2012-12-13 11:18:26 +00:00
Mike Blumenkrantz 0743fd1ea2 fix efm daemon leak in every command made
SVN revision: 80820
2012-12-13 11:13:17 +00:00
Mike Blumenkrantz b2b336ed7d fix leak in efm daemon when reordering files
SVN revision: 80819
2012-12-13 11:10:01 +00:00
Mike Blumenkrantz 67b24415d6 fix efm leak when symlinking out of an ASK DND action
SVN revision: 80818
2012-12-13 11:07:06 +00:00
Mike Blumenkrantz 52ca7afc9a fix leak in e_exec when DISPLAY is too long
SVN revision: 80817
2012-12-13 11:03:13 +00:00
Mike Blumenkrantz 59aa402a46 fix wrong E_FREE usage
SVN revision: 80816
2012-12-13 11:02:36 +00:00
Mike Blumenkrantz c0910ad0d4 only create config registry item once its category has been found to prevent dangling registry items
SVN revision: 80815
2012-12-13 10:56:59 +00:00
Mike Blumenkrantz f81c0f3d93 fix uninitialized border geom in SMART/EXPAND maximizes
SVN revision: 80814
2012-12-13 10:48:39 +00:00
Mike Blumenkrantz 7877c41869 handle NULL more gracefully in e_bindings_signal_handle
SVN revision: 80813
2012-12-13 10:38:24 +00:00
Mike Blumenkrantz e3c0e6bbcc shut up e_exehist
SVN revision: 80812
2012-12-13 10:37:14 +00:00
Mike Blumenkrantz 9cc54e74c7 formatting
SVN revision: 80804
2012-12-13 09:46:11 +00:00
Carsten Haitzler dae7d45236 add small detail to error printf on e_sys.
SVN revision: 80799
2012-12-13 08:32:37 +00:00
Mike Blumenkrantz 6999eb8ad1 add new event for when managers regrab keys
SVN revision: 80774
2012-12-12 19:21:31 +00:00
Mike Blumenkrantz 55ae26fcd3 prevent config dialogs from crashing if create/free data functions are not defined
SVN revision: 80772
2012-12-12 16:54:48 +00:00
Mike Blumenkrantz 8077e1aafb always unpopulate shelf before changing orientation so systray doesn't ibtch
SVN revision: 80768
2012-12-12 14:56:17 +00:00
Mike Blumenkrantz 86aa333211 disable currently-set orientation for shelf on orientation change menu
SVN revision: 80766
2012-12-12 14:44:10 +00:00
Mike Blumenkrantz dbce2eaed3 show files again when an overwrite dialog pops up
ticket #1974


SVN revision: 80762
2012-12-12 13:50:43 +00:00
Mike Blumenkrantz a8143270cd always re-set xmodmap after changing kbd layout group
SVN revision: 80761
2012-12-12 13:31:18 +00:00
Mike Blumenkrantz 15df42143e add some null checks before monitor deletion to account for people still affected by the frenchman's laziness
SVN revision: 80757
2012-12-12 12:34:49 +00:00
Carsten Haitzler ddbf106d6e ensur emensu dont go futzing about whileu use them... allocate
POTENTIAL space for submenus later. :)



SVN revision: 80751
2012-12-12 11:06:40 +00:00
Mike Blumenkrantz d0eff6a730 fix initial name string for New Directory action
SVN revision: 80748
2012-12-12 10:12:29 +00:00
Mike Blumenkrantz a93a4d56f0 New Directory action in efm now renames inline like New File action
SVN revision: 80747
2012-12-12 10:08:04 +00:00
Carsten Haitzler 353b588347 10k files.... ok! :)
oh and fix a segv people will get when queue process timeout is hit...

and reduce timeout to 0.01 sec :)



SVN revision: 80746
2012-12-12 09:59:53 +00:00
Carsten Haitzler da9336c9dd fix menu box packing for submenu itms so when set up in specific
orners with a pre callback... its packed WITH fill



SVN revision: 80661
2012-12-11 14:37:17 +00:00
Mike Blumenkrantz 90ce8a3f24 fix buffer length for deskenv_init
SVN revision: 80660
2012-12-11 14:31:12 +00:00
Mike Blumenkrantz b341cd4689 unbreak mouse move events when autohiding shelves are present
ticket #1961
ticket #zmikeisdumb


SVN revision: 80659
2012-12-11 14:20:53 +00:00
Mike Blumenkrantz ab1a9e5e80 efm no longer eats pager dnd events
SVN revision: 80646
2012-12-11 11:14:25 +00:00
Carsten Haitzler 54faad046f dont focus noedit entries! :)
SVN revision: 80645
2012-12-11 10:54:31 +00:00
Carsten Haitzler 36523293d2 fix read-only status of file name in desktop editor
SVN revision: 80644
2012-12-11 10:50:54 +00:00
Mike Blumenkrantz 00cac2c0a4 add function for determining whether modules are still loading
SVN revision: 80640
2012-12-11 10:30:06 +00:00
Mike Blumenkrantz f287acc53c warn--
SVN revision: 80639
2012-12-11 10:29:48 +00:00
Mike Blumenkrantz c4115615f0 s/creat/open/
SVN revision: 80630
2012-12-11 08:44:05 +00:00
Mike Blumenkrantz 370ba1b3fe okay, after considering the words of a certain frenchman we no longer write anything to new files
SVN revision: 80629
2012-12-11 07:50:06 +00:00
Mike Blumenkrantz e61159e49e write \n to new files instead of ""
ticket #1947


SVN revision: 80608
2012-12-10 14:16:16 +00:00
Mike Blumenkrantz c30e42e9ec fix fsel path changing and entry setting
SVN revision: 80606
2012-12-10 13:06:04 +00:00
Mike Blumenkrantz fd9abc1da8 e now properly sets "hicolor" as the icon theme when no theme is set (FDO standard: http://icon-theme.freedesktop.org/wiki/HicolorTheme)
SVN revision: 80601
2012-12-10 11:48:20 +00:00
Mike Blumenkrantz f9c87ab214 fix efm crash when using XDS drags, also fix XDS drags to work again
SVN revision: 80599
2012-12-10 11:41:40 +00:00
Daniel Juyung Seo 206acb6eb6 e e_icon.c: also return false on null icon.
SVN revision: 80598
2012-12-10 11:33:45 +00:00
Mike Blumenkrantz 06897e960b fix dnd source visibility when dragging into a link drop target
ticket #1953


SVN revision: 80586
2012-12-10 08:59:36 +00:00
Mike Blumenkrantz 74b145c3d0 hide scrollbars by default in scrollframe
ticket #1954


SVN revision: 80584
2012-12-10 08:29:53 +00:00
Mike Blumenkrantz 9605a4fb85 resizable dialogs are now compatible with the maximize action and maximize options in border menu
ticket #1950


SVN revision: 80581
2012-12-10 08:20:52 +00:00
José Roberto de Souza 463617699c From: José Roberto de Souza <zehortigoza@profusion.mobi>
Subject: [E-devel] [PATCH] e: Return EINA_FALSE if icon path was not
found



SVN revision: 80567
2012-12-10 06:58:58 +00:00
Massimo Maiurana 96fac26f2f Mark some strings for translation. (patch from Igor Murzov)
SVN revision: 80551
2012-12-09 14:39:30 +00:00
Carsten Haitzler f0c9f5121c lots of buglet-fixing. this does:
1. make idle fade timer work at all (dodnt work before)
2. fixes backlight status on e restart
3. fixes setting bl level on start
4. improves the compositor fade in/out effect by ALSO fading backlight
in and out... oh so much smoother now
5. fixes label in ui to be seconds, not minutes.
6. in order to make this all work - it adds a special screensaver
event inside of e that the screensaver subsystem generates based on
the real x one.



SVN revision: 80538
2012-12-09 06:27:42 +00:00
Carsten Haitzler 1b4cfff4bf avoid mouse down cb feeding another mouse down cb.. to itself.. until
the stack blows.. in slider.



SVN revision: 80510
2012-12-08 05:16:33 +00:00
Sebastian Dransfeld 7903db5d3d e: efreet event can be null
And add code to normal startup with a TODO

SVN revision: 80500
2012-12-07 20:27:27 +00:00
Massimo Maiurana 8b38245df1 two more duplicate message with different case and also two with slash and hyphen
SVN revision: 80481
2012-12-07 18:15:14 +00:00
Mike Blumenkrantz 82b4efa5e4 in the event that an ecore_exe is not passed with the exit cb, check the pid list
SVN revision: 80450
2012-12-07 13:28:17 +00:00
Mike Blumenkrantz 41fbbfe2da when fullscreening a window from a maximized state, prevent overwriting of previously saved window geometry
ticket #1940


SVN revision: 80416
2012-12-07 08:05:17 +00:00
Mike Blumenkrantz b3ae9ae78a always run deskenv init on startup, even during restart; gnome-settings-daemon is smart enough not to run if already running
ticket #1939


SVN revision: 80415
2012-12-07 07:54:35 +00:00
Cedric BAIL a97fb13810 e: forgotten move to PT_GETSIGINGO.
SVN revision: 80408
2012-12-07 02:49:40 +00:00
Carsten Haitzler d1581b714f group ptrs together.
SVN revision: 80407
2012-12-07 02:48:30 +00:00
Boris Faure 5bf8a6cab3 e: fix windows being uniconified on desk show
SVN revision: 80392
2012-12-06 21:22:34 +00:00
Massimo Maiurana b2d8ca25e5 this is to avoid duplicate messages different only for case of initial letters, so translation files has less messages
SVN revision: 80374
2012-12-06 17:44:36 +00:00
Mike Blumenkrantz 3c78f7dba2 fix ratio resizing when increasing window size
ticket #1935


SVN revision: 80359
2012-12-06 13:24:27 +00:00
Mike Blumenkrantz 3a87b43a19 formatting
SVN revision: 80356
2012-12-06 12:48:14 +00:00
Mike Blumenkrantz f233e0d59d fix shelf autohiding when the mouse goes directly from a shelf into the window of a shitty toolkit which blocks X mouse movement events
ticket #1884


SVN revision: 80343
2012-12-06 11:03:32 +00:00
Mike Blumenkrantz 955c24344a fix shelf autohide calculations for non-zero zones
ticket #1884


SVN revision: 80334
2012-12-06 10:27:15 +00:00
Mike Blumenkrantz ce1add259c probably fix crash in ticket #1931
SVN revision: 80333
2012-12-06 09:59:14 +00:00
Mike Blumenkrantz 2b64147c16 double clicking efm icons with single click activation enabled no longer opens directories twice
ticket #1933


SVN revision: 80331
2012-12-06 09:52:06 +00:00
Mike Blumenkrantz 7972371393 efm menu replace/start functions now properly pass icon info
SVN revision: 80327
2012-12-06 09:36:35 +00:00
Mike Blumenkrantz 4aa85b3c2c add timer to show icons after a drag to fix XDirectSave dnd
ticket #1917


SVN revision: 80324
2012-12-06 09:16:15 +00:00
Mike Blumenkrantz 654b7ee554 use event handler list macro
SVN revision: 80323
2012-12-06 09:04:18 +00:00
Mike Blumenkrantz 11b244883d fix weird dnd crash
SVN revision: 80321
2012-12-06 09:01:32 +00:00
Mike Blumenkrantz d6521d8cad fix pointer slide focus setting
SVN revision: 80307
2012-12-06 08:01:42 +00:00
Mike Blumenkrantz 503d7305db Dear all,
As I've said before, I'm attached a patch for minor bugs in the e17 again.
 Please take a look at attached patch.

 01. missing E_FREE(wev) if zone is null
     File: src/bin/e_actions.c: 1467
     Function: ACT_FN_GO_EDGE macro function
     null check of zone and wev, it would be better to separate them.

 02. dead code
     File: src/bin/e_configure.c: 338
     Function: _e_configure_efreet_desktop_update

 03. array buf might be overwritten by "buf[i] = '\0'"
     File: src/bin/e_eap_editor.c: 412
     Function: _e_desktop_edit_user_local_desktop_filename_generate

 04. missing null check
     File: src/bin/e_fm.c
     Function: e_fm2_icon_get: 2196
     It would be better to check ic->info.file in e_fm2_icon_get
     before passing to _e_fm2_file_is_edje because it doesn't check
     null pointer.

 05. array 'path' might be overwritten by "path[i + 1] = XXX"
     File: src/bin/e_fm.c: 4299
     Function: _e_fm2_uri_parse

 06. missing null check
     File: src/bin/e_fm_device.c: 468
     Function: e_fm2_device_mount_find
     If the null pointer is passed to e_fm2_device_mount_find,
     then it attempt to compare string using strncmp without null
     check.
     e.g., e_fm2_path_set
           -> real_path = _e_fm2_dev_path_map: this function could return null.
           -> sd->realpath = real_path;
           -> e_fm2_device_mount_find(sd->realpath)

 07. missing free(fstrip)
     File: src/bin/e_import_config_dialog.c: 34
     Function: _import_edj_gen

 08. missing _module_free(cfm)
     File: src/bin/e_int_config_modules.c: 530
     Function: _load_modules

 09. missing free(class) in for loop
     File: src/bin/e_int_menus.c: 1187
     Function: _e_int_menus_clients_add_by_class

 10. missing free(roots)
     File: src/bin/e_main.c: 1646
     Function: _e_main_screens_init
     Actually only e_win_init function could return 0.
     But I've added free to other codes for the consistency.

 11. missing null check of 'es->cfg'
     File: src/bin/e_shelf.c: 2583
     Function: _e_shelf_bindings_add
     'es->cfg' might be null. please look at e_shelf_position_calc.

 12. no ect->category check before comparing string values
     File: src/bin/e_theme.c: 387
     Function: e_theme_config_remove
     I'm not sure, but inner if block checks ect->category before
     deleting a string.

 13. missing E_FREE(wcb) in while loop
     File: src/bin/e_widget_ilist.c: 146
     Function: _queue_timer

 14. dereferencing freed pointer 'entry'
     File: src/modules/quickaccess/e_mod_quickaccess.c: 583
     Function: _e_qa_event_border_remove_cb

 15. missing E_FREE(trov)
     File: src/modules/tiling/e_mod_tiling.c: 3106
     Function: _do_transition_overlay

 Thanks & Regards,
 Gwanglim


SVN revision: 80231
2012-12-05 11:13:09 +00:00
Carsten Haitzler 84b97ad9cc warn--... and actually build. :)
SVN revision: 80229
2012-12-05 10:56:18 +00:00
Mike Blumenkrantz f66c6c6f2c unbreak compile with 1.7 branch
SVN revision: 80226
2012-12-05 09:59:02 +00:00
Gwanglim Lee 499b88748b From: Gwanglim Lee <gl77.lee@samsung.com>
Subject: Re: Re: Re: [E-devel] [RFC] Virtual desktop window profile

I've attached 4th patch. May the 4th be with you.

ecore patch has been merged with efl and all files are based on r80123.

Thanks & Regards,
Gwanglim

------- Original Message -------
Sender : Daniel Juyung Seo<seojuyung2@gmail.com>
Date : 2012-12-04 01:55 (GMT+09:00)
Title : Re: Re: [E-devel] [RFC] Virtual desktop window profile

It looks ok to me.
Sorry but can you re-generate the patch according to the recent ecore
merge to efl single tree?

Daniel Juyung Seo (SeoZ)


On Thu, Nov 29, 2012 at 12:29 AM, Gwanglim Lee <gl77.lee@samsung.com>
wrote:

Dear Raster and Daniel Juyung Seo,

I've attached 3rd patches and test_config according to your reviews.
These are based on r79782.

[elementary & ecore]
1. "profile,set" -> "profile,changed" - done
2. spaces after EINA_LIST_FOREACH - done
3. variable type - keep
4. author - done
5. removing deprecated marking in patch - done
6. add elm_win_available_profiles_get to test_config for the debugging
purpose - done

7. check whether a given profile is present in an available profiles.
otherwise window profile will be one of the item
    in available profiles. - newly added thing to the elm_win
        8. merge with EO - done. :(
        
        
            Any comments would be appreciated.
            


SVN revision: 80216
2012-12-05 06:51:16 +00:00
Carsten Haitzler b000cf12d6 only srand once.
SVN revision: 80209
2012-12-05 06:21:41 +00:00
Cedric BAIL d8b8ba3be4 e: fix build on Solaris 11.
Patch by Robert David <robert.david.public@gmail.com>.


SVN revision: 80204
2012-12-05 02:23:00 +00:00
Mike Blumenkrantz 17c9b707d5 fix focus_revert_on_hide_or_close option to work correctly with mouse focus, also fix annoying pointer warp focus bug which erroneously focused windows while moving the pointer for pointer_slide warps on new windows
SVN revision: 80174
2012-12-04 15:11:53 +00:00
Mike Blumenkrantz 3bd8f4dd81 also fix lost window pointer warping
SVN revision: 80173
2012-12-04 14:58:48 +00:00
Mike Blumenkrantz 86a42a2e73 add functions for locking border focus
SVN revision: 80172
2012-12-04 14:57:35 +00:00
Mike Blumenkrantz 17ef5ee535 fix e_exec crash
SVN revision: 80171
2012-12-04 14:50:16 +00:00
Mike Blumenkrantz 5980697b20 delete from hash by key
SVN revision: 80170
2012-12-04 14:49:49 +00:00
Mike Blumenkrantz dd3f97f742 scrollframe scrollbars are NOT visible by default
ticket #1846


SVN revision: 80143
2012-12-04 11:20:35 +00:00
Mike Blumenkrantz 5a60f9dad8 further clamp menus to zone size
ticket #1895


SVN revision: 80138
2012-12-04 09:08:19 +00:00
Mike Blumenkrantz 0ceb3289f0 fix e_entry cnp to work better with non-container grab windows
SVN revision: 80094
2012-12-03 19:04:27 +00:00
Mike Blumenkrantz 23d0765d1a add function to return current key grab xwin
SVN revision: 80093
2012-12-03 19:03:49 +00:00
Mike Blumenkrantz d48545db45 add function to disable entry menu
SVN revision: 80091
2012-12-03 18:31:14 +00:00
Mike Blumenkrantz d444728457 all dialogs EXCEPT module config dialog are not resizable. this is just too frustrating
SVN revision: 80075
2012-12-03 14:59:39 +00:00
Carsten Haitzler d268bb2cc3 fix infintie delfn loop waiting to happen.
SVN revision: 80048
2012-12-03 11:40:23 +00:00
Cedric BAIL d6b04df109 e: when valgrind is on, no need to ptrace anything.
SVN revision: 80042
2012-12-03 10:43:14 +00:00
Mike Blumenkrantz 68e6b07cd7 all dialogs are no longer resizable
SVN revision: 80032
2012-12-03 09:24:12 +00:00
Mike Blumenkrantz dc5775e628 set no_resizable state by default on dialogs
SVN revision: 80029
2012-12-03 09:15:47 +00:00
Mike Blumenkrantz f8efeed3e8 fix in-place directory opening in efm: statinfo resolves link targets now, so only call "selected" if link target is not a directory
ticket #1863


SVN revision: 80026
2012-12-03 08:57:15 +00:00
Mike Blumenkrantz 362531b082 Dear all,
I'm attaching a patch for some minor bugs in the e17.
 Please take a look at attached patch.

 01. missing E_FREE(inst)
     File: src/bin/e_exec.c: 347
     Function: _e_exec_cb_exec

 02. missing null check
     File: src/bin/e_fm.c: 10173
     Function: _e_fm_error_dialog
     I'm not sure, but all other codes always check the return
     value of e_fm2_op_registry_entry_get except here.

 03. missing free(slave)
     File: src/bin/e_fm_ipc.c: 804
     Function: _e_fm_ipc_slave_run

 04. eina_list_remove after free
     File: src/bin/e_fm/e_fm_ipc.c :1325
     Function: _e_fm_ipc_cb_fop_trash_idler

 05. invalid check for _udisks_del, it might be _udisks_chg.
     File: src/bin/e_fm/e_fm_main_udisks.c : 162
     Function: _e_fm_main_udisks_test

 06. uninitialized gx and gy values
     File: src/bin/e_gadcon_popup.c: 172
     Function: _e_gadcon_popup_position
     These could be changed in e_gadcon_client_geometry_get
     if gcc->o_base is null.

 07. unnecessary code 'evas = e_win_evas_get(dia->win)'
     File: src/bin/e_import_config_dialog.c: 456
     Function: e_import_config_dialog_show

 08. missing free(sizes)
     src/bin/e_randr_11_serialization.c: 136
     Function: _11_try_restore_configuration()

 09. unnecessary variable output_info
     File: src/bin/e_randr_12.c: 560
     Function: _output_property_change_event_cb

 10. eina_list_remove after free
     File: src/bin/e_randr_12_serialization.c : 357
     Function: _12_serialized_setup_update

 11. no check of the return value of symlink.
     File: src/bin/e_widget_fsel.c: 84
     Function: _e_wid_fsel_favorites_add

 12. no evr->var check before comparing string values
     File: src/modules/conf_applications/e_int_config_defapps.c: 432
     Function: _basic_apply

 13. missing error message or check return value of edje_file_group_exists
     File: src/modules/conf_theme/e_int_config_theme.c: 333
     Function: _open_test_cb
     Anyway, I've added e_util_dialog_show if failed. Is it okay?

 14. missing index range check
     File: src/modules/gadman/e_mod_config.c: 153
     Function: _cb_config
     It could read negative array index, because return value of
     e_widget_ilist_selected_get might be negative.

 BR,
 Gwanglim


SVN revision: 80020
2012-12-03 07:54:07 +00:00
Carsten Haitzler 63286be95d lets make e_alert noto also be bag with valgrind eh?
SVN revision: 79998
2012-12-03 00:46:34 +00:00
Carsten Haitzler 8fa7ba94bb doing configure checks for arpa/inet.h and so on is all fine and
great.. but if the src file htis was intended for doesn't include e.h
so it include config.h... then its kind of pointless isn't it? :)



SVN revision: 79997
2012-12-03 00:27:52 +00:00
Mike Blumenkrantz 97a7e3affb cast to void in delete macro
SVN revision: 79986
2012-12-02 19:27:25 +00:00
Vincent Torri 688aa066a1 E17: define htonl correctly
SVN revision: 79960
2012-12-01 07:19:18 +00:00
Mike Blumenkrantz 011dfdccf5 only block fsel updating if path is already set
SVN revision: 79951
2012-11-30 21:26:24 +00:00