Commit Graph

397 Commits

Author SHA1 Message Date
Hannes Janetzek f8fc5f9f78 e17/fm: fix segv
SVN revision: 57399
2011-02-27 22:39:51 +00:00
Hannes Janetzek 0e59861be3 e17/fm: fix last commit.
it's possible that ic_next could be NULL


SVN revision: 57260
2011-02-23 10:37:17 +00:00
Hannes Janetzek af23edc941 e17/fm: select next item after deleting a file
SVN revision: 57258
2011-02-23 10:18:41 +00:00
Hannes Janetzek 8bf7b759a7 efm add keybindings:
- ctrl+h toggle show hidden files
- ctrl+1 icon view
- ctrl+2 list view
- ctrl+3 custom grid view


SVN revision: 56839
2011-02-09 13:12:38 +00:00
Hannes Janetzek f56fe34d97 do not crop labels at bottom: add extra space in icon-view mode
SVN revision: 56821
2011-02-08 21:30:48 +00:00
Hannes Janetzek b7cfdd21f1 fix loop in fm favorites view: delete .desktop for non existing device
SVN revision: 56715
2011-02-04 20:33:30 +00:00
Carsten Haitzler 5683f1b65c and fix mounty to be SAFE woth udisks.
SVN revision: 55994
2011-01-08 18:18:17 +00:00
Mike Blumenkrantz c2f5922c89 fix segv when using udisks to mount during ipc reads
SVN revision: 55989
2011-01-08 06:04:32 +00:00
Mike Blumenkrantz ef105564ba with this commit, udisks mounting is now fully functional (wfm!) and has a number of benefits over the HAL backend, such as being able to automount media that's in your fstab
dev notes: changes to efm were required for this to work since udisks doesn't report back a mount point upon executing a mount command, so the actual dir listing/display must
be delayed by another callback until we actually know where the disk is to avoid opening a random directory


SVN revision: 55916
2011-01-06 01:35:41 +00:00
Mike Blumenkrantz 23e9a844ff remove random semicolon?
SVN revision: 55901
2011-01-05 19:42:24 +00:00
Mike Blumenkrantz 6221397e99 fix annoying comparison is always true warning
SVN revision: 55862
2011-01-05 05:39:30 +00:00
Christopher Michael 27819e0780 Add missing UNUSED where needed.
SVN revision: 55769
2010-12-29 16:42:46 +00:00
Mike Blumenkrantz d3bcd46f2b avoid garbage deref
SVN revision: 55725
2010-12-23 00:24:16 +00:00
Sebastian Dransfeld 4d602b28e9 Listen for icon theme changes
SVN revision: 55683
2010-12-21 08:42:30 +00:00
Gustavo Sverzut Barbieri 6f2213cb25 convert init/shutdown to EINTERN, move some to _update().
Do not abuse the concept of e_*_init(), make them call-once and those
that needed multiple call are renamed to e_*_update(). To make sure
convert them to EINTERN so the symbols are not exported.

Actually I guess too much is exported as EAPI while they should be
EINTERN, but that would require manual investigation, while this patch
was basically created with sed + grep.



SVN revision: 54795
2010-11-22 15:21:32 +00:00
Sebastian Dransfeld 3d1a299e06 Let efreet icon return const
We return a pointer to an internal cache, so no need to do strdup. I we
implement a cache, the pointer will be a return from a mmap'ed file, so
no need to do strdup.

A bit late to do an API break, but must be done.

SVN revision: 54372
2010-11-09 20:15:55 +00:00
Sebastian Dransfeld ea2d3ab0eb Cleanup icon up handling
It seems that originally the "selected" event wasn't to be fired on dirs
during single click. This makes it impossible for fwin to open a new
window when single clicking a dir, so some ugly hacks has been added.
"The right fix (tm)" is to always emit "selected", even on dirs, and let
the listener decide what to do with the file.

SVN revision: 54229
2010-11-06 15:15:21 +00:00
Sebastian Dransfeld 889876d851 Only call "selected" on dirs
This fixes bug #593

SVN revision: 54228
2010-11-06 14:44:37 +00:00
Sebastian Dransfeld 3c12d4daba __UNUSED__ last
SVN revision: 54193
2010-11-05 18:40:31 +00:00
Mike Blumenkrantz fc78801dd8 should fix desktop icon text shortening
SVN revision: 54137
2010-11-03 21:59:56 +00:00
Mike Blumenkrantz 745e9031ea more vars that should be ints
SVN revision: 54136
2010-11-03 21:46:10 +00:00
Mike Blumenkrantz a8fb965995 fix some vars that should be ints after all
SVN revision: 54135
2010-11-03 21:31:44 +00:00
Mike Blumenkrantz de632e8367 run #2 of ecrustify, plus a manual edit to correctly make a function pointer
* now aligns with function prototype name, a couple other tiny spacing fixes


SVN revision: 53798
2010-10-23 06:05:03 +00:00
Mike Blumenkrantz 475ab010c1 dunno how that snuck in
SVN revision: 53784
2010-10-22 20:36:38 +00:00
Mike Blumenkrantz 76224aeb9e this is a rather large stress test of the improved version of uncrustify+config that I have been working on
as far as I can tell, it's perfect for non-headers

header example following as soon as I finish making it space EINA_XYZ() args properly


SVN revision: 53774
2010-10-22 17:07:41 +00:00
Miculcy Brian dd641e9259 New categories for modules.
To be continued soon...


SVN revision: 53514
2010-10-17 17:33:44 +00:00
Mike Blumenkrantz 33f0bae5cb e_fm2_dbus prefix is now e_fm2_device for upcoming seamless integration with eeze
SVN revision: 53328
2010-10-13 02:53:25 +00:00
Carsten Haitzler 5f713c865b fix... gah. formatting mess there.. and the real problem
using str1 == str2 instead of strcmp assuming all strings are
stringshared. dont ASSUME this unless you 100% KNOW for sure they are.

bad disco stu!



SVN revision: 53128
2010-10-07 00:04:19 +00:00
Mike Blumenkrantz 04662b3565 complete rewrite of all includes and file splitting to completely abstract dbus out of efm
SVN revision: 53051
2010-10-05 06:33:23 +00:00
Mike Blumenkrantz 29336de90d more function protos to typedefs, add E_Fm_Cb(void *data, Evas_Object *obj, E_Menu *m, E_Fm2_Icon_Info *info) for casting
SVN revision: 53044
2010-10-05 06:32:59 +00:00
Mike Blumenkrantz 97f27a269c switch lots of efm vars to bool bitfields
SVN revision: 53042
2010-10-05 06:32:51 +00:00
Lucas De Marchi 25113159a5 Fix common misspellings
Some misspellings were manually reverted since in E there are tons of .po with
phrases in other languages. Other than that all the changes in the following
files were reverted:

 * src/modules/illume/dicts/English_(US).dic
 * src/modules/illume-keyboard/dicts/English_(US).dic


Following misspellings were fixed:

acquited->acquitted
adres->address
adress->address
alreayd->already
aquire->acquire
arbitarily->arbitrarily
cant->can't
Capetown->Cape
carefull->careful
causalities->casualties
Celcius->Celsius
certian->certain
commandoes->commandos
considerd->considered
conveyer->conveyor
dependant->dependent
didnt->didn't
discontentment->discontent
doesnt->doesn't
everytime->every
exemple->example
existance->existence
existant->existent
existince->existence
Farenheit->Fahrenheit
forbad->forbade
funguses->fungi
guage->gauge
guerilla->guerrilla
guerillas->guerrillas
happend->happened
hasnt->hasn't
heros->heroes
inbetween->between
independant->independent
inital->initial
intrusted->entrusted
irregardless->regardless
isnt->isn't
knifes->knives
layed->laid
loosing->losing
marrage->marriage
midwifes->midwives
miniscule->minuscule
monickers->monikers
mroe->more
noone->no one
occured->occurred
omre->more
paralell->parallel
payed->paid
planed->planned
quitted->quit
quizes->quizzes
seperated->separated
seperate->separate
shoudl->should
similiar->similar
simplier->simpler
specifiying->specifying
teh->the
toke->took
torpedos->torpedoes
Tuscon->Tucson
unecessary->unnecessary
useage->usage
usefull->useful
useing->using
waht->what
wanna->want
whith->with
wich->which
withing->within




SVN revision: 52006
2010-09-08 23:59:07 +00:00
Miculcy Brian 586632efd1 allow to directly edit .desktop files
SVN revision: 51761
2010-08-30 17:54:18 +00:00
Lucas De Marchi 63f07459a0 Convert (hopefully) all comparisons to NULL
Apply badzero.cocci, badnull.coci and badnull2.cocci

This should convert all cases where there's a comparison to NULL to simpler
forms. This patch applies the following transformations:

code before patch               ||code after patch
===============================================================

return a == NULL;                 return !a;

return a != NULL;                 return !!a;

func(a == NULL);                  func(!a);

func(a != NULL);                  func(!!a);

b = a == NULL;                    b = !a;

b = a != NULL;                    b = !!a;

b = a == NULL ? c : d;            b = !a ? c : d;

b = a != NULL ? c : d;            b = a ? c : d;


other cases:

a == NULL                         !a
a != NULL                         a




SVN revision: 51487
2010-08-21 13:52:25 +00:00
Christopher Michael 4804fe3eb3 Add UNUSED.
SVN revision: 51346
2010-08-18 20:59:17 +00:00
Lucas De Marchi 6638a10e20 FORMATTING
* Remove vim modelines:
 find . -name '*.[chx]' -exec sed -i '/\/\*$/ {N;N;/ \* vim:ts/d}' \{\} \;
 find . -name '*.[chx]' -exec sed -i '/\/[\*\/] *vim:/d' \{\} \;

* Remove leading blank lines:
 find . -name '*.[cxh]' -exec sed -i '/./,$!d'

If you use vim, use this in your .vimrc:
set ts=8 sw=3 sts=8 expandtab cino=>5n-3f0^-2{2(0W1st0



SVN revision: 50816
2010-08-04 16:57:32 +00:00
Lucas De Marchi d8dc2a9511 Remove unneeded code with notnull.cocci script
This continues previous commit with more complex places, where it required
more than just removing some "ifs".



SVN revision: 50242
2010-07-14 02:20:30 +00:00
Cedric BAIL c6a118d738 * e: remove warning due to Ecore API change.
SVN revision: 49833
2010-06-24 16:19:12 +00:00
Mike Blumenkrantz 492178f1b2 add header, fix compile warning when printing int64 (use PRIi64)
SVN revision: 49388
2010-06-02 03:23:49 +00:00
Hannes Janetzek 702218034b check strings not null
SVN revision: 49230
2010-05-27 12:45:41 +00:00
Carsten Haitzler 12c8a33b11 fix segv with removable devices!!!! decode forced strdup/free etc... but rest
of code assumed stringshare.



SVN revision: 48546
2010-05-02 12:05:56 +00:00
Chidambar Zinnoury 94fe8e9020 EFM: on [↑] or [↓] key, use the same distance function for "normal" view modes as for "custom" view modes so that selection doesn't get jumpy.
SVN revision: 48542
2010-05-02 07:03:32 +00:00
Gustavo Sverzut Barbieri 4cd34cc5e8 NEVER, EVER should modify the stringshared pointer.
That is why stringshare returns "const char*".

ZMike, pay attention to these cases. I know this one was particularly
nasty to spot since you receive the "const char *path", but later on
you request strrchr(path..) and receive "char *p", the cast is done
implicitly by libC to make all the case works (C++ version fixed this
recently, but in C there is no way).

The crash that lead me to investigate it was spot by Lucas De Marchi
at advanced wallpaper dialog, but actually other places that uses efm
should be equaly broken.



SVN revision: 48508
2010-05-01 16:02:03 +00:00
Mike Blumenkrantz 9d40d66091 step 3: migrate all function and variable names to generic dbus naming
SVN revision: 48488
2010-04-30 19:14:20 +00:00
Mike Blumenkrantz 5c598d1a78 beginnings of the ukit migration. this time, in many many many small commits along the way to avoid breaking things! :)
step 1: migrate *hal* files to *dbus* files


SVN revision: 48463
2010-04-30 08:38:08 +00:00
Mike Blumenkrantz a6c5618f69 finish char* to const char* conversion
SVN revision: 48461
2010-04-30 08:17:53 +00:00
Mike Blumenkrantz 5aa48ed402 fix more broken stringshare stuff from ehal memory migration, including incredible lines such as
char *udi = eina_stringshare_del(udi);
my bad, I really fudged the bucket on this one guys.


SVN revision: 48416
2010-04-29 10:17:41 +00:00
Mike Blumenkrantz 97da075d67 ukit integration taking way longer than expected, so I'm fixing all the stringshares now. should be safe to use. hooray.
SVN revision: 48414
2010-04-29 08:58:38 +00:00
Carsten Haitzler aadcae0b20 be lenient on uri';s allow boring full paths.
SVN revision: 48380
2010-04-28 03:30:48 +00:00
Sebastian Dransfeld 02b6e4db39 Ecore_Str.h -> Eina
SVN revision: 45740
2010-01-30 22:11:11 +00:00