Carsten Haitzler
6b64e40122
e - e client, comp win etc. reffing fix ... part 2
...
this follows 56cabf59c64e5521b4d8
2015-06-15 20:27:25 +09:00
Carsten Haitzler
56cabf59c6
e - bring back fullscreen crash bug while fixing refcount correctness
...
refs were inconsistent - thus this fixed the fullscreen quit bug by
never freeing a client. this brings the bug back by fixing this client
leak. i'll look again at this later.
2015-06-14 19:16:09 +09:00
Carsten Haitzler
4e5521b4d8
e comp - fix refcounting for e_comp and comp clients
...
the refcoutning for e_comp and e comp clients seemed to be a bit off -
i read over every ref and unref carefully and fix it. this leads to
the com-_data being null (properly now), so now check for that too.
2015-06-14 16:06:37 +09:00
ba39887b26
rename visibility effect struct member effect -> visibility_effect
...
feeble attempt at making future added effects more intelligible
2015-06-11 12:47:04 -04:00
ef5bfbad26
add compositor visibility effects and matching configuration
...
these are specific types of animation for use when toggling window visibility.
they combine with existing compositor window animations to provide nicer integration
for very specific types of windows
see https://www.youtube.com/watch?v=hIVdd0Z2K00 for a demo
2015-06-11 11:35:44 -04:00
7f63c4ec2d
allow comp matching for UNKNOWN type windows
...
sometimes this is a valid type and we want to match it
2015-06-11 11:33:45 -04:00
38670e0553
disable animations on clients during hide
2015-06-08 14:47:42 -04:00
424bdf93be
only freeze/thaw edje objects on non-input clients
2015-06-08 14:46:33 -04:00
0a94e8ba71
enlightenment: Make E build again with EFL from git
...
sed -i 's/EAPI/E_API/g'
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-05-07 15:13:10 -04:00
2e0bb7dc36
freeze comp object edjes while not hidden
...
requested by cedric
2015-04-29 12:55:42 -04:00
0d439345c1
set focus on comp autoclose objects
...
fix T2114
2015-04-27 13:20:52 -04:00
b9c4171ab1
do not pass key events through autoclose handler
2015-04-27 13:04:53 -04:00
b825af34cf
use client geom for comp object centering functions if ec->new_client is set
2015-04-21 15:05:25 -04:00
db9348c16f
do not attempt to re-center fullscreen/maximized internal windows
...
fix T2279
2015-04-13 15:39:30 -04:00
58447e9508
completely remove E_Manager
...
the final step in flattening all the canvas/screen apis
2015-03-19 16:53:32 -04:00
d4c0a663cf
only throw frame object size CRI for X comp objects
2015-03-17 16:15:23 -04:00
1736d1ecb9
e_client functions no longer require E_Comp param
2015-03-13 16:53:19 -04:00
d00127c2f5
e_comp functions no longer require E_Comp param
2015-03-13 16:48:41 -04:00
1fe1c94245
comp canvas functions no longer require an E_Comp param
2015-03-13 16:07:08 -04:00
2461c6b50d
remove unnecessary E_Comp references in comp object callbacks
2015-03-13 15:49:04 -04:00
091142b032
remove E_Client->comp
2015-03-13 15:41:21 -04:00
96b13f2620
remove E_Comp_Object->comp member
2015-03-13 15:28:42 -04:00
Carsten Haitzler
03f05d16e5
e clients - make sure we handle client with a NULL zone
2015-03-11 18:34:38 +09:00
567802f251
fix crash when using e_comp_object_util_center_pos_get() with non comp_objects
2015-03-06 17:59:43 -05:00
08b9194c12
don't require client mirror object existence to hide dead comp object mirrors
2015-03-05 14:57:49 -05:00
02134369c0
only hide comp object images for dead clients on smart hide
2015-03-05 12:44:27 -05:00
b9f797a277
flag non-internal wl shm clients as dead and delete mirrors on hide
...
no more crashing?
2015-03-05 12:18:27 -05:00
6696c99a26
trivial move comp object function
2015-03-05 12:18:06 -05:00
caddd0f1d5
hide comp object image on smart hide
...
ensure that this is not being rendered anywhere at the time of hide
2015-03-05 11:56:26 -05:00
ac7a94261a
never resize client clip object
2015-03-04 17:07:39 -05:00
9dee41f1a3
do not reapply focus on canvas object ungrab/close for pointer-focus enthusiasts
2015-02-20 09:55:20 -05:00
baa9cfeac1
don't send unfocused signal to override clients
...
fix T2099
2015-02-18 16:35:10 -05:00
6e504751b1
revert some comp object debugging bits that snuck into another commit
2015-02-17 17:21:37 -05:00
Vincent Torri
f31ed5bcb1
add MIN define for non-linux systems
2015-02-15 17:54:10 -05:00
fff95929c6
apply client focus glow based on opaque region
2015-02-10 18:08:39 -05:00
d97c6b04bb
redo pixmap image border to take xywh instead of lrtb
...
client size is not set by the time opacity is set so it's necessary to store the full rect
2015-02-10 18:07:41 -05:00
362a505567
set client image borders even when 0
...
opaque region can be reset to nonexistent
2015-02-10 16:40:12 -05:00
b0ef692817
handle image borders during client rendering
2015-02-09 21:14:18 -05:00
256378577c
Revert "ref/free client pixmaps during hide animations"
...
This reverts commit bbb04ecb32
2015-02-02 17:40:11 -05:00
bbb04ecb32
ref/free client pixmaps during hide animations
...
replaces wl client crashing with a garbage frame
2015-02-02 13:38:48 -05:00
44229f20bd
clean up comp object to not use deprecated comp functions
2015-02-02 12:12:12 -05:00
Carsten Haitzler
33d4531f1d
e - rewrite randr code entirely. core and dialog. dialog is basic atm
...
the dialog for now is simple and lets you just raw edit the properties
per screen in a dialog. nothing fancy. not user firendly. but it works.
the randr core has been totally rewritten and tested against a range
of drivers and setups before even getting a commit. it works solidly
and configures screens reliably now. drivers tested:
nvidia
intel
radeon
some drivers still are unreliable in terms of delivering plug/unplug
events for outputs (both intel and radeon are flakey - nvidia is solid
and reliable). so to fix this there is now a screen redo action you
can bind to a hotkey or something and have e re-evaluate current
screen setup and apply ny pending config if needed.
also to make reconfiguring prettier the screen is faded to black
first, then configured, then faded back in. some drivers work
flawlessly with this, others still flicker some garbage.
i admit - i haven't tested nouveau, but my general take on this is the
randr code is now in far better shape than where it was (minus pretty
and easy dialog). the dialog can be done next, but i'd like to get the
core in now for more testing.
@fix
2015-01-25 22:50:23 +09:00
b0a9d64000
allow client pixmap size to be used in place of actual client geom for tiler creation
2015-01-23 17:20:52 -05:00
a5c00bfb2b
defer client frame resizes if client is not protocol-visible
2015-01-23 17:20:14 -05:00
189763cde3
force internal window recentering after resize when no move/resize is active
2015-01-14 14:47:54 -05:00
66f28829a1
don't change shade.x/y during unshade or after shade
...
fix T1930
2015-01-08 18:23:05 -05:00
41f4f28114
comp pending resizes should not require both w+h to change
2014-12-30 17:00:23 -05:00
ac7bf5fe32
greatly reduce FAILURE_MAX
...
ref T1820
2014-12-08 17:03:23 -05:00
28d6eecceb
reduce shape recalc for clients which cannot currently receive input
2014-12-07 20:17:33 -05:00
610c439abd
redo shaped client checks to use shape flags instead of rect pointer, fix shapeless clients
...
according to the shape extension protocol, the number of rectangles returned should be checked to determine a client's shape. if 0 is returned, the client has no shape, meaning that it either should not be drawn or should have no input region. this improves behavior with various client window types such as tooltips
ref T1820
2014-12-07 20:17:33 -05:00
634b58773a
add failure count for client rendering, drop clients after FAILURE_MAX tries
...
this traps clients which are showing and hiding themselves extremely quickly and prevents them from crashing us when we try to draw them
fix T1820
2014-12-07 20:17:33 -05:00
3e50ac6e27
ensure clients are visible before triggering shape/render queue
2014-12-07 20:17:33 -05:00
ce49f2a1f0
only change internal win visibility on comp obj show if win not already visible
2014-11-22 12:46:50 -05:00
99589eb5af
remove E_Win+e_canvas, convert all internal wins to use elm_win
...
known issues:
* keybindings for efm windows (eg. ctrl+w) are broken until the rest of the conversion is completed
2014-11-20 15:26:21 -05:00
57b5fd4d44
force comp render queue more aggressively to detect changes in nocomp
2014-09-23 10:31:04 -04:00
3aaa843a4f
comp render queue on every client resize instead of on unmaximize
2014-09-23 10:31:04 -04:00
ec1cd25cfe
rename E19* defines/texts to just E so they don't need to keep being updated
2014-09-09 12:30:50 -04:00
93e0dd20c0
add docs for all the comp_object data keys
2014-09-07 12:49:19 -04:00
5733e7b3f7
non-client comp object creation checks "noshadow" edje flag on passed objects
...
returns theme functionality from e17
2014-09-03 09:46:27 -04:00
8a10f288ad
use a non-conflicting data item for comp mirror creation
2014-09-01 14:22:44 -04:00
74c3e0a979
shorten rendering path when creating comp mirrors from comp mirrors
2014-09-01 13:55:02 -04:00
77c63e0387
redo comp object util refs to be more consistent and not break evas
2014-09-01 10:30:53 -04:00
cef6ebd2db
fix post-effect stacking BITCH and post-effect transient stacking
2014-08-26 09:45:04 -04:00
d654f880a1
fix e_comp_object_client_get() when used with signal callback
2014-06-16 13:35:57 -04:00
04a8f58ff9
remove useless null checks
...
CIDs 1155278, 1155289
2014-06-10 20:40:47 -04:00
5ad876ccad
block mouse actions on frame for iconic clients
...
fix T1069
2014-06-08 12:13:02 -04:00
3f9af38da2
edje: remove use of deprecated functions.
2014-06-07 21:10:55 +02:00
dbce413b42
fix shape cutting for frames which are larger than their object size implies
...
requires border themes to have data.item "frame_extends" set
2014-06-04 08:55:06 -04:00
d8aa488096
completely revert all eo/eolian usage
...
this was a neat experiment, but apparently it's not going to be usable for a long time in anything outside efl/elm
This reverts commits f87b9900faa49cede79081038f8d0247cfb31752
2014-06-04 07:27:50 -04:00
f87b9900fa
Update code to use the new class names generated by eolian.
2014-06-03 11:55:02 +01:00
1a492e3786
ignore fake client resizes during shade
...
fix T1314
2014-06-02 16:25:47 -04:00
73f35d8444
check current client size before rejecting resize
...
moderately certain this will fix T993 and also probably fix T1053
2014-06-02 08:42:32 -04:00
c55e16dcb4
fix wl crash with layer_block
...
D920
2014-06-02 07:20:50 -04:00
a49cede790
add class type check where client layer marker is taken
...
Summary:
it fixes crash when running wl client apps on e wayland server.
invalid comp object pointer value is returned by using eo_data_scope_get.
thus eo_isa should be added before eo_data_scope_get.
Test Plan:
1. run e wl server
2. run wl client terminlogy
3. run second wl client elementary_test
Reviewers: raster, devilhorns, zmike, stefan_schmidt
CC: cedric
Differential Revision: https://phab.enlightenment.org/D919
2014-06-02 07:16:42 -04:00
1a4b0bf29c
Revert "fix relative stack object check"
...
This reverts commit b3efbfb91d
2014-05-29 12:20:38 -04:00
b4e4214e5c
ensure client is actually stacked below the above-client when raising
2014-05-29 12:19:43 -04:00
e84eb965f4
remove unused variable use and function call
...
Reviewers: raster, zmike
CC: cedric
Differential Revision: https://phab.enlightenment.org/D867
2014-05-19 15:56:01 +09:00
3c416438b0
fix enlightenment crash by accessing null pointer.
...
Summary: e_client_below_get can return null, so added null check code.
Reviewers: raster, zmike
CC: cedric
Differential Revision: https://phab.enlightenment.org/D857
2014-05-14 09:09:30 -04:00
b3efbfb91d
fix relative stack object check
2014-05-10 17:18:08 -04:00
5434656751
add check for stacking errors in non-release builds
2014-05-10 17:18:08 -04:00
81038f8d02
fix some smart_data_get stragglers in comp object
2014-05-10 17:18:08 -04:00
fdeb104733
comp can only set native surface with gl, so only try setting based on gl
2014-05-10 17:18:08 -04:00
1d9a94c7e9
remove duplicated code
...
Summary:
this patch removes duplicated code.
the event handler of "focus in/out" already added above it.
Reviewers: raster, zmike
CC: cedric
Differential Revision: https://phab.enlightenment.org/D816
2014-05-02 06:48:28 -04:00
69e39063dd
e_comp_object: update xy position of client in intercept_move to avoid unwanted first damage if given client is not a new_client
...
Summary:
xterm and pcmanfm windows shows black area if e is running with sw engine mode. (T1180)
In this case, there are two problems:
1. Unwanted geometry info of first damage by wrong window move in intercept_move.
(a) Handle x map request
(b) Initialize client_inset value of comp object according to geometry value of "e.swallow.client" part
(c) Set client_inset value to cw->client.x and y in intercept_move
(d) Call ecore_x_window_move_resize with wrong x and y at idler
(e) Create x damage
(f) Handle unwanted damage notify event which has position values same as client_inset.
(g) Copy image contents from pixmap according to wrong area info of damage notify and render it on screen.
2. Problem of override redirect window
Black area of pcmanfm's menu is related to override redirect window.
This patch only covers 1st problem not 2nd problem.
The override redirect window should be fixed by another way.
Test Plan:
1. Run e with sw engine mode or run x-ui.sh in e git simply
2. Run xterm which is using classic x drawing api
3. Check client window area of xterm
Reviewers: raster, zmike, devilhorns
CC: cedric
Differential Revision: https://phab.enlightenment.org/D795
2014-04-25 12:50:47 -04:00
ffcc5e72d9
null check ecstack
...
Summary: fix segmentation fault error
Test Plan:
run enlightenment (wl only server) -> run elementary_test -> run terminlogy
-> move cursor to elementary_test -> click on elementary_test
Reviewers: raster, devilhorns, zmike
CC: cedric
Differential Revision: https://phab.enlightenment.org/D770
2014-04-18 12:51:36 -04:00
b49957bf9b
preserve client stacking after compositor effects
...
fix T1065
2014-04-10 19:01:50 -04:00
47cfb31752
comp_object now uses eo, e_comp_object_signal* -> edje_object_signal*
...
also cw->clip is gone
2014-04-10 19:01:47 -04:00
95a8fed0bf
unify comp object stacking
...
these were nearly identical, and sooner or later there was going to be an unfortunate c/p error
2014-04-02 14:16:34 -04:00
cfe26ff838
comp docs part 1: comp objects
2014-04-02 13:06:28 -04:00
b9e6a624ef
fix frame size calc check to account for themes with 0 height
2014-04-02 12:31:33 -04:00
3f2efbc548
fix client layer marker detection/usage in wayland
...
this is the correct fix for D687
2014-04-02 11:07:22 -04:00
597aec1710
remove unused comp object variable use and function call in show helper
...
Reviewers: zmike
Differential Revision: https://phab.enlightenment.org/D686
2014-04-02 09:27:20 -04:00
ea3439b664
Revert "move comp object tiler creation to helper function to catch retries"
...
This reverts commit f4e4b2fc4f
2014-03-27 17:01:22 -04:00
f4e4b2fc4f
move comp object tiler creation to helper function to catch retries
2014-03-27 16:47:19 -04:00
53824eb309
redo input rects after comp effect layer changes
...
fix T1070
2014-03-27 16:47:18 -04:00
42f43c9311
disable comp object animation hooks if animations are disabled
2014-03-27 16:47:18 -04:00
daa98e867d
fix lots of edje emits on non-edje objects
2014-03-27 16:47:18 -04:00
c47bf94cdf
hook sticky smart callbacks properly inside comp object
2014-03-20 11:38:58 -04:00
915f8f0613
@bugfix: Fix building for WAYLAND_ONLY by using the proper define
...
sed -i 's/WAYLAND_ONLY/HAVE_WAYLAND_ONLY/g'
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-03-18 07:43:04 +00:00
Carsten Haitzler
ad6aa3db71
part of previous commit - also set delete_requested to 0
2014-03-15 00:00:27 +09:00
Carsten Haitzler
b1373fe63f
fix hiding of windows when delete is requested
...
this is applicable to e19 only (you can't backport this patch as-is -
e19 is too different). this fixes T1063.
2014-03-14 16:25:14 +09:00
63b01101ee
fix comp util object initial visibility
2014-03-05 10:53:05 -05:00
851ef43c41
force comp render on dirty for hidden objects with visible mirrors
2014-03-05 10:08:09 -05:00
9ad04eb877
redo client urgency again with separate flag for actual urgent state
...
preserve icccm flag for accurate detection
2014-03-05 10:08:09 -05:00
8568a76313
always set iconic client comp state as visible
...
pass: init_states
2014-03-04 15:20:24 -05:00
41c4cded01
send unmaximize signal when unfullscreening
...
fix T1044
2014-02-28 14:55:27 -05:00
78403e2f54
don't reshadow on client redirect
...
fix T1019
2014-02-27 20:31:18 -05:00
c01a1fcc6c
manage comp overrides for comp objects
...
fix T1019
2014-02-26 11:46:32 -05:00
f75a923ab0
break out client focus reset into separate function
2014-02-21 16:44:12 -05:00
63d6153d86
reject comp autoclose refocus during comp input grabs
2014-02-21 16:44:12 -05:00
71bfe06bb3
fix debug format string
2014-02-21 16:44:11 -05:00
1a3e86c3c9
fix race condition when repeatedly resizing clients too fast
...
T993
2014-02-21 16:44:11 -05:00
ef360e1684
resize damage tiler on resize
...
this fixes render races which occur when damages and resizes happen in quick succession
2014-02-17 19:11:33 -03:00
b317bedf5a
remove comp object dirty flag
...
this logic was useful for another issue which has since been fixed. it currently only serves the purpose of triggering a race condition crash which I do not enjoy.
2014-02-17 16:21:02 -03:00
bbf29c6a2a
only set want_focus for non-hidden clients when deferring focus setting
...
T950
2014-02-14 14:56:16 -05:00
494e6bc5ee
another revision for client geometry resets: take new geometry instead of ignoring it
2014-02-14 13:43:15 -05:00
09cb41f1dc
only reset move/resize attempts if the pending move/resize is different than the current one
2014-02-13 22:46:48 -05:00
d80dbc1a35
add maximize_override client flag
...
sometimes you just want to do stuff on a client without any maximize logic applying!
2014-02-12 20:37:52 -05:00
7571ccb2d8
reapply geometry and unset post flags when a client intercept gets the current geometry
2014-02-12 19:50:50 -05:00
6802ae750d
send smart object to comp effect end cb
2014-02-11 22:29:34 -05:00
449ec43d1f
size comp zoomap child to pixmap, not client
...
this affects nothing
2014-02-11 21:45:04 -05:00
c3ce56c1dc
it's possible that a comp effect has no post-effect callback
2014-02-11 18:40:22 -05:00
bf48616a47
remove shadow check from shape apply
2014-02-11 18:40:02 -05:00
d9be56ad41
add smart callback on comp object for shadow change
2014-02-11 18:39:51 -05:00
e895d86839
set comp mirror alpha the same way as objects
...
T928
2014-02-10 09:54:01 -05:00
722b18de9a
set precise_is_inside based on shaped || shaped_input
2014-02-10 09:48:13 -05:00
a78d98700a
apply shadow states during theme setup
...
T885
2014-02-10 09:12:43 -05:00
6524711e68
set comp theme object shadow state to off during setup
...
T907
2014-02-06 20:52:31 -05:00
446eb19653
use regular edje signal emit on regular edje objects
2014-02-06 20:51:58 -05:00
3499f454bd
fix signal callback deletion in comp effect start
2014-02-05 20:52:20 -05:00
a16f820f95
only ignore protocol stacking if comp object is on a different layer
2014-02-05 13:05:05 -05:00
eba912cf6a
e_client_resizing_get() -> e_client_util_resizing_get()
...
functions in e_client.x should be namespaced with e_client_util to indicate that they are inline (and in e_client.x)
2014-02-05 10:51:36 -05:00
4eae850861
e_util_client_shadow_state_get() -> e_client_util_shadow_state_get()
...
removals: e_util_client_shadow_state_get
2014-02-05 10:48:31 -05:00
27768fcb03
guarantee comp shadow is off when frame exists
2014-02-05 10:48:01 -05:00
cd37f23632
allow shadows on borderless, non-argb, non-shaped clients
...
T885
2014-02-04 22:27:23 -05:00
de9dde6daf
remember comp object dirty state and update when necessary
...
normal clients rely upon the guarantee that they will receive another resize on next render when size updates occur before visibility happens, but overrides will never receive another resize since they always size accurately. by remembering that the state was previously considered dirty, render updates which occur before visibility are no longer lost until the next damage/resize occurs
tl;dr: your menus show up again
2014-02-03 14:00:12 -05:00
3125c3a674
fix more misuses of comp animating flag
...
this should even things out permanently here and ensure things get deleted when they should
related: T879
2014-01-30 12:12:01 -05:00
1d22c527a3
force comp reshadow after pixmap fetch succeeds, not during setup
...
reshadowing earlier than this makes it very likely that client attributes have not been fetched, meaning that the match will fall through to a default type match instead of using the correct one
2014-01-30 12:12:00 -05:00
49cfe28719
use object list for comp matching internal objects
2014-01-30 12:12:00 -05:00
8e6cd13766
fix some misuses of comp animating flag
...
T879
2014-01-30 06:59:11 -05:00
5a2aab8457
reject stopping comp object effect if wrong end_cb is passed
2014-01-30 06:55:14 -05:00
db01319aee
ref client itself during comp object add event
2014-01-29 21:12:07 -05:00
9b36b9b78c
remove comp iconify hacks (and e_iconify api), expand comp object effect api
...
instead of adding specific handling which will work (sometimes) in one specific case, expand already-existing api to provide the needed functionality for iconify animations. now on emitting any signal to a comp object, optional glob-able effect providers can be hooked and prioritized to add effect animations
also use animating flags now when applying an object effect
a base effect is provided in elementary, but now each module which wants to hook iconify animations (or other events) can do so in the theme and have different animations with their module
2014-01-29 13:36:42 -05:00
e5bbb98918
don't reset focus to iconified clients on autoclose delete
2014-01-29 13:36:42 -05:00
c4afece1a3
revert 8b62039e6a, use existing layer_block flag
2014-01-29 13:36:41 -05:00
Carsten Haitzler
8b62039e6a
support temporary layer changes for iconify anim purposes
2014-01-29 22:42:54 +09:00
Carsten Haitzler
1ede2a5632
iconify provider - the ability to provide geometry for src/dst of iconify
...
ibox now uses this as an initial test. there are teething problems:
1. unknown location for new icon (guess that its on right)
2. stacking - the animation is at the stacking layer of the comp obj
... this probably needs a way for the comp shobj to request a
temporary stacking change until anim done
2014-01-29 22:42:54 +09:00
cd2cde6477
clean up client delete+unfocus
...
previously there were cases where client focus was not explicitly unset on delete, which resulted in expected client hooks not being called and minor inconveniences to occur
2014-01-27 10:58:41 -05:00
de58ff7ecd
only hide/delete comp util objs if hiding flag is set
...
if an object is shown during the hide animation, this flag gets unset
2014-01-27 10:58:40 -05:00
6effdae157
fix comp util adding of already-visible objects
...
this fixes pager popups which don't use the new style of popup adding
2014-01-27 10:58:40 -05:00
Carsten Haitzler
Mike Blumenkrantz
Chris Michael
Vincent Torri
Mike Blumenkrantz
Cedric BAIL
Tom Hacohen
Gwanglim Lee
Seunghun Lee