Commit Graph

12785 Commits

Author SHA1 Message Date
Carsten Haitzler f6e4be1005 e wl screen dimming.blanking/timeouts/lock handling redo/fixup
so there was a fair bit of stick-tape and chewing gum in putting the
wl screensaving in e_Screensaver.c ... it thus was very different to
the x stuff. it SHOULd have had e_comp_wl handle idle timeout like the
xserver did and then glue in the same way the x code did to be
conistsent. instead of trying to fix the chewing gum ball there in
e_Screensver.c to find the logic holes ... i made it work like the
code as indicated above. this now makes it work reliably. dim
reliably. lock reliably. it even doesnt exit on ctrl+alt+backspace
once desklock is up now to allow locks to really lock... (dont use
locks during dev then if you need ctl+alt+backspace).

at least now all this dpms/screensavwr/brightness/backlight/lock goop
is consistent between wl and x11 and wl seems reliabkle now (to me).

knock this off as an annoyance fixed.

@fix
2020-06-28 15:06:37 +01:00
Alastair Poole 8cc3bd7cdb e_start_main: Guard against malloc.h on BSD.
This fixes a build break on FreeBSD. Guarding as per other
blocks. These guards can be removed at a later stage as OpenBSD
has removed malloc.h and FreeBSD is in the process of
reintroducing it after a failed attempt to deprecate the header.
For consistency's sake keep these blocks identical within the
tree. We can nuke these later when FreeBSD make their minds up.
2020-06-24 23:45:29 +01:00
Carsten Haitzler 21200cb2f7 e init - stop listening to zone changes once init has been hidden 2020-06-22 08:16:46 +01:00
Carsten Haitzler 2c9405b92f fix preload of e icon when already loaded to show new icon
didn't stack right always. had if (x) not if (!x) ...
2020-06-21 23:54:17 +01:00
Carsten Haitzler ddc9ff7280 randr - add response timeout config value 2020-06-20 01:50:03 +01:00
Carsten Haitzler e8f5794b81 e xsettings - do not use long for 32bit types... it's WRONG
long varies by architecture... whoever decided C32 should be long...
was totally wrong. it varies between 32 and 64bit (on unixen).

@fix
2020-06-17 13:21:13 +01:00
Carsten Haitzler b55fa736ed randr - add option to ignore disconnects on specific screens...
work around kvm's that like to disconenct screens... be able to force
an ignore on disconnects on specific screens.
2020-06-15 22:27:34 +01:00
Carsten Haitzler c4ab23511e fix null edid more - found hole missed in last fix
adds more fix on top 80f92ee486
2020-06-14 14:00:48 +01:00
Carsten Haitzler 1b5d229855 e - increase timeout for efreetd responding to 20 sec
it seems some peole suffer from an unusually long scan time so account
for that.
2020-06-14 12:09:43 +01:00
Carsten Haitzler ce66161874 init - handle zone changes during startup/init 2020-06-14 00:33:44 +01:00
Carsten Haitzler 3e31c9ebf8 precache - add more prints to see when thread spawns for info 2020-06-13 22:56:54 +01:00
Carsten Haitzler 18c522fb24 Revert "e randr - x - only apply/modify randr if xurrent config not the same"
This reverts commit cf0a43b844.

This seems to cause some issues on restore at startup.
2020-06-13 22:56:40 +01:00
Carsten Haitzler b519c44c67 pager+thumb - speed up thumb generation and pager aspect
pager didnt reset aspect after setting min size. fixed. also improve
thumb generation by having no artifical delays. use idle enterer + job
wakeups instead. now thumbs appear almost instantly.

also remove initial pager popup on starup that is just not needed.

fixes T8314
@fix
2020-06-13 16:22:07 +01:00
q66 fd9a798376 meson: fix fnmatch dependency lookup
The previous version didn't really make sense whatsoever, also
it was unused.
2020-06-11 02:44:55 +02:00
q66 9fc310db63 try linking against execinfo when execinfo.h is present
This should fix build on systems where execinfo.h is present
but the APIs are implemented in a separate library - commonly
a case on the BSDs as well as on non-glibc libcs and so on.
2020-06-11 02:37:26 +02:00
q66 6e87988071 e_util_suid: need signal.h on some libcs 2020-06-10 21:13:41 +02:00
Carsten Haitzler ed1d9ea62c e backlight - fix initial restore of backlight after previous fix
no edid fix broke initial restore. fix it.
2020-06-10 12:34:21 +00:00
Carsten Haitzler 80f92ee486 e backlight - handle screens with no edid
this fixes backlight support on my pinephone...

@fix
2020-06-10 11:05:13 +00:00
Carsten Haitzler a91ba4e1a8 exec - dont run null exec commands
fixes T7133

@fix
2020-06-09 22:11:32 +01:00
Carsten Haitzler 1aad79dbe7 init splash - make it default as it no longer needs an option
it used ot be a separate process to run to hide e starting in the bg
on a slow hdd loading modules etc. but due to compisitng and other
changes its all internal now, so keep it on always as it guarantees a
better smoother experience with less complexity to maintain.
2020-06-09 15:54:58 +01:00
Carsten Haitzler cf0a43b844 e randr - x - only apply/modify randr if xurrent config not the same
so if already the same - leave it as-is.
2020-06-07 00:57:13 +01:00
Carsten Haitzler 74815ebc9b e start - save 24k of stack that gets touched then never again.
use less stack with smaller "just big enough" alloca'd string buffers.
as e_start hangs around looking after e all day, using a bit less mem
is a good thing.

@opt
2020-06-07 00:54:57 +01:00
Carsten Haitzler 71b5cb3e7c xsettings - always use decimal for format for float prints
snprintf will use locale and maybe print 10,24 instead of 10.24 ...
thus use a custom routine to specially do this always by hand without
mssing with locale.

@fix
2020-06-05 11:21:20 +01:00
Carsten Haitzler 3fdd7d3118 e sys - also force e to exit on halt or reboot after a timeout.
also log more on what is going on...
2020-05-30 21:56:29 +01:00
Carsten Haitzler eb61b825e4 suspend/hibernate - add a small delay before doing the deed
allow any pending frames to pop out of the pipeline before we
sleep
2020-05-30 21:56:29 +01:00
Carsten Haitzler af63443e19 sys - fix non-systemd code patch for suspend/resume handling/tracking
so in the non-systemd case there was a current e sys action stored and
never cleared. e keeps thinking it is in the midddle of an action as
it was not cleared. the systemd code path was different and didn't
suffer from this. this fixes that so the non-systemd path works too.

@fix
2020-05-28 23:07:56 +01:00
Carsten Haitzler 596def7806 e system - storage - improve mount/umount code to enforce simple std
all dirs owned by root - so can't be exploited. this code is not
acessible at this point so no actual issues. it still needs testing.
until other work is done it won't be tested yet.

fixes T8671 further comments on umount check.
2020-05-28 11:24:32 +01:00
Carsten Haitzler a018f8273f e randr x - move pointer to a visible screen coord if outside screens
on reconfigure if we find the pointer outside the screen region bounds
it can get caught there until a warp forces it in. this is due to the
barriers i added i think. this fixes that

@fix
2020-05-27 14:17:07 +01:00
Carsten Haitzler 373b4c5ee1 e ckpasse - also back out another change i made to fix up pk 2020-05-27 09:24:24 +01:00
Carsten Haitzler fc89c4f78c e ckpasswd - clean some vars to be static and a fprintf status 2020-05-27 09:19:47 +01:00
Carsten Haitzler d8f1e63a75 back out undo of pk fix - back to bu5hm4ns version 2020-05-27 09:16:04 +01:00
Carsten Haitzler d2c0c1bf19 polkit - fix user id we're authing to and be explicit which one it is
@fix
2020-05-25 13:45:44 +01:00
Carsten Haitzler b16b2fac74 e auth - fix missing stderr output logs i missed last commit 2020-05-25 13:45:40 +01:00
Marcel Hollerbach 4475eb42a6 e_ckpasswd_main: fix polkit to auth root
there were the wrong pids passed.
This fixes calls like "systemctl start docker".
2020-05-25 14:39:25 +02:00
Carsten Haitzler e84dce7806 e auth - nicely prefix logs and clean up error reports and report more 2020-05-25 12:27:49 +01:00
Carsten Haitzler ac6ad8cb96 add debug printf (commented out) for frame requests 2020-05-23 09:35:44 +01:00
Carsten Haitzler fb5bcc24af remove base time - not needed anymore 2020-05-21 21:17:37 +01:00
Carsten Haitzler c742c011ae e wl - fix frame req timestamp to be the same as others
no others subtrace the base... weston doesnt.. no input events cb's
do... this is a mistake with what is a wrong timeline as a result. fix
and use the same timeline as everyone else

@fix
2020-05-21 21:11:14 +01:00
Carsten Haitzler 048470f888 xkb - optimize handling of keymaps to only change them a few times
also listen to all xkb events properly..

@fix
2020-05-19 18:51:03 +01:00
Elyes HAOUAS f84d23ffd2 Remove duplicated includes
Remove duplicated includes

Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11857
2020-05-19 13:06:21 -04:00
Elyes HAOUAS 44b029378a tree-wide: get rid of trailing whitespace (part 5)
Remove trailing whitespaces

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11824
2020-05-14 13:49:17 +02:00
Elyes HAOUAS cd5f79c814 tree-wide: get rid of trailing whitespace (part 4)
Remove trailing whitespaces

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11823
2020-05-14 13:49:15 +02:00
Elyes HAOUAS 2b1a72f3cb tree-wide: get rid of trailing whitespace (part 3)
Remove trailing whitespaces

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11822
2020-05-14 13:49:13 +02:00
Elyes HAOUAS b980034665 tree-wide: get rid of trailing whitespace (part 2)
Remove trailing whitespaces

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11821
2020-05-14 13:49:11 +02:00
Carsten Haitzler 4c52048f09 undo the client volume fix as it causes memory access issues.
reopen D8928

it looked good until i started having some apps start/stop audio a lot
with asan on - it was catching memory mis-accesses. definitely not ok
to have this in

Revert "e client vol - fix del-self in a del while deleting self..."
This reverts commit e78c8b6b5f.
Revert "e_client_volume: Update the e_client frame object on sink del event"
This reverts commit f4c1ba959e.
2020-05-14 12:10:24 +01:00
Carsten Haitzler e78c8b6b5f e client vol - fix del-self in a del while deleting self... 2020-05-14 11:41:55 +01:00
Elyes HAOUAS 3524bc167c tree-wide: get rid of trailing whitespace (part 1)
Remove trailing white spaces.

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11780
2020-05-14 12:30:31 +02:00
Thierry 2a96a8dbaf I can not load my preferences shortcuts keyboards. To take them into account I must reload e. I came across this error, "e_config_binding_key_match" uses "mouse_bindings" instead of "key_bindings". Unfortunately it does not change anything to my...
Summary: ...problem.

Reviewers: zmike!, devilhorns, raster

Reviewed By: raster

Subscribers: raster, cedric

Tags: #enlightenment-git

Differential Revision: https://phab.enlightenment.org/D6997
2020-05-14 11:28:02 +01:00
Thierry HUCHARD 48b555b204 Fixed menu crashes in the systray.
Reviewers: devilhorns

Subscribers: cedric, zmike

Tags: #enlightenment-git

Differential Revision: https://phab.enlightenment.org/D11502
2020-05-14 11:26:11 +01:00
thierry1970 19395ae1fe Fix : Check that the file has a protocol.
Reviewers: devilhorns

Subscribers: raster, cedric, zmike

Tags: #enlightenment-git

Differential Revision: https://phab.enlightenment.org/D10410
2020-05-14 11:23:04 +01:00
Ross Vandegrift 765d8e1d3d Don't set x-scheme-handler/file for File manager app.
Summary:
File managers should handle inode/directory, not
x-scheme-handler/file.  Registering x-scheme-handler/file means that the file
manager app should open all "file://" URLs.  And because of some details of the
FDO spec, scheme handlers override mime-type handlers.  As a result, other
desktop environments can start using a file manager to open all local files.

fixes T7521

Reviewers: devilhorns, raster

Reviewed By: raster

Subscribers: cedric, zmike

Tags: #enlightenment-git

Maniphest Tasks: T7521

Differential Revision: https://phab.enlightenment.org/D10244
2020-05-14 11:23:04 +01:00
Michael Bouchaud (yoz) f4c1ba959e e_client_volume: Update the e_client frame object on sink del event
Reviewers: raster, devilhorns

Subscribers: cedric, zmike

Tags: #enlightenment-git

Differential Revision: https://phab.enlightenment.org/D8928
2020-05-14 11:23:04 +01:00
Elyes HAOUAS 7071faca6c e_mmx: & evry: Remove unneeded white spaces
Remove unnecessary white spaces

Differential Revision: https://phab.enlightenment.org/D11779
2020-05-14 12:17:49 +02:00
Elyes HAOUAS 153f479d3f tree-wide: fix typos all over the place
Fix some typos

Differential Revision: https://phab.enlightenment.org/D11778
2020-05-14 12:04:51 +02:00
Carsten Haitzler 9cb83899b4 gadcon - defer resize handling in a job to speed up startup 2020-05-12 14:47:13 +01:00
Carsten Haitzler 306632a21c e menus - dont double unref/free a menu
e_menu_item_submenu_set() already unrefs the previous submenu...
2020-05-11 11:14:53 +01:00
Carsten Haitzler a310999640 shelf - debug printf remove 2020-05-11 11:01:44 +01:00
Carsten Haitzler 811e4240b6 shelf - fix off-by one added in previous fix to invisible shelf 2020-05-08 11:55:05 +01:00
Carsten Haitzler 01f710335a e order - do null check for path and return before alloc of obj
fix coverity CID 1428757
2020-05-07 17:33:08 +01:00
Carsten Haitzler e3b909538c shelf content change handle - only show again if hidden bc its a shelf 2020-05-05 12:45:16 +01:00
Carsten Haitzler 65d7830aae gadcon config - show shelf again if hidden on content del 2020-05-04 22:33:42 +01:00
Carsten Haitzler 83369e331a whitespace fix 2020-05-04 21:44:33 +01:00
Carsten Haitzler 73a754a411 shelf - fixup initial layout with workaround fixup
this is complicated ... but a confluence of zoomap original geom vs
transformed geom etc. ... things go wrong. this does a fixup to ensure
they go right...

@fix
2020-05-04 21:42:32 +01:00
Carsten Haitzler 8489a96a23 rememebers - make relative to zone useful geom for diff screen setup
if on some screens you have shelves eating up useful geometry then
window position can be off/wrong. this fixes this to use the zone
useful geom as the baseline.

@fix
2020-05-04 15:47:35 +01:00
Carsten Haitzler ead3991e3f e order - bring back handling desktop files in dirs as well as .order 2020-05-03 19:41:26 +01:00
Carsten Haitzler 9d289d73c1 0.24 - prepare dotting i's and crossing t's for 0.24 alpha 1 2020-05-02 16:15:30 +01:00
Carsten Haitzler 33dfe6899c menus - ensure submenus deacivate when parent does 2020-05-02 15:20:51 +01:00
Carsten Haitzler bab2b503f6 setuid setup - move to single shared file to stop cnp of code 2020-05-01 18:13:23 +01:00
Carsten Haitzler 48bcb8d0b3 e comp - shape rects - handle logic hol where num > 0 but rects is null
don't fall in this hole and crash...
2020-05-01 15:12:16 +01:00
Carsten Haitzler 81d8a1351d efm - upgrade thumbs to 256x256 2020-05-01 14:00:50 +01:00
Carsten Haitzler d428726382 comp - commented out debug for later use 2020-05-01 14:00:50 +01:00
Carsten Haitzler 38f9b6861f menus - allow them on fullscreen windows if they are not override 2020-04-30 00:45:21 +01:00
Carsten Haitzler 2ae006cfbd e system - spew out unique exit codes we can then show dialogs for
tell the user all the possible exit reason we know about for
enlightenment_system.
2020-04-29 22:14:15 +01:00
Carsten Haitzler a999bdcdf3 e sys - dont faade backlight on logout or exit 2020-04-29 22:11:49 +01:00
Christopher Michael 194f1c77b5 e_system_main: Fix resource leak
Coverity reports a leak here because we are not closing the previously
opened file. Fix that.

fixes CID1427985
2020-04-28 11:31:24 -04:00
Carsten Haitzler 8157253032 e - rememebr - fix resolution change re-shuffle for remembers
this kind of broke along the way. re-fix it to work again.

@fix
2020-04-25 00:16:45 +01:00
Carsten Haitzler 3d413eea68 fix menus to jump content onto screen better without side-effects
fixes T8680

@fix
2020-04-24 18:58:45 +01:00
Carsten Haitzler ffa60c9345 e bg - make anim gifs work again 2020-04-24 12:25:09 +01:00
Carsten Haitzler 5852c17c2e e bg - fix blurred non-edj wallpapers 2020-04-24 12:21:18 +01:00
Carsten Haitzler 7227173169 e comp x - debug and correct mask handling for configure requests 2020-04-23 17:00:21 +01:00
Carsten Haitzler 91c003100e e system - allow the per system permit/deny rules to work 2020-04-23 13:43:45 +01:00
Carsten Haitzler 3d490704ca e system - check chdir return
chdir to / will never fail... it's the root dir.. but let's make
coverity happy.

fix CID 1425454
2020-04-23 01:05:00 +01:00
Carsten Haitzler 273ec41687 e actions - handle params not being provided by user bindings
fix CID 1425456
2020-04-23 01:00:10 +01:00
Carsten Haitzler 089051af9e e system main - check getgrid return like elsewhere to maake cov happy
fix CID 1425457
2020-04-23 00:54:35 +01:00
Carsten Haitzler 21ec506dfd randr - provide dialog telling the user they have no screens
this shouldn't be a state to find yourself in... so let the user know
they are in that broken state with a dialog.
2020-04-22 21:01:38 +01:00
Carsten Haitzler 2b452e5db1 e - avoid segv's when zero screens are configured
at least backlight won't be applied now...
2020-04-22 20:46:59 +01:00
Carsten Haitzler d8130a741c e sys storage - disable it effectively by failing all devices
all devices will fail the check for now as i have no filter to only
check for block + removable devices etc.

fixes T8672
2020-04-22 14:53:25 +01:00
Carsten Haitzler 800ff4e24f e sys store - unmount verify its root and right username
also check for relative paths, shell metachars etc.

fixes T8671
2020-04-22 14:40:59 +01:00
Carsten Haitzler dfed5c2718 e sys storage - also address media dirs to have to be user named
only allow media dirs to be /media/username/xxx ...

fixes T8672
2020-04-22 14:27:21 +01:00
Carsten Haitzler 0c79c6317b e sys store - make it all root owned for meda mount dirs
fixes T8670
2020-04-22 14:11:00 +01:00
Carsten Haitzler 027095b68e e system - use ERR - its not the eina log - it's already a custom one
i already made ERR do fprintf to stderr... so use it :)
2020-04-22 13:44:01 +01:00
Carsten Haitzler fc6c423a9f e system main - fix system.conf parsing to parse all of it
forgot my for loop.. :)

fixes T8675
2020-04-22 13:42:32 +01:00
Carsten Haitzler 2e75a9410e e sys man - double check root homedir to be paranoid 2020-04-22 13:15:08 +01:00
Carsten Haitzler ac37da4167 e sys inout - abort on messages more than 1m in size
i never see a need for messages more than 1m in size so lets just
abort on them to limit abuse

fixes T8677
2020-04-22 13:00:55 +01:00
Carsten Haitzler 5fb2fccd70 e sys main - double check return from getpwent homedir 2020-04-22 12:37:51 +01:00
Carsten Haitzler d42605f5c0 e sys main - change cwd to avoid loading .so's in ./
fixes T8676
2020-04-22 12:35:32 +01:00
Carsten Haitzler fc26d91ac0 e sys l2ping - handle null params
fixes T8674
2020-04-22 12:25:36 +01:00
Carsten Haitzler 6926d1d338 e sys l2ping - limit devv string scanf size to buffer size
fixes T8673
2020-04-22 12:20:54 +01:00
Alastair Poole d0b2f3db0c e_system: When setuid, set home also.
This ensures we have a matching $HOME when using setuid, without
which can potentially cause issues in eina_vpath on some
systems (FreeBSD as example).
2020-04-21 15:56:26 +01:00
Carsten Haitzler bd97c74492 e alert - in case of crash use e system in new alert mode
this forces all ddc/backlight devices to max when discovered so you
can always see the alert.
2020-04-21 03:01:54 +01:00
Carsten Haitzler 5d6424e3bc backlight - if bl devices not there yet for a zone then fix them later
if bl devices added later - sync them up to the desired backlight leave
when that happens and ensure we store the desired level...l
2020-04-21 01:35:57 +01:00
Christopher Michael 77f8008334 e_pixmap: Missed one on that variable change 2020-04-20 18:55:51 -04:00
Christopher Michael e365138a2b e_pixmap: No need for this variable here
We only ever used this var Once in this func...
2020-04-20 18:52:08 -04:00
Christopher Michael 7c678e5762 e_pixmap: Final formatting
This code is now readable in a terminal...yay !! :)
2020-04-20 18:51:57 -04:00
Christopher Michael acf622b31b e_comp_wl: Remove EINA_UNUSED from used parameter
'client' is potentially used here if we have an error
2020-04-20 11:58:36 -04:00
Christopher Michael b7ecc19c61 e_comp_object: Minor formatting fix 2020-04-20 11:58:36 -04:00
Carsten Haitzler fee794af29 comp - handle possible case where we're grabbed - ungrab first 2020-04-19 23:52:34 +01:00
Carsten Haitzler 1d7adf0626 comp - blackwin - only use compositor size and not 32k x 32k 2020-04-19 23:38:04 +01:00
Carsten Haitzler e66af58795 e - restarts - if theme supports make it totally seamless
if theme doesn't support, fade-in will not happen (it'll just appear),
but if it does... e will fade to black for a restart, then fade back
in nice and cleanly.
2020-04-19 23:14:35 +01:00
Carsten Haitzler 24524001c4 e - restart - fix restoring of visible virtual desktop
e now (in x mode) will restore virtual desktop. not in wl at this
stage as i think i need to work on a proper serialised sate file...
2020-04-19 20:17:19 +01:00
Carsten Haitzler 4ff2b3e4c7 e main - remove unused env vbar stuff since we dont exec ourselves 2020-04-19 19:10:50 +01:00
Carsten Haitzler 97d98c9beb desklock - remove commented out getenv for locked state 2020-04-19 19:02:30 +01:00
Carsten Haitzler 6d8b24aef5 e - profile send to efl wins - fall back to getting ellm profile
use elm profile THEN .. if that fails use standard.
2020-04-19 13:44:32 +01:00
Carsten Haitzler b88b7bd1c4 e profile send - add debug to let you know what profile e is sending app 2020-04-19 12:36:59 +01:00
Carsten Haitzler 2ccfec3dad e ckpasswd - handle read errors on stdin
error path - not going to be a problem but in theory... it's there.

fix CID 1425211
2020-04-19 01:58:44 +01:00
Carsten Haitzler 23493550b2 wp gen - remove unused var assignments
these ren't used, so

fix CID 1425228 1425225
2020-04-19 01:48:28 +01:00
Carsten Haitzler d5d53a0e96 wl - handle logicaly dead code by doing the most logical thing
it would seem it wants to send it being allowed if it has handled the
case, so get rid of logically dead coe and make it not dead...

fix CID 1403932
2020-04-19 01:45:10 +01:00
Carsten Haitzler 3d6597d3ec comp wl - add comment to indicate args are in the right orer...
clarify CID 1403953
2020-04-19 01:33:06 +01:00
Carsten Haitzler f4c49a071f e auth - also use wrapped memory zeroing in polkit and normal auth
fix CID 1425207
2020-04-19 01:17:39 +01:00
Carsten Haitzler 8f019a4ef7 comp wl - fix sync with dmabuf code to not have early return
coverity pointed out dead code - code wss actually wrong. it'd have
skippedlinear on older proto

fix CID 1425218
2020-04-19 00:57:43 +01:00
Carsten Haitzler 3b15f1bb8f e win - fix dead code
fi CID 1425219
2020-04-19 00:50:11 +01:00
Carsten Haitzler f1e899fee0 e system ddc - handle error case of alloc fail and dont deref null
fix CID 1425220
2020-04-19 00:48:07 +01:00
Carsten Haitzler 8931a333eb e system - handle /dev/null not opening
fix CID 1425222
2020-04-19 00:39:51 +01:00
Carsten Haitzler f9454fcb65 e win - remove logically dead code
fix CID 1425227
2020-04-19 00:32:51 +01:00
Carsten Haitzler 65f9b94d2b wp import dialog - fix string leak in error case
fix CID 1425206
2020-04-19 00:11:56 +01:00
Carsten Haitzler 4749e1e065 backlight - fix string ptr leak
fix CID 1425215
2020-04-19 00:06:08 +01:00
Carsten Haitzler a6a10d405d e wp gen tool -fix theoretical leak on tool exit
theoretical leak - but not really as porcess exits anyway

fix CID 1425217
2020-04-18 23:31:11 +01:00
Carsten Haitzler 5e0bb63118 e system storage - fix double free found by coverity
fix CID 1425224
2020-04-18 23:19:54 +01:00
maxerba cac4c69f74 Fixed error message's lines stick each other 2020-04-18 09:54:14 +02:00
Christopher Michael d37ffa3599 e_comp_wl_dmabuf: Fix another formatting snafu
NB: No functional changes
2020-04-17 16:21:50 -04:00
Alastair Poole 909cb2be30 e_shelf: Improve auto hide behaviour.
Improve auto hide behaviour. Allow the user to re-enter an
auto-hiding shelf as many times as he/she likes. This fixes the
issue where hovering back onto such a configured shelf causes
the shelf to hide and then animate.

This needs to move to edje. As per the TODO task.
2020-04-17 21:18:41 +01:00
Christopher Michael 2e14660bec e_comp_wl_dmabuf: Fix minor snafu from formatting patch 2020-04-17 16:15:14 -04:00
Christopher Michael dc013b8626 e_comp_wl_dmabuf: Format this file properly
NB: No functional changes (yet), just formatting to make this code
remotely readable.
2020-04-17 16:12:55 -04:00
Carsten Haitzler 6ca000a257 only define beta api defines if not defined in e.h 2020-04-17 20:20:50 +01:00
Carsten Haitzler bcd612e78d revert last focus fixes - they both end up worse than before.
Revert "fix spurious pointer jumps due to previous commit bugfix"
This reverts commit 550de9a680.
Revert "focus - fix emacs buffer switch focus set reported by felipe"
This reverts commit 690ab94c06.
2020-04-17 19:02:23 +01:00
Carsten Haitzler 550de9a680 fix spurious pointer jumps due to previous commit bugfix
690ab94c06 fixed one bug and added
another - this fixes the other spurious pointer warps.
2020-04-17 18:50:13 +01:00
Carsten Haitzler e07e56036a e - stop trying to fixup xdg runtime dir env var - leave it as is
so it's consistently broken .. or not. os/distro should just set this
for login sessions.
2020-04-16 13:09:04 +01:00
Carsten Haitzler 690ab94c06 focus - fix emacs buffer switch focus set reported by felipe
emacs window (not in terminal). now in one:
ctrl+x 5 2 <- open new buffer

now we have it try switch to the other buffer:
ctrl+x 5 o

broken ... now fixed.

@fix
2020-04-15 18:04:49 +01:00
Carsten Haitzler 1edddcda66 e system rfkill - use list command for old rfkill output
some distros use an ancient rfkill without default listing of devices.
this adapts to work there.

@fix
2020-04-15 15:31:14 +01:00
Carsten Haitzler c0ee372ba1 e dnd - add timeout in case we don't get a finished from the other end
2 second timeout seems reasonable. could be less... but should avoid
hangs.
2020-04-14 19:30:02 +01:00
Alastair Poole f7654e7681 e_entry_dialog: Fix entry sizing.
Fixes "Add shelf" and "Rename shelf"...
2020-04-13 14:06:09 +01:00
Carsten Haitzler 2f52f093b6 simplify stacking rules to be a bit dumber so stacking works better
fixes T8652
2020-04-12 16:52:40 +01:00
Carsten Haitzler 42100a1ae7 e - fix fullscreen state revert on focusing of another window if child
check the newly focused window is not part of a parent tree back to a
fullscreen window e is considering unfullscreening on loss of focus.

fixes T8651

@fix
2020-04-11 23:11:33 +01:00
Simon Tischer 71a67823c9 shelf settings - sizing/align optimizations
make the dialog resizeable
the position tab is not the beste

Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11683
2020-04-11 13:05:59 -04:00
Carsten Haitzler b5a6635137 gad bar - make right menu items more obvious and simple 2020-04-08 10:55:31 +01:00
Carsten Haitzler b5fa86e7f5 e system - disable singleton mode code - fewer pluses than minuses 2020-04-08 09:39:23 +01:00
Alastair Poole 48f9529fbd filepreview: Fix aspect ratio of audio preview.
Artwork from an icon. Previously the image was squashed.
2020-04-06 11:52:01 +01:00
Carsten Haitzler 54847302cc printf-- 2020-04-01 20:47:42 +01:00
Carsten Haitzler 64f87877a6 fix pointer offset fpor older themes
fixes T8622

so due rto optimizations in edje it no longer moves/resizes invsible
parts, so swallow a rect and it wont have moved if it is not visible
thus tracking its geometry by getting the geometry of the swallowed
part only works if its visible, so get the part geom from edje instead
which has to give the calculated geom.
2020-04-01 20:12:15 +01:00
Mike Blumenkrantz a08304fdd0 update gadget runner smart events to stable api
the legacy events here are no longer emitted

fix T8633
2020-03-19 10:56:10 -04:00
Christopher Michael d85d0194a9 e_gadget: Check for valid gadget config before trying to remove it
Should fix crash when trying to add a gadget to a gadget bar

https://nopaste.linux-dev.org/?1295161
2020-03-18 13:28:52 -04:00
Mike Blumenkrantz 0cce17f3cc final gadget runner efl.canvas.wl api update 2020-03-13 12:19:39 -04:00
Mike Blumenkrantz b80ddda9fb update gadget runner to (stabilized) efl api
efl-wl -> efl-canvas-wl
2020-03-12 12:15:42 -04:00
Carsten Haitzler 4368916c2c e theme - fix leak of list of stringshares and be paranoid about strings
what if the list contains strings that are not sub-paths for some
reason? check lenghts at least are big enough...
2020-03-09 15:27:58 +00:00
Carsten Haitzler 381c12bd19 cleared widgets handle part 2 2020-03-08 12:28:09 +00:00
Carsten Haitzler b22831fb30 efm/widget robustness - handle cleared or invalid widgets 2020-03-08 12:27:02 +00:00
Carsten Haitzler 3a3257e789 personal app editor - force size up to be sanely sized for use 2020-02-18 10:55:45 +00:00
Carsten Haitzler a3ae1b0ac2 e auth - use our memclear and fill it out with modern zeroing methods
so memset_s still doesn't get detected (add a check anyway), but there
are other alternatives, so detect and use them if found
(explicit_bzero, explicit_memset) in addition to the generally
"practically works" memset ptr method we had and.. just to be extra
safe add an asm memory barrier to this fallback. also.. mlock the
passwd memory in lokker (if it doesn't work - don't worry - there is
nothing we can do, so we did our best) to avoid this memory gettign
swapped etc.
2020-02-18 10:29:43 +00:00
Carsten Haitzler 4fcd1a989c e - scale pointer by scale factor properly... 2020-02-15 15:33:02 +00:00
Carsten Haitzler d524673f96 e system ddc - add optional sleep multiplier api - new in libddc
add ability to find it at any rate...
2020-02-14 11:02:42 +00:00
Christopher Michael a8afd46a82 e_main: Remove unused variables 2020-02-13 12:13:42 -05:00
Carsten Haitzler 71cbbeff27 e start - clean up xdg runtime dir in e_start not e if created in estart 2020-02-13 16:06:44 +00:00
Carsten Haitzler eba37f40a6 backlight - on get fails, also retry a few times
so sometimes i see gets fail, especially on wakeup, so retry.
2020-02-10 08:09:47 +00:00
Carsten Haitzler 346969eb90 todo - add magnifier 2020-02-09 13:59:12 +00:00
Carsten Haitzler 559a7737a7 e sytem - dont add null hash items 2020-02-08 09:52:39 +00:00
Carsten Haitzler fcacbe8a4f ddc - work around some probe fails, missing timer handle, etc.
beating on ddc support to make it solid. dealing with some bad screens
that don't respond, a libddcutil that was doing a printf messing up
the message stream from e_system to e .... and more.
2020-02-07 19:56:01 +00:00
Carsten Haitzler d7325c3aad ddc - use return val of system to decide to usleep or not 2020-02-07 13:36:09 +00:00
Carsten Haitzler 78b73fb1a7 when backlight devices change, ensure they are restored to normal level
this ensures things like on login e setsup backlights fine - also on
monitor add/plug-in as when e's backlight init happens it may not see
all screens or devices yet.
2020-02-07 10:49:15 +00:00
Carsten Haitzler ee59cec585 ddc - add small delay after modprobe to allow module to init in bg... 2020-02-07 10:48:54 +00:00
Carsten Haitzler 1cfd1f4242 backlight - add workaround monitor wakeups silently ignoring val sets
so if monitor is buys waking up from dpms, it may not be bothering to
do what we asked... but the sets of the propety say they succeed, so
use the get at the end of a fade in run to see if we get the target
brightness within some delta and it's one of our standard brightnesses
(1.0, normal or dim) and retry a few times until we succeed or give
up. this ensures on wakupe your monitors end up at their target
brightness even with some hiccups as opposed to stay dim. not much we
can do about iffy hardware or libddcutil (not sure which is to blame)
other than do workarounds like this.

also add logging so you can see what is being asked and if it succeeds
or fails according to libddcutil.
2020-02-07 10:24:59 +00:00
Carsten Haitzler 57e8805005 ddc - fix animation blocked by slow ddc response with multi screen
just by luck the queue "play catchup" happens to have a classic
scheduling issue. one screen always wins, the other always loses as we
play catch-up in the request queue so one is starved of "scheduling
slots" while the othe rgets them all. this fixes that by moving the
entire request queue into the thread work queue in one go so they all
get an equal chance. now botjh my desktop monitors dim smoothly on
idle like my laptop... smooooooooood
2020-02-06 19:47:04 +00:00
Carsten Haitzler eab2a34ef3 backlight - add ddc support via libddcutil
This adds ddc monitor control and glues it into the backlight system.
A result of this is now backlgiht control gadgets work screen by
screen and even on desktop monitors as well as on a laptop panel. If
you now put a backlight gadget on a shelf on each screen... it will
control THAT screen's backlight.

This requires libddcutil to be installed. That will require i2c
modules (i2c-dev specifically). This means that this is likely not
going to do anything useful on bsd's... unless libddcutil happens to
work there by chance.

so install ddcutil/libddcutil. ensure it's in ld.so.conf so setuid
root processes find it (as LD_LIBRARY_PATH won't help) and enjoy your
new funcky per-screen backlight controls... :)

@feature
2020-02-06 18:41:23 +00:00
Carsten Haitzler ee393a201f e backlight - restructure to have real per screen backlight
now it really does look for the right way to control per screen and
only use the new e_system back-end to query/list devices etc. ...

this now opens the door to adding ddc support to e_system then using
it from e_backlight.

i can't test this... yet - but this means in theory the backlight
gadget will control the backlight of the screen it is on...
2020-02-01 11:29:38 +00:00
Alastair Poole 7856939596 Revert "filepreview_widget: Show "Resolution" field when appropriate."
This reverts commit 555d64d5d5.

This is more fragile than I expected, reverting :/
2020-01-25 11:37:48 +00:00
Carsten Haitzler 0329696423 menu - handle invalid access to menu if already active
asan helped find this

@fix
2020-01-24 23:01:11 +00:00
Carsten Haitzler c9efd9c23d fix events on internal windows if placed on another desk with remembers
this fixes T8584

@fix
2020-01-24 19:50:15 +00:00
Carsten Haitzler 25699c1db7 move xdg env fixup/set set after e prefix determine 2020-01-23 08:24:49 +00:00
Carsten Haitzler 3f22a0c26d e - wallpaper gen - generate multiple resolutions for wallpapers
pre-scale a bunch of resolutions for generated wallpaper files that
intersect with common resolution sizes so e will automatically load
the nearest resolution to be more efficient on load to only decode
what is needed. a bi-product is that e now has a wallapper gen
tool that is simpler than writing your own edc files... :)

@feature
2020-01-22 20:39:19 +00:00
Carsten Haitzler 7323a97f2c e client sync rendering - disable some more sync handling to improve
rendering is so much less jerky and smooth now disabling this sync
handling. something has broken over time with wit and we're better off
without...
2020-01-20 17:06:54 +00:00
Carsten Haitzler bac870bf61 malloc.h - bsd does not like me including it... 2020-01-18 01:33:21 +01:00
Carsten Haitzler 1e2d589b14 csd - fix size hint handling and sizing to not be broken
gtk and efl can use csd. we kind of were copying gtk's but we got it
wrong... in efl. and in etoo as a result. this fixes it to use
min/bas/max size as covering the whole window including the insets.

@fix
2020-01-17 22:06:14 +00:00
Carsten Haitzler 13d721cea6 efm - add printf for eject req with info 2020-01-16 23:14:29 +00:00
Carsten Haitzler 5cc02d6467 Bring back e_sys just for mount, unmount and eject
This reverts commit a43869cdc0.

I still need this for efm... i forgot... :( So bring back the bits we
need until it's no longer needed...
2020-01-16 23:13:52 +00:00
Carsten Haitzler 5ce778194d e_sys.c - remove old snprintf of enlightenment_sys cmd not used now 2020-01-16 20:21:20 +00:00
Carsten Haitzler 0308c7abce e_open - special case for dirs - if no explicit one set - use efm
enlightenment_open will use efm to show a dir unless you have explicit
config saying to use another handler for inode/directory mime types
2020-01-16 19:09:26 +00:00
Carsten Haitzler af0d44a57d mem trimming - have e trim its own memory every now and again
use malloc_trim() if it exists to do this every now and again
(idle_enterer if there isa gap > 10 sec since last clean cycle
so no added wakeups).
2020-01-16 15:33:37 +00:00
Carsten Haitzler 5b5c7c3cb3 e system - force a malloc trim regularly to keep back-end proc minimal 2020-01-16 12:09:49 +00:00
Carsten Haitzler 63ae3290fb e system - remove test tool as we can't use it anymore
it'll just be a fight between e and a cmdline tool - so no more test
tool needed. this is off the ground.
2020-01-16 11:59:12 +00:00
Carsten Haitzler 37620211e5 e restart - use new exit code 111 for restart by parent e_start 2020-01-16 10:54:20 +00:00
Carsten Haitzler 6210b12294 mtrack - declutter - remove as i'm probably the only one ot ever use it 2020-01-16 10:51:41 +00:00
Carsten Haitzler 96d920b707 eina statgen - move to using api not env var as we need new efl anyway 2020-01-16 10:51:04 +00:00
Carsten Haitzler 6373d5583b move xdg data dir fixup to e_start to esnure its set super-early
now everything e launched should agree on xdg data dir if hose os
doesn't set it (bad host os!) :)
2020-01-16 10:38:54 +00:00
Carsten Haitzler 7e47977d9a printf format macros - put them in the right places for no warnings 2020-01-15 19:06:24 +01:00
Carsten Haitzler e122b2855f e start - fix warning on unused params when ptracing 2020-01-15 19:06:24 +01:00
Carsten Haitzler 9c8661abe2 efx - valid casts to silence warnings - same enum vals by design 2020-01-15 19:06:24 +01:00
Carsten Haitzler 13e696ce46 efx - fix type return type - still same actual value (0) 2020-01-15 19:06:24 +01:00
Carsten Haitzler 0e715f89b1 e fx - cast explicitly as 2 enums have same values by design 2020-01-15 19:06:24 +01:00
Carsten Haitzler 9022620366 e_fx - explicit case as enums have same values explicitly 2020-01-15 19:06:24 +01:00
Carsten Haitzler 0f1e2862a6 e win - fix recursive symbol typo
amazing this didn't blow up before. missing e_ in front ad the macro
should have transformed this to wrap the e version of this func...
clang warning pointed this out. a real bug waiting to happen.

@fix
2020-01-15 19:06:24 +01:00
Carsten Haitzler 10c2d74a9b e system api - fix warning about buffer ptr get
binbuf buffers are universally aligned anyway...
2020-01-15 19:06:24 +01:00