8bea4f9411
check for existence BEFORE getting geom
...
SVN revision: 76744
2012-09-17 09:27:05 +00:00
7031ce46b4
fix bug where gadgets could not be dragged left on shelf at the expected level of dragging, also increase drag threshold for moving gadgets to the right
...
SVN revision: 76736
2012-09-17 07:09:21 +00:00
9ccf1d988f
don't delete gadgets when drag is done if new gadget is dropped gadget
...
SVN revision: 76735
2012-09-17 06:10:49 +00:00
4036e9a3c5
need to unlock gadcon BEFORE checking whether gadcon is still editing, otherwise we never unlock and always break shelf autohide
...
SVN revision: 76731
2012-09-17 05:26:22 +00:00
092b37f981
hmm it seems that attempting to be clever and show/hide when leaving and entering the same gadcon during a drag is at least part of the problem with ticket #1462...
...
SVN revision: 76730
2012-09-17 05:25:15 +00:00
d181a362c6
fix gadget dnd bug where repeatedly dragging gadgets around from shelf to desktop to shelf to desktop to shelf to desktop would confuse gadman and prevent it from injecting gadgets properly
...
SVN revision: 76729
2012-09-17 05:02:23 +00:00
6cf37f95bf
delete newly-created gcc here if it isn't our current gcc since we won't be using it
...
SVN revision: 76728
2012-09-17 04:44:41 +00:00
46afc57359
check null here even though it SEEMS impossible to prevent jokers from injecting bad configs
...
SVN revision: 76727
2012-09-17 04:41:09 +00:00
194dbb13a3
fix rare gadget dnd crash
...
SVN revision: 76726
2012-09-17 04:29:49 +00:00
5193de5919
finally fix moving (dragging) gadgets from a shelf to the desktop in a super hackish way that will hopefully be fixable in e18 with a complete rewrite of gadcon/gadman
...
note: this will look really bad (giant black rectangle) if you have "Use ARGB instead of shaped" checked in Engine config
SVN revision: 76543
2012-09-12 16:23:02 +00:00
8f0aa351f8
reflow some code
...
SVN revision: 76536
2012-09-12 15:02:12 +00:00
e81c385e57
break out gadcon drop handler add into separate function to make it reusable
...
SVN revision: 76516
2012-09-12 10:37:29 +00:00
4c89c8ccb1
add mechanism for deleting gadcon configs, shelf deletion now triggers gadcon deletion, fix crash when renaming shelves, prevent shelves from being renamed to the same name as another shelf, fix bug where gadcon client ordering would increase infinitely when adding/removing/redrawing gadgets
...
SVN revision: 76297
2012-09-07 11:00:25 +00:00
e0c57c8244
remove this misleading line: there is NEVER a zone here.
...
SVN revision: 76280
2012-09-07 07:08:48 +00:00
0e414444b2
add flag to gadcons to mark them as being custom gadcons, don't refresh custom gadcons completely when repopulating, fix crash which occurred when gadcon container was deleted before gadcon
...
SVN revision: 76256
2012-09-06 18:26:09 +00:00
c66c6babeb
add events for gadcon provider add/del
...
SVN revision: 76233
2012-09-06 09:28:53 +00:00
0b9f1a9c17
add new events for gadcon clients being added/removed
...
SVN revision: 76225
2012-09-06 07:40:30 +00:00
0fc873f1b9
revert gadcon event thingy, this causes a stupid gadman bug crash which takes more than 5 mins to fix
...
SVN revision: 76203
2012-09-05 16:47:16 +00:00
0a50c49958
add events for gadcon populate/unpopulate
...
SVN revision: 76199
2012-09-05 14:17:43 +00:00
4c0fa2d381
big roundup commit fixing leaky submenus
...
SVN revision: 75973
2012-09-03 08:30:39 +00:00
5c3352c57f
add function for changing a gadcon client's menu
...
SVN revision: 75971
2012-09-03 08:02:33 +00:00
Carsten Haitzler
40a67e9222
streamline gadget menu to move move item to main menu.
...
SVN revision: 75407
2012-08-18 10:54:02 +00:00
3433a78ba2
gadcon util menu thingy now sets created menu to appropriate struct members to prevent unexpected behavior
...
SVN revision: 75282
2012-08-15 06:35:02 +00:00
8da7dd34b1
probably a good idea to actually delete menus when they hide instead of just praying for it
...
indirectly fixes ticket #1287
SVN revision: 75256
2012-08-14 12:39:19 +00:00
e9cb0d2085
gadget provider list is now sorted alphabetically
...
SVN revision: 75201
2012-08-13 09:51:50 +00:00
e3e11778fa
wait till after module init is over before drawing gadgets so we can draw them all at once, also don't need to bind to frametime anymore with this
...
SVN revision: 75067
2012-08-10 07:02:02 +00:00
f8eff99bf8
Dear all.
...
I found the bug which may occurs enlightenment crash.
There is code to insert E_Gadcon pointer to custom_populate_requests list in e_gadcon_custom_new(). However, there is no code to remove deleted E_Gadcon pointer from custom_populate_requests list in e_gadcon_custom_del(). So, if the e_gadcon_custom_del() is called before calling _e_gadcon_custom_populate_idler(), then enlightenment crash may occurs while e calls _e_gadcon_custom_populate_idler() because e accesses deleted E_Gadcon pointer.
I modified this problem. Please review this patch.
Thanks.
--
Doyoun Kang
SVN revision: 75033
2012-08-09 08:25:41 +00:00
7623fa4de0
add new functions for renaming a shelf/gadcon in the process of hunting #1286
...
SVN revision: 74973
2012-08-07 10:28:28 +00:00
031fc80e2f
clean up my earlier gadcon/menu idler work to be functional, thanks to jeffdameth for pointing it out
...
SVN revision: 74786
2012-08-02 07:20:51 +00:00
71ce826982
e_gadcon_client_find now takes an optional gadcon param to speed it up where possible
...
SVN revision: 74512
2012-07-27 16:10:06 +00:00
4ffafd3313
ensure gadcon class is populated before trying to create a client for it
...
SVN revision: 74507
2012-07-27 15:30:36 +00:00
f990c4d738
greatly simplify gadcon populate idler
...
SVN revision: 74491
2012-07-27 13:18:25 +00:00
df03a272e5
remove useless checks on gcc name
...
SVN revision: 74488
2012-07-27 12:29:55 +00:00
5db9d9fb00
change gadcon waiting classes list to a hash in order to remove some strcmps
...
SVN revision: 74487
2012-07-27 12:26:41 +00:00
5a6e5ec964
make client class population gadcon-specific so we don't end up populating every gadcon site with 500 client classes if they're only used on a single shelf
...
SVN revision: 74485
2012-07-27 10:54:00 +00:00
5070653af2
add debug timing info for gadcon idler populates
...
SVN revision: 74478
2012-07-27 09:28:25 +00:00
81cbce9d96
log error and fail when attempting to register a nameless gadcon client class to prevent massive failure later
...
it is once again a good time to update
SVN revision: 74477
2012-07-27 08:46:04 +00:00
8b0c1eaefe
fix gcc populates to actually set all necessary variables and prevent config from being wiped; fixes gadman gadgets randomly disappearing and probably a lot of other unnoticed bugs
...
SVN revision: 74476
2012-07-27 08:42:16 +00:00
f08e7423f2
make gadcon class function pointers require const as they should, add new custom populate request function, consolidate gcc populate code
...
compile warnings are being cleaned up next
SVN revision: 74472
2012-07-27 08:17:32 +00:00
5389c8a964
forgot to deregister client class from populated list
...
SVN revision: 74445
2012-07-26 14:13:49 +00:00
14b109ac78
fix gadcon crashing when enabling/disabling modules
...
SVN revision: 74443
2012-07-26 13:59:41 +00:00
812abd7c1d
actually I don't know wtf I was thinking with 74438, I was clearly a misguided genius in the code that I removed in this commit; fixes adding new gadgets and also speeds up the process greatly
...
SVN revision: 74441
2012-07-26 13:00:15 +00:00
f8b1dbf2e3
add function for finding a gadcon client from its config
...
SVN revision: 74439
2012-07-26 12:41:41 +00:00
512f48014c
not sure what I was thinking here, no need to repopulate a gadcon when client class is populated
...
SVN revision: 74438
2012-07-26 12:41:01 +00:00
ec019bae91
only populate custom gadcons with the gadgets that are actually loaded in the gadcon: huge speedup
...
SVN revision: 74433
2012-07-26 11:05:39 +00:00
c2b2d7e5ad
registering a gadcon client class no longer immediately tries to populate the class; we now populate classes only when a gadget for the class is loaded to further reduce the initial loading clusterfuck
...
SVN revision: 74432
2012-07-26 10:34:40 +00:00
f66e16178c
in general, any time e_icon_object_set is used, it's wrong. e_icon doesn't handle these cases and fails in every case other than the initial _set() call.
...
SVN revision: 74209
2012-07-20 06:53:52 +00:00
42ceb58540
merge a big e17 doc patch
...
ticket #91
SVN revision: 73408
2012-07-06 10:53:22 +00:00
5950d44b2f
add resize callback for gadcon parent to properly adjust box packing objects for gadcon clients
...
also fixes pager resize in shelf
SVN revision: 73222
2012-07-03 10:44:33 +00:00
37461278bc
add e_shelf_zone_dummy_new(), e_shelf_list_all(), and e_gadcon_dummy_new() to allow for creating an object (such as a task bar) which simulates a shelf for the purpose of removing its geometry from _e_zone_useful_geometry_calc(), thus preventing windows from being placed under it
...
ticket #643
SVN revision: 72999
2012-06-28 10:59:19 +00:00
a8bfedc268
have to unlock shelf at this point or else it will never hide anymore
...
fixes ticket #1013
SVN revision: 72806
2012-06-25 13:04:13 +00:00
e1acc237ed
fix some remaining shelf autohide bugs related to shelves drawn on the container
...
SVN revision: 72804
2012-06-25 12:10:31 +00:00
251ae5f857
add e_gadcon_client_autoscroll_toggle_disabled_set() to prevent disabling autoscroll in a gadget
...
SVN revision: 72795
2012-06-25 10:46:51 +00:00
9d5f2a7c63
also ensure min size for shelf gadgets is not greater than max size
...
SVN revision: 72787
2012-06-25 08:25:07 +00:00
1c0ae4ffcb
shelf gadgets no longer tries to set min/max sizes that are larger than the shelf
...
SVN revision: 72786
2012-06-25 08:22:16 +00:00
82ae1fcaac
when a gc_init function fails, delete the config and clean up after: mainly for systray
...
SVN revision: 72564
2012-06-21 06:47:26 +00:00
Vincent Torri
c3b0637802
e17: whitespaces--
...
SVN revision: 72561
2012-06-21 06:19:43 +00:00
1a7c41f86a
formatting
...
SVN revision: 72540
2012-06-20 12:43:15 +00:00
2d0970da9a
e: warning--.
...
SVN revision: 70751
2012-05-04 02:34:56 +00:00
Carsten Haitzler
515819cdb5
make all zone matching agree on the same convention - use zone->num,
...
not zone->id. zone->id is for matching u to zinerama/xrandr
screens/outputs. e re-sorts based on highest res screens first, lower
res later.
SVN revision: 67951
2012-02-15 04:35:18 +00:00
Carsten Haitzler
2812e15939
make aspect size requests work properly with autoscroll in shelf.
...
SVN revision: 66312
2011-12-18 14:03:15 +00:00
Carsten Haitzler
a3bfd5d8bb
have tasks always set inset and autoscroll so it works right.
...
SVN revision: 65118
2011-11-13 05:47:09 +00:00
Carsten Haitzler
0b4f2529f9
overkill doing "Gadget nameofgadget in the menu. just nameofgadget
...
will do. also it wasnt translated anyway.
SVN revision: 64624
2011-11-01 22:33:38 +00:00
88f331c878
wtf, removing wrongly inserted tabs in previous commit
...
SVN revision: 64588
2011-10-31 23:26:24 +00:00
a98518a9de
E: gadcon width adjustment was entering an infinite loop if no gadget had autoscroll enabled
...
the 'need' variable had to be initialized to 0, and a break condition for the loop
also needed to be added otherwise we'd end up in an infinite loop if no gadget
had autoscroll (in which case, the need var was never modified).
SVN revision: 64587
2011-10-31 23:22:07 +00:00
Carsten Haitzler
d5247cd243
and refine new gadcon layout somemore - so much simpler now! yay!
...
SVN revision: 64556
2011-10-31 12:04:34 +00:00
Carsten Haitzler
be4202e8a6
disable resizable gadcon gadgets because we now have autoscroll expand
...
stuff working.
SVN revision: 64551
2011-10-31 10:10:17 +00:00
Carsten Haitzler
4a76470496
taskbar++!
...
one more todo item being knocked off. but there.
also no proper icon for it yet. mostly code from the old taskbar with
lots of little things fixed.
SVN revision: 64518
2011-10-30 07:36:54 +00:00
4651579f73
e17/gadcon client menu: dont restrict 'move to' when gadcon has no site restrictions
...
SVN revision: 58600
2011-04-12 20:42:19 +00:00
bbcae9589b
e17/gadcon: dont show 'move to' entries for sites to which gadgets cannot be moved
...
SVN revision: 58568
2011-04-11 20:39:42 +00:00
43c493f090
E17 - Fixup some compiler warnings
...
gadcon: Fix 'limit' may be used uninitialized.
Fix formatting in some places.
menus: Fix several variables may be used uninitialized warnings.
comp: Add UNUSED where needed.
Fix formatting in some places.
SVN revision: 58467
2011-04-08 05:31:47 +00:00
7f457f1911
e17: add option to have gadcon client settings menu in toplevel again.
...
added e_menu_item_new_relative(E_Menu, E_Menu_Item *rel) which appends
new item to rel or prepends it when rel is NULL.
changed e_gadcon_util_client_menu_append to to take only the gadget menu
and returns the new toplevel menu that should be shown by gcc
depending on the setting this is a new menu with gadget menu as submenu
or the gadet_menu with gadget menu items appended
updated e-modules-extra comes in a minute
SVN revision: 57826
2011-03-17 17:08:36 +00:00
Carsten Haitzler
d9184e351d
on free of list.. set list ptr to null tnx. :)
...
SVN revision: 55859
2011-01-05 03:14:34 +00:00
Carsten Haitzler
ab3e4d2f1b
dont access null cf in gcc.
...
SVN revision: 55827
2011-01-03 15:37:49 +00:00
71d8f97aff
Add some missing checks to make sure Gadcon Container and Gadcon
...
Clients are valid before we try using them.
SVN revision: 55789
2010-12-31 16:51:25 +00:00
565303e0f3
Modified patch.
...
From: Peter van de Werken <pwerken-e@a-eskwadraat.nl>
Only add a separator if there is something to separate.
SVN revision: 55780
2010-12-30 13:44:39 +00:00
bd9200c460
avoid two null derefs
...
SVN revision: 55712
2010-12-22 22:55:55 +00:00
6f2213cb25
convert init/shutdown to EINTERN, move some to _update().
...
Do not abuse the concept of e_*_init(), make them call-once and those
that needed multiple call are renamed to e_*_update(). To make sure
convert them to EINTERN so the symbols are not exported.
Actually I guess too much is exported as EAPI while they should be
EINTERN, but that would require manual investigation, while this patch
was basically created with sed + grep.
SVN revision: 54795
2010-11-22 15:21:32 +00:00
32a8f5160d
Fix dnd working with reference coords.
...
SVN revision: 54383
2010-11-09 21:14:38 +00:00
2a048b5005
gadcon helper functions
...
SVN revision: 54348
2010-11-08 20:11:45 +00:00
8f1e82d9f9
TODO++
...
SVN revision: 54326
2010-11-08 14:05:08 +00:00
7867b41c98
Don't allow NULL id
...
This fixes #567
SVN revision: 54243
2010-11-06 18:13:57 +00:00
dd641e9259
New categories for modules.
...
To be continued soon...
SVN revision: 53514
2010-10-17 17:33:44 +00:00
Carsten Haitzler
4dfa97df1f
menu icons.. are meant to be e_icon objects... devilhorns!
...
:)
(damned 64bit shit found it)
SVN revision: 52119
2010-09-10 04:09:00 +00:00
5a6461bcd8
Handle case where gadcon may not have the icon function for menu.
...
SVN revision: 52110
2010-09-09 22:18:00 +00:00
312da38b10
Get the Label from the gadget itself for display in the menu (rather
...
than the gadget name which is usually just a short version which would
mean less to the user).
Use the Icon from the gadget itself for display in the menu.
SVN revision: 52106
2010-09-09 20:46:24 +00:00
2f8f31fbf5
This commit will change the shelf menu completly:
...
If you have a Gadget and open the menu over it, all gadget specific options are under a separate submenu. The menu items which the Gadget sets theirself can be put on the main menu tree or on the Gadget submenu.
If you don't see a reason for this, check the ibar menu _before_ and _after_. :)
This api change broke all modules but i already fixed them all. Hope everything works... I also shortend text strings, etc, etc.
Hope you like it! :)
SVN revision: 52041
2010-09-09 14:44:21 +00:00
25113159a5
Fix common misspellings
...
Some misspellings were manually reverted since in E there are tons of .po with
phrases in other languages. Other than that all the changes in the following
files were reverted:
* src/modules/illume/dicts/English_(US).dic
* src/modules/illume-keyboard/dicts/English_(US).dic
Following misspellings were fixed:
acquited->acquitted
adres->address
adress->address
alreayd->already
aquire->acquire
arbitarily->arbitrarily
cant->can't
Capetown->Cape
carefull->careful
causalities->casualties
Celcius->Celsius
certian->certain
commandoes->commandos
considerd->considered
conveyer->conveyor
dependant->dependent
didnt->didn't
discontentment->discontent
doesnt->doesn't
everytime->every
exemple->example
existance->existence
existant->existent
existince->existence
Farenheit->Fahrenheit
forbad->forbade
funguses->fungi
guage->gauge
guerilla->guerrilla
guerillas->guerrillas
happend->happened
hasnt->hasn't
heros->heroes
inbetween->between
independant->independent
inital->initial
intrusted->entrusted
irregardless->regardless
isnt->isn't
knifes->knives
layed->laid
loosing->losing
marrage->marriage
midwifes->midwives
miniscule->minuscule
monickers->monikers
mroe->more
noone->no one
occured->occurred
omre->more
paralell->parallel
payed->paid
planed->planned
quitted->quit
quizes->quizzes
seperated->separated
seperate->separate
shoudl->should
similiar->similar
simplier->simpler
specifiying->specifying
teh->the
toke->took
torpedos->torpedoes
Tuscon->Tucson
unecessary->unnecessary
useage->usage
usefull->useful
useing->using
waht->what
wanna->want
whith->with
wich->which
withing->within
SVN revision: 52006
2010-09-08 23:59:07 +00:00
Michael BOUCHAUD
8f557cd30c
Use a const char * here, remove some warning
...
SVN revision: 51402
2010-08-19 15:18:18 +00:00
9469f5ff41
Add UNUSED.
...
Init some vars.
SVN revision: 51338
2010-08-18 20:25:13 +00:00
6638a10e20
FORMATTING
...
* Remove vim modelines:
find . -name '*.[chx]' -exec sed -i '/\/\*$/ {N;N;/ \* vim:ts/d}' \{\} \;
find . -name '*.[chx]' -exec sed -i '/\/[\*\/] *vim:/d' \{\} \;
* Remove leading blank lines:
find . -name '*.[cxh]' -exec sed -i '/./,$!d'
If you use vim, use this in your .vimrc:
set ts=8 sw=3 sts=8 expandtab cino=>5n-3f0^-2{2(0W1st0
SVN revision: 50816
2010-08-04 16:57:32 +00:00
c6a118d738
* e: remove warning due to Ecore API change.
...
SVN revision: 49833
2010-06-24 16:19:12 +00:00
d1e46e3888
Fix segfault if gadget has no zone.
...
SVN revision: 49163
2010-05-23 20:39:51 +00:00
57f2c2bd48
Set new client config geometry resolution to match current resolution
...
(better than a hard-coded value which may be incorrect).
SVN revision: 48748
2010-05-11 05:05:51 +00:00
78b294c4a8
make clang happy
...
SVN revision: 45176
2010-01-15 11:29:50 +00:00
ffaef6196d
When setting gadcon zone, record the zone id in config struct. (There was a
...
placeholder for it, but never got filled).
Fix some formatting while I am in here.
SVN revision: 44914
2010-01-05 22:06:47 +00:00
bda24a1f0d
Make clang happy
...
SVN revision: 44230
2009-12-06 19:42:41 +00:00
2a7f105194
If CLANG needs this return there, then don't create o_control until after in
...
case we do actually hit this return.
SVN revision: 43967
2009-11-25 01:10:11 +00:00
fc8c5cac0d
Add illume-indicator module to configure.ac
...
Some formatting in e_gadcon/e_shelf.
SVN revision: 43966
2009-11-25 01:02:11 +00:00
09edadd2a5
Use MENU_POP_DIRECTION_AUTO instead of DIRECTION_DOWN.
...
SVN revision: 43960
2009-11-24 21:17:18 +00:00
Mike Blumenkrantz
Carsten Haitzler
Vincent Torri
Cedric BAIL
Youness Alaoui
Hannes Janetzek
Christopher Michael
Peter van de Werken
Gustavo Sverzut Barbieri
Sebastian Dransfeld
Miculcy Brian
Lucas De Marchi
Michael BOUCHAUD