rename wayland session desktop file #61

Merged
raster merged 1 commits from rvandegrift/enlightenment:rename-wayland-session-file into master 2024-06-05 09:59:59 -07:00
Contributor

When enlightenment.desktop exists in /usr/share/xsessions and /usr/share/wayland-sessions, gdm only displays the Wayland session. Other display managers show both. It sounds like the fdo standards don't quite cover the desktop session case, so there's some interpretation going on.

GDM uses the matching names to implement fallback from Wayland -> X11 sessions in case of a crash. Different names should work everywhere.

More details at: https://gitlab.gnome.org/GNOME/gdm/-/issues/898

When `enlightenment.desktop` exists in `/usr/share/xsessions` and `/usr/share/wayland-sessions`, gdm only displays the Wayland session. Other display managers show both. It sounds like the fdo standards don't quite cover the desktop session case, so there's some interpretation going on. GDM uses the matching names to implement fallback from Wayland -> X11 sessions in case of a crash. Different names should work everywhere. More details at: https://gitlab.gnome.org/GNOME/gdm/-/issues/898
rvandegrift added 1 commit 2024-01-17 21:48:36 -08:00
61898983e9 rename wayland session desktop file
This ensures all display managers provide both the wayland and x11 sessions to
the user.
- when two different desktop files have the same desktop-id, they're merged.
- gdm uses this to implement fallback from wayland -> x11, in case of a crash.
- this behavior isn't standardized since fdo doesn't really define the desktop
  session files, so there's some variation.

Providing the files under different names should work everywhere.  This is
summarized from https://gitlab.gnome.org/GNOME/gdm/-/issues/898
First-time contributor

Approved for GDM. Use the same patch.

But i'm not sure that it works for other display managers.
To approve changes, they should be tested with

  • SDDM
  • LightDM
  • LXDM

May be stay alive both versions of file (enlightenment.desktop and enlightenment-wayland.desktop in wayland-sessions dir)?

Approved for GDM. Use the same patch. But i'm not sure that it works for other display managers. To approve changes, they should be tested with - [ ] SDDM - [ ] LightDM - [ ] LXDM May be stay alive both versions of file (enlightenment.desktop and enlightenment-wayland.desktop in wayland-sessions dir)?
Author
Contributor

Approved for GDM. Use the same patch.

But i'm not sure that it works for other display managers.
To approve changes, they should be tested with

  • SDDM
  • LightDM
  • LXDM

May be stay alive both versions of file (enlightenment.desktop and enlightenment-wayland.desktop in wayland-sessions dir)?

Since this create separate sessions, I don't see why it'd break any other display managers (they'll have two explicit sessions like GDM now). That seems right to me - since E doesn't have production-worthy wayland support, users should have to opt into it.

> Approved for GDM. Use the same patch. > > But i'm not sure that it works for other display managers. > To approve changes, they should be tested with > - [ ] SDDM > - [ ] LightDM > - [ ] LXDM > > May be stay alive both versions of file (enlightenment.desktop and enlightenment-wayland.desktop in wayland-sessions dir)? Since this create separate sessions, I don't see why it'd break any other display managers (they'll have two explicit sessions like GDM now). That seems right to me - since E doesn't have production-worthy wayland support, users should have to opt into it.
First-time contributor

Agree, i don't see either.

But we can both be wrong :)
It is better to test.

@raster, we need your guru-opinion?

Agree, i don't see either. But we can both be wrong :) It is better to test. @raster, we need your guru-opinion?
Owner

i really have no firm opinion - so we can rename the wl session

i really have no firm opinion - so we can rename the wl session
raster requested review from raster 2024-06-05 09:59:28 -07:00
raster requested review from Owners 2024-06-05 09:59:29 -07:00
raster approved these changes 2024-06-05 09:59:40 -07:00
raster merged commit e52c25c71b into master 2024-06-05 09:59:59 -07:00
raster deleted branch rename-wayland-session-file 2024-06-05 10:00:04 -07:00
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: enlightenment/enlightenment#61
No description provided.