enlightenment/enlightenment
enlightenment
/
enlightenment
10
9
Fork 12
Code Issues 24 Pull Requests 2 Projects Releases Wiki Activity

rename wayland session desktop file #61

Open
rvandegrift wants to merge 1 commits from rvandegrift/enlightenment:rename-wayland-session-file into master
pull from: rvandegrift/enlightenment:rename-wayland-session-file
merge into: enlightenment:master
Conversation 0 Commits 1 Files Changed 2 +2 -2
rvandegrift commented 2024-01-17 21:48:35 -08:00
Contributor
Copy Link

When enlightenment.desktop exists in /usr/share/xsessions and /usr/share/wayland-sessions, gdm only displays the Wayland session. Other display managers show both. It sounds like the fdo standards don't quite cover the desktop session case, so there's some interpretation going on.

GDM uses the matching names to implement fallback from Wayland -> X11 sessions in case of a crash. Different names should work everywhere.

More details at: https://gitlab.gnome.org/GNOME/gdm/-/issues/898

When `enlightenment.desktop` exists in `/usr/share/xsessions` and `/usr/share/wayland-sessions`, gdm only displays the Wayland session. Other display managers show both. It sounds like the fdo standards don't quite cover the desktop session case, so there's some interpretation going on. GDM uses the matching names to implement fallback from Wayland -> X11 sessions in case of a crash. Different names should work everywhere. More details at: https://gitlab.gnome.org/GNOME/gdm/-/issues/898
rvandegrift added 1 commit 2024-01-17 21:48:36 -08:00
61898983e9 rename wayland session desktop file 
This ensures all display managers provide both the wayland and x11 sessions to
the user.
- when two different desktop files have the same desktop-id, they're merged.
- gdm uses this to implement fallback from wayland -> x11, in case of a crash.
- this behavior isn't standardized since fdo doesn't really define the desktop
  session files, so there's some variation.

Providing the files under different names should work everywhere.  This is
summarized from https://gitlab.gnome.org/GNOME/gdm/-/issues/898
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b rvandegrift-rename-wayland-session-file master
git pull rename-wayland-session-file

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff rvandegrift-rename-wayland-session-file
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: enlightenment/enlightenment#61
No description provided.
Delete Branch "rvandegrift/enlightenment:rename-wayland-session-file"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?