enlightenment/enlightenment
enlightenment
/
enlightenment
10
9
Fork 12
Code Issues 24 Pull Requests 2 Projects Releases Wiki Activity
enlightenment/src/modules
History
Mike Blumenkrantz 362531b082 Dear all, 
I'm attaching a patch for some minor bugs in the e17.
 Please take a look at attached patch.

 01. missing E_FREE(inst)
     File: src/bin/e_exec.c: 347
     Function: _e_exec_cb_exec

 02. missing null check
     File: src/bin/e_fm.c: 10173
     Function: _e_fm_error_dialog
     I'm not sure, but all other codes always check the return
     value of e_fm2_op_registry_entry_get except here.

 03. missing free(slave)
     File: src/bin/e_fm_ipc.c: 804
     Function: _e_fm_ipc_slave_run

 04. eina_list_remove after free
     File: src/bin/e_fm/e_fm_ipc.c :1325
     Function: _e_fm_ipc_cb_fop_trash_idler

 05. invalid check for _udisks_del, it might be _udisks_chg.
     File: src/bin/e_fm/e_fm_main_udisks.c : 162
     Function: _e_fm_main_udisks_test

 06. uninitialized gx and gy values
     File: src/bin/e_gadcon_popup.c: 172
     Function: _e_gadcon_popup_position
     These could be changed in e_gadcon_client_geometry_get
     if gcc->o_base is null.

 07. unnecessary code 'evas = e_win_evas_get(dia->win)'
     File: src/bin/e_import_config_dialog.c: 456
     Function: e_import_config_dialog_show

 08. missing free(sizes)
     src/bin/e_randr_11_serialization.c: 136
     Function: _11_try_restore_configuration()

 09. unnecessary variable output_info
     File: src/bin/e_randr_12.c: 560
     Function: _output_property_change_event_cb

 10. eina_list_remove after free
     File: src/bin/e_randr_12_serialization.c : 357
     Function: _12_serialized_setup_update

 11. no check of the return value of symlink.
     File: src/bin/e_widget_fsel.c: 84
     Function: _e_wid_fsel_favorites_add

 12. no evr->var check before comparing string values
     File: src/modules/conf_applications/e_int_config_defapps.c: 432
     Function: _basic_apply

 13. missing error message or check return value of edje_file_group_exists
     File: src/modules/conf_theme/e_int_config_theme.c: 333
     Function: _open_test_cb
     Anyway, I've added e_util_dialog_show if failed. Is it okay?

 14. missing index range check
     File: src/modules/gadman/e_mod_config.c: 153
     Function: _cb_config
     It could read negative array index, because return value of
     e_widget_ilist_selected_get might be negative.

 BR,
 Gwanglim


SVN revision: 80020
 		2012-12-03 07:54:07 +00:00
..
access giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
backlight giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
battery as part of theme redo.. i get to find all the evil little "didnt 2012-12-01 04:22:05 +00:00
clock "Show Calendar" action correctly renamed to "Toggle Calendar" 2012-11-26 14:13:21 +00:00
comp oh - this was irking me - client region of comp preview was pure solid 2012-12-01 16:08:32 +00:00
conf giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
conf_applications Dear all, 2012-12-03 07:54:07 +00:00
conf_dialogs giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
conf_display giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
conf_edgebindings giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
conf_interaction giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
conf_intl ensure restart always occurs after language change 2012-11-30 20:12:46 +00:00
conf_keybindings giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
conf_menus giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
conf_paths giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
conf_performance giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
conf_randr giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
conf_shelves giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
conf_theme Dear all, 2012-12-03 07:54:07 +00:00
conf_wallpaper2 giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
conf_window_manipulation giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
conf_window_remembers giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
connman e/connman: use zone percentage for popup list 2012-12-03 03:38:58 +00:00
cpufreq updating various translations 2012-11-21 19:45:32 +00:00
dropshadow giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
everything updating various translations 2012-11-21 19:45:32 +00:00
fileman giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
fileman_opinfo giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
gadman Dear all, 2012-12-03 07:54:07 +00:00
ibar new ibar sources now try to copy default source before writing dummy source 2012-11-26 09:59:44 +00:00
ibox updating various translations 2012-11-21 19:45:32 +00:00
illume-bluetooth giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
illume-home giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
illume-home-toggle giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
illume-indicator giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
illume-kbd-toggle giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
illume-keyboard giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
illume-mode-toggle giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
illume-softkey giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
illume2 giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
layout giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
mixer E17: define htonl correctly 2012-12-01 07:19:18 +00:00
msgbus giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
notification notification module no longer has a broken and buggy gadget. bug hunters everywhere rejoice in the streets 2012-11-28 10:05:21 +00:00
pager ummm pager - when dragging a whole DESKTOP... dont set a white bg.. 2012-11-26 10:13:54 +00:00
physics giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
quickaccess updating various translations 2012-11-21 19:45:32 +00:00
shot giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
start giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
syscon giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
systray giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
tasks updating various translations 2012-11-21 19:45:32 +00:00
temperature formatting by request 2012-12-01 08:42:33 +00:00
tiling e:tiling: disabling module restores original borders and sizes 2012-12-01 13:53:51 +00:00
winlist giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
wizard e/wizard: this is a file, not dir 2012-11-30 21:46:53 +00:00
wl_drm updating various translations 2012-11-21 19:45:32 +00:00
wl_screenshot giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
wl_shell giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
xkbswitch giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile.am E17 is no longer in birthday mode :( 2012-11-30 07:04:48 +00:00
Makefile_access.am e: typo 2012-11-20 05:56:54 +00:00
Makefile_backlight.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_battery.am e: typo 2012-11-20 05:56:54 +00:00
Makefile_clock.am e: typo 2012-11-20 05:56:54 +00:00
Makefile_comp.am e: typo 2012-11-20 05:56:54 +00:00
Makefile_conf.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_conf_applications.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_conf_dialogs.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_conf_display.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_conf_edgebindings.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_conf_interaction.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_conf_intl.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_conf_keybindings.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_conf_menus.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_conf_paths.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_conf_performance.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_conf_randr.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_conf_shelves.am e: typo 2012-11-20 05:56:54 +00:00
Makefile_conf_theme.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_conf_wallpaper2.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_conf_window_manipulation.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_conf_window_remembers.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_connman.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_cpufreq.am e: typo 2012-11-20 05:56:54 +00:00
Makefile_dropshadow.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_everything.am e: typo 2012-11-20 05:56:54 +00:00
Makefile_fileman.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_fileman_opinfo.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_gadman.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_ibar.am e: typo 2012-11-20 05:56:54 +00:00
Makefile_ibox.am e: typo 2012-11-20 05:56:54 +00:00
Makefile_illume-bluetooth.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_illume-home-toggle.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_illume-home.am e: typo 2012-11-20 05:56:54 +00:00
Makefile_illume-indicator.am e: typo 2012-11-20 05:56:54 +00:00
Makefile_illume-kbd-toggle.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_illume-keyboard.am e: typo 2012-11-20 05:56:54 +00:00
Makefile_illume-mode-toggle.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_illume-softkey.am e: typo 2012-11-20 05:56:54 +00:00
Makefile_illume2.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_mixer.am e: typo 2012-11-20 05:56:54 +00:00
Makefile_msgbus.am e: typo 2012-11-20 05:56:54 +00:00
Makefile_notification.am notification module no longer has a broken and buggy gadget. bug hunters everywhere rejoice in the streets 2012-11-28 10:05:21 +00:00
Makefile_pager.am e: typo 2012-11-20 05:56:54 +00:00
Makefile_physics.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_quickaccess.am e: typo 2012-11-20 05:56:54 +00:00
Makefile_shot.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_start.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_syscon.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_systray.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_tasks.am e: typo 2012-11-20 05:56:54 +00:00
Makefile_temperature.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_tiling.am e: typo 2012-11-20 05:56:54 +00:00
Makefile_winlist.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_wizard.am giant header overhaul which removes all the stupid one line function prototype headers and e_mod_main.h headers that contain nothing but unnecessary module api prototypes 2012-11-30 14:38:34 +00:00
Makefile_xkbswitch.am e: typo 2012-11-20 05:56:54 +00:00